From: Christoph Hellwig <hch@lst.de>
To: David Miller <davem@davemloft.net>
Cc: hch@lst.de, jengelh@inai.de, idosch@idosch.org, Jason@zx2c4.com,
David.Laight@ACULAB.COM, netdev@vger.kernel.org
Subject: Re: [PATCH 4/4] net: improve the user pointer check in init_user_sockptr
Date: Wed, 29 Jul 2020 08:04:01 +0200 [thread overview]
Message-ID: <20200729060401.GD31113@lst.de> (raw)
In-Reply-To: <20200728.130111.2163106097158516623.davem@davemloft.net>
On Tue, Jul 28, 2020 at 01:01:11PM -0700, David Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Date: Tue, 28 Jul 2020 08:36:43 +0200
>
> > if (get_user(len, optlen))
> > return -EFAULT;
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> > - err = init_user_sockptr(&optval, user_optval);
> > + err = init_user_sockptr(&optval, user_optval, *optlen);
> ^^^^^^^^
>
> Hmmm?
A fixed version was already posted yesterday:
https://lore.kernel.org/netdev/20200728163836.562074-1-hch@lst.de/T/#me3e9c7b71e39b4689628ed2e61dec06705344847
next prev parent reply other threads:[~2020-07-29 6:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 6:36 [PATCH 0/4 net-next] sockptr_t fixes Christoph Hellwig
2020-07-28 6:36 ` [PATCH 1/4] netfilter: arp_tables: restore a SPDX identifier Christoph Hellwig
2020-07-28 6:36 ` [PATCH 2/4] net: make sockptr_is_null strict aliasing safe Christoph Hellwig
2020-07-28 6:36 ` [PATCH 3/4] net: remove sockptr_advance Christoph Hellwig
2020-07-28 6:36 ` [PATCH 4/4] net: improve the user pointer check in init_user_sockptr Christoph Hellwig
2020-07-28 15:47 ` Jakub Kicinski
2020-07-28 15:51 ` Christoph Hellwig
2020-07-28 18:53 ` Jakub Kicinski
2020-07-28 15:52 ` David Laight
2020-07-28 16:10 ` kernel test robot
2020-07-28 20:01 ` David Miller
2020-07-29 6:04 ` Christoph Hellwig [this message]
2020-07-28 16:38 [PATCH 0/4 net-next] sockptr_t fixes v2 Christoph Hellwig
2020-07-28 16:38 ` [PATCH 4/4] net: improve the user pointer check in init_user_sockptr Christoph Hellwig
2020-07-29 8:22 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729060401.GD31113@lst.de \
--to=hch@lst.de \
--cc=David.Laight@ACULAB.COM \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=jengelh@inai.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.