* rcu warnings in tun
@ 2020-07-30 20:16 Michael S. Tsirkin
2020-07-31 4:09 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2020-07-30 20:16 UTC (permalink / raw)
To: Jason Wang, netdev
Was building tun with sparse the other day, noticed this:
drivers/net/tun.c:3003:36: warning: incorrect type in argument 2 (different address spaces)
drivers/net/tun.c:3003:36: expected struct tun_prog [noderef] __rcu **prog_p
drivers/net/tun.c:3003:36: got struct tun_prog **prog_p
drivers/net/tun.c:3292:42: warning: incorrect type in argument 2 (different address spaces)
drivers/net/tun.c:3292:42: expected struct tun_prog **prog_p
drivers/net/tun.c:3292:42: got struct tun_prog [noderef] __rcu **
drivers/net/tun.c:3296:42: warning: incorrect type in argument 2 (different address spaces)
drivers/net/tun.c:3296:42: expected struct tun_prog **prog_p
drivers/net/tun.c:3296:42: got struct tun_prog [noderef] __rcu **
any idea when did these surface?
--
MST
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: rcu warnings in tun
2020-07-30 20:16 rcu warnings in tun Michael S. Tsirkin
@ 2020-07-31 4:09 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2020-07-31 4:09 UTC (permalink / raw)
To: Michael S. Tsirkin, netdev
On 2020/7/31 上午4:16, Michael S. Tsirkin wrote:
> drivers/net/tun.c:3003:36: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3003:36: expected struct tun_prog [noderef] __rcu **prog_p
> drivers/net/tun.c:3003:36: got struct tun_prog **prog_p
> drivers/net/tun.c:3292:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3292:42: expected struct tun_prog **prog_p
> drivers/net/tun.c:3292:42: got struct tun_prog [noderef] __rcu **
> drivers/net/tun.c:3296:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3296:42: expected struct tun_prog **prog_p
> drivers/net/tun.c:3296:42: got struct tun_prog [noderef] __rcu **
prog_p in tun_set_bpf() should be protected by RCU, will post a fix.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-31 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 20:16 rcu warnings in tun Michael S. Tsirkin
2020-07-31 4:09 ` Jason Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.