All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCH 11/17] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.
Date: Thu, 30 Jul 2020 16:58:46 -0500	[thread overview]
Message-ID: <20200730165846.527d5b66@crass-HP-ZBook-15-G2> (raw)
In-Reply-To: <20200730152958.GE39309@tanuki.pks.im>

On Thu, 30 Jul 2020 17:29:58 +0200
Patrick Steinhardt <ps@pks.im> wrote:

> On Wed, Jul 29, 2020 at 04:50:16PM -0500, development@efficientek.com
> wrote:
> > From: Glenn Washburn <development@efficientek.com>
> > 
> > This makes the creates an alignment with grub_disk_t naming of the
> > same field and is more intuitive as to how it should be used.
> > 
> > Signed-off-by: Glenn Washburn <development@efficientek.com>

...

> > --- a/grub-core/disk/luks.c
> > +++ b/grub-core/disk/luks.c
> > @@ -113,7 +113,7 @@ configure_ciphers (grub_disk_t disk, const char
> > *check_uuid, newdev->offset = grub_be_to_cpu32
> > (header.payloadOffset); newdev->source_disk = NULL;
> >    newdev->log_sector_size = LOG_SECTOR_SIZE;
> > -  newdev->total_length = grub_disk_get_size (disk) -
> > newdev->offset;
> > +  newdev->total_sectors = grub_disk_get_size (disk) -
> > newdev->offset;
> 
> Oh, yes please. Care to add in another patch that does the same for
> offset? `offset_sectors` would also be much clearer to me.

Yep, I'll add an extra patch for that in the next patch set.



  reply	other threads:[~2020-07-30 21:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 21:50 [PATCH 00/17] Fixes and improvements for cryptodisks+luks2 and a few other things development
2020-07-29 21:50 ` [PATCH 01/17] configure: Add Ubuntu dejavu font path development
2020-07-29 22:08   ` David Michael
2020-07-30 21:14     ` Mike Gilbert
2020-07-29 21:50 ` [PATCH 02/17] cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain' development
2020-07-29 21:50 ` [PATCH 03/17] cryptodisk: Incorrect calculation of start sector for grub_disk_read in grub_cryptodisk_read development
2020-07-29 21:50 ` [PATCH 04/17] cryptodisk: Add more verbosity when reading/writing cryptodisks development
2020-07-29 21:50 ` [PATCH 05/17] luks: Add support for LUKS2 in (proc)/luks_script development
2020-07-30 15:14   ` Patrick Steinhardt
2020-07-30 20:38     ` Glenn Washburn
2020-07-29 21:50 ` [PATCH 06/17] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors development
2020-07-30 15:21   ` Patrick Steinhardt
2020-07-30 21:03     ` Glenn Washburn
2020-07-29 21:50 ` [PATCH 07/17] cryptodisk, luks: Allow special processing for comparing UUIDs development
2020-07-30 15:24   ` [PATCH 07/17] cryptodisk,luks: " Patrick Steinhardt
2020-07-30 21:29     ` Glenn Washburn
2020-07-29 21:50 ` [PATCH 08/17] cryptodisk: Unregister cryptomount command when removing module development
2020-07-29 21:50 ` [PATCH 09/17] fs: When checking if a block list goes past the end of the disk, make sure the total size of the disk is in grub native sector sizes, otherwise there will be blocks at the end of the disk unaccessible by block lists development
2020-07-30 15:26   ` Patrick Steinhardt
2020-07-29 21:50 ` [PATCH 10/17] cryptodisk: Properly handle non-512 byte sized sectors development
2020-07-29 21:50 ` [PATCH 11/17] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors development
2020-07-30 15:29   ` Patrick Steinhardt
2020-07-30 21:58     ` Glenn Washburn [this message]
2020-07-29 21:50 ` [PATCH 12/17] fs: Allow number of blocks in block list to be optional, where length will be defaulted to the length of the device development
2020-07-29 21:50 ` [PATCH 13/17] loopback: Add procfs entry 'loopbacks' to output configured loopback devices development
2020-07-29 21:50 ` [PATCH 14/17] cryptodisk: Add header line to procfs entry and crypto and source device names development
2020-07-29 21:50 ` [PATCH 15/17] cryptodisk: Add a couple comments noting the usage of a couple fields in grub_cryptodisk_t as is done for grub_disk_t development
2020-07-29 21:50 ` [PATCH 16/17] luks2: Ensure that bit fields of grub_luks2_digest_t in luks2_parse_digest are initialized before returning development
2020-07-29 21:50 ` [PATCH 17/17] luks2: Fix use of incorrect index and some error messages development
2020-07-30 20:22   ` Patrick Steinhardt
2020-07-30 22:04     ` Glenn Washburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730165846.527d5b66@crass-HP-ZBook-15-G2 \
    --to=development@efficientek.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.