[linux-next:master 10807/13035] drivers/md/bcache/bcache.h:769 meta_bucket_pages() warn: subtract is higher precedence than shift

[linux-next:master 10807/13035] drivers/md/bcache/bcache.h:769 meta_bucket_pages() warn: subtract is higher precedence than shift

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2964 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Coly Li <colyli@suse.de>
CC: Jens Axboe <axboe@kernel.dk>
CC: Hannes Reinecke <hare@suse.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   7b287a5c6ac518c415a258f2aa7b1ebb25c263d2
commit: bf6af17065079d29b9bd4e59de27cc2965e6fabf [10807/13035] bcache: handle cache set verify_ondisk properly for bucket size > 8MB
:::::: branch date: 3 hours ago
:::::: commit date: 5 days ago
config: i386-randconfig-m021-20200730 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/md/bcache/bcache.h:769 meta_bucket_pages() warn: subtract is higher precedence than shift
drivers/md/bcache/bcache.h:769 meta_bucket_pages() warn: subtract is higher precedence than shift
drivers/md/bcache/bcache.h:769 meta_bucket_pages() warn: subtract is higher precedence than shift

Old smatch warnings:
drivers/md/bcache/btree.c:641 mca_reap() warn: inconsistent returns 'b->lock'.

# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bf6af17065079d29b9bd4e59de27cc2965e6fabf
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout bf6af17065079d29b9bd4e59de27cc2965e6fabf
vim +769 drivers/md/bcache/bcache.h

cafe563591446c Kent Overstreet 2013-03-23  764  
de1fafab649f94 Coly Li         2020-07-25  765  static inline unsigned int meta_bucket_pages(struct cache_sb *sb)
de1fafab649f94 Coly Li         2020-07-25  766  {
de1fafab649f94 Coly Li         2020-07-25  767  	unsigned int n, max_pages;
de1fafab649f94 Coly Li         2020-07-25  768  
de1fafab649f94 Coly Li         2020-07-25 @769  	max_pages = min_t(unsigned int,
de1fafab649f94 Coly Li         2020-07-25  770  			  __rounddown_pow_of_two(USHRT_MAX) / PAGE_SECTORS,
de1fafab649f94 Coly Li         2020-07-25  771  			  MAX_ORDER_NR_PAGES);
de1fafab649f94 Coly Li         2020-07-25  772  
de1fafab649f94 Coly Li         2020-07-25  773  	n = sb->bucket_size / PAGE_SECTORS;
de1fafab649f94 Coly Li         2020-07-25  774  	if (n > max_pages)
de1fafab649f94 Coly Li         2020-07-25  775  		n = max_pages;
de1fafab649f94 Coly Li         2020-07-25  776  
de1fafab649f94 Coly Li         2020-07-25  777  	return n;
de1fafab649f94 Coly Li         2020-07-25  778  }
de1fafab649f94 Coly Li         2020-07-25  779  

:::::: The code at line 769 was first introduced by commit
:::::: de1fafab649f944d97e45fc043b55a3a5a371744 bcache: introduce meta_bucket_pages() related helper routines

:::::: TO: Coly Li <colyli@suse.de>
:::::: CC: Jens Axboe <axboe@kernel.dk>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31071 bytes --]