[PATCHv2 1/3] netmon: added PCI, TAC, SNR value

[PATCHv2 1/3] netmon: added PCI, TAC, SNR value

[JongSeok Won]

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

To support cell type LTE, the value of PCI, TAC, SNR is added
---
 include/netmon.h |  3 +++
 src/netmon.c     | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/include/netmon.h b/include/netmon.h
index a99d6ca9..53f9d393 100644
--- a/include/netmon.h
+++ b/include/netmon.h
@@ -72,6 +72,9 @@ enum ofono_netmon_info {
 	OFONO_NETMON_INFO_EARFCN, /* int */
 	OFONO_NETMON_INFO_EBAND, /* int */
 	OFONO_NETMON_INFO_CQI, /* int */
+	OFONO_NETMON_INFO_PCI, /* int */
+	OFONO_NETMON_INFO_TAC, /* int */
+	OFONO_NETMON_INFO_SNR, /* int */
 	OFONO_NETMON_INFO_INVALID,
 };
 
diff --git a/src/netmon.c b/src/netmon.c
index 9eacb3ca..10e3ee2b 100644
--- a/src/netmon.c
+++ b/src/netmon.c
@@ -213,6 +213,27 @@ static void netmon_cell_info_dict_append(DBusMessageIter *dict,
 					intval, uint8_t, DBUS_TYPE_BYTE);
 			break;
 
+		case OFONO_NETMON_INFO_PCI:
+			intval = va_arg(*arglist, int);
+
+			CELL_INFO_DICT_APPEND(dict, "PhysicalCellId",
+					intval, uint16_t, DBUS_TYPE_UINT16);
+			break;
+
+		case OFONO_NETMON_INFO_TAC:
+			intval = va_arg(*arglist, int);
+
+			CELL_INFO_DICT_APPEND(dict, "TrackingAreaCode",
+					intval, uint16_t, DBUS_TYPE_UINT16);
+			break;
+
+		case OFONO_NETMON_INFO_SNR:
+			intval = va_arg(*arglist, int);
+
+			ofono_dbus_dict_append(dict, "SingalToNoiseRatio",
+					DBUS_TYPE_INT32, &intval);
+			break;
+
 		case OFONO_NETMON_INFO_INVALID:
 			break;
 		}
-- 
2.17.1

Re: [PATCHv2 1/3] netmon: added PCI, TAC, SNR value

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Hi JongSeok,

On 7/30/20 9:20 PM, JongSeok Won wrote:
> To support cell type LTE, the value of PCI, TAC, SNR is added
> ---
>   include/netmon.h |  3 +++
>   src/netmon.c     | 21 +++++++++++++++++++++
>   2 files changed, 24 insertions(+)
> 

All three applied, thanks.

Regards,
-Denis