Re: [PATCH v2] ASoC: Intel: boards: eve: Fix DMIC records zero

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2927 bytes --]

Hi Harsha,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on sound/for-next v5.8-rc7 next-20200730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Harsha-Priya/ASoC-Intel-boards-eve-Fix-DMIC-records-zero/20200731-012912
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c: In function 'kabylake_set_bias_level':
>> sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c:734:19: error: 'struct kbl_codec_private' has no member named 'mclk0'; did you mean 'mclk'?
     734 |  if (IS_ERR(priv->mclk0))
         |                   ^~~~~
         |                   mclk

vim +734 sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c

   723	
   724	static int kabylake_set_bias_level(struct snd_soc_card *card,
   725		struct snd_soc_dapm_context *dapm, enum snd_soc_bias_level level)
   726	{
   727		struct snd_soc_component *component = dapm->component;
   728		struct kbl_codec_private *priv = snd_soc_card_get_drvdata(card);
   729		int ret = 0;
   730	
   731		if (!component || strcmp(component->name, RT5514_DEV_NAME))
   732			return 0;
   733	
 > 734		if (IS_ERR(priv->mclk0))
   735			return 0;
   736	
   737		/*
   738		 * It's required to control mclk directly in the set_bias_level
   739		 * function for rt5514 codec or the recording function could
   740		 * break.
   741		 */
   742		switch (level) {
   743		case SND_SOC_BIAS_PREPARE:
   744			if (dapm->bias_level == SND_SOC_BIAS_ON) {
   745				dev_dbg(card->dev, "Disable mclk");
   746				clk_disable_unprepare(priv->mclk);
   747			} else {
   748				dev_dbg(card->dev, "Enable mclk");
   749				ret = clk_set_rate(priv->mclk, 24000000);
   750				if (ret) {
   751					dev_err(card->dev, "Can't set rate for mclk, err: %d\n",
   752						ret);
   753					return ret;
   754				}
   755	
   756				ret = clk_prepare_enable(priv->mclk);
   757				if (ret) {
   758					dev_err(card->dev, "Can't enable mclk, err: %d\n",
   759						ret);
   760	
   761					/* mclk is already enabled in FW */
   762					ret = 0;
   763				}
   764			}
   765			break;
   766		default:
   767			break;
   768		}
   769	
   770		return ret;
   771	}
   772	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75288 bytes --]