drivers/infiniband/hw/mlx5/mr.c:232:3-9: preceding lock on line 240

drivers/infiniband/hw/mlx5/mr.c:232:3-9: preceding lock on line 240

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3886 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Jason Gunthorpe <jgg@mellanox.com>
CC: Leon Romanovsky <leonro@mellanox.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e2c46b5762c616c249201688d3b9846627f78d2c
commit: a1d8854aae4ee19df6161a276a99d3c9c2abc4f3 RDMA/mlx5: Fix MR cache size and limit debugfs
date:   5 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 5 months ago
config: i386-randconfig-c001-20200730 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/infiniband/hw/mlx5/mr.c:232:3-9: preceding lock on line 240
   drivers/infiniband/hw/mlx5/mr.c:232:3-9: preceding lock on line 249
   drivers/infiniband/hw/mlx5/mr.c:243:5-11: preceding lock on line 240

# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a1d8854aae4ee19df6161a276a99d3c9c2abc4f3
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout a1d8854aae4ee19df6161a276a99d3c9c2abc4f3
vim +232 drivers/infiniband/hw/mlx5/mr.c

65edd0e758b8a21 Daniel Jurgens  2018-03-13  220  
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  221  static int resize_available_mrs(struct mlx5_cache_ent *ent, unsigned int target,
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  222  				bool limit_fill)
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  223  {
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  224  	int err;
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  225  
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  226  	lockdep_assert_held(&ent->lock);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  227  
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  228  	while (true) {
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  229  		if (limit_fill)
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  230  			target = ent->limit * 2;
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  231  		if (target == ent->available_mrs + ent->pending)
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10 @232  			return 0;
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  233  		if (target > ent->available_mrs + ent->pending) {
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  234  			u32 todo = target - (ent->available_mrs + ent->pending);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  235  
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  236  			spin_unlock_irq(&ent->lock);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  237  			err = add_keys(ent, todo);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  238  			if (err == -EAGAIN)
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  239  				usleep_range(3000, 5000);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10 @240  			spin_lock_irq(&ent->lock);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  241  			if (err) {
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  242  				if (err != -EAGAIN)
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  243  					return err;
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  244  			} else
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  245  				return 0;
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  246  		} else {
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  247  			spin_unlock_irq(&ent->lock);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  248  			remove_cache_mr(ent);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  249  			spin_lock_irq(&ent->lock);
a1d8854aae4ee19 Jason Gunthorpe 2020-03-10  250  		}
e126ba97dba9ede Eli Cohen       2013-07-07  251  	}
e126ba97dba9ede Eli Cohen       2013-07-07  252  }
e126ba97dba9ede Eli Cohen       2013-07-07  253  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35214 bytes --]