From: daniel@ffwll.ch To: unlisted-recipients:; (no To-header on input) Cc: daniel@ffwll.ch, David Airlie <airlied@linux.ie>, od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/2] Small cleanups to ingenic-drm driver Date: Fri, 31 Jul 2020 11:11:42 +0200 [thread overview] Message-ID: <20200731091142.GS6419@phenom.ffwll.local> (raw) In-Reply-To: <PYF7EQ.CC652MXUV2R41@crapouillou.net> On Wed, Jul 29, 2020 at 02:28:01AM +0200, Paul Cercueil wrote: > > > Le mer. 29 juil. 2020 à 0:00, daniel@ffwll.ch a écrit : > > On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: > > > Hi Paul. > > > > > > On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > > > > Here are a few cleanups to the ingenic-drm driver. > > > > - some error paths were missing and have been added; > > > > - the mode validation has been moved to the .mode_valid helper > > > callback. > > > > > > > > Cheers, > > > > -Paul > > > > > > > > Paul Cercueil (2): > > > > drm/ingenic: Handle errors of drm_atomic_get_plane_state > > > > drm/ingenic: Validate mode in a .mode_valid callback > > > > > > Both looks fine, you can add my: > > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > > > > > I assume you will apply the patches. > > > Maybe wait for Daniel to take a look, he had some feedback on where > > > to add checks. I assume this is covered by the second patch. > > > > Yeah changelog for new versions would be great, but aside from that > > bickering patch 2 lgtm now. > > This patchset is V1, I'm fixing issues you saw in the ingenic-drm driver > when reviewing a different patchset. Oh right that was pre-existing issue in which callback to use, apologies for the confusion. -Daniel > > Thanks for the review, I'll apply now. > > -Paul > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: daniel@ffwll.ch Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, od@zcrc.me, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Small cleanups to ingenic-drm driver Date: Fri, 31 Jul 2020 11:11:42 +0200 [thread overview] Message-ID: <20200731091142.GS6419@phenom.ffwll.local> (raw) In-Reply-To: <PYF7EQ.CC652MXUV2R41@crapouillou.net> On Wed, Jul 29, 2020 at 02:28:01AM +0200, Paul Cercueil wrote: > > > Le mer. 29 juil. 2020 à 0:00, daniel@ffwll.ch a écrit : > > On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: > > > Hi Paul. > > > > > > On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > > > > Here are a few cleanups to the ingenic-drm driver. > > > > - some error paths were missing and have been added; > > > > - the mode validation has been moved to the .mode_valid helper > > > callback. > > > > > > > > Cheers, > > > > -Paul > > > > > > > > Paul Cercueil (2): > > > > drm/ingenic: Handle errors of drm_atomic_get_plane_state > > > > drm/ingenic: Validate mode in a .mode_valid callback > > > > > > Both looks fine, you can add my: > > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > > > > > I assume you will apply the patches. > > > Maybe wait for Daniel to take a look, he had some feedback on where > > > to add checks. I assume this is covered by the second patch. > > > > Yeah changelog for new versions would be great, but aside from that > > bickering patch 2 lgtm now. > > This patchset is V1, I'm fixing issues you saw in the ingenic-drm driver > when reviewing a different patchset. Oh right that was pre-existing issue in which callback to use, apologies for the confusion. -Daniel > > Thanks for the review, I'll apply now. > > -Paul > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-31 9:11 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-28 15:16 [PATCH 0/2] Small cleanups to ingenic-drm driver Paul Cercueil 2020-07-28 15:16 ` Paul Cercueil 2020-07-28 15:16 ` [PATCH 1/2] drm/ingenic: Handle errors of drm_atomic_get_plane_state Paul Cercueil 2020-07-28 15:16 ` Paul Cercueil 2020-07-28 15:16 ` [PATCH 2/2] drm/ingenic: Validate mode in a .mode_valid callback Paul Cercueil 2020-07-28 15:16 ` Paul Cercueil 2020-07-28 20:17 ` [PATCH 0/2] Small cleanups to ingenic-drm driver Sam Ravnborg 2020-07-28 20:17 ` Sam Ravnborg 2020-07-28 22:00 ` daniel 2020-07-28 22:00 ` daniel 2020-07-29 0:28 ` Paul Cercueil 2020-07-29 0:28 ` Paul Cercueil 2020-07-31 9:11 ` daniel [this message] 2020-07-31 9:11 ` daniel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200731091142.GS6419@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=od@zcrc.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.