[saeed:net-mlx5 21/21] drivers/net/ethernet/mellanox/mlx5/core/health.c:210:2-8: preceding lock on line 208

[saeed:net-mlx5 21/21] drivers/net/ethernet/mellanox/mlx5/core/health.c:210:2-8: preceding lock on line 208

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3881 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Shay Drory <shayd@mellanox.com>
CC: Saeed Mahameed <saeedm@mellanox.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git net-mlx5
head:   fbe5105a9bbbd391ec318b69e9308be883af8e9c
commit: fbe5105a9bbbd391ec318b69e9308be883af8e9c [21/21] net/mlx5: Don't allow health work when device is uninitialized
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
config: i386-randconfig-c001-20200731 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/mellanox/mlx5/core/health.c:210:2-8: preceding lock on line 208

# https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?id=fbe5105a9bbbd391ec318b69e9308be883af8e9c
git remote add saeed https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
git remote update saeed
git checkout fbe5105a9bbbd391ec318b69e9308be883af8e9c
vim +210 drivers/net/ethernet/mellanox/mlx5/core/health.c

fbe5105a9bbbd3 Shay Drory        2020-07-14  197  
8812c24d28f497 Majd Dibbiny      2017-02-09  198  void mlx5_enter_error_state(struct mlx5_core_dev *dev, bool force)
89d44f0a6c732d Majd Dibbiny      2015-10-14  199  {
b6e0b6bebe0732 Shay Drory        2020-05-07  200  	bool err_detected = false;
b6e0b6bebe0732 Shay Drory        2020-05-07  201  
b6e0b6bebe0732 Shay Drory        2020-05-07  202  	/* Mark the device as fatal in order to abort FW commands */
b6e0b6bebe0732 Shay Drory        2020-05-07  203  	if ((check_fatal_sensors(dev) || force) &&
b6e0b6bebe0732 Shay Drory        2020-05-07  204  	    dev->state == MLX5_DEVICE_STATE_UP) {
b6e0b6bebe0732 Shay Drory        2020-05-07  205  		dev->state = MLX5_DEVICE_STATE_INTERNAL_ERROR;
b6e0b6bebe0732 Shay Drory        2020-05-07  206  		err_detected = true;
b6e0b6bebe0732 Shay Drory        2020-05-07  207  	}
c1d4d2e92ad670 Mohamad Haj Yahia 2016-06-30 @208  	mutex_lock(&dev->intf_state_mutex);
fbe5105a9bbbd3 Shay Drory        2020-07-14  209  	if (!mlx5_is_device_initialized(dev))
fbe5105a9bbbd3 Shay Drory        2020-07-14 @210  		return;
fbe5105a9bbbd3 Shay Drory        2020-07-14  211  
b6e0b6bebe0732 Shay Drory        2020-05-07  212  	if (!err_detected && dev->state == MLX5_DEVICE_STATE_INTERNAL_ERROR)
b6e0b6bebe0732 Shay Drory        2020-05-07  213  		goto unlock;/* a previous error is still being handled */
3e5b72ac2f2984 Feras Daoud       2018-11-12  214  	if (dev->state == MLX5_DEVICE_STATE_UNINITIALIZED) {
3e5b72ac2f2984 Feras Daoud       2018-11-12  215  		dev->state = MLX5_DEVICE_STATE_INTERNAL_ERROR;
3e5b72ac2f2984 Feras Daoud       2018-11-12  216  		goto unlock;
3e5b72ac2f2984 Feras Daoud       2018-11-12  217  	}
89d44f0a6c732d Majd Dibbiny      2015-10-14  218  
b6e0b6bebe0732 Shay Drory        2020-05-07  219  	if (check_fatal_sensors(dev) || force) { /* protected state setting */
89d44f0a6c732d Majd Dibbiny      2015-10-14  220  		dev->state = MLX5_DEVICE_STATE_INTERNAL_ERROR;
4cab346bcf74f4 Huy Nguyen        2019-02-07  221  		mlx5_cmd_flush(dev);
c1d4d2e92ad670 Mohamad Haj Yahia 2016-06-30  222  	}
89d44f0a6c732d Majd Dibbiny      2015-10-14  223  
02039fb659b366 Saeed Mahameed    2018-11-26  224  	mlx5_notifier_call_chain(dev->priv.events, MLX5_DEV_EVENT_SYS_ERROR, (void *)1);
3e5b72ac2f2984 Feras Daoud       2018-11-12  225  unlock:
3e5b72ac2f2984 Feras Daoud       2018-11-12  226  	mutex_unlock(&dev->intf_state_mutex);
3e5b72ac2f2984 Feras Daoud       2018-11-12  227  }
3e5b72ac2f2984 Feras Daoud       2018-11-12  228  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33263 bytes --]