From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: fsl-asoc-card: Remove fsl_asoc_card_set_bias_level function
Date: Sat, 1 Aug 2020 00:59:54 -0700 [thread overview]
Message-ID: <20200801075954.GA19629@Asurada-Nvidia> (raw)
In-Reply-To: <1596102422-14010-1-git-send-email-shengjiu.wang@nxp.com>
Hi,
Having two nits and one question, inline:
On Thu, Jul 30, 2020 at 05:47:02PM +0800, Shengjiu Wang wrote:
> @@ -182,6 +180,69 @@ static int fsl_asoc_card_hw_params(struct snd_pcm_substream *substream,
> cpu_priv->slot_width);
> if (ret && ret != -ENOTSUPP) {
> dev_err(dev, "failed to set TDM slot for cpu dai\n");
> + goto out;
> + }
> + }
> +
> + /* Specific configuration for PLL */
> + if (codec_priv->pll_id && codec_priv->fll_id) {
> + if (priv->sample_format == SNDRV_PCM_FORMAT_S24_LE)
> + pll_out = priv->sample_rate * 384;
> + else
> + pll_out = priv->sample_rate * 256;
> +
> + ret = snd_soc_dai_set_pll(asoc_rtd_to_codec(rtd, 0),
> + codec_priv->pll_id,
> + codec_priv->mclk_id,
> + codec_priv->mclk_freq, pll_out);
> + if (ret) {
> + dev_err(dev, "failed to start FLL: %d\n", ret);
> + goto out;
> + }
> +
> + ret = snd_soc_dai_set_sysclk(asoc_rtd_to_codec(rtd, 0),
> + codec_priv->fll_id,
> + pll_out, SND_SOC_CLOCK_IN);
Just came into my mind: do we need some protection here to prevent
PLL/SYSCLK reconfiguration if TX/RX end up with different values?
> + return 0;
> +
> +out:
> + priv->streams &= ~BIT(substream->stream);
> + return ret;
Rather than "out:" which doesn't explicitly indicate an error-out,
"fail:" would be better, following what we used in probe().
> +static int fsl_asoc_card_hw_free(struct snd_pcm_substream *substream)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct fsl_asoc_card_priv *priv = snd_soc_card_get_drvdata(rtd->card);
> + struct codec_priv *codec_priv = &priv->codec_priv;
> + struct device *dev = rtd->card->dev;
> + int ret;
> +
> + priv->streams &= ~BIT(substream->stream);
> +
> + if (!priv->streams && codec_priv->pll_id &&
> + codec_priv->fll_id) {
This now can fit into single line :)
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org,
festevam@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: fsl-asoc-card: Remove fsl_asoc_card_set_bias_level function
Date: Sat, 1 Aug 2020 00:59:54 -0700 [thread overview]
Message-ID: <20200801075954.GA19629@Asurada-Nvidia> (raw)
In-Reply-To: <1596102422-14010-1-git-send-email-shengjiu.wang@nxp.com>
Hi,
Having two nits and one question, inline:
On Thu, Jul 30, 2020 at 05:47:02PM +0800, Shengjiu Wang wrote:
> @@ -182,6 +180,69 @@ static int fsl_asoc_card_hw_params(struct snd_pcm_substream *substream,
> cpu_priv->slot_width);
> if (ret && ret != -ENOTSUPP) {
> dev_err(dev, "failed to set TDM slot for cpu dai\n");
> + goto out;
> + }
> + }
> +
> + /* Specific configuration for PLL */
> + if (codec_priv->pll_id && codec_priv->fll_id) {
> + if (priv->sample_format == SNDRV_PCM_FORMAT_S24_LE)
> + pll_out = priv->sample_rate * 384;
> + else
> + pll_out = priv->sample_rate * 256;
> +
> + ret = snd_soc_dai_set_pll(asoc_rtd_to_codec(rtd, 0),
> + codec_priv->pll_id,
> + codec_priv->mclk_id,
> + codec_priv->mclk_freq, pll_out);
> + if (ret) {
> + dev_err(dev, "failed to start FLL: %d\n", ret);
> + goto out;
> + }
> +
> + ret = snd_soc_dai_set_sysclk(asoc_rtd_to_codec(rtd, 0),
> + codec_priv->fll_id,
> + pll_out, SND_SOC_CLOCK_IN);
Just came into my mind: do we need some protection here to prevent
PLL/SYSCLK reconfiguration if TX/RX end up with different values?
> + return 0;
> +
> +out:
> + priv->streams &= ~BIT(substream->stream);
> + return ret;
Rather than "out:" which doesn't explicitly indicate an error-out,
"fail:" would be better, following what we used in probe().
> +static int fsl_asoc_card_hw_free(struct snd_pcm_substream *substream)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct fsl_asoc_card_priv *priv = snd_soc_card_get_drvdata(rtd->card);
> + struct codec_priv *codec_priv = &priv->codec_priv;
> + struct device *dev = rtd->card->dev;
> + int ret;
> +
> + priv->streams &= ~BIT(substream->stream);
> +
> + if (!priv->streams && codec_priv->pll_id &&
> + codec_priv->fll_id) {
This now can fit into single line :)
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org,
tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz,
broonie@kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: fsl-asoc-card: Remove fsl_asoc_card_set_bias_level function
Date: Sat, 1 Aug 2020 00:59:54 -0700 [thread overview]
Message-ID: <20200801075954.GA19629@Asurada-Nvidia> (raw)
In-Reply-To: <1596102422-14010-1-git-send-email-shengjiu.wang@nxp.com>
Hi,
Having two nits and one question, inline:
On Thu, Jul 30, 2020 at 05:47:02PM +0800, Shengjiu Wang wrote:
> @@ -182,6 +180,69 @@ static int fsl_asoc_card_hw_params(struct snd_pcm_substream *substream,
> cpu_priv->slot_width);
> if (ret && ret != -ENOTSUPP) {
> dev_err(dev, "failed to set TDM slot for cpu dai\n");
> + goto out;
> + }
> + }
> +
> + /* Specific configuration for PLL */
> + if (codec_priv->pll_id && codec_priv->fll_id) {
> + if (priv->sample_format == SNDRV_PCM_FORMAT_S24_LE)
> + pll_out = priv->sample_rate * 384;
> + else
> + pll_out = priv->sample_rate * 256;
> +
> + ret = snd_soc_dai_set_pll(asoc_rtd_to_codec(rtd, 0),
> + codec_priv->pll_id,
> + codec_priv->mclk_id,
> + codec_priv->mclk_freq, pll_out);
> + if (ret) {
> + dev_err(dev, "failed to start FLL: %d\n", ret);
> + goto out;
> + }
> +
> + ret = snd_soc_dai_set_sysclk(asoc_rtd_to_codec(rtd, 0),
> + codec_priv->fll_id,
> + pll_out, SND_SOC_CLOCK_IN);
Just came into my mind: do we need some protection here to prevent
PLL/SYSCLK reconfiguration if TX/RX end up with different values?
> + return 0;
> +
> +out:
> + priv->streams &= ~BIT(substream->stream);
> + return ret;
Rather than "out:" which doesn't explicitly indicate an error-out,
"fail:" would be better, following what we used in probe().
> +static int fsl_asoc_card_hw_free(struct snd_pcm_substream *substream)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct fsl_asoc_card_priv *priv = snd_soc_card_get_drvdata(rtd->card);
> + struct codec_priv *codec_priv = &priv->codec_priv;
> + struct device *dev = rtd->card->dev;
> + int ret;
> +
> + priv->streams &= ~BIT(substream->stream);
> +
> + if (!priv->streams && codec_priv->pll_id &&
> + codec_priv->fll_id) {
This now can fit into single line :)
next prev parent reply other threads:[~2020-08-01 8:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 9:47 [PATCH v2] ASoC: fsl-asoc-card: Remove fsl_asoc_card_set_bias_level function Shengjiu Wang
2020-08-01 7:59 ` Nicolin Chen [this message]
2020-08-01 7:59 ` Nicolin Chen
2020-08-01 7:59 ` Nicolin Chen
2020-08-02 2:22 ` Shengjiu Wang
2020-08-02 2:22 ` Shengjiu Wang
2020-08-02 6:43 ` Nicolin Chen
2020-08-02 6:43 ` Nicolin Chen
2020-08-03 1:28 ` Shengjiu Wang
2020-08-03 1:28 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200801075954.GA19629@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.