All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Sathishkumar Muruganandam <murugana@codeaurora.org>
Cc: stable@vger.kernel.org, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org,
	Abhishek Ambure <aambure@codeaurora.org>,
	Balaji Pothunoori <bpothuno@codeaurora.org>,
	Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] ath10k: enable transmit data ack RSSI for QCA9884
Date: Sat, 1 Aug 2020 12:35:09 +0200	[thread overview]
Message-ID: <20200801103509.GB3046974@kroah.com> (raw)
In-Reply-To: <20200731094416.5172-1-murugana@codeaurora.org>

On Fri, Jul 31, 2020 at 03:14:16PM +0530, Sathishkumar Muruganandam wrote:
> From: Abhishek Ambure <aambure@codeaurora.org>
> 
> commit cc78dc3b790619aa05f22a86a9152986bd73698c upstream.
> 
> This commit fixes the regression caused by
> commit 6ddc3860a566 ("ath10k: add support for ack rssi value of data tx packets")
> in linux-5.4.y branch.
> 
> ath10k_is_rssi_enable() always returns 0 for QCA9984 and this will cause
> the ppdu_info_offset to hold invalid value in ath10k_htt_rx_tx_compl_ind().
> 
> This leads to CE corruption for HTC endpoints to cause WMI command failures
> with insufficient HTC credits. Below warnings are seen due to beacon
> command failure in QCA9984.
> 
> [  675.939638] ath10k_pci 0000:03:00.0: SWBA overrun on vdev 0, skipped old beacon
> [  675.947828] ath10k_pci 0000:04:00.0: SWBA overrun on vdev 1, skipped old beacon
> 
> Tested HW: QCA9984
> Tested FW: 10.4-3.10-00047
> Tested Kernel version: 5.4.22
> 
> Fixes: 6ddc3860a566 ("ath10k: add support for ack rssi value of data tx packets")
> Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
> Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org>
> [kvalo@codeaurora.org: improve commit log]
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath10k/hw.c | 1 +
>  1 file changed, 1 insertion(+)

Now queued up, thanks.

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Sathishkumar Muruganandam <murugana@codeaurora.org>
Cc: Balaji Pothunoori <bpothuno@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Abhishek Ambure <aambure@codeaurora.org>,
	stable@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] ath10k: enable transmit data ack RSSI for QCA9884
Date: Sat, 1 Aug 2020 12:35:09 +0200	[thread overview]
Message-ID: <20200801103509.GB3046974@kroah.com> (raw)
In-Reply-To: <20200731094416.5172-1-murugana@codeaurora.org>

On Fri, Jul 31, 2020 at 03:14:16PM +0530, Sathishkumar Muruganandam wrote:
> From: Abhishek Ambure <aambure@codeaurora.org>
> 
> commit cc78dc3b790619aa05f22a86a9152986bd73698c upstream.
> 
> This commit fixes the regression caused by
> commit 6ddc3860a566 ("ath10k: add support for ack rssi value of data tx packets")
> in linux-5.4.y branch.
> 
> ath10k_is_rssi_enable() always returns 0 for QCA9984 and this will cause
> the ppdu_info_offset to hold invalid value in ath10k_htt_rx_tx_compl_ind().
> 
> This leads to CE corruption for HTC endpoints to cause WMI command failures
> with insufficient HTC credits. Below warnings are seen due to beacon
> command failure in QCA9984.
> 
> [  675.939638] ath10k_pci 0000:03:00.0: SWBA overrun on vdev 0, skipped old beacon
> [  675.947828] ath10k_pci 0000:04:00.0: SWBA overrun on vdev 1, skipped old beacon
> 
> Tested HW: QCA9984
> Tested FW: 10.4-3.10-00047
> Tested Kernel version: 5.4.22
> 
> Fixes: 6ddc3860a566 ("ath10k: add support for ack rssi value of data tx packets")
> Signed-off-by: Abhishek Ambure <aambure@codeaurora.org>
> Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org>
> [kvalo@codeaurora.org: improve commit log]
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath10k/hw.c | 1 +
>  1 file changed, 1 insertion(+)

Now queued up, thanks.

greg k-h

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2020-08-01 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  9:44 [PATCH] ath10k: enable transmit data ack RSSI for QCA9884 Sathishkumar Muruganandam
2020-07-31  9:44 ` Sathishkumar Muruganandam
2020-08-01 10:35 ` Greg KH [this message]
2020-08-01 10:35   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200801103509.GB3046974@kroah.com \
    --to=greg@kroah.com \
    --cc=aambure@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=bpothuno@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=murugana@codeaurora.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.