All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jules Irenge <jbi.octave@gmail.com>,
	Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
	linux-audit@redhat.com (moderated list:AUDIT SUBSYSTEM)
Subject: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid
Date: Sat,  1 Aug 2020 19:46:01 +0100	[thread overview]
Message-ID: <20200801184603.310769-3-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200801184603.310769-1-jbi.octave@gmail.com>

Checkpatch tool reports an error at variable audit_sig_sid declaration

"ERROR: do not initialise globals to 0"

To fix this, the global variable has been uninitialized.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 kernel/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 8c201f414226..7b1a38a211a9 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -125,7 +125,7 @@ static u32	audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;
 /* The identity of the user shutting down the audit system. */
 kuid_t		audit_sig_uid = INVALID_UID;
 pid_t		audit_sig_pid = -1;
-u32		audit_sig_sid = 0;
+u32		audit_sig_sid;
 
 /* Records can be lost in several ways:
    0) [suppressed in audit_alloc]
-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jules Irenge <jbi.octave@gmail.com>,
	"moderated list:AUDIT SUBSYSTEM" <linux-audit@redhat.com>
Subject: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid
Date: Sat,  1 Aug 2020 19:46:01 +0100	[thread overview]
Message-ID: <20200801184603.310769-3-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200801184603.310769-1-jbi.octave@gmail.com>

Checkpatch tool reports an error at variable audit_sig_sid declaration

"ERROR: do not initialise globals to 0"

To fix this, the global variable has been uninitialized.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 kernel/audit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 8c201f414226..7b1a38a211a9 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -125,7 +125,7 @@ static u32	audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;
 /* The identity of the user shutting down the audit system. */
 kuid_t		audit_sig_uid = INVALID_UID;
 pid_t		audit_sig_pid = -1;
-u32		audit_sig_sid = 0;
+u32		audit_sig_sid;
 
 /* Records can be lost in several ways:
    0) [suppressed in audit_alloc]
-- 
2.26.2

--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit


  parent reply	other threads:[~2020-08-01 18:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0/4>
2020-03-30  1:24 ` [PATCH v2 0/4] Coccinelle cleanups Jules Irenge
2020-03-30  1:24   ` [PATCH v2 1/4] cpu: Remove Comparison to bool Jules Irenge
2020-03-30  1:24   ` [PATCH v2 2/4] rcu: Replace 1 by true Jules Irenge
2020-03-30 21:16     ` Paul E. McKenney
2020-03-30  1:24   ` [PATCH v2 3/4] genirq: " Jules Irenge
2020-03-30  1:24   ` [PATCH v2 4/4] locking/rtmutex: Remove Comparison to bool Jules Irenge
2020-03-30 11:21     ` Peter Zijlstra
2020-04-03 16:17       ` Jules Irenge
2020-08-01 18:45 ` [PATCH 0/4] Checkpatch tool errors clean up Jules Irenge
2020-08-01 18:46   ` [PATCH 1/4] acct: Add required space between variable and operator Jules Irenge
2020-08-01 18:46   ` Jules Irenge [this message]
2020-08-01 18:46     ` [PATCH 2/4] audit: uninitialize global variable audit_sig_sid Jules Irenge
2020-08-01 18:55     ` Joe Perches
2020-08-01 18:55       ` Joe Perches
2020-08-01 20:26       ` Paul Moore
2020-08-01 20:26         ` Paul Moore
2020-08-02 14:32       ` Jules Irenge
2020-08-02 14:32         ` Jules Irenge
2020-08-01 18:46   ` [PATCH 3/4] audit: uninitialize static variables Jules Irenge
2020-08-01 18:46     ` Jules Irenge
2020-08-01 20:21     ` Paul Moore
2020-08-01 20:21       ` Paul Moore
2020-08-01 18:46   ` [PATCH 4/4] context_tracking: " Jules Irenge
2020-08-03  9:37     ` peterz
2020-08-03 10:27       ` Jules Irenge
2020-08-01 19:07   ` [PATCH 0/4] Checkpatch tool errors clean up Joe Perches
2020-08-02 14:54     ` Jules Irenge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200801184603.310769-3-jbi.octave@gmail.com \
    --to=jbi.octave@gmail.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.