* [PATCH net] wl1251: fix always return 0 error
@ 2020-07-30 7:39 Wang Hai
2020-08-02 15:25 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-07-30 7:39 UTC (permalink / raw)
To: kvalo, davem, kuba, david.gnedt, linville, pavel, pali
Cc: linux-wireless, netdev, linux-kernel
wl1251_event_ps_report() should not always return 0 because
wl1251_ps_set_mode() may fail. Change it to return 'ret'.
Fixes: f7ad1eed4d4b ("wl1251: retry power save entry")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/net/wireless/ti/wl1251/event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/event.c b/drivers/net/wireless/ti/wl1251/event.c
index 850864dbafa1..e6d426edab56 100644
--- a/drivers/net/wireless/ti/wl1251/event.c
+++ b/drivers/net/wireless/ti/wl1251/event.c
@@ -70,7 +70,7 @@ static int wl1251_event_ps_report(struct wl1251 *wl,
break;
}
- return 0;
+ return ret;
}
static void wl1251_event_mbox_dump(struct event_mailbox *mbox)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] wl1251: fix always return 0 error
2020-07-30 7:39 [PATCH net] wl1251: fix always return 0 error Wang Hai
@ 2020-08-02 15:25 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-08-02 15:25 UTC (permalink / raw)
To: Wang Hai
Cc: davem, kuba, david.gnedt, linville, pavel, pali, linux-wireless,
netdev, linux-kernel
Wang Hai <wanghai38@huawei.com> wrote:
> wl1251_event_ps_report() should not always return 0 because
> wl1251_ps_set_mode() may fail. Change it to return 'ret'.
>
> Fixes: f7ad1eed4d4b ("wl1251: retry power save entry")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
20e6421344b5 wl1251: fix always return 0 error
--
https://patchwork.kernel.org/patch/11692427/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-02 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 7:39 [PATCH net] wl1251: fix always return 0 error Wang Hai
2020-08-02 15:25 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.