* [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
@ 2020-08-03 4:29 Marcos Paulo de Souza
2020-08-04 1:24 ` Neal Gompa
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Marcos Paulo de Souza @ 2020-08-03 4:29 UTC (permalink / raw)
To: dsterba, linux-btrfs; +Cc: Marcos Paulo de Souza
From: Marcos Paulo de Souza <mpdesouza@suse.com>
Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
btrfs-man5"), this option was never available in kernel, we can only
enable this option using usebackuproot.
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
Documentation/btrfs-man5.asciidoc | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc
index 064312ed..2edf721c 100644
--- a/Documentation/btrfs-man5.asciidoc
+++ b/Documentation/btrfs-man5.asciidoc
@@ -471,7 +471,6 @@ The tree log could contain new files/directories, these would not exist on
a mounted filesystem if the log is not replayed.
*usebackuproot*::
-*nousebackuproot*::
(since: 4.6, default: off)
+
Enable autorecovery attempts if a bad tree root is found at mount time.
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
2020-08-03 4:29 [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option Marcos Paulo de Souza
@ 2020-08-04 1:24 ` Neal Gompa
2020-08-04 2:57 ` Marcos Paulo de Souza
2020-08-04 8:12 ` Nikolay Borisov
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Neal Gompa @ 2020-08-04 1:24 UTC (permalink / raw)
To: Marcos Paulo de Souza; +Cc: David Sterba, Btrfs BTRFS, Marcos Paulo de Souza
On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza
<marcos@mpdesouza.com> wrote:
>
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
> btrfs-man5"), this option was never available in kernel, we can only
> enable this option using usebackuproot.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> ---
> Documentation/btrfs-man5.asciidoc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc
> index 064312ed..2edf721c 100644
> --- a/Documentation/btrfs-man5.asciidoc
> +++ b/Documentation/btrfs-man5.asciidoc
> @@ -471,7 +471,6 @@ The tree log could contain new files/directories, these would not exist on
> a mounted filesystem if the log is not replayed.
>
> *usebackuproot*::
> -*nousebackuproot*::
> (since: 4.6, default: off)
> +
> Enable autorecovery attempts if a bad tree root is found at mount time.
> --
> 2.27.0
>
Shouldn't this option be plumbed through instead?
--
真実はいつも一つ！/ Always, there's only one truth!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
2020-08-04 1:24 ` Neal Gompa
@ 2020-08-04 2:57 ` Marcos Paulo de Souza
2020-08-04 7:51 ` Nikolay Borisov
0 siblings, 1 reply; 7+ messages in thread
From: Marcos Paulo de Souza @ 2020-08-04 2:57 UTC (permalink / raw)
To: Neal Gompa; +Cc: David Sterba, Btrfs BTRFS, Marcos Paulo de Souza
On Mon, 2020-08-03 at 21:24 -0400, Neal Gompa wrote:
> On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza
> <marcos@mpdesouza.com> wrote:
> >
> > From: Marcos Paulo de Souza <mpdesouza@suse.com>
> >
> > Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
> > btrfs-man5"), this option was never available in kernel, we can
> only
> > enable this option using usebackuproot.
> >
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> > ---
> > Documentation/btrfs-man5.asciidoc | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/btrfs-man5.asciidoc
> b/Documentation/btrfs-man5.asciidoc
> > index 064312ed..2edf721c 100644
> > --- a/Documentation/btrfs-man5.asciidoc
> > +++ b/Documentation/btrfs-man5.asciidoc
> > @@ -471,7 +471,6 @@ The tree log could contain new
> files/directories, these would not exist on
> > a mounted filesystem if the log is not replayed.
> >
> > *usebackuproot*::
> > -*nousebackuproot*::
> > (since: 4.6, default: off)
> > +
> > Enable autorecovery attempts if a bad tree root is found at mount
> time.
> > --
> > 2.27.0
> >
>
> Shouldn't this option be plumbed through instead?
As this option is only used at mount time, I don't see why we should be
able to disable using remount for example. Am I missing something?
Thanks,
Marcos
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
2020-08-04 2:57 ` Marcos Paulo de Souza
@ 2020-08-04 7:51 ` Nikolay Borisov
0 siblings, 0 replies; 7+ messages in thread
From: Nikolay Borisov @ 2020-08-04 7:51 UTC (permalink / raw)
To: Marcos Paulo de Souza, Neal Gompa
Cc: David Sterba, Btrfs BTRFS, Marcos Paulo de Souza
On 4.08.20 г. 5:57 ч., Marcos Paulo de Souza wrote:
> On Mon, 2020-08-03 at 21:24 -0400, Neal Gompa wrote:
>> On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza
>> <marcos@mpdesouza.com> wrote:
>>>
>>> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>>>
>>> Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
>>> btrfs-man5"), this option was never available in kernel, we can
>> only
>>> enable this option using usebackuproot.
>>>
>>> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
>>> ---
>>> Documentation/btrfs-man5.asciidoc | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/Documentation/btrfs-man5.asciidoc
>> b/Documentation/btrfs-man5.asciidoc
>>> index 064312ed..2edf721c 100644
>>> --- a/Documentation/btrfs-man5.asciidoc
>>> +++ b/Documentation/btrfs-man5.asciidoc
>>> @@ -471,7 +471,6 @@ The tree log could contain new
>> files/directories, these would not exist on
>>> a mounted filesystem if the log is not replayed.
>>>
>>> *usebackuproot*::
>>> -*nousebackuproot*::
>>> (since: 4.6, default: off)
>>> +
>>> Enable autorecovery attempts if a bad tree root is found at mount
>> time.
>>> --
>>> 2.27.0
>>>
>>
>> Shouldn't this option be plumbed through instead?
>
> As this option is only used at mount time, I don't see why we should be
> able to disable using remount for example. Am I missing something?
>
The default is to not use backup roots, so there's no point in having it
as an explicit option.
> Thanks,
> Marcos
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
2020-08-03 4:29 [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option Marcos Paulo de Souza
2020-08-04 1:24 ` Neal Gompa
@ 2020-08-04 8:12 ` Nikolay Borisov
2020-08-04 11:31 ` Neal Gompa
2020-08-11 6:52 ` David Sterba
3 siblings, 0 replies; 7+ messages in thread
From: Nikolay Borisov @ 2020-08-04 8:12 UTC (permalink / raw)
To: Marcos Paulo de Souza, dsterba, linux-btrfs; +Cc: Marcos Paulo de Souza
On 3.08.20 г. 7:29 ч., Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
> btrfs-man5"), this option was never available in kernel, we can only
> enable this option using usebackuproot.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
2020-08-03 4:29 [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option Marcos Paulo de Souza
2020-08-04 1:24 ` Neal Gompa
2020-08-04 8:12 ` Nikolay Borisov
@ 2020-08-04 11:31 ` Neal Gompa
2020-08-11 6:52 ` David Sterba
3 siblings, 0 replies; 7+ messages in thread
From: Neal Gompa @ 2020-08-04 11:31 UTC (permalink / raw)
To: Marcos Paulo de Souza; +Cc: David Sterba, Btrfs BTRFS, Marcos Paulo de Souza
On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza
<marcos@mpdesouza.com> wrote:
>
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
> btrfs-man5"), this option was never available in kernel, we can only
> enable this option using usebackuproot.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> ---
> Documentation/btrfs-man5.asciidoc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/btrfs-man5.asciidoc b/Documentation/btrfs-man5.asciidoc
> index 064312ed..2edf721c 100644
> --- a/Documentation/btrfs-man5.asciidoc
> +++ b/Documentation/btrfs-man5.asciidoc
> @@ -471,7 +471,6 @@ The tree log could contain new files/directories, these would not exist on
> a mounted filesystem if the log is not replayed.
>
> *usebackuproot*::
> -*nousebackuproot*::
> (since: 4.6, default: off)
> +
> Enable autorecovery attempts if a bad tree root is found at mount time.
> --
> 2.27.0
>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
--
真実はいつも一つ！/ Always, there's only one truth!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
2020-08-03 4:29 [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option Marcos Paulo de Souza
` (2 preceding siblings ...)
2020-08-04 11:31 ` Neal Gompa
@ 2020-08-11 6:52 ` David Sterba
3 siblings, 0 replies; 7+ messages in thread
From: David Sterba @ 2020-08-11 6:52 UTC (permalink / raw)
To: Marcos Paulo de Souza; +Cc: dsterba, linux-btrfs, Marcos Paulo de Souza
On Mon, Aug 03, 2020 at 01:29:44AM -0300, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
> btrfs-man5"), this option was never available in kernel, we can only
> enable this option using usebackuproot.
>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Added to devel, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-11 6:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 4:29 [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option Marcos Paulo de Souza
2020-08-04 1:24 ` Neal Gompa
2020-08-04 2:57 ` Marcos Paulo de Souza
2020-08-04 7:51 ` Nikolay Borisov
2020-08-04 8:12 ` Nikolay Borisov
2020-08-04 11:31 ` Neal Gompa
2020-08-11 6:52 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.