* [PATCH] hwmon: axi-fan-control: remove duplicate macros
@ 2020-08-03 5:43 Alexandru Ardelean
2020-08-04 21:27 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Ardelean @ 2020-08-03 5:43 UTC (permalink / raw)
To: linux-hwmon, linux-kernel; +Cc: linux, jdelvare, nuno.sa, Alexandru Ardelean
These macros are also present in the "include/linux/fpga/adi-axi-common.h"
file which is included in this driver.
This patch removes them from the AXI Fan Control driver. No sense in having
them in 2 places.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/hwmon/axi-fan-control.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
index 38d9cdb3db1a..e3f6b03e6764 100644
--- a/drivers/hwmon/axi-fan-control.c
+++ b/drivers/hwmon/axi-fan-control.c
@@ -15,10 +15,6 @@
#include <linux/of.h>
#include <linux/platform_device.h>
-#define ADI_AXI_PCORE_VER_MAJOR(version) (((version) >> 16) & 0xff)
-#define ADI_AXI_PCORE_VER_MINOR(version) (((version) >> 8) & 0xff)
-#define ADI_AXI_PCORE_VER_PATCH(version) ((version) & 0xff)
-
/* register map */
#define ADI_REG_RSTN 0x0080
#define ADI_REG_PWM_WIDTH 0x0084
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: axi-fan-control: remove duplicate macros
2020-08-03 5:43 [PATCH] hwmon: axi-fan-control: remove duplicate macros Alexandru Ardelean
@ 2020-08-04 21:27 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2020-08-04 21:27 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-hwmon, linux-kernel, jdelvare, nuno.sa
On Mon, Aug 03, 2020 at 08:43:11AM +0300, Alexandru Ardelean wrote:
> These macros are also present in the "include/linux/fpga/adi-axi-common.h"
> file which is included in this driver.
>
> This patch removes them from the AXI Fan Control driver. No sense in having
> them in 2 places.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/axi-fan-control.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
> index 38d9cdb3db1a..e3f6b03e6764 100644
> --- a/drivers/hwmon/axi-fan-control.c
> +++ b/drivers/hwmon/axi-fan-control.c
> @@ -15,10 +15,6 @@
> #include <linux/of.h>
> #include <linux/platform_device.h>
>
> -#define ADI_AXI_PCORE_VER_MAJOR(version) (((version) >> 16) & 0xff)
> -#define ADI_AXI_PCORE_VER_MINOR(version) (((version) >> 8) & 0xff)
> -#define ADI_AXI_PCORE_VER_PATCH(version) ((version) & 0xff)
> -
> /* register map */
> #define ADI_REG_RSTN 0x0080
> #define ADI_REG_PWM_WIDTH 0x0084
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-04 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 5:43 [PATCH] hwmon: axi-fan-control: remove duplicate macros Alexandru Ardelean
2020-08-04 21:27 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.