All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] max9286: Depend on OF_GPIO
@ 2020-08-03  9:09 Sakari Ailus
  2020-08-04 15:41 ` Kieran Bingham
  0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2020-08-03  9:09 UTC (permalink / raw)
  To: linux-media; +Cc: Jacopo Mondi

The driver expects struct gpio_chip has of_node field and that field is
only there if CONFIG_OF_GPIO is defined. Fix this by changing the OF
dependency to OF_GPIO.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 48ae60a2c603..915b840f1783 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -467,7 +467,7 @@ config VIDEO_VPX3220
 config VIDEO_MAX9286
 	tristate "Maxim MAX9286 GMSL deserializer support"
 	depends on I2C && I2C_MUX
-	depends on OF
+	depends on OF_GPIO
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
 	select MEDIA_CONTROLLER
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] max9286: Depend on OF_GPIO
  2020-08-03  9:09 [PATCH 1/1] max9286: Depend on OF_GPIO Sakari Ailus
@ 2020-08-04 15:41 ` Kieran Bingham
  0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2020-08-04 15:41 UTC (permalink / raw)
  To: Sakari Ailus, linux-media; +Cc: Jacopo Mondi

Hi Sakari,

On 03/08/2020 10:09, Sakari Ailus wrote:
> The driver expects struct gpio_chip has of_node field and that field is
> only there if CONFIG_OF_GPIO is defined. Fix this by changing the OF
> dependency to OF_GPIO.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/media/i2c/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 48ae60a2c603..915b840f1783 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -467,7 +467,7 @@ config VIDEO_VPX3220
>  config VIDEO_MAX9286
>  	tristate "Maxim MAX9286 GMSL deserializer support"
>  	depends on I2C && I2C_MUX
> -	depends on OF
> +	depends on OF_GPIO
>  	select V4L2_FWNODE
>  	select VIDEO_V4L2_SUBDEV_API
>  	select MEDIA_CONTROLLER
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-04 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03  9:09 [PATCH 1/1] max9286: Depend on OF_GPIO Sakari Ailus
2020-08-04 15:41 ` Kieran Bingham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.