* [PATCH] btrfs: Remove spurious BUG_ON in btrfs_get_extent
@ 2020-08-03 9:43 Nikolay Borisov
2020-08-11 13:53 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Borisov @ 2020-08-03 9:43 UTC (permalink / raw)
To: linux-btrfs; +Cc: Nikolay Borisov
That BUG_ON cannot ever trigger because as the comment there states -
'err' is always set. Simply remove it as it brings no value.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
fs/btrfs/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 14aed0d3cb51..0df881e39f57 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6740,7 +6740,6 @@ struct extent_map *btrfs_get_extent(struct btrfs_inode *inode,
free_extent_map(em);
return ERR_PTR(err);
}
- BUG_ON(!em); /* Error is always set */
return em;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: Remove spurious BUG_ON in btrfs_get_extent
2020-08-03 9:43 [PATCH] btrfs: Remove spurious BUG_ON in btrfs_get_extent Nikolay Borisov
@ 2020-08-11 13:53 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2020-08-11 13:53 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: linux-btrfs
On Mon, Aug 03, 2020 at 12:43:18PM +0300, Nikolay Borisov wrote:
> That BUG_ON cannot ever trigger because as the comment there states -
> 'err' is always set. Simply remove it as it brings no value.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-11 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 9:43 [PATCH] btrfs: Remove spurious BUG_ON in btrfs_get_extent Nikolay Borisov
2020-08-11 13:53 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.