From: Greg KH <gregkh@linuxfoundation.org>
To: Dongdong Yang <contribute.kernel@gmail.com>
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, mingo@redhat.com,
peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
devel@driverdev.osuosl.org, gulinghua@xiaomi.com,
tanggeliang@xiaomi.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, yangdongdong@xiaomi.com,
duhui@xiaomi.com, zhangguoquan@xiaomi.com, fengwei@xiaomi.com,
taojun@xiaomi.com, rocking@linux.alibaba.com,
huangqiwu@xiaomi.com
Subject: Re: [PATCH v3] sched: Provide USF for the portable equipment.
Date: Mon, 3 Aug 2020 17:07:56 +0200 [thread overview]
Message-ID: <20200803150756.GA1098726@kroah.com> (raw)
In-Reply-To: <23719695ee476715ec54d3310c95d535f8e1391a.1596464896.git.yangdongdong@xiaomi.com>
On Mon, Aug 03, 2020 at 10:31:15PM +0800, Dongdong Yang wrote:
> + /*
> + * create a sched_usf in cpu_subsys:
> + * /sys/devices/system/cpu/sched_usf/...
I thought I asked you not to use a "raw" kobject, you are making this
much harder than it has to be.
Just use a normal struct device.
Also you failed to document your new sysfs files in Documentation/ABI/
like is required :(
Because of both of those things, this isn't ok as-is, sorry.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Dongdong Yang <contribute.kernel@gmail.com>
Cc: juri.lelli@redhat.com, peterz@infradead.org,
viresh.kumar@linaro.org, bsegall@google.com,
gulinghua@xiaomi.com, duhui@xiaomi.com,
rocking@linux.alibaba.com, devel@driverdev.osuosl.org,
vincent.guittot@linaro.org, tanggeliang@xiaomi.com,
mingo@redhat.com, yangdongdong@xiaomi.com, mgorman@suse.de,
linux-pm@vger.kernel.org, rostedt@goodmis.org,
fengwei@xiaomi.com, taojun@xiaomi.com, dietmar.eggemann@arm.com,
huangqiwu@xiaomi.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, zhangguoquan@xiaomi.com
Subject: Re: [PATCH v3] sched: Provide USF for the portable equipment.
Date: Mon, 3 Aug 2020 17:07:56 +0200 [thread overview]
Message-ID: <20200803150756.GA1098726@kroah.com> (raw)
In-Reply-To: <23719695ee476715ec54d3310c95d535f8e1391a.1596464896.git.yangdongdong@xiaomi.com>
On Mon, Aug 03, 2020 at 10:31:15PM +0800, Dongdong Yang wrote:
> + /*
> + * create a sched_usf in cpu_subsys:
> + * /sys/devices/system/cpu/sched_usf/...
I thought I asked you not to use a "raw" kobject, you are making this
much harder than it has to be.
Just use a normal struct device.
Also you failed to document your new sysfs files in Documentation/ABI/
like is required :(
Because of both of those things, this isn't ok as-is, sorry.
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-08-03 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 14:31 [PATCH v3] Provide USF for the portable equipment Dongdong Yang
2020-08-03 14:31 ` Dongdong Yang
2020-08-03 14:31 ` [PATCH v3] sched: " Dongdong Yang
2020-08-03 14:31 ` Dongdong Yang
2020-08-03 15:07 ` Greg KH [this message]
2020-08-03 15:07 ` Greg KH
2020-08-03 23:30 ` Randy Dunlap
2020-08-03 23:30 ` Randy Dunlap
2020-08-04 5:47 ` [PATCH v3] " Viresh Kumar
2020-08-04 5:47 ` Viresh Kumar
[not found] ` <CADhdXfri8L6763ifBFMtP-cFSOuXO4isXhxZ4qF6M4vE=eeEjA@mail.gmail.com>
2020-08-04 7:47 ` Greg KH
2020-08-04 7:47 ` Greg KH
2020-08-05 11:33 ` Dan Carpenter
2020-08-05 11:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803150756.GA1098726@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bsegall@google.com \
--cc=contribute.kernel@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dietmar.eggemann@arm.com \
--cc=duhui@xiaomi.com \
--cc=fengwei@xiaomi.com \
--cc=gulinghua@xiaomi.com \
--cc=huangqiwu@xiaomi.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rocking@linux.alibaba.com \
--cc=rostedt@goodmis.org \
--cc=tanggeliang@xiaomi.com \
--cc=taojun@xiaomi.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=yangdongdong@xiaomi.com \
--cc=zhangguoquan@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.