* [RFC PATCH v1 0/1] A client needs to query whether the Bluetooth adapter support WBS, so we
@ 2020-08-03 23:58 Yu Liu
2020-08-03 23:58 ` [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability Yu Liu
0 siblings, 1 reply; 5+ messages in thread
From: Yu Liu @ 2020-08-03 23:58 UTC (permalink / raw)
To: linux-bluetooth; +Cc: chromeos-bluetooth-upstreaming, Yu Liu
designed this new D-Bus API to provide a generic way to query the
adapter's capabilities. Initially this will only cover WBS capability,
but can be easily extended to support other capabilities.
Changes in v1:
- Initial change
Archie Pusaka (1):
adapter - D-Bus API for querying the adapter's capability
doc/adapter-api.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
--
2.28.0.163.g6104cc2f0b6-goog
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability
2020-08-03 23:58 [RFC PATCH v1 0/1] A client needs to query whether the Bluetooth adapter support WBS, so we Yu Liu
@ 2020-08-03 23:58 ` Yu Liu
2020-08-11 18:22 ` Yu Liu
2020-08-12 12:13 ` Marcel Holtmann
0 siblings, 2 replies; 5+ messages in thread
From: Yu Liu @ 2020-08-03 23:58 UTC (permalink / raw)
To: linux-bluetooth
Cc: chromeos-bluetooth-upstreaming, Archie Pusaka, sonnysasaka
From: Archie Pusaka <apusaka@chromium.org>
Initially this is introduced to query whether WBS is supported by the adapter,
the API is generic enough to be extended to support querying others in
the future.
Reviewed-by: sonnysasaka@chromium.org
---
Changes in v1:
- Initial change
doc/adapter-api.txt | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
index 1a7255750..250d0e9b3 100644
--- a/doc/adapter-api.txt
+++ b/doc/adapter-api.txt
@@ -204,6 +204,23 @@ Methods void StartDiscovery()
org.bluez.Error.NotReady
org.bluez.Error.Failed
+ dict GetSupportedCapabilities()
+
+ This method returns a dictionary of supported
+ capabilities that is populated when the adapter
+ initiated.
+
+ The dictionary is following the format
+ {capability : value}, where:
+
+ string capability: The supported capability under
+ discussion.
+ variant value: A more detailed description of
+ the capability.
+
+ Possible errors: org.bluez.Error.NotReady
+ org.bluez.Error.Failed
+
Properties string Address [readonly]
The Bluetooth device address.
--
2.28.0.163.g6104cc2f0b6-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability
2020-08-03 23:58 ` [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability Yu Liu
@ 2020-08-11 18:22 ` Yu Liu
2020-08-12 12:13 ` Marcel Holtmann
1 sibling, 0 replies; 5+ messages in thread
From: Yu Liu @ 2020-08-11 18:22 UTC (permalink / raw)
To: linux-bluetooth
Friendly ping for comments, thanks.
On Mon, Aug 3, 2020 at 4:58 PM Yu Liu <yudiliu@google.com> wrote:
>
> From: Archie Pusaka <apusaka@chromium.org>
>
> Initially this is introduced to query whether WBS is supported by the adapter,
> the API is generic enough to be extended to support querying others in
> the future.
>
> Reviewed-by: sonnysasaka@chromium.org
>
> ---
>
> Changes in v1:
> - Initial change
>
> doc/adapter-api.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index 1a7255750..250d0e9b3 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -204,6 +204,23 @@ Methods void StartDiscovery()
> org.bluez.Error.NotReady
> org.bluez.Error.Failed
>
> + dict GetSupportedCapabilities()
> +
> + This method returns a dictionary of supported
> + capabilities that is populated when the adapter
> + initiated.
> +
> + The dictionary is following the format
> + {capability : value}, where:
> +
> + string capability: The supported capability under
> + discussion.
> + variant value: A more detailed description of
> + the capability.
> +
> + Possible errors: org.bluez.Error.NotReady
> + org.bluez.Error.Failed
> +
> Properties string Address [readonly]
>
> The Bluetooth device address.
> --
> 2.28.0.163.g6104cc2f0b6-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability
2020-08-03 23:58 ` [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability Yu Liu
2020-08-11 18:22 ` Yu Liu
@ 2020-08-12 12:13 ` Marcel Holtmann
2020-08-17 21:28 ` Yu Liu
1 sibling, 1 reply; 5+ messages in thread
From: Marcel Holtmann @ 2020-08-12 12:13 UTC (permalink / raw)
To: Yu Liu
Cc: linux-bluetooth, chromeos-bluetooth-upstreaming, Archie Pusaka,
sonnysasaka
Hi Yu,
> Initially this is introduced to query whether WBS is supported by the adapter,
> the API is generic enough to be extended to support querying others in
> the future.
>
> Reviewed-by: sonnysasaka@chromium.org
>
> ---
>
> Changes in v1:
> - Initial change
>
> doc/adapter-api.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index 1a7255750..250d0e9b3 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -204,6 +204,23 @@ Methods void StartDiscovery()
> org.bluez.Error.NotReady
> org.bluez.Error.Failed
>
> + dict GetSupportedCapabilities()
> +
> + This method returns a dictionary of supported
> + capabilities that is populated when the adapter
> + initiated.
> +
> + The dictionary is following the format
> + {capability : value}, where:
> +
> + string capability: The supported capability under
> + discussion.
> + variant value: A more detailed description of
> + the capability.
> +
> + Possible errors: org.bluez.Error.NotReady
> + org.bluez.Error.Failed
can’t this be just an array{string} that lists the capabilities?
And if we introduce it, then lets introduce it also with the first user of it. Otherwise we end up forgetting to comment on the actual possible capabilities.
Regards
Marcel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability
2020-08-12 12:13 ` Marcel Holtmann
@ 2020-08-17 21:28 ` Yu Liu
0 siblings, 0 replies; 5+ messages in thread
From: Yu Liu @ 2020-08-17 21:28 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-bluetooth
Hi Marcel,
Thanks for the suggestion, after talking to the original author we
dropped the original idea and added the new API as suggested. Thanks.
On Wed, Aug 12, 2020 at 5:13 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Yu,
>
> > Initially this is introduced to query whether WBS is supported by the adapter,
> > the API is generic enough to be extended to support querying others in
> > the future.
> >
> > Reviewed-by: sonnysasaka@chromium.org
> >
> > ---
> >
> > Changes in v1:
> > - Initial change
> >
> > doc/adapter-api.txt | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> > index 1a7255750..250d0e9b3 100644
> > --- a/doc/adapter-api.txt
> > +++ b/doc/adapter-api.txt
> > @@ -204,6 +204,23 @@ Methods void StartDiscovery()
> > org.bluez.Error.NotReady
> > org.bluez.Error.Failed
> >
> > + dict GetSupportedCapabilities()
> > +
> > + This method returns a dictionary of supported
> > + capabilities that is populated when the adapter
> > + initiated.
> > +
> > + The dictionary is following the format
> > + {capability : value}, where:
> > +
> > + string capability: The supported capability under
> > + discussion.
> > + variant value: A more detailed description of
> > + the capability.
> > +
> > + Possible errors: org.bluez.Error.NotReady
> > + org.bluez.Error.Failed
>
> can’t this be just an array{string} that lists the capabilities?
>
> And if we introduce it, then lets introduce it also with the first user of it. Otherwise we end up forgetting to comment on the actual possible capabilities.
>
> Regards
>
> Marcel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-17 21:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 23:58 [RFC PATCH v1 0/1] A client needs to query whether the Bluetooth adapter support WBS, so we Yu Liu
2020-08-03 23:58 ` [RFC PATCH v1 1/1] adapter - D-Bus API for querying the adapter's capability Yu Liu
2020-08-11 18:22 ` Yu Liu
2020-08-12 12:13 ` Marcel Holtmann
2020-08-17 21:28 ` Yu Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.