All of lore.kernel.org
 help / color / mirror / Atom feed
* [zen-kernel-zen-kernel:5.8/zen-sauce 20/26] mm/truncate.c:41:9-10: WARNING: return of 0/1 in function '__clear_shadow_entry' with return type bool
@ 2020-08-04  5:00 kernel test robot
  2020-08-04  5:01 ` [PATCH] vfs: fix boolreturn.cocci warnings kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-08-04  5:00 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

tree:   https://github.com/zen-kernel/zen-kernel 5.8/zen-sauce
head:   4ae00f4cbefe933616f33bf79935393ec49dbfa3
commit: 610bf337976b48286c82c09a4a8df8bdfcde38a8 [20/26] vfs: keep inodes with page cache off the inode shrinker LRU
config: ia64-randconfig-c004-20200804 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> mm/truncate.c:41:9-10: WARNING: return of 0/1 in function '__clear_shadow_entry' with return type bool

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40518 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] vfs: fix boolreturn.cocci warnings
  2020-08-04  5:00 [zen-kernel-zen-kernel:5.8/zen-sauce 20/26] mm/truncate.c:41:9-10: WARNING: return of 0/1 in function '__clear_shadow_entry' with return type bool kernel test robot
@ 2020-08-04  5:01 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-08-04  5:01 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

From: kernel test robot <lkp@intel.com>

mm/truncate.c:41:9-10: WARNING: return of 0/1 in function '__clear_shadow_entry' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 610bf337976b ("vfs: keep inodes with page cache off the inode shrinker LRU")
CC: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/zen-kernel/zen-kernel 5.8/zen-sauce
head:   4ae00f4cbefe933616f33bf79935393ec49dbfa3
commit: 610bf337976b48286c82c09a4a8df8bdfcde38a8 [20/26] vfs: keep inodes with page cache off the inode shrinker LRU

 truncate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/truncate.c
+++ b/mm/truncate.c
@@ -38,7 +38,7 @@ static bool __must_check __clear_shadow_
 
 	xas_set_update(&xas, workingset_update_node);
 	if (xas_load(&xas) != entry)
-		return 0;
+		return false;
 	xas_store(&xas, NULL);
 	mapping->nrexceptional--;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-04  5:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04  5:00 [zen-kernel-zen-kernel:5.8/zen-sauce 20/26] mm/truncate.c:41:9-10: WARNING: return of 0/1 in function '__clear_shadow_entry' with return type bool kernel test robot
2020-08-04  5:01 ` [PATCH] vfs: fix boolreturn.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.