All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Stafford Horne <shorne@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Jonas Bonn <jonas@southpole.se>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	openrisc@lists.librecores.org
Subject: Re: [PATCH 2/6] openrisc: uaccess: Fix sparse address space warnings
Date: Tue, 4 Aug 2020 22:46:10 +0200	[thread overview]
Message-ID: <20200804204610.mxzw6ahdnfw6yko2@ltop.local> (raw)
In-Reply-To: <20200804042354.3930694-3-shorne@gmail.com>

On Tue, Aug 04, 2020 at 01:23:50PM +0900, Stafford Horne wrote:
> The OpenRISC user access functions put_user(), get_user() and
> clear_user() were missing proper sparse annotations.  This generated
> warnings like the below.
> 
> This patch adds the annotations to fix the warnings.
> 
> Example warnings:
> 
> net/ipv4/ip_sockglue.c:759:29: warning: incorrect type in argument 1 (different address spaces)
> net/ipv4/ip_sockglue.c:759:29:    expected void const volatile [noderef] __user *
> net/ipv4/ip_sockglue.c:759:29:    got int const *__gu_addr
> net/ipv4/ip_sockglue.c:764:29: warning: incorrect type in initializer (different address spaces)
> net/ipv4/ip_sockglue.c:764:29:    expected unsigned char const *__gu_addr
> net/ipv4/ip_sockglue.c:764:29:    got unsigned char [noderef] __user *
> 
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Look good to me.

-- Luc

WARNING: multiple messages have this Message-ID (diff)
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 2/6] openrisc: uaccess: Fix sparse address space warnings
Date: Tue, 4 Aug 2020 22:46:10 +0200	[thread overview]
Message-ID: <20200804204610.mxzw6ahdnfw6yko2@ltop.local> (raw)
In-Reply-To: <20200804042354.3930694-3-shorne@gmail.com>

On Tue, Aug 04, 2020 at 01:23:50PM +0900, Stafford Horne wrote:
> The OpenRISC user access functions put_user(), get_user() and
> clear_user() were missing proper sparse annotations.  This generated
> warnings like the below.
> 
> This patch adds the annotations to fix the warnings.
> 
> Example warnings:
> 
> net/ipv4/ip_sockglue.c:759:29: warning: incorrect type in argument 1 (different address spaces)
> net/ipv4/ip_sockglue.c:759:29:    expected void const volatile [noderef] __user *
> net/ipv4/ip_sockglue.c:759:29:    got int const *__gu_addr
> net/ipv4/ip_sockglue.c:764:29: warning: incorrect type in initializer (different address spaces)
> net/ipv4/ip_sockglue.c:764:29:    expected unsigned char const *__gu_addr
> net/ipv4/ip_sockglue.c:764:29:    got unsigned char [noderef] __user *
> 
> Signed-off-by: Stafford Horne <shorne@gmail.com>

Look good to me.

-- Luc

  reply	other threads:[~2020-08-04 20:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  4:23 [PATCH 0/6] OpenRISC header and sparse warning fixes for 5.9 Stafford Horne
2020-08-04  4:23 ` [PATCH 1/6] openrisc: io: Fixup defines and move include to the end Stafford Horne
2020-08-04  4:23   ` [OpenRISC] " Stafford Horne
2020-08-04  4:23 ` [PATCH 2/6] openrisc: uaccess: Fix sparse address space warnings Stafford Horne
2020-08-04  4:23   ` [OpenRISC] " Stafford Horne
2020-08-04 20:46   ` Luc Van Oostenryck [this message]
2020-08-04 20:46     ` Luc Van Oostenryck
2020-08-04  4:23 ` [PATCH 3/6] openrisc: uaccess: Use static inline function in access_ok Stafford Horne
2020-08-04  4:23   ` [OpenRISC] " Stafford Horne
2020-08-04 20:48   ` Luc Van Oostenryck
2020-08-04 20:48     ` [OpenRISC] " Luc Van Oostenryck
2020-08-04  4:23 ` [PATCH 4/6] openrisc: uaccess: Remove unused macro __addr_ok Stafford Horne
2020-08-04  4:23   ` [OpenRISC] " Stafford Horne
2020-08-04  4:23 ` [PATCH 5/6] openrisc: signal: Fix sparse address space warnings Stafford Horne
2020-08-04  4:23   ` [OpenRISC] " Stafford Horne
2020-08-04  4:23 ` [PATCH 6/6] openrisc: uaccess: Add user address space check to access_ok Stafford Horne
2020-08-04  4:23   ` [OpenRISC] " Stafford Horne
2020-08-04 20:50   ` Luc Van Oostenryck
2020-08-04 20:50     ` [OpenRISC] " Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804204610.mxzw6ahdnfw6yko2@ltop.local \
    --to=luc.vanoostenryck@gmail.com \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openrisc@lists.librecores.org \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.