* [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-05 11:27 ` Peter Ujfalusi
0 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2020-08-05 11:27 UTC (permalink / raw)
To: ssantosh, santosh.shilimkar
Cc: linux-arm-kernel, grygorii.strashko, linux-kernel, vkoul, dmaengine
The original commit mixed up the forward and completion ring IDs for the
rx flow configuration.
Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Santosh, Vinod,
the offending patch was queued via ti SoC tree.
Santosh, can you pick up this fix also?
Regards,
Peter
drivers/dma/ti/k3-udma-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
index 3a5d33ea5ebe..12da38a92218 100644
--- a/drivers/dma/ti/k3-udma-glue.c
+++ b/drivers/dma/ti/k3-udma-glue.c
@@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
/* request and cfg rings */
ret = k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
- flow_cfg->ring_rxq_id,
flow_cfg->ring_rxfdq0_id,
+ flow_cfg->ring_rxq_id,
&flow->ringrxfdq,
&flow->ringrx);
if (ret) {
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-05 11:27 ` Peter Ujfalusi
0 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2020-08-05 11:27 UTC (permalink / raw)
To: ssantosh, santosh.shilimkar
Cc: linux-arm-kernel, grygorii.strashko, linux-kernel, vkoul, dmaengine
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-05 11:27 ` Peter Ujfalusi
0 siblings, 0 replies; 10+ messages in thread
From: Peter Ujfalusi @ 2020-08-05 11:27 UTC (permalink / raw)
To: ssantosh, santosh.shilimkar
Cc: dmaengine, vkoul, grygorii.strashko, linux-kernel, linux-arm-kernel
The original commit mixed up the forward and completion ring IDs for the
rx flow configuration.
Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Santosh, Vinod,
the offending patch was queued via ti SoC tree.
Santosh, can you pick up this fix also?
Regards,
Peter
drivers/dma/ti/k3-udma-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
index 3a5d33ea5ebe..12da38a92218 100644
--- a/drivers/dma/ti/k3-udma-glue.c
+++ b/drivers/dma/ti/k3-udma-glue.c
@@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
/* request and cfg rings */
ret = k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
- flow_cfg->ring_rxq_id,
flow_cfg->ring_rxfdq0_id,
+ flow_cfg->ring_rxq_id,
&flow->ringrxfdq,
&flow->ringrx);
if (ret) {
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
2020-08-05 11:27 ` Peter Ujfalusi
@ 2020-08-05 11:32 ` Vinod Koul
-1 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2020-08-05 11:32 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: ssantosh, santosh.shilimkar, linux-arm-kernel, grygorii.strashko,
linux-kernel, dmaengine
On 05-08-20, 14:27, Peter Ujfalusi wrote:
> The original commit mixed up the forward and completion ring IDs for the
> rx flow configuration.
Acked-By: Vinod Koul <vkoul@kernel.org>
>
> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Santosh, Vinod,
>
> the offending patch was queued via ti SoC tree.
> Santosh, can you pick up this fix also?
>
> Regards,
> Peter
>
> drivers/dma/ti/k3-udma-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 3a5d33ea5ebe..12da38a92218 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
>
> /* request and cfg rings */
> ret = k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
> - flow_cfg->ring_rxq_id,
> flow_cfg->ring_rxfdq0_id,
> + flow_cfg->ring_rxq_id,
> &flow->ringrxfdq,
> &flow->ringrx);
> if (ret) {
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-05 11:32 ` Vinod Koul
0 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2020-08-05 11:32 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: grygorii.strashko, santosh.shilimkar, linux-kernel, ssantosh,
dmaengine, linux-arm-kernel
On 05-08-20, 14:27, Peter Ujfalusi wrote:
> The original commit mixed up the forward and completion ring IDs for the
> rx flow configuration.
Acked-By: Vinod Koul <vkoul@kernel.org>
>
> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Santosh, Vinod,
>
> the offending patch was queued via ti SoC tree.
> Santosh, can you pick up this fix also?
>
> Regards,
> Peter
>
> drivers/dma/ti/k3-udma-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 3a5d33ea5ebe..12da38a92218 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
>
> /* request and cfg rings */
> ret = k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
> - flow_cfg->ring_rxq_id,
> flow_cfg->ring_rxfdq0_id,
> + flow_cfg->ring_rxq_id,
> &flow->ringrxfdq,
> &flow->ringrx);
> if (ret) {
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-05 13:17 ` Grygorii Strashko
0 siblings, 0 replies; 10+ messages in thread
From: Grygorii Strashko @ 2020-08-05 13:17 UTC (permalink / raw)
To: Vinod Koul, Peter Ujfalusi
Cc: ssantosh, santosh.shilimkar, linux-arm-kernel, linux-kernel, dmaengine
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-05 13:17 ` Grygorii Strashko
0 siblings, 0 replies; 10+ messages in thread
From: Grygorii Strashko @ 2020-08-05 13:17 UTC (permalink / raw)
To: Vinod Koul, Peter Ujfalusi
Cc: ssantosh, santosh.shilimkar, linux-arm-kernel, linux-kernel, dmaengine
On 05/08/2020 14:32, Vinod Koul wrote:
> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>> The original commit mixed up the forward and completion ring IDs for the
>> rx flow configuration.
>
> Acked-By: Vinod Koul <vkoul@kernel.org>
>
>>
>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> Hi Santosh, Vinod,
>>
>> the offending patch was queued via ti SoC tree.
>> Santosh, can you pick up this fix also?
Thank you Peter for catching this - it's valid issue.
but I'd like to note that issue was discovered with private code and
nothing is broken in Master.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-05 13:17 ` Grygorii Strashko
0 siblings, 0 replies; 10+ messages in thread
From: Grygorii Strashko @ 2020-08-05 13:17 UTC (permalink / raw)
To: Vinod Koul, Peter Ujfalusi
Cc: dmaengine, santosh.shilimkar, linux-kernel, linux-arm-kernel, ssantosh
On 05/08/2020 14:32, Vinod Koul wrote:
> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>> The original commit mixed up the forward and completion ring IDs for the
>> rx flow configuration.
>
> Acked-By: Vinod Koul <vkoul@kernel.org>
>
>>
>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> Hi Santosh, Vinod,
>>
>> the offending patch was queued via ti SoC tree.
>> Santosh, can you pick up this fix also?
Thank you Peter for catching this - it's valid issue.
but I'd like to note that issue was discovered with private code and
nothing is broken in Master.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
2020-08-05 13:17 ` Grygorii Strashko
@ 2020-08-06 17:58 ` santosh.shilimkar
-1 siblings, 0 replies; 10+ messages in thread
From: santosh.shilimkar @ 2020-08-06 17:58 UTC (permalink / raw)
To: Grygorii Strashko, Vinod Koul, Peter Ujfalusi
Cc: ssantosh, linux-arm-kernel, linux-kernel, dmaengine
On 8/5/20 6:17 AM, Grygorii Strashko wrote:
>
>
> On 05/08/2020 14:32, Vinod Koul wrote:
>> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>>> The original commit mixed up the forward and completion ring IDs for the
>>> rx flow configuration.
>>
>> Acked-By: Vinod Koul <vkoul@kernel.org>
>>
>>>
>>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to
>>> k3_ringacc_request_rings_pair")
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>>> Hi Santosh, Vinod,
>>>
>>> the offending patch was queued via ti SoC tree.
>>> Santosh, can you pick up this fix also?
>
> Thank you Peter for catching this - it's valid issue.
> but I'd like to note that issue was discovered with private code and
> nothing is broken in Master.
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
Will queue this up for next merge window.
regards,
Santosh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request
@ 2020-08-06 17:58 ` santosh.shilimkar
0 siblings, 0 replies; 10+ messages in thread
From: santosh.shilimkar @ 2020-08-06 17:58 UTC (permalink / raw)
To: Grygorii Strashko, Vinod Koul, Peter Ujfalusi
Cc: dmaengine, linux-kernel, linux-arm-kernel, ssantosh
On 8/5/20 6:17 AM, Grygorii Strashko wrote:
>
>
> On 05/08/2020 14:32, Vinod Koul wrote:
>> On 05-08-20, 14:27, Peter Ujfalusi wrote:
>>> The original commit mixed up the forward and completion ring IDs for the
>>> rx flow configuration.
>>
>> Acked-By: Vinod Koul <vkoul@kernel.org>
>>
>>>
>>> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to
>>> k3_ringacc_request_rings_pair")
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>>> Hi Santosh, Vinod,
>>>
>>> the offending patch was queued via ti SoC tree.
>>> Santosh, can you pick up this fix also?
>
> Thank you Peter for catching this - it's valid issue.
> but I'd like to note that issue was discovered with private code and
> nothing is broken in Master.
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
Will queue this up for next merge window.
regards,
Santosh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-08-06 18:00 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-05 11:27 [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request Peter Ujfalusi
2020-08-05 11:27 ` Peter Ujfalusi
2020-08-05 11:27 ` Peter Ujfalusi
2020-08-05 11:32 ` Vinod Koul
2020-08-05 11:32 ` Vinod Koul
2020-08-05 13:17 ` Grygorii Strashko
2020-08-05 13:17 ` Grygorii Strashko
2020-08-05 13:17 ` Grygorii Strashko
2020-08-06 17:58 ` santosh.shilimkar
2020-08-06 17:58 ` santosh.shilimkar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.