* [PATCH] nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage
@ 2020-08-05 13:35 Johannes Berg
2020-08-10 3:32 ` Rajkumar Manoharan
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2020-08-05 13:35 UTC (permalink / raw)
To: linux-wireless; +Cc: Rajkumar Manoharan, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
In nl80211_set_station(), we check NL80211_ATTR_HE_6GHZ_CAPABILITY
and then use NL80211_ATTR_HE_CAPABILITY, which is clearly wrong.
Fix this to use NL80211_ATTR_HE_6GHZ_CAPABILITY as well.
Fixes: 43e64bf301fd ("cfg80211: handle 6 GHz capability of new station")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/wireless/nl80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 19281d0c8c9d..bfda09d24146 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -6008,7 +6008,7 @@ static int nl80211_set_station(struct sk_buff *skb, struct genl_info *info)
if (info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY])
params.he_6ghz_capa =
- nla_data(info->attrs[NL80211_ATTR_HE_CAPABILITY]);
+ nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);
if (info->attrs[NL80211_ATTR_AIRTIME_WEIGHT])
params.airtime_weight =
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage
2020-08-05 13:35 [PATCH] nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage Johannes Berg
@ 2020-08-10 3:32 ` Rajkumar Manoharan
0 siblings, 0 replies; 2+ messages in thread
From: Rajkumar Manoharan @ 2020-08-10 3:32 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, Johannes Berg, linux-wireless-owner
On 2020-08-05 06:35, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> In nl80211_set_station(), we check NL80211_ATTR_HE_6GHZ_CAPABILITY
> and then use NL80211_ATTR_HE_CAPABILITY, which is clearly wrong.
> Fix this to use NL80211_ATTR_HE_6GHZ_CAPABILITY as well.
>
> Fixes: 43e64bf301fd ("cfg80211: handle 6 GHz capability of new
> station")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/wireless/nl80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 19281d0c8c9d..bfda09d24146 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -6008,7 +6008,7 @@ static int nl80211_set_station(struct sk_buff
> *skb, struct genl_info *info)
>
> if (info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY])
> params.he_6ghz_capa =
> - nla_data(info->attrs[NL80211_ATTR_HE_CAPABILITY]);
> + nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);
>
Thanks for the fix :). Must have overlooked.
-Rajkumar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-10 3:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-05 13:35 [PATCH] nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage Johannes Berg
2020-08-10 3:32 ` Rajkumar Manoharan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.