[sashal-linux-stable:queue-4.4 6/31] fs/nfs/nfs4proc.c:8777:9: sparse: sparse: symbol 'nfs4_listxattr' was not declared. Should it be

[sashal-linux-stable:queue-4.4 6/31] fs/nfs/nfs4proc.c:8777:9: sparse: sparse: symbol 'nfs4_listxattr' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 6083 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.4
head:   891ee24b4da9d5b139c4a494acc742c2a4b0cb1d
commit: 9115887f4dd57b0c2428f933203443b35cc6bf9d [6/31] nfs: Move call to security_inode_listsecurity into nfs_listxattr
config: i386-randconfig-s001-20200805 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-117-g8c7aee71-dirty
        git checkout 9115887f4dd57b0c2428f933203443b35cc6bf9d
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> fs/nfs/nfs4proc.c:8777:9: sparse: sparse: symbol 'nfs4_listxattr' was not declared. Should it be static?
   In file included from include/linux/nfs_fs.h:23:0,
                    from fs/nfs/nfs4proc.c:48:
   include/linux/pagemap.h: In function 'fault_in_multipages_readable':
   include/linux/pagemap.h:632:16: warning: variable 'c' set but not used [-Wunused-but-set-variable]
     volatile char c;
                   ^
   fs/nfs/nfs4proc.c: In function 'nfs4_init_nonuniform_client_string':
   fs/nfs/nfs4proc.c:5059:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
     int result;
         ^~~~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_init_uniquifier_client_string':
   fs/nfs/nfs4proc.c:5100:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
     int result;
         ^~~~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_init_uniform_client_string':
   fs/nfs/nfs4proc.c:5131:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
     int result;
         ^~~~~~
   fs/nfs/nfs4proc.c: At top level:
   fs/nfs/nfs4proc.c:8777:9: warning: no previous prototype for 'nfs4_listxattr' [-Wmissing-prototypes]
    ssize_t nfs4_listxattr(struct dentry *dentry, char *list, size_t size)
            ^~~~~~~~~~~~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_do_handle_exception':
   fs/nfs/nfs4proc.c:371:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
       if (state != NULL) {
          ^
   fs/nfs/nfs4proc.c:376:3: note: here
      case -NFS4ERR_STALE_STATEID:
      ^~~~
   fs/nfs/nfs4proc.c:402:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
       if (exception->timeout > HZ) {
          ^
   fs/nfs/nfs4proc.c:409:3: note: here
      case -NFS4ERR_DELAY:
      ^~~~
   fs/nfs/nfs4proc.c:410:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
       nfs_inc_server_stats(server, NFSIOS_DELAY);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/nfs/nfs4proc.c:411:3: note: here
      case -NFS4ERR_GRACE:
      ^~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_open_delegation_recall':
   fs/nfs/nfs4proc.c:1863:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
      if (err)
         ^
   fs/nfs/nfs4proc.c:1865:2: note: here
     case FMODE_READ:
     ^~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_open_prepare':
   fs/nfs/nfs4proc.c:1994:27: warning: this statement may fall through [-Wimplicit-fallthrough=]
      data->o_arg.open_bitmap = &nfs4_open_noattr_bitmap[0];
      ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/nfs/nfs4proc.c:1995:2: note: here
     case NFS4_OPEN_CLAIM_FH:
     ^~~~
   fs/nfs/nfs4proc.c: In function 'can_open_delegated':
   fs/nfs/nfs4proc.c:1251:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
      if (!test_bit(NFS_DELEGATION_NEED_RECLAIM, &delegation->flags))
         ^
   fs/nfs/nfs4proc.c:1253:2: note: here
     default:
     ^~~~~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_handle_delegation_recall_error':
   fs/nfs/nfs4proc.c:1803:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
       set_bit(NFS_DELEGATED_STATE, &state->flags);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/nfs/nfs4proc.c:1804:3: note: here
      case -NFS4ERR_EXPIRED:
      ^~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_close_done':
   fs/nfs/nfs4proc.c:2819:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
       if (calldata->arg.fmode == 0)
          ^
   fs/nfs/nfs4proc.c:2821:3: note: here
      default:
      ^~~~~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_delegreturn_done':
   fs/nfs/nfs4proc.c:5317:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
      renew_lease(data->res.server, data->timestamp);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/nfs/nfs4proc.c:5318:2: note: here
     case -NFS4ERR_ADMIN_REVOKED:
     ^~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_locku_done':
   fs/nfs/nfs4proc.c:5580:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
       if (nfs4_update_lock_stateid(calldata->lsp,
          ^
   fs/nfs/nfs4proc.c:5583:3: note: here
      case -NFS4ERR_BAD_STATEID:
      ^~~~
   fs/nfs/nfs4proc.c: In function 'nfs4_handle_setlk_error':
   fs/nfs/nfs4proc.c:5892:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
      lsp->ls_seqid.flags &= ~NFS_SEQID_CONFIRMED;
   fs/nfs/nfs4proc.c:5893:2: note: here
     case -NFS4ERR_EXPIRED:
     ^~~~
   arch/x86/include/asm/bitops.h: Assembler messages:
   arch/x86/include/asm/bitops.h:206: Warning: no instruction mnemonic suffix given and no register operands; using default for `bts'
   arch/x86/include/asm/bitops.h:252: Warning: no instruction mnemonic suffix given and no register operands; using default for `btr'
   arch/x86/include/asm/bitops.h:252: Warning: no instruction mnemonic suffix given and no register operands; using default for `btr'

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 21011 bytes --]

[RFC PATCH sashal-linux-stable] nfs: nfs4_listxattr() can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]


Fixes: 9115887f4dd5 ("nfs: Move call to security_inode_listsecurity into nfs_listxattr")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 nfs4proc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 566afcc36adb5..c02ea018b0a78 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -8774,7 +8774,7 @@ const struct nfs4_minor_version_ops *nfs_v4_minor_ops[] = {
 #endif
 };
 
-ssize_t nfs4_listxattr(struct dentry *dentry, char *list, size_t size)
+static ssize_t nfs4_listxattr(struct dentry *dentry, char *list, size_t size)
 {
 	ssize_t error, error2;