* [Intel-gfx] [PATCH i-g-t] i915/gem_caching: Fix mmap protection for writes
@ 2020-08-06 18:31 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2020-08-06 18:31 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Dominik Grzegorzek, Chris Wilson
As we are about to write into the mmap'ed pointer using memset, we need
to specify PROT_WRITE [if we only say PROT_READ, then the memset should
generate a SIGSEGV].
Fixes: 897d21d14e99 ("i915/gem_caching: Remove libdrm dependency")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ramalingam C <ramalingam.c@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
---
tests/i915/gem_caching.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
index 1d8989db7..894c4b12e 100644
--- a/tests/i915/gem_caching.c
+++ b/tests/i915/gem_caching.c
@@ -282,7 +282,7 @@ igt_main
val2 = i + 63;
cpu_ptr = gem_mmap__cpu(data.fd, scratch_buf->handle,
0, scratch_buf->surface[0].size,
- PROT_READ);
+ PROT_WRITE);
memset(cpu_ptr + start, val2, len);
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/gem_caching: Fix mmap protection for writes
@ 2020-08-06 18:31 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2020-08-06 18:31 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Chris Wilson
As we are about to write into the mmap'ed pointer using memset, we need
to specify PROT_WRITE [if we only say PROT_READ, then the memset should
generate a SIGSEGV].
Fixes: 897d21d14e99 ("i915/gem_caching: Remove libdrm dependency")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ramalingam C <ramalingam.c@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
---
tests/i915/gem_caching.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
index 1d8989db7..894c4b12e 100644
--- a/tests/i915/gem_caching.c
+++ b/tests/i915/gem_caching.c
@@ -282,7 +282,7 @@ igt_main
val2 = i + 63;
cpu_ptr = gem_mmap__cpu(data.fd, scratch_buf->handle,
0, scratch_buf->surface[0].size,
- PROT_READ);
+ PROT_WRITE);
memset(cpu_ptr + start, val2, len);
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] i915/gem_caching: Fix mmap protection for writes
2020-08-06 18:31 ` [igt-dev] " Chris Wilson
@ 2020-08-06 19:10 ` Ramalingam C
-1 siblings, 0 replies; 8+ messages in thread
From: Ramalingam C @ 2020-08-06 19:10 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx, Dominik Grzegorzek
On 2020-08-06 at 19:31:43 +0100, Chris Wilson wrote:
> As we are about to write into the mmap'ed pointer using memset, we need
> to specify PROT_WRITE [if we only say PROT_READ, then the memset should
> generate a SIGSEGV].
>
> Fixes: 897d21d14e99 ("i915/gem_caching: Remove libdrm dependency")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> ---
> tests/i915/gem_caching.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
> index 1d8989db7..894c4b12e 100644
> --- a/tests/i915/gem_caching.c
> +++ b/tests/i915/gem_caching.c
> @@ -282,7 +282,7 @@ igt_main
> val2 = i + 63;
> cpu_ptr = gem_mmap__cpu(data.fd, scratch_buf->handle,
> 0, scratch_buf->surface[0].size,
> - PROT_READ);
> + PROT_WRITE);
>
> memset(cpu_ptr + start, val2, len);
>
> --
> 2.28.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_caching: Fix mmap protection for writes
@ 2020-08-06 19:10 ` Ramalingam C
0 siblings, 0 replies; 8+ messages in thread
From: Ramalingam C @ 2020-08-06 19:10 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On 2020-08-06 at 19:31:43 +0100, Chris Wilson wrote:
> As we are about to write into the mmap'ed pointer using memset, we need
> to specify PROT_WRITE [if we only say PROT_READ, then the memset should
> generate a SIGSEGV].
>
> Fixes: 897d21d14e99 ("i915/gem_caching: Remove libdrm dependency")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> ---
> tests/i915/gem_caching.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
> index 1d8989db7..894c4b12e 100644
> --- a/tests/i915/gem_caching.c
> +++ b/tests/i915/gem_caching.c
> @@ -282,7 +282,7 @@ igt_main
> val2 = i + 63;
> cpu_ptr = gem_mmap__cpu(data.fd, scratch_buf->handle,
> 0, scratch_buf->surface[0].size,
> - PROT_READ);
> + PROT_WRITE);
>
> memset(cpu_ptr + start, val2, len);
>
> --
> 2.28.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_caching: Fix mmap protection for writes
2020-08-06 18:31 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2020-08-06 19:20 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-08-06 19:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5985 bytes --]
== Series Details ==
Series: i915/gem_caching: Fix mmap protection for writes
URL : https://patchwork.freedesktop.org/series/80363/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8850 -> IGTPW_4865
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/index.html
Known issues
------------
Here are the changes found in IGTPW_4865 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [PASS][3] -> [DMESG-WARN][4] ([i915#2203])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-cml-s: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-cml-s/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-cml-s/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- {fi-kbl-7560u}: [WARN][9] ([i915#2249]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][11] ([i915#2276]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-icl-y/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-icl-y/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_lrc:
- fi-tgl-u2: [DMESG-FAIL][13] ([i915#1233]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-kbl-x1275/igt@kms_busy@basic@flip.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
#### Warnings ####
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92]) -> [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95]) +7 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][22] ([i915#62] / [i915#92]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2249]: https://gitlab.freedesktop.org/drm/intel/issues/2249
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (44 -> 37)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5762 -> IGTPW_4865
CI-20190529: 20190529
CI_DRM_8850: 8b1e9fc8743b9e054c46a18567e1c7b91e360926 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4865: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/index.html
IGT_5762: ec3d9a843686a618612016de9249117dd8d862a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/index.html
[-- Attachment #1.2: Type: text/html, Size: 7636 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_caching: Fix mmap protection for writes
2020-08-06 18:31 ` [igt-dev] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2020-08-07 4:38 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2020-08-07 4:38 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 16550 bytes --]
== Series Details ==
Series: i915/gem_caching: Fix mmap protection for writes
URL : https://patchwork.freedesktop.org/series/80363/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8850_full -> IGTPW_4865_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/index.html
Known issues
------------
Here are the changes found in IGTPW_4865_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([i915#118] / [i915#95])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-glk6/igt@gem_exec_whisper@basic-queues-all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-glk6/igt@gem_exec_whisper@basic-queues-all.html
* igt@kms_big_fb@linear-8bpp-rotate-180:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#1635] / [i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-apl8/igt@kms_big_fb@linear-8bpp-rotate-180.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-apl7/igt@kms_big_fb@linear-8bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-glk: [PASS][5] -> [DMESG-FAIL][6] ([i915#118] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-glk5/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-random:
- shard-hsw: [PASS][7] -> [TIMEOUT][8] ([i915#1958]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-hsw7/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-hsw1/igt@kms_cursor_crc@pipe-c-cursor-256x256-random.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][9] -> [FAIL][10] ([i915#57])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#49])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
- shard-tglb: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-kbl7/igt@kms_hdr@bpc-switch-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([i915#1185] / [i915#250])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-iclb: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#173])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb8/igt@kms_psr@no_drrs.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-hsw: [PASS][25] -> [FAIL][26] ([i915#31])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-hsw2/igt@kms_setmode@basic.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-hsw2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([i915#1798] / [i915#456])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-tglb8/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-tglb5/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@prime_busy@hang-wait@bcs0:
- shard-hsw: [PASS][29] -> [FAIL][30] ([i915#2258]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-hsw6/igt@prime_busy@hang-wait@bcs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-hsw2/igt@prime_busy@hang-wait@bcs0.html
#### Possible fixes ####
* igt@i915_pm_dc@dc5-psr:
- shard-iclb: [FAIL][31] ([i915#1899]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb2/igt@i915_pm_dc@dc5-psr.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb8/igt@i915_pm_dc@dc5-psr.html
- shard-tglb: [FAIL][33] ([i915#1899]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-tglb7/igt@i915_pm_dc@dc5-psr.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-tglb3/igt@i915_pm_dc@dc5-psr.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-glk: [DMESG-FAIL][35] ([i915#118] / [i915#95]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-glk3/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-kbl: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-kbl4/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-kbl6/igt@kms_big_fb@yf-tiled-16bpp-rotate-0.html
* igt@kms_color@pipe-a-ctm-max:
- shard-kbl: [FAIL][39] ([i915#168]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-kbl7/igt@kms_color@pipe-a-ctm-max.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-kbl6/igt@kms_color@pipe-a-ctm-max.html
- shard-apl: [FAIL][41] ([i915#1635] / [i915#168]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-apl4/igt@kms_color@pipe-a-ctm-max.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-apl6/igt@kms_color@pipe-a-ctm-max.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-offscreen:
- shard-kbl: [DMESG-WARN][43] ([i915#78]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-256x85-offscreen.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-256x85-offscreen.html
* igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge:
- shard-glk: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-glk6/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-glk8/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][47] ([i915#96]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-glk: [FAIL][49] ([i915#49]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-tglb: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +6 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_panel_fitting@atomic-fastset:
- shard-iclb: [FAIL][53] ([i915#83]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb4/igt@kms_panel_fitting@atomic-fastset.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb8/igt@kms_panel_fitting@atomic-fastset.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +8 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_properties@invalid-properties-atomic:
- shard-snb: [TIMEOUT][57] ([i915#1958]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-snb6/igt@kms_properties@invalid-properties-atomic.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-snb2/igt@kms_properties@invalid-properties-atomic.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][59] ([fdo#109642] / [fdo#111068]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_cpu.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][63] ([i915#31]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-glk1/igt@kms_setmode@basic.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-glk6/igt@kms_setmode@basic.html
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-hsw: [TIMEOUT][65] ([i915#1958]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-hsw1/igt@kms_universal_plane@universal-plane-pipe-c-functional.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-hsw2/igt@kms_universal_plane@universal-plane-pipe-c-functional.html
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [TIMEOUT][67] ([i915#1958]) -> [FAIL][68] ([i915#1930])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-snb6/igt@gem_exec_reloc@basic-concurrent16.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-snb6/igt@gem_exec_reloc@basic-concurrent16.html
* igt@kms_chamelium@common-hpd-after-suspend:
- shard-hsw: [TIMEOUT][69] ([i915#1958]) -> [SKIP][70] ([fdo#109271] / [fdo#111827])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-hsw1/igt@kms_chamelium@common-hpd-after-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-hsw2/igt@kms_chamelium@common-hpd-after-suspend.html
- shard-snb: [TIMEOUT][71] ([i915#1958]) -> [SKIP][72] ([fdo#109271] / [fdo#111827])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-snb6/igt@kms_chamelium@common-hpd-after-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-snb2/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-pwrite:
- shard-snb: [TIMEOUT][73] ([i915#1958]) -> [SKIP][74] ([fdo#109271]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8850/shard-snb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-pwrite.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/shard-snb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-pwrite.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#168]: https://gitlab.freedesktop.org/drm/intel/issues/168
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#1798]: https://gitlab.freedesktop.org/drm/intel/issues/1798
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#83]: https://gitlab.freedesktop.org/drm/intel/issues/83
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5762 -> IGTPW_4865
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_8850: 8b1e9fc8743b9e054c46a18567e1c7b91e360926 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4865: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/index.html
IGT_5762: ec3d9a843686a618612016de9249117dd8d862a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4865/index.html
[-- Attachment #1.2: Type: text/html, Size: 19722 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] i915/gem_caching: Fix mmap protection for writes
2020-08-06 18:31 ` [igt-dev] " Chris Wilson
@ 2020-08-07 8:04 ` Grzegorzek, Dominik
-1 siblings, 0 replies; 8+ messages in thread
From: Grzegorzek, Dominik @ 2020-08-07 8:04 UTC (permalink / raw)
To: intel-gfx, chris; +Cc: igt-dev
On Thu, 2020-08-06 at 19:31 +0100, Chris Wilson wrote:
> As we are about to write into the mmap'ed pointer using memset, we
> need
> to specify PROT_WRITE [if we only say PROT_READ, then the memset
> should
> generate a SIGSEGV].
>
Thank you for fixing that.
> Fixes: 897d21d14e99 ("i915/gem_caching: Remove libdrm dependency")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> ---
> tests/i915/gem_caching.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
> index 1d8989db7..894c4b12e 100644
> --- a/tests/i915/gem_caching.c
> +++ b/tests/i915/gem_caching.c
> @@ -282,7 +282,7 @@ igt_main
> val2 = i + 63;
> cpu_ptr = gem_mmap__cpu(data.fd, scratch_buf-
> >handle,
> 0, scratch_buf-
> >surface[0].size,
> - PROT_READ);
> + PROT_WRITE);
>
> memset(cpu_ptr + start, val2, len);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_caching: Fix mmap protection for writes
@ 2020-08-07 8:04 ` Grzegorzek, Dominik
0 siblings, 0 replies; 8+ messages in thread
From: Grzegorzek, Dominik @ 2020-08-07 8:04 UTC (permalink / raw)
To: intel-gfx, chris; +Cc: igt-dev
On Thu, 2020-08-06 at 19:31 +0100, Chris Wilson wrote:
> As we are about to write into the mmap'ed pointer using memset, we
> need
> to specify PROT_WRITE [if we only say PROT_READ, then the memset
> should
> generate a SIGSEGV].
>
Thank you for fixing that.
> Fixes: 897d21d14e99 ("i915/gem_caching: Remove libdrm dependency")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> ---
> tests/i915/gem_caching.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
> index 1d8989db7..894c4b12e 100644
> --- a/tests/i915/gem_caching.c
> +++ b/tests/i915/gem_caching.c
> @@ -282,7 +282,7 @@ igt_main
> val2 = i + 63;
> cpu_ptr = gem_mmap__cpu(data.fd, scratch_buf-
> >handle,
> 0, scratch_buf-
> >surface[0].size,
> - PROT_READ);
> + PROT_WRITE);
>
> memset(cpu_ptr + start, val2, len);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-08-07 8:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 18:31 [Intel-gfx] [PATCH i-g-t] i915/gem_caching: Fix mmap protection for writes Chris Wilson
2020-08-06 18:31 ` [igt-dev] " Chris Wilson
2020-08-06 19:10 ` [Intel-gfx] " Ramalingam C
2020-08-06 19:10 ` [igt-dev] " Ramalingam C
2020-08-06 19:20 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-07 4:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-08-07 8:04 ` [Intel-gfx] [PATCH i-g-t] " Grzegorzek, Dominik
2020-08-07 8:04 ` [igt-dev] " Grzegorzek, Dominik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.