* [PATCH v4] documentation: coccinelle: Improve command example for make C={1,2}
@ 2020-08-11 0:23 ` Sumera Priyadarsini
0 siblings, 0 replies; 7+ messages in thread
From: Sumera Priyadarsini @ 2020-08-11 0:23 UTC (permalink / raw)
To: Julia.Lawall
Cc: gregkh, Gilles.Muller, nicolas.palix, michal.lkml, corbet, cocci,
linux-doc, linux-kernel, Sumera Priyadarsini
Modify coccinelle documentation to further clarify
the usage of the makefile C variable by coccicheck.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
Changes in v4:
- Modify commit message to clarify C is a variable
---
Documentation/dev-tools/coccinelle.rst | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst
index 6c791af1c859..74c5e6aeeff5 100644
--- a/Documentation/dev-tools/coccinelle.rst
+++ b/Documentation/dev-tools/coccinelle.rst
@@ -175,13 +175,20 @@ For example, to check drivers/net/wireless/ one may write::
make coccicheck M=drivers/net/wireless/
To apply Coccinelle on a file basis, instead of a directory basis, the
-following command may be used::
+C variable is used by the makefile to select which files to work with.
+This variable can be used to run scripts for the entire kernel, a
+specific directory, or for a single file.
- make C=1 CHECK="scripts/coccicheck"
+For example, to check drivers/bluetooth/bfusb.c, the value 1 is
+passed to the C variable to check files that make considers
+need to be compiled.::
-To check only newly edited code, use the value 2 for the C flag, i.e.::
+ make C=1 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
- make C=2 CHECK="scripts/coccicheck"
+The value 2 is passed to the C variable to check files regardless of
+whether they need to be compiled or not.::
+
+ make C=2 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
In these modes, which work on a file basis, there is no information
about semantic patches displayed, and no commit message proposed.
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
@ 2020-08-11 0:23 ` Sumera Priyadarsini
0 siblings, 0 replies; 7+ messages in thread
From: Sumera Priyadarsini @ 2020-08-11 0:23 UTC (permalink / raw)
To: Julia.Lawall
Cc: michal.lkml, linux-doc, corbet, gregkh, Gilles.Muller,
nicolas.palix, linux-kernel, cocci
Modify coccinelle documentation to further clarify
the usage of the makefile C variable by coccicheck.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
Changes in v4:
- Modify commit message to clarify C is a variable
---
Documentation/dev-tools/coccinelle.rst | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst
index 6c791af1c859..74c5e6aeeff5 100644
--- a/Documentation/dev-tools/coccinelle.rst
+++ b/Documentation/dev-tools/coccinelle.rst
@@ -175,13 +175,20 @@ For example, to check drivers/net/wireless/ one may write::
make coccicheck M=drivers/net/wireless/
To apply Coccinelle on a file basis, instead of a directory basis, the
-following command may be used::
+C variable is used by the makefile to select which files to work with.
+This variable can be used to run scripts for the entire kernel, a
+specific directory, or for a single file.
- make C=1 CHECK="scripts/coccicheck"
+For example, to check drivers/bluetooth/bfusb.c, the value 1 is
+passed to the C variable to check files that make considers
+need to be compiled.::
-To check only newly edited code, use the value 2 for the C flag, i.e.::
+ make C=1 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
- make C=2 CHECK="scripts/coccicheck"
+The value 2 is passed to the C variable to check files regardless of
+whether they need to be compiled or not.::
+
+ make C=2 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
In these modes, which work on a file basis, there is no information
about semantic patches displayed, and no commit message proposed.
--
2.17.1
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v4] documentation: coccinelle: Improve command example for make C={1,2}
2020-08-11 0:23 ` [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2} Sumera Priyadarsini
(?)
@ 2020-08-11 16:38 ` Jonathan Corbet
-1 siblings, 0 replies; 7+ messages in thread
From: Jonathan Corbet @ 2020-08-11 16:38 UTC (permalink / raw)
To: Sumera Priyadarsini
Cc: Julia.Lawall, gregkh, Gilles.Muller, nicolas.palix, michal.lkml,
cocci, linux-doc, linux-kernel
On Tue, 11 Aug 2020 05:53:50 +0530
Sumera Priyadarsini <sylphrenadin@gmail.com> wrote:
> Modify coccinelle documentation to further clarify
> the usage of the makefile C variable by coccicheck.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
>
> ---
> Changes in v4:
> - Modify commit message to clarify C is a variable
> ---
> Documentation/dev-tools/coccinelle.rst | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
2020-08-11 0:23 ` [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2} Sumera Priyadarsini
@ 2020-08-11 19:53 ` Julia Lawall
-1 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2020-08-11 19:53 UTC (permalink / raw)
To: Sumera Priyadarsini
Cc: Julia Lawall, michal.lkml, linux-doc, corbet, gregkh,
Gilles.Muller, nicolas.palix, linux-kernel, cocci
On Tue, 11 Aug 2020, Sumera Priyadarsini wrote:
> Modify coccinelle documentation to further clarify
> the usage of the makefile C variable by coccicheck.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Acked-by: Julia Lawall <julia.lawall@inria.fr>
Thanks.
>
> ---
> Changes in v4:
> - Modify commit message to clarify C is a variable
> ---
> Documentation/dev-tools/coccinelle.rst | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst
> index 6c791af1c859..74c5e6aeeff5 100644
> --- a/Documentation/dev-tools/coccinelle.rst
> +++ b/Documentation/dev-tools/coccinelle.rst
> @@ -175,13 +175,20 @@ For example, to check drivers/net/wireless/ one may write::
> make coccicheck M=drivers/net/wireless/
>
> To apply Coccinelle on a file basis, instead of a directory basis, the
> -following command may be used::
> +C variable is used by the makefile to select which files to work with.
> +This variable can be used to run scripts for the entire kernel, a
> +specific directory, or for a single file.
>
> - make C=1 CHECK="scripts/coccicheck"
> +For example, to check drivers/bluetooth/bfusb.c, the value 1 is
> +passed to the C variable to check files that make considers
> +need to be compiled.::
>
> -To check only newly edited code, use the value 2 for the C flag, i.e.::
> + make C=1 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
>
> - make C=2 CHECK="scripts/coccicheck"
> +The value 2 is passed to the C variable to check files regardless of
> +whether they need to be compiled or not.::
> +
> + make C=2 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
>
> In these modes, which work on a file basis, there is no information
> about semantic patches displayed, and no commit message proposed.
> --
> 2.17.1
>
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
@ 2020-08-11 19:53 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2020-08-11 19:53 UTC (permalink / raw)
To: Sumera Priyadarsini
Cc: michal.lkml, Gilles.Muller, gregkh, nicolas.palix, corbet,
linux-doc, linux-kernel, Julia Lawall, cocci
On Tue, 11 Aug 2020, Sumera Priyadarsini wrote:
> Modify coccinelle documentation to further clarify
> the usage of the makefile C variable by coccicheck.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Acked-by: Julia Lawall <julia.lawall@inria.fr>
Thanks.
>
> ---
> Changes in v4:
> - Modify commit message to clarify C is a variable
> ---
> Documentation/dev-tools/coccinelle.rst | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst
> index 6c791af1c859..74c5e6aeeff5 100644
> --- a/Documentation/dev-tools/coccinelle.rst
> +++ b/Documentation/dev-tools/coccinelle.rst
> @@ -175,13 +175,20 @@ For example, to check drivers/net/wireless/ one may write::
> make coccicheck M=drivers/net/wireless/
>
> To apply Coccinelle on a file basis, instead of a directory basis, the
> -following command may be used::
> +C variable is used by the makefile to select which files to work with.
> +This variable can be used to run scripts for the entire kernel, a
> +specific directory, or for a single file.
>
> - make C=1 CHECK="scripts/coccicheck"
> +For example, to check drivers/bluetooth/bfusb.c, the value 1 is
> +passed to the C variable to check files that make considers
> +need to be compiled.::
>
> -To check only newly edited code, use the value 2 for the C flag, i.e.::
> + make C=1 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
>
> - make C=2 CHECK="scripts/coccicheck"
> +The value 2 is passed to the C variable to check files regardless of
> +whether they need to be compiled or not.::
> +
> + make C=2 CHECK=scripts/coccicheck drivers/bluetooth/bfusb.o
>
> In these modes, which work on a file basis, there is no information
> about semantic patches displayed, and no commit message proposed.
> --
> 2.17.1
>
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
[not found] <ed46e96e-a24b-b3f3-3bdc-cd8f0d50bac9@web.de>
@ 2020-08-11 8:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2020-08-11 8:22 UTC (permalink / raw)
To: Markus Elfring
Cc: Sumera Priyadarsini, Coccinelle, linux-doc, kernel-janitors,
linux-kernel, Jonathan Corbet, Gilles Muller, Julia Lawall,
Masahiro Yamada, Matthew Wilcox, Michal Marek, Nicolas Palix,
Randy Dunlap, Sam Ravnborg, Luc Van Oostenryck
On Tue, Aug 11, 2020 at 10:00:20AM +0200, Markus Elfring wrote:
> > +This variable can be used to run scripts for the entire kernel, a
> > +specific directory, or for a single file.
>
> I imagine that this wording can be improved another bit (as I indicated it before).
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2}
@ 2020-08-11 8:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2020-08-11 8:22 UTC (permalink / raw)
To: Markus Elfring
Cc: Michal Marek, Jonathan Corbet, Nicolas Palix, linux-doc,
kernel-janitors, linux-kernel, Matthew Wilcox, Julia Lawall,
Randy Dunlap, Gilles Muller, Sam Ravnborg, Coccinelle,
Luc Van Oostenryck
On Tue, Aug 11, 2020 at 10:00:20AM +0200, Markus Elfring wrote:
> > +This variable can be used to run scripts for the entire kernel, a
> > +specific directory, or for a single file.
>
> I imagine that this wording can be improved another bit (as I indicated it before).
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-11 19:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 0:23 [PATCH v4] documentation: coccinelle: Improve command example for make C={1,2} Sumera Priyadarsini
2020-08-11 0:23 ` [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2} Sumera Priyadarsini
2020-08-11 16:38 ` [PATCH v4] documentation: coccinelle: Improve command example for make C={1,2} Jonathan Corbet
2020-08-11 19:53 ` [Cocci] [PATCH v4] documentation: coccinelle: Improve command example for make C={1, 2} Julia Lawall
2020-08-11 19:53 ` Julia Lawall
[not found] <ed46e96e-a24b-b3f3-3bdc-cd8f0d50bac9@web.de>
2020-08-11 8:22 ` Greg Kroah-Hartman
2020-08-11 8:22 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.