* [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display
@ 2020-08-10 18:08 Matt Roper
2020-08-10 18:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Matt Roper @ 2020-08-10 18:08 UTC (permalink / raw)
To: intel-gfx
Userspace may still create GEM dumb buffers even on platforms with
disabled or non-existent display. When creating dumb buffers we try to
check the max fb stride for the platform by looking at the first pipe on
the platform. We previously fixed a crash related to accessing the
non-existent PIPE_A in commit 8ac495f624a4 ("drm/i915: Don't oops in
dumb_create ioctl if we have no crtcs") but the crash is back as of
commit eae3da27ba84 ("drm/i915: Get first crtc instead of PIPE_A crtc")
because we now try to iterate over the [uninitialized] crtc list.
Fixes: eae3da27ba84 ("drm/i915: Get first crtc instead of PIPE_A crtc")
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 522c772a2111..47839bafcfe6 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -2723,6 +2723,9 @@ u32 intel_plane_fb_max_stride(struct drm_i915_private *dev_priv,
struct intel_crtc *crtc;
struct intel_plane *plane;
+ if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv))
+ return 0;
+
/*
* We assume the primary plane for pipe A has
* the highest stride limits of them all,
--
2.24.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Don't try to check max stride for disabled/non-existent display
2020-08-10 18:08 [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display Matt Roper
@ 2020-08-10 18:57 ` Patchwork
2020-08-10 19:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-08-10 18:57 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Don't try to check max stride for disabled/non-existent display
URL : https://patchwork.freedesktop.org/series/80479/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.0
Fast mode used, each commit won't be checked separately.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't try to check max stride for disabled/non-existent display
2020-08-10 18:08 [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display Matt Roper
2020-08-10 18:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2020-08-10 19:19 ` Patchwork
2020-08-10 20:53 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-08-10 22:07 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-08-10 19:19 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 7104 bytes --]
== Series Details ==
Series: drm/i915: Don't try to check max stride for disabled/non-existent display
URL : https://patchwork.freedesktop.org/series/80479/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8866 -> Patchwork_18335
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/index.html
Known issues
------------
Here are the changes found in Patchwork_18335 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-byt-j1900/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-apl-guc: [PASS][3] -> [DMESG-WARN][4] ([i915#1635] / [i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-apl-guc/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-apl-guc/igt@i915_module_load@reload.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][5] -> [DMESG-WARN][6] ([i915#62] / [i915#92] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-kbl-x1275/igt@kms_busy@basic@flip.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [PASS][7] -> [DMESG-WARN][8] ([i915#2203])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-icl-y: [INCOMPLETE][13] ([i915#2276]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-icl-y/igt@i915_selftest@live@execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-icl-y/igt@i915_selftest@live@execlists.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b}:
- {fi-tgl-dsi}: [DMESG-WARN][19] ([i915#402]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-tgl-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92]) -> [DMESG-WARN][22] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-kbl-x1275/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [SKIP][23] ([fdo#109271]) -> [DMESG-FAIL][24] ([i915#62])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +6 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2276]: https://gitlab.freedesktop.org/drm/intel/issues/2276
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (44 -> 37)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8866 -> Patchwork_18335
CI-20190529: 20190529
CI_DRM_8866: 14e46145f8add798ffc8d63a53e803749ccd3286 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5766: fc9f95086fc23f7f2226f7603241fbad3a214ee1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18335: 3befe1110b0ed17ccd22b3598dfbd3e7d64bb9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3befe1110b0e drm/i915: Don't try to check max stride for disabled/non-existent display
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/index.html
[-- Attachment #1.2: Type: text/html, Size: 9009 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display
2020-08-10 18:08 [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display Matt Roper
2020-08-10 18:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-08-10 19:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-08-10 20:53 ` Chris Wilson
2020-08-11 3:44 ` Matt Roper
2020-08-10 22:07 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2020-08-10 20:53 UTC (permalink / raw)
To: Matt Roper, intel-gfx
Quoting Matt Roper (2020-08-10 19:08:51)
> Userspace may still create GEM dumb buffers even on platforms with
> disabled or non-existent display. When creating dumb buffers we try to
> check the max fb stride for the platform by looking at the first pipe on
> the platform. We previously fixed a crash related to accessing the
> non-existent PIPE_A in commit 8ac495f624a4 ("drm/i915: Don't oops in
> dumb_create ioctl if we have no crtcs") but the crash is back as of
> commit eae3da27ba84 ("drm/i915: Get first crtc instead of PIPE_A crtc")
> because we now try to iterate over the [uninitialized] crtc list.
drm_mode_config_init() is still being called
i915_driver_probe
-> i915_driver_modeset_probe_noirq
-> intel_modeset_init_noirq
-> intel_mode_config_init
-> drm_mode_config_init
regardless of the status for HAS_DISPLAY or INTEL_DISPLAY_ENABLED. So
drm_crtc_index(0) should be returning NULL?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't try to check max stride for disabled/non-existent display
2020-08-10 18:08 [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display Matt Roper
` (2 preceding siblings ...)
2020-08-10 20:53 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-08-10 22:07 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-08-10 22:07 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 16772 bytes --]
== Series Details ==
Series: drm/i915: Don't try to check max stride for disabled/non-existent display
URL : https://patchwork.freedesktop.org/series/80479/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8866_full -> Patchwork_18335_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18335_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@smoketest-all:
- shard-glk: [PASS][1] -> [DMESG-WARN][2] ([i915#118] / [i915#95]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-glk2/igt@gem_exec_schedule@smoketest-all.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-glk2/igt@gem_exec_schedule@smoketest-all.html
* igt@gem_reg_read@timestamp-monotonic:
- shard-iclb: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-iclb8/igt@gem_reg_read@timestamp-monotonic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-iclb2/igt@gem_reg_read@timestamp-monotonic.html
* igt@i915_selftest@mock@contexts:
- shard-apl: [PASS][5] -> [INCOMPLETE][6] ([i915#1635])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-apl8/igt@i915_selftest@mock@contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-apl4/igt@i915_selftest@mock@contexts.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-glk: [PASS][7] -> [DMESG-FAIL][8] ([i915#118] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-glk6/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_color@pipe-b-ctm-negative:
- shard-skl: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +14 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl4/igt@kms_color@pipe-b-ctm-negative.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl10/igt@kms_color@pipe-b-ctm-negative.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#1635] / [i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-apl1/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-kbl1/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-kbl3/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#79])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#79]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-glk1/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1:
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([i915#2055])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2122])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_flip_tiling@flip-to-y-tiled:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#167])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl2/igt@kms_flip_tiling@flip-to-y-tiled.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl5/igt@kms_flip_tiling@flip-to-y-tiled.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#49])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-render:
- shard-tglb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-tglb2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-tglb1/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +4 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-kbl7/igt@kms_hdr@bpc-switch-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145] / [i915#265])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][33] -> [DMESG-FAIL][34] ([fdo#108145] / [i915#1982])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@blocking-parameterized:
- shard-iclb: [PASS][37] -> [FAIL][38] ([i915#1542])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-iclb5/igt@perf@blocking-parameterized.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-iclb7/igt@perf@blocking-parameterized.html
#### Possible fixes ####
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][39] ([i915#2190]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-tglb6/igt@gem_huc_copy@huc-copy.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-tglb8/igt@gem_huc_copy@huc-copy.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-glk: [DMESG-WARN][41] ([i915#118] / [i915#95]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-glk1/igt@kms_color@pipe-a-ctm-0-75.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-glk9/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-glk: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- shard-apl: [DMESG-WARN][45] ([i915#1635] / [i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-apl1/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-apl6/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
* igt@kms_flip@2x-nonexisting-fb@ab-vga1-hdmi-a1:
- shard-hsw: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-hsw6/igt@kms_flip@2x-nonexisting-fb@ab-vga1-hdmi-a1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-hsw5/igt@kms_flip@2x-nonexisting-fb@ab-vga1-hdmi-a1.html
* igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1:
- shard-kbl: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-kbl4/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-kbl7/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +7 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-ts-check@b-edp1:
- shard-skl: [FAIL][53] ([i915#2122]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl10/igt@kms_flip@plain-flip-ts-check@b-edp1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl4/igt@kms_flip@plain-flip-ts-check@b-edp1.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-tglb3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-tglb1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][57] ([i915#1188]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
- shard-skl: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][61] ([fdo#108145] / [i915#265]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][63] ([fdo#109441]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_cpu.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][65] ([i915#31]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-kbl3/igt@kms_setmode@basic.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-kbl1/igt@kms_setmode@basic.html
* {igt@syncobj_timeline@wait-any-snapshot}:
- shard-glk: [FAIL][67] -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-glk7/igt@syncobj_timeline@wait-any-snapshot.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-glk1/igt@syncobj_timeline@wait-any-snapshot.html
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-apl: [TIMEOUT][69] ([i915#1635] / [i915#1958]) -> [INCOMPLETE][70] ([i915#1635] / [i915#1958])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-apl7/igt@gem_exec_reloc@basic-concurrent16.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-apl2/igt@gem_exec_reloc@basic-concurrent16.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][71] ([i915#588]) -> [SKIP][72] ([i915#658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][73] ([fdo#108145] / [i915#265]) -> [DMESG-WARN][74] ([i915#1982])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8866/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#167]: https://gitlab.freedesktop.org/drm/intel/issues/167
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8866 -> Patchwork_18335
CI-20190529: 20190529
CI_DRM_8866: 14e46145f8add798ffc8d63a53e803749ccd3286 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5766: fc9f95086fc23f7f2226f7603241fbad3a214ee1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18335: 3befe1110b0ed17ccd22b3598dfbd3e7d64bb9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18335/index.html
[-- Attachment #1.2: Type: text/html, Size: 20232 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display
2020-08-10 20:53 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-08-11 3:44 ` Matt Roper
0 siblings, 0 replies; 6+ messages in thread
From: Matt Roper @ 2020-08-11 3:44 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Mon, Aug 10, 2020 at 09:53:44PM +0100, Chris Wilson wrote:
> Quoting Matt Roper (2020-08-10 19:08:51)
> > Userspace may still create GEM dumb buffers even on platforms with
> > disabled or non-existent display. When creating dumb buffers we try to
> > check the max fb stride for the platform by looking at the first pipe on
> > the platform. We previously fixed a crash related to accessing the
> > non-existent PIPE_A in commit 8ac495f624a4 ("drm/i915: Don't oops in
> > dumb_create ioctl if we have no crtcs") but the crash is back as of
> > commit eae3da27ba84 ("drm/i915: Get first crtc instead of PIPE_A crtc")
> > because we now try to iterate over the [uninitialized] crtc list.
>
> drm_mode_config_init() is still being called
> i915_driver_probe
> -> i915_driver_modeset_probe_noirq
> -> intel_modeset_init_noirq
> -> intel_mode_config_init
> -> drm_mode_config_init
> regardless of the status for HAS_DISPLAY or INTEL_DISPLAY_ENABLED. So
> drm_crtc_index(0) should be returning NULL?
Ah, you're right. The kernel that I was looking at the backtrace from
was a bit different than drm-tip and had a different initialization
flow. Looks like drm-tip doesn't suffer from the same problem and we
don't need this patch after all.
Matt
> -Chris
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-11 3:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 18:08 [Intel-gfx] [PATCH] drm/i915: Don't try to check max stride for disabled/non-existent display Matt Roper
2020-08-10 18:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-08-10 19:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-10 20:53 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-08-11 3:44 ` Matt Roper
2020-08-10 22:07 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.