From: Mark Brown <broonie@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, tiwai@suse.com, john.stultz@linaro.org
Subject: Re: [PATCH 1/2] ASoC: q6afe-dai: add dummy register read function
Date: Tue, 11 Aug 2020 12:36:50 +0100 [thread overview]
Message-ID: <20200811113650.GE6967@sirena.org.uk> (raw)
In-Reply-To: <20200811110409.GA1481@gerhold.net>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Tue, Aug 11, 2020 at 01:04:09PM +0200, Stephan Gerhold wrote:
> Actually q6afe-dai does not seem to make use of the register number.
> The DAPM widgets all look like
> SND_SOC_DAPM_AIF_IN("HDMI_RX", NULL, 0, 0, 0, 0),
> /* (wname, stname, wchan, wreg, wshift, winvert)
> Wouldn't it be better to replace wreg = 0 with SND_SOC_NOPM in this case
> so the read/write won't happen at all?
Yes, if they are not used at all then that's what _NOPM is for.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, john.stultz@linaro.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH 1/2] ASoC: q6afe-dai: add dummy register read function
Date: Tue, 11 Aug 2020 12:36:50 +0100 [thread overview]
Message-ID: <20200811113650.GE6967@sirena.org.uk> (raw)
In-Reply-To: <20200811110409.GA1481@gerhold.net>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Tue, Aug 11, 2020 at 01:04:09PM +0200, Stephan Gerhold wrote:
> Actually q6afe-dai does not seem to make use of the register number.
> The DAPM widgets all look like
> SND_SOC_DAPM_AIF_IN("HDMI_RX", NULL, 0, 0, 0, 0),
> /* (wname, stname, wchan, wreg, wshift, winvert)
> Wouldn't it be better to replace wreg = 0 with SND_SOC_NOPM in this case
> so the read/write won't happen at all?
Yes, if they are not used at all then that's what _NOPM is for.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-11 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 10:25 [PATCH 1/2] ASoC: q6afe-dai: add dummy register read function Srinivas Kandagatla
2020-08-11 10:25 ` Srinivas Kandagatla
2020-08-11 10:25 ` [PATCH 2/2] ASoC: q6routing: " Srinivas Kandagatla
2020-08-11 10:25 ` Srinivas Kandagatla
2020-08-11 11:04 ` [PATCH 1/2] ASoC: q6afe-dai: " Stephan Gerhold
2020-08-11 11:04 ` Stephan Gerhold
2020-08-11 11:16 ` Srinivas Kandagatla
2020-08-11 11:16 ` Srinivas Kandagatla
2020-08-11 11:36 ` Mark Brown [this message]
2020-08-11 11:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811113650.GE6967@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=john.stultz@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.