* [drm-intel:drm-intel-next-queued 27/28] drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
@ 2020-08-11 19:41 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-08-11 19:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all, Matthew Auld, dri-devel
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head: 06b108297b5cc24418e91c1103587ac7ca6fd03f
commit: 1d567ec619333e54283dcd02780ab9a71ef86e44 [27/28] drm/i915/gt: Switch to object allocations for page directories
config: i386-randconfig-c001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:322:7-9: ERROR: iterator variable bound on line 321 cannot be NULL
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38242 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] [drm-intel:drm-intel-next-queued 27/28] drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
@ 2020-08-11 19:41 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-08-11 19:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all, Matthew Auld, dri-devel
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head: 06b108297b5cc24418e91c1103587ac7ca6fd03f
commit: 1d567ec619333e54283dcd02780ab9a71ef86e44 [27/28] drm/i915/gt: Switch to object allocations for page directories
config: i386-randconfig-c001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:322:7-9: ERROR: iterator variable bound on line 321 cannot be NULL
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38242 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [drm-intel:drm-intel-next-queued 27/28] drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
@ 2020-08-11 19:41 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-08-11 19:41 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head: 06b108297b5cc24418e91c1103587ac7ca6fd03f
commit: 1d567ec619333e54283dcd02780ab9a71ef86e44 [27/28] drm/i915/gt: Switch to object allocations for page directories
config: i386-randconfig-c001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:322:7-9: ERROR: iterator variable bound on line 321 cannot be NULL
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38242 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/i915/gt: fix itnull.cocci warnings
2020-08-11 19:41 ` [Intel-gfx] " kernel test robot
(?)
@ 2020-08-11 19:41 ` kernel test robot
-1 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-08-11 19:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all, Matthew Auld, dri-devel
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:322:7-9: ERROR: iterator variable bound on line 321 cannot be NULL
Many iterators have the property that the first argument is always bound
to a real list element, never NULL.
Semantic patch information:
False positives arise for some iterators that do not have this property,
or in cases when the loop cursor is reassigned. The latter should only
happen when the matched code is on the way to a loop exit (break, goto,
or return).
Generated by: scripts/coccinelle/iterators/itnull.cocci
Fixes: 1d567ec61933 ("drm/i915/gt: Switch to object allocations for page directories")
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head: 06b108297b5cc24418e91c1103587ac7ca6fd03f
commit: 1d567ec619333e54283dcd02780ab9a71ef86e44 [27/28] drm/i915/gt: Switch to object allocations for page directories
Please take the patch only if it's a positive warning. Thanks!
gen6_ppgtt.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
@@ -260,8 +260,9 @@ static void gen6_ppgtt_free_pd(struct ge
u32 pde;
gen6_for_all_pdes(pt, pd, pde)
- if (pt)
- free_px(&ppgtt->base.vm, pt);
+ {
+ free_px(&ppgtt->base.vm, pt);
+ }
}
static void gen6_ppgtt_cleanup(struct i915_address_space *vm)
@@ -319,7 +320,7 @@ static void pd_vma_unbind(struct i915_ad
/* Free all no longer used page tables */
gen6_for_all_pdes(pt, ppgtt->base.pd, pde) {
- if (!pt || atomic_read(&pt->used))
+ if (atomic_read(&pt->used))
continue;
free_px(&ppgtt->base.vm, pt);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/gt: fix itnull.cocci warnings
@ 2020-08-11 19:41 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-08-11 19:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kbuild-all, Matthew Auld, dri-devel
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:322:7-9: ERROR: iterator variable bound on line 321 cannot be NULL
Many iterators have the property that the first argument is always bound
to a real list element, never NULL.
Semantic patch information:
False positives arise for some iterators that do not have this property,
or in cases when the loop cursor is reassigned. The latter should only
happen when the matched code is on the way to a loop exit (break, goto,
or return).
Generated by: scripts/coccinelle/iterators/itnull.cocci
Fixes: 1d567ec61933 ("drm/i915/gt: Switch to object allocations for page directories")
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head: 06b108297b5cc24418e91c1103587ac7ca6fd03f
commit: 1d567ec619333e54283dcd02780ab9a71ef86e44 [27/28] drm/i915/gt: Switch to object allocations for page directories
Please take the patch only if it's a positive warning. Thanks!
gen6_ppgtt.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
@@ -260,8 +260,9 @@ static void gen6_ppgtt_free_pd(struct ge
u32 pde;
gen6_for_all_pdes(pt, pd, pde)
- if (pt)
- free_px(&ppgtt->base.vm, pt);
+ {
+ free_px(&ppgtt->base.vm, pt);
+ }
}
static void gen6_ppgtt_cleanup(struct i915_address_space *vm)
@@ -319,7 +320,7 @@ static void pd_vma_unbind(struct i915_ad
/* Free all no longer used page tables */
gen6_for_all_pdes(pt, ppgtt->base.pd, pde) {
- if (!pt || atomic_read(&pt->used))
+ if (atomic_read(&pt->used))
continue;
free_px(&ppgtt->base.vm, pt);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/i915/gt: fix itnull.cocci warnings
@ 2020-08-11 19:41 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-08-11 19:41 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL
drivers/gpu/drm/i915/gt/gen6_ppgtt.c:322:7-9: ERROR: iterator variable bound on line 321 cannot be NULL
Many iterators have the property that the first argument is always bound
to a real list element, never NULL.
Semantic patch information:
False positives arise for some iterators that do not have this property,
or in cases when the loop cursor is reassigned. The latter should only
happen when the matched code is on the way to a loop exit (break, goto,
or return).
Generated by: scripts/coccinelle/iterators/itnull.cocci
Fixes: 1d567ec61933 ("drm/i915/gt: Switch to object allocations for page directories")
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head: 06b108297b5cc24418e91c1103587ac7ca6fd03f
commit: 1d567ec619333e54283dcd02780ab9a71ef86e44 [27/28] drm/i915/gt: Switch to object allocations for page directories
Please take the patch only if it's a positive warning. Thanks!
gen6_ppgtt.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen6_ppgtt.c
@@ -260,8 +260,9 @@ static void gen6_ppgtt_free_pd(struct ge
u32 pde;
gen6_for_all_pdes(pt, pd, pde)
- if (pt)
- free_px(&ppgtt->base.vm, pt);
+ {
+ free_px(&ppgtt->base.vm, pt);
+ }
}
static void gen6_ppgtt_cleanup(struct i915_address_space *vm)
@@ -319,7 +320,7 @@ static void pd_vma_unbind(struct i915_ad
/* Free all no longer used page tables */
gen6_for_all_pdes(pt, ppgtt->base.pd, pde) {
- if (!pt || atomic_read(&pt->used))
+ if (atomic_read(&pt->used))
continue;
free_px(&ppgtt->base.vm, pt);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-11 19:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 19:41 [drm-intel:drm-intel-next-queued 27/28] drivers/gpu/drm/i915/gt/gen6_ppgtt.c:263:6-8: ERROR: iterator variable bound on line 262 cannot be NULL kernel test robot
2020-08-11 19:41 ` kernel test robot
2020-08-11 19:41 ` [Intel-gfx] " kernel test robot
2020-08-11 19:41 ` [PATCH] drm/i915/gt: fix itnull.cocci warnings kernel test robot
2020-08-11 19:41 ` kernel test robot
2020-08-11 19:41 ` [Intel-gfx] " kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.