[PATCH 1/2] hw: ehci: destroy sglist in error path

* [PATCH 1/2] hw: ehci: destroy sglist in error path
@ 2020-08-12 16:17 Li Qiang
  0 siblings, 0 replies; only message in thread
From: Li Qiang @ 2020-08-12 16:17 UTC (permalink / raw)
  To: kraxel; +Cc: Li Qiang, liq3ea, qemu-devel

This may cause resource leak.

Signed-off-by: Li Qiang <liq3ea@163.com>
---
 hw/usb/hcd-ehci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 1495e8f7fa..58cceacbf8 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -1445,6 +1445,7 @@ static int ehci_process_itd(EHCIState *ehci,
             dev = ehci_find_device(ehci, devaddr);
             if (dev == NULL) {
                 ehci_trace_guest_bug(ehci, "no device found");
+                qemu_sglist_destroy(&ehci->isgl);
                 return -1;
             }
             pid = dir ? USB_TOKEN_IN : USB_TOKEN_OUT;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] only message in thread