All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/4] dt-bindings: media: ov5647: Convert to dt-schema
@ 2020-08-10 21:55 Jacopo Mondi
  2020-08-10 21:55 ` [PATCH v4 1/4] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Jacopo Mondi @ 2020-08-10 21:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, linux-renesas-soc, laurent.pinchart,
	roman.kovalivskyi

Hello,
   re-based on latest media master with small typographical updates to the
bindings document.

The series collects patches which have been sent to the list as part of
of two separate series.

I've not been able to get in touch with the sensor driver last maintainer
of the driver (Luis Oliveira)

Thanks
  j

v2->v3:
- Expand the series with two additional patches
- Make 'remote-endpoint' not required: we allow empty endpoints, to be filled
  in with overlays
- End all senteces with a full stop for consistency

Jacopo Mondi (4):
  dt-bindings: media: ov5647: Convert to json-schema
  dt-bindings: media: ov5647: Document pwdn-gpios
  dt-bindings: media: ov5647: Document clock-noncontinuous
  media: MAINTAINERS: ov5647: Replace maintainer

 .../devicetree/bindings/media/i2c/ov5647.txt  | 35 --------
 .../devicetree/bindings/media/i2c/ov5647.yaml | 88 +++++++++++++++++++
 MAINTAINERS                                   |  4 +-
 3 files changed, 91 insertions(+), 36 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml

--
2.27.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v4 1/4] dt-bindings: media: ov5647: Convert to json-schema
  2020-08-10 21:55 [PATCH v4 0/4] dt-bindings: media: ov5647: Convert to dt-schema Jacopo Mondi
@ 2020-08-10 21:55 ` Jacopo Mondi
  2020-08-10 21:55 ` [PATCH v4 2/4] dt-bindings: media: ov5647: Document pwdn-gpios Jacopo Mondi
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Jacopo Mondi @ 2020-08-10 21:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, linux-renesas-soc, laurent.pinchart,
	roman.kovalivskyi, Rob Herring

Convert the ov5647 image sensor bindings to DT schema and add
the file entry to MAINTAINERS.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 .../devicetree/bindings/media/i2c/ov5647.txt  | 35 ---------
 .../devicetree/bindings/media/i2c/ov5647.yaml | 77 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 3 files changed, 78 insertions(+), 35 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt
deleted file mode 100644
index 22e44945b661..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/ov5647.txt
+++ /dev/null
@@ -1,35 +0,0 @@
-Omnivision OV5647 raw image sensor
----------------------------------
-
-OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces
-and CCI (I2C compatible) control bus.
-
-Required properties:
-
-- compatible		: "ovti,ov5647".
-- reg			: I2C slave address of the sensor.
-- clocks		: Reference to the xclk clock.
-
-The common video interfaces bindings (see video-interfaces.txt) should be
-used to specify link to the image data receiver. The OV5647 device
-node should contain one 'port' child node with an 'endpoint' subnode.
-
-Endpoint node mandatory properties:
-
-- remote-endpoint: A phandle to the bus receiver's endpoint node.
-
-Example:
-
-	i2c@2000 {
-		...
-		ov: camera@36 {
-			compatible = "ovti,ov5647";
-			reg = <0x36>;
-			clocks = <&camera_clk>;
-			port {
-				camera_1: endpoint {
-					remote-endpoint = <&csi1_ep1>;
-				};
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
new file mode 100644
index 000000000000..1c1d94e805d6
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/ov5647.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Omnivision OV5647 raw image sensor
+
+maintainers:
+  - Dave Stevenson <dave.stevenson@raspberrypi.com>
+  - Jacopo Mondi <jacopo@jmondi.org>
+
+description: |-
+  The OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data
+  interfaces and CCI (I2C compatible) control bus.
+
+properties:
+  compatible:
+    const: ovti,ov5647
+
+  reg:
+    description: I2C device address.
+    maxItems: 1
+
+  clocks:
+    description: Reference to the xclk clock.
+    maxItems: 1
+
+  port:
+    type: object
+    description: |-
+      Should contain one endpoint sub-node used to model connection to the
+      video receiver according to the specification defined in
+      Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+    properties:
+      endpoint:
+        type: object
+
+        properties:
+          remote-endpoint:
+            description: |-
+              phandle to the video receiver input port.
+
+        additionalProperties: false
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ov5647: camera@36 {
+            compatible = "ovti,ov5647";
+            reg = <0x36>;
+            clocks = <&camera_clk>;
+
+            port {
+                camera_out: endpoint {
+                    remote-endpoint = <&csi1_ep1>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 5392f00cec46..21e6c3120152 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12629,6 +12629,7 @@ M:	Luis Oliveira <lolivei@synopsys.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
+F:	Documentation/devicetree/bindings/media/i2c/ov5647.yaml
 F:	drivers/media/i2c/ov5647.c

 OMNIVISION OV5670 SENSOR DRIVER
--
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v4 2/4] dt-bindings: media: ov5647: Document pwdn-gpios
  2020-08-10 21:55 [PATCH v4 0/4] dt-bindings: media: ov5647: Convert to dt-schema Jacopo Mondi
  2020-08-10 21:55 ` [PATCH v4 1/4] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
@ 2020-08-10 21:55 ` Jacopo Mondi
  2020-08-12 19:15   ` Rob Herring
  2020-08-10 21:55 ` [PATCH v4 3/4] dt-bindings: media: ov5647: Document clock-noncontinuous Jacopo Mondi
  2020-08-10 21:55 ` [PATCH v4 4/4] media: MAINTAINERS: ov5647: Replace maintainer Jacopo Mondi
  3 siblings, 1 reply; 8+ messages in thread
From: Jacopo Mondi @ 2020-08-10 21:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, linux-renesas-soc, laurent.pinchart,
	roman.kovalivskyi, Jacopo Mondi

From: Jacopo Mondi <jacopo@jmondi.org>

Document in dt-schema bindings for the ov5647 sensor the optional
'pwdn-gpios' property.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 Documentation/devicetree/bindings/media/i2c/ov5647.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
index 1c1d94e805d6..9f76897f52e3 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
@@ -26,6 +26,10 @@ properties:
     description: Reference to the xclk clock.
     maxItems: 1
 
+  pwdn-gpios:
+    description: Reference to the GPIO connected to the pwdn pin. Active high.
+    maxItems: 1
+
   port:
     type: object
     description: |-
@@ -56,6 +60,7 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/gpio/gpio.h>
 
     i2c {
         #address-cells = <1>;
@@ -65,6 +70,7 @@ examples:
             compatible = "ovti,ov5647";
             reg = <0x36>;
             clocks = <&camera_clk>;
+            pwdn-gpios = <&pioE 29 GPIO_ACTIVE_HIGH>;
 
             port {
                 camera_out: endpoint {
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v4 3/4] dt-bindings: media: ov5647: Document clock-noncontinuous
  2020-08-10 21:55 [PATCH v4 0/4] dt-bindings: media: ov5647: Convert to dt-schema Jacopo Mondi
  2020-08-10 21:55 ` [PATCH v4 1/4] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
  2020-08-10 21:55 ` [PATCH v4 2/4] dt-bindings: media: ov5647: Document pwdn-gpios Jacopo Mondi
@ 2020-08-10 21:55 ` Jacopo Mondi
  2020-08-12 19:15   ` Rob Herring
  2020-08-10 21:55 ` [PATCH v4 4/4] media: MAINTAINERS: ov5647: Replace maintainer Jacopo Mondi
  3 siblings, 1 reply; 8+ messages in thread
From: Jacopo Mondi @ 2020-08-10 21:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, linux-renesas-soc, laurent.pinchart,
	roman.kovalivskyi, Jacopo Mondi

From: Jacopo Mondi <jacopo@jmondi.org>

Document the optional clock-noncontinuous endpoint property that
allows enabling MIPI CSI-2 non-continuous clock operations.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 Documentation/devicetree/bindings/media/i2c/ov5647.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
index 9f76897f52e3..280c62afae13 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ov5647.yaml
@@ -46,6 +46,11 @@ properties:
             description: |-
               phandle to the video receiver input port.
 
+          clock-noncontinuous:
+            type: boolean
+            description: |-
+              Set to true to allow MIPI CSI-2 non-continuous clock operations.
+
         additionalProperties: false
 
     additionalProperties: false
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v4 4/4] media: MAINTAINERS: ov5647: Replace maintainer
  2020-08-10 21:55 [PATCH v4 0/4] dt-bindings: media: ov5647: Convert to dt-schema Jacopo Mondi
                   ` (2 preceding siblings ...)
  2020-08-10 21:55 ` [PATCH v4 3/4] dt-bindings: media: ov5647: Document clock-noncontinuous Jacopo Mondi
@ 2020-08-10 21:55 ` Jacopo Mondi
  2020-08-11  9:22   ` Dave Stevenson
  3 siblings, 1 reply; 8+ messages in thread
From: Jacopo Mondi @ 2020-08-10 21:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-media
  Cc: Jacopo Mondi, mchehab, sakari.ailus, hverkuil-cisco,
	dave.stevenson, linux-renesas-soc, laurent.pinchart,
	roman.kovalivskyi

Since the current maintainer email address bounces back, replace
the entry and make myself and Dave Stevenson maintainers of the driver.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 21e6c3120152..6a9d87282578 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12625,7 +12625,8 @@ T:	git git://linuxtv.org/media_tree.git
 F:	drivers/media/i2c/ov5640.c
 
 OMNIVISION OV5647 SENSOR DRIVER
-M:	Luis Oliveira <lolivei@synopsys.com>
+M:	Dave Stevenson <dave.stevenson@raspberrypi.com>
+M:	Jacopo Mondi <jacopo@jmondi.org>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 4/4] media: MAINTAINERS: ov5647: Replace maintainer
  2020-08-10 21:55 ` [PATCH v4 4/4] media: MAINTAINERS: ov5647: Replace maintainer Jacopo Mondi
@ 2020-08-11  9:22   ` Dave Stevenson
  0 siblings, 0 replies; 8+ messages in thread
From: Dave Stevenson @ 2020-08-11  9:22 UTC (permalink / raw)
  To: Jacopo Mondi
  Cc: robh+dt, devicetree, Linux Media Mailing List,
	Mauro Carvalho Chehab, Sakari Ailus, Hans Verkuil,
	linux-renesas-soc, Laurent Pinchart, Roman Kovalivskyi

On Mon, 10 Aug 2020 at 22:52, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
>
> Since the current maintainer email address bounces back, replace
> the entry and make myself and Dave Stevenson maintainers of the driver.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 21e6c3120152..6a9d87282578 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12625,7 +12625,8 @@ T:      git git://linuxtv.org/media_tree.git
>  F:     drivers/media/i2c/ov5640.c
>
>  OMNIVISION OV5647 SENSOR DRIVER
> -M:     Luis Oliveira <lolivei@synopsys.com>
> +M:     Dave Stevenson <dave.stevenson@raspberrypi.com>
> +M:     Jacopo Mondi <jacopo@jmondi.org>
>  L:     linux-media@vger.kernel.org
>  S:     Maintained
>  T:     git git://linuxtv.org/media_tree.git
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 2/4] dt-bindings: media: ov5647: Document pwdn-gpios
  2020-08-10 21:55 ` [PATCH v4 2/4] dt-bindings: media: ov5647: Document pwdn-gpios Jacopo Mondi
@ 2020-08-12 19:15   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-08-12 19:15 UTC (permalink / raw)
  To: Jacopo Mondi
  Cc: linux-media, devicetree, mchehab, sakari.ailus,
	linux-renesas-soc, dave.stevenson, laurent.pinchart,
	Jacopo Mondi, robh+dt, roman.kovalivskyi, hverkuil-cisco

On Mon, 10 Aug 2020 23:55:41 +0200, Jacopo Mondi wrote:
> From: Jacopo Mondi <jacopo@jmondi.org>
> 
> Document in dt-schema bindings for the ov5647 sensor the optional
> 'pwdn-gpios' property.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/ov5647.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 3/4] dt-bindings: media: ov5647: Document clock-noncontinuous
  2020-08-10 21:55 ` [PATCH v4 3/4] dt-bindings: media: ov5647: Document clock-noncontinuous Jacopo Mondi
@ 2020-08-12 19:15   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-08-12 19:15 UTC (permalink / raw)
  To: Jacopo Mondi
  Cc: Jacopo Mondi, mchehab, sakari.ailus, linux-renesas-soc,
	laurent.pinchart, roman.kovalivskyi, dave.stevenson, linux-media,
	devicetree, hverkuil-cisco, robh+dt

On Mon, 10 Aug 2020 23:55:42 +0200, Jacopo Mondi wrote:
> From: Jacopo Mondi <jacopo@jmondi.org>
> 
> Document the optional clock-noncontinuous endpoint property that
> allows enabling MIPI CSI-2 non-continuous clock operations.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/ov5647.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-08-12 19:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 21:55 [PATCH v4 0/4] dt-bindings: media: ov5647: Convert to dt-schema Jacopo Mondi
2020-08-10 21:55 ` [PATCH v4 1/4] dt-bindings: media: ov5647: Convert to json-schema Jacopo Mondi
2020-08-10 21:55 ` [PATCH v4 2/4] dt-bindings: media: ov5647: Document pwdn-gpios Jacopo Mondi
2020-08-12 19:15   ` Rob Herring
2020-08-10 21:55 ` [PATCH v4 3/4] dt-bindings: media: ov5647: Document clock-noncontinuous Jacopo Mondi
2020-08-12 19:15   ` Rob Herring
2020-08-10 21:55 ` [PATCH v4 4/4] media: MAINTAINERS: ov5647: Replace maintainer Jacopo Mondi
2020-08-11  9:22   ` Dave Stevenson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.