* [PATCH 00/20] Convert all remaining drivers to GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The GEM and PRIME related callbacks in struct drm_driver are deprecated in
favor of GEM object functions in struct drm_gem_object_funcs. This patchset
converts the remaining drivers to object functions and removes most of the
obsolete interfaces.
Patches #1 to #18 convert DRM drivers to GEM object functions, one by one.
Each patch moves existing callbacks from struct drm_driver to an instance
of struct drm_gem_object_funcs, and sets these funcs when the GEM object is
initialized. The expection is .gem_prime_mmap. There are different ways of
how drivers implement the callback, and moving it to GEM object functions
requires a closer review for each.
Patch #19 converts xlnx to CMA helper macros. There's no apparent reason
why the driver does the GEM setup on it's own. Using CMA helper macros
adds GEM object functions implicitly.
With most of the GEM and PRIME moved to GEM object functions, related code
in struct drm_driver and in the DRM core/helpers is being removed by patch
#20.
Further testing is welcome. I tested the drivers for which I have HW
available, which are gma500, i915, nouveau, radeon and vc4. The console,
Weston and Xorg apparently work with the patches applied.
Thomas Zimmermann (20):
drm/amdgpu: Introduce GEM object functions
drm/armada: Introduce GEM object functions
drm/etnaviv: Introduce GEM object functions
drm/exynos: Introduce GEM object functions
drm/gma500: Introduce GEM object functions
drm/i915: Introduce GEM object functions
drm/mediatek: Introduce GEM object functions
drm/msm: Introduce GEM object funcs
drm/nouveau: Introduce GEM object functions
drm/omapdrm: Introduce GEM object functions
drm/pl111: Introduce GEM object functions
drm/radeon: Introduce GEM object functions
drm/rockchip: Convert to drm_gem_object_funcs
drm/tegra: Introduce GEM object functions
drm/vc4: Introduce GEM object functions
drm/vgem: Introduce GEM object functions
drm/vkms: Introduce GEM object functions
drm/xen: Introduce GEM object functions
drm/xlnx: Initialize DRM driver instance with CMA helper macro
drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 +++
drivers/gpu/drm/armada/armada_drv.c | 3 -
drivers/gpu/drm/armada/armada_gem.c | 12 ++-
drivers/gpu/drm/armada/armada_gem.h | 2 -
drivers/gpu/drm/drm_gem.c | 35 ++------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 ++--
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 ---
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++-
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 ++++
drivers/gpu/drm/gma500/framebuffer.c | 2 +
drivers/gpu/drm/gma500/gem.c | 18 +++-
drivers/gpu/drm/gma500/gem.h | 3 +
drivers/gpu/drm/gma500/psb_drv.c | 9 --
drivers/gpu/drm/gma500/psb_drv.h | 2 -
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 +-
drivers/gpu/drm/i915/i915_drv.c | 10 ++-
drivers/gpu/drm/i915/i915_drv.h | 1 +
.../gpu/drm/i915/selftests/mock_gem_device.c | 3 -
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 --
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++
drivers/gpu/drm/msm/msm_drv.c | 13 ---
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++-
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 --
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 +
drivers/gpu/drm/omapdrm/omap_drv.c | 9 --
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
drivers/gpu/drm/pl111/pl111_drv.c | 28 +++++-
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 --
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 +++
drivers/gpu/drm/tegra/drm.c | 4 -
drivers/gpu/drm/tegra/gem.c | 8 ++
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ---
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
drivers/gpu/drm/vgem/vgem_drv.c | 21 +++--
drivers/gpu/drm/vkms/vkms_drv.c | 8 --
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++
drivers/gpu/drm/xen/xen_drm_front.c | 12 +--
drivers/gpu/drm/xen/xen_drm_front.h | 2 +
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 ++++
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +--
include/drm/drm_drv.h | 85 +------------------
52 files changed, 311 insertions(+), 306 deletions(-)
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread
* [Intel-gfx] [PATCH 00/20] Convert all remaining drivers to GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The GEM and PRIME related callbacks in struct drm_driver are deprecated in
favor of GEM object functions in struct drm_gem_object_funcs. This patchset
converts the remaining drivers to object functions and removes most of the
obsolete interfaces.
Patches #1 to #18 convert DRM drivers to GEM object functions, one by one.
Each patch moves existing callbacks from struct drm_driver to an instance
of struct drm_gem_object_funcs, and sets these funcs when the GEM object is
initialized. The expection is .gem_prime_mmap. There are different ways of
how drivers implement the callback, and moving it to GEM object functions
requires a closer review for each.
Patch #19 converts xlnx to CMA helper macros. There's no apparent reason
why the driver does the GEM setup on it's own. Using CMA helper macros
adds GEM object functions implicitly.
With most of the GEM and PRIME moved to GEM object functions, related code
in struct drm_driver and in the DRM core/helpers is being removed by patch
#20.
Further testing is welcome. I tested the drivers for which I have HW
available, which are gma500, i915, nouveau, radeon and vc4. The console,
Weston and Xorg apparently work with the patches applied.
Thomas Zimmermann (20):
drm/amdgpu: Introduce GEM object functions
drm/armada: Introduce GEM object functions
drm/etnaviv: Introduce GEM object functions
drm/exynos: Introduce GEM object functions
drm/gma500: Introduce GEM object functions
drm/i915: Introduce GEM object functions
drm/mediatek: Introduce GEM object functions
drm/msm: Introduce GEM object funcs
drm/nouveau: Introduce GEM object functions
drm/omapdrm: Introduce GEM object functions
drm/pl111: Introduce GEM object functions
drm/radeon: Introduce GEM object functions
drm/rockchip: Convert to drm_gem_object_funcs
drm/tegra: Introduce GEM object functions
drm/vc4: Introduce GEM object functions
drm/vgem: Introduce GEM object functions
drm/vkms: Introduce GEM object functions
drm/xen: Introduce GEM object functions
drm/xlnx: Initialize DRM driver instance with CMA helper macro
drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 +++
drivers/gpu/drm/armada/armada_drv.c | 3 -
drivers/gpu/drm/armada/armada_gem.c | 12 ++-
drivers/gpu/drm/armada/armada_gem.h | 2 -
drivers/gpu/drm/drm_gem.c | 35 ++------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 ++--
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 ---
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++-
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 ++++
drivers/gpu/drm/gma500/framebuffer.c | 2 +
drivers/gpu/drm/gma500/gem.c | 18 +++-
drivers/gpu/drm/gma500/gem.h | 3 +
drivers/gpu/drm/gma500/psb_drv.c | 9 --
drivers/gpu/drm/gma500/psb_drv.h | 2 -
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 +-
drivers/gpu/drm/i915/i915_drv.c | 10 ++-
drivers/gpu/drm/i915/i915_drv.h | 1 +
.../gpu/drm/i915/selftests/mock_gem_device.c | 3 -
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 --
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++
drivers/gpu/drm/msm/msm_drv.c | 13 ---
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++-
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 --
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 +
drivers/gpu/drm/omapdrm/omap_drv.c | 9 --
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
drivers/gpu/drm/pl111/pl111_drv.c | 28 +++++-
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 --
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 +++
drivers/gpu/drm/tegra/drm.c | 4 -
drivers/gpu/drm/tegra/gem.c | 8 ++
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ---
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
drivers/gpu/drm/vgem/vgem_drv.c | 21 +++--
drivers/gpu/drm/vkms/vkms_drv.c | 8 --
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++
drivers/gpu/drm/xen/xen_drm_front.c | 12 +--
drivers/gpu/drm/xen/xen_drm_front.h | 2 +
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 ++++
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +--
include/drm/drm_drv.h | 85 +------------------
52 files changed, 311 insertions(+), 306 deletions(-)
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 00/20] Convert all remaining drivers to GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The GEM and PRIME related callbacks in struct drm_driver are deprecated in
favor of GEM object functions in struct drm_gem_object_funcs. This patchset
converts the remaining drivers to object functions and removes most of the
obsolete interfaces.
Patches #1 to #18 convert DRM drivers to GEM object functions, one by one.
Each patch moves existing callbacks from struct drm_driver to an instance
of struct drm_gem_object_funcs, and sets these funcs when the GEM object is
initialized. The expection is .gem_prime_mmap. There are different ways of
how drivers implement the callback, and moving it to GEM object functions
requires a closer review for each.
Patch #19 converts xlnx to CMA helper macros. There's no apparent reason
why the driver does the GEM setup on it's own. Using CMA helper macros
adds GEM object functions implicitly.
With most of the GEM and PRIME moved to GEM object functions, related code
in struct drm_driver and in the DRM core/helpers is being removed by patch
#20.
Further testing is welcome. I tested the drivers for which I have HW
available, which are gma500, i915, nouveau, radeon and vc4. The console,
Weston and Xorg apparently work with the patches applied.
Thomas Zimmermann (20):
drm/amdgpu: Introduce GEM object functions
drm/armada: Introduce GEM object functions
drm/etnaviv: Introduce GEM object functions
drm/exynos: Introduce GEM object functions
drm/gma500: Introduce GEM object functions
drm/i915: Introduce GEM object functions
drm/mediatek: Introduce GEM object functions
drm/msm: Introduce GEM object funcs
drm/nouveau: Introduce GEM object functions
drm/omapdrm: Introduce GEM object functions
drm/pl111: Introduce GEM object functions
drm/radeon: Introduce GEM object functions
drm/rockchip: Convert to drm_gem_object_funcs
drm/tegra: Introduce GEM object functions
drm/vc4: Introduce GEM object functions
drm/vgem: Introduce GEM object functions
drm/vkms: Introduce GEM object functions
drm/xen: Introduce GEM object functions
drm/xlnx: Initialize DRM driver instance with CMA helper macro
drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 +++
drivers/gpu/drm/armada/armada_drv.c | 3 -
drivers/gpu/drm/armada/armada_gem.c | 12 ++-
drivers/gpu/drm/armada/armada_gem.h | 2 -
drivers/gpu/drm/drm_gem.c | 35 ++------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 ++--
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 ---
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++-
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 ++++
drivers/gpu/drm/gma500/framebuffer.c | 2 +
drivers/gpu/drm/gma500/gem.c | 18 +++-
drivers/gpu/drm/gma500/gem.h | 3 +
drivers/gpu/drm/gma500/psb_drv.c | 9 --
drivers/gpu/drm/gma500/psb_drv.h | 2 -
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 +-
drivers/gpu/drm/i915/i915_drv.c | 10 ++-
drivers/gpu/drm/i915/i915_drv.h | 1 +
.../gpu/drm/i915/selftests/mock_gem_device.c | 3 -
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 --
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++
drivers/gpu/drm/msm/msm_drv.c | 13 ---
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++-
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 --
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 +
drivers/gpu/drm/omapdrm/omap_drv.c | 9 --
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
drivers/gpu/drm/pl111/pl111_drv.c | 28 +++++-
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 --
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 +++
drivers/gpu/drm/tegra/drm.c | 4 -
drivers/gpu/drm/tegra/gem.c | 8 ++
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ---
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
drivers/gpu/drm/vgem/vgem_drv.c | 21 +++--
drivers/gpu/drm/vkms/vkms_drv.c | 8 --
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++
drivers/gpu/drm/xen/xen_drm_front.c | 12 +--
drivers/gpu/drm/xen/xen_drm_front.h | 2 +
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 ++++
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +--
include/drm/drm_drv.h | 85 +------------------
52 files changed, 311 insertions(+), 306 deletions(-)
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 00/20] Convert all remaining drivers to GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The GEM and PRIME related callbacks in struct drm_driver are deprecated in
favor of GEM object functions in struct drm_gem_object_funcs. This patchset
converts the remaining drivers to object functions and removes most of the
obsolete interfaces.
Patches #1 to #18 convert DRM drivers to GEM object functions, one by one.
Each patch moves existing callbacks from struct drm_driver to an instance
of struct drm_gem_object_funcs, and sets these funcs when the GEM object is
initialized. The expection is .gem_prime_mmap. There are different ways of
how drivers implement the callback, and moving it to GEM object functions
requires a closer review for each.
Patch #19 converts xlnx to CMA helper macros. There's no apparent reason
why the driver does the GEM setup on it's own. Using CMA helper macros
adds GEM object functions implicitly.
With most of the GEM and PRIME moved to GEM object functions, related code
in struct drm_driver and in the DRM core/helpers is being removed by patch
#20.
Further testing is welcome. I tested the drivers for which I have HW
available, which are gma500, i915, nouveau, radeon and vc4. The console,
Weston and Xorg apparently work with the patches applied.
Thomas Zimmermann (20):
drm/amdgpu: Introduce GEM object functions
drm/armada: Introduce GEM object functions
drm/etnaviv: Introduce GEM object functions
drm/exynos: Introduce GEM object functions
drm/gma500: Introduce GEM object functions
drm/i915: Introduce GEM object functions
drm/mediatek: Introduce GEM object functions
drm/msm: Introduce GEM object funcs
drm/nouveau: Introduce GEM object functions
drm/omapdrm: Introduce GEM object functions
drm/pl111: Introduce GEM object functions
drm/radeon: Introduce GEM object functions
drm/rockchip: Convert to drm_gem_object_funcs
drm/tegra: Introduce GEM object functions
drm/vc4: Introduce GEM object functions
drm/vgem: Introduce GEM object functions
drm/vkms: Introduce GEM object functions
drm/xen: Introduce GEM object functions
drm/xlnx: Initialize DRM driver instance with CMA helper macro
drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 +++
drivers/gpu/drm/armada/armada_drv.c | 3 -
drivers/gpu/drm/armada/armada_gem.c | 12 ++-
drivers/gpu/drm/armada/armada_gem.h | 2 -
drivers/gpu/drm/drm_gem.c | 35 ++------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 ++--
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 ---
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++-
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 ++++
drivers/gpu/drm/gma500/framebuffer.c | 2 +
drivers/gpu/drm/gma500/gem.c | 18 +++-
drivers/gpu/drm/gma500/gem.h | 3 +
drivers/gpu/drm/gma500/psb_drv.c | 9 --
drivers/gpu/drm/gma500/psb_drv.h | 2 -
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 +-
drivers/gpu/drm/i915/i915_drv.c | 10 ++-
drivers/gpu/drm/i915/i915_drv.h | 1 +
.../gpu/drm/i915/selftests/mock_gem_device.c | 3 -
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 --
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++
drivers/gpu/drm/msm/msm_drv.c | 13 ---
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++-
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 --
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 +
drivers/gpu/drm/omapdrm/omap_drv.c | 9 --
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
drivers/gpu/drm/pl111/pl111_drv.c | 28 +++++-
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 --
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 +++
drivers/gpu/drm/tegra/drm.c | 4 -
drivers/gpu/drm/tegra/gem.c | 8 ++
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ---
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
drivers/gpu/drm/vgem/vgem_drv.c | 21 +++--
drivers/gpu/drm/vkms/vkms_drv.c | 8 --
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++
drivers/gpu/drm/xen/xen_drm_front.c | 12 +--
drivers/gpu/drm/xen/xen_drm_front.h | 2 +
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 ++++
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +--
include/drm/drm_drv.h | 85 +------------------
52 files changed, 311 insertions(+), 306 deletions(-)
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 00/20] Convert all remaining drivers to GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
The GEM and PRIME related callbacks in struct drm_driver are deprecated in
favor of GEM object functions in struct drm_gem_object_funcs. This patchset
converts the remaining drivers to object functions and removes most of the
obsolete interfaces.
Patches #1 to #18 convert DRM drivers to GEM object functions, one by one.
Each patch moves existing callbacks from struct drm_driver to an instance
of struct drm_gem_object_funcs, and sets these funcs when the GEM object is
initialized. The expection is .gem_prime_mmap. There are different ways of
how drivers implement the callback, and moving it to GEM object functions
requires a closer review for each.
Patch #19 converts xlnx to CMA helper macros. There's no apparent reason
why the driver does the GEM setup on it's own. Using CMA helper macros
adds GEM object functions implicitly.
With most of the GEM and PRIME moved to GEM object functions, related code
in struct drm_driver and in the DRM core/helpers is being removed by patch
#20.
Further testing is welcome. I tested the drivers for which I have HW
available, which are gma500, i915, nouveau, radeon and vc4. The console,
Weston and Xorg apparently work with the patches applied.
Thomas Zimmermann (20):
drm/amdgpu: Introduce GEM object functions
drm/armada: Introduce GEM object functions
drm/etnaviv: Introduce GEM object functions
drm/exynos: Introduce GEM object functions
drm/gma500: Introduce GEM object functions
drm/i915: Introduce GEM object functions
drm/mediatek: Introduce GEM object functions
drm/msm: Introduce GEM object funcs
drm/nouveau: Introduce GEM object functions
drm/omapdrm: Introduce GEM object functions
drm/pl111: Introduce GEM object functions
drm/radeon: Introduce GEM object functions
drm/rockchip: Convert to drm_gem_object_funcs
drm/tegra: Introduce GEM object functions
drm/vc4: Introduce GEM object functions
drm/vgem: Introduce GEM object functions
drm/vkms: Introduce GEM object functions
drm/xen: Introduce GEM object functions
drm/xlnx: Initialize DRM driver instance with CMA helper macro
drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 --
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 +++
drivers/gpu/drm/armada/armada_drv.c | 3 -
drivers/gpu/drm/armada/armada_gem.c | 12 ++-
drivers/gpu/drm/armada/armada_gem.h | 2 -
drivers/gpu/drm/drm_gem.c | 35 ++------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 ++--
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 ---
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++-
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 ++++
drivers/gpu/drm/gma500/framebuffer.c | 2 +
drivers/gpu/drm/gma500/gem.c | 18 +++-
drivers/gpu/drm/gma500/gem.h | 3 +
drivers/gpu/drm/gma500/psb_drv.c | 9 --
drivers/gpu/drm/gma500/psb_drv.h | 2 -
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 +-
drivers/gpu/drm/i915/i915_drv.c | 10 ++-
drivers/gpu/drm/i915/i915_drv.h | 1 +
.../gpu/drm/i915/selftests/mock_gem_device.c | 3 -
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 --
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++
drivers/gpu/drm/msm/msm_drv.c | 13 ---
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++-
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 --
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 +
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 +
drivers/gpu/drm/omapdrm/omap_drv.c | 9 --
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
drivers/gpu/drm/pl111/pl111_drv.c | 28 +++++-
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 --
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 +++
drivers/gpu/drm/tegra/drm.c | 4 -
drivers/gpu/drm/tegra/gem.c | 8 ++
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ---
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
drivers/gpu/drm/vgem/vgem_drv.c | 21 +++--
drivers/gpu/drm/vkms/vkms_drv.c | 8 --
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++
drivers/gpu/drm/xen/xen_drm_front.c | 12 +--
drivers/gpu/drm/xen/xen_drm_front.h | 2 +
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 ++++
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +--
include/drm/drm_drv.h | 85 +------------------
52 files changed, 311 insertions(+), 306 deletions(-)
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 81a79760ca61..51525b8774c9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
.lastclose = amdgpu_driver_lastclose_kms,
.irq_handler = amdgpu_irq_handler,
.ioctls = amdgpu_ioctls_kms,
- .gem_free_object_unlocked = amdgpu_gem_object_free,
- .gem_open_object = amdgpu_gem_object_open,
- .gem_close_object = amdgpu_gem_object_close,
.dumb_create = amdgpu_mode_dumb_create,
.dumb_map_offset = amdgpu_mode_dumb_mmap,
.fops = &amdgpu_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = amdgpu_gem_prime_export,
.gem_prime_import = amdgpu_gem_prime_import,
- .gem_prime_vmap = amdgpu_gem_prime_vmap,
- .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
.gem_prime_mmap = amdgpu_gem_prime_mmap,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 43f4966331dd..ca2b79f94e99 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -36,6 +36,7 @@
#include <drm/amdgpu_drm.h>
#include <drm/drm_cache.h>
#include "amdgpu.h"
+#include "amdgpu_dma_buf.h"
#include "amdgpu_trace.h"
#include "amdgpu_amdkfd.h"
@@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
#endif
}
+static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
+ .free = amdgpu_gem_object_free,
+ .open = amdgpu_gem_object_open,
+ .close = amdgpu_gem_object_close,
+ .export = amdgpu_gem_prime_export,
+ .vmap = amdgpu_gem_prime_vmap,
+ .vunmap = amdgpu_gem_prime_vunmap,
+};
+
static int amdgpu_bo_do_create(struct amdgpu_device *adev,
struct amdgpu_bo_param *bp,
struct amdgpu_bo **bo_ptr)
@@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+
+ bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
INIT_LIST_HEAD(&bo->shadow_list);
bo->vm_bo = NULL;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 81a79760ca61..51525b8774c9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
.lastclose = amdgpu_driver_lastclose_kms,
.irq_handler = amdgpu_irq_handler,
.ioctls = amdgpu_ioctls_kms,
- .gem_free_object_unlocked = amdgpu_gem_object_free,
- .gem_open_object = amdgpu_gem_object_open,
- .gem_close_object = amdgpu_gem_object_close,
.dumb_create = amdgpu_mode_dumb_create,
.dumb_map_offset = amdgpu_mode_dumb_mmap,
.fops = &amdgpu_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = amdgpu_gem_prime_export,
.gem_prime_import = amdgpu_gem_prime_import,
- .gem_prime_vmap = amdgpu_gem_prime_vmap,
- .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
.gem_prime_mmap = amdgpu_gem_prime_mmap,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 43f4966331dd..ca2b79f94e99 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -36,6 +36,7 @@
#include <drm/amdgpu_drm.h>
#include <drm/drm_cache.h>
#include "amdgpu.h"
+#include "amdgpu_dma_buf.h"
#include "amdgpu_trace.h"
#include "amdgpu_amdkfd.h"
@@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
#endif
}
+static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
+ .free = amdgpu_gem_object_free,
+ .open = amdgpu_gem_object_open,
+ .close = amdgpu_gem_object_close,
+ .export = amdgpu_gem_prime_export,
+ .vmap = amdgpu_gem_prime_vmap,
+ .vunmap = amdgpu_gem_prime_vunmap,
+};
+
static int amdgpu_bo_do_create(struct amdgpu_device *adev,
struct amdgpu_bo_param *bp,
struct amdgpu_bo **bo_ptr)
@@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+
+ bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
INIT_LIST_HEAD(&bo->shadow_list);
bo->vm_bo = NULL;
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 81a79760ca61..51525b8774c9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
.lastclose = amdgpu_driver_lastclose_kms,
.irq_handler = amdgpu_irq_handler,
.ioctls = amdgpu_ioctls_kms,
- .gem_free_object_unlocked = amdgpu_gem_object_free,
- .gem_open_object = amdgpu_gem_object_open,
- .gem_close_object = amdgpu_gem_object_close,
.dumb_create = amdgpu_mode_dumb_create,
.dumb_map_offset = amdgpu_mode_dumb_mmap,
.fops = &amdgpu_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = amdgpu_gem_prime_export,
.gem_prime_import = amdgpu_gem_prime_import,
- .gem_prime_vmap = amdgpu_gem_prime_vmap,
- .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
.gem_prime_mmap = amdgpu_gem_prime_mmap,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 43f4966331dd..ca2b79f94e99 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -36,6 +36,7 @@
#include <drm/amdgpu_drm.h>
#include <drm/drm_cache.h>
#include "amdgpu.h"
+#include "amdgpu_dma_buf.h"
#include "amdgpu_trace.h"
#include "amdgpu_amdkfd.h"
@@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
#endif
}
+static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
+ .free = amdgpu_gem_object_free,
+ .open = amdgpu_gem_object_open,
+ .close = amdgpu_gem_object_close,
+ .export = amdgpu_gem_prime_export,
+ .vmap = amdgpu_gem_prime_vmap,
+ .vunmap = amdgpu_gem_prime_vunmap,
+};
+
static int amdgpu_bo_do_create(struct amdgpu_device *adev,
struct amdgpu_bo_param *bp,
struct amdgpu_bo **bo_ptr)
@@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+
+ bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
INIT_LIST_HEAD(&bo->shadow_list);
bo->vm_bo = NULL;
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 81a79760ca61..51525b8774c9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
.lastclose = amdgpu_driver_lastclose_kms,
.irq_handler = amdgpu_irq_handler,
.ioctls = amdgpu_ioctls_kms,
- .gem_free_object_unlocked = amdgpu_gem_object_free,
- .gem_open_object = amdgpu_gem_object_open,
- .gem_close_object = amdgpu_gem_object_close,
.dumb_create = amdgpu_mode_dumb_create,
.dumb_map_offset = amdgpu_mode_dumb_mmap,
.fops = &amdgpu_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = amdgpu_gem_prime_export,
.gem_prime_import = amdgpu_gem_prime_import,
- .gem_prime_vmap = amdgpu_gem_prime_vmap,
- .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
.gem_prime_mmap = amdgpu_gem_prime_mmap,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 43f4966331dd..ca2b79f94e99 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -36,6 +36,7 @@
#include <drm/amdgpu_drm.h>
#include <drm/drm_cache.h>
#include "amdgpu.h"
+#include "amdgpu_dma_buf.h"
#include "amdgpu_trace.h"
#include "amdgpu_amdkfd.h"
@@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
#endif
}
+static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
+ .free = amdgpu_gem_object_free,
+ .open = amdgpu_gem_object_open,
+ .close = amdgpu_gem_object_close,
+ .export = amdgpu_gem_prime_export,
+ .vmap = amdgpu_gem_prime_vmap,
+ .vunmap = amdgpu_gem_prime_vunmap,
+};
+
static int amdgpu_bo_do_create(struct amdgpu_device *adev,
struct amdgpu_bo_param *bp,
struct amdgpu_bo **bo_ptr)
@@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+
+ bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
INIT_LIST_HEAD(&bo->shadow_list);
bo->vm_bo = NULL;
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 81a79760ca61..51525b8774c9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
.lastclose = amdgpu_driver_lastclose_kms,
.irq_handler = amdgpu_irq_handler,
.ioctls = amdgpu_ioctls_kms,
- .gem_free_object_unlocked = amdgpu_gem_object_free,
- .gem_open_object = amdgpu_gem_object_open,
- .gem_close_object = amdgpu_gem_object_close,
.dumb_create = amdgpu_mode_dumb_create,
.dumb_map_offset = amdgpu_mode_dumb_mmap,
.fops = &amdgpu_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = amdgpu_gem_prime_export,
.gem_prime_import = amdgpu_gem_prime_import,
- .gem_prime_vmap = amdgpu_gem_prime_vmap,
- .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
.gem_prime_mmap = amdgpu_gem_prime_mmap,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 43f4966331dd..ca2b79f94e99 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -36,6 +36,7 @@
#include <drm/amdgpu_drm.h>
#include <drm/drm_cache.h>
#include "amdgpu.h"
+#include "amdgpu_dma_buf.h"
#include "amdgpu_trace.h"
#include "amdgpu_amdkfd.h"
@@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
#endif
}
+static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
+ .free = amdgpu_gem_object_free,
+ .open = amdgpu_gem_object_open,
+ .close = amdgpu_gem_object_close,
+ .export = amdgpu_gem_prime_export,
+ .vmap = amdgpu_gem_prime_vmap,
+ .vunmap = amdgpu_gem_prime_vunmap,
+};
+
static int amdgpu_bo_do_create(struct amdgpu_device *adev,
struct amdgpu_bo_param *bp,
struct amdgpu_bo **bo_ptr)
@@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+
+ bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
INIT_LIST_HEAD(&bo->shadow_list);
bo->vm_bo = NULL;
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 81a79760ca61..51525b8774c9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
.lastclose = amdgpu_driver_lastclose_kms,
.irq_handler = amdgpu_irq_handler,
.ioctls = amdgpu_ioctls_kms,
- .gem_free_object_unlocked = amdgpu_gem_object_free,
- .gem_open_object = amdgpu_gem_object_open,
- .gem_close_object = amdgpu_gem_object_close,
.dumb_create = amdgpu_mode_dumb_create,
.dumb_map_offset = amdgpu_mode_dumb_mmap,
.fops = &amdgpu_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = amdgpu_gem_prime_export,
.gem_prime_import = amdgpu_gem_prime_import,
- .gem_prime_vmap = amdgpu_gem_prime_vmap,
- .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
.gem_prime_mmap = amdgpu_gem_prime_mmap,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index 43f4966331dd..ca2b79f94e99 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -36,6 +36,7 @@
#include <drm/amdgpu_drm.h>
#include <drm/drm_cache.h>
#include "amdgpu.h"
+#include "amdgpu_dma_buf.h"
#include "amdgpu_trace.h"
#include "amdgpu_amdkfd.h"
@@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
#endif
}
+static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
+ .free = amdgpu_gem_object_free,
+ .open = amdgpu_gem_object_open,
+ .close = amdgpu_gem_object_close,
+ .export = amdgpu_gem_prime_export,
+ .vmap = amdgpu_gem_prime_vmap,
+ .vunmap = amdgpu_gem_prime_vunmap,
+};
+
static int amdgpu_bo_do_create(struct amdgpu_device *adev,
struct amdgpu_bo_param *bp,
struct amdgpu_bo **bo_ptr)
@@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+
+ bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
INIT_LIST_HEAD(&bo->shadow_list);
bo->vm_bo = NULL;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 10:22 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:22 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 81a79760ca61..51525b8774c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
> .lastclose = amdgpu_driver_lastclose_kms,
> .irq_handler = amdgpu_irq_handler,
> .ioctls = amdgpu_ioctls_kms,
> - .gem_free_object_unlocked = amdgpu_gem_object_free,
> - .gem_open_object = amdgpu_gem_object_open,
> - .gem_close_object = amdgpu_gem_object_close,
> .dumb_create = amdgpu_mode_dumb_create,
> .dumb_map_offset = amdgpu_mode_dumb_mmap,
> .fops = &amdgpu_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = amdgpu_gem_prime_export,
> .gem_prime_import = amdgpu_gem_prime_import,
> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>
> .name = DRIVER_NAME,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 43f4966331dd..ca2b79f94e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -36,6 +36,7 @@
> #include <drm/amdgpu_drm.h>
> #include <drm/drm_cache.h>
> #include "amdgpu.h"
> +#include "amdgpu_dma_buf.h"
> #include "amdgpu_trace.h"
> #include "amdgpu_amdkfd.h"
>
> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
> #endif
> }
>
> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
> + .free = amdgpu_gem_object_free,
> + .open = amdgpu_gem_object_open,
> + .close = amdgpu_gem_object_close,
> + .export = amdgpu_gem_prime_export,
> + .vmap = amdgpu_gem_prime_vmap,
> + .vunmap = amdgpu_gem_prime_vunmap,
> +};
> +
Wrong file, this belongs into amdgpu_gem.c
> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> struct amdgpu_bo_param *bp,
> struct amdgpu_bo **bo_ptr)
> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> +
> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
And this should probably go into amdgpu_gem_object_create().
Apart from that looks like a good idea to me.
Christian.
> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
> INIT_LIST_HEAD(&bo->shadow_list);
> bo->vm_bo = NULL;
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 10:22 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:22 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 81a79760ca61..51525b8774c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
> .lastclose = amdgpu_driver_lastclose_kms,
> .irq_handler = amdgpu_irq_handler,
> .ioctls = amdgpu_ioctls_kms,
> - .gem_free_object_unlocked = amdgpu_gem_object_free,
> - .gem_open_object = amdgpu_gem_object_open,
> - .gem_close_object = amdgpu_gem_object_close,
> .dumb_create = amdgpu_mode_dumb_create,
> .dumb_map_offset = amdgpu_mode_dumb_mmap,
> .fops = &amdgpu_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = amdgpu_gem_prime_export,
> .gem_prime_import = amdgpu_gem_prime_import,
> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>
> .name = DRIVER_NAME,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 43f4966331dd..ca2b79f94e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -36,6 +36,7 @@
> #include <drm/amdgpu_drm.h>
> #include <drm/drm_cache.h>
> #include "amdgpu.h"
> +#include "amdgpu_dma_buf.h"
> #include "amdgpu_trace.h"
> #include "amdgpu_amdkfd.h"
>
> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
> #endif
> }
>
> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
> + .free = amdgpu_gem_object_free,
> + .open = amdgpu_gem_object_open,
> + .close = amdgpu_gem_object_close,
> + .export = amdgpu_gem_prime_export,
> + .vmap = amdgpu_gem_prime_vmap,
> + .vunmap = amdgpu_gem_prime_vunmap,
> +};
> +
Wrong file, this belongs into amdgpu_gem.c
> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> struct amdgpu_bo_param *bp,
> struct amdgpu_bo **bo_ptr)
> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> +
> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
And this should probably go into amdgpu_gem_object_create().
Apart from that looks like a good idea to me.
Christian.
> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
> INIT_LIST_HEAD(&bo->shadow_list);
> bo->vm_bo = NULL;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 10:22 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:22 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 81a79760ca61..51525b8774c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
> .lastclose = amdgpu_driver_lastclose_kms,
> .irq_handler = amdgpu_irq_handler,
> .ioctls = amdgpu_ioctls_kms,
> - .gem_free_object_unlocked = amdgpu_gem_object_free,
> - .gem_open_object = amdgpu_gem_object_open,
> - .gem_close_object = amdgpu_gem_object_close,
> .dumb_create = amdgpu_mode_dumb_create,
> .dumb_map_offset = amdgpu_mode_dumb_mmap,
> .fops = &amdgpu_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = amdgpu_gem_prime_export,
> .gem_prime_import = amdgpu_gem_prime_import,
> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>
> .name = DRIVER_NAME,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 43f4966331dd..ca2b79f94e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -36,6 +36,7 @@
> #include <drm/amdgpu_drm.h>
> #include <drm/drm_cache.h>
> #include "amdgpu.h"
> +#include "amdgpu_dma_buf.h"
> #include "amdgpu_trace.h"
> #include "amdgpu_amdkfd.h"
>
> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
> #endif
> }
>
> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
> + .free = amdgpu_gem_object_free,
> + .open = amdgpu_gem_object_open,
> + .close = amdgpu_gem_object_close,
> + .export = amdgpu_gem_prime_export,
> + .vmap = amdgpu_gem_prime_vmap,
> + .vunmap = amdgpu_gem_prime_vunmap,
> +};
> +
Wrong file, this belongs into amdgpu_gem.c
> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> struct amdgpu_bo_param *bp,
> struct amdgpu_bo **bo_ptr)
> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> +
> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
And this should probably go into amdgpu_gem_object_create().
Apart from that looks like a good idea to me.
Christian.
> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
> INIT_LIST_HEAD(&bo->shadow_list);
> bo->vm_bo = NULL;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 10:22 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:22 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 81a79760ca61..51525b8774c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
> .lastclose = amdgpu_driver_lastclose_kms,
> .irq_handler = amdgpu_irq_handler,
> .ioctls = amdgpu_ioctls_kms,
> - .gem_free_object_unlocked = amdgpu_gem_object_free,
> - .gem_open_object = amdgpu_gem_object_open,
> - .gem_close_object = amdgpu_gem_object_close,
> .dumb_create = amdgpu_mode_dumb_create,
> .dumb_map_offset = amdgpu_mode_dumb_mmap,
> .fops = &amdgpu_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = amdgpu_gem_prime_export,
> .gem_prime_import = amdgpu_gem_prime_import,
> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>
> .name = DRIVER_NAME,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 43f4966331dd..ca2b79f94e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -36,6 +36,7 @@
> #include <drm/amdgpu_drm.h>
> #include <drm/drm_cache.h>
> #include "amdgpu.h"
> +#include "amdgpu_dma_buf.h"
> #include "amdgpu_trace.h"
> #include "amdgpu_amdkfd.h"
>
> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
> #endif
> }
>
> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
> + .free = amdgpu_gem_object_free,
> + .open = amdgpu_gem_object_open,
> + .close = amdgpu_gem_object_close,
> + .export = amdgpu_gem_prime_export,
> + .vmap = amdgpu_gem_prime_vmap,
> + .vunmap = amdgpu_gem_prime_vunmap,
> +};
> +
Wrong file, this belongs into amdgpu_gem.c
> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> struct amdgpu_bo_param *bp,
> struct amdgpu_bo **bo_ptr)
> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> +
> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
And this should probably go into amdgpu_gem_object_create().
Apart from that looks like a good idea to me.
Christian.
> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
> INIT_LIST_HEAD(&bo->shadow_list);
> bo->vm_bo = NULL;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 10:22 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:22 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 81a79760ca61..51525b8774c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
> .lastclose = amdgpu_driver_lastclose_kms,
> .irq_handler = amdgpu_irq_handler,
> .ioctls = amdgpu_ioctls_kms,
> - .gem_free_object_unlocked = amdgpu_gem_object_free,
> - .gem_open_object = amdgpu_gem_object_open,
> - .gem_close_object = amdgpu_gem_object_close,
> .dumb_create = amdgpu_mode_dumb_create,
> .dumb_map_offset = amdgpu_mode_dumb_mmap,
> .fops = &amdgpu_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = amdgpu_gem_prime_export,
> .gem_prime_import = amdgpu_gem_prime_import,
> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>
> .name = DRIVER_NAME,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 43f4966331dd..ca2b79f94e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -36,6 +36,7 @@
> #include <drm/amdgpu_drm.h>
> #include <drm/drm_cache.h>
> #include "amdgpu.h"
> +#include "amdgpu_dma_buf.h"
> #include "amdgpu_trace.h"
> #include "amdgpu_amdkfd.h"
>
> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
> #endif
> }
>
> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
> + .free = amdgpu_gem_object_free,
> + .open = amdgpu_gem_object_open,
> + .close = amdgpu_gem_object_close,
> + .export = amdgpu_gem_prime_export,
> + .vmap = amdgpu_gem_prime_vmap,
> + .vunmap = amdgpu_gem_prime_vunmap,
> +};
> +
Wrong file, this belongs into amdgpu_gem.c
> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> struct amdgpu_bo_param *bp,
> struct amdgpu_bo **bo_ptr)
> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> +
> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
And this should probably go into amdgpu_gem_object_create().
Apart from that looks like a good idea to me.
Christian.
> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
> INIT_LIST_HEAD(&bo->shadow_list);
> bo->vm_bo = NULL;
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 10:22 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:22 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 81a79760ca61..51525b8774c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
> .lastclose = amdgpu_driver_lastclose_kms,
> .irq_handler = amdgpu_irq_handler,
> .ioctls = amdgpu_ioctls_kms,
> - .gem_free_object_unlocked = amdgpu_gem_object_free,
> - .gem_open_object = amdgpu_gem_object_open,
> - .gem_close_object = amdgpu_gem_object_close,
> .dumb_create = amdgpu_mode_dumb_create,
> .dumb_map_offset = amdgpu_mode_dumb_mmap,
> .fops = &amdgpu_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = amdgpu_gem_prime_export,
> .gem_prime_import = amdgpu_gem_prime_import,
> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>
> .name = DRIVER_NAME,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 43f4966331dd..ca2b79f94e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -36,6 +36,7 @@
> #include <drm/amdgpu_drm.h>
> #include <drm/drm_cache.h>
> #include "amdgpu.h"
> +#include "amdgpu_dma_buf.h"
> #include "amdgpu_trace.h"
> #include "amdgpu_amdkfd.h"
>
> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
> #endif
> }
>
> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
> + .free = amdgpu_gem_object_free,
> + .open = amdgpu_gem_object_open,
> + .close = amdgpu_gem_object_close,
> + .export = amdgpu_gem_prime_export,
> + .vmap = amdgpu_gem_prime_vmap,
> + .vunmap = amdgpu_gem_prime_vunmap,
> +};
> +
Wrong file, this belongs into amdgpu_gem.c
> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> struct amdgpu_bo_param *bp,
> struct amdgpu_bo **bo_ptr)
> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> +
> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
And this should probably go into amdgpu_gem_object_create().
Apart from that looks like a good idea to me.
Christian.
> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
> INIT_LIST_HEAD(&bo->shadow_list);
> bo->vm_bo = NULL;
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-08-13 10:22 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:22 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 81a79760ca61..51525b8774c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
> .lastclose = amdgpu_driver_lastclose_kms,
> .irq_handler = amdgpu_irq_handler,
> .ioctls = amdgpu_ioctls_kms,
> - .gem_free_object_unlocked = amdgpu_gem_object_free,
> - .gem_open_object = amdgpu_gem_object_open,
> - .gem_close_object = amdgpu_gem_object_close,
> .dumb_create = amdgpu_mode_dumb_create,
> .dumb_map_offset = amdgpu_mode_dumb_mmap,
> .fops = &amdgpu_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = amdgpu_gem_prime_export,
> .gem_prime_import = amdgpu_gem_prime_import,
> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>
> .name = DRIVER_NAME,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 43f4966331dd..ca2b79f94e99 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -36,6 +36,7 @@
> #include <drm/amdgpu_drm.h>
> #include <drm/drm_cache.h>
> #include "amdgpu.h"
> +#include "amdgpu_dma_buf.h"
> #include "amdgpu_trace.h"
> #include "amdgpu_amdkfd.h"
>
> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
> #endif
> }
>
> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
> + .free = amdgpu_gem_object_free,
> + .open = amdgpu_gem_object_open,
> + .close = amdgpu_gem_object_close,
> + .export = amdgpu_gem_prime_export,
> + .vmap = amdgpu_gem_prime_vmap,
> + .vunmap = amdgpu_gem_prime_vunmap,
> +};
> +
Wrong file, this belongs into amdgpu_gem.c
> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> struct amdgpu_bo_param *bp,
> struct amdgpu_bo **bo_ptr)
> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> +
> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
And this should probably go into amdgpu_gem_object_create().
Apart from that looks like a good idea to me.
Christian.
> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
> INIT_LIST_HEAD(&bo->shadow_list);
> bo->vm_bo = NULL;
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 15:05 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-14 15:05 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 4089 bytes --]
Hi
Am 13.08.20 um 12:22 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 81a79760ca61..51525b8774c9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>> .lastclose = amdgpu_driver_lastclose_kms,
>> .irq_handler = amdgpu_irq_handler,
>> .ioctls = amdgpu_ioctls_kms,
>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>> - .gem_open_object = amdgpu_gem_object_open,
>> - .gem_close_object = amdgpu_gem_object_close,
>> .dumb_create = amdgpu_mode_dumb_create,
>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>> .fops = &amdgpu_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = amdgpu_gem_prime_export,
>> .gem_prime_import = amdgpu_gem_prime_import,
>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>> .name = DRIVER_NAME,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 43f4966331dd..ca2b79f94e99 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -36,6 +36,7 @@
>> #include <drm/amdgpu_drm.h>
>> #include <drm/drm_cache.h>
>> #include "amdgpu.h"
>> +#include "amdgpu_dma_buf.h"
>> #include "amdgpu_trace.h"
>> #include "amdgpu_amdkfd.h"
>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>> #endif
>> }
>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>> + .free = amdgpu_gem_object_free,
>> + .open = amdgpu_gem_object_open,
>> + .close = amdgpu_gem_object_close,
>> + .export = amdgpu_gem_prime_export,
>> + .vmap = amdgpu_gem_prime_vmap,
>> + .vunmap = amdgpu_gem_prime_vunmap,
>> +};
>> +
>
> Wrong file, this belongs into amdgpu_gem.c
>
>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>> struct amdgpu_bo_param *bp,
>> struct amdgpu_bo **bo_ptr)
>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>> amdgpu_device *adev,
>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> +
>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>
> And this should probably go into amdgpu_gem_object_create().
I'm trying to understand what amdgpu does. What about all the places
where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
the free callback for the GEM object?
Best regards
Thomas
>
> Apart from that looks like a good idea to me.
>
> Christian.
>
>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>> INIT_LIST_HEAD(&bo->shadow_list);
>> bo->vm_bo = NULL;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 15:05 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-14 15:05 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4089 bytes --]
Hi
Am 13.08.20 um 12:22 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 81a79760ca61..51525b8774c9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>> .lastclose = amdgpu_driver_lastclose_kms,
>> .irq_handler = amdgpu_irq_handler,
>> .ioctls = amdgpu_ioctls_kms,
>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>> - .gem_open_object = amdgpu_gem_object_open,
>> - .gem_close_object = amdgpu_gem_object_close,
>> .dumb_create = amdgpu_mode_dumb_create,
>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>> .fops = &amdgpu_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = amdgpu_gem_prime_export,
>> .gem_prime_import = amdgpu_gem_prime_import,
>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>> .name = DRIVER_NAME,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 43f4966331dd..ca2b79f94e99 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -36,6 +36,7 @@
>> #include <drm/amdgpu_drm.h>
>> #include <drm/drm_cache.h>
>> #include "amdgpu.h"
>> +#include "amdgpu_dma_buf.h"
>> #include "amdgpu_trace.h"
>> #include "amdgpu_amdkfd.h"
>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>> #endif
>> }
>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>> + .free = amdgpu_gem_object_free,
>> + .open = amdgpu_gem_object_open,
>> + .close = amdgpu_gem_object_close,
>> + .export = amdgpu_gem_prime_export,
>> + .vmap = amdgpu_gem_prime_vmap,
>> + .vunmap = amdgpu_gem_prime_vunmap,
>> +};
>> +
>
> Wrong file, this belongs into amdgpu_gem.c
>
>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>> struct amdgpu_bo_param *bp,
>> struct amdgpu_bo **bo_ptr)
>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>> amdgpu_device *adev,
>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> +
>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>
> And this should probably go into amdgpu_gem_object_create().
I'm trying to understand what amdgpu does. What about all the places
where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
the free callback for the GEM object?
Best regards
Thomas
>
> Apart from that looks like a good idea to me.
>
> Christian.
>
>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>> INIT_LIST_HEAD(&bo->shadow_list);
>> bo->vm_bo = NULL;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 15:05 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-14 15:05 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4089 bytes --]
Hi
Am 13.08.20 um 12:22 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 81a79760ca61..51525b8774c9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>> .lastclose = amdgpu_driver_lastclose_kms,
>> .irq_handler = amdgpu_irq_handler,
>> .ioctls = amdgpu_ioctls_kms,
>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>> - .gem_open_object = amdgpu_gem_object_open,
>> - .gem_close_object = amdgpu_gem_object_close,
>> .dumb_create = amdgpu_mode_dumb_create,
>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>> .fops = &amdgpu_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = amdgpu_gem_prime_export,
>> .gem_prime_import = amdgpu_gem_prime_import,
>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>> .name = DRIVER_NAME,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 43f4966331dd..ca2b79f94e99 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -36,6 +36,7 @@
>> #include <drm/amdgpu_drm.h>
>> #include <drm/drm_cache.h>
>> #include "amdgpu.h"
>> +#include "amdgpu_dma_buf.h"
>> #include "amdgpu_trace.h"
>> #include "amdgpu_amdkfd.h"
>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>> #endif
>> }
>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>> + .free = amdgpu_gem_object_free,
>> + .open = amdgpu_gem_object_open,
>> + .close = amdgpu_gem_object_close,
>> + .export = amdgpu_gem_prime_export,
>> + .vmap = amdgpu_gem_prime_vmap,
>> + .vunmap = amdgpu_gem_prime_vunmap,
>> +};
>> +
>
> Wrong file, this belongs into amdgpu_gem.c
>
>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>> struct amdgpu_bo_param *bp,
>> struct amdgpu_bo **bo_ptr)
>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>> amdgpu_device *adev,
>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> +
>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>
> And this should probably go into amdgpu_gem_object_create().
I'm trying to understand what amdgpu does. What about all the places
where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
the free callback for the GEM object?
Best regards
Thomas
>
> Apart from that looks like a good idea to me.
>
> Christian.
>
>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>> INIT_LIST_HEAD(&bo->shadow_list);
>> bo->vm_bo = NULL;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 15:05 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-14 15:05 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4089 bytes --]
Hi
Am 13.08.20 um 12:22 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 81a79760ca61..51525b8774c9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>> .lastclose = amdgpu_driver_lastclose_kms,
>> .irq_handler = amdgpu_irq_handler,
>> .ioctls = amdgpu_ioctls_kms,
>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>> - .gem_open_object = amdgpu_gem_object_open,
>> - .gem_close_object = amdgpu_gem_object_close,
>> .dumb_create = amdgpu_mode_dumb_create,
>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>> .fops = &amdgpu_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = amdgpu_gem_prime_export,
>> .gem_prime_import = amdgpu_gem_prime_import,
>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>> .name = DRIVER_NAME,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 43f4966331dd..ca2b79f94e99 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -36,6 +36,7 @@
>> #include <drm/amdgpu_drm.h>
>> #include <drm/drm_cache.h>
>> #include "amdgpu.h"
>> +#include "amdgpu_dma_buf.h"
>> #include "amdgpu_trace.h"
>> #include "amdgpu_amdkfd.h"
>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>> #endif
>> }
>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>> + .free = amdgpu_gem_object_free,
>> + .open = amdgpu_gem_object_open,
>> + .close = amdgpu_gem_object_close,
>> + .export = amdgpu_gem_prime_export,
>> + .vmap = amdgpu_gem_prime_vmap,
>> + .vunmap = amdgpu_gem_prime_vunmap,
>> +};
>> +
>
> Wrong file, this belongs into amdgpu_gem.c
>
>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>> struct amdgpu_bo_param *bp,
>> struct amdgpu_bo **bo_ptr)
>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>> amdgpu_device *adev,
>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> +
>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>
> And this should probably go into amdgpu_gem_object_create().
I'm trying to understand what amdgpu does. What about all the places
where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
the free callback for the GEM object?
Best regards
Thomas
>
> Apart from that looks like a good idea to me.
>
> Christian.
>
>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>> INIT_LIST_HEAD(&bo->shadow_list);
>> bo->vm_bo = NULL;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 15:05 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-14 15:05 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4089 bytes --]
Hi
Am 13.08.20 um 12:22 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 81a79760ca61..51525b8774c9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>> .lastclose = amdgpu_driver_lastclose_kms,
>> .irq_handler = amdgpu_irq_handler,
>> .ioctls = amdgpu_ioctls_kms,
>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>> - .gem_open_object = amdgpu_gem_object_open,
>> - .gem_close_object = amdgpu_gem_object_close,
>> .dumb_create = amdgpu_mode_dumb_create,
>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>> .fops = &amdgpu_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = amdgpu_gem_prime_export,
>> .gem_prime_import = amdgpu_gem_prime_import,
>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>> .name = DRIVER_NAME,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 43f4966331dd..ca2b79f94e99 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -36,6 +36,7 @@
>> #include <drm/amdgpu_drm.h>
>> #include <drm/drm_cache.h>
>> #include "amdgpu.h"
>> +#include "amdgpu_dma_buf.h"
>> #include "amdgpu_trace.h"
>> #include "amdgpu_amdkfd.h"
>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>> #endif
>> }
>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>> + .free = amdgpu_gem_object_free,
>> + .open = amdgpu_gem_object_open,
>> + .close = amdgpu_gem_object_close,
>> + .export = amdgpu_gem_prime_export,
>> + .vmap = amdgpu_gem_prime_vmap,
>> + .vunmap = amdgpu_gem_prime_vunmap,
>> +};
>> +
>
> Wrong file, this belongs into amdgpu_gem.c
>
>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>> struct amdgpu_bo_param *bp,
>> struct amdgpu_bo **bo_ptr)
>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>> amdgpu_device *adev,
>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> +
>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>
> And this should probably go into amdgpu_gem_object_create().
I'm trying to understand what amdgpu does. What about all the places
where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
the free callback for the GEM object?
Best regards
Thomas
>
> Apart from that looks like a good idea to me.
>
> Christian.
>
>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>> INIT_LIST_HEAD(&bo->shadow_list);
>> bo->vm_bo = NULL;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 15:05 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-14 15:05 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4089 bytes --]
Hi
Am 13.08.20 um 12:22 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 81a79760ca61..51525b8774c9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>> .lastclose = amdgpu_driver_lastclose_kms,
>> .irq_handler = amdgpu_irq_handler,
>> .ioctls = amdgpu_ioctls_kms,
>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>> - .gem_open_object = amdgpu_gem_object_open,
>> - .gem_close_object = amdgpu_gem_object_close,
>> .dumb_create = amdgpu_mode_dumb_create,
>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>> .fops = &amdgpu_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = amdgpu_gem_prime_export,
>> .gem_prime_import = amdgpu_gem_prime_import,
>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>> .name = DRIVER_NAME,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 43f4966331dd..ca2b79f94e99 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -36,6 +36,7 @@
>> #include <drm/amdgpu_drm.h>
>> #include <drm/drm_cache.h>
>> #include "amdgpu.h"
>> +#include "amdgpu_dma_buf.h"
>> #include "amdgpu_trace.h"
>> #include "amdgpu_amdkfd.h"
>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>> #endif
>> }
>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>> + .free = amdgpu_gem_object_free,
>> + .open = amdgpu_gem_object_open,
>> + .close = amdgpu_gem_object_close,
>> + .export = amdgpu_gem_prime_export,
>> + .vmap = amdgpu_gem_prime_vmap,
>> + .vunmap = amdgpu_gem_prime_vunmap,
>> +};
>> +
>
> Wrong file, this belongs into amdgpu_gem.c
>
>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>> struct amdgpu_bo_param *bp,
>> struct amdgpu_bo **bo_ptr)
>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>> amdgpu_device *adev,
>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> +
>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>
> And this should probably go into amdgpu_gem_object_create().
I'm trying to understand what amdgpu does. What about all the places
where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
the free callback for the GEM object?
Best regards
Thomas
>
> Apart from that looks like a good idea to me.
>
> Christian.
>
>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>> INIT_LIST_HEAD(&bo->shadow_list);
>> bo->vm_bo = NULL;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 15:05 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-14 15:05 UTC (permalink / raw)
To: Christian König, alexander.deucher-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w,
oleksandr_andrushchenko-uRwfk40T5oI,
hyun.kwon-gjFFaj9aHVfQT0dZR+AlfA
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1.1.1: Type: text/plain, Size: 4110 bytes --]
Hi
Am 13.08.20 um 12:22 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 81a79760ca61..51525b8774c9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>> .lastclose = amdgpu_driver_lastclose_kms,
>> .irq_handler = amdgpu_irq_handler,
>> .ioctls = amdgpu_ioctls_kms,
>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>> - .gem_open_object = amdgpu_gem_object_open,
>> - .gem_close_object = amdgpu_gem_object_close,
>> .dumb_create = amdgpu_mode_dumb_create,
>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>> .fops = &amdgpu_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = amdgpu_gem_prime_export,
>> .gem_prime_import = amdgpu_gem_prime_import,
>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>> .name = DRIVER_NAME,
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 43f4966331dd..ca2b79f94e99 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -36,6 +36,7 @@
>> #include <drm/amdgpu_drm.h>
>> #include <drm/drm_cache.h>
>> #include "amdgpu.h"
>> +#include "amdgpu_dma_buf.h"
>> #include "amdgpu_trace.h"
>> #include "amdgpu_amdkfd.h"
>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>> #endif
>> }
>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>> + .free = amdgpu_gem_object_free,
>> + .open = amdgpu_gem_object_open,
>> + .close = amdgpu_gem_object_close,
>> + .export = amdgpu_gem_prime_export,
>> + .vmap = amdgpu_gem_prime_vmap,
>> + .vunmap = amdgpu_gem_prime_vunmap,
>> +};
>> +
>
> Wrong file, this belongs into amdgpu_gem.c
>
>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>> struct amdgpu_bo_param *bp,
>> struct amdgpu_bo **bo_ptr)
>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>> amdgpu_device *adev,
>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> +
>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>
> And this should probably go into amdgpu_gem_object_create().
I'm trying to understand what amdgpu does. What about all the places
where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
the free callback for the GEM object?
Best regards
Thomas
>
> Apart from that looks like a good idea to me.
>
> Christian.
>
>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>> INIT_LIST_HEAD(&bo->shadow_list);
>> bo->vm_bo = NULL;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 188 bytes --]
_______________________________________________
Freedreno mailing list
Freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
^ permalink raw reply [flat|nested] 243+ messages in thread[parent not found: <c445493b-9914-63f2-1cf2-c3c1de14e3e5-l3A5Bk7waGM@public.gmane.org>]
* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
2020-09-14 15:05 ` Thomas Zimmermann
` (2 preceding siblings ...)
(?)
@ 2020-09-14 17:51 ` Christian König
-1 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-09-14 17:51 UTC (permalink / raw)
To: Thomas Zimmermann, Christian König,
alexander.deucher-5C7GfCeVMHo, airlied-cv59FeDIM0c,
daniel-/w4YWyX8dFk, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, oleksandr_andrushchenko
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1.1: Type: text/plain, Size: 4302 bytes --]
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:22 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>>> which is non-trivial to convert.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> index 81a79760ca61..51525b8774c9 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>>> .lastclose = amdgpu_driver_lastclose_kms,
>>> .irq_handler = amdgpu_irq_handler,
>>> .ioctls = amdgpu_ioctls_kms,
>>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>>> - .gem_open_object = amdgpu_gem_object_open,
>>> - .gem_close_object = amdgpu_gem_object_close,
>>> .dumb_create = amdgpu_mode_dumb_create,
>>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>>> .fops = &amdgpu_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = amdgpu_gem_prime_export,
>>> .gem_prime_import = amdgpu_gem_prime_import,
>>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>>> .name = DRIVER_NAME,
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> index 43f4966331dd..ca2b79f94e99 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> @@ -36,6 +36,7 @@
>>> #include <drm/amdgpu_drm.h>
>>> #include <drm/drm_cache.h>
>>> #include "amdgpu.h"
>>> +#include "amdgpu_dma_buf.h"
>>> #include "amdgpu_trace.h"
>>> #include "amdgpu_amdkfd.h"
>>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>>> #endif
>>> }
>>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>>> + .free = amdgpu_gem_object_free,
>>> + .open = amdgpu_gem_object_open,
>>> + .close = amdgpu_gem_object_close,
>>> + .export = amdgpu_gem_prime_export,
>>> + .vmap = amdgpu_gem_prime_vmap,
>>> + .vunmap = amdgpu_gem_prime_vunmap,
>>> +};
>>> +
>> Wrong file, this belongs into amdgpu_gem.c
>>
>>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>>> struct amdgpu_bo_param *bp,
>>> struct amdgpu_bo **bo_ptr)
>>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>>> amdgpu_device *adev,
>>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> +
>>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>> And this should probably go into amdgpu_gem_object_create().
> I'm trying to understand what amdgpu does. What about all the places
> where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
> the free callback for the GEM object?
Those shouldn't have a GEM object in the first place.
Or otherwise we would have a reference counting issue.
Regards,
Christian.
>
> Best regards
> Thomas
>
>> Apart from that looks like a good idea to me.
>>
>> Christian.
>>
>>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>>> INIT_LIST_HEAD(&bo->shadow_list);
>>> bo->vm_bo = NULL;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 5790 bytes --]
[-- Attachment #2: Type: text/plain, Size: 182 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 17:51 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-09-14 17:51 UTC (permalink / raw)
To: Thomas Zimmermann, Christian König, alexander.deucher,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, oleksandr_andrushchenko, hyun.kwon,
laurent.pinchart, michal.simek, sumit.semwal, evan.quan,
Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 4253 bytes --]
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:22 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>>> which is non-trivial to convert.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> index 81a79760ca61..51525b8774c9 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>>> .lastclose = amdgpu_driver_lastclose_kms,
>>> .irq_handler = amdgpu_irq_handler,
>>> .ioctls = amdgpu_ioctls_kms,
>>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>>> - .gem_open_object = amdgpu_gem_object_open,
>>> - .gem_close_object = amdgpu_gem_object_close,
>>> .dumb_create = amdgpu_mode_dumb_create,
>>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>>> .fops = &amdgpu_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = amdgpu_gem_prime_export,
>>> .gem_prime_import = amdgpu_gem_prime_import,
>>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>>> .name = DRIVER_NAME,
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> index 43f4966331dd..ca2b79f94e99 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> @@ -36,6 +36,7 @@
>>> #include <drm/amdgpu_drm.h>
>>> #include <drm/drm_cache.h>
>>> #include "amdgpu.h"
>>> +#include "amdgpu_dma_buf.h"
>>> #include "amdgpu_trace.h"
>>> #include "amdgpu_amdkfd.h"
>>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>>> #endif
>>> }
>>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>>> + .free = amdgpu_gem_object_free,
>>> + .open = amdgpu_gem_object_open,
>>> + .close = amdgpu_gem_object_close,
>>> + .export = amdgpu_gem_prime_export,
>>> + .vmap = amdgpu_gem_prime_vmap,
>>> + .vunmap = amdgpu_gem_prime_vunmap,
>>> +};
>>> +
>> Wrong file, this belongs into amdgpu_gem.c
>>
>>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>>> struct amdgpu_bo_param *bp,
>>> struct amdgpu_bo **bo_ptr)
>>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>>> amdgpu_device *adev,
>>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> +
>>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>> And this should probably go into amdgpu_gem_object_create().
> I'm trying to understand what amdgpu does. What about all the places
> where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
> the free callback for the GEM object?
Those shouldn't have a GEM object in the first place.
Or otherwise we would have a reference counting issue.
Regards,
Christian.
>
> Best regards
> Thomas
>
>> Apart from that looks like a good idea to me.
>>
>> Christian.
>>
>>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>>> INIT_LIST_HEAD(&bo->shadow_list);
>>> bo->vm_bo = NULL;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 5650 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 17:51 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-09-14 17:51 UTC (permalink / raw)
To: Thomas Zimmermann, Christian König, alexander.deucher,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, oleksandr_andrushchenko, hyun.kwon,
laurent.pinchart, michal.simek, sumit.semwal, evan.quan,
Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 4253 bytes --]
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:22 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>>> which is non-trivial to convert.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> index 81a79760ca61..51525b8774c9 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>>> .lastclose = amdgpu_driver_lastclose_kms,
>>> .irq_handler = amdgpu_irq_handler,
>>> .ioctls = amdgpu_ioctls_kms,
>>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>>> - .gem_open_object = amdgpu_gem_object_open,
>>> - .gem_close_object = amdgpu_gem_object_close,
>>> .dumb_create = amdgpu_mode_dumb_create,
>>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>>> .fops = &amdgpu_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = amdgpu_gem_prime_export,
>>> .gem_prime_import = amdgpu_gem_prime_import,
>>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>>> .name = DRIVER_NAME,
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> index 43f4966331dd..ca2b79f94e99 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> @@ -36,6 +36,7 @@
>>> #include <drm/amdgpu_drm.h>
>>> #include <drm/drm_cache.h>
>>> #include "amdgpu.h"
>>> +#include "amdgpu_dma_buf.h"
>>> #include "amdgpu_trace.h"
>>> #include "amdgpu_amdkfd.h"
>>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>>> #endif
>>> }
>>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>>> + .free = amdgpu_gem_object_free,
>>> + .open = amdgpu_gem_object_open,
>>> + .close = amdgpu_gem_object_close,
>>> + .export = amdgpu_gem_prime_export,
>>> + .vmap = amdgpu_gem_prime_vmap,
>>> + .vunmap = amdgpu_gem_prime_vunmap,
>>> +};
>>> +
>> Wrong file, this belongs into amdgpu_gem.c
>>
>>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>>> struct amdgpu_bo_param *bp,
>>> struct amdgpu_bo **bo_ptr)
>>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>>> amdgpu_device *adev,
>>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> +
>>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>> And this should probably go into amdgpu_gem_object_create().
> I'm trying to understand what amdgpu does. What about all the places
> where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
> the free callback for the GEM object?
Those shouldn't have a GEM object in the first place.
Or otherwise we would have a reference counting issue.
Regards,
Christian.
>
> Best regards
> Thomas
>
>> Apart from that looks like a good idea to me.
>>
>> Christian.
>>
>>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>>> INIT_LIST_HEAD(&bo->shadow_list);
>>> bo->vm_bo = NULL;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #2: Type: text/html, Size: 5650 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 17:51 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-09-14 17:51 UTC (permalink / raw)
To: Thomas Zimmermann, Christian König, alexander.deucher,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, oleksandr_andrushchenko, hyun.kwon,
laurent.pinchart, michal.simek, sumit.semwal, evan.quan,
Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 4253 bytes --]
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:22 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>>> which is non-trivial to convert.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> index 81a79760ca61..51525b8774c9 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>>> .lastclose = amdgpu_driver_lastclose_kms,
>>> .irq_handler = amdgpu_irq_handler,
>>> .ioctls = amdgpu_ioctls_kms,
>>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>>> - .gem_open_object = amdgpu_gem_object_open,
>>> - .gem_close_object = amdgpu_gem_object_close,
>>> .dumb_create = amdgpu_mode_dumb_create,
>>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>>> .fops = &amdgpu_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = amdgpu_gem_prime_export,
>>> .gem_prime_import = amdgpu_gem_prime_import,
>>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>>> .name = DRIVER_NAME,
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> index 43f4966331dd..ca2b79f94e99 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> @@ -36,6 +36,7 @@
>>> #include <drm/amdgpu_drm.h>
>>> #include <drm/drm_cache.h>
>>> #include "amdgpu.h"
>>> +#include "amdgpu_dma_buf.h"
>>> #include "amdgpu_trace.h"
>>> #include "amdgpu_amdkfd.h"
>>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>>> #endif
>>> }
>>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>>> + .free = amdgpu_gem_object_free,
>>> + .open = amdgpu_gem_object_open,
>>> + .close = amdgpu_gem_object_close,
>>> + .export = amdgpu_gem_prime_export,
>>> + .vmap = amdgpu_gem_prime_vmap,
>>> + .vunmap = amdgpu_gem_prime_vunmap,
>>> +};
>>> +
>> Wrong file, this belongs into amdgpu_gem.c
>>
>>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>>> struct amdgpu_bo_param *bp,
>>> struct amdgpu_bo **bo_ptr)
>>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>>> amdgpu_device *adev,
>>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> +
>>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>> And this should probably go into amdgpu_gem_object_create().
> I'm trying to understand what amdgpu does. What about all the places
> where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
> the free callback for the GEM object?
Those shouldn't have a GEM object in the first place.
Or otherwise we would have a reference counting issue.
Regards,
Christian.
>
> Best regards
> Thomas
>
>> Apart from that looks like a good idea to me.
>>
>> Christian.
>>
>>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>>> INIT_LIST_HEAD(&bo->shadow_list);
>>> bo->vm_bo = NULL;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 5650 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 01/20] drm/amdgpu: Introduce GEM object functions
@ 2020-09-14 17:51 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-09-14 17:51 UTC (permalink / raw)
To: Thomas Zimmermann, Christian König, alexander.deucher,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, oleksandr_andrushchenko, hyun.kwon,
laurent.pinchart, michal.simek, sumit.semwal, evan.quan,
Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 4253 bytes --]
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:22 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in amdgpu. The only exception is gem_prime_mmap,
>>> which is non-trivial to convert.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ------
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 12 ++++++++++++
>>> 2 files changed, 12 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> index 81a79760ca61..51525b8774c9 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>>> @@ -1468,19 +1468,13 @@ static struct drm_driver kms_driver = {
>>> .lastclose = amdgpu_driver_lastclose_kms,
>>> .irq_handler = amdgpu_irq_handler,
>>> .ioctls = amdgpu_ioctls_kms,
>>> - .gem_free_object_unlocked = amdgpu_gem_object_free,
>>> - .gem_open_object = amdgpu_gem_object_open,
>>> - .gem_close_object = amdgpu_gem_object_close,
>>> .dumb_create = amdgpu_mode_dumb_create,
>>> .dumb_map_offset = amdgpu_mode_dumb_mmap,
>>> .fops = &amdgpu_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = amdgpu_gem_prime_export,
>>> .gem_prime_import = amdgpu_gem_prime_import,
>>> - .gem_prime_vmap = amdgpu_gem_prime_vmap,
>>> - .gem_prime_vunmap = amdgpu_gem_prime_vunmap,
>>> .gem_prime_mmap = amdgpu_gem_prime_mmap,
>>> .name = DRIVER_NAME,
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> index 43f4966331dd..ca2b79f94e99 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>>> @@ -36,6 +36,7 @@
>>> #include <drm/amdgpu_drm.h>
>>> #include <drm/drm_cache.h>
>>> #include "amdgpu.h"
>>> +#include "amdgpu_dma_buf.h"
>>> #include "amdgpu_trace.h"
>>> #include "amdgpu_amdkfd.h"
>>> @@ -510,6 +511,15 @@ bool amdgpu_bo_support_uswc(u64 bo_flags)
>>> #endif
>>> }
>>> +static const struct drm_gem_object_funcs amdgpu_gem_object_funcs = {
>>> + .free = amdgpu_gem_object_free,
>>> + .open = amdgpu_gem_object_open,
>>> + .close = amdgpu_gem_object_close,
>>> + .export = amdgpu_gem_prime_export,
>>> + .vmap = amdgpu_gem_prime_vmap,
>>> + .vunmap = amdgpu_gem_prime_vunmap,
>>> +};
>>> +
>> Wrong file, this belongs into amdgpu_gem.c
>>
>>> static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>>> struct amdgpu_bo_param *bp,
>>> struct amdgpu_bo **bo_ptr)
>>> @@ -552,6 +562,8 @@ static int amdgpu_bo_do_create(struct
>>> amdgpu_device *adev,
>>> bo = kzalloc(sizeof(struct amdgpu_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> +
>>> + bo->tbo.base.funcs = &amdgpu_gem_object_funcs;
>> And this should probably go into amdgpu_gem_object_create().
> I'm trying to understand what amdgpu does. What about all the places
> where amdgpu calls amdgpu_bo_create() internally? Wouldn't these miss
> the free callback for the GEM object?
Those shouldn't have a GEM object in the first place.
Or otherwise we would have a reference counting issue.
Regards,
Christian.
>
> Best regards
> Thomas
>
>> Apart from that looks like a good idea to me.
>>
>> Christian.
>>
>>> drm_gem_private_object_init(adev->ddev, &bo->tbo.base, size);
>>> INIT_LIST_HEAD(&bo->shadow_list);
>>> bo->vm_bo = NULL;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[-- Attachment #1.2: Type: text/html, Size: 5650 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 02/20] drm/armada: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in armada.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/armada/armada_drv.c | 3 ---
drivers/gpu/drm/armada/armada_gem.c | 12 +++++++++++-
drivers/gpu/drm/armada/armada_gem.h | 2 --
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index 5fc25c3f445c..9bccfd894be9 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -37,13 +37,10 @@ DEFINE_DRM_GEM_FOPS(armada_drm_fops);
static struct drm_driver armada_drm_driver = {
.lastclose = drm_fb_helper_lastclose,
- .gem_free_object_unlocked = armada_gem_free_object,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = armada_gem_prime_export,
.gem_prime_import = armada_gem_prime_import,
.dumb_create = armada_gem_dumb_create,
- .gem_vm_ops = &armada_gem_vm_ops,
.major = 1,
.minor = 0,
.name = "armada-drm",
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 8005614d2e6b..81c9da65045c 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -25,7 +25,7 @@ static vm_fault_t armada_gem_vm_fault(struct vm_fault *vmf)
return vmf_insert_pfn(vmf->vma, vmf->address, pfn);
}
-const struct vm_operations_struct armada_gem_vm_ops = {
+static const struct vm_operations_struct armada_gem_vm_ops = {
.fault = armada_gem_vm_fault,
.open = drm_gem_vm_open,
.close = drm_gem_vm_close,
@@ -184,6 +184,12 @@ armada_gem_map_object(struct drm_device *dev, struct armada_gem_object *dobj)
return dobj->addr;
}
+static const struct drm_gem_object_funcs armada_gem_object_funcs = {
+ .free = armada_gem_free_object,
+ .export = armada_gem_prime_export,
+ .vm_ops = &armada_gem_vm_ops,
+};
+
struct armada_gem_object *
armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
{
@@ -195,6 +201,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
drm_gem_private_object_init(dev, &obj->obj, size);
DRM_DEBUG_DRIVER("alloc private obj %p size %zu\n", obj, size);
@@ -214,6 +222,8 @@ static struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev,
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
if (drm_gem_object_init(dev, &obj->obj, size)) {
kfree(obj);
return NULL;
diff --git a/drivers/gpu/drm/armada/armada_gem.h b/drivers/gpu/drm/armada/armada_gem.h
index de04cc2c8f0e..ffcc7e8dd351 100644
--- a/drivers/gpu/drm/armada/armada_gem.h
+++ b/drivers/gpu/drm/armada/armada_gem.h
@@ -21,8 +21,6 @@ struct armada_gem_object {
void *update_data;
};
-extern const struct vm_operations_struct armada_gem_vm_ops;
-
#define drm_to_armada_gem(o) container_of(o, struct armada_gem_object, obj)
void armada_gem_free_object(struct drm_gem_object *);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 02/20] drm/armada: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in armada.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/armada/armada_drv.c | 3 ---
drivers/gpu/drm/armada/armada_gem.c | 12 +++++++++++-
drivers/gpu/drm/armada/armada_gem.h | 2 --
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index 5fc25c3f445c..9bccfd894be9 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -37,13 +37,10 @@ DEFINE_DRM_GEM_FOPS(armada_drm_fops);
static struct drm_driver armada_drm_driver = {
.lastclose = drm_fb_helper_lastclose,
- .gem_free_object_unlocked = armada_gem_free_object,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = armada_gem_prime_export,
.gem_prime_import = armada_gem_prime_import,
.dumb_create = armada_gem_dumb_create,
- .gem_vm_ops = &armada_gem_vm_ops,
.major = 1,
.minor = 0,
.name = "armada-drm",
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 8005614d2e6b..81c9da65045c 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -25,7 +25,7 @@ static vm_fault_t armada_gem_vm_fault(struct vm_fault *vmf)
return vmf_insert_pfn(vmf->vma, vmf->address, pfn);
}
-const struct vm_operations_struct armada_gem_vm_ops = {
+static const struct vm_operations_struct armada_gem_vm_ops = {
.fault = armada_gem_vm_fault,
.open = drm_gem_vm_open,
.close = drm_gem_vm_close,
@@ -184,6 +184,12 @@ armada_gem_map_object(struct drm_device *dev, struct armada_gem_object *dobj)
return dobj->addr;
}
+static const struct drm_gem_object_funcs armada_gem_object_funcs = {
+ .free = armada_gem_free_object,
+ .export = armada_gem_prime_export,
+ .vm_ops = &armada_gem_vm_ops,
+};
+
struct armada_gem_object *
armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
{
@@ -195,6 +201,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
drm_gem_private_object_init(dev, &obj->obj, size);
DRM_DEBUG_DRIVER("alloc private obj %p size %zu\n", obj, size);
@@ -214,6 +222,8 @@ static struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev,
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
if (drm_gem_object_init(dev, &obj->obj, size)) {
kfree(obj);
return NULL;
diff --git a/drivers/gpu/drm/armada/armada_gem.h b/drivers/gpu/drm/armada/armada_gem.h
index de04cc2c8f0e..ffcc7e8dd351 100644
--- a/drivers/gpu/drm/armada/armada_gem.h
+++ b/drivers/gpu/drm/armada/armada_gem.h
@@ -21,8 +21,6 @@ struct armada_gem_object {
void *update_data;
};
-extern const struct vm_operations_struct armada_gem_vm_ops;
-
#define drm_to_armada_gem(o) container_of(o, struct armada_gem_object, obj)
void armada_gem_free_object(struct drm_gem_object *);
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 02/20] drm/armada: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in armada.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/armada/armada_drv.c | 3 ---
drivers/gpu/drm/armada/armada_gem.c | 12 +++++++++++-
drivers/gpu/drm/armada/armada_gem.h | 2 --
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index 5fc25c3f445c..9bccfd894be9 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -37,13 +37,10 @@ DEFINE_DRM_GEM_FOPS(armada_drm_fops);
static struct drm_driver armada_drm_driver = {
.lastclose = drm_fb_helper_lastclose,
- .gem_free_object_unlocked = armada_gem_free_object,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = armada_gem_prime_export,
.gem_prime_import = armada_gem_prime_import,
.dumb_create = armada_gem_dumb_create,
- .gem_vm_ops = &armada_gem_vm_ops,
.major = 1,
.minor = 0,
.name = "armada-drm",
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 8005614d2e6b..81c9da65045c 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -25,7 +25,7 @@ static vm_fault_t armada_gem_vm_fault(struct vm_fault *vmf)
return vmf_insert_pfn(vmf->vma, vmf->address, pfn);
}
-const struct vm_operations_struct armada_gem_vm_ops = {
+static const struct vm_operations_struct armada_gem_vm_ops = {
.fault = armada_gem_vm_fault,
.open = drm_gem_vm_open,
.close = drm_gem_vm_close,
@@ -184,6 +184,12 @@ armada_gem_map_object(struct drm_device *dev, struct armada_gem_object *dobj)
return dobj->addr;
}
+static const struct drm_gem_object_funcs armada_gem_object_funcs = {
+ .free = armada_gem_free_object,
+ .export = armada_gem_prime_export,
+ .vm_ops = &armada_gem_vm_ops,
+};
+
struct armada_gem_object *
armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
{
@@ -195,6 +201,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
drm_gem_private_object_init(dev, &obj->obj, size);
DRM_DEBUG_DRIVER("alloc private obj %p size %zu\n", obj, size);
@@ -214,6 +222,8 @@ static struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev,
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
if (drm_gem_object_init(dev, &obj->obj, size)) {
kfree(obj);
return NULL;
diff --git a/drivers/gpu/drm/armada/armada_gem.h b/drivers/gpu/drm/armada/armada_gem.h
index de04cc2c8f0e..ffcc7e8dd351 100644
--- a/drivers/gpu/drm/armada/armada_gem.h
+++ b/drivers/gpu/drm/armada/armada_gem.h
@@ -21,8 +21,6 @@ struct armada_gem_object {
void *update_data;
};
-extern const struct vm_operations_struct armada_gem_vm_ops;
-
#define drm_to_armada_gem(o) container_of(o, struct armada_gem_object, obj)
void armada_gem_free_object(struct drm_gem_object *);
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 02/20] drm/armada: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in armada.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/armada/armada_drv.c | 3 ---
drivers/gpu/drm/armada/armada_gem.c | 12 +++++++++++-
drivers/gpu/drm/armada/armada_gem.h | 2 --
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index 5fc25c3f445c..9bccfd894be9 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -37,13 +37,10 @@ DEFINE_DRM_GEM_FOPS(armada_drm_fops);
static struct drm_driver armada_drm_driver = {
.lastclose = drm_fb_helper_lastclose,
- .gem_free_object_unlocked = armada_gem_free_object,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = armada_gem_prime_export,
.gem_prime_import = armada_gem_prime_import,
.dumb_create = armada_gem_dumb_create,
- .gem_vm_ops = &armada_gem_vm_ops,
.major = 1,
.minor = 0,
.name = "armada-drm",
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 8005614d2e6b..81c9da65045c 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -25,7 +25,7 @@ static vm_fault_t armada_gem_vm_fault(struct vm_fault *vmf)
return vmf_insert_pfn(vmf->vma, vmf->address, pfn);
}
-const struct vm_operations_struct armada_gem_vm_ops = {
+static const struct vm_operations_struct armada_gem_vm_ops = {
.fault = armada_gem_vm_fault,
.open = drm_gem_vm_open,
.close = drm_gem_vm_close,
@@ -184,6 +184,12 @@ armada_gem_map_object(struct drm_device *dev, struct armada_gem_object *dobj)
return dobj->addr;
}
+static const struct drm_gem_object_funcs armada_gem_object_funcs = {
+ .free = armada_gem_free_object,
+ .export = armada_gem_prime_export,
+ .vm_ops = &armada_gem_vm_ops,
+};
+
struct armada_gem_object *
armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
{
@@ -195,6 +201,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
drm_gem_private_object_init(dev, &obj->obj, size);
DRM_DEBUG_DRIVER("alloc private obj %p size %zu\n", obj, size);
@@ -214,6 +222,8 @@ static struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev,
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
if (drm_gem_object_init(dev, &obj->obj, size)) {
kfree(obj);
return NULL;
diff --git a/drivers/gpu/drm/armada/armada_gem.h b/drivers/gpu/drm/armada/armada_gem.h
index de04cc2c8f0e..ffcc7e8dd351 100644
--- a/drivers/gpu/drm/armada/armada_gem.h
+++ b/drivers/gpu/drm/armada/armada_gem.h
@@ -21,8 +21,6 @@ struct armada_gem_object {
void *update_data;
};
-extern const struct vm_operations_struct armada_gem_vm_ops;
-
#define drm_to_armada_gem(o) container_of(o, struct armada_gem_object, obj)
void armada_gem_free_object(struct drm_gem_object *);
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 02/20] drm/armada: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in armada.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/armada/armada_drv.c | 3 ---
drivers/gpu/drm/armada/armada_gem.c | 12 +++++++++++-
drivers/gpu/drm/armada/armada_gem.h | 2 --
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index 5fc25c3f445c..9bccfd894be9 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -37,13 +37,10 @@ DEFINE_DRM_GEM_FOPS(armada_drm_fops);
static struct drm_driver armada_drm_driver = {
.lastclose = drm_fb_helper_lastclose,
- .gem_free_object_unlocked = armada_gem_free_object,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = armada_gem_prime_export,
.gem_prime_import = armada_gem_prime_import,
.dumb_create = armada_gem_dumb_create,
- .gem_vm_ops = &armada_gem_vm_ops,
.major = 1,
.minor = 0,
.name = "armada-drm",
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 8005614d2e6b..81c9da65045c 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -25,7 +25,7 @@ static vm_fault_t armada_gem_vm_fault(struct vm_fault *vmf)
return vmf_insert_pfn(vmf->vma, vmf->address, pfn);
}
-const struct vm_operations_struct armada_gem_vm_ops = {
+static const struct vm_operations_struct armada_gem_vm_ops = {
.fault = armada_gem_vm_fault,
.open = drm_gem_vm_open,
.close = drm_gem_vm_close,
@@ -184,6 +184,12 @@ armada_gem_map_object(struct drm_device *dev, struct armada_gem_object *dobj)
return dobj->addr;
}
+static const struct drm_gem_object_funcs armada_gem_object_funcs = {
+ .free = armada_gem_free_object,
+ .export = armada_gem_prime_export,
+ .vm_ops = &armada_gem_vm_ops,
+};
+
struct armada_gem_object *
armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
{
@@ -195,6 +201,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
drm_gem_private_object_init(dev, &obj->obj, size);
DRM_DEBUG_DRIVER("alloc private obj %p size %zu\n", obj, size);
@@ -214,6 +222,8 @@ static struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev,
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
if (drm_gem_object_init(dev, &obj->obj, size)) {
kfree(obj);
return NULL;
diff --git a/drivers/gpu/drm/armada/armada_gem.h b/drivers/gpu/drm/armada/armada_gem.h
index de04cc2c8f0e..ffcc7e8dd351 100644
--- a/drivers/gpu/drm/armada/armada_gem.h
+++ b/drivers/gpu/drm/armada/armada_gem.h
@@ -21,8 +21,6 @@ struct armada_gem_object {
void *update_data;
};
-extern const struct vm_operations_struct armada_gem_vm_ops;
-
#define drm_to_armada_gem(o) container_of(o, struct armada_gem_object, obj)
void armada_gem_free_object(struct drm_gem_object *);
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 02/20] drm/armada: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in armada.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/armada/armada_drv.c | 3 ---
drivers/gpu/drm/armada/armada_gem.c | 12 +++++++++++-
drivers/gpu/drm/armada/armada_gem.h | 2 --
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index 5fc25c3f445c..9bccfd894be9 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -37,13 +37,10 @@ DEFINE_DRM_GEM_FOPS(armada_drm_fops);
static struct drm_driver armada_drm_driver = {
.lastclose = drm_fb_helper_lastclose,
- .gem_free_object_unlocked = armada_gem_free_object,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = armada_gem_prime_export,
.gem_prime_import = armada_gem_prime_import,
.dumb_create = armada_gem_dumb_create,
- .gem_vm_ops = &armada_gem_vm_ops,
.major = 1,
.minor = 0,
.name = "armada-drm",
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 8005614d2e6b..81c9da65045c 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -25,7 +25,7 @@ static vm_fault_t armada_gem_vm_fault(struct vm_fault *vmf)
return vmf_insert_pfn(vmf->vma, vmf->address, pfn);
}
-const struct vm_operations_struct armada_gem_vm_ops = {
+static const struct vm_operations_struct armada_gem_vm_ops = {
.fault = armada_gem_vm_fault,
.open = drm_gem_vm_open,
.close = drm_gem_vm_close,
@@ -184,6 +184,12 @@ armada_gem_map_object(struct drm_device *dev, struct armada_gem_object *dobj)
return dobj->addr;
}
+static const struct drm_gem_object_funcs armada_gem_object_funcs = {
+ .free = armada_gem_free_object,
+ .export = armada_gem_prime_export,
+ .vm_ops = &armada_gem_vm_ops,
+};
+
struct armada_gem_object *
armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
{
@@ -195,6 +201,8 @@ armada_gem_alloc_private_object(struct drm_device *dev, size_t size)
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
drm_gem_private_object_init(dev, &obj->obj, size);
DRM_DEBUG_DRIVER("alloc private obj %p size %zu\n", obj, size);
@@ -214,6 +222,8 @@ static struct armada_gem_object *armada_gem_alloc_object(struct drm_device *dev,
if (!obj)
return NULL;
+ obj->obj.funcs = &armada_gem_object_funcs;
+
if (drm_gem_object_init(dev, &obj->obj, size)) {
kfree(obj);
return NULL;
diff --git a/drivers/gpu/drm/armada/armada_gem.h b/drivers/gpu/drm/armada/armada_gem.h
index de04cc2c8f0e..ffcc7e8dd351 100644
--- a/drivers/gpu/drm/armada/armada_gem.h
+++ b/drivers/gpu/drm/armada/armada_gem.h
@@ -21,8 +21,6 @@ struct armada_gem_object {
void *update_data;
};
-extern const struct vm_operations_struct armada_gem_vm_ops;
-
#define drm_to_armada_gem(o) container_of(o, struct armada_gem_object, obj)
void armada_gem_free_object(struct drm_gem_object *);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 03/20] drm/etnaviv: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 -------------
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index a9a3afaef9a1..aa270b79e585 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -468,12 +468,6 @@ static const struct drm_ioctl_desc etnaviv_ioctls[] = {
ETNA_IOCTL(PM_QUERY_SIG, pm_query_sig, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = etnaviv_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -490,16 +484,9 @@ static struct drm_driver etnaviv_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.open = etnaviv_open,
.postclose = etnaviv_postclose,
- .gem_free_object_unlocked = etnaviv_gem_free_object,
- .gem_vm_ops = &vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = etnaviv_gem_prime_pin,
- .gem_prime_unpin = etnaviv_gem_prime_unpin,
- .gem_prime_get_sg_table = etnaviv_gem_prime_get_sg_table,
.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
- .gem_prime_vmap = etnaviv_gem_prime_vmap,
- .gem_prime_vunmap = etnaviv_gem_prime_vunmap,
.gem_prime_mmap = etnaviv_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = etnaviv_debugfs_init,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index 4d8dc9236e5f..914f0867ff71 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -49,7 +49,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
struct drm_file *file);
int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf);
int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index f06e19e7be04..66de9f299c76 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -170,7 +170,7 @@ int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return obj->ops->mmap(obj, vma);
}
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
+static vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -560,6 +560,22 @@ void etnaviv_gem_obj_add(struct drm_device *dev, struct drm_gem_object *obj)
mutex_unlock(&priv->gem_lock);
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = etnaviv_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs etnaviv_gem_object_funcs = {
+ .free = etnaviv_gem_free_object,
+ .pin = etnaviv_gem_prime_pin,
+ .unpin = etnaviv_gem_prime_unpin,
+ .get_sg_table = etnaviv_gem_prime_get_sg_table,
+ .vmap = etnaviv_gem_prime_vmap,
+ .vunmap = etnaviv_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj)
{
@@ -594,6 +610,7 @@ static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
INIT_LIST_HEAD(&etnaviv_obj->vram_list);
*obj = &etnaviv_obj->base;
+ (*obj)->funcs = &etnaviv_gem_object_funcs;
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 03/20] drm/etnaviv: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 -------------
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index a9a3afaef9a1..aa270b79e585 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -468,12 +468,6 @@ static const struct drm_ioctl_desc etnaviv_ioctls[] = {
ETNA_IOCTL(PM_QUERY_SIG, pm_query_sig, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = etnaviv_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -490,16 +484,9 @@ static struct drm_driver etnaviv_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.open = etnaviv_open,
.postclose = etnaviv_postclose,
- .gem_free_object_unlocked = etnaviv_gem_free_object,
- .gem_vm_ops = &vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = etnaviv_gem_prime_pin,
- .gem_prime_unpin = etnaviv_gem_prime_unpin,
- .gem_prime_get_sg_table = etnaviv_gem_prime_get_sg_table,
.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
- .gem_prime_vmap = etnaviv_gem_prime_vmap,
- .gem_prime_vunmap = etnaviv_gem_prime_vunmap,
.gem_prime_mmap = etnaviv_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = etnaviv_debugfs_init,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index 4d8dc9236e5f..914f0867ff71 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -49,7 +49,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
struct drm_file *file);
int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf);
int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index f06e19e7be04..66de9f299c76 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -170,7 +170,7 @@ int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return obj->ops->mmap(obj, vma);
}
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
+static vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -560,6 +560,22 @@ void etnaviv_gem_obj_add(struct drm_device *dev, struct drm_gem_object *obj)
mutex_unlock(&priv->gem_lock);
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = etnaviv_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs etnaviv_gem_object_funcs = {
+ .free = etnaviv_gem_free_object,
+ .pin = etnaviv_gem_prime_pin,
+ .unpin = etnaviv_gem_prime_unpin,
+ .get_sg_table = etnaviv_gem_prime_get_sg_table,
+ .vmap = etnaviv_gem_prime_vmap,
+ .vunmap = etnaviv_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj)
{
@@ -594,6 +610,7 @@ static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
INIT_LIST_HEAD(&etnaviv_obj->vram_list);
*obj = &etnaviv_obj->base;
+ (*obj)->funcs = &etnaviv_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 03/20] drm/etnaviv: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 -------------
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index a9a3afaef9a1..aa270b79e585 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -468,12 +468,6 @@ static const struct drm_ioctl_desc etnaviv_ioctls[] = {
ETNA_IOCTL(PM_QUERY_SIG, pm_query_sig, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = etnaviv_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -490,16 +484,9 @@ static struct drm_driver etnaviv_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.open = etnaviv_open,
.postclose = etnaviv_postclose,
- .gem_free_object_unlocked = etnaviv_gem_free_object,
- .gem_vm_ops = &vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = etnaviv_gem_prime_pin,
- .gem_prime_unpin = etnaviv_gem_prime_unpin,
- .gem_prime_get_sg_table = etnaviv_gem_prime_get_sg_table,
.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
- .gem_prime_vmap = etnaviv_gem_prime_vmap,
- .gem_prime_vunmap = etnaviv_gem_prime_vunmap,
.gem_prime_mmap = etnaviv_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = etnaviv_debugfs_init,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index 4d8dc9236e5f..914f0867ff71 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -49,7 +49,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
struct drm_file *file);
int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf);
int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index f06e19e7be04..66de9f299c76 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -170,7 +170,7 @@ int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return obj->ops->mmap(obj, vma);
}
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
+static vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -560,6 +560,22 @@ void etnaviv_gem_obj_add(struct drm_device *dev, struct drm_gem_object *obj)
mutex_unlock(&priv->gem_lock);
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = etnaviv_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs etnaviv_gem_object_funcs = {
+ .free = etnaviv_gem_free_object,
+ .pin = etnaviv_gem_prime_pin,
+ .unpin = etnaviv_gem_prime_unpin,
+ .get_sg_table = etnaviv_gem_prime_get_sg_table,
+ .vmap = etnaviv_gem_prime_vmap,
+ .vunmap = etnaviv_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj)
{
@@ -594,6 +610,7 @@ static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
INIT_LIST_HEAD(&etnaviv_obj->vram_list);
*obj = &etnaviv_obj->base;
+ (*obj)->funcs = &etnaviv_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 03/20] drm/etnaviv: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 -------------
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index a9a3afaef9a1..aa270b79e585 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -468,12 +468,6 @@ static const struct drm_ioctl_desc etnaviv_ioctls[] = {
ETNA_IOCTL(PM_QUERY_SIG, pm_query_sig, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = etnaviv_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -490,16 +484,9 @@ static struct drm_driver etnaviv_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.open = etnaviv_open,
.postclose = etnaviv_postclose,
- .gem_free_object_unlocked = etnaviv_gem_free_object,
- .gem_vm_ops = &vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = etnaviv_gem_prime_pin,
- .gem_prime_unpin = etnaviv_gem_prime_unpin,
- .gem_prime_get_sg_table = etnaviv_gem_prime_get_sg_table,
.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
- .gem_prime_vmap = etnaviv_gem_prime_vmap,
- .gem_prime_vunmap = etnaviv_gem_prime_vunmap,
.gem_prime_mmap = etnaviv_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = etnaviv_debugfs_init,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index 4d8dc9236e5f..914f0867ff71 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -49,7 +49,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
struct drm_file *file);
int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf);
int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index f06e19e7be04..66de9f299c76 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -170,7 +170,7 @@ int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return obj->ops->mmap(obj, vma);
}
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
+static vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -560,6 +560,22 @@ void etnaviv_gem_obj_add(struct drm_device *dev, struct drm_gem_object *obj)
mutex_unlock(&priv->gem_lock);
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = etnaviv_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs etnaviv_gem_object_funcs = {
+ .free = etnaviv_gem_free_object,
+ .pin = etnaviv_gem_prime_pin,
+ .unpin = etnaviv_gem_prime_unpin,
+ .get_sg_table = etnaviv_gem_prime_get_sg_table,
+ .vmap = etnaviv_gem_prime_vmap,
+ .vunmap = etnaviv_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj)
{
@@ -594,6 +610,7 @@ static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
INIT_LIST_HEAD(&etnaviv_obj->vram_list);
*obj = &etnaviv_obj->base;
+ (*obj)->funcs = &etnaviv_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 03/20] drm/etnaviv: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 -------------
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index a9a3afaef9a1..aa270b79e585 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -468,12 +468,6 @@ static const struct drm_ioctl_desc etnaviv_ioctls[] = {
ETNA_IOCTL(PM_QUERY_SIG, pm_query_sig, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = etnaviv_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -490,16 +484,9 @@ static struct drm_driver etnaviv_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.open = etnaviv_open,
.postclose = etnaviv_postclose,
- .gem_free_object_unlocked = etnaviv_gem_free_object,
- .gem_vm_ops = &vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = etnaviv_gem_prime_pin,
- .gem_prime_unpin = etnaviv_gem_prime_unpin,
- .gem_prime_get_sg_table = etnaviv_gem_prime_get_sg_table,
.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
- .gem_prime_vmap = etnaviv_gem_prime_vmap,
- .gem_prime_vunmap = etnaviv_gem_prime_vunmap,
.gem_prime_mmap = etnaviv_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = etnaviv_debugfs_init,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index 4d8dc9236e5f..914f0867ff71 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -49,7 +49,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
struct drm_file *file);
int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf);
int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index f06e19e7be04..66de9f299c76 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -170,7 +170,7 @@ int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return obj->ops->mmap(obj, vma);
}
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
+static vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -560,6 +560,22 @@ void etnaviv_gem_obj_add(struct drm_device *dev, struct drm_gem_object *obj)
mutex_unlock(&priv->gem_lock);
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = etnaviv_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs etnaviv_gem_object_funcs = {
+ .free = etnaviv_gem_free_object,
+ .pin = etnaviv_gem_prime_pin,
+ .unpin = etnaviv_gem_prime_unpin,
+ .get_sg_table = etnaviv_gem_prime_get_sg_table,
+ .vmap = etnaviv_gem_prime_vmap,
+ .vunmap = etnaviv_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj)
{
@@ -594,6 +610,7 @@ static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
INIT_LIST_HEAD(&etnaviv_obj->vram_list);
*obj = &etnaviv_obj->base;
+ (*obj)->funcs = &etnaviv_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 03/20] drm/etnaviv: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in etnaviv. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 13 -------------
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 -
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index a9a3afaef9a1..aa270b79e585 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -468,12 +468,6 @@ static const struct drm_ioctl_desc etnaviv_ioctls[] = {
ETNA_IOCTL(PM_QUERY_SIG, pm_query_sig, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = etnaviv_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -490,16 +484,9 @@ static struct drm_driver etnaviv_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.open = etnaviv_open,
.postclose = etnaviv_postclose,
- .gem_free_object_unlocked = etnaviv_gem_free_object,
- .gem_vm_ops = &vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = etnaviv_gem_prime_pin,
- .gem_prime_unpin = etnaviv_gem_prime_unpin,
- .gem_prime_get_sg_table = etnaviv_gem_prime_get_sg_table,
.gem_prime_import_sg_table = etnaviv_gem_prime_import_sg_table,
- .gem_prime_vmap = etnaviv_gem_prime_vmap,
- .gem_prime_vunmap = etnaviv_gem_prime_vunmap,
.gem_prime_mmap = etnaviv_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = etnaviv_debugfs_init,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
index 4d8dc9236e5f..914f0867ff71 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
@@ -49,7 +49,6 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
struct drm_file *file);
int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf);
int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index f06e19e7be04..66de9f299c76 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -170,7 +170,7 @@ int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return obj->ops->mmap(obj, vma);
}
-vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
+static vm_fault_t etnaviv_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -560,6 +560,22 @@ void etnaviv_gem_obj_add(struct drm_device *dev, struct drm_gem_object *obj)
mutex_unlock(&priv->gem_lock);
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = etnaviv_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs etnaviv_gem_object_funcs = {
+ .free = etnaviv_gem_free_object,
+ .pin = etnaviv_gem_prime_pin,
+ .unpin = etnaviv_gem_prime_unpin,
+ .get_sg_table = etnaviv_gem_prime_get_sg_table,
+ .vmap = etnaviv_gem_prime_vmap,
+ .vunmap = etnaviv_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
const struct etnaviv_gem_ops *ops, struct drm_gem_object **obj)
{
@@ -594,6 +610,7 @@ static int etnaviv_gem_new_impl(struct drm_device *dev, u32 size, u32 flags,
INIT_LIST_HEAD(&etnaviv_obj->vram_list);
*obj = &etnaviv_obj->base;
+ (*obj)->funcs = &etnaviv_gem_object_funcs;
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 04/20] drm/exynos: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in exynos. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ----------
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 +++++++++++++++
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index dbd80f1e4c78..fe46680ca208 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -75,11 +75,6 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
file->driver_priv = NULL;
}
-static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct drm_ioctl_desc exynos_ioctls[] = {
DRM_IOCTL_DEF_DRV(EXYNOS_GEM_CREATE, exynos_drm_gem_create_ioctl,
DRM_RENDER_ALLOW),
@@ -124,16 +119,11 @@ static struct drm_driver exynos_drm_driver = {
.open = exynos_drm_open,
.lastclose = drm_fb_helper_lastclose,
.postclose = exynos_drm_postclose,
- .gem_free_object_unlocked = exynos_drm_gem_free_object,
- .gem_vm_ops = &exynos_drm_gem_vm_ops,
.dumb_create = exynos_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = exynos_drm_gem_prime_import,
- .gem_prime_get_sg_table = exynos_drm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = exynos_drm_gem_prime_import_sg_table,
- .gem_prime_vmap = exynos_drm_gem_prime_vmap,
- .gem_prime_vunmap = exynos_drm_gem_prime_vunmap,
.gem_prime_mmap = exynos_drm_gem_prime_mmap,
.ioctls = exynos_ioctls,
.num_ioctls = ARRAY_SIZE(exynos_ioctls),
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index efa476858db5..69a5cf28b4ae 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -129,6 +129,19 @@ void exynos_drm_gem_destroy(struct exynos_drm_gem *exynos_gem)
kfree(exynos_gem);
}
+static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs exynos_drm_gem_object_funcs = {
+ .free = exynos_drm_gem_free_object,
+ .get_sg_table = exynos_drm_gem_prime_get_sg_table,
+ .vmap = exynos_drm_gem_prime_vmap,
+ .vunmap = exynos_drm_gem_prime_vunmap,
+ .vm_ops = &exynos_drm_gem_vm_ops,
+};
+
static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -143,6 +156,8 @@ static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
exynos_gem->size = size;
obj = &exynos_gem->base;
+ obj->funcs = &exynos_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, obj, size);
if (ret < 0) {
DRM_DEV_ERROR(dev->dev, "failed to initialize gem object\n");
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 04/20] drm/exynos: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in exynos. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ----------
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 +++++++++++++++
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index dbd80f1e4c78..fe46680ca208 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -75,11 +75,6 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
file->driver_priv = NULL;
}
-static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct drm_ioctl_desc exynos_ioctls[] = {
DRM_IOCTL_DEF_DRV(EXYNOS_GEM_CREATE, exynos_drm_gem_create_ioctl,
DRM_RENDER_ALLOW),
@@ -124,16 +119,11 @@ static struct drm_driver exynos_drm_driver = {
.open = exynos_drm_open,
.lastclose = drm_fb_helper_lastclose,
.postclose = exynos_drm_postclose,
- .gem_free_object_unlocked = exynos_drm_gem_free_object,
- .gem_vm_ops = &exynos_drm_gem_vm_ops,
.dumb_create = exynos_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = exynos_drm_gem_prime_import,
- .gem_prime_get_sg_table = exynos_drm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = exynos_drm_gem_prime_import_sg_table,
- .gem_prime_vmap = exynos_drm_gem_prime_vmap,
- .gem_prime_vunmap = exynos_drm_gem_prime_vunmap,
.gem_prime_mmap = exynos_drm_gem_prime_mmap,
.ioctls = exynos_ioctls,
.num_ioctls = ARRAY_SIZE(exynos_ioctls),
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index efa476858db5..69a5cf28b4ae 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -129,6 +129,19 @@ void exynos_drm_gem_destroy(struct exynos_drm_gem *exynos_gem)
kfree(exynos_gem);
}
+static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs exynos_drm_gem_object_funcs = {
+ .free = exynos_drm_gem_free_object,
+ .get_sg_table = exynos_drm_gem_prime_get_sg_table,
+ .vmap = exynos_drm_gem_prime_vmap,
+ .vunmap = exynos_drm_gem_prime_vunmap,
+ .vm_ops = &exynos_drm_gem_vm_ops,
+};
+
static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -143,6 +156,8 @@ static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
exynos_gem->size = size;
obj = &exynos_gem->base;
+ obj->funcs = &exynos_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, obj, size);
if (ret < 0) {
DRM_DEV_ERROR(dev->dev, "failed to initialize gem object\n");
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 04/20] drm/exynos: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in exynos. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ----------
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 +++++++++++++++
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index dbd80f1e4c78..fe46680ca208 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -75,11 +75,6 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
file->driver_priv = NULL;
}
-static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct drm_ioctl_desc exynos_ioctls[] = {
DRM_IOCTL_DEF_DRV(EXYNOS_GEM_CREATE, exynos_drm_gem_create_ioctl,
DRM_RENDER_ALLOW),
@@ -124,16 +119,11 @@ static struct drm_driver exynos_drm_driver = {
.open = exynos_drm_open,
.lastclose = drm_fb_helper_lastclose,
.postclose = exynos_drm_postclose,
- .gem_free_object_unlocked = exynos_drm_gem_free_object,
- .gem_vm_ops = &exynos_drm_gem_vm_ops,
.dumb_create = exynos_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = exynos_drm_gem_prime_import,
- .gem_prime_get_sg_table = exynos_drm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = exynos_drm_gem_prime_import_sg_table,
- .gem_prime_vmap = exynos_drm_gem_prime_vmap,
- .gem_prime_vunmap = exynos_drm_gem_prime_vunmap,
.gem_prime_mmap = exynos_drm_gem_prime_mmap,
.ioctls = exynos_ioctls,
.num_ioctls = ARRAY_SIZE(exynos_ioctls),
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index efa476858db5..69a5cf28b4ae 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -129,6 +129,19 @@ void exynos_drm_gem_destroy(struct exynos_drm_gem *exynos_gem)
kfree(exynos_gem);
}
+static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs exynos_drm_gem_object_funcs = {
+ .free = exynos_drm_gem_free_object,
+ .get_sg_table = exynos_drm_gem_prime_get_sg_table,
+ .vmap = exynos_drm_gem_prime_vmap,
+ .vunmap = exynos_drm_gem_prime_vunmap,
+ .vm_ops = &exynos_drm_gem_vm_ops,
+};
+
static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -143,6 +156,8 @@ static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
exynos_gem->size = size;
obj = &exynos_gem->base;
+ obj->funcs = &exynos_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, obj, size);
if (ret < 0) {
DRM_DEV_ERROR(dev->dev, "failed to initialize gem object\n");
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 04/20] drm/exynos: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in exynos. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ----------
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 +++++++++++++++
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index dbd80f1e4c78..fe46680ca208 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -75,11 +75,6 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
file->driver_priv = NULL;
}
-static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct drm_ioctl_desc exynos_ioctls[] = {
DRM_IOCTL_DEF_DRV(EXYNOS_GEM_CREATE, exynos_drm_gem_create_ioctl,
DRM_RENDER_ALLOW),
@@ -124,16 +119,11 @@ static struct drm_driver exynos_drm_driver = {
.open = exynos_drm_open,
.lastclose = drm_fb_helper_lastclose,
.postclose = exynos_drm_postclose,
- .gem_free_object_unlocked = exynos_drm_gem_free_object,
- .gem_vm_ops = &exynos_drm_gem_vm_ops,
.dumb_create = exynos_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = exynos_drm_gem_prime_import,
- .gem_prime_get_sg_table = exynos_drm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = exynos_drm_gem_prime_import_sg_table,
- .gem_prime_vmap = exynos_drm_gem_prime_vmap,
- .gem_prime_vunmap = exynos_drm_gem_prime_vunmap,
.gem_prime_mmap = exynos_drm_gem_prime_mmap,
.ioctls = exynos_ioctls,
.num_ioctls = ARRAY_SIZE(exynos_ioctls),
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index efa476858db5..69a5cf28b4ae 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -129,6 +129,19 @@ void exynos_drm_gem_destroy(struct exynos_drm_gem *exynos_gem)
kfree(exynos_gem);
}
+static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs exynos_drm_gem_object_funcs = {
+ .free = exynos_drm_gem_free_object,
+ .get_sg_table = exynos_drm_gem_prime_get_sg_table,
+ .vmap = exynos_drm_gem_prime_vmap,
+ .vunmap = exynos_drm_gem_prime_vunmap,
+ .vm_ops = &exynos_drm_gem_vm_ops,
+};
+
static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -143,6 +156,8 @@ static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
exynos_gem->size = size;
obj = &exynos_gem->base;
+ obj->funcs = &exynos_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, obj, size);
if (ret < 0) {
DRM_DEV_ERROR(dev->dev, "failed to initialize gem object\n");
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 04/20] drm/exynos: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in exynos. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ----------
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 +++++++++++++++
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index dbd80f1e4c78..fe46680ca208 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -75,11 +75,6 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
file->driver_priv = NULL;
}
-static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct drm_ioctl_desc exynos_ioctls[] = {
DRM_IOCTL_DEF_DRV(EXYNOS_GEM_CREATE, exynos_drm_gem_create_ioctl,
DRM_RENDER_ALLOW),
@@ -124,16 +119,11 @@ static struct drm_driver exynos_drm_driver = {
.open = exynos_drm_open,
.lastclose = drm_fb_helper_lastclose,
.postclose = exynos_drm_postclose,
- .gem_free_object_unlocked = exynos_drm_gem_free_object,
- .gem_vm_ops = &exynos_drm_gem_vm_ops,
.dumb_create = exynos_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = exynos_drm_gem_prime_import,
- .gem_prime_get_sg_table = exynos_drm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = exynos_drm_gem_prime_import_sg_table,
- .gem_prime_vmap = exynos_drm_gem_prime_vmap,
- .gem_prime_vunmap = exynos_drm_gem_prime_vunmap,
.gem_prime_mmap = exynos_drm_gem_prime_mmap,
.ioctls = exynos_ioctls,
.num_ioctls = ARRAY_SIZE(exynos_ioctls),
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index efa476858db5..69a5cf28b4ae 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -129,6 +129,19 @@ void exynos_drm_gem_destroy(struct exynos_drm_gem *exynos_gem)
kfree(exynos_gem);
}
+static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs exynos_drm_gem_object_funcs = {
+ .free = exynos_drm_gem_free_object,
+ .get_sg_table = exynos_drm_gem_prime_get_sg_table,
+ .vmap = exynos_drm_gem_prime_vmap,
+ .vunmap = exynos_drm_gem_prime_vunmap,
+ .vm_ops = &exynos_drm_gem_vm_ops,
+};
+
static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -143,6 +156,8 @@ static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
exynos_gem->size = size;
obj = &exynos_gem->base;
+ obj->funcs = &exynos_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, obj, size);
if (ret < 0) {
DRM_DEV_ERROR(dev->dev, "failed to initialize gem object\n");
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 04/20] drm/exynos: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in exynos. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ----------
drivers/gpu/drm/exynos/exynos_drm_gem.c | 15 +++++++++++++++
2 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index dbd80f1e4c78..fe46680ca208 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -75,11 +75,6 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
file->driver_priv = NULL;
}
-static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct drm_ioctl_desc exynos_ioctls[] = {
DRM_IOCTL_DEF_DRV(EXYNOS_GEM_CREATE, exynos_drm_gem_create_ioctl,
DRM_RENDER_ALLOW),
@@ -124,16 +119,11 @@ static struct drm_driver exynos_drm_driver = {
.open = exynos_drm_open,
.lastclose = drm_fb_helper_lastclose,
.postclose = exynos_drm_postclose,
- .gem_free_object_unlocked = exynos_drm_gem_free_object,
- .gem_vm_ops = &exynos_drm_gem_vm_ops,
.dumb_create = exynos_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = exynos_drm_gem_prime_import,
- .gem_prime_get_sg_table = exynos_drm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = exynos_drm_gem_prime_import_sg_table,
- .gem_prime_vmap = exynos_drm_gem_prime_vmap,
- .gem_prime_vunmap = exynos_drm_gem_prime_vunmap,
.gem_prime_mmap = exynos_drm_gem_prime_mmap,
.ioctls = exynos_ioctls,
.num_ioctls = ARRAY_SIZE(exynos_ioctls),
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index efa476858db5..69a5cf28b4ae 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -129,6 +129,19 @@ void exynos_drm_gem_destroy(struct exynos_drm_gem *exynos_gem)
kfree(exynos_gem);
}
+static const struct vm_operations_struct exynos_drm_gem_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs exynos_drm_gem_object_funcs = {
+ .free = exynos_drm_gem_free_object,
+ .get_sg_table = exynos_drm_gem_prime_get_sg_table,
+ .vmap = exynos_drm_gem_prime_vmap,
+ .vunmap = exynos_drm_gem_prime_vunmap,
+ .vm_ops = &exynos_drm_gem_vm_ops,
+};
+
static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -143,6 +156,8 @@ static struct exynos_drm_gem *exynos_drm_gem_init(struct drm_device *dev,
exynos_gem->size = size;
obj = &exynos_gem->base;
+ obj->funcs = &exynos_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, obj, size);
if (ret < 0) {
DRM_DEV_ERROR(dev->dev, "failed to initialize gem object\n");
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 05/20] drm/gma500: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in gma500.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/gma500/framebuffer.c | 2 ++
drivers/gpu/drm/gma500/gem.c | 18 ++++++++++++++++--
drivers/gpu/drm/gma500/gem.h | 3 +++
drivers/gpu/drm/gma500/psb_drv.c | 9 ---------
drivers/gpu/drm/gma500/psb_drv.h | 2 --
5 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index da02d7e8a8f5..12c19f5fbb5d 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -24,6 +24,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include "framebuffer.h"
+#include "gem.h"
#include "gtt.h"
#include "psb_drv.h"
#include "psb_intel_drv.h"
@@ -285,6 +286,7 @@ static struct gtt_range *psbfb_alloc(struct drm_device *dev, int aligned_size)
/* Begin by trying to use stolen memory backing */
backing = psb_gtt_alloc_range(dev, aligned_size, "fb", 1, PAGE_SIZE);
if (backing) {
+ backing->gem.funcs = &psb_gem_object_funcs;
drm_gem_private_object_init(dev, &backing->gem, aligned_size);
return backing;
}
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index f9c4b1d76f56..8f07de83b6fb 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -18,7 +18,9 @@
#include "psb_drv.h"
-void psb_gem_free_object(struct drm_gem_object *obj)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf);
+
+static void psb_gem_free_object(struct drm_gem_object *obj)
{
struct gtt_range *gtt = container_of(obj, struct gtt_range, gem);
@@ -36,6 +38,17 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data,
return -EINVAL;
}
+static const struct vm_operations_struct psb_gem_vm_ops = {
+ .fault = psb_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+const struct drm_gem_object_funcs psb_gem_object_funcs = {
+ .free = psb_gem_free_object,
+ .vm_ops = &psb_gem_vm_ops,
+};
+
/**
* psb_gem_create - create a mappable object
* @file: the DRM file of the client
@@ -63,6 +76,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size,
dev_err(dev->dev, "no memory for %lld byte GEM object\n", size);
return -ENOSPC;
}
+ r->gem.funcs = &psb_gem_object_funcs;
/* Initialize the extra goodies GEM needs to do all the hard work */
if (drm_gem_object_init(dev, &r->gem, size) != 0) {
psb_gtt_free_range(dev, r);
@@ -123,7 +137,7 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t psb_gem_fault(struct vm_fault *vmf)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj;
diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h
index 4a74dc623b6b..3741a711b9fd 100644
--- a/drivers/gpu/drm/gma500/gem.h
+++ b/drivers/gpu/drm/gma500/gem.h
@@ -8,6 +8,9 @@
#ifndef _GEM_H
#define _GEM_H
+extern const struct drm_gem_object_funcs psb_gem_object_funcs;
+
extern int psb_gem_create(struct drm_file *file, struct drm_device *dev,
u64 size, u32 *handlep, int stolen, u32 align);
+
#endif
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 34b4aae9a15e..b13376a6fb91 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -480,12 +480,6 @@ static const struct dev_pm_ops psb_pm_ops = {
.runtime_idle = psb_runtime_idle,
};
-static const struct vm_operations_struct psb_gem_vm_ops = {
- .fault = psb_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations psb_gem_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -507,9 +501,6 @@ static struct drm_driver driver = {
.irq_uninstall = psb_irq_uninstall,
.irq_handler = psb_irq_handler,
- .gem_free_object_unlocked = psb_gem_free_object,
- .gem_vm_ops = &psb_gem_vm_ops,
-
.dumb_create = psb_gem_dumb_create,
.ioctls = psb_ioctls,
.fops = &psb_gem_fops,
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 956926341316..c71a5a4e912c 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -735,12 +735,10 @@ extern const struct drm_connector_helper_funcs
extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
/* gem.c */
-extern void psb_gem_free_object(struct drm_gem_object *obj);
extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
struct drm_file *file);
extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
struct drm_mode_create_dumb *args);
-extern vm_fault_t psb_gem_fault(struct vm_fault *vmf);
/* psb_device.c */
extern const struct psb_ops psb_chip_ops;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 05/20] drm/gma500: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in gma500.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/gma500/framebuffer.c | 2 ++
drivers/gpu/drm/gma500/gem.c | 18 ++++++++++++++++--
drivers/gpu/drm/gma500/gem.h | 3 +++
drivers/gpu/drm/gma500/psb_drv.c | 9 ---------
drivers/gpu/drm/gma500/psb_drv.h | 2 --
5 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index da02d7e8a8f5..12c19f5fbb5d 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -24,6 +24,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include "framebuffer.h"
+#include "gem.h"
#include "gtt.h"
#include "psb_drv.h"
#include "psb_intel_drv.h"
@@ -285,6 +286,7 @@ static struct gtt_range *psbfb_alloc(struct drm_device *dev, int aligned_size)
/* Begin by trying to use stolen memory backing */
backing = psb_gtt_alloc_range(dev, aligned_size, "fb", 1, PAGE_SIZE);
if (backing) {
+ backing->gem.funcs = &psb_gem_object_funcs;
drm_gem_private_object_init(dev, &backing->gem, aligned_size);
return backing;
}
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index f9c4b1d76f56..8f07de83b6fb 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -18,7 +18,9 @@
#include "psb_drv.h"
-void psb_gem_free_object(struct drm_gem_object *obj)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf);
+
+static void psb_gem_free_object(struct drm_gem_object *obj)
{
struct gtt_range *gtt = container_of(obj, struct gtt_range, gem);
@@ -36,6 +38,17 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data,
return -EINVAL;
}
+static const struct vm_operations_struct psb_gem_vm_ops = {
+ .fault = psb_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+const struct drm_gem_object_funcs psb_gem_object_funcs = {
+ .free = psb_gem_free_object,
+ .vm_ops = &psb_gem_vm_ops,
+};
+
/**
* psb_gem_create - create a mappable object
* @file: the DRM file of the client
@@ -63,6 +76,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size,
dev_err(dev->dev, "no memory for %lld byte GEM object\n", size);
return -ENOSPC;
}
+ r->gem.funcs = &psb_gem_object_funcs;
/* Initialize the extra goodies GEM needs to do all the hard work */
if (drm_gem_object_init(dev, &r->gem, size) != 0) {
psb_gtt_free_range(dev, r);
@@ -123,7 +137,7 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t psb_gem_fault(struct vm_fault *vmf)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj;
diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h
index 4a74dc623b6b..3741a711b9fd 100644
--- a/drivers/gpu/drm/gma500/gem.h
+++ b/drivers/gpu/drm/gma500/gem.h
@@ -8,6 +8,9 @@
#ifndef _GEM_H
#define _GEM_H
+extern const struct drm_gem_object_funcs psb_gem_object_funcs;
+
extern int psb_gem_create(struct drm_file *file, struct drm_device *dev,
u64 size, u32 *handlep, int stolen, u32 align);
+
#endif
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 34b4aae9a15e..b13376a6fb91 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -480,12 +480,6 @@ static const struct dev_pm_ops psb_pm_ops = {
.runtime_idle = psb_runtime_idle,
};
-static const struct vm_operations_struct psb_gem_vm_ops = {
- .fault = psb_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations psb_gem_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -507,9 +501,6 @@ static struct drm_driver driver = {
.irq_uninstall = psb_irq_uninstall,
.irq_handler = psb_irq_handler,
- .gem_free_object_unlocked = psb_gem_free_object,
- .gem_vm_ops = &psb_gem_vm_ops,
-
.dumb_create = psb_gem_dumb_create,
.ioctls = psb_ioctls,
.fops = &psb_gem_fops,
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 956926341316..c71a5a4e912c 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -735,12 +735,10 @@ extern const struct drm_connector_helper_funcs
extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
/* gem.c */
-extern void psb_gem_free_object(struct drm_gem_object *obj);
extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
struct drm_file *file);
extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
struct drm_mode_create_dumb *args);
-extern vm_fault_t psb_gem_fault(struct vm_fault *vmf);
/* psb_device.c */
extern const struct psb_ops psb_chip_ops;
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 05/20] drm/gma500: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in gma500.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/gma500/framebuffer.c | 2 ++
drivers/gpu/drm/gma500/gem.c | 18 ++++++++++++++++--
drivers/gpu/drm/gma500/gem.h | 3 +++
drivers/gpu/drm/gma500/psb_drv.c | 9 ---------
drivers/gpu/drm/gma500/psb_drv.h | 2 --
5 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index da02d7e8a8f5..12c19f5fbb5d 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -24,6 +24,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include "framebuffer.h"
+#include "gem.h"
#include "gtt.h"
#include "psb_drv.h"
#include "psb_intel_drv.h"
@@ -285,6 +286,7 @@ static struct gtt_range *psbfb_alloc(struct drm_device *dev, int aligned_size)
/* Begin by trying to use stolen memory backing */
backing = psb_gtt_alloc_range(dev, aligned_size, "fb", 1, PAGE_SIZE);
if (backing) {
+ backing->gem.funcs = &psb_gem_object_funcs;
drm_gem_private_object_init(dev, &backing->gem, aligned_size);
return backing;
}
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index f9c4b1d76f56..8f07de83b6fb 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -18,7 +18,9 @@
#include "psb_drv.h"
-void psb_gem_free_object(struct drm_gem_object *obj)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf);
+
+static void psb_gem_free_object(struct drm_gem_object *obj)
{
struct gtt_range *gtt = container_of(obj, struct gtt_range, gem);
@@ -36,6 +38,17 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data,
return -EINVAL;
}
+static const struct vm_operations_struct psb_gem_vm_ops = {
+ .fault = psb_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+const struct drm_gem_object_funcs psb_gem_object_funcs = {
+ .free = psb_gem_free_object,
+ .vm_ops = &psb_gem_vm_ops,
+};
+
/**
* psb_gem_create - create a mappable object
* @file: the DRM file of the client
@@ -63,6 +76,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size,
dev_err(dev->dev, "no memory for %lld byte GEM object\n", size);
return -ENOSPC;
}
+ r->gem.funcs = &psb_gem_object_funcs;
/* Initialize the extra goodies GEM needs to do all the hard work */
if (drm_gem_object_init(dev, &r->gem, size) != 0) {
psb_gtt_free_range(dev, r);
@@ -123,7 +137,7 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t psb_gem_fault(struct vm_fault *vmf)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj;
diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h
index 4a74dc623b6b..3741a711b9fd 100644
--- a/drivers/gpu/drm/gma500/gem.h
+++ b/drivers/gpu/drm/gma500/gem.h
@@ -8,6 +8,9 @@
#ifndef _GEM_H
#define _GEM_H
+extern const struct drm_gem_object_funcs psb_gem_object_funcs;
+
extern int psb_gem_create(struct drm_file *file, struct drm_device *dev,
u64 size, u32 *handlep, int stolen, u32 align);
+
#endif
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 34b4aae9a15e..b13376a6fb91 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -480,12 +480,6 @@ static const struct dev_pm_ops psb_pm_ops = {
.runtime_idle = psb_runtime_idle,
};
-static const struct vm_operations_struct psb_gem_vm_ops = {
- .fault = psb_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations psb_gem_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -507,9 +501,6 @@ static struct drm_driver driver = {
.irq_uninstall = psb_irq_uninstall,
.irq_handler = psb_irq_handler,
- .gem_free_object_unlocked = psb_gem_free_object,
- .gem_vm_ops = &psb_gem_vm_ops,
-
.dumb_create = psb_gem_dumb_create,
.ioctls = psb_ioctls,
.fops = &psb_gem_fops,
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 956926341316..c71a5a4e912c 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -735,12 +735,10 @@ extern const struct drm_connector_helper_funcs
extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
/* gem.c */
-extern void psb_gem_free_object(struct drm_gem_object *obj);
extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
struct drm_file *file);
extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
struct drm_mode_create_dumb *args);
-extern vm_fault_t psb_gem_fault(struct vm_fault *vmf);
/* psb_device.c */
extern const struct psb_ops psb_chip_ops;
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 05/20] drm/gma500: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in gma500.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/gma500/framebuffer.c | 2 ++
drivers/gpu/drm/gma500/gem.c | 18 ++++++++++++++++--
drivers/gpu/drm/gma500/gem.h | 3 +++
drivers/gpu/drm/gma500/psb_drv.c | 9 ---------
drivers/gpu/drm/gma500/psb_drv.h | 2 --
5 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index da02d7e8a8f5..12c19f5fbb5d 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -24,6 +24,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include "framebuffer.h"
+#include "gem.h"
#include "gtt.h"
#include "psb_drv.h"
#include "psb_intel_drv.h"
@@ -285,6 +286,7 @@ static struct gtt_range *psbfb_alloc(struct drm_device *dev, int aligned_size)
/* Begin by trying to use stolen memory backing */
backing = psb_gtt_alloc_range(dev, aligned_size, "fb", 1, PAGE_SIZE);
if (backing) {
+ backing->gem.funcs = &psb_gem_object_funcs;
drm_gem_private_object_init(dev, &backing->gem, aligned_size);
return backing;
}
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index f9c4b1d76f56..8f07de83b6fb 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -18,7 +18,9 @@
#include "psb_drv.h"
-void psb_gem_free_object(struct drm_gem_object *obj)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf);
+
+static void psb_gem_free_object(struct drm_gem_object *obj)
{
struct gtt_range *gtt = container_of(obj, struct gtt_range, gem);
@@ -36,6 +38,17 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data,
return -EINVAL;
}
+static const struct vm_operations_struct psb_gem_vm_ops = {
+ .fault = psb_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+const struct drm_gem_object_funcs psb_gem_object_funcs = {
+ .free = psb_gem_free_object,
+ .vm_ops = &psb_gem_vm_ops,
+};
+
/**
* psb_gem_create - create a mappable object
* @file: the DRM file of the client
@@ -63,6 +76,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size,
dev_err(dev->dev, "no memory for %lld byte GEM object\n", size);
return -ENOSPC;
}
+ r->gem.funcs = &psb_gem_object_funcs;
/* Initialize the extra goodies GEM needs to do all the hard work */
if (drm_gem_object_init(dev, &r->gem, size) != 0) {
psb_gtt_free_range(dev, r);
@@ -123,7 +137,7 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t psb_gem_fault(struct vm_fault *vmf)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj;
diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h
index 4a74dc623b6b..3741a711b9fd 100644
--- a/drivers/gpu/drm/gma500/gem.h
+++ b/drivers/gpu/drm/gma500/gem.h
@@ -8,6 +8,9 @@
#ifndef _GEM_H
#define _GEM_H
+extern const struct drm_gem_object_funcs psb_gem_object_funcs;
+
extern int psb_gem_create(struct drm_file *file, struct drm_device *dev,
u64 size, u32 *handlep, int stolen, u32 align);
+
#endif
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 34b4aae9a15e..b13376a6fb91 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -480,12 +480,6 @@ static const struct dev_pm_ops psb_pm_ops = {
.runtime_idle = psb_runtime_idle,
};
-static const struct vm_operations_struct psb_gem_vm_ops = {
- .fault = psb_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations psb_gem_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -507,9 +501,6 @@ static struct drm_driver driver = {
.irq_uninstall = psb_irq_uninstall,
.irq_handler = psb_irq_handler,
- .gem_free_object_unlocked = psb_gem_free_object,
- .gem_vm_ops = &psb_gem_vm_ops,
-
.dumb_create = psb_gem_dumb_create,
.ioctls = psb_ioctls,
.fops = &psb_gem_fops,
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 956926341316..c71a5a4e912c 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -735,12 +735,10 @@ extern const struct drm_connector_helper_funcs
extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
/* gem.c */
-extern void psb_gem_free_object(struct drm_gem_object *obj);
extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
struct drm_file *file);
extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
struct drm_mode_create_dumb *args);
-extern vm_fault_t psb_gem_fault(struct vm_fault *vmf);
/* psb_device.c */
extern const struct psb_ops psb_chip_ops;
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 05/20] drm/gma500: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in gma500.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/gma500/framebuffer.c | 2 ++
drivers/gpu/drm/gma500/gem.c | 18 ++++++++++++++++--
drivers/gpu/drm/gma500/gem.h | 3 +++
drivers/gpu/drm/gma500/psb_drv.c | 9 ---------
drivers/gpu/drm/gma500/psb_drv.h | 2 --
5 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index da02d7e8a8f5..12c19f5fbb5d 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -24,6 +24,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include "framebuffer.h"
+#include "gem.h"
#include "gtt.h"
#include "psb_drv.h"
#include "psb_intel_drv.h"
@@ -285,6 +286,7 @@ static struct gtt_range *psbfb_alloc(struct drm_device *dev, int aligned_size)
/* Begin by trying to use stolen memory backing */
backing = psb_gtt_alloc_range(dev, aligned_size, "fb", 1, PAGE_SIZE);
if (backing) {
+ backing->gem.funcs = &psb_gem_object_funcs;
drm_gem_private_object_init(dev, &backing->gem, aligned_size);
return backing;
}
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index f9c4b1d76f56..8f07de83b6fb 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -18,7 +18,9 @@
#include "psb_drv.h"
-void psb_gem_free_object(struct drm_gem_object *obj)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf);
+
+static void psb_gem_free_object(struct drm_gem_object *obj)
{
struct gtt_range *gtt = container_of(obj, struct gtt_range, gem);
@@ -36,6 +38,17 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data,
return -EINVAL;
}
+static const struct vm_operations_struct psb_gem_vm_ops = {
+ .fault = psb_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+const struct drm_gem_object_funcs psb_gem_object_funcs = {
+ .free = psb_gem_free_object,
+ .vm_ops = &psb_gem_vm_ops,
+};
+
/**
* psb_gem_create - create a mappable object
* @file: the DRM file of the client
@@ -63,6 +76,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size,
dev_err(dev->dev, "no memory for %lld byte GEM object\n", size);
return -ENOSPC;
}
+ r->gem.funcs = &psb_gem_object_funcs;
/* Initialize the extra goodies GEM needs to do all the hard work */
if (drm_gem_object_init(dev, &r->gem, size) != 0) {
psb_gtt_free_range(dev, r);
@@ -123,7 +137,7 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t psb_gem_fault(struct vm_fault *vmf)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj;
diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h
index 4a74dc623b6b..3741a711b9fd 100644
--- a/drivers/gpu/drm/gma500/gem.h
+++ b/drivers/gpu/drm/gma500/gem.h
@@ -8,6 +8,9 @@
#ifndef _GEM_H
#define _GEM_H
+extern const struct drm_gem_object_funcs psb_gem_object_funcs;
+
extern int psb_gem_create(struct drm_file *file, struct drm_device *dev,
u64 size, u32 *handlep, int stolen, u32 align);
+
#endif
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 34b4aae9a15e..b13376a6fb91 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -480,12 +480,6 @@ static const struct dev_pm_ops psb_pm_ops = {
.runtime_idle = psb_runtime_idle,
};
-static const struct vm_operations_struct psb_gem_vm_ops = {
- .fault = psb_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations psb_gem_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -507,9 +501,6 @@ static struct drm_driver driver = {
.irq_uninstall = psb_irq_uninstall,
.irq_handler = psb_irq_handler,
- .gem_free_object_unlocked = psb_gem_free_object,
- .gem_vm_ops = &psb_gem_vm_ops,
-
.dumb_create = psb_gem_dumb_create,
.ioctls = psb_ioctls,
.fops = &psb_gem_fops,
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 956926341316..c71a5a4e912c 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -735,12 +735,10 @@ extern const struct drm_connector_helper_funcs
extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
/* gem.c */
-extern void psb_gem_free_object(struct drm_gem_object *obj);
extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
struct drm_file *file);
extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
struct drm_mode_create_dumb *args);
-extern vm_fault_t psb_gem_fault(struct vm_fault *vmf);
/* psb_device.c */
extern const struct psb_ops psb_chip_ops;
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 05/20] drm/gma500: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in gma500.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/gma500/framebuffer.c | 2 ++
drivers/gpu/drm/gma500/gem.c | 18 ++++++++++++++++--
drivers/gpu/drm/gma500/gem.h | 3 +++
drivers/gpu/drm/gma500/psb_drv.c | 9 ---------
drivers/gpu/drm/gma500/psb_drv.h | 2 --
5 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index da02d7e8a8f5..12c19f5fbb5d 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -24,6 +24,7 @@
#include <drm/drm_gem_framebuffer_helper.h>
#include "framebuffer.h"
+#include "gem.h"
#include "gtt.h"
#include "psb_drv.h"
#include "psb_intel_drv.h"
@@ -285,6 +286,7 @@ static struct gtt_range *psbfb_alloc(struct drm_device *dev, int aligned_size)
/* Begin by trying to use stolen memory backing */
backing = psb_gtt_alloc_range(dev, aligned_size, "fb", 1, PAGE_SIZE);
if (backing) {
+ backing->gem.funcs = &psb_gem_object_funcs;
drm_gem_private_object_init(dev, &backing->gem, aligned_size);
return backing;
}
diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index f9c4b1d76f56..8f07de83b6fb 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -18,7 +18,9 @@
#include "psb_drv.h"
-void psb_gem_free_object(struct drm_gem_object *obj)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf);
+
+static void psb_gem_free_object(struct drm_gem_object *obj)
{
struct gtt_range *gtt = container_of(obj, struct gtt_range, gem);
@@ -36,6 +38,17 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data,
return -EINVAL;
}
+static const struct vm_operations_struct psb_gem_vm_ops = {
+ .fault = psb_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+const struct drm_gem_object_funcs psb_gem_object_funcs = {
+ .free = psb_gem_free_object,
+ .vm_ops = &psb_gem_vm_ops,
+};
+
/**
* psb_gem_create - create a mappable object
* @file: the DRM file of the client
@@ -63,6 +76,7 @@ int psb_gem_create(struct drm_file *file, struct drm_device *dev, u64 size,
dev_err(dev->dev, "no memory for %lld byte GEM object\n", size);
return -ENOSPC;
}
+ r->gem.funcs = &psb_gem_object_funcs;
/* Initialize the extra goodies GEM needs to do all the hard work */
if (drm_gem_object_init(dev, &r->gem, size) != 0) {
psb_gtt_free_range(dev, r);
@@ -123,7 +137,7 @@ int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t psb_gem_fault(struct vm_fault *vmf)
+static vm_fault_t psb_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj;
diff --git a/drivers/gpu/drm/gma500/gem.h b/drivers/gpu/drm/gma500/gem.h
index 4a74dc623b6b..3741a711b9fd 100644
--- a/drivers/gpu/drm/gma500/gem.h
+++ b/drivers/gpu/drm/gma500/gem.h
@@ -8,6 +8,9 @@
#ifndef _GEM_H
#define _GEM_H
+extern const struct drm_gem_object_funcs psb_gem_object_funcs;
+
extern int psb_gem_create(struct drm_file *file, struct drm_device *dev,
u64 size, u32 *handlep, int stolen, u32 align);
+
#endif
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 34b4aae9a15e..b13376a6fb91 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -480,12 +480,6 @@ static const struct dev_pm_ops psb_pm_ops = {
.runtime_idle = psb_runtime_idle,
};
-static const struct vm_operations_struct psb_gem_vm_ops = {
- .fault = psb_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations psb_gem_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -507,9 +501,6 @@ static struct drm_driver driver = {
.irq_uninstall = psb_irq_uninstall,
.irq_handler = psb_irq_handler,
- .gem_free_object_unlocked = psb_gem_free_object,
- .gem_vm_ops = &psb_gem_vm_ops,
-
.dumb_create = psb_gem_dumb_create,
.ioctls = psb_ioctls,
.fops = &psb_gem_fops,
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 956926341316..c71a5a4e912c 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -735,12 +735,10 @@ extern const struct drm_connector_helper_funcs
extern const struct drm_connector_funcs psb_intel_lvds_connector_funcs;
/* gem.c */
-extern void psb_gem_free_object(struct drm_gem_object *obj);
extern int psb_gem_get_aperture(struct drm_device *dev, void *data,
struct drm_file *file);
extern int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
struct drm_mode_create_dumb *args);
-extern vm_fault_t psb_gem_fault(struct vm_fault *vmf);
/* psb_device.c */
extern const struct psb_ops psb_chip_ops;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 06/20] drm/i915: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in i915.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index c8421fd9d2dc..bc15ee4f2bd5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -41,7 +41,14 @@ static struct i915_global_object {
struct drm_i915_gem_object *i915_gem_object_alloc(void)
{
- return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ struct drm_i915_gem_object *obj;
+
+ obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ if (!obj)
+ return NULL;
+ obj->base.funcs = &i915_gem_object_funcs;
+
+ return obj;
}
void i915_gem_object_free(struct drm_i915_gem_object *obj)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 068447f565a9..b09eee11c540 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
};
+const struct drm_gem_object_funcs i915_gem_object_funcs = {
+ .free = i915_gem_free_object,
+ .close = i915_gem_close_object,
+ .export = i915_gem_prime_export,
+};
+
static struct drm_driver driver = {
/* Don't use MTRRs here; the Xserver or userspace app should
* deal with them for Intel hardware.
@@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
.lastclose = i915_driver_lastclose,
.postclose = i915_driver_postclose,
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = i915_gem_prime_export,
.gem_prime_import = i915_gem_prime_import,
.dumb_create = i915_gem_dumb_create,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bacb4c762f5b..666db65fe69e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
/* i915_drv.c */
extern const struct dev_pm_ops i915_pm_ops;
+extern const struct drm_gem_object_funcs i915_gem_object_funcs;
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
void i915_driver_remove(struct drm_i915_private *i915);
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index ce4d4303229c..4725dad63e0a 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
.name = "mock",
.driver_features = DRIVER_GEM,
.release = mock_device_release,
-
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
};
static void release_dev(struct device *dev)
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in i915.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index c8421fd9d2dc..bc15ee4f2bd5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -41,7 +41,14 @@ static struct i915_global_object {
struct drm_i915_gem_object *i915_gem_object_alloc(void)
{
- return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ struct drm_i915_gem_object *obj;
+
+ obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ if (!obj)
+ return NULL;
+ obj->base.funcs = &i915_gem_object_funcs;
+
+ return obj;
}
void i915_gem_object_free(struct drm_i915_gem_object *obj)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 068447f565a9..b09eee11c540 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
};
+const struct drm_gem_object_funcs i915_gem_object_funcs = {
+ .free = i915_gem_free_object,
+ .close = i915_gem_close_object,
+ .export = i915_gem_prime_export,
+};
+
static struct drm_driver driver = {
/* Don't use MTRRs here; the Xserver or userspace app should
* deal with them for Intel hardware.
@@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
.lastclose = i915_driver_lastclose,
.postclose = i915_driver_postclose,
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = i915_gem_prime_export,
.gem_prime_import = i915_gem_prime_import,
.dumb_create = i915_gem_dumb_create,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bacb4c762f5b..666db65fe69e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
/* i915_drv.c */
extern const struct dev_pm_ops i915_pm_ops;
+extern const struct drm_gem_object_funcs i915_gem_object_funcs;
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
void i915_driver_remove(struct drm_i915_private *i915);
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index ce4d4303229c..4725dad63e0a 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
.name = "mock",
.driver_features = DRIVER_GEM,
.release = mock_device_release,
-
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
};
static void release_dev(struct device *dev)
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in i915.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index c8421fd9d2dc..bc15ee4f2bd5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -41,7 +41,14 @@ static struct i915_global_object {
struct drm_i915_gem_object *i915_gem_object_alloc(void)
{
- return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ struct drm_i915_gem_object *obj;
+
+ obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ if (!obj)
+ return NULL;
+ obj->base.funcs = &i915_gem_object_funcs;
+
+ return obj;
}
void i915_gem_object_free(struct drm_i915_gem_object *obj)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 068447f565a9..b09eee11c540 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
};
+const struct drm_gem_object_funcs i915_gem_object_funcs = {
+ .free = i915_gem_free_object,
+ .close = i915_gem_close_object,
+ .export = i915_gem_prime_export,
+};
+
static struct drm_driver driver = {
/* Don't use MTRRs here; the Xserver or userspace app should
* deal with them for Intel hardware.
@@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
.lastclose = i915_driver_lastclose,
.postclose = i915_driver_postclose,
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = i915_gem_prime_export,
.gem_prime_import = i915_gem_prime_import,
.dumb_create = i915_gem_dumb_create,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bacb4c762f5b..666db65fe69e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
/* i915_drv.c */
extern const struct dev_pm_ops i915_pm_ops;
+extern const struct drm_gem_object_funcs i915_gem_object_funcs;
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
void i915_driver_remove(struct drm_i915_private *i915);
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index ce4d4303229c..4725dad63e0a 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
.name = "mock",
.driver_features = DRIVER_GEM,
.release = mock_device_release,
-
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
};
static void release_dev(struct device *dev)
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in i915.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index c8421fd9d2dc..bc15ee4f2bd5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -41,7 +41,14 @@ static struct i915_global_object {
struct drm_i915_gem_object *i915_gem_object_alloc(void)
{
- return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ struct drm_i915_gem_object *obj;
+
+ obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ if (!obj)
+ return NULL;
+ obj->base.funcs = &i915_gem_object_funcs;
+
+ return obj;
}
void i915_gem_object_free(struct drm_i915_gem_object *obj)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 068447f565a9..b09eee11c540 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
};
+const struct drm_gem_object_funcs i915_gem_object_funcs = {
+ .free = i915_gem_free_object,
+ .close = i915_gem_close_object,
+ .export = i915_gem_prime_export,
+};
+
static struct drm_driver driver = {
/* Don't use MTRRs here; the Xserver or userspace app should
* deal with them for Intel hardware.
@@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
.lastclose = i915_driver_lastclose,
.postclose = i915_driver_postclose,
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = i915_gem_prime_export,
.gem_prime_import = i915_gem_prime_import,
.dumb_create = i915_gem_dumb_create,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bacb4c762f5b..666db65fe69e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
/* i915_drv.c */
extern const struct dev_pm_ops i915_pm_ops;
+extern const struct drm_gem_object_funcs i915_gem_object_funcs;
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
void i915_driver_remove(struct drm_i915_private *i915);
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index ce4d4303229c..4725dad63e0a 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
.name = "mock",
.driver_features = DRIVER_GEM,
.release = mock_device_release,
-
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
};
static void release_dev(struct device *dev)
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in i915.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index c8421fd9d2dc..bc15ee4f2bd5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -41,7 +41,14 @@ static struct i915_global_object {
struct drm_i915_gem_object *i915_gem_object_alloc(void)
{
- return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ struct drm_i915_gem_object *obj;
+
+ obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ if (!obj)
+ return NULL;
+ obj->base.funcs = &i915_gem_object_funcs;
+
+ return obj;
}
void i915_gem_object_free(struct drm_i915_gem_object *obj)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 068447f565a9..b09eee11c540 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
};
+const struct drm_gem_object_funcs i915_gem_object_funcs = {
+ .free = i915_gem_free_object,
+ .close = i915_gem_close_object,
+ .export = i915_gem_prime_export,
+};
+
static struct drm_driver driver = {
/* Don't use MTRRs here; the Xserver or userspace app should
* deal with them for Intel hardware.
@@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
.lastclose = i915_driver_lastclose,
.postclose = i915_driver_postclose,
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = i915_gem_prime_export,
.gem_prime_import = i915_gem_prime_import,
.dumb_create = i915_gem_dumb_create,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bacb4c762f5b..666db65fe69e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
/* i915_drv.c */
extern const struct dev_pm_ops i915_pm_ops;
+extern const struct drm_gem_object_funcs i915_gem_object_funcs;
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
void i915_driver_remove(struct drm_i915_private *i915);
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index ce4d4303229c..4725dad63e0a 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
.name = "mock",
.driver_features = DRIVER_GEM,
.release = mock_device_release,
-
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
};
static void release_dev(struct device *dev)
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in i915.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
4 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
index c8421fd9d2dc..bc15ee4f2bd5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
@@ -41,7 +41,14 @@ static struct i915_global_object {
struct drm_i915_gem_object *i915_gem_object_alloc(void)
{
- return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ struct drm_i915_gem_object *obj;
+
+ obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
+ if (!obj)
+ return NULL;
+ obj->base.funcs = &i915_gem_object_funcs;
+
+ return obj;
}
void i915_gem_object_free(struct drm_i915_gem_object *obj)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 068447f565a9..b09eee11c540 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
};
+const struct drm_gem_object_funcs i915_gem_object_funcs = {
+ .free = i915_gem_free_object,
+ .close = i915_gem_close_object,
+ .export = i915_gem_prime_export,
+};
+
static struct drm_driver driver = {
/* Don't use MTRRs here; the Xserver or userspace app should
* deal with them for Intel hardware.
@@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
.lastclose = i915_driver_lastclose,
.postclose = i915_driver_postclose,
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = i915_gem_prime_export,
.gem_prime_import = i915_gem_prime_import,
.dumb_create = i915_gem_dumb_create,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bacb4c762f5b..666db65fe69e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
/* i915_drv.c */
extern const struct dev_pm_ops i915_pm_ops;
+extern const struct drm_gem_object_funcs i915_gem_object_funcs;
int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
void i915_driver_remove(struct drm_i915_private *i915);
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index ce4d4303229c..4725dad63e0a 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
.name = "mock",
.driver_features = DRIVER_GEM,
.release = mock_device_release,
-
- .gem_close_object = i915_gem_close_object,
- .gem_free_object_unlocked = i915_gem_free_object,
};
static void release_dev(struct device *dev)
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:08 ` Jani Nikula
0 siblings, 0 replies; 243+ messages in thread
From: Jani Nikula @ 2020-08-13 9:08 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in i915.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
> 4 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index c8421fd9d2dc..bc15ee4f2bd5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -41,7 +41,14 @@ static struct i915_global_object {
>
> struct drm_i915_gem_object *i915_gem_object_alloc(void)
> {
> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + struct drm_i915_gem_object *obj;
> +
> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + if (!obj)
> + return NULL;
> + obj->base.funcs = &i915_gem_object_funcs;
> +
> + return obj;
> }
>
> void i915_gem_object_free(struct drm_i915_gem_object *obj)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 068447f565a9..b09eee11c540 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
> };
>
> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
> + .free = i915_gem_free_object,
> + .close = i915_gem_close_object,
> + .export = i915_gem_prime_export,
> +};
> +
Any reason not to make this static in i915_gem_object.c next to its only
user?
BR,
Jani.
> static struct drm_driver driver = {
> /* Don't use MTRRs here; the Xserver or userspace app should
> * deal with them for Intel hardware.
> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
> .lastclose = i915_driver_lastclose,
> .postclose = i915_driver_postclose,
>
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> -
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = i915_gem_prime_export,
> .gem_prime_import = i915_gem_prime_import,
>
> .dumb_create = i915_gem_dumb_create,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bacb4c762f5b..666db65fe69e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>
> /* i915_drv.c */
> extern const struct dev_pm_ops i915_pm_ops;
> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void i915_driver_remove(struct drm_i915_private *i915);
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index ce4d4303229c..4725dad63e0a 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
> .name = "mock",
> .driver_features = DRIVER_GEM,
> .release = mock_device_release,
> -
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> };
>
> static void release_dev(struct device *dev)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:08 ` Jani Nikula
0 siblings, 0 replies; 243+ messages in thread
From: Jani Nikula @ 2020-08-13 9:08 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in i915.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
> 4 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index c8421fd9d2dc..bc15ee4f2bd5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -41,7 +41,14 @@ static struct i915_global_object {
>
> struct drm_i915_gem_object *i915_gem_object_alloc(void)
> {
> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + struct drm_i915_gem_object *obj;
> +
> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + if (!obj)
> + return NULL;
> + obj->base.funcs = &i915_gem_object_funcs;
> +
> + return obj;
> }
>
> void i915_gem_object_free(struct drm_i915_gem_object *obj)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 068447f565a9..b09eee11c540 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
> };
>
> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
> + .free = i915_gem_free_object,
> + .close = i915_gem_close_object,
> + .export = i915_gem_prime_export,
> +};
> +
Any reason not to make this static in i915_gem_object.c next to its only
user?
BR,
Jani.
> static struct drm_driver driver = {
> /* Don't use MTRRs here; the Xserver or userspace app should
> * deal with them for Intel hardware.
> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
> .lastclose = i915_driver_lastclose,
> .postclose = i915_driver_postclose,
>
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> -
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = i915_gem_prime_export,
> .gem_prime_import = i915_gem_prime_import,
>
> .dumb_create = i915_gem_dumb_create,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bacb4c762f5b..666db65fe69e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>
> /* i915_drv.c */
> extern const struct dev_pm_ops i915_pm_ops;
> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void i915_driver_remove(struct drm_i915_private *i915);
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index ce4d4303229c..4725dad63e0a 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
> .name = "mock",
> .driver_features = DRIVER_GEM,
> .release = mock_device_release,
> -
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> };
>
> static void release_dev(struct device *dev)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:08 ` Jani Nikula
0 siblings, 0 replies; 243+ messages in thread
From: Jani Nikula @ 2020-08-13 9:08 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in i915.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
> 4 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index c8421fd9d2dc..bc15ee4f2bd5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -41,7 +41,14 @@ static struct i915_global_object {
>
> struct drm_i915_gem_object *i915_gem_object_alloc(void)
> {
> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + struct drm_i915_gem_object *obj;
> +
> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + if (!obj)
> + return NULL;
> + obj->base.funcs = &i915_gem_object_funcs;
> +
> + return obj;
> }
>
> void i915_gem_object_free(struct drm_i915_gem_object *obj)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 068447f565a9..b09eee11c540 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
> };
>
> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
> + .free = i915_gem_free_object,
> + .close = i915_gem_close_object,
> + .export = i915_gem_prime_export,
> +};
> +
Any reason not to make this static in i915_gem_object.c next to its only
user?
BR,
Jani.
> static struct drm_driver driver = {
> /* Don't use MTRRs here; the Xserver or userspace app should
> * deal with them for Intel hardware.
> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
> .lastclose = i915_driver_lastclose,
> .postclose = i915_driver_postclose,
>
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> -
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = i915_gem_prime_export,
> .gem_prime_import = i915_gem_prime_import,
>
> .dumb_create = i915_gem_dumb_create,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bacb4c762f5b..666db65fe69e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>
> /* i915_drv.c */
> extern const struct dev_pm_ops i915_pm_ops;
> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void i915_driver_remove(struct drm_i915_private *i915);
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index ce4d4303229c..4725dad63e0a 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
> .name = "mock",
> .driver_features = DRIVER_GEM,
> .release = mock_device_release,
> -
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> };
>
> static void release_dev(struct device *dev)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:08 ` Jani Nikula
0 siblings, 0 replies; 243+ messages in thread
From: Jani Nikula @ 2020-08-13 9:08 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in i915.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
> 4 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index c8421fd9d2dc..bc15ee4f2bd5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -41,7 +41,14 @@ static struct i915_global_object {
>
> struct drm_i915_gem_object *i915_gem_object_alloc(void)
> {
> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + struct drm_i915_gem_object *obj;
> +
> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + if (!obj)
> + return NULL;
> + obj->base.funcs = &i915_gem_object_funcs;
> +
> + return obj;
> }
>
> void i915_gem_object_free(struct drm_i915_gem_object *obj)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 068447f565a9..b09eee11c540 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
> };
>
> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
> + .free = i915_gem_free_object,
> + .close = i915_gem_close_object,
> + .export = i915_gem_prime_export,
> +};
> +
Any reason not to make this static in i915_gem_object.c next to its only
user?
BR,
Jani.
> static struct drm_driver driver = {
> /* Don't use MTRRs here; the Xserver or userspace app should
> * deal with them for Intel hardware.
> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
> .lastclose = i915_driver_lastclose,
> .postclose = i915_driver_postclose,
>
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> -
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = i915_gem_prime_export,
> .gem_prime_import = i915_gem_prime_import,
>
> .dumb_create = i915_gem_dumb_create,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bacb4c762f5b..666db65fe69e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>
> /* i915_drv.c */
> extern const struct dev_pm_ops i915_pm_ops;
> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void i915_driver_remove(struct drm_i915_private *i915);
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index ce4d4303229c..4725dad63e0a 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
> .name = "mock",
> .driver_features = DRIVER_GEM,
> .release = mock_device_release,
> -
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> };
>
> static void release_dev(struct device *dev)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:08 ` Jani Nikula
0 siblings, 0 replies; 243+ messages in thread
From: Jani Nikula @ 2020-08-13 9:08 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in i915.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
> 4 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index c8421fd9d2dc..bc15ee4f2bd5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -41,7 +41,14 @@ static struct i915_global_object {
>
> struct drm_i915_gem_object *i915_gem_object_alloc(void)
> {
> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + struct drm_i915_gem_object *obj;
> +
> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + if (!obj)
> + return NULL;
> + obj->base.funcs = &i915_gem_object_funcs;
> +
> + return obj;
> }
>
> void i915_gem_object_free(struct drm_i915_gem_object *obj)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 068447f565a9..b09eee11c540 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
> };
>
> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
> + .free = i915_gem_free_object,
> + .close = i915_gem_close_object,
> + .export = i915_gem_prime_export,
> +};
> +
Any reason not to make this static in i915_gem_object.c next to its only
user?
BR,
Jani.
> static struct drm_driver driver = {
> /* Don't use MTRRs here; the Xserver or userspace app should
> * deal with them for Intel hardware.
> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
> .lastclose = i915_driver_lastclose,
> .postclose = i915_driver_postclose,
>
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> -
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = i915_gem_prime_export,
> .gem_prime_import = i915_gem_prime_import,
>
> .dumb_create = i915_gem_dumb_create,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bacb4c762f5b..666db65fe69e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>
> /* i915_drv.c */
> extern const struct dev_pm_ops i915_pm_ops;
> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void i915_driver_remove(struct drm_i915_private *i915);
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index ce4d4303229c..4725dad63e0a 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
> .name = "mock",
> .driver_features = DRIVER_GEM,
> .release = mock_device_release,
> -
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> };
>
> static void release_dev(struct device *dev)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:08 ` Jani Nikula
0 siblings, 0 replies; 243+ messages in thread
From: Jani Nikula @ 2020-08-13 9:08 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org> wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in i915.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
> 4 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> index c8421fd9d2dc..bc15ee4f2bd5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
> @@ -41,7 +41,14 @@ static struct i915_global_object {
>
> struct drm_i915_gem_object *i915_gem_object_alloc(void)
> {
> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + struct drm_i915_gem_object *obj;
> +
> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
> + if (!obj)
> + return NULL;
> + obj->base.funcs = &i915_gem_object_funcs;
> +
> + return obj;
> }
>
> void i915_gem_object_free(struct drm_i915_gem_object *obj)
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 068447f565a9..b09eee11c540 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
> };
>
> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
> + .free = i915_gem_free_object,
> + .close = i915_gem_close_object,
> + .export = i915_gem_prime_export,
> +};
> +
Any reason not to make this static in i915_gem_object.c next to its only
user?
BR,
Jani.
> static struct drm_driver driver = {
> /* Don't use MTRRs here; the Xserver or userspace app should
> * deal with them for Intel hardware.
> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
> .lastclose = i915_driver_lastclose,
> .postclose = i915_driver_postclose,
>
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> -
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = i915_gem_prime_export,
> .gem_prime_import = i915_gem_prime_import,
>
> .dumb_create = i915_gem_dumb_create,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bacb4c762f5b..666db65fe69e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>
> /* i915_drv.c */
> extern const struct dev_pm_ops i915_pm_ops;
> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>
> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void i915_driver_remove(struct drm_i915_private *i915);
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index ce4d4303229c..4725dad63e0a 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
> .name = "mock",
> .driver_features = DRIVER_GEM,
> .release = mock_device_release,
> -
> - .gem_close_object = i915_gem_close_object,
> - .gem_free_object_unlocked = i915_gem_free_object,
> };
>
> static void release_dev(struct device *dev)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:13 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 9:13 UTC (permalink / raw)
To: Jani Nikula, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 4339 bytes --]
Hi
Am 13.08.20 um 11:08 schrieb Jani Nikula:
> On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in i915.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
>> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
>> 4 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> index c8421fd9d2dc..bc15ee4f2bd5 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> @@ -41,7 +41,14 @@ static struct i915_global_object {
>>
>> struct drm_i915_gem_object *i915_gem_object_alloc(void)
>> {
>> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + struct drm_i915_gem_object *obj;
>> +
>> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + if (!obj)
>> + return NULL;
>> + obj->base.funcs = &i915_gem_object_funcs;
>> +
>> + return obj;
>> }
>>
>> void i915_gem_object_free(struct drm_i915_gem_object *obj)
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 068447f565a9..b09eee11c540 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
>> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
>> };
>>
>> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
>> + .free = i915_gem_free_object,
>> + .close = i915_gem_close_object,
>> + .export = i915_gem_prime_export,
>> +};
>> +
>
> Any reason not to make this static in i915_gem_object.c next to its only
> user?
That is just an oversight. Will be fixed in the next iteration. Thanks.
Best regards
Thomas
>
> BR,
> Jani.
>
>
>> static struct drm_driver driver = {
>> /* Don't use MTRRs here; the Xserver or userspace app should
>> * deal with them for Intel hardware.
>> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
>> .lastclose = i915_driver_lastclose,
>> .postclose = i915_driver_postclose,
>>
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> -
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = i915_gem_prime_export,
>> .gem_prime_import = i915_gem_prime_import,
>>
>> .dumb_create = i915_gem_dumb_create,
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index bacb4c762f5b..666db65fe69e 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>>
>> /* i915_drv.c */
>> extern const struct dev_pm_ops i915_pm_ops;
>> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>>
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
>> void i915_driver_remove(struct drm_i915_private *i915);
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index ce4d4303229c..4725dad63e0a 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
>> .name = "mock",
>> .driver_features = DRIVER_GEM,
>> .release = mock_device_release,
>> -
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> };
>>
>> static void release_dev(struct device *dev)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:13 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 9:13 UTC (permalink / raw)
To: Jani Nikula, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4339 bytes --]
Hi
Am 13.08.20 um 11:08 schrieb Jani Nikula:
> On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in i915.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
>> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
>> 4 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> index c8421fd9d2dc..bc15ee4f2bd5 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> @@ -41,7 +41,14 @@ static struct i915_global_object {
>>
>> struct drm_i915_gem_object *i915_gem_object_alloc(void)
>> {
>> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + struct drm_i915_gem_object *obj;
>> +
>> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + if (!obj)
>> + return NULL;
>> + obj->base.funcs = &i915_gem_object_funcs;
>> +
>> + return obj;
>> }
>>
>> void i915_gem_object_free(struct drm_i915_gem_object *obj)
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 068447f565a9..b09eee11c540 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
>> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
>> };
>>
>> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
>> + .free = i915_gem_free_object,
>> + .close = i915_gem_close_object,
>> + .export = i915_gem_prime_export,
>> +};
>> +
>
> Any reason not to make this static in i915_gem_object.c next to its only
> user?
That is just an oversight. Will be fixed in the next iteration. Thanks.
Best regards
Thomas
>
> BR,
> Jani.
>
>
>> static struct drm_driver driver = {
>> /* Don't use MTRRs here; the Xserver or userspace app should
>> * deal with them for Intel hardware.
>> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
>> .lastclose = i915_driver_lastclose,
>> .postclose = i915_driver_postclose,
>>
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> -
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = i915_gem_prime_export,
>> .gem_prime_import = i915_gem_prime_import,
>>
>> .dumb_create = i915_gem_dumb_create,
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index bacb4c762f5b..666db65fe69e 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>>
>> /* i915_drv.c */
>> extern const struct dev_pm_ops i915_pm_ops;
>> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>>
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
>> void i915_driver_remove(struct drm_i915_private *i915);
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index ce4d4303229c..4725dad63e0a 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
>> .name = "mock",
>> .driver_features = DRIVER_GEM,
>> .release = mock_device_release,
>> -
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> };
>>
>> static void release_dev(struct device *dev)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:13 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 9:13 UTC (permalink / raw)
To: Jani Nikula, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4339 bytes --]
Hi
Am 13.08.20 um 11:08 schrieb Jani Nikula:
> On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in i915.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
>> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
>> 4 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> index c8421fd9d2dc..bc15ee4f2bd5 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> @@ -41,7 +41,14 @@ static struct i915_global_object {
>>
>> struct drm_i915_gem_object *i915_gem_object_alloc(void)
>> {
>> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + struct drm_i915_gem_object *obj;
>> +
>> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + if (!obj)
>> + return NULL;
>> + obj->base.funcs = &i915_gem_object_funcs;
>> +
>> + return obj;
>> }
>>
>> void i915_gem_object_free(struct drm_i915_gem_object *obj)
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 068447f565a9..b09eee11c540 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
>> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
>> };
>>
>> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
>> + .free = i915_gem_free_object,
>> + .close = i915_gem_close_object,
>> + .export = i915_gem_prime_export,
>> +};
>> +
>
> Any reason not to make this static in i915_gem_object.c next to its only
> user?
That is just an oversight. Will be fixed in the next iteration. Thanks.
Best regards
Thomas
>
> BR,
> Jani.
>
>
>> static struct drm_driver driver = {
>> /* Don't use MTRRs here; the Xserver or userspace app should
>> * deal with them for Intel hardware.
>> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
>> .lastclose = i915_driver_lastclose,
>> .postclose = i915_driver_postclose,
>>
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> -
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = i915_gem_prime_export,
>> .gem_prime_import = i915_gem_prime_import,
>>
>> .dumb_create = i915_gem_dumb_create,
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index bacb4c762f5b..666db65fe69e 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>>
>> /* i915_drv.c */
>> extern const struct dev_pm_ops i915_pm_ops;
>> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>>
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
>> void i915_driver_remove(struct drm_i915_private *i915);
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index ce4d4303229c..4725dad63e0a 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
>> .name = "mock",
>> .driver_features = DRIVER_GEM,
>> .release = mock_device_release,
>> -
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> };
>>
>> static void release_dev(struct device *dev)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:13 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 9:13 UTC (permalink / raw)
To: Jani Nikula, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4339 bytes --]
Hi
Am 13.08.20 um 11:08 schrieb Jani Nikula:
> On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in i915.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
>> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
>> 4 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> index c8421fd9d2dc..bc15ee4f2bd5 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> @@ -41,7 +41,14 @@ static struct i915_global_object {
>>
>> struct drm_i915_gem_object *i915_gem_object_alloc(void)
>> {
>> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + struct drm_i915_gem_object *obj;
>> +
>> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + if (!obj)
>> + return NULL;
>> + obj->base.funcs = &i915_gem_object_funcs;
>> +
>> + return obj;
>> }
>>
>> void i915_gem_object_free(struct drm_i915_gem_object *obj)
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 068447f565a9..b09eee11c540 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
>> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
>> };
>>
>> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
>> + .free = i915_gem_free_object,
>> + .close = i915_gem_close_object,
>> + .export = i915_gem_prime_export,
>> +};
>> +
>
> Any reason not to make this static in i915_gem_object.c next to its only
> user?
That is just an oversight. Will be fixed in the next iteration. Thanks.
Best regards
Thomas
>
> BR,
> Jani.
>
>
>> static struct drm_driver driver = {
>> /* Don't use MTRRs here; the Xserver or userspace app should
>> * deal with them for Intel hardware.
>> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
>> .lastclose = i915_driver_lastclose,
>> .postclose = i915_driver_postclose,
>>
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> -
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = i915_gem_prime_export,
>> .gem_prime_import = i915_gem_prime_import,
>>
>> .dumb_create = i915_gem_dumb_create,
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index bacb4c762f5b..666db65fe69e 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>>
>> /* i915_drv.c */
>> extern const struct dev_pm_ops i915_pm_ops;
>> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>>
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
>> void i915_driver_remove(struct drm_i915_private *i915);
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index ce4d4303229c..4725dad63e0a 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
>> .name = "mock",
>> .driver_features = DRIVER_GEM,
>> .release = mock_device_release,
>> -
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> };
>>
>> static void release_dev(struct device *dev)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:13 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 9:13 UTC (permalink / raw)
To: Jani Nikula, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4339 bytes --]
Hi
Am 13.08.20 um 11:08 schrieb Jani Nikula:
> On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in i915.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
>> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
>> 4 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> index c8421fd9d2dc..bc15ee4f2bd5 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> @@ -41,7 +41,14 @@ static struct i915_global_object {
>>
>> struct drm_i915_gem_object *i915_gem_object_alloc(void)
>> {
>> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + struct drm_i915_gem_object *obj;
>> +
>> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + if (!obj)
>> + return NULL;
>> + obj->base.funcs = &i915_gem_object_funcs;
>> +
>> + return obj;
>> }
>>
>> void i915_gem_object_free(struct drm_i915_gem_object *obj)
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 068447f565a9..b09eee11c540 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
>> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
>> };
>>
>> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
>> + .free = i915_gem_free_object,
>> + .close = i915_gem_close_object,
>> + .export = i915_gem_prime_export,
>> +};
>> +
>
> Any reason not to make this static in i915_gem_object.c next to its only
> user?
That is just an oversight. Will be fixed in the next iteration. Thanks.
Best regards
Thomas
>
> BR,
> Jani.
>
>
>> static struct drm_driver driver = {
>> /* Don't use MTRRs here; the Xserver or userspace app should
>> * deal with them for Intel hardware.
>> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
>> .lastclose = i915_driver_lastclose,
>> .postclose = i915_driver_postclose,
>>
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> -
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = i915_gem_prime_export,
>> .gem_prime_import = i915_gem_prime_import,
>>
>> .dumb_create = i915_gem_dumb_create,
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index bacb4c762f5b..666db65fe69e 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>>
>> /* i915_drv.c */
>> extern const struct dev_pm_ops i915_pm_ops;
>> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>>
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
>> void i915_driver_remove(struct drm_i915_private *i915);
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index ce4d4303229c..4725dad63e0a 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
>> .name = "mock",
>> .driver_features = DRIVER_GEM,
>> .release = mock_device_release,
>> -
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> };
>>
>> static void release_dev(struct device *dev)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:13 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 9:13 UTC (permalink / raw)
To: Jani Nikula, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, joonas.lahtinen,
rodrigo.vivi, chunkuang.hu, p.zabel, matthias.bgg, robdclark,
sean, bskeggs, tomi.valkeinen, eric, hjc, heiko, thierry.reding,
jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 4339 bytes --]
Hi
Am 13.08.20 um 11:08 schrieb Jani Nikula:
> On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in i915.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
>> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
>> 4 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> index c8421fd9d2dc..bc15ee4f2bd5 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> @@ -41,7 +41,14 @@ static struct i915_global_object {
>>
>> struct drm_i915_gem_object *i915_gem_object_alloc(void)
>> {
>> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + struct drm_i915_gem_object *obj;
>> +
>> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + if (!obj)
>> + return NULL;
>> + obj->base.funcs = &i915_gem_object_funcs;
>> +
>> + return obj;
>> }
>>
>> void i915_gem_object_free(struct drm_i915_gem_object *obj)
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 068447f565a9..b09eee11c540 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
>> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
>> };
>>
>> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
>> + .free = i915_gem_free_object,
>> + .close = i915_gem_close_object,
>> + .export = i915_gem_prime_export,
>> +};
>> +
>
> Any reason not to make this static in i915_gem_object.c next to its only
> user?
That is just an oversight. Will be fixed in the next iteration. Thanks.
Best regards
Thomas
>
> BR,
> Jani.
>
>
>> static struct drm_driver driver = {
>> /* Don't use MTRRs here; the Xserver or userspace app should
>> * deal with them for Intel hardware.
>> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
>> .lastclose = i915_driver_lastclose,
>> .postclose = i915_driver_postclose,
>>
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> -
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = i915_gem_prime_export,
>> .gem_prime_import = i915_gem_prime_import,
>>
>> .dumb_create = i915_gem_dumb_create,
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index bacb4c762f5b..666db65fe69e 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>>
>> /* i915_drv.c */
>> extern const struct dev_pm_ops i915_pm_ops;
>> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>>
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
>> void i915_driver_remove(struct drm_i915_private *i915);
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index ce4d4303229c..4725dad63e0a 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
>> .name = "mock",
>> .driver_features = DRIVER_GEM,
>> .release = mock_device_release,
>> -
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> };
>>
>> static void release_dev(struct device *dev)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 06/20] drm/i915: Introduce GEM object functions
@ 2020-08-13 9:13 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 9:13 UTC (permalink / raw)
To: Jani Nikula, alexander.deucher-5C7GfCeVMHo,
christian.koenig-5C7GfCeVMHo, airlied-cv59FeDIM0c,
daniel-/w4YWyX8dFk, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w,
oleksandr_andrushchenko-uRwfk40T5oI,
hyun.kwon-gjFFaj9aHVfQT0dZR+AlfA,
laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1.1.1: Type: text/plain, Size: 4381 bytes --]
Hi
Am 13.08.20 um 11:08 schrieb Jani Nikula:
> On Thu, 13 Aug 2020, Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org> wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in i915.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++++++++-
>> drivers/gpu/drm/i915/i915_drv.c | 10 ++++++----
>> drivers/gpu/drm/i915/i915_drv.h | 1 +
>> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 3 ---
>> 4 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> index c8421fd9d2dc..bc15ee4f2bd5 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c
>> @@ -41,7 +41,14 @@ static struct i915_global_object {
>>
>> struct drm_i915_gem_object *i915_gem_object_alloc(void)
>> {
>> - return kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + struct drm_i915_gem_object *obj;
>> +
>> + obj = kmem_cache_zalloc(global.slab_objects, GFP_KERNEL);
>> + if (!obj)
>> + return NULL;
>> + obj->base.funcs = &i915_gem_object_funcs;
>> +
>> + return obj;
>> }
>>
>> void i915_gem_object_free(struct drm_i915_gem_object *obj)
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 068447f565a9..b09eee11c540 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1840,6 +1840,12 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
>> DRM_IOCTL_DEF_DRV(I915_GEM_VM_DESTROY, i915_gem_vm_destroy_ioctl, DRM_RENDER_ALLOW),
>> };
>>
>> +const struct drm_gem_object_funcs i915_gem_object_funcs = {
>> + .free = i915_gem_free_object,
>> + .close = i915_gem_close_object,
>> + .export = i915_gem_prime_export,
>> +};
>> +
>
> Any reason not to make this static in i915_gem_object.c next to its only
> user?
That is just an oversight. Will be fixed in the next iteration. Thanks.
Best regards
Thomas
>
> BR,
> Jani.
>
>
>> static struct drm_driver driver = {
>> /* Don't use MTRRs here; the Xserver or userspace app should
>> * deal with them for Intel hardware.
>> @@ -1853,12 +1859,8 @@ static struct drm_driver driver = {
>> .lastclose = i915_driver_lastclose,
>> .postclose = i915_driver_postclose,
>>
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> -
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = i915_gem_prime_export,
>> .gem_prime_import = i915_gem_prime_import,
>>
>> .dumb_create = i915_gem_dumb_create,
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index bacb4c762f5b..666db65fe69e 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1736,6 +1736,7 @@ intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
>>
>> /* i915_drv.c */
>> extern const struct dev_pm_ops i915_pm_ops;
>> +extern const struct drm_gem_object_funcs i915_gem_object_funcs;
>>
>> int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
>> void i915_driver_remove(struct drm_i915_private *i915);
>> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> index ce4d4303229c..4725dad63e0a 100644
>> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
>> @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = {
>> .name = "mock",
>> .driver_features = DRIVER_GEM,
>> .release = mock_device_release,
>> -
>> - .gem_close_object = i915_gem_close_object,
>> - .gem_free_object_unlocked = i915_gem_free_object,
>> };
>>
>> static void release_dev(struct device *dev)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 182 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 07/20] drm/mediatek: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in mediatek. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 -----
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++++++++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 040a8f393fe2..2f8d0043fca7 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -301,18 +301,13 @@ struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev,
static struct drm_driver mtk_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
- .gem_free_object_unlocked = mtk_drm_gem_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = mtk_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = mtk_drm_gem_prime_import,
- .gem_prime_get_sg_table = mtk_gem_prime_get_sg_table,
.gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
.gem_prime_mmap = mtk_drm_gem_mmap_buf,
- .gem_prime_vmap = mtk_drm_gem_prime_vmap,
- .gem_prime_vunmap = mtk_drm_gem_prime_vunmap,
.fops = &mtk_drm_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 6190cc3b7b0d..591b90410e4a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -8,11 +8,20 @@
#include <drm/drm.h>
#include <drm/drm_device.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include "mtk_drm_drv.h"
#include "mtk_drm_gem.h"
+static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
+ .free = mtk_drm_gem_free_object,
+ .get_sg_table = mtk_gem_prime_get_sg_table,
+ .vmap = mtk_drm_gem_prime_vmap,
+ .vunmap = mtk_drm_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -25,6 +34,8 @@ static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
if (!mtk_gem_obj)
return ERR_PTR(-ENOMEM);
+ mtk_gem_obj->base.funcs = &mtk_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &mtk_gem_obj->base, size);
if (ret < 0) {
DRM_ERROR("failed to initialize gem object\n");
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 07/20] drm/mediatek: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in mediatek. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 -----
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++++++++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 040a8f393fe2..2f8d0043fca7 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -301,18 +301,13 @@ struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev,
static struct drm_driver mtk_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
- .gem_free_object_unlocked = mtk_drm_gem_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = mtk_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = mtk_drm_gem_prime_import,
- .gem_prime_get_sg_table = mtk_gem_prime_get_sg_table,
.gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
.gem_prime_mmap = mtk_drm_gem_mmap_buf,
- .gem_prime_vmap = mtk_drm_gem_prime_vmap,
- .gem_prime_vunmap = mtk_drm_gem_prime_vunmap,
.fops = &mtk_drm_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 6190cc3b7b0d..591b90410e4a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -8,11 +8,20 @@
#include <drm/drm.h>
#include <drm/drm_device.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include "mtk_drm_drv.h"
#include "mtk_drm_gem.h"
+static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
+ .free = mtk_drm_gem_free_object,
+ .get_sg_table = mtk_gem_prime_get_sg_table,
+ .vmap = mtk_drm_gem_prime_vmap,
+ .vunmap = mtk_drm_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -25,6 +34,8 @@ static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
if (!mtk_gem_obj)
return ERR_PTR(-ENOMEM);
+ mtk_gem_obj->base.funcs = &mtk_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &mtk_gem_obj->base, size);
if (ret < 0) {
DRM_ERROR("failed to initialize gem object\n");
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 07/20] drm/mediatek: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in mediatek. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 -----
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++++++++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 040a8f393fe2..2f8d0043fca7 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -301,18 +301,13 @@ struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev,
static struct drm_driver mtk_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
- .gem_free_object_unlocked = mtk_drm_gem_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = mtk_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = mtk_drm_gem_prime_import,
- .gem_prime_get_sg_table = mtk_gem_prime_get_sg_table,
.gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
.gem_prime_mmap = mtk_drm_gem_mmap_buf,
- .gem_prime_vmap = mtk_drm_gem_prime_vmap,
- .gem_prime_vunmap = mtk_drm_gem_prime_vunmap,
.fops = &mtk_drm_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 6190cc3b7b0d..591b90410e4a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -8,11 +8,20 @@
#include <drm/drm.h>
#include <drm/drm_device.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include "mtk_drm_drv.h"
#include "mtk_drm_gem.h"
+static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
+ .free = mtk_drm_gem_free_object,
+ .get_sg_table = mtk_gem_prime_get_sg_table,
+ .vmap = mtk_drm_gem_prime_vmap,
+ .vunmap = mtk_drm_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -25,6 +34,8 @@ static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
if (!mtk_gem_obj)
return ERR_PTR(-ENOMEM);
+ mtk_gem_obj->base.funcs = &mtk_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &mtk_gem_obj->base, size);
if (ret < 0) {
DRM_ERROR("failed to initialize gem object\n");
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 07/20] drm/mediatek: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in mediatek. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 -----
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++++++++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 040a8f393fe2..2f8d0043fca7 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -301,18 +301,13 @@ struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev,
static struct drm_driver mtk_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
- .gem_free_object_unlocked = mtk_drm_gem_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = mtk_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = mtk_drm_gem_prime_import,
- .gem_prime_get_sg_table = mtk_gem_prime_get_sg_table,
.gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
.gem_prime_mmap = mtk_drm_gem_mmap_buf,
- .gem_prime_vmap = mtk_drm_gem_prime_vmap,
- .gem_prime_vunmap = mtk_drm_gem_prime_vunmap,
.fops = &mtk_drm_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 6190cc3b7b0d..591b90410e4a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -8,11 +8,20 @@
#include <drm/drm.h>
#include <drm/drm_device.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include "mtk_drm_drv.h"
#include "mtk_drm_gem.h"
+static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
+ .free = mtk_drm_gem_free_object,
+ .get_sg_table = mtk_gem_prime_get_sg_table,
+ .vmap = mtk_drm_gem_prime_vmap,
+ .vunmap = mtk_drm_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -25,6 +34,8 @@ static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
if (!mtk_gem_obj)
return ERR_PTR(-ENOMEM);
+ mtk_gem_obj->base.funcs = &mtk_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &mtk_gem_obj->base, size);
if (ret < 0) {
DRM_ERROR("failed to initialize gem object\n");
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 07/20] drm/mediatek: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in mediatek. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 -----
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++++++++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 040a8f393fe2..2f8d0043fca7 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -301,18 +301,13 @@ struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev,
static struct drm_driver mtk_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
- .gem_free_object_unlocked = mtk_drm_gem_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = mtk_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = mtk_drm_gem_prime_import,
- .gem_prime_get_sg_table = mtk_gem_prime_get_sg_table,
.gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
.gem_prime_mmap = mtk_drm_gem_mmap_buf,
- .gem_prime_vmap = mtk_drm_gem_prime_vmap,
- .gem_prime_vunmap = mtk_drm_gem_prime_vunmap,
.fops = &mtk_drm_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 6190cc3b7b0d..591b90410e4a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -8,11 +8,20 @@
#include <drm/drm.h>
#include <drm/drm_device.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include "mtk_drm_drv.h"
#include "mtk_drm_gem.h"
+static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
+ .free = mtk_drm_gem_free_object,
+ .get_sg_table = mtk_gem_prime_get_sg_table,
+ .vmap = mtk_drm_gem_prime_vmap,
+ .vunmap = mtk_drm_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -25,6 +34,8 @@ static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
if (!mtk_gem_obj)
return ERR_PTR(-ENOMEM);
+ mtk_gem_obj->base.funcs = &mtk_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &mtk_gem_obj->base, size);
if (ret < 0) {
DRM_ERROR("failed to initialize gem object\n");
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 07/20] drm/mediatek: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in mediatek. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 -----
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 11 +++++++++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 040a8f393fe2..2f8d0043fca7 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -301,18 +301,13 @@ struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev,
static struct drm_driver mtk_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
- .gem_free_object_unlocked = mtk_drm_gem_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = mtk_drm_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import = mtk_drm_gem_prime_import,
- .gem_prime_get_sg_table = mtk_gem_prime_get_sg_table,
.gem_prime_import_sg_table = mtk_gem_prime_import_sg_table,
.gem_prime_mmap = mtk_drm_gem_mmap_buf,
- .gem_prime_vmap = mtk_drm_gem_prime_vmap,
- .gem_prime_vunmap = mtk_drm_gem_prime_vunmap,
.fops = &mtk_drm_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 6190cc3b7b0d..591b90410e4a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -8,11 +8,20 @@
#include <drm/drm.h>
#include <drm/drm_device.h>
#include <drm/drm_gem.h>
+#include <drm/drm_gem_cma_helper.h>
#include <drm/drm_prime.h>
#include "mtk_drm_drv.h"
#include "mtk_drm_gem.h"
+static const struct drm_gem_object_funcs mtk_drm_gem_object_funcs = {
+ .free = mtk_drm_gem_free_object,
+ .get_sg_table = mtk_gem_prime_get_sg_table,
+ .vmap = mtk_drm_gem_prime_vmap,
+ .vunmap = mtk_drm_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
unsigned long size)
{
@@ -25,6 +34,8 @@ static struct mtk_drm_gem_obj *mtk_drm_gem_init(struct drm_device *dev,
if (!mtk_gem_obj)
return ERR_PTR(-ENOMEM);
+ mtk_gem_obj->base.funcs = &mtk_drm_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &mtk_gem_obj->base, size);
if (ret < 0) {
DRM_ERROR("failed to initialize gem object\n");
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 08/20] drm/msm: Introduce GEM object funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in msm. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/msm/msm_drv.c | 13 -------------
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 36d98d4116ca..365a1098761e 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -989,12 +989,6 @@ static const struct drm_ioctl_desc msm_ioctls[] = {
DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = msm_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -1020,18 +1014,11 @@ static struct drm_driver msm_driver = {
.irq_preinstall = msm_irq_preinstall,
.irq_postinstall = msm_irq_postinstall,
.irq_uninstall = msm_irq_uninstall,
- .gem_free_object_unlocked = msm_gem_free_object,
- .gem_vm_ops = &vm_ops,
.dumb_create = msm_gem_dumb_create,
.dumb_map_offset = msm_gem_dumb_map_offset,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = msm_gem_prime_pin,
- .gem_prime_unpin = msm_gem_prime_unpin,
- .gem_prime_get_sg_table = msm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = msm_gem_prime_import_sg_table,
- .gem_prime_vmap = msm_gem_prime_vmap,
- .gem_prime_vunmap = msm_gem_prime_vunmap,
.gem_prime_mmap = msm_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = msm_debugfs_init,
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index af259b0573ea..7bcea10be81f 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -269,7 +269,6 @@ void msm_gem_shrinker_cleanup(struct drm_device *dev);
int msm_gem_mmap_obj(struct drm_gem_object *obj,
struct vm_area_struct *vma);
int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t msm_gem_fault(struct vm_fault *vmf);
uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj);
int msm_gem_get_iova(struct drm_gem_object *obj,
struct msm_gem_address_space *aspace, uint64_t *iova);
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index b2f49152b4d4..465b97a77c38 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -247,7 +247,7 @@ int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return msm_gem_mmap_obj(vma->vm_private_data, vma);
}
-vm_fault_t msm_gem_fault(struct vm_fault *vmf)
+static vm_fault_t msm_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -994,6 +994,22 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
return ret;
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = msm_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs msm_gem_object_funcs = {
+ .free = msm_gem_free_object,
+ .pin = msm_gem_prime_pin,
+ .unpin = msm_gem_prime_unpin,
+ .get_sg_table = msm_gem_prime_get_sg_table,
+ .vmap = msm_gem_prime_vmap,
+ .vunmap = msm_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int msm_gem_new_impl(struct drm_device *dev,
uint32_t size, uint32_t flags,
struct drm_gem_object **obj)
@@ -1024,6 +1040,7 @@ static int msm_gem_new_impl(struct drm_device *dev,
INIT_LIST_HEAD(&msm_obj->vmas);
*obj = &msm_obj->base;
+ (*obj)->funcs = &msm_gem_object_funcs;
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 08/20] drm/msm: Introduce GEM object funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in msm. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/msm/msm_drv.c | 13 -------------
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 36d98d4116ca..365a1098761e 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -989,12 +989,6 @@ static const struct drm_ioctl_desc msm_ioctls[] = {
DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = msm_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -1020,18 +1014,11 @@ static struct drm_driver msm_driver = {
.irq_preinstall = msm_irq_preinstall,
.irq_postinstall = msm_irq_postinstall,
.irq_uninstall = msm_irq_uninstall,
- .gem_free_object_unlocked = msm_gem_free_object,
- .gem_vm_ops = &vm_ops,
.dumb_create = msm_gem_dumb_create,
.dumb_map_offset = msm_gem_dumb_map_offset,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = msm_gem_prime_pin,
- .gem_prime_unpin = msm_gem_prime_unpin,
- .gem_prime_get_sg_table = msm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = msm_gem_prime_import_sg_table,
- .gem_prime_vmap = msm_gem_prime_vmap,
- .gem_prime_vunmap = msm_gem_prime_vunmap,
.gem_prime_mmap = msm_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = msm_debugfs_init,
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index af259b0573ea..7bcea10be81f 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -269,7 +269,6 @@ void msm_gem_shrinker_cleanup(struct drm_device *dev);
int msm_gem_mmap_obj(struct drm_gem_object *obj,
struct vm_area_struct *vma);
int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t msm_gem_fault(struct vm_fault *vmf);
uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj);
int msm_gem_get_iova(struct drm_gem_object *obj,
struct msm_gem_address_space *aspace, uint64_t *iova);
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index b2f49152b4d4..465b97a77c38 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -247,7 +247,7 @@ int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return msm_gem_mmap_obj(vma->vm_private_data, vma);
}
-vm_fault_t msm_gem_fault(struct vm_fault *vmf)
+static vm_fault_t msm_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -994,6 +994,22 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
return ret;
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = msm_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs msm_gem_object_funcs = {
+ .free = msm_gem_free_object,
+ .pin = msm_gem_prime_pin,
+ .unpin = msm_gem_prime_unpin,
+ .get_sg_table = msm_gem_prime_get_sg_table,
+ .vmap = msm_gem_prime_vmap,
+ .vunmap = msm_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int msm_gem_new_impl(struct drm_device *dev,
uint32_t size, uint32_t flags,
struct drm_gem_object **obj)
@@ -1024,6 +1040,7 @@ static int msm_gem_new_impl(struct drm_device *dev,
INIT_LIST_HEAD(&msm_obj->vmas);
*obj = &msm_obj->base;
+ (*obj)->funcs = &msm_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 08/20] drm/msm: Introduce GEM object funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in msm. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/msm/msm_drv.c | 13 -------------
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 36d98d4116ca..365a1098761e 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -989,12 +989,6 @@ static const struct drm_ioctl_desc msm_ioctls[] = {
DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = msm_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -1020,18 +1014,11 @@ static struct drm_driver msm_driver = {
.irq_preinstall = msm_irq_preinstall,
.irq_postinstall = msm_irq_postinstall,
.irq_uninstall = msm_irq_uninstall,
- .gem_free_object_unlocked = msm_gem_free_object,
- .gem_vm_ops = &vm_ops,
.dumb_create = msm_gem_dumb_create,
.dumb_map_offset = msm_gem_dumb_map_offset,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = msm_gem_prime_pin,
- .gem_prime_unpin = msm_gem_prime_unpin,
- .gem_prime_get_sg_table = msm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = msm_gem_prime_import_sg_table,
- .gem_prime_vmap = msm_gem_prime_vmap,
- .gem_prime_vunmap = msm_gem_prime_vunmap,
.gem_prime_mmap = msm_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = msm_debugfs_init,
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index af259b0573ea..7bcea10be81f 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -269,7 +269,6 @@ void msm_gem_shrinker_cleanup(struct drm_device *dev);
int msm_gem_mmap_obj(struct drm_gem_object *obj,
struct vm_area_struct *vma);
int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t msm_gem_fault(struct vm_fault *vmf);
uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj);
int msm_gem_get_iova(struct drm_gem_object *obj,
struct msm_gem_address_space *aspace, uint64_t *iova);
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index b2f49152b4d4..465b97a77c38 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -247,7 +247,7 @@ int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return msm_gem_mmap_obj(vma->vm_private_data, vma);
}
-vm_fault_t msm_gem_fault(struct vm_fault *vmf)
+static vm_fault_t msm_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -994,6 +994,22 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
return ret;
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = msm_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs msm_gem_object_funcs = {
+ .free = msm_gem_free_object,
+ .pin = msm_gem_prime_pin,
+ .unpin = msm_gem_prime_unpin,
+ .get_sg_table = msm_gem_prime_get_sg_table,
+ .vmap = msm_gem_prime_vmap,
+ .vunmap = msm_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int msm_gem_new_impl(struct drm_device *dev,
uint32_t size, uint32_t flags,
struct drm_gem_object **obj)
@@ -1024,6 +1040,7 @@ static int msm_gem_new_impl(struct drm_device *dev,
INIT_LIST_HEAD(&msm_obj->vmas);
*obj = &msm_obj->base;
+ (*obj)->funcs = &msm_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 08/20] drm/msm: Introduce GEM object funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in msm. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/msm/msm_drv.c | 13 -------------
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 36d98d4116ca..365a1098761e 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -989,12 +989,6 @@ static const struct drm_ioctl_desc msm_ioctls[] = {
DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = msm_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -1020,18 +1014,11 @@ static struct drm_driver msm_driver = {
.irq_preinstall = msm_irq_preinstall,
.irq_postinstall = msm_irq_postinstall,
.irq_uninstall = msm_irq_uninstall,
- .gem_free_object_unlocked = msm_gem_free_object,
- .gem_vm_ops = &vm_ops,
.dumb_create = msm_gem_dumb_create,
.dumb_map_offset = msm_gem_dumb_map_offset,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = msm_gem_prime_pin,
- .gem_prime_unpin = msm_gem_prime_unpin,
- .gem_prime_get_sg_table = msm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = msm_gem_prime_import_sg_table,
- .gem_prime_vmap = msm_gem_prime_vmap,
- .gem_prime_vunmap = msm_gem_prime_vunmap,
.gem_prime_mmap = msm_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = msm_debugfs_init,
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index af259b0573ea..7bcea10be81f 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -269,7 +269,6 @@ void msm_gem_shrinker_cleanup(struct drm_device *dev);
int msm_gem_mmap_obj(struct drm_gem_object *obj,
struct vm_area_struct *vma);
int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t msm_gem_fault(struct vm_fault *vmf);
uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj);
int msm_gem_get_iova(struct drm_gem_object *obj,
struct msm_gem_address_space *aspace, uint64_t *iova);
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index b2f49152b4d4..465b97a77c38 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -247,7 +247,7 @@ int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return msm_gem_mmap_obj(vma->vm_private_data, vma);
}
-vm_fault_t msm_gem_fault(struct vm_fault *vmf)
+static vm_fault_t msm_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -994,6 +994,22 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
return ret;
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = msm_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs msm_gem_object_funcs = {
+ .free = msm_gem_free_object,
+ .pin = msm_gem_prime_pin,
+ .unpin = msm_gem_prime_unpin,
+ .get_sg_table = msm_gem_prime_get_sg_table,
+ .vmap = msm_gem_prime_vmap,
+ .vunmap = msm_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int msm_gem_new_impl(struct drm_device *dev,
uint32_t size, uint32_t flags,
struct drm_gem_object **obj)
@@ -1024,6 +1040,7 @@ static int msm_gem_new_impl(struct drm_device *dev,
INIT_LIST_HEAD(&msm_obj->vmas);
*obj = &msm_obj->base;
+ (*obj)->funcs = &msm_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 08/20] drm/msm: Introduce GEM object funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in msm. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/msm/msm_drv.c | 13 -------------
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 36d98d4116ca..365a1098761e 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -989,12 +989,6 @@ static const struct drm_ioctl_desc msm_ioctls[] = {
DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = msm_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -1020,18 +1014,11 @@ static struct drm_driver msm_driver = {
.irq_preinstall = msm_irq_preinstall,
.irq_postinstall = msm_irq_postinstall,
.irq_uninstall = msm_irq_uninstall,
- .gem_free_object_unlocked = msm_gem_free_object,
- .gem_vm_ops = &vm_ops,
.dumb_create = msm_gem_dumb_create,
.dumb_map_offset = msm_gem_dumb_map_offset,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = msm_gem_prime_pin,
- .gem_prime_unpin = msm_gem_prime_unpin,
- .gem_prime_get_sg_table = msm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = msm_gem_prime_import_sg_table,
- .gem_prime_vmap = msm_gem_prime_vmap,
- .gem_prime_vunmap = msm_gem_prime_vunmap,
.gem_prime_mmap = msm_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = msm_debugfs_init,
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index af259b0573ea..7bcea10be81f 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -269,7 +269,6 @@ void msm_gem_shrinker_cleanup(struct drm_device *dev);
int msm_gem_mmap_obj(struct drm_gem_object *obj,
struct vm_area_struct *vma);
int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t msm_gem_fault(struct vm_fault *vmf);
uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj);
int msm_gem_get_iova(struct drm_gem_object *obj,
struct msm_gem_address_space *aspace, uint64_t *iova);
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index b2f49152b4d4..465b97a77c38 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -247,7 +247,7 @@ int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return msm_gem_mmap_obj(vma->vm_private_data, vma);
}
-vm_fault_t msm_gem_fault(struct vm_fault *vmf)
+static vm_fault_t msm_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -994,6 +994,22 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
return ret;
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = msm_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs msm_gem_object_funcs = {
+ .free = msm_gem_free_object,
+ .pin = msm_gem_prime_pin,
+ .unpin = msm_gem_prime_unpin,
+ .get_sg_table = msm_gem_prime_get_sg_table,
+ .vmap = msm_gem_prime_vmap,
+ .vunmap = msm_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int msm_gem_new_impl(struct drm_device *dev,
uint32_t size, uint32_t flags,
struct drm_gem_object **obj)
@@ -1024,6 +1040,7 @@ static int msm_gem_new_impl(struct drm_device *dev,
INIT_LIST_HEAD(&msm_obj->vmas);
*obj = &msm_obj->base;
+ (*obj)->funcs = &msm_gem_object_funcs;
return 0;
}
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 08/20] drm/msm: Introduce GEM object funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in msm. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/msm/msm_drv.c | 13 -------------
drivers/gpu/drm/msm/msm_drv.h | 1 -
drivers/gpu/drm/msm/msm_gem.c | 19 ++++++++++++++++++-
3 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 36d98d4116ca..365a1098761e 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -989,12 +989,6 @@ static const struct drm_ioctl_desc msm_ioctls[] = {
DRM_IOCTL_DEF_DRV(MSM_SUBMITQUEUE_QUERY, msm_ioctl_submitqueue_query, DRM_RENDER_ALLOW),
};
-static const struct vm_operations_struct vm_ops = {
- .fault = msm_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -1020,18 +1014,11 @@ static struct drm_driver msm_driver = {
.irq_preinstall = msm_irq_preinstall,
.irq_postinstall = msm_irq_postinstall,
.irq_uninstall = msm_irq_uninstall,
- .gem_free_object_unlocked = msm_gem_free_object,
- .gem_vm_ops = &vm_ops,
.dumb_create = msm_gem_dumb_create,
.dumb_map_offset = msm_gem_dumb_map_offset,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = msm_gem_prime_pin,
- .gem_prime_unpin = msm_gem_prime_unpin,
- .gem_prime_get_sg_table = msm_gem_prime_get_sg_table,
.gem_prime_import_sg_table = msm_gem_prime_import_sg_table,
- .gem_prime_vmap = msm_gem_prime_vmap,
- .gem_prime_vunmap = msm_gem_prime_vunmap,
.gem_prime_mmap = msm_gem_prime_mmap,
#ifdef CONFIG_DEBUG_FS
.debugfs_init = msm_debugfs_init,
diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h
index af259b0573ea..7bcea10be81f 100644
--- a/drivers/gpu/drm/msm/msm_drv.h
+++ b/drivers/gpu/drm/msm/msm_drv.h
@@ -269,7 +269,6 @@ void msm_gem_shrinker_cleanup(struct drm_device *dev);
int msm_gem_mmap_obj(struct drm_gem_object *obj,
struct vm_area_struct *vma);
int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma);
-vm_fault_t msm_gem_fault(struct vm_fault *vmf);
uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj);
int msm_gem_get_iova(struct drm_gem_object *obj,
struct msm_gem_address_space *aspace, uint64_t *iova);
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index b2f49152b4d4..465b97a77c38 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -247,7 +247,7 @@ int msm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
return msm_gem_mmap_obj(vma->vm_private_data, vma);
}
-vm_fault_t msm_gem_fault(struct vm_fault *vmf)
+static vm_fault_t msm_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -994,6 +994,22 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
return ret;
}
+static const struct vm_operations_struct vm_ops = {
+ .fault = msm_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs msm_gem_object_funcs = {
+ .free = msm_gem_free_object,
+ .pin = msm_gem_prime_pin,
+ .unpin = msm_gem_prime_unpin,
+ .get_sg_table = msm_gem_prime_get_sg_table,
+ .vmap = msm_gem_prime_vmap,
+ .vunmap = msm_gem_prime_vunmap,
+ .vm_ops = &vm_ops,
+};
+
static int msm_gem_new_impl(struct drm_device *dev,
uint32_t size, uint32_t flags,
struct drm_gem_object **obj)
@@ -1024,6 +1040,7 @@ static int msm_gem_new_impl(struct drm_device *dev,
INIT_LIST_HEAD(&msm_obj->vmas);
*obj = &msm_obj->base;
+ (*obj)->funcs = &msm_gem_object_funcs;
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 09/20] drm/nouveau: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in nouveau.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 ---------
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++++++++++++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 ++
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 ++
4 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22d246acc5e5..dc2388efc857 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1207,16 +1207,7 @@ driver_stub = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = nouveau_gem_prime_pin,
- .gem_prime_unpin = nouveau_gem_prime_unpin,
- .gem_prime_get_sg_table = nouveau_gem_prime_get_sg_table,
.gem_prime_import_sg_table = nouveau_gem_prime_import_sg_table,
- .gem_prime_vmap = nouveau_gem_prime_vmap,
- .gem_prime_vunmap = nouveau_gem_prime_vunmap,
-
- .gem_free_object_unlocked = nouveau_gem_object_del,
- .gem_open_object = nouveau_gem_object_open,
- .gem_close_object = nouveau_gem_object_close,
.dumb_create = nouveau_display_dumb_create,
.dumb_map_offset = nouveau_display_dumb_map_offset,
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 81f111ad3f4f..b04b8f6bb9d5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -169,6 +169,17 @@ nouveau_gem_object_close(struct drm_gem_object *gem, struct drm_file *file_priv)
ttm_bo_unreserve(&nvbo->bo);
}
+const struct drm_gem_object_funcs nouveau_gem_object_funcs = {
+ .free = nouveau_gem_object_del,
+ .open = nouveau_gem_object_open,
+ .close = nouveau_gem_object_close,
+ .pin = nouveau_gem_prime_pin,
+ .unpin = nouveau_gem_prime_unpin,
+ .get_sg_table = nouveau_gem_prime_get_sg_table,
+ .vmap = nouveau_gem_prime_vmap,
+ .vunmap = nouveau_gem_prime_vunmap,
+};
+
int
nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
uint32_t tile_mode, uint32_t tile_flags,
@@ -194,6 +205,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
if (IS_ERR(nvbo))
return PTR_ERR(nvbo);
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(drm->dev, &nvbo->bo.base, size);
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.h b/drivers/gpu/drm/nouveau/nouveau_gem.h
index 978e07591990..b35c180322e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.h
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.h
@@ -5,6 +5,8 @@
#include "nouveau_drv.h"
#include "nouveau_bo.h"
+extern const struct drm_gem_object_funcs nouveau_gem_object_funcs;
+
static inline struct nouveau_bo *
nouveau_gem_object(struct drm_gem_object *gem)
{
diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
index bae6a3eccee0..30f616aa251e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_prime.c
+++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
@@ -79,6 +79,8 @@ struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
nvbo->valid_domains = NOUVEAU_GEM_DOMAIN_GART;
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(dev, &nvbo->bo.base, size);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 09/20] drm/nouveau: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in nouveau.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 ---------
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++++++++++++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 ++
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 ++
4 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22d246acc5e5..dc2388efc857 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1207,16 +1207,7 @@ driver_stub = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = nouveau_gem_prime_pin,
- .gem_prime_unpin = nouveau_gem_prime_unpin,
- .gem_prime_get_sg_table = nouveau_gem_prime_get_sg_table,
.gem_prime_import_sg_table = nouveau_gem_prime_import_sg_table,
- .gem_prime_vmap = nouveau_gem_prime_vmap,
- .gem_prime_vunmap = nouveau_gem_prime_vunmap,
-
- .gem_free_object_unlocked = nouveau_gem_object_del,
- .gem_open_object = nouveau_gem_object_open,
- .gem_close_object = nouveau_gem_object_close,
.dumb_create = nouveau_display_dumb_create,
.dumb_map_offset = nouveau_display_dumb_map_offset,
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 81f111ad3f4f..b04b8f6bb9d5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -169,6 +169,17 @@ nouveau_gem_object_close(struct drm_gem_object *gem, struct drm_file *file_priv)
ttm_bo_unreserve(&nvbo->bo);
}
+const struct drm_gem_object_funcs nouveau_gem_object_funcs = {
+ .free = nouveau_gem_object_del,
+ .open = nouveau_gem_object_open,
+ .close = nouveau_gem_object_close,
+ .pin = nouveau_gem_prime_pin,
+ .unpin = nouveau_gem_prime_unpin,
+ .get_sg_table = nouveau_gem_prime_get_sg_table,
+ .vmap = nouveau_gem_prime_vmap,
+ .vunmap = nouveau_gem_prime_vunmap,
+};
+
int
nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
uint32_t tile_mode, uint32_t tile_flags,
@@ -194,6 +205,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
if (IS_ERR(nvbo))
return PTR_ERR(nvbo);
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(drm->dev, &nvbo->bo.base, size);
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.h b/drivers/gpu/drm/nouveau/nouveau_gem.h
index 978e07591990..b35c180322e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.h
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.h
@@ -5,6 +5,8 @@
#include "nouveau_drv.h"
#include "nouveau_bo.h"
+extern const struct drm_gem_object_funcs nouveau_gem_object_funcs;
+
static inline struct nouveau_bo *
nouveau_gem_object(struct drm_gem_object *gem)
{
diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
index bae6a3eccee0..30f616aa251e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_prime.c
+++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
@@ -79,6 +79,8 @@ struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
nvbo->valid_domains = NOUVEAU_GEM_DOMAIN_GART;
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(dev, &nvbo->bo.base, size);
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 09/20] drm/nouveau: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in nouveau.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 ---------
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++++++++++++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 ++
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 ++
4 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22d246acc5e5..dc2388efc857 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1207,16 +1207,7 @@ driver_stub = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = nouveau_gem_prime_pin,
- .gem_prime_unpin = nouveau_gem_prime_unpin,
- .gem_prime_get_sg_table = nouveau_gem_prime_get_sg_table,
.gem_prime_import_sg_table = nouveau_gem_prime_import_sg_table,
- .gem_prime_vmap = nouveau_gem_prime_vmap,
- .gem_prime_vunmap = nouveau_gem_prime_vunmap,
-
- .gem_free_object_unlocked = nouveau_gem_object_del,
- .gem_open_object = nouveau_gem_object_open,
- .gem_close_object = nouveau_gem_object_close,
.dumb_create = nouveau_display_dumb_create,
.dumb_map_offset = nouveau_display_dumb_map_offset,
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 81f111ad3f4f..b04b8f6bb9d5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -169,6 +169,17 @@ nouveau_gem_object_close(struct drm_gem_object *gem, struct drm_file *file_priv)
ttm_bo_unreserve(&nvbo->bo);
}
+const struct drm_gem_object_funcs nouveau_gem_object_funcs = {
+ .free = nouveau_gem_object_del,
+ .open = nouveau_gem_object_open,
+ .close = nouveau_gem_object_close,
+ .pin = nouveau_gem_prime_pin,
+ .unpin = nouveau_gem_prime_unpin,
+ .get_sg_table = nouveau_gem_prime_get_sg_table,
+ .vmap = nouveau_gem_prime_vmap,
+ .vunmap = nouveau_gem_prime_vunmap,
+};
+
int
nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
uint32_t tile_mode, uint32_t tile_flags,
@@ -194,6 +205,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
if (IS_ERR(nvbo))
return PTR_ERR(nvbo);
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(drm->dev, &nvbo->bo.base, size);
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.h b/drivers/gpu/drm/nouveau/nouveau_gem.h
index 978e07591990..b35c180322e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.h
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.h
@@ -5,6 +5,8 @@
#include "nouveau_drv.h"
#include "nouveau_bo.h"
+extern const struct drm_gem_object_funcs nouveau_gem_object_funcs;
+
static inline struct nouveau_bo *
nouveau_gem_object(struct drm_gem_object *gem)
{
diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
index bae6a3eccee0..30f616aa251e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_prime.c
+++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
@@ -79,6 +79,8 @@ struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
nvbo->valid_domains = NOUVEAU_GEM_DOMAIN_GART;
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(dev, &nvbo->bo.base, size);
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 09/20] drm/nouveau: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in nouveau.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 ---------
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++++++++++++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 ++
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 ++
4 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22d246acc5e5..dc2388efc857 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1207,16 +1207,7 @@ driver_stub = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = nouveau_gem_prime_pin,
- .gem_prime_unpin = nouveau_gem_prime_unpin,
- .gem_prime_get_sg_table = nouveau_gem_prime_get_sg_table,
.gem_prime_import_sg_table = nouveau_gem_prime_import_sg_table,
- .gem_prime_vmap = nouveau_gem_prime_vmap,
- .gem_prime_vunmap = nouveau_gem_prime_vunmap,
-
- .gem_free_object_unlocked = nouveau_gem_object_del,
- .gem_open_object = nouveau_gem_object_open,
- .gem_close_object = nouveau_gem_object_close,
.dumb_create = nouveau_display_dumb_create,
.dumb_map_offset = nouveau_display_dumb_map_offset,
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 81f111ad3f4f..b04b8f6bb9d5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -169,6 +169,17 @@ nouveau_gem_object_close(struct drm_gem_object *gem, struct drm_file *file_priv)
ttm_bo_unreserve(&nvbo->bo);
}
+const struct drm_gem_object_funcs nouveau_gem_object_funcs = {
+ .free = nouveau_gem_object_del,
+ .open = nouveau_gem_object_open,
+ .close = nouveau_gem_object_close,
+ .pin = nouveau_gem_prime_pin,
+ .unpin = nouveau_gem_prime_unpin,
+ .get_sg_table = nouveau_gem_prime_get_sg_table,
+ .vmap = nouveau_gem_prime_vmap,
+ .vunmap = nouveau_gem_prime_vunmap,
+};
+
int
nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
uint32_t tile_mode, uint32_t tile_flags,
@@ -194,6 +205,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
if (IS_ERR(nvbo))
return PTR_ERR(nvbo);
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(drm->dev, &nvbo->bo.base, size);
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.h b/drivers/gpu/drm/nouveau/nouveau_gem.h
index 978e07591990..b35c180322e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.h
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.h
@@ -5,6 +5,8 @@
#include "nouveau_drv.h"
#include "nouveau_bo.h"
+extern const struct drm_gem_object_funcs nouveau_gem_object_funcs;
+
static inline struct nouveau_bo *
nouveau_gem_object(struct drm_gem_object *gem)
{
diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
index bae6a3eccee0..30f616aa251e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_prime.c
+++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
@@ -79,6 +79,8 @@ struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
nvbo->valid_domains = NOUVEAU_GEM_DOMAIN_GART;
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(dev, &nvbo->bo.base, size);
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 09/20] drm/nouveau: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in nouveau.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 ---------
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++++++++++++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 ++
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 ++
4 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22d246acc5e5..dc2388efc857 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1207,16 +1207,7 @@ driver_stub = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = nouveau_gem_prime_pin,
- .gem_prime_unpin = nouveau_gem_prime_unpin,
- .gem_prime_get_sg_table = nouveau_gem_prime_get_sg_table,
.gem_prime_import_sg_table = nouveau_gem_prime_import_sg_table,
- .gem_prime_vmap = nouveau_gem_prime_vmap,
- .gem_prime_vunmap = nouveau_gem_prime_vunmap,
-
- .gem_free_object_unlocked = nouveau_gem_object_del,
- .gem_open_object = nouveau_gem_object_open,
- .gem_close_object = nouveau_gem_object_close,
.dumb_create = nouveau_display_dumb_create,
.dumb_map_offset = nouveau_display_dumb_map_offset,
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 81f111ad3f4f..b04b8f6bb9d5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -169,6 +169,17 @@ nouveau_gem_object_close(struct drm_gem_object *gem, struct drm_file *file_priv)
ttm_bo_unreserve(&nvbo->bo);
}
+const struct drm_gem_object_funcs nouveau_gem_object_funcs = {
+ .free = nouveau_gem_object_del,
+ .open = nouveau_gem_object_open,
+ .close = nouveau_gem_object_close,
+ .pin = nouveau_gem_prime_pin,
+ .unpin = nouveau_gem_prime_unpin,
+ .get_sg_table = nouveau_gem_prime_get_sg_table,
+ .vmap = nouveau_gem_prime_vmap,
+ .vunmap = nouveau_gem_prime_vunmap,
+};
+
int
nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
uint32_t tile_mode, uint32_t tile_flags,
@@ -194,6 +205,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
if (IS_ERR(nvbo))
return PTR_ERR(nvbo);
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(drm->dev, &nvbo->bo.base, size);
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.h b/drivers/gpu/drm/nouveau/nouveau_gem.h
index 978e07591990..b35c180322e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.h
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.h
@@ -5,6 +5,8 @@
#include "nouveau_drv.h"
#include "nouveau_bo.h"
+extern const struct drm_gem_object_funcs nouveau_gem_object_funcs;
+
static inline struct nouveau_bo *
nouveau_gem_object(struct drm_gem_object *gem)
{
diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
index bae6a3eccee0..30f616aa251e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_prime.c
+++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
@@ -79,6 +79,8 @@ struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
nvbo->valid_domains = NOUVEAU_GEM_DOMAIN_GART;
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(dev, &nvbo->bo.base, size);
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 09/20] drm/nouveau: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in nouveau.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 ---------
drivers/gpu/drm/nouveau/nouveau_gem.c | 13 +++++++++++++
drivers/gpu/drm/nouveau/nouveau_gem.h | 2 ++
drivers/gpu/drm/nouveau/nouveau_prime.c | 2 ++
4 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 22d246acc5e5..dc2388efc857 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -1207,16 +1207,7 @@ driver_stub = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = nouveau_gem_prime_pin,
- .gem_prime_unpin = nouveau_gem_prime_unpin,
- .gem_prime_get_sg_table = nouveau_gem_prime_get_sg_table,
.gem_prime_import_sg_table = nouveau_gem_prime_import_sg_table,
- .gem_prime_vmap = nouveau_gem_prime_vmap,
- .gem_prime_vunmap = nouveau_gem_prime_vunmap,
-
- .gem_free_object_unlocked = nouveau_gem_object_del,
- .gem_open_object = nouveau_gem_object_open,
- .gem_close_object = nouveau_gem_object_close,
.dumb_create = nouveau_display_dumb_create,
.dumb_map_offset = nouveau_display_dumb_map_offset,
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c
index 81f111ad3f4f..b04b8f6bb9d5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.c
@@ -169,6 +169,17 @@ nouveau_gem_object_close(struct drm_gem_object *gem, struct drm_file *file_priv)
ttm_bo_unreserve(&nvbo->bo);
}
+const struct drm_gem_object_funcs nouveau_gem_object_funcs = {
+ .free = nouveau_gem_object_del,
+ .open = nouveau_gem_object_open,
+ .close = nouveau_gem_object_close,
+ .pin = nouveau_gem_prime_pin,
+ .unpin = nouveau_gem_prime_unpin,
+ .get_sg_table = nouveau_gem_prime_get_sg_table,
+ .vmap = nouveau_gem_prime_vmap,
+ .vunmap = nouveau_gem_prime_vunmap,
+};
+
int
nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
uint32_t tile_mode, uint32_t tile_flags,
@@ -194,6 +205,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
if (IS_ERR(nvbo))
return PTR_ERR(nvbo);
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(drm->dev, &nvbo->bo.base, size);
diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.h b/drivers/gpu/drm/nouveau/nouveau_gem.h
index 978e07591990..b35c180322e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_gem.h
+++ b/drivers/gpu/drm/nouveau/nouveau_gem.h
@@ -5,6 +5,8 @@
#include "nouveau_drv.h"
#include "nouveau_bo.h"
+extern const struct drm_gem_object_funcs nouveau_gem_object_funcs;
+
static inline struct nouveau_bo *
nouveau_gem_object(struct drm_gem_object *gem)
{
diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
index bae6a3eccee0..30f616aa251e 100644
--- a/drivers/gpu/drm/nouveau/nouveau_prime.c
+++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
@@ -79,6 +79,8 @@ struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
nvbo->valid_domains = NOUVEAU_GEM_DOMAIN_GART;
+ nvbo->bo.base.funcs = &nouveau_gem_object_funcs;
+
/* Initialize the embedded gem-object. We return a single gem-reference
* to the caller, instead of a normal nouveau_bo ttm reference. */
ret = drm_gem_object_init(dev, &nvbo->bo.base, size);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in omapdrm.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
3 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 53d5e184ee77..2e598b8b72af 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
return 0;
}
-static const struct vm_operations_struct omap_gem_vm_ops = {
- .fault = omap_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations omapdriver_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
#endif
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = omap_gem_prime_export,
.gem_prime_import = omap_gem_prime_import,
- .gem_free_object_unlocked = omap_gem_free_object,
- .gem_vm_ops = &omap_gem_vm_ops,
.dumb_create = omap_gem_dumb_create,
.dumb_map_offset = omap_gem_dumb_map_offset,
.ioctls = ioctls,
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index d0d12d5dd76c..d68dc63dea0a 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t omap_gem_fault(struct vm_fault *vmf)
+static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
return true;
}
+static const struct vm_operations_struct omap_gem_vm_ops = {
+ .fault = omap_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs omap_gem_object_funcs = {
+ .free = omap_gem_free_object,
+ .export = omap_gem_prime_export,
+ .vm_ops = &omap_gem_vm_ops,
+};
+
/* GEM buffer object constructor */
struct drm_gem_object *omap_gem_new(struct drm_device *dev,
union omap_gem_size gsize, u32 flags)
@@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
size = PAGE_ALIGN(gsize.bytes);
}
+ obj->funcs = &omap_gem_object_funcs;
+
/* Initialize the GEM object. */
if (!(flags & OMAP_BO_MEM_SHMEM)) {
drm_gem_private_object_init(dev, obj, size);
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
index 729b7812a815..9e6b5c8195d9 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.h
+++ b/drivers/gpu/drm/omapdrm/omap_gem.h
@@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
struct dma_buf *buffer);
-vm_fault_t omap_gem_fault(struct vm_fault *vmf);
int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in omapdrm.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
3 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 53d5e184ee77..2e598b8b72af 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
return 0;
}
-static const struct vm_operations_struct omap_gem_vm_ops = {
- .fault = omap_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations omapdriver_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
#endif
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = omap_gem_prime_export,
.gem_prime_import = omap_gem_prime_import,
- .gem_free_object_unlocked = omap_gem_free_object,
- .gem_vm_ops = &omap_gem_vm_ops,
.dumb_create = omap_gem_dumb_create,
.dumb_map_offset = omap_gem_dumb_map_offset,
.ioctls = ioctls,
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index d0d12d5dd76c..d68dc63dea0a 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t omap_gem_fault(struct vm_fault *vmf)
+static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
return true;
}
+static const struct vm_operations_struct omap_gem_vm_ops = {
+ .fault = omap_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs omap_gem_object_funcs = {
+ .free = omap_gem_free_object,
+ .export = omap_gem_prime_export,
+ .vm_ops = &omap_gem_vm_ops,
+};
+
/* GEM buffer object constructor */
struct drm_gem_object *omap_gem_new(struct drm_device *dev,
union omap_gem_size gsize, u32 flags)
@@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
size = PAGE_ALIGN(gsize.bytes);
}
+ obj->funcs = &omap_gem_object_funcs;
+
/* Initialize the GEM object. */
if (!(flags & OMAP_BO_MEM_SHMEM)) {
drm_gem_private_object_init(dev, obj, size);
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
index 729b7812a815..9e6b5c8195d9 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.h
+++ b/drivers/gpu/drm/omapdrm/omap_gem.h
@@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
struct dma_buf *buffer);
-vm_fault_t omap_gem_fault(struct vm_fault *vmf);
int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in omapdrm.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
3 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 53d5e184ee77..2e598b8b72af 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
return 0;
}
-static const struct vm_operations_struct omap_gem_vm_ops = {
- .fault = omap_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations omapdriver_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
#endif
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = omap_gem_prime_export,
.gem_prime_import = omap_gem_prime_import,
- .gem_free_object_unlocked = omap_gem_free_object,
- .gem_vm_ops = &omap_gem_vm_ops,
.dumb_create = omap_gem_dumb_create,
.dumb_map_offset = omap_gem_dumb_map_offset,
.ioctls = ioctls,
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index d0d12d5dd76c..d68dc63dea0a 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t omap_gem_fault(struct vm_fault *vmf)
+static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
return true;
}
+static const struct vm_operations_struct omap_gem_vm_ops = {
+ .fault = omap_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs omap_gem_object_funcs = {
+ .free = omap_gem_free_object,
+ .export = omap_gem_prime_export,
+ .vm_ops = &omap_gem_vm_ops,
+};
+
/* GEM buffer object constructor */
struct drm_gem_object *omap_gem_new(struct drm_device *dev,
union omap_gem_size gsize, u32 flags)
@@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
size = PAGE_ALIGN(gsize.bytes);
}
+ obj->funcs = &omap_gem_object_funcs;
+
/* Initialize the GEM object. */
if (!(flags & OMAP_BO_MEM_SHMEM)) {
drm_gem_private_object_init(dev, obj, size);
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
index 729b7812a815..9e6b5c8195d9 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.h
+++ b/drivers/gpu/drm/omapdrm/omap_gem.h
@@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
struct dma_buf *buffer);
-vm_fault_t omap_gem_fault(struct vm_fault *vmf);
int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in omapdrm.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
3 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 53d5e184ee77..2e598b8b72af 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
return 0;
}
-static const struct vm_operations_struct omap_gem_vm_ops = {
- .fault = omap_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations omapdriver_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
#endif
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = omap_gem_prime_export,
.gem_prime_import = omap_gem_prime_import,
- .gem_free_object_unlocked = omap_gem_free_object,
- .gem_vm_ops = &omap_gem_vm_ops,
.dumb_create = omap_gem_dumb_create,
.dumb_map_offset = omap_gem_dumb_map_offset,
.ioctls = ioctls,
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index d0d12d5dd76c..d68dc63dea0a 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t omap_gem_fault(struct vm_fault *vmf)
+static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
return true;
}
+static const struct vm_operations_struct omap_gem_vm_ops = {
+ .fault = omap_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs omap_gem_object_funcs = {
+ .free = omap_gem_free_object,
+ .export = omap_gem_prime_export,
+ .vm_ops = &omap_gem_vm_ops,
+};
+
/* GEM buffer object constructor */
struct drm_gem_object *omap_gem_new(struct drm_device *dev,
union omap_gem_size gsize, u32 flags)
@@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
size = PAGE_ALIGN(gsize.bytes);
}
+ obj->funcs = &omap_gem_object_funcs;
+
/* Initialize the GEM object. */
if (!(flags & OMAP_BO_MEM_SHMEM)) {
drm_gem_private_object_init(dev, obj, size);
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
index 729b7812a815..9e6b5c8195d9 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.h
+++ b/drivers/gpu/drm/omapdrm/omap_gem.h
@@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
struct dma_buf *buffer);
-vm_fault_t omap_gem_fault(struct vm_fault *vmf);
int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in omapdrm.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
3 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 53d5e184ee77..2e598b8b72af 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
return 0;
}
-static const struct vm_operations_struct omap_gem_vm_ops = {
- .fault = omap_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations omapdriver_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
#endif
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = omap_gem_prime_export,
.gem_prime_import = omap_gem_prime_import,
- .gem_free_object_unlocked = omap_gem_free_object,
- .gem_vm_ops = &omap_gem_vm_ops,
.dumb_create = omap_gem_dumb_create,
.dumb_map_offset = omap_gem_dumb_map_offset,
.ioctls = ioctls,
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index d0d12d5dd76c..d68dc63dea0a 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t omap_gem_fault(struct vm_fault *vmf)
+static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
return true;
}
+static const struct vm_operations_struct omap_gem_vm_ops = {
+ .fault = omap_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs omap_gem_object_funcs = {
+ .free = omap_gem_free_object,
+ .export = omap_gem_prime_export,
+ .vm_ops = &omap_gem_vm_ops,
+};
+
/* GEM buffer object constructor */
struct drm_gem_object *omap_gem_new(struct drm_device *dev,
union omap_gem_size gsize, u32 flags)
@@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
size = PAGE_ALIGN(gsize.bytes);
}
+ obj->funcs = &omap_gem_object_funcs;
+
/* Initialize the GEM object. */
if (!(flags & OMAP_BO_MEM_SHMEM)) {
drm_gem_private_object_init(dev, obj, size);
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
index 729b7812a815..9e6b5c8195d9 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.h
+++ b/drivers/gpu/drm/omapdrm/omap_gem.h
@@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
struct dma_buf *buffer);
-vm_fault_t omap_gem_fault(struct vm_fault *vmf);
int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in omapdrm.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
3 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 53d5e184ee77..2e598b8b72af 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
return 0;
}
-static const struct vm_operations_struct omap_gem_vm_ops = {
- .fault = omap_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations omapdriver_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
#endif
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = omap_gem_prime_export,
.gem_prime_import = omap_gem_prime_import,
- .gem_free_object_unlocked = omap_gem_free_object,
- .gem_vm_ops = &omap_gem_vm_ops,
.dumb_create = omap_gem_dumb_create,
.dumb_map_offset = omap_gem_dumb_map_offset,
.ioctls = ioctls,
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index d0d12d5dd76c..d68dc63dea0a 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
* vma->vm_private_data points to the GEM object that is backing this
* mapping.
*/
-vm_fault_t omap_gem_fault(struct vm_fault *vmf)
+static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
@@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
return true;
}
+static const struct vm_operations_struct omap_gem_vm_ops = {
+ .fault = omap_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs omap_gem_object_funcs = {
+ .free = omap_gem_free_object,
+ .export = omap_gem_prime_export,
+ .vm_ops = &omap_gem_vm_ops,
+};
+
/* GEM buffer object constructor */
struct drm_gem_object *omap_gem_new(struct drm_device *dev,
union omap_gem_size gsize, u32 flags)
@@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
size = PAGE_ALIGN(gsize.bytes);
}
+ obj->funcs = &omap_gem_object_funcs;
+
/* Initialize the GEM object. */
if (!(flags & OMAP_BO_MEM_SHMEM)) {
drm_gem_private_object_init(dev, obj, size);
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
index 729b7812a815..9e6b5c8195d9 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.h
+++ b/drivers/gpu/drm/omapdrm/omap_gem.h
@@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
struct dma_buf *buffer);
-vm_fault_t omap_gem_fault(struct vm_fault *vmf);
int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (4 preceding siblings ...)
(?)
@ 2020-08-13 13:38 ` Laurent Pinchart
-1 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:38 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, michal.simek, sumit.semwal, evan.quan, Hawking.Zhang,
tianci.yin, marek.olsak, hdegoede, andrey.grodzovsky,
Felix.Kuehling, xinhui.pan, aaron.liu, nirmoy.das, chris,
matthew.auld, abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam,
miaoqinglang, emil.velikov, amd-gfx, dri-devel, etnaviv,
linux-arm-kernel, linux-samsung-soc, intel-gfx, linux-mediatek,
linux-arm-msm, freedreno, nouveau, linux-rockchip, linux-tegra,
xen-devel
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
I like how this function now becomes internal to omap_gem.c.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 13:38 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:38 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sam, sumit.semwal, emil.velikov,
abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
patrik.r.jakobsson, jonathanh, linux-rockchip, kgene, bskeggs,
xen-devel, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, miaoqinglang,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
I like how this function now becomes internal to omap_gem.c.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
Regards,
Laurent Pinchart
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 13:38 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:38 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
dri-devel, michal.simek, eric, krzk, sam, sumit.semwal,
emil.velikov, abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
jonathanh, linux-rockchip, kgene, bskeggs, xen-devel, intel-gfx,
matthew.auld, chunkuang.hu, linux-arm-msm, marek.olsak,
tianci.yin, etnaviv, inki.dae, christian.gmeiner, linux-mediatek,
mripard, matthias.bgg, evan.quan, linux-arm-kernel, amd-gfx,
chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, miaoqinglang, kyungmin.park,
nirmoy.das, p.zabel, alexander.deucher, Hawking.Zhang, freedreno,
christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
I like how this function now becomes internal to omap_gem.c.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
Regards,
Laurent Pinchart
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 13:38 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:38 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, airlied, nouveau, dri-devel, michal.simek,
thierry.reding, krzk, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, jonathanh, linux-rockchip,
kgene, bskeggs, xen-devel, intel-gfx, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, marek.olsak, tianci.yin, etnaviv,
hdegoede, linux-mediatek, rodrigo.vivi, matthias.bgg, evan.quan,
sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx, chris,
hyun.kwon, rodrigosiqueiramelo, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, miaoqinglang, kyungmin.park,
nirmoy.das, alexander.deucher, Hawking.Zhang, freedreno,
christian.koenig
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
I like how this function now becomes internal to omap_gem.c.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 13:38 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:38 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sam, sumit.semwal, emil.velikov,
abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
patrik.r.jakobsson, jonathanh, linux-rockchip, kgene, bskeggs,
xen-devel, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, miaoqinglang,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
I like how this function now becomes internal to omap_gem.c.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 13:38 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:38 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sam, sumit.semwal, emil.velikov,
abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
patrik.r.jakobsson, jonathanh, linux-rockchip, kgene, bskeggs,
xen-devel, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, miaoqinglang,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
I like how this function now becomes internal to omap_gem.c.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-13 13:38 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:38 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:34AM +0200, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
I like how this function now becomes internal to omap_gem.c.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 243+ messages in thread
* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (4 preceding siblings ...)
(?)
@ 2020-08-19 10:43 ` Tomi Valkeinen
-1 siblings, 0 replies; 243+ messages in thread
From: Tomi Valkeinen @ 2020-08-19 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, eric, hjc, heiko,
thierry.reding, jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
Hi,
On 13/08/2020 11:36, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
omap_gem_free_object() can also be made static, and removed from omap_gem.h.
Tested on AM5 EVM.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-19 10:43 ` Tomi Valkeinen
0 siblings, 0 replies; 243+ messages in thread
From: Tomi Valkeinen @ 2020-08-19 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, eric, hjc, heiko,
thierry.reding, jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 13/08/2020 11:36, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
omap_gem_free_object() can also be made static, and removed from omap_gem.h.
Tested on AM5 EVM.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-19 10:43 ` Tomi Valkeinen
0 siblings, 0 replies; 243+ messages in thread
From: Tomi Valkeinen @ 2020-08-19 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, eric, hjc, heiko,
thierry.reding, jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 13/08/2020 11:36, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
omap_gem_free_object() can also be made static, and removed from omap_gem.h.
Tested on AM5 EVM.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-19 10:43 ` Tomi Valkeinen
0 siblings, 0 replies; 243+ messages in thread
From: Tomi Valkeinen @ 2020-08-19 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, eric, hjc, heiko,
thierry.reding, jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 13/08/2020 11:36, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
omap_gem_free_object() can also be made static, and removed from omap_gem.h.
Tested on AM5 EVM.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-19 10:43 ` Tomi Valkeinen
0 siblings, 0 replies; 243+ messages in thread
From: Tomi Valkeinen @ 2020-08-19 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, eric, hjc, heiko,
thierry.reding, jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 13/08/2020 11:36, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
omap_gem_free_object() can also be made static, and removed from omap_gem.h.
Tested on AM5 EVM.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-19 10:43 ` Tomi Valkeinen
0 siblings, 0 replies; 243+ messages in thread
From: Tomi Valkeinen @ 2020-08-19 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, eric, hjc, heiko,
thierry.reding, jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushchenko, hyun.kwon, laurent.pinchart,
michal.simek, sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin,
marek.olsak, hdegoede, andrey.grodzovsky, Felix.Kuehling,
xinhui.pan, aaron.liu, nirmoy.das, chris, matthew.auld,
abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam, miaoqinglang,
emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 13/08/2020 11:36, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
omap_gem_free_object() can also be made static, and removed from omap_gem.h.
Tested on AM5 EVM.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 10/20] drm/omapdrm: Introduce GEM object functions
@ 2020-08-19 10:43 ` Tomi Valkeinen
0 siblings, 0 replies; 243+ messages in thread
From: Tomi Valkeinen @ 2020-08-19 10:43 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, eric, hjc, heiko,
thierry.reding, jonathanh, rodrigosiqueiramelo, hamohammed.sa,
oleksandr_andrushch
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
Hi,
On 13/08/2020 11:36, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in omapdrm.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 ---------
> drivers/gpu/drm/omapdrm/omap_gem.c | 16 +++++++++++++++-
> drivers/gpu/drm/omapdrm/omap_gem.h | 1 -
> 3 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index 53d5e184ee77..2e598b8b72af 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -521,12 +521,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file)
> return 0;
> }
>
> -static const struct vm_operations_struct omap_gem_vm_ops = {
> - .fault = omap_gem_fault,
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static const struct file_operations omapdriver_fops = {
> .owner = THIS_MODULE,
> .open = drm_open,
> @@ -549,10 +543,7 @@ static struct drm_driver omap_drm_driver = {
> #endif
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = omap_gem_prime_export,
> .gem_prime_import = omap_gem_prime_import,
> - .gem_free_object_unlocked = omap_gem_free_object,
> - .gem_vm_ops = &omap_gem_vm_ops,
> .dumb_create = omap_gem_dumb_create,
> .dumb_map_offset = omap_gem_dumb_map_offset,
> .ioctls = ioctls,
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index d0d12d5dd76c..d68dc63dea0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -487,7 +487,7 @@ static vm_fault_t omap_gem_fault_2d(struct drm_gem_object *obj,
> * vma->vm_private_data points to the GEM object that is backing this
> * mapping.
> */
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> +static vm_fault_t omap_gem_fault(struct vm_fault *vmf)
> {
> struct vm_area_struct *vma = vmf->vma;
> struct drm_gem_object *obj = vma->vm_private_data;
> @@ -1169,6 +1169,18 @@ static bool omap_gem_validate_flags(struct drm_device *dev, u32 flags)
> return true;
> }
>
> +static const struct vm_operations_struct omap_gem_vm_ops = {
> + .fault = omap_gem_fault,
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs omap_gem_object_funcs = {
> + .free = omap_gem_free_object,
> + .export = omap_gem_prime_export,
> + .vm_ops = &omap_gem_vm_ops,
> +};
> +
> /* GEM buffer object constructor */
> struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> union omap_gem_size gsize, u32 flags)
> @@ -1236,6 +1248,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
> size = PAGE_ALIGN(gsize.bytes);
> }
>
> + obj->funcs = &omap_gem_object_funcs;
> +
> /* Initialize the GEM object. */
> if (!(flags & OMAP_BO_MEM_SHMEM)) {
> drm_gem_private_object_init(dev, obj, size);
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.h b/drivers/gpu/drm/omapdrm/omap_gem.h
> index 729b7812a815..9e6b5c8195d9 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.h
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.h
> @@ -69,7 +69,6 @@ struct dma_buf *omap_gem_prime_export(struct drm_gem_object *obj, int flags);
> struct drm_gem_object *omap_gem_prime_import(struct drm_device *dev,
> struct dma_buf *buffer);
>
> -vm_fault_t omap_gem_fault(struct vm_fault *vmf);
> int omap_gem_roll(struct drm_gem_object *obj, u32 roll);
> void omap_gem_cpu_sync_page(struct drm_gem_object *obj, int pgoff);
> void omap_gem_dma_sync_buffer(struct drm_gem_object *obj,
omap_gem_free_object() can also be made static, and removed from omap_gem.h.
Tested on AM5 EVM.
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 11/20] drm/pl111: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in pl111. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/pl111/pl111_drv.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index 46b0d1c4a16c..00b605060336 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -211,6 +211,29 @@ pl111_gem_import_sg_table(struct drm_device *dev,
return drm_gem_cma_prime_import_sg_table(dev, attach, sgt);
}
+static const struct drm_gem_object_funcs pl111_gem_object_funcs = {
+ .free = drm_gem_cma_free_object,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = drm_gem_cma_prime_vmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
+static struct drm_gem_object *
+pl111_gem_create_object(struct drm_device *dev, size_t size)
+{
+ static struct drm_gem_cma_object *cma_obj;
+ struct drm_gem_object *obj;
+
+ cma_obj = kzalloc(sizeof(*cma_obj), GFP_KERNEL);
+ if (!cma_obj)
+ return NULL;
+
+ obj = &cma_obj->base;
+ obj->funcs = &pl111_gem_object_funcs;
+
+ return obj;
+}
+
DEFINE_DRM_GEM_CMA_FOPS(drm_fops);
static struct drm_driver pl111_drm_driver = {
@@ -224,15 +247,12 @@ static struct drm_driver pl111_drm_driver = {
.major = 1,
.minor = 0,
.patchlevel = 0,
+ .gem_create_object = pl111_gem_create_object,
.dumb_create = drm_gem_cma_dumb_create,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = pl111_gem_import_sg_table,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
#if defined(CONFIG_DEBUG_FS)
.debugfs_init = pl111_debugfs_init,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 11/20] drm/pl111: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in pl111. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/pl111/pl111_drv.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index 46b0d1c4a16c..00b605060336 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -211,6 +211,29 @@ pl111_gem_import_sg_table(struct drm_device *dev,
return drm_gem_cma_prime_import_sg_table(dev, attach, sgt);
}
+static const struct drm_gem_object_funcs pl111_gem_object_funcs = {
+ .free = drm_gem_cma_free_object,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = drm_gem_cma_prime_vmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
+static struct drm_gem_object *
+pl111_gem_create_object(struct drm_device *dev, size_t size)
+{
+ static struct drm_gem_cma_object *cma_obj;
+ struct drm_gem_object *obj;
+
+ cma_obj = kzalloc(sizeof(*cma_obj), GFP_KERNEL);
+ if (!cma_obj)
+ return NULL;
+
+ obj = &cma_obj->base;
+ obj->funcs = &pl111_gem_object_funcs;
+
+ return obj;
+}
+
DEFINE_DRM_GEM_CMA_FOPS(drm_fops);
static struct drm_driver pl111_drm_driver = {
@@ -224,15 +247,12 @@ static struct drm_driver pl111_drm_driver = {
.major = 1,
.minor = 0,
.patchlevel = 0,
+ .gem_create_object = pl111_gem_create_object,
.dumb_create = drm_gem_cma_dumb_create,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = pl111_gem_import_sg_table,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
#if defined(CONFIG_DEBUG_FS)
.debugfs_init = pl111_debugfs_init,
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 11/20] drm/pl111: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in pl111. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/pl111/pl111_drv.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index 46b0d1c4a16c..00b605060336 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -211,6 +211,29 @@ pl111_gem_import_sg_table(struct drm_device *dev,
return drm_gem_cma_prime_import_sg_table(dev, attach, sgt);
}
+static const struct drm_gem_object_funcs pl111_gem_object_funcs = {
+ .free = drm_gem_cma_free_object,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = drm_gem_cma_prime_vmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
+static struct drm_gem_object *
+pl111_gem_create_object(struct drm_device *dev, size_t size)
+{
+ static struct drm_gem_cma_object *cma_obj;
+ struct drm_gem_object *obj;
+
+ cma_obj = kzalloc(sizeof(*cma_obj), GFP_KERNEL);
+ if (!cma_obj)
+ return NULL;
+
+ obj = &cma_obj->base;
+ obj->funcs = &pl111_gem_object_funcs;
+
+ return obj;
+}
+
DEFINE_DRM_GEM_CMA_FOPS(drm_fops);
static struct drm_driver pl111_drm_driver = {
@@ -224,15 +247,12 @@ static struct drm_driver pl111_drm_driver = {
.major = 1,
.minor = 0,
.patchlevel = 0,
+ .gem_create_object = pl111_gem_create_object,
.dumb_create = drm_gem_cma_dumb_create,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = pl111_gem_import_sg_table,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
#if defined(CONFIG_DEBUG_FS)
.debugfs_init = pl111_debugfs_init,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 11/20] drm/pl111: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in pl111. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/pl111/pl111_drv.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index 46b0d1c4a16c..00b605060336 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -211,6 +211,29 @@ pl111_gem_import_sg_table(struct drm_device *dev,
return drm_gem_cma_prime_import_sg_table(dev, attach, sgt);
}
+static const struct drm_gem_object_funcs pl111_gem_object_funcs = {
+ .free = drm_gem_cma_free_object,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = drm_gem_cma_prime_vmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
+static struct drm_gem_object *
+pl111_gem_create_object(struct drm_device *dev, size_t size)
+{
+ static struct drm_gem_cma_object *cma_obj;
+ struct drm_gem_object *obj;
+
+ cma_obj = kzalloc(sizeof(*cma_obj), GFP_KERNEL);
+ if (!cma_obj)
+ return NULL;
+
+ obj = &cma_obj->base;
+ obj->funcs = &pl111_gem_object_funcs;
+
+ return obj;
+}
+
DEFINE_DRM_GEM_CMA_FOPS(drm_fops);
static struct drm_driver pl111_drm_driver = {
@@ -224,15 +247,12 @@ static struct drm_driver pl111_drm_driver = {
.major = 1,
.minor = 0,
.patchlevel = 0,
+ .gem_create_object = pl111_gem_create_object,
.dumb_create = drm_gem_cma_dumb_create,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = pl111_gem_import_sg_table,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
#if defined(CONFIG_DEBUG_FS)
.debugfs_init = pl111_debugfs_init,
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 11/20] drm/pl111: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in pl111. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/pl111/pl111_drv.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index 46b0d1c4a16c..00b605060336 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -211,6 +211,29 @@ pl111_gem_import_sg_table(struct drm_device *dev,
return drm_gem_cma_prime_import_sg_table(dev, attach, sgt);
}
+static const struct drm_gem_object_funcs pl111_gem_object_funcs = {
+ .free = drm_gem_cma_free_object,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = drm_gem_cma_prime_vmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
+static struct drm_gem_object *
+pl111_gem_create_object(struct drm_device *dev, size_t size)
+{
+ static struct drm_gem_cma_object *cma_obj;
+ struct drm_gem_object *obj;
+
+ cma_obj = kzalloc(sizeof(*cma_obj), GFP_KERNEL);
+ if (!cma_obj)
+ return NULL;
+
+ obj = &cma_obj->base;
+ obj->funcs = &pl111_gem_object_funcs;
+
+ return obj;
+}
+
DEFINE_DRM_GEM_CMA_FOPS(drm_fops);
static struct drm_driver pl111_drm_driver = {
@@ -224,15 +247,12 @@ static struct drm_driver pl111_drm_driver = {
.major = 1,
.minor = 0,
.patchlevel = 0,
+ .gem_create_object = pl111_gem_create_object,
.dumb_create = drm_gem_cma_dumb_create,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = pl111_gem_import_sg_table,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
#if defined(CONFIG_DEBUG_FS)
.debugfs_init = pl111_debugfs_init,
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 11/20] drm/pl111: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in pl111. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/pl111/pl111_drv.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c
index 46b0d1c4a16c..00b605060336 100644
--- a/drivers/gpu/drm/pl111/pl111_drv.c
+++ b/drivers/gpu/drm/pl111/pl111_drv.c
@@ -211,6 +211,29 @@ pl111_gem_import_sg_table(struct drm_device *dev,
return drm_gem_cma_prime_import_sg_table(dev, attach, sgt);
}
+static const struct drm_gem_object_funcs pl111_gem_object_funcs = {
+ .free = drm_gem_cma_free_object,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = drm_gem_cma_prime_vmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
+static struct drm_gem_object *
+pl111_gem_create_object(struct drm_device *dev, size_t size)
+{
+ static struct drm_gem_cma_object *cma_obj;
+ struct drm_gem_object *obj;
+
+ cma_obj = kzalloc(sizeof(*cma_obj), GFP_KERNEL);
+ if (!cma_obj)
+ return NULL;
+
+ obj = &cma_obj->base;
+ obj->funcs = &pl111_gem_object_funcs;
+
+ return obj;
+}
+
DEFINE_DRM_GEM_CMA_FOPS(drm_fops);
static struct drm_driver pl111_drm_driver = {
@@ -224,15 +247,12 @@ static struct drm_driver pl111_drm_driver = {
.major = 1,
.minor = 0,
.patchlevel = 0,
+ .gem_create_object = pl111_gem_create_object,
.dumb_create = drm_gem_cma_dumb_create,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = pl111_gem_import_sg_table,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
#if defined(CONFIG_DEBUG_FS)
.debugfs_init = pl111_debugfs_init,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in radeon.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 4cd30613fa1d..65061c949aee 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
-void radeon_gem_object_free(struct drm_gem_object *obj);
-int radeon_gem_object_open(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-void radeon_gem_object_close(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
- int flags);
extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
unsigned int flags, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime,
@@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args);
-struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
struct dma_buf_attachment *,
struct sg_table *sg);
-int radeon_gem_prime_pin(struct drm_gem_object *obj);
-void radeon_gem_prime_unpin(struct drm_gem_object *obj);
-void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
-void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
/* atpx handler */
#if defined(CONFIG_VGA_SWITCHEROO)
@@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
}
ret = drm_ioctl(filp, cmd, arg);
-
+
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);
return ret;
@@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
.irq_uninstall = radeon_driver_irq_uninstall_kms,
.irq_handler = radeon_driver_irq_handler_kms,
.ioctls = radeon_ioctls_kms,
- .gem_free_object_unlocked = radeon_gem_object_free,
- .gem_open_object = radeon_gem_object_open,
- .gem_close_object = radeon_gem_object_close,
.dumb_create = radeon_mode_dumb_create,
.dumb_map_offset = radeon_mode_dumb_mmap,
.fops = &radeon_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = radeon_gem_prime_export,
- .gem_prime_pin = radeon_gem_prime_pin,
- .gem_prime_unpin = radeon_gem_prime_unpin,
- .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
.gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
- .gem_prime_vmap = radeon_gem_prime_vmap,
- .gem_prime_vunmap = radeon_gem_prime_vunmap,
.name = DRIVER_NAME,
.desc = DRIVER_DESC,
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index bb7582afd803..882390e15dfe 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
void radeon_ttm_fini(struct radeon_device *rdev);
static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
+void radeon_gem_object_free(struct drm_gem_object *obj);
+int radeon_gem_object_open(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+void radeon_gem_object_close(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
+ int flags);
+struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
+int radeon_gem_prime_pin(struct drm_gem_object *obj);
+void radeon_gem_prime_unpin(struct drm_gem_object *obj);
+void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
+void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
+
/*
* To exclude mutual BO access we rely on bo_reserve exclusion, as all
* function are calling it.
@@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
}
+static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
+ .free = radeon_gem_object_free,
+ .open = radeon_gem_object_open,
+ .close = radeon_gem_object_close,
+ .export = radeon_gem_prime_export,
+ .pin = radeon_gem_prime_pin,
+ .unpin = radeon_gem_prime_unpin,
+ .get_sg_table = radeon_gem_prime_get_sg_table,
+ .vmap = radeon_gem_prime_vmap,
+ .vunmap = radeon_gem_prime_vunmap,
+};
+
int radeon_bo_create(struct radeon_device *rdev,
unsigned long size, int byte_align, bool kernel,
u32 domain, u32 flags, struct sg_table *sg,
@@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+ bo->tbo.base.funcs = &radeon_gem_object_funcs;
drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
bo->rdev = rdev;
bo->surface_reg = -1;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in radeon.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 4cd30613fa1d..65061c949aee 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
-void radeon_gem_object_free(struct drm_gem_object *obj);
-int radeon_gem_object_open(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-void radeon_gem_object_close(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
- int flags);
extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
unsigned int flags, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime,
@@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args);
-struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
struct dma_buf_attachment *,
struct sg_table *sg);
-int radeon_gem_prime_pin(struct drm_gem_object *obj);
-void radeon_gem_prime_unpin(struct drm_gem_object *obj);
-void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
-void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
/* atpx handler */
#if defined(CONFIG_VGA_SWITCHEROO)
@@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
}
ret = drm_ioctl(filp, cmd, arg);
-
+
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);
return ret;
@@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
.irq_uninstall = radeon_driver_irq_uninstall_kms,
.irq_handler = radeon_driver_irq_handler_kms,
.ioctls = radeon_ioctls_kms,
- .gem_free_object_unlocked = radeon_gem_object_free,
- .gem_open_object = radeon_gem_object_open,
- .gem_close_object = radeon_gem_object_close,
.dumb_create = radeon_mode_dumb_create,
.dumb_map_offset = radeon_mode_dumb_mmap,
.fops = &radeon_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = radeon_gem_prime_export,
- .gem_prime_pin = radeon_gem_prime_pin,
- .gem_prime_unpin = radeon_gem_prime_unpin,
- .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
.gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
- .gem_prime_vmap = radeon_gem_prime_vmap,
- .gem_prime_vunmap = radeon_gem_prime_vunmap,
.name = DRIVER_NAME,
.desc = DRIVER_DESC,
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index bb7582afd803..882390e15dfe 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
void radeon_ttm_fini(struct radeon_device *rdev);
static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
+void radeon_gem_object_free(struct drm_gem_object *obj);
+int radeon_gem_object_open(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+void radeon_gem_object_close(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
+ int flags);
+struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
+int radeon_gem_prime_pin(struct drm_gem_object *obj);
+void radeon_gem_prime_unpin(struct drm_gem_object *obj);
+void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
+void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
+
/*
* To exclude mutual BO access we rely on bo_reserve exclusion, as all
* function are calling it.
@@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
}
+static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
+ .free = radeon_gem_object_free,
+ .open = radeon_gem_object_open,
+ .close = radeon_gem_object_close,
+ .export = radeon_gem_prime_export,
+ .pin = radeon_gem_prime_pin,
+ .unpin = radeon_gem_prime_unpin,
+ .get_sg_table = radeon_gem_prime_get_sg_table,
+ .vmap = radeon_gem_prime_vmap,
+ .vunmap = radeon_gem_prime_vunmap,
+};
+
int radeon_bo_create(struct radeon_device *rdev,
unsigned long size, int byte_align, bool kernel,
u32 domain, u32 flags, struct sg_table *sg,
@@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+ bo->tbo.base.funcs = &radeon_gem_object_funcs;
drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
bo->rdev = rdev;
bo->surface_reg = -1;
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in radeon.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 4cd30613fa1d..65061c949aee 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
-void radeon_gem_object_free(struct drm_gem_object *obj);
-int radeon_gem_object_open(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-void radeon_gem_object_close(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
- int flags);
extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
unsigned int flags, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime,
@@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args);
-struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
struct dma_buf_attachment *,
struct sg_table *sg);
-int radeon_gem_prime_pin(struct drm_gem_object *obj);
-void radeon_gem_prime_unpin(struct drm_gem_object *obj);
-void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
-void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
/* atpx handler */
#if defined(CONFIG_VGA_SWITCHEROO)
@@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
}
ret = drm_ioctl(filp, cmd, arg);
-
+
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);
return ret;
@@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
.irq_uninstall = radeon_driver_irq_uninstall_kms,
.irq_handler = radeon_driver_irq_handler_kms,
.ioctls = radeon_ioctls_kms,
- .gem_free_object_unlocked = radeon_gem_object_free,
- .gem_open_object = radeon_gem_object_open,
- .gem_close_object = radeon_gem_object_close,
.dumb_create = radeon_mode_dumb_create,
.dumb_map_offset = radeon_mode_dumb_mmap,
.fops = &radeon_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = radeon_gem_prime_export,
- .gem_prime_pin = radeon_gem_prime_pin,
- .gem_prime_unpin = radeon_gem_prime_unpin,
- .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
.gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
- .gem_prime_vmap = radeon_gem_prime_vmap,
- .gem_prime_vunmap = radeon_gem_prime_vunmap,
.name = DRIVER_NAME,
.desc = DRIVER_DESC,
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index bb7582afd803..882390e15dfe 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
void radeon_ttm_fini(struct radeon_device *rdev);
static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
+void radeon_gem_object_free(struct drm_gem_object *obj);
+int radeon_gem_object_open(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+void radeon_gem_object_close(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
+ int flags);
+struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
+int radeon_gem_prime_pin(struct drm_gem_object *obj);
+void radeon_gem_prime_unpin(struct drm_gem_object *obj);
+void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
+void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
+
/*
* To exclude mutual BO access we rely on bo_reserve exclusion, as all
* function are calling it.
@@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
}
+static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
+ .free = radeon_gem_object_free,
+ .open = radeon_gem_object_open,
+ .close = radeon_gem_object_close,
+ .export = radeon_gem_prime_export,
+ .pin = radeon_gem_prime_pin,
+ .unpin = radeon_gem_prime_unpin,
+ .get_sg_table = radeon_gem_prime_get_sg_table,
+ .vmap = radeon_gem_prime_vmap,
+ .vunmap = radeon_gem_prime_vunmap,
+};
+
int radeon_bo_create(struct radeon_device *rdev,
unsigned long size, int byte_align, bool kernel,
u32 domain, u32 flags, struct sg_table *sg,
@@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+ bo->tbo.base.funcs = &radeon_gem_object_funcs;
drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
bo->rdev = rdev;
bo->surface_reg = -1;
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in radeon.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 4cd30613fa1d..65061c949aee 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
-void radeon_gem_object_free(struct drm_gem_object *obj);
-int radeon_gem_object_open(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-void radeon_gem_object_close(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
- int flags);
extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
unsigned int flags, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime,
@@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args);
-struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
struct dma_buf_attachment *,
struct sg_table *sg);
-int radeon_gem_prime_pin(struct drm_gem_object *obj);
-void radeon_gem_prime_unpin(struct drm_gem_object *obj);
-void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
-void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
/* atpx handler */
#if defined(CONFIG_VGA_SWITCHEROO)
@@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
}
ret = drm_ioctl(filp, cmd, arg);
-
+
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);
return ret;
@@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
.irq_uninstall = radeon_driver_irq_uninstall_kms,
.irq_handler = radeon_driver_irq_handler_kms,
.ioctls = radeon_ioctls_kms,
- .gem_free_object_unlocked = radeon_gem_object_free,
- .gem_open_object = radeon_gem_object_open,
- .gem_close_object = radeon_gem_object_close,
.dumb_create = radeon_mode_dumb_create,
.dumb_map_offset = radeon_mode_dumb_mmap,
.fops = &radeon_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = radeon_gem_prime_export,
- .gem_prime_pin = radeon_gem_prime_pin,
- .gem_prime_unpin = radeon_gem_prime_unpin,
- .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
.gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
- .gem_prime_vmap = radeon_gem_prime_vmap,
- .gem_prime_vunmap = radeon_gem_prime_vunmap,
.name = DRIVER_NAME,
.desc = DRIVER_DESC,
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index bb7582afd803..882390e15dfe 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
void radeon_ttm_fini(struct radeon_device *rdev);
static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
+void radeon_gem_object_free(struct drm_gem_object *obj);
+int radeon_gem_object_open(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+void radeon_gem_object_close(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
+ int flags);
+struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
+int radeon_gem_prime_pin(struct drm_gem_object *obj);
+void radeon_gem_prime_unpin(struct drm_gem_object *obj);
+void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
+void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
+
/*
* To exclude mutual BO access we rely on bo_reserve exclusion, as all
* function are calling it.
@@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
}
+static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
+ .free = radeon_gem_object_free,
+ .open = radeon_gem_object_open,
+ .close = radeon_gem_object_close,
+ .export = radeon_gem_prime_export,
+ .pin = radeon_gem_prime_pin,
+ .unpin = radeon_gem_prime_unpin,
+ .get_sg_table = radeon_gem_prime_get_sg_table,
+ .vmap = radeon_gem_prime_vmap,
+ .vunmap = radeon_gem_prime_vunmap,
+};
+
int radeon_bo_create(struct radeon_device *rdev,
unsigned long size, int byte_align, bool kernel,
u32 domain, u32 flags, struct sg_table *sg,
@@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+ bo->tbo.base.funcs = &radeon_gem_object_funcs;
drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
bo->rdev = rdev;
bo->surface_reg = -1;
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in radeon.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 4cd30613fa1d..65061c949aee 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
-void radeon_gem_object_free(struct drm_gem_object *obj);
-int radeon_gem_object_open(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-void radeon_gem_object_close(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
- int flags);
extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
unsigned int flags, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime,
@@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args);
-struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
struct dma_buf_attachment *,
struct sg_table *sg);
-int radeon_gem_prime_pin(struct drm_gem_object *obj);
-void radeon_gem_prime_unpin(struct drm_gem_object *obj);
-void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
-void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
/* atpx handler */
#if defined(CONFIG_VGA_SWITCHEROO)
@@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
}
ret = drm_ioctl(filp, cmd, arg);
-
+
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);
return ret;
@@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
.irq_uninstall = radeon_driver_irq_uninstall_kms,
.irq_handler = radeon_driver_irq_handler_kms,
.ioctls = radeon_ioctls_kms,
- .gem_free_object_unlocked = radeon_gem_object_free,
- .gem_open_object = radeon_gem_object_open,
- .gem_close_object = radeon_gem_object_close,
.dumb_create = radeon_mode_dumb_create,
.dumb_map_offset = radeon_mode_dumb_mmap,
.fops = &radeon_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = radeon_gem_prime_export,
- .gem_prime_pin = radeon_gem_prime_pin,
- .gem_prime_unpin = radeon_gem_prime_unpin,
- .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
.gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
- .gem_prime_vmap = radeon_gem_prime_vmap,
- .gem_prime_vunmap = radeon_gem_prime_vunmap,
.name = DRIVER_NAME,
.desc = DRIVER_DESC,
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index bb7582afd803..882390e15dfe 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
void radeon_ttm_fini(struct radeon_device *rdev);
static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
+void radeon_gem_object_free(struct drm_gem_object *obj);
+int radeon_gem_object_open(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+void radeon_gem_object_close(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
+ int flags);
+struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
+int radeon_gem_prime_pin(struct drm_gem_object *obj);
+void radeon_gem_prime_unpin(struct drm_gem_object *obj);
+void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
+void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
+
/*
* To exclude mutual BO access we rely on bo_reserve exclusion, as all
* function are calling it.
@@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
}
+static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
+ .free = radeon_gem_object_free,
+ .open = radeon_gem_object_open,
+ .close = radeon_gem_object_close,
+ .export = radeon_gem_prime_export,
+ .pin = radeon_gem_prime_pin,
+ .unpin = radeon_gem_prime_unpin,
+ .get_sg_table = radeon_gem_prime_get_sg_table,
+ .vmap = radeon_gem_prime_vmap,
+ .vunmap = radeon_gem_prime_vunmap,
+};
+
int radeon_bo_create(struct radeon_device *rdev,
unsigned long size, int byte_align, bool kernel,
u32 domain, u32 flags, struct sg_table *sg,
@@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+ bo->tbo.base.funcs = &radeon_gem_object_funcs;
drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
bo->rdev = rdev;
bo->surface_reg = -1;
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in radeon.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
2 files changed, 27 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 4cd30613fa1d..65061c949aee 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
-void radeon_gem_object_free(struct drm_gem_object *obj);
-int radeon_gem_object_open(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-void radeon_gem_object_close(struct drm_gem_object *obj,
- struct drm_file *file_priv);
-struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
- int flags);
extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
unsigned int flags, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime,
@@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
int radeon_mode_dumb_create(struct drm_file *file_priv,
struct drm_device *dev,
struct drm_mode_create_dumb *args);
-struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
struct dma_buf_attachment *,
struct sg_table *sg);
-int radeon_gem_prime_pin(struct drm_gem_object *obj);
-void radeon_gem_prime_unpin(struct drm_gem_object *obj);
-void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
-void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
/* atpx handler */
#if defined(CONFIG_VGA_SWITCHEROO)
@@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
}
ret = drm_ioctl(filp, cmd, arg);
-
+
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);
return ret;
@@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
.irq_uninstall = radeon_driver_irq_uninstall_kms,
.irq_handler = radeon_driver_irq_handler_kms,
.ioctls = radeon_ioctls_kms,
- .gem_free_object_unlocked = radeon_gem_object_free,
- .gem_open_object = radeon_gem_object_open,
- .gem_close_object = radeon_gem_object_close,
.dumb_create = radeon_mode_dumb_create,
.dumb_map_offset = radeon_mode_dumb_mmap,
.fops = &radeon_driver_kms_fops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = radeon_gem_prime_export,
- .gem_prime_pin = radeon_gem_prime_pin,
- .gem_prime_unpin = radeon_gem_prime_unpin,
- .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
.gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
- .gem_prime_vmap = radeon_gem_prime_vmap,
- .gem_prime_vunmap = radeon_gem_prime_vunmap,
.name = DRIVER_NAME,
.desc = DRIVER_DESC,
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index bb7582afd803..882390e15dfe 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
void radeon_ttm_fini(struct radeon_device *rdev);
static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
+void radeon_gem_object_free(struct drm_gem_object *obj);
+int radeon_gem_object_open(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+void radeon_gem_object_close(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
+struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
+ int flags);
+struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
+int radeon_gem_prime_pin(struct drm_gem_object *obj);
+void radeon_gem_prime_unpin(struct drm_gem_object *obj);
+void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
+void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
+
/*
* To exclude mutual BO access we rely on bo_reserve exclusion, as all
* function are calling it.
@@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
}
}
+static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
+ .free = radeon_gem_object_free,
+ .open = radeon_gem_object_open,
+ .close = radeon_gem_object_close,
+ .export = radeon_gem_prime_export,
+ .pin = radeon_gem_prime_pin,
+ .unpin = radeon_gem_prime_unpin,
+ .get_sg_table = radeon_gem_prime_get_sg_table,
+ .vmap = radeon_gem_prime_vmap,
+ .vunmap = radeon_gem_prime_vunmap,
+};
+
int radeon_bo_create(struct radeon_device *rdev,
unsigned long size, int byte_align, bool kernel,
u32 domain, u32 flags, struct sg_table *sg,
@@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
if (bo == NULL)
return -ENOMEM;
+ bo->tbo.base.funcs = &radeon_gem_object_funcs;
drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
bo->rdev = rdev;
bo->surface_reg = -1;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:24 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:24 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in radeon.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 4cd30613fa1d..65061c949aee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
> -void radeon_gem_object_free(struct drm_gem_object *obj);
> -int radeon_gem_object_open(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -void radeon_gem_object_close(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> - int flags);
> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
> unsigned int flags, int *vpos, int *hpos,
> ktime_t *stime, ktime_t *etime,
> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
> int radeon_mode_dumb_create(struct drm_file *file_priv,
> struct drm_device *dev,
> struct drm_mode_create_dumb *args);
> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *,
> struct sg_table *sg);
> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>
> /* atpx handler */
> #if defined(CONFIG_VGA_SWITCHEROO)
> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
> }
>
> ret = drm_ioctl(filp, cmd, arg);
> -
> +
> pm_runtime_mark_last_busy(dev->dev);
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
> .irq_uninstall = radeon_driver_irq_uninstall_kms,
> .irq_handler = radeon_driver_irq_handler_kms,
> .ioctls = radeon_ioctls_kms,
> - .gem_free_object_unlocked = radeon_gem_object_free,
> - .gem_open_object = radeon_gem_object_open,
> - .gem_close_object = radeon_gem_object_close,
> .dumb_create = radeon_mode_dumb_create,
> .dumb_map_offset = radeon_mode_dumb_mmap,
> .fops = &radeon_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = radeon_gem_prime_export,
> - .gem_prime_pin = radeon_gem_prime_pin,
> - .gem_prime_unpin = radeon_gem_prime_unpin,
> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
> - .gem_prime_vmap = radeon_gem_prime_vmap,
> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>
> .name = DRIVER_NAME,
> .desc = DRIVER_DESC,
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index bb7582afd803..882390e15dfe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
> void radeon_ttm_fini(struct radeon_device *rdev);
> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>
> +void radeon_gem_object_free(struct drm_gem_object *obj);
> +int radeon_gem_object_open(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +void radeon_gem_object_close(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> + int flags);
> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
> +
> /*
> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
> * function are calling it.
> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
> }
>
> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
> + .free = radeon_gem_object_free,
> + .open = radeon_gem_object_open,
> + .close = radeon_gem_object_close,
> + .export = radeon_gem_prime_export,
> + .pin = radeon_gem_prime_pin,
> + .unpin = radeon_gem_prime_unpin,
> + .get_sg_table = radeon_gem_prime_get_sg_table,
> + .vmap = radeon_gem_prime_vmap,
> + .vunmap = radeon_gem_prime_vunmap,
> +};
> +
Same comment as for amdgpu, please put that into radeon_gem.c instead.
Christian.
> int radeon_bo_create(struct radeon_device *rdev,
> unsigned long size, int byte_align, bool kernel,
> u32 domain, u32 flags, struct sg_table *sg,
> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
> bo->rdev = rdev;
> bo->surface_reg = -1;
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:24 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:24 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in radeon.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 4cd30613fa1d..65061c949aee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
> -void radeon_gem_object_free(struct drm_gem_object *obj);
> -int radeon_gem_object_open(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -void radeon_gem_object_close(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> - int flags);
> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
> unsigned int flags, int *vpos, int *hpos,
> ktime_t *stime, ktime_t *etime,
> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
> int radeon_mode_dumb_create(struct drm_file *file_priv,
> struct drm_device *dev,
> struct drm_mode_create_dumb *args);
> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *,
> struct sg_table *sg);
> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>
> /* atpx handler */
> #if defined(CONFIG_VGA_SWITCHEROO)
> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
> }
>
> ret = drm_ioctl(filp, cmd, arg);
> -
> +
> pm_runtime_mark_last_busy(dev->dev);
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
> .irq_uninstall = radeon_driver_irq_uninstall_kms,
> .irq_handler = radeon_driver_irq_handler_kms,
> .ioctls = radeon_ioctls_kms,
> - .gem_free_object_unlocked = radeon_gem_object_free,
> - .gem_open_object = radeon_gem_object_open,
> - .gem_close_object = radeon_gem_object_close,
> .dumb_create = radeon_mode_dumb_create,
> .dumb_map_offset = radeon_mode_dumb_mmap,
> .fops = &radeon_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = radeon_gem_prime_export,
> - .gem_prime_pin = radeon_gem_prime_pin,
> - .gem_prime_unpin = radeon_gem_prime_unpin,
> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
> - .gem_prime_vmap = radeon_gem_prime_vmap,
> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>
> .name = DRIVER_NAME,
> .desc = DRIVER_DESC,
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index bb7582afd803..882390e15dfe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
> void radeon_ttm_fini(struct radeon_device *rdev);
> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>
> +void radeon_gem_object_free(struct drm_gem_object *obj);
> +int radeon_gem_object_open(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +void radeon_gem_object_close(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> + int flags);
> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
> +
> /*
> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
> * function are calling it.
> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
> }
>
> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
> + .free = radeon_gem_object_free,
> + .open = radeon_gem_object_open,
> + .close = radeon_gem_object_close,
> + .export = radeon_gem_prime_export,
> + .pin = radeon_gem_prime_pin,
> + .unpin = radeon_gem_prime_unpin,
> + .get_sg_table = radeon_gem_prime_get_sg_table,
> + .vmap = radeon_gem_prime_vmap,
> + .vunmap = radeon_gem_prime_vunmap,
> +};
> +
Same comment as for amdgpu, please put that into radeon_gem.c instead.
Christian.
> int radeon_bo_create(struct radeon_device *rdev,
> unsigned long size, int byte_align, bool kernel,
> u32 domain, u32 flags, struct sg_table *sg,
> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
> bo->rdev = rdev;
> bo->surface_reg = -1;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:24 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:24 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in radeon.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 4cd30613fa1d..65061c949aee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
> -void radeon_gem_object_free(struct drm_gem_object *obj);
> -int radeon_gem_object_open(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -void radeon_gem_object_close(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> - int flags);
> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
> unsigned int flags, int *vpos, int *hpos,
> ktime_t *stime, ktime_t *etime,
> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
> int radeon_mode_dumb_create(struct drm_file *file_priv,
> struct drm_device *dev,
> struct drm_mode_create_dumb *args);
> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *,
> struct sg_table *sg);
> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>
> /* atpx handler */
> #if defined(CONFIG_VGA_SWITCHEROO)
> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
> }
>
> ret = drm_ioctl(filp, cmd, arg);
> -
> +
> pm_runtime_mark_last_busy(dev->dev);
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
> .irq_uninstall = radeon_driver_irq_uninstall_kms,
> .irq_handler = radeon_driver_irq_handler_kms,
> .ioctls = radeon_ioctls_kms,
> - .gem_free_object_unlocked = radeon_gem_object_free,
> - .gem_open_object = radeon_gem_object_open,
> - .gem_close_object = radeon_gem_object_close,
> .dumb_create = radeon_mode_dumb_create,
> .dumb_map_offset = radeon_mode_dumb_mmap,
> .fops = &radeon_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = radeon_gem_prime_export,
> - .gem_prime_pin = radeon_gem_prime_pin,
> - .gem_prime_unpin = radeon_gem_prime_unpin,
> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
> - .gem_prime_vmap = radeon_gem_prime_vmap,
> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>
> .name = DRIVER_NAME,
> .desc = DRIVER_DESC,
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index bb7582afd803..882390e15dfe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
> void radeon_ttm_fini(struct radeon_device *rdev);
> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>
> +void radeon_gem_object_free(struct drm_gem_object *obj);
> +int radeon_gem_object_open(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +void radeon_gem_object_close(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> + int flags);
> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
> +
> /*
> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
> * function are calling it.
> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
> }
>
> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
> + .free = radeon_gem_object_free,
> + .open = radeon_gem_object_open,
> + .close = radeon_gem_object_close,
> + .export = radeon_gem_prime_export,
> + .pin = radeon_gem_prime_pin,
> + .unpin = radeon_gem_prime_unpin,
> + .get_sg_table = radeon_gem_prime_get_sg_table,
> + .vmap = radeon_gem_prime_vmap,
> + .vunmap = radeon_gem_prime_vunmap,
> +};
> +
Same comment as for amdgpu, please put that into radeon_gem.c instead.
Christian.
> int radeon_bo_create(struct radeon_device *rdev,
> unsigned long size, int byte_align, bool kernel,
> u32 domain, u32 flags, struct sg_table *sg,
> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
> bo->rdev = rdev;
> bo->surface_reg = -1;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:24 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:24 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in radeon.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 4cd30613fa1d..65061c949aee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
> -void radeon_gem_object_free(struct drm_gem_object *obj);
> -int radeon_gem_object_open(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -void radeon_gem_object_close(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> - int flags);
> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
> unsigned int flags, int *vpos, int *hpos,
> ktime_t *stime, ktime_t *etime,
> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
> int radeon_mode_dumb_create(struct drm_file *file_priv,
> struct drm_device *dev,
> struct drm_mode_create_dumb *args);
> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *,
> struct sg_table *sg);
> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>
> /* atpx handler */
> #if defined(CONFIG_VGA_SWITCHEROO)
> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
> }
>
> ret = drm_ioctl(filp, cmd, arg);
> -
> +
> pm_runtime_mark_last_busy(dev->dev);
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
> .irq_uninstall = radeon_driver_irq_uninstall_kms,
> .irq_handler = radeon_driver_irq_handler_kms,
> .ioctls = radeon_ioctls_kms,
> - .gem_free_object_unlocked = radeon_gem_object_free,
> - .gem_open_object = radeon_gem_object_open,
> - .gem_close_object = radeon_gem_object_close,
> .dumb_create = radeon_mode_dumb_create,
> .dumb_map_offset = radeon_mode_dumb_mmap,
> .fops = &radeon_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = radeon_gem_prime_export,
> - .gem_prime_pin = radeon_gem_prime_pin,
> - .gem_prime_unpin = radeon_gem_prime_unpin,
> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
> - .gem_prime_vmap = radeon_gem_prime_vmap,
> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>
> .name = DRIVER_NAME,
> .desc = DRIVER_DESC,
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index bb7582afd803..882390e15dfe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
> void radeon_ttm_fini(struct radeon_device *rdev);
> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>
> +void radeon_gem_object_free(struct drm_gem_object *obj);
> +int radeon_gem_object_open(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +void radeon_gem_object_close(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> + int flags);
> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
> +
> /*
> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
> * function are calling it.
> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
> }
>
> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
> + .free = radeon_gem_object_free,
> + .open = radeon_gem_object_open,
> + .close = radeon_gem_object_close,
> + .export = radeon_gem_prime_export,
> + .pin = radeon_gem_prime_pin,
> + .unpin = radeon_gem_prime_unpin,
> + .get_sg_table = radeon_gem_prime_get_sg_table,
> + .vmap = radeon_gem_prime_vmap,
> + .vunmap = radeon_gem_prime_vunmap,
> +};
> +
Same comment as for amdgpu, please put that into radeon_gem.c instead.
Christian.
> int radeon_bo_create(struct radeon_device *rdev,
> unsigned long size, int byte_align, bool kernel,
> u32 domain, u32 flags, struct sg_table *sg,
> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
> bo->rdev = rdev;
> bo->surface_reg = -1;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:24 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:24 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in radeon.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 4cd30613fa1d..65061c949aee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
> -void radeon_gem_object_free(struct drm_gem_object *obj);
> -int radeon_gem_object_open(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -void radeon_gem_object_close(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> - int flags);
> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
> unsigned int flags, int *vpos, int *hpos,
> ktime_t *stime, ktime_t *etime,
> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
> int radeon_mode_dumb_create(struct drm_file *file_priv,
> struct drm_device *dev,
> struct drm_mode_create_dumb *args);
> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *,
> struct sg_table *sg);
> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>
> /* atpx handler */
> #if defined(CONFIG_VGA_SWITCHEROO)
> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
> }
>
> ret = drm_ioctl(filp, cmd, arg);
> -
> +
> pm_runtime_mark_last_busy(dev->dev);
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
> .irq_uninstall = radeon_driver_irq_uninstall_kms,
> .irq_handler = radeon_driver_irq_handler_kms,
> .ioctls = radeon_ioctls_kms,
> - .gem_free_object_unlocked = radeon_gem_object_free,
> - .gem_open_object = radeon_gem_object_open,
> - .gem_close_object = radeon_gem_object_close,
> .dumb_create = radeon_mode_dumb_create,
> .dumb_map_offset = radeon_mode_dumb_mmap,
> .fops = &radeon_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = radeon_gem_prime_export,
> - .gem_prime_pin = radeon_gem_prime_pin,
> - .gem_prime_unpin = radeon_gem_prime_unpin,
> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
> - .gem_prime_vmap = radeon_gem_prime_vmap,
> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>
> .name = DRIVER_NAME,
> .desc = DRIVER_DESC,
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index bb7582afd803..882390e15dfe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
> void radeon_ttm_fini(struct radeon_device *rdev);
> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>
> +void radeon_gem_object_free(struct drm_gem_object *obj);
> +int radeon_gem_object_open(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +void radeon_gem_object_close(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> + int flags);
> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
> +
> /*
> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
> * function are calling it.
> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
> }
>
> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
> + .free = radeon_gem_object_free,
> + .open = radeon_gem_object_open,
> + .close = radeon_gem_object_close,
> + .export = radeon_gem_prime_export,
> + .pin = radeon_gem_prime_pin,
> + .unpin = radeon_gem_prime_unpin,
> + .get_sg_table = radeon_gem_prime_get_sg_table,
> + .vmap = radeon_gem_prime_vmap,
> + .vunmap = radeon_gem_prime_vunmap,
> +};
> +
Same comment as for amdgpu, please put that into radeon_gem.c instead.
Christian.
> int radeon_bo_create(struct radeon_device *rdev,
> unsigned long size, int byte_align, bool kernel,
> u32 domain, u32 flags, struct sg_table *sg,
> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
> bo->rdev = rdev;
> bo->surface_reg = -1;
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:24 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:24 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in radeon.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 4cd30613fa1d..65061c949aee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
> -void radeon_gem_object_free(struct drm_gem_object *obj);
> -int radeon_gem_object_open(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -void radeon_gem_object_close(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> - int flags);
> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
> unsigned int flags, int *vpos, int *hpos,
> ktime_t *stime, ktime_t *etime,
> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
> int radeon_mode_dumb_create(struct drm_file *file_priv,
> struct drm_device *dev,
> struct drm_mode_create_dumb *args);
> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *,
> struct sg_table *sg);
> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>
> /* atpx handler */
> #if defined(CONFIG_VGA_SWITCHEROO)
> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
> }
>
> ret = drm_ioctl(filp, cmd, arg);
> -
> +
> pm_runtime_mark_last_busy(dev->dev);
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
> .irq_uninstall = radeon_driver_irq_uninstall_kms,
> .irq_handler = radeon_driver_irq_handler_kms,
> .ioctls = radeon_ioctls_kms,
> - .gem_free_object_unlocked = radeon_gem_object_free,
> - .gem_open_object = radeon_gem_object_open,
> - .gem_close_object = radeon_gem_object_close,
> .dumb_create = radeon_mode_dumb_create,
> .dumb_map_offset = radeon_mode_dumb_mmap,
> .fops = &radeon_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = radeon_gem_prime_export,
> - .gem_prime_pin = radeon_gem_prime_pin,
> - .gem_prime_unpin = radeon_gem_prime_unpin,
> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
> - .gem_prime_vmap = radeon_gem_prime_vmap,
> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>
> .name = DRIVER_NAME,
> .desc = DRIVER_DESC,
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index bb7582afd803..882390e15dfe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
> void radeon_ttm_fini(struct radeon_device *rdev);
> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>
> +void radeon_gem_object_free(struct drm_gem_object *obj);
> +int radeon_gem_object_open(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +void radeon_gem_object_close(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> + int flags);
> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
> +
> /*
> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
> * function are calling it.
> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
> }
>
> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
> + .free = radeon_gem_object_free,
> + .open = radeon_gem_object_open,
> + .close = radeon_gem_object_close,
> + .export = radeon_gem_prime_export,
> + .pin = radeon_gem_prime_pin,
> + .unpin = radeon_gem_prime_unpin,
> + .get_sg_table = radeon_gem_prime_get_sg_table,
> + .vmap = radeon_gem_prime_vmap,
> + .vunmap = radeon_gem_prime_vunmap,
> +};
> +
Same comment as for amdgpu, please put that into radeon_gem.c instead.
Christian.
> int radeon_bo_create(struct radeon_device *rdev,
> unsigned long size, int byte_align, bool kernel,
> u32 domain, u32 flags, struct sg_table *sg,
> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
> bo->rdev = rdev;
> bo->surface_reg = -1;
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:24 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:24 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w,
oleksandr_andrushchenko-uRwfk40T5oI,
hyun.kwon-gjFFaj9aHVfQT0dZR+AlfA,
laurent.pinchart-ryLnwIuWjnhk3lzF8UVTdg
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in radeon.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 27 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index 4cd30613fa1d..65061c949aee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct drm_device *dev);
> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
> -void radeon_gem_object_free(struct drm_gem_object *obj);
> -int radeon_gem_object_open(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -void radeon_gem_object_close(struct drm_gem_object *obj,
> - struct drm_file *file_priv);
> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> - int flags);
> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev, unsigned int crtc,
> unsigned int flags, int *vpos, int *hpos,
> ktime_t *stime, ktime_t *etime,
> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
> int radeon_mode_dumb_create(struct drm_file *file_priv,
> struct drm_device *dev,
> struct drm_mode_create_dumb *args);
> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> struct dma_buf_attachment *,
> struct sg_table *sg);
> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>
> /* atpx handler */
> #if defined(CONFIG_VGA_SWITCHEROO)
> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
> }
>
> ret = drm_ioctl(filp, cmd, arg);
> -
> +
> pm_runtime_mark_last_busy(dev->dev);
> pm_runtime_put_autosuspend(dev->dev);
> return ret;
> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
> .irq_uninstall = radeon_driver_irq_uninstall_kms,
> .irq_handler = radeon_driver_irq_handler_kms,
> .ioctls = radeon_ioctls_kms,
> - .gem_free_object_unlocked = radeon_gem_object_free,
> - .gem_open_object = radeon_gem_object_open,
> - .gem_close_object = radeon_gem_object_close,
> .dumb_create = radeon_mode_dumb_create,
> .dumb_map_offset = radeon_mode_dumb_mmap,
> .fops = &radeon_driver_kms_fops,
>
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = radeon_gem_prime_export,
> - .gem_prime_pin = radeon_gem_prime_pin,
> - .gem_prime_unpin = radeon_gem_prime_unpin,
> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
> - .gem_prime_vmap = radeon_gem_prime_vmap,
> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>
> .name = DRIVER_NAME,
> .desc = DRIVER_DESC,
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index bb7582afd803..882390e15dfe 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
> void radeon_ttm_fini(struct radeon_device *rdev);
> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>
> +void radeon_gem_object_free(struct drm_gem_object *obj);
> +int radeon_gem_object_open(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +void radeon_gem_object_close(struct drm_gem_object *obj,
> + struct drm_file *file_priv);
> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
> + int flags);
> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj);
> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
> +
> /*
> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
> * function are calling it.
> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> }
> }
>
> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
> + .free = radeon_gem_object_free,
> + .open = radeon_gem_object_open,
> + .close = radeon_gem_object_close,
> + .export = radeon_gem_prime_export,
> + .pin = radeon_gem_prime_pin,
> + .unpin = radeon_gem_prime_unpin,
> + .get_sg_table = radeon_gem_prime_get_sg_table,
> + .vmap = radeon_gem_prime_vmap,
> + .vunmap = radeon_gem_prime_vunmap,
> +};
> +
Same comment as for amdgpu, please put that into radeon_gem.c instead.
Christian.
> int radeon_bo_create(struct radeon_device *rdev,
> unsigned long size, int byte_align, bool kernel,
> u32 domain, u32 flags, struct sg_table *sg,
> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
> if (bo == NULL)
> return -ENOMEM;
> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
> bo->rdev = rdev;
> bo->surface_reg = -1;
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:41 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:41 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 7363 bytes --]
Hi
Am 13.08.20 um 12:24 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in radeon.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>> b/drivers/gpu/drm/radeon/radeon_drv.c
>> index 4cd30613fa1d..65061c949aee 100644
>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>> drm_device *dev);
>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> - int flags);
>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>> unsigned int crtc,
>> unsigned int flags, int *vpos, int *hpos,
>> ktime_t *stime, ktime_t *etime,
>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>> struct drm_device *dev,
>> struct drm_mode_create_dumb *args);
>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>> drm_device *dev,
>> struct dma_buf_attachment *,
>> struct sg_table *sg);
>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> /* atpx handler */
>> #if defined(CONFIG_VGA_SWITCHEROO)
>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>> }
>> ret = drm_ioctl(filp, cmd, arg);
>> -
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>> return ret;
>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>> .irq_handler = radeon_driver_irq_handler_kms,
>> .ioctls = radeon_ioctls_kms,
>> - .gem_free_object_unlocked = radeon_gem_object_free,
>> - .gem_open_object = radeon_gem_object_open,
>> - .gem_close_object = radeon_gem_object_close,
>> .dumb_create = radeon_mode_dumb_create,
>> .dumb_map_offset = radeon_mode_dumb_mmap,
>> .fops = &radeon_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = radeon_gem_prime_export,
>> - .gem_prime_pin = radeon_gem_prime_pin,
>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>> .name = DRIVER_NAME,
>> .desc = DRIVER_DESC,
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>> b/drivers/gpu/drm/radeon/radeon_object.c
>> index bb7582afd803..882390e15dfe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>> void radeon_ttm_fini(struct radeon_device *rdev);
>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> + int flags);
>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> +
>> /*
>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>> * function are calling it.
>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>> radeon_bo *rbo, u32 domain)
>> }
>> }
>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>> + .free = radeon_gem_object_free,
>> + .open = radeon_gem_object_open,
>> + .close = radeon_gem_object_close,
>> + .export = radeon_gem_prime_export,
>> + .pin = radeon_gem_prime_pin,
>> + .unpin = radeon_gem_prime_unpin,
>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>> + .vmap = radeon_gem_prime_vmap,
>> + .vunmap = radeon_gem_prime_vunmap,
>> +};
>> +
>
> Same comment as for amdgpu, please put that into radeon_gem.c instead.
There's no good header file to put the declarations, right? I'm asking
because checkpatch warns about declarations in the source files.
Best regards
Thomas
>
> Christian.
>
>> int radeon_bo_create(struct radeon_device *rdev,
>> unsigned long size, int byte_align, bool kernel,
>> u32 domain, u32 flags, struct sg_table *sg,
>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>> bo->rdev = rdev;
>> bo->surface_reg = -1;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:41 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:41 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 7363 bytes --]
Hi
Am 13.08.20 um 12:24 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in radeon.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>> b/drivers/gpu/drm/radeon/radeon_drv.c
>> index 4cd30613fa1d..65061c949aee 100644
>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>> drm_device *dev);
>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> - int flags);
>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>> unsigned int crtc,
>> unsigned int flags, int *vpos, int *hpos,
>> ktime_t *stime, ktime_t *etime,
>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>> struct drm_device *dev,
>> struct drm_mode_create_dumb *args);
>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>> drm_device *dev,
>> struct dma_buf_attachment *,
>> struct sg_table *sg);
>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> /* atpx handler */
>> #if defined(CONFIG_VGA_SWITCHEROO)
>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>> }
>> ret = drm_ioctl(filp, cmd, arg);
>> -
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>> return ret;
>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>> .irq_handler = radeon_driver_irq_handler_kms,
>> .ioctls = radeon_ioctls_kms,
>> - .gem_free_object_unlocked = radeon_gem_object_free,
>> - .gem_open_object = radeon_gem_object_open,
>> - .gem_close_object = radeon_gem_object_close,
>> .dumb_create = radeon_mode_dumb_create,
>> .dumb_map_offset = radeon_mode_dumb_mmap,
>> .fops = &radeon_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = radeon_gem_prime_export,
>> - .gem_prime_pin = radeon_gem_prime_pin,
>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>> .name = DRIVER_NAME,
>> .desc = DRIVER_DESC,
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>> b/drivers/gpu/drm/radeon/radeon_object.c
>> index bb7582afd803..882390e15dfe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>> void radeon_ttm_fini(struct radeon_device *rdev);
>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> + int flags);
>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> +
>> /*
>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>> * function are calling it.
>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>> radeon_bo *rbo, u32 domain)
>> }
>> }
>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>> + .free = radeon_gem_object_free,
>> + .open = radeon_gem_object_open,
>> + .close = radeon_gem_object_close,
>> + .export = radeon_gem_prime_export,
>> + .pin = radeon_gem_prime_pin,
>> + .unpin = radeon_gem_prime_unpin,
>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>> + .vmap = radeon_gem_prime_vmap,
>> + .vunmap = radeon_gem_prime_vunmap,
>> +};
>> +
>
> Same comment as for amdgpu, please put that into radeon_gem.c instead.
There's no good header file to put the declarations, right? I'm asking
because checkpatch warns about declarations in the source files.
Best regards
Thomas
>
> Christian.
>
>> int radeon_bo_create(struct radeon_device *rdev,
>> unsigned long size, int byte_align, bool kernel,
>> u32 domain, u32 flags, struct sg_table *sg,
>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>> bo->rdev = rdev;
>> bo->surface_reg = -1;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:41 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:41 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 7363 bytes --]
Hi
Am 13.08.20 um 12:24 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in radeon.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>> b/drivers/gpu/drm/radeon/radeon_drv.c
>> index 4cd30613fa1d..65061c949aee 100644
>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>> drm_device *dev);
>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> - int flags);
>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>> unsigned int crtc,
>> unsigned int flags, int *vpos, int *hpos,
>> ktime_t *stime, ktime_t *etime,
>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>> struct drm_device *dev,
>> struct drm_mode_create_dumb *args);
>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>> drm_device *dev,
>> struct dma_buf_attachment *,
>> struct sg_table *sg);
>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> /* atpx handler */
>> #if defined(CONFIG_VGA_SWITCHEROO)
>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>> }
>> ret = drm_ioctl(filp, cmd, arg);
>> -
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>> return ret;
>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>> .irq_handler = radeon_driver_irq_handler_kms,
>> .ioctls = radeon_ioctls_kms,
>> - .gem_free_object_unlocked = radeon_gem_object_free,
>> - .gem_open_object = radeon_gem_object_open,
>> - .gem_close_object = radeon_gem_object_close,
>> .dumb_create = radeon_mode_dumb_create,
>> .dumb_map_offset = radeon_mode_dumb_mmap,
>> .fops = &radeon_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = radeon_gem_prime_export,
>> - .gem_prime_pin = radeon_gem_prime_pin,
>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>> .name = DRIVER_NAME,
>> .desc = DRIVER_DESC,
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>> b/drivers/gpu/drm/radeon/radeon_object.c
>> index bb7582afd803..882390e15dfe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>> void radeon_ttm_fini(struct radeon_device *rdev);
>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> + int flags);
>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> +
>> /*
>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>> * function are calling it.
>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>> radeon_bo *rbo, u32 domain)
>> }
>> }
>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>> + .free = radeon_gem_object_free,
>> + .open = radeon_gem_object_open,
>> + .close = radeon_gem_object_close,
>> + .export = radeon_gem_prime_export,
>> + .pin = radeon_gem_prime_pin,
>> + .unpin = radeon_gem_prime_unpin,
>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>> + .vmap = radeon_gem_prime_vmap,
>> + .vunmap = radeon_gem_prime_vunmap,
>> +};
>> +
>
> Same comment as for amdgpu, please put that into radeon_gem.c instead.
There's no good header file to put the declarations, right? I'm asking
because checkpatch warns about declarations in the source files.
Best regards
Thomas
>
> Christian.
>
>> int radeon_bo_create(struct radeon_device *rdev,
>> unsigned long size, int byte_align, bool kernel,
>> u32 domain, u32 flags, struct sg_table *sg,
>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>> bo->rdev = rdev;
>> bo->surface_reg = -1;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:41 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:41 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 7363 bytes --]
Hi
Am 13.08.20 um 12:24 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in radeon.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>> b/drivers/gpu/drm/radeon/radeon_drv.c
>> index 4cd30613fa1d..65061c949aee 100644
>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>> drm_device *dev);
>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> - int flags);
>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>> unsigned int crtc,
>> unsigned int flags, int *vpos, int *hpos,
>> ktime_t *stime, ktime_t *etime,
>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>> struct drm_device *dev,
>> struct drm_mode_create_dumb *args);
>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>> drm_device *dev,
>> struct dma_buf_attachment *,
>> struct sg_table *sg);
>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> /* atpx handler */
>> #if defined(CONFIG_VGA_SWITCHEROO)
>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>> }
>> ret = drm_ioctl(filp, cmd, arg);
>> -
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>> return ret;
>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>> .irq_handler = radeon_driver_irq_handler_kms,
>> .ioctls = radeon_ioctls_kms,
>> - .gem_free_object_unlocked = radeon_gem_object_free,
>> - .gem_open_object = radeon_gem_object_open,
>> - .gem_close_object = radeon_gem_object_close,
>> .dumb_create = radeon_mode_dumb_create,
>> .dumb_map_offset = radeon_mode_dumb_mmap,
>> .fops = &radeon_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = radeon_gem_prime_export,
>> - .gem_prime_pin = radeon_gem_prime_pin,
>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>> .name = DRIVER_NAME,
>> .desc = DRIVER_DESC,
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>> b/drivers/gpu/drm/radeon/radeon_object.c
>> index bb7582afd803..882390e15dfe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>> void radeon_ttm_fini(struct radeon_device *rdev);
>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> + int flags);
>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> +
>> /*
>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>> * function are calling it.
>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>> radeon_bo *rbo, u32 domain)
>> }
>> }
>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>> + .free = radeon_gem_object_free,
>> + .open = radeon_gem_object_open,
>> + .close = radeon_gem_object_close,
>> + .export = radeon_gem_prime_export,
>> + .pin = radeon_gem_prime_pin,
>> + .unpin = radeon_gem_prime_unpin,
>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>> + .vmap = radeon_gem_prime_vmap,
>> + .vunmap = radeon_gem_prime_vunmap,
>> +};
>> +
>
> Same comment as for amdgpu, please put that into radeon_gem.c instead.
There's no good header file to put the declarations, right? I'm asking
because checkpatch warns about declarations in the source files.
Best regards
Thomas
>
> Christian.
>
>> int radeon_bo_create(struct radeon_device *rdev,
>> unsigned long size, int byte_align, bool kernel,
>> u32 domain, u32 flags, struct sg_table *sg,
>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>> bo->rdev = rdev;
>> bo->surface_reg = -1;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:41 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:41 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 7363 bytes --]
Hi
Am 13.08.20 um 12:24 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in radeon.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>> b/drivers/gpu/drm/radeon/radeon_drv.c
>> index 4cd30613fa1d..65061c949aee 100644
>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>> drm_device *dev);
>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> - int flags);
>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>> unsigned int crtc,
>> unsigned int flags, int *vpos, int *hpos,
>> ktime_t *stime, ktime_t *etime,
>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>> struct drm_device *dev,
>> struct drm_mode_create_dumb *args);
>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>> drm_device *dev,
>> struct dma_buf_attachment *,
>> struct sg_table *sg);
>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> /* atpx handler */
>> #if defined(CONFIG_VGA_SWITCHEROO)
>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>> }
>> ret = drm_ioctl(filp, cmd, arg);
>> -
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>> return ret;
>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>> .irq_handler = radeon_driver_irq_handler_kms,
>> .ioctls = radeon_ioctls_kms,
>> - .gem_free_object_unlocked = radeon_gem_object_free,
>> - .gem_open_object = radeon_gem_object_open,
>> - .gem_close_object = radeon_gem_object_close,
>> .dumb_create = radeon_mode_dumb_create,
>> .dumb_map_offset = radeon_mode_dumb_mmap,
>> .fops = &radeon_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = radeon_gem_prime_export,
>> - .gem_prime_pin = radeon_gem_prime_pin,
>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>> .name = DRIVER_NAME,
>> .desc = DRIVER_DESC,
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>> b/drivers/gpu/drm/radeon/radeon_object.c
>> index bb7582afd803..882390e15dfe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>> void radeon_ttm_fini(struct radeon_device *rdev);
>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> + int flags);
>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> +
>> /*
>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>> * function are calling it.
>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>> radeon_bo *rbo, u32 domain)
>> }
>> }
>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>> + .free = radeon_gem_object_free,
>> + .open = radeon_gem_object_open,
>> + .close = radeon_gem_object_close,
>> + .export = radeon_gem_prime_export,
>> + .pin = radeon_gem_prime_pin,
>> + .unpin = radeon_gem_prime_unpin,
>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>> + .vmap = radeon_gem_prime_vmap,
>> + .vunmap = radeon_gem_prime_vunmap,
>> +};
>> +
>
> Same comment as for amdgpu, please put that into radeon_gem.c instead.
There's no good header file to put the declarations, right? I'm asking
because checkpatch warns about declarations in the source files.
Best regards
Thomas
>
> Christian.
>
>> int radeon_bo_create(struct radeon_device *rdev,
>> unsigned long size, int byte_align, bool kernel,
>> u32 domain, u32 flags, struct sg_table *sg,
>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>> bo->rdev = rdev;
>> bo->surface_reg = -1;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:41 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:41 UTC (permalink / raw)
To: Christian König, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 7363 bytes --]
Hi
Am 13.08.20 um 12:24 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in radeon.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>> b/drivers/gpu/drm/radeon/radeon_drv.c
>> index 4cd30613fa1d..65061c949aee 100644
>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>> drm_device *dev);
>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> - int flags);
>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>> unsigned int crtc,
>> unsigned int flags, int *vpos, int *hpos,
>> ktime_t *stime, ktime_t *etime,
>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>> struct drm_device *dev,
>> struct drm_mode_create_dumb *args);
>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>> drm_device *dev,
>> struct dma_buf_attachment *,
>> struct sg_table *sg);
>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> /* atpx handler */
>> #if defined(CONFIG_VGA_SWITCHEROO)
>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>> }
>> ret = drm_ioctl(filp, cmd, arg);
>> -
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>> return ret;
>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>> .irq_handler = radeon_driver_irq_handler_kms,
>> .ioctls = radeon_ioctls_kms,
>> - .gem_free_object_unlocked = radeon_gem_object_free,
>> - .gem_open_object = radeon_gem_object_open,
>> - .gem_close_object = radeon_gem_object_close,
>> .dumb_create = radeon_mode_dumb_create,
>> .dumb_map_offset = radeon_mode_dumb_mmap,
>> .fops = &radeon_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = radeon_gem_prime_export,
>> - .gem_prime_pin = radeon_gem_prime_pin,
>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>> .name = DRIVER_NAME,
>> .desc = DRIVER_DESC,
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>> b/drivers/gpu/drm/radeon/radeon_object.c
>> index bb7582afd803..882390e15dfe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>> void radeon_ttm_fini(struct radeon_device *rdev);
>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> + int flags);
>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> +
>> /*
>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>> * function are calling it.
>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>> radeon_bo *rbo, u32 domain)
>> }
>> }
>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>> + .free = radeon_gem_object_free,
>> + .open = radeon_gem_object_open,
>> + .close = radeon_gem_object_close,
>> + .export = radeon_gem_prime_export,
>> + .pin = radeon_gem_prime_pin,
>> + .unpin = radeon_gem_prime_unpin,
>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>> + .vmap = radeon_gem_prime_vmap,
>> + .vunmap = radeon_gem_prime_vunmap,
>> +};
>> +
>
> Same comment as for amdgpu, please put that into radeon_gem.c instead.
There's no good header file to put the declarations, right? I'm asking
because checkpatch warns about declarations in the source files.
Best regards
Thomas
>
> Christian.
>
>> int radeon_bo_create(struct radeon_device *rdev,
>> unsigned long size, int byte_align, bool kernel,
>> u32 domain, u32 flags, struct sg_table *sg,
>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>> bo->rdev = rdev;
>> bo->surface_reg = -1;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:41 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:41 UTC (permalink / raw)
To: Christian König, alexander.deucher-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b
[-- Attachment #1.1: Type: text/plain, Size: 7384 bytes --]
Hi
Am 13.08.20 um 12:24 schrieb Christian König:
> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in radeon.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
>> ---
>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>> b/drivers/gpu/drm/radeon/radeon_drv.c
>> index 4cd30613fa1d..65061c949aee 100644
>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>> drm_device *dev);
>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>> - struct drm_file *file_priv);
>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> - int flags);
>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>> unsigned int crtc,
>> unsigned int flags, int *vpos, int *hpos,
>> ktime_t *stime, ktime_t *etime,
>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>> struct drm_device *dev,
>> struct drm_mode_create_dumb *args);
>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>> drm_device *dev,
>> struct dma_buf_attachment *,
>> struct sg_table *sg);
>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> /* atpx handler */
>> #if defined(CONFIG_VGA_SWITCHEROO)
>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>> }
>> ret = drm_ioctl(filp, cmd, arg);
>> -
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>> return ret;
>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>> .irq_handler = radeon_driver_irq_handler_kms,
>> .ioctls = radeon_ioctls_kms,
>> - .gem_free_object_unlocked = radeon_gem_object_free,
>> - .gem_open_object = radeon_gem_object_open,
>> - .gem_close_object = radeon_gem_object_close,
>> .dumb_create = radeon_mode_dumb_create,
>> .dumb_map_offset = radeon_mode_dumb_mmap,
>> .fops = &radeon_driver_kms_fops,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = radeon_gem_prime_export,
>> - .gem_prime_pin = radeon_gem_prime_pin,
>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>> .name = DRIVER_NAME,
>> .desc = DRIVER_DESC,
>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>> b/drivers/gpu/drm/radeon/radeon_object.c
>> index bb7582afd803..882390e15dfe 100644
>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>> void radeon_ttm_fini(struct radeon_device *rdev);
>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>> + struct drm_file *file_priv);
>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>> + int flags);
>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>> *obj);
>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>> +
>> /*
>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>> * function are calling it.
>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>> radeon_bo *rbo, u32 domain)
>> }
>> }
>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>> + .free = radeon_gem_object_free,
>> + .open = radeon_gem_object_open,
>> + .close = radeon_gem_object_close,
>> + .export = radeon_gem_prime_export,
>> + .pin = radeon_gem_prime_pin,
>> + .unpin = radeon_gem_prime_unpin,
>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>> + .vmap = radeon_gem_prime_vmap,
>> + .vunmap = radeon_gem_prime_vunmap,
>> +};
>> +
>
> Same comment as for amdgpu, please put that into radeon_gem.c instead.
There's no good header file to put the declarations, right? I'm asking
because checkpatch warns about declarations in the source files.
Best regards
Thomas
>
> Christian.
>
>> int radeon_bo_create(struct radeon_device *rdev,
>> unsigned long size, int byte_align, bool kernel,
>> u32 domain, u32 flags, struct sg_table *sg,
>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>> if (bo == NULL)
>> return -ENOMEM;
>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>> bo->rdev = rdev;
>> bo->surface_reg = -1;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:47 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:47 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:24 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in radeon.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>>> b/drivers/gpu/drm/radeon/radeon_drv.c
>>> index 4cd30613fa1d..65061c949aee 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>>> drm_device *dev);
>>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> - int flags);
>>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>>> unsigned int crtc,
>>> unsigned int flags, int *vpos, int *hpos,
>>> ktime_t *stime, ktime_t *etime,
>>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>>> struct drm_device *dev,
>>> struct drm_mode_create_dumb *args);
>>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>>> drm_device *dev,
>>> struct dma_buf_attachment *,
>>> struct sg_table *sg);
>>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> /* atpx handler */
>>> #if defined(CONFIG_VGA_SWITCHEROO)
>>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>>> }
>>> ret = drm_ioctl(filp, cmd, arg);
>>> -
>>> +
>>> pm_runtime_mark_last_busy(dev->dev);
>>> pm_runtime_put_autosuspend(dev->dev);
>>> return ret;
>>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>>> .irq_handler = radeon_driver_irq_handler_kms,
>>> .ioctls = radeon_ioctls_kms,
>>> - .gem_free_object_unlocked = radeon_gem_object_free,
>>> - .gem_open_object = radeon_gem_object_open,
>>> - .gem_close_object = radeon_gem_object_close,
>>> .dumb_create = radeon_mode_dumb_create,
>>> .dumb_map_offset = radeon_mode_dumb_mmap,
>>> .fops = &radeon_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = radeon_gem_prime_export,
>>> - .gem_prime_pin = radeon_gem_prime_pin,
>>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>>> .name = DRIVER_NAME,
>>> .desc = DRIVER_DESC,
>>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>>> b/drivers/gpu/drm/radeon/radeon_object.c
>>> index bb7582afd803..882390e15dfe 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>>> void radeon_ttm_fini(struct radeon_device *rdev);
>>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> + int flags);
>>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> +
>>> /*
>>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>>> * function are calling it.
>>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>>> radeon_bo *rbo, u32 domain)
>>> }
>>> }
>>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>>> + .free = radeon_gem_object_free,
>>> + .open = radeon_gem_object_open,
>>> + .close = radeon_gem_object_close,
>>> + .export = radeon_gem_prime_export,
>>> + .pin = radeon_gem_prime_pin,
>>> + .unpin = radeon_gem_prime_unpin,
>>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>>> + .vmap = radeon_gem_prime_vmap,
>>> + .vunmap = radeon_gem_prime_vunmap,
>>> +};
>>> +
>> Same comment as for amdgpu, please put that into radeon_gem.c instead.
> There's no good header file to put the declarations, right? I'm asking
> because checkpatch warns about declarations in the source files.
Yes, that is kind of a mess because radeon used to support both KMS and UMS.
Thanks for cleaning this up,
Christian.
>
> Best regards
> Thomas
>
>> Christian.
>>
>>> int radeon_bo_create(struct radeon_device *rdev,
>>> unsigned long size, int byte_align, bool kernel,
>>> u32 domain, u32 flags, struct sg_table *sg,
>>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>>> bo->rdev = rdev;
>>> bo->surface_reg = -1;
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:47 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:47 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:24 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in radeon.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>>> b/drivers/gpu/drm/radeon/radeon_drv.c
>>> index 4cd30613fa1d..65061c949aee 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>>> drm_device *dev);
>>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> - int flags);
>>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>>> unsigned int crtc,
>>> unsigned int flags, int *vpos, int *hpos,
>>> ktime_t *stime, ktime_t *etime,
>>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>>> struct drm_device *dev,
>>> struct drm_mode_create_dumb *args);
>>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>>> drm_device *dev,
>>> struct dma_buf_attachment *,
>>> struct sg_table *sg);
>>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> /* atpx handler */
>>> #if defined(CONFIG_VGA_SWITCHEROO)
>>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>>> }
>>> ret = drm_ioctl(filp, cmd, arg);
>>> -
>>> +
>>> pm_runtime_mark_last_busy(dev->dev);
>>> pm_runtime_put_autosuspend(dev->dev);
>>> return ret;
>>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>>> .irq_handler = radeon_driver_irq_handler_kms,
>>> .ioctls = radeon_ioctls_kms,
>>> - .gem_free_object_unlocked = radeon_gem_object_free,
>>> - .gem_open_object = radeon_gem_object_open,
>>> - .gem_close_object = radeon_gem_object_close,
>>> .dumb_create = radeon_mode_dumb_create,
>>> .dumb_map_offset = radeon_mode_dumb_mmap,
>>> .fops = &radeon_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = radeon_gem_prime_export,
>>> - .gem_prime_pin = radeon_gem_prime_pin,
>>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>>> .name = DRIVER_NAME,
>>> .desc = DRIVER_DESC,
>>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>>> b/drivers/gpu/drm/radeon/radeon_object.c
>>> index bb7582afd803..882390e15dfe 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>>> void radeon_ttm_fini(struct radeon_device *rdev);
>>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> + int flags);
>>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> +
>>> /*
>>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>>> * function are calling it.
>>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>>> radeon_bo *rbo, u32 domain)
>>> }
>>> }
>>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>>> + .free = radeon_gem_object_free,
>>> + .open = radeon_gem_object_open,
>>> + .close = radeon_gem_object_close,
>>> + .export = radeon_gem_prime_export,
>>> + .pin = radeon_gem_prime_pin,
>>> + .unpin = radeon_gem_prime_unpin,
>>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>>> + .vmap = radeon_gem_prime_vmap,
>>> + .vunmap = radeon_gem_prime_vunmap,
>>> +};
>>> +
>> Same comment as for amdgpu, please put that into radeon_gem.c instead.
> There's no good header file to put the declarations, right? I'm asking
> because checkpatch warns about declarations in the source files.
Yes, that is kind of a mess because radeon used to support both KMS and UMS.
Thanks for cleaning this up,
Christian.
>
> Best regards
> Thomas
>
>> Christian.
>>
>>> int radeon_bo_create(struct radeon_device *rdev,
>>> unsigned long size, int byte_align, bool kernel,
>>> u32 domain, u32 flags, struct sg_table *sg,
>>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>>> bo->rdev = rdev;
>>> bo->surface_reg = -1;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:47 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:47 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:24 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in radeon.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>>> b/drivers/gpu/drm/radeon/radeon_drv.c
>>> index 4cd30613fa1d..65061c949aee 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>>> drm_device *dev);
>>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> - int flags);
>>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>>> unsigned int crtc,
>>> unsigned int flags, int *vpos, int *hpos,
>>> ktime_t *stime, ktime_t *etime,
>>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>>> struct drm_device *dev,
>>> struct drm_mode_create_dumb *args);
>>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>>> drm_device *dev,
>>> struct dma_buf_attachment *,
>>> struct sg_table *sg);
>>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> /* atpx handler */
>>> #if defined(CONFIG_VGA_SWITCHEROO)
>>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>>> }
>>> ret = drm_ioctl(filp, cmd, arg);
>>> -
>>> +
>>> pm_runtime_mark_last_busy(dev->dev);
>>> pm_runtime_put_autosuspend(dev->dev);
>>> return ret;
>>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>>> .irq_handler = radeon_driver_irq_handler_kms,
>>> .ioctls = radeon_ioctls_kms,
>>> - .gem_free_object_unlocked = radeon_gem_object_free,
>>> - .gem_open_object = radeon_gem_object_open,
>>> - .gem_close_object = radeon_gem_object_close,
>>> .dumb_create = radeon_mode_dumb_create,
>>> .dumb_map_offset = radeon_mode_dumb_mmap,
>>> .fops = &radeon_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = radeon_gem_prime_export,
>>> - .gem_prime_pin = radeon_gem_prime_pin,
>>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>>> .name = DRIVER_NAME,
>>> .desc = DRIVER_DESC,
>>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>>> b/drivers/gpu/drm/radeon/radeon_object.c
>>> index bb7582afd803..882390e15dfe 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>>> void radeon_ttm_fini(struct radeon_device *rdev);
>>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> + int flags);
>>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> +
>>> /*
>>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>>> * function are calling it.
>>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>>> radeon_bo *rbo, u32 domain)
>>> }
>>> }
>>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>>> + .free = radeon_gem_object_free,
>>> + .open = radeon_gem_object_open,
>>> + .close = radeon_gem_object_close,
>>> + .export = radeon_gem_prime_export,
>>> + .pin = radeon_gem_prime_pin,
>>> + .unpin = radeon_gem_prime_unpin,
>>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>>> + .vmap = radeon_gem_prime_vmap,
>>> + .vunmap = radeon_gem_prime_vunmap,
>>> +};
>>> +
>> Same comment as for amdgpu, please put that into radeon_gem.c instead.
> There's no good header file to put the declarations, right? I'm asking
> because checkpatch warns about declarations in the source files.
Yes, that is kind of a mess because radeon used to support both KMS and UMS.
Thanks for cleaning this up,
Christian.
>
> Best regards
> Thomas
>
>> Christian.
>>
>>> int radeon_bo_create(struct radeon_device *rdev,
>>> unsigned long size, int byte_align, bool kernel,
>>> u32 domain, u32 flags, struct sg_table *sg,
>>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>>> bo->rdev = rdev;
>>> bo->surface_reg = -1;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:47 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:47 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:24 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in radeon.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>>> b/drivers/gpu/drm/radeon/radeon_drv.c
>>> index 4cd30613fa1d..65061c949aee 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>>> drm_device *dev);
>>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> - int flags);
>>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>>> unsigned int crtc,
>>> unsigned int flags, int *vpos, int *hpos,
>>> ktime_t *stime, ktime_t *etime,
>>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>>> struct drm_device *dev,
>>> struct drm_mode_create_dumb *args);
>>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>>> drm_device *dev,
>>> struct dma_buf_attachment *,
>>> struct sg_table *sg);
>>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> /* atpx handler */
>>> #if defined(CONFIG_VGA_SWITCHEROO)
>>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>>> }
>>> ret = drm_ioctl(filp, cmd, arg);
>>> -
>>> +
>>> pm_runtime_mark_last_busy(dev->dev);
>>> pm_runtime_put_autosuspend(dev->dev);
>>> return ret;
>>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>>> .irq_handler = radeon_driver_irq_handler_kms,
>>> .ioctls = radeon_ioctls_kms,
>>> - .gem_free_object_unlocked = radeon_gem_object_free,
>>> - .gem_open_object = radeon_gem_object_open,
>>> - .gem_close_object = radeon_gem_object_close,
>>> .dumb_create = radeon_mode_dumb_create,
>>> .dumb_map_offset = radeon_mode_dumb_mmap,
>>> .fops = &radeon_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = radeon_gem_prime_export,
>>> - .gem_prime_pin = radeon_gem_prime_pin,
>>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>>> .name = DRIVER_NAME,
>>> .desc = DRIVER_DESC,
>>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>>> b/drivers/gpu/drm/radeon/radeon_object.c
>>> index bb7582afd803..882390e15dfe 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>>> void radeon_ttm_fini(struct radeon_device *rdev);
>>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> + int flags);
>>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> +
>>> /*
>>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>>> * function are calling it.
>>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>>> radeon_bo *rbo, u32 domain)
>>> }
>>> }
>>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>>> + .free = radeon_gem_object_free,
>>> + .open = radeon_gem_object_open,
>>> + .close = radeon_gem_object_close,
>>> + .export = radeon_gem_prime_export,
>>> + .pin = radeon_gem_prime_pin,
>>> + .unpin = radeon_gem_prime_unpin,
>>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>>> + .vmap = radeon_gem_prime_vmap,
>>> + .vunmap = radeon_gem_prime_vunmap,
>>> +};
>>> +
>> Same comment as for amdgpu, please put that into radeon_gem.c instead.
> There's no good header file to put the declarations, right? I'm asking
> because checkpatch warns about declarations in the source files.
Yes, that is kind of a mess because radeon used to support both KMS and UMS.
Thanks for cleaning this up,
Christian.
>
> Best regards
> Thomas
>
>> Christian.
>>
>>> int radeon_bo_create(struct radeon_device *rdev,
>>> unsigned long size, int byte_align, bool kernel,
>>> u32 domain, u32 flags, struct sg_table *sg,
>>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>>> bo->rdev = rdev;
>>> bo->surface_reg = -1;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:47 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:47 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:24 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in radeon.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>>> b/drivers/gpu/drm/radeon/radeon_drv.c
>>> index 4cd30613fa1d..65061c949aee 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>>> drm_device *dev);
>>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> - int flags);
>>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>>> unsigned int crtc,
>>> unsigned int flags, int *vpos, int *hpos,
>>> ktime_t *stime, ktime_t *etime,
>>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>>> struct drm_device *dev,
>>> struct drm_mode_create_dumb *args);
>>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>>> drm_device *dev,
>>> struct dma_buf_attachment *,
>>> struct sg_table *sg);
>>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> /* atpx handler */
>>> #if defined(CONFIG_VGA_SWITCHEROO)
>>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>>> }
>>> ret = drm_ioctl(filp, cmd, arg);
>>> -
>>> +
>>> pm_runtime_mark_last_busy(dev->dev);
>>> pm_runtime_put_autosuspend(dev->dev);
>>> return ret;
>>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>>> .irq_handler = radeon_driver_irq_handler_kms,
>>> .ioctls = radeon_ioctls_kms,
>>> - .gem_free_object_unlocked = radeon_gem_object_free,
>>> - .gem_open_object = radeon_gem_object_open,
>>> - .gem_close_object = radeon_gem_object_close,
>>> .dumb_create = radeon_mode_dumb_create,
>>> .dumb_map_offset = radeon_mode_dumb_mmap,
>>> .fops = &radeon_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = radeon_gem_prime_export,
>>> - .gem_prime_pin = radeon_gem_prime_pin,
>>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>>> .name = DRIVER_NAME,
>>> .desc = DRIVER_DESC,
>>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>>> b/drivers/gpu/drm/radeon/radeon_object.c
>>> index bb7582afd803..882390e15dfe 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>>> void radeon_ttm_fini(struct radeon_device *rdev);
>>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> + int flags);
>>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> +
>>> /*
>>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>>> * function are calling it.
>>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>>> radeon_bo *rbo, u32 domain)
>>> }
>>> }
>>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>>> + .free = radeon_gem_object_free,
>>> + .open = radeon_gem_object_open,
>>> + .close = radeon_gem_object_close,
>>> + .export = radeon_gem_prime_export,
>>> + .pin = radeon_gem_prime_pin,
>>> + .unpin = radeon_gem_prime_unpin,
>>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>>> + .vmap = radeon_gem_prime_vmap,
>>> + .vunmap = radeon_gem_prime_vunmap,
>>> +};
>>> +
>> Same comment as for amdgpu, please put that into radeon_gem.c instead.
> There's no good header file to put the declarations, right? I'm asking
> because checkpatch warns about declarations in the source files.
Yes, that is kind of a mess because radeon used to support both KMS and UMS.
Thanks for cleaning this up,
Christian.
>
> Best regards
> Thomas
>
>> Christian.
>>
>>> int radeon_bo_create(struct radeon_device *rdev,
>>> unsigned long size, int byte_align, bool kernel,
>>> u32 domain, u32 flags, struct sg_table *sg,
>>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>>> bo->rdev = rdev;
>>> bo->surface_reg = -1;
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:47 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:47 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:24 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in radeon.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>>> b/drivers/gpu/drm/radeon/radeon_drv.c
>>> index 4cd30613fa1d..65061c949aee 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>>> drm_device *dev);
>>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> - int flags);
>>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>>> unsigned int crtc,
>>> unsigned int flags, int *vpos, int *hpos,
>>> ktime_t *stime, ktime_t *etime,
>>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>>> struct drm_device *dev,
>>> struct drm_mode_create_dumb *args);
>>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>>> drm_device *dev,
>>> struct dma_buf_attachment *,
>>> struct sg_table *sg);
>>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> /* atpx handler */
>>> #if defined(CONFIG_VGA_SWITCHEROO)
>>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>>> }
>>> ret = drm_ioctl(filp, cmd, arg);
>>> -
>>> +
>>> pm_runtime_mark_last_busy(dev->dev);
>>> pm_runtime_put_autosuspend(dev->dev);
>>> return ret;
>>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>>> .irq_handler = radeon_driver_irq_handler_kms,
>>> .ioctls = radeon_ioctls_kms,
>>> - .gem_free_object_unlocked = radeon_gem_object_free,
>>> - .gem_open_object = radeon_gem_object_open,
>>> - .gem_close_object = radeon_gem_object_close,
>>> .dumb_create = radeon_mode_dumb_create,
>>> .dumb_map_offset = radeon_mode_dumb_mmap,
>>> .fops = &radeon_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = radeon_gem_prime_export,
>>> - .gem_prime_pin = radeon_gem_prime_pin,
>>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>>> .name = DRIVER_NAME,
>>> .desc = DRIVER_DESC,
>>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>>> b/drivers/gpu/drm/radeon/radeon_object.c
>>> index bb7582afd803..882390e15dfe 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>>> void radeon_ttm_fini(struct radeon_device *rdev);
>>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> + int flags);
>>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> +
>>> /*
>>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>>> * function are calling it.
>>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>>> radeon_bo *rbo, u32 domain)
>>> }
>>> }
>>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>>> + .free = radeon_gem_object_free,
>>> + .open = radeon_gem_object_open,
>>> + .close = radeon_gem_object_close,
>>> + .export = radeon_gem_prime_export,
>>> + .pin = radeon_gem_prime_pin,
>>> + .unpin = radeon_gem_prime_unpin,
>>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>>> + .vmap = radeon_gem_prime_vmap,
>>> + .vunmap = radeon_gem_prime_vunmap,
>>> +};
>>> +
>> Same comment as for amdgpu, please put that into radeon_gem.c instead.
> There's no good header file to put the declarations, right? I'm asking
> because checkpatch warns about declarations in the source files.
Yes, that is kind of a mess because radeon used to support both KMS and UMS.
Thanks for cleaning this up,
Christian.
>
> Best regards
> Thomas
>
>> Christian.
>>
>>> int radeon_bo_create(struct radeon_device *rdev,
>>> unsigned long size, int byte_align, bool kernel,
>>> u32 domain, u32 flags, struct sg_table *sg,
>>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>>> bo->rdev = rdev;
>>> bo->surface_reg = -1;
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 12/20] drm/radeon: Introduce GEM object functions
@ 2020-08-13 10:47 ` Christian König
0 siblings, 0 replies; 243+ messages in thread
From: Christian König @ 2020-08-13 10:47 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w,
oleksandr_andrushchenko-uRwfk40T5oI,
hyun.kwon-gjFFaj9aHVfQT0dZR+AlfA,
laurent.pinchart-ryLnwIuWjnhk3lzF8UVTdg
Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am 13.08.20 um 12:41 schrieb Thomas Zimmermann:
> Hi
>
> Am 13.08.20 um 12:24 schrieb Christian König:
>> Am 13.08.20 um 10:36 schrieb Thomas Zimmermann:
>>> GEM object functions deprecate several similar callback interfaces in
>>> struct drm_driver. This patch replaces the per-driver callbacks with
>>> per-instance callbacks in radeon.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>> ---
>>> drivers/gpu/drm/radeon/radeon_drv.c | 23 +----------------------
>>> drivers/gpu/drm/radeon/radeon_object.c | 26 ++++++++++++++++++++++++++
>>> 2 files changed, 27 insertions(+), 22 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
>>> b/drivers/gpu/drm/radeon/radeon_drv.c
>>> index 4cd30613fa1d..65061c949aee 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_drv.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
>>> @@ -124,13 +124,6 @@ void radeon_driver_irq_preinstall_kms(struct
>>> drm_device *dev);
>>> int radeon_driver_irq_postinstall_kms(struct drm_device *dev);
>>> void radeon_driver_irq_uninstall_kms(struct drm_device *dev);
>>> irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg);
>>> -void radeon_gem_object_free(struct drm_gem_object *obj);
>>> -int radeon_gem_object_open(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -void radeon_gem_object_close(struct drm_gem_object *obj,
>>> - struct drm_file *file_priv);
>>> -struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> - int flags);
>>> extern int radeon_get_crtc_scanoutpos(struct drm_device *dev,
>>> unsigned int crtc,
>>> unsigned int flags, int *vpos, int *hpos,
>>> ktime_t *stime, ktime_t *etime,
>>> @@ -145,14 +138,9 @@ int radeon_mode_dumb_mmap(struct drm_file *filp,
>>> int radeon_mode_dumb_create(struct drm_file *file_priv,
>>> struct drm_device *dev,
>>> struct drm_mode_create_dumb *args);
>>> -struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct
>>> drm_device *dev,
>>> struct dma_buf_attachment *,
>>> struct sg_table *sg);
>>> -int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> -void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> -void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> /* atpx handler */
>>> #if defined(CONFIG_VGA_SWITCHEROO)
>>> @@ -550,7 +538,7 @@ long radeon_drm_ioctl(struct file *filp,
>>> }
>>> ret = drm_ioctl(filp, cmd, arg);
>>> -
>>> +
>>> pm_runtime_mark_last_busy(dev->dev);
>>> pm_runtime_put_autosuspend(dev->dev);
>>> return ret;
>>> @@ -609,22 +597,13 @@ static struct drm_driver kms_driver = {
>>> .irq_uninstall = radeon_driver_irq_uninstall_kms,
>>> .irq_handler = radeon_driver_irq_handler_kms,
>>> .ioctls = radeon_ioctls_kms,
>>> - .gem_free_object_unlocked = radeon_gem_object_free,
>>> - .gem_open_object = radeon_gem_object_open,
>>> - .gem_close_object = radeon_gem_object_close,
>>> .dumb_create = radeon_mode_dumb_create,
>>> .dumb_map_offset = radeon_mode_dumb_mmap,
>>> .fops = &radeon_driver_kms_fops,
>>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>> - .gem_prime_export = radeon_gem_prime_export,
>>> - .gem_prime_pin = radeon_gem_prime_pin,
>>> - .gem_prime_unpin = radeon_gem_prime_unpin,
>>> - .gem_prime_get_sg_table = radeon_gem_prime_get_sg_table,
>>> .gem_prime_import_sg_table = radeon_gem_prime_import_sg_table,
>>> - .gem_prime_vmap = radeon_gem_prime_vmap,
>>> - .gem_prime_vunmap = radeon_gem_prime_vunmap,
>>> .name = DRIVER_NAME,
>>> .desc = DRIVER_DESC,
>>> diff --git a/drivers/gpu/drm/radeon/radeon_object.c
>>> b/drivers/gpu/drm/radeon/radeon_object.c
>>> index bb7582afd803..882390e15dfe 100644
>>> --- a/drivers/gpu/drm/radeon/radeon_object.c
>>> +++ b/drivers/gpu/drm/radeon/radeon_object.c
>>> @@ -45,6 +45,19 @@ int radeon_ttm_init(struct radeon_device *rdev);
>>> void radeon_ttm_fini(struct radeon_device *rdev);
>>> static void radeon_bo_clear_surface_reg(struct radeon_bo *bo);
>>> +void radeon_gem_object_free(struct drm_gem_object *obj);
>>> +int radeon_gem_object_open(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +void radeon_gem_object_close(struct drm_gem_object *obj,
>>> + struct drm_file *file_priv);
>>> +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj,
>>> + int flags);
>>> +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object
>>> *obj);
>>> +int radeon_gem_prime_pin(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_unpin(struct drm_gem_object *obj);
>>> +void *radeon_gem_prime_vmap(struct drm_gem_object *obj);
>>> +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
>>> +
>>> /*
>>> * To exclude mutual BO access we rely on bo_reserve exclusion, as all
>>> * function are calling it.
>>> @@ -180,6 +193,18 @@ void radeon_ttm_placement_from_domain(struct
>>> radeon_bo *rbo, u32 domain)
>>> }
>>> }
>>> +static const struct drm_gem_object_funcs radeon_gem_object_funcs = {
>>> + .free = radeon_gem_object_free,
>>> + .open = radeon_gem_object_open,
>>> + .close = radeon_gem_object_close,
>>> + .export = radeon_gem_prime_export,
>>> + .pin = radeon_gem_prime_pin,
>>> + .unpin = radeon_gem_prime_unpin,
>>> + .get_sg_table = radeon_gem_prime_get_sg_table,
>>> + .vmap = radeon_gem_prime_vmap,
>>> + .vunmap = radeon_gem_prime_vunmap,
>>> +};
>>> +
>> Same comment as for amdgpu, please put that into radeon_gem.c instead.
> There's no good header file to put the declarations, right? I'm asking
> because checkpatch warns about declarations in the source files.
Yes, that is kind of a mess because radeon used to support both KMS and UMS.
Thanks for cleaning this up,
Christian.
>
> Best regards
> Thomas
>
>> Christian.
>>
>>> int radeon_bo_create(struct radeon_device *rdev,
>>> unsigned long size, int byte_align, bool kernel,
>>> u32 domain, u32 flags, struct sg_table *sg,
>>> @@ -209,6 +234,7 @@ int radeon_bo_create(struct radeon_device *rdev,
>>> bo = kzalloc(sizeof(struct radeon_bo), GFP_KERNEL);
>>> if (bo == NULL)
>>> return -ENOMEM;
>>> + bo->tbo.base.funcs = &radeon_gem_object_funcs;
>>> drm_gem_private_object_init(rdev->ddev, &bo->tbo.base, size);
>>> bo->rdev = rdev;
>>> bo->surface_reg = -1;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 -----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 ++++++++++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 0f3eb392fe39..b7654f5e4225 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -212,15 +212,10 @@ static const struct file_operations rockchip_drm_driver_fops = {
static struct drm_driver rockchip_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
.lastclose = drm_fb_helper_lastclose,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_get_sg_table = rockchip_gem_prime_get_sg_table,
.gem_prime_import_sg_table = rockchip_gem_prime_import_sg_table,
- .gem_prime_vmap = rockchip_gem_prime_vmap,
- .gem_prime_vunmap = rockchip_gem_prime_vunmap,
.gem_prime_mmap = rockchip_gem_mmap_buf,
.fops = &rockchip_drm_driver_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index b9275ba7c5a5..9724e7b561f3 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -295,6 +295,14 @@ static void rockchip_gem_release_object(struct rockchip_gem_object *rk_obj)
kfree(rk_obj);
}
+static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
+ .free = rockchip_gem_free_object,
+ .get_sg_table = rockchip_gem_prime_get_sg_table,
+ .vmap = rockchip_gem_prime_vmap,
+ .vunmap = rockchip_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct rockchip_gem_object *
rockchip_gem_alloc_object(struct drm_device *drm, unsigned int size)
{
@@ -309,6 +317,8 @@ static struct rockchip_gem_object *
obj = &rk_obj->base;
+ obj->funcs = &rockchip_gem_object_funcs;
+
drm_gem_object_init(drm, obj, size);
return rk_obj;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 -----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 ++++++++++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 0f3eb392fe39..b7654f5e4225 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -212,15 +212,10 @@ static const struct file_operations rockchip_drm_driver_fops = {
static struct drm_driver rockchip_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
.lastclose = drm_fb_helper_lastclose,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_get_sg_table = rockchip_gem_prime_get_sg_table,
.gem_prime_import_sg_table = rockchip_gem_prime_import_sg_table,
- .gem_prime_vmap = rockchip_gem_prime_vmap,
- .gem_prime_vunmap = rockchip_gem_prime_vunmap,
.gem_prime_mmap = rockchip_gem_mmap_buf,
.fops = &rockchip_drm_driver_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index b9275ba7c5a5..9724e7b561f3 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -295,6 +295,14 @@ static void rockchip_gem_release_object(struct rockchip_gem_object *rk_obj)
kfree(rk_obj);
}
+static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
+ .free = rockchip_gem_free_object,
+ .get_sg_table = rockchip_gem_prime_get_sg_table,
+ .vmap = rockchip_gem_prime_vmap,
+ .vunmap = rockchip_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct rockchip_gem_object *
rockchip_gem_alloc_object(struct drm_device *drm, unsigned int size)
{
@@ -309,6 +317,8 @@ static struct rockchip_gem_object *
obj = &rk_obj->base;
+ obj->funcs = &rockchip_gem_object_funcs;
+
drm_gem_object_init(drm, obj, size);
return rk_obj;
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 -----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 ++++++++++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 0f3eb392fe39..b7654f5e4225 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -212,15 +212,10 @@ static const struct file_operations rockchip_drm_driver_fops = {
static struct drm_driver rockchip_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
.lastclose = drm_fb_helper_lastclose,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_get_sg_table = rockchip_gem_prime_get_sg_table,
.gem_prime_import_sg_table = rockchip_gem_prime_import_sg_table,
- .gem_prime_vmap = rockchip_gem_prime_vmap,
- .gem_prime_vunmap = rockchip_gem_prime_vunmap,
.gem_prime_mmap = rockchip_gem_mmap_buf,
.fops = &rockchip_drm_driver_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index b9275ba7c5a5..9724e7b561f3 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -295,6 +295,14 @@ static void rockchip_gem_release_object(struct rockchip_gem_object *rk_obj)
kfree(rk_obj);
}
+static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
+ .free = rockchip_gem_free_object,
+ .get_sg_table = rockchip_gem_prime_get_sg_table,
+ .vmap = rockchip_gem_prime_vmap,
+ .vunmap = rockchip_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct rockchip_gem_object *
rockchip_gem_alloc_object(struct drm_device *drm, unsigned int size)
{
@@ -309,6 +317,8 @@ static struct rockchip_gem_object *
obj = &rk_obj->base;
+ obj->funcs = &rockchip_gem_object_funcs;
+
drm_gem_object_init(drm, obj, size);
return rk_obj;
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 -----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 ++++++++++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 0f3eb392fe39..b7654f5e4225 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -212,15 +212,10 @@ static const struct file_operations rockchip_drm_driver_fops = {
static struct drm_driver rockchip_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
.lastclose = drm_fb_helper_lastclose,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_get_sg_table = rockchip_gem_prime_get_sg_table,
.gem_prime_import_sg_table = rockchip_gem_prime_import_sg_table,
- .gem_prime_vmap = rockchip_gem_prime_vmap,
- .gem_prime_vunmap = rockchip_gem_prime_vunmap,
.gem_prime_mmap = rockchip_gem_mmap_buf,
.fops = &rockchip_drm_driver_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index b9275ba7c5a5..9724e7b561f3 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -295,6 +295,14 @@ static void rockchip_gem_release_object(struct rockchip_gem_object *rk_obj)
kfree(rk_obj);
}
+static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
+ .free = rockchip_gem_free_object,
+ .get_sg_table = rockchip_gem_prime_get_sg_table,
+ .vmap = rockchip_gem_prime_vmap,
+ .vunmap = rockchip_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct rockchip_gem_object *
rockchip_gem_alloc_object(struct drm_device *drm, unsigned int size)
{
@@ -309,6 +317,8 @@ static struct rockchip_gem_object *
obj = &rk_obj->base;
+ obj->funcs = &rockchip_gem_object_funcs;
+
drm_gem_object_init(drm, obj, size);
return rk_obj;
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 -----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 ++++++++++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 0f3eb392fe39..b7654f5e4225 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -212,15 +212,10 @@ static const struct file_operations rockchip_drm_driver_fops = {
static struct drm_driver rockchip_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
.lastclose = drm_fb_helper_lastclose,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_get_sg_table = rockchip_gem_prime_get_sg_table,
.gem_prime_import_sg_table = rockchip_gem_prime_import_sg_table,
- .gem_prime_vmap = rockchip_gem_prime_vmap,
- .gem_prime_vunmap = rockchip_gem_prime_vunmap,
.gem_prime_mmap = rockchip_gem_mmap_buf,
.fops = &rockchip_drm_driver_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index b9275ba7c5a5..9724e7b561f3 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -295,6 +295,14 @@ static void rockchip_gem_release_object(struct rockchip_gem_object *rk_obj)
kfree(rk_obj);
}
+static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
+ .free = rockchip_gem_free_object,
+ .get_sg_table = rockchip_gem_prime_get_sg_table,
+ .vmap = rockchip_gem_prime_vmap,
+ .vunmap = rockchip_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct rockchip_gem_object *
rockchip_gem_alloc_object(struct drm_device *drm, unsigned int size)
{
@@ -309,6 +317,8 @@ static struct rockchip_gem_object *
obj = &rk_obj->base;
+ obj->funcs = &rockchip_gem_object_funcs;
+
drm_gem_object_init(drm, obj, size);
return rk_obj;
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in rockchip. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 5 -----
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 10 ++++++++++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 0f3eb392fe39..b7654f5e4225 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -212,15 +212,10 @@ static const struct file_operations rockchip_drm_driver_fops = {
static struct drm_driver rockchip_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
.lastclose = drm_fb_helper_lastclose,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_get_sg_table = rockchip_gem_prime_get_sg_table,
.gem_prime_import_sg_table = rockchip_gem_prime_import_sg_table,
- .gem_prime_vmap = rockchip_gem_prime_vmap,
- .gem_prime_vunmap = rockchip_gem_prime_vunmap,
.gem_prime_mmap = rockchip_gem_mmap_buf,
.fops = &rockchip_drm_driver_fops,
.name = DRIVER_NAME,
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index b9275ba7c5a5..9724e7b561f3 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -295,6 +295,14 @@ static void rockchip_gem_release_object(struct rockchip_gem_object *rk_obj)
kfree(rk_obj);
}
+static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
+ .free = rockchip_gem_free_object,
+ .get_sg_table = rockchip_gem_prime_get_sg_table,
+ .vmap = rockchip_gem_prime_vmap,
+ .vunmap = rockchip_gem_prime_vunmap,
+ .vm_ops = &drm_gem_cma_vm_ops,
+};
+
static struct rockchip_gem_object *
rockchip_gem_alloc_object(struct drm_device *drm, unsigned int size)
{
@@ -309,6 +317,8 @@ static struct rockchip_gem_object *
obj = &rk_obj->base;
+ obj->funcs = &rockchip_gem_object_funcs;
+
drm_gem_object_init(drm, obj, size);
return rk_obj;
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs
2020-08-13 8:36 ` Thomas Zimmermann
` (4 preceding siblings ...)
(?)
@ 2020-08-13 11:26 ` kernel test robot
-1 siblings, 0 replies; 243+ messages in thread
From: kernel test robot @ 2020-08-13 11:26 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2045 bytes --]
Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on next-20200813]
[cannot apply to drm-intel/for-linux-next linux-arm/drm-armada-devel linux-arm/drm-armada-fixes v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Convert-all-remaining-drivers-to-GEM-object-functions/20200813-163944
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dc06fe51d26efc100ac74121607c01a454867c91
config: arc-allmodconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:303:13: error: 'drm_gem_cma_vm_ops' undeclared here (not in a function); did you mean 'drm_gem_mmap_obj'?
303 | .vm_ops = &drm_gem_cma_vm_ops,
| ^~~~~~~~~~~~~~~~~~
| drm_gem_mmap_obj
vim +303 drivers/gpu/drm/rockchip/rockchip_drm_gem.c
297
298 static const struct drm_gem_object_funcs rockchip_gem_object_funcs = {
299 .free = rockchip_gem_free_object,
300 .get_sg_table = rockchip_gem_prime_get_sg_table,
301 .vmap = rockchip_gem_prime_vmap,
302 .vunmap = rockchip_gem_prime_vunmap,
> 303 .vm_ops = &drm_gem_cma_vm_ops,
304 };
305
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65058 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 14/20] drm/tegra: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in tegra.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/tegra/drm.c | 4 ----
drivers/gpu/drm/tegra/gem.c | 8 ++++++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index ba9d1c3e7cac..f0f581cd345e 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -858,12 +858,8 @@ static struct drm_driver tegra_drm_driver = {
.debugfs_init = tegra_debugfs_init,
#endif
- .gem_free_object_unlocked = tegra_bo_free_object,
- .gem_vm_ops = &tegra_bo_vm_ops,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = tegra_gem_prime_export,
.gem_prime_import = tegra_gem_prime_import,
.dumb_create = tegra_bo_dumb_create,
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 723df142a981..8f3614af580b 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -231,6 +231,12 @@ static int tegra_bo_iommu_unmap(struct tegra_drm *tegra, struct tegra_bo *bo)
return 0;
}
+static const struct drm_gem_object_funcs tegra_gem_object_funcs = {
+ .free = tegra_bo_free_object,
+ .export = tegra_gem_prime_export,
+ .vm_ops = &tegra_bo_vm_ops,
+};
+
static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
size_t size)
{
@@ -241,6 +247,8 @@ static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
if (!bo)
return ERR_PTR(-ENOMEM);
+ bo->gem.funcs = &tegra_gem_object_funcs;
+
host1x_bo_init(&bo->base, &tegra_bo_ops);
size = round_up(size, PAGE_SIZE);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 14/20] drm/tegra: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in tegra.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/tegra/drm.c | 4 ----
drivers/gpu/drm/tegra/gem.c | 8 ++++++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index ba9d1c3e7cac..f0f581cd345e 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -858,12 +858,8 @@ static struct drm_driver tegra_drm_driver = {
.debugfs_init = tegra_debugfs_init,
#endif
- .gem_free_object_unlocked = tegra_bo_free_object,
- .gem_vm_ops = &tegra_bo_vm_ops,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = tegra_gem_prime_export,
.gem_prime_import = tegra_gem_prime_import,
.dumb_create = tegra_bo_dumb_create,
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 723df142a981..8f3614af580b 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -231,6 +231,12 @@ static int tegra_bo_iommu_unmap(struct tegra_drm *tegra, struct tegra_bo *bo)
return 0;
}
+static const struct drm_gem_object_funcs tegra_gem_object_funcs = {
+ .free = tegra_bo_free_object,
+ .export = tegra_gem_prime_export,
+ .vm_ops = &tegra_bo_vm_ops,
+};
+
static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
size_t size)
{
@@ -241,6 +247,8 @@ static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
if (!bo)
return ERR_PTR(-ENOMEM);
+ bo->gem.funcs = &tegra_gem_object_funcs;
+
host1x_bo_init(&bo->base, &tegra_bo_ops);
size = round_up(size, PAGE_SIZE);
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 14/20] drm/tegra: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in tegra.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/tegra/drm.c | 4 ----
drivers/gpu/drm/tegra/gem.c | 8 ++++++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index ba9d1c3e7cac..f0f581cd345e 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -858,12 +858,8 @@ static struct drm_driver tegra_drm_driver = {
.debugfs_init = tegra_debugfs_init,
#endif
- .gem_free_object_unlocked = tegra_bo_free_object,
- .gem_vm_ops = &tegra_bo_vm_ops,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = tegra_gem_prime_export,
.gem_prime_import = tegra_gem_prime_import,
.dumb_create = tegra_bo_dumb_create,
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 723df142a981..8f3614af580b 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -231,6 +231,12 @@ static int tegra_bo_iommu_unmap(struct tegra_drm *tegra, struct tegra_bo *bo)
return 0;
}
+static const struct drm_gem_object_funcs tegra_gem_object_funcs = {
+ .free = tegra_bo_free_object,
+ .export = tegra_gem_prime_export,
+ .vm_ops = &tegra_bo_vm_ops,
+};
+
static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
size_t size)
{
@@ -241,6 +247,8 @@ static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
if (!bo)
return ERR_PTR(-ENOMEM);
+ bo->gem.funcs = &tegra_gem_object_funcs;
+
host1x_bo_init(&bo->base, &tegra_bo_ops);
size = round_up(size, PAGE_SIZE);
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 14/20] drm/tegra: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in tegra.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/tegra/drm.c | 4 ----
drivers/gpu/drm/tegra/gem.c | 8 ++++++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index ba9d1c3e7cac..f0f581cd345e 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -858,12 +858,8 @@ static struct drm_driver tegra_drm_driver = {
.debugfs_init = tegra_debugfs_init,
#endif
- .gem_free_object_unlocked = tegra_bo_free_object,
- .gem_vm_ops = &tegra_bo_vm_ops,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = tegra_gem_prime_export,
.gem_prime_import = tegra_gem_prime_import,
.dumb_create = tegra_bo_dumb_create,
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 723df142a981..8f3614af580b 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -231,6 +231,12 @@ static int tegra_bo_iommu_unmap(struct tegra_drm *tegra, struct tegra_bo *bo)
return 0;
}
+static const struct drm_gem_object_funcs tegra_gem_object_funcs = {
+ .free = tegra_bo_free_object,
+ .export = tegra_gem_prime_export,
+ .vm_ops = &tegra_bo_vm_ops,
+};
+
static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
size_t size)
{
@@ -241,6 +247,8 @@ static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
if (!bo)
return ERR_PTR(-ENOMEM);
+ bo->gem.funcs = &tegra_gem_object_funcs;
+
host1x_bo_init(&bo->base, &tegra_bo_ops);
size = round_up(size, PAGE_SIZE);
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 14/20] drm/tegra: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in tegra.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/tegra/drm.c | 4 ----
drivers/gpu/drm/tegra/gem.c | 8 ++++++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index ba9d1c3e7cac..f0f581cd345e 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -858,12 +858,8 @@ static struct drm_driver tegra_drm_driver = {
.debugfs_init = tegra_debugfs_init,
#endif
- .gem_free_object_unlocked = tegra_bo_free_object,
- .gem_vm_ops = &tegra_bo_vm_ops,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = tegra_gem_prime_export,
.gem_prime_import = tegra_gem_prime_import,
.dumb_create = tegra_bo_dumb_create,
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 723df142a981..8f3614af580b 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -231,6 +231,12 @@ static int tegra_bo_iommu_unmap(struct tegra_drm *tegra, struct tegra_bo *bo)
return 0;
}
+static const struct drm_gem_object_funcs tegra_gem_object_funcs = {
+ .free = tegra_bo_free_object,
+ .export = tegra_gem_prime_export,
+ .vm_ops = &tegra_bo_vm_ops,
+};
+
static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
size_t size)
{
@@ -241,6 +247,8 @@ static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
if (!bo)
return ERR_PTR(-ENOMEM);
+ bo->gem.funcs = &tegra_gem_object_funcs;
+
host1x_bo_init(&bo->base, &tegra_bo_ops);
size = round_up(size, PAGE_SIZE);
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 14/20] drm/tegra: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in tegra.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/tegra/drm.c | 4 ----
drivers/gpu/drm/tegra/gem.c | 8 ++++++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index ba9d1c3e7cac..f0f581cd345e 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -858,12 +858,8 @@ static struct drm_driver tegra_drm_driver = {
.debugfs_init = tegra_debugfs_init,
#endif
- .gem_free_object_unlocked = tegra_bo_free_object,
- .gem_vm_ops = &tegra_bo_vm_ops,
-
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = tegra_gem_prime_export,
.gem_prime_import = tegra_gem_prime_import,
.dumb_create = tegra_bo_dumb_create,
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 723df142a981..8f3614af580b 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -231,6 +231,12 @@ static int tegra_bo_iommu_unmap(struct tegra_drm *tegra, struct tegra_bo *bo)
return 0;
}
+static const struct drm_gem_object_funcs tegra_gem_object_funcs = {
+ .free = tegra_bo_free_object,
+ .export = tegra_gem_prime_export,
+ .vm_ops = &tegra_bo_vm_ops,
+};
+
static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
size_t size)
{
@@ -241,6 +247,8 @@ static struct tegra_bo *tegra_bo_alloc_object(struct drm_device *drm,
if (!bo)
return ERR_PTR(-ENOMEM);
+ bo->gem.funcs = &tegra_gem_object_funcs;
+
host1x_bo_init(&bo->base, &tegra_bo_ops);
size = round_up(size, PAGE_SIZE);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 15/20] drm/vc4: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vc4. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ------------
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 74ceebd62fbc..f432278173cd 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -21,6 +21,8 @@
#include "vc4_drv.h"
#include "uapi/drm/vc4_drm.h"
+static vm_fault_t vc4_fault(struct vm_fault *vmf);
+
static const char * const bo_type_names[] = {
"kernel",
"V3D",
@@ -374,6 +376,21 @@ static struct vc4_bo *vc4_bo_get_from_cache(struct drm_device *dev,
return bo;
}
+static const struct vm_operations_struct vc4_vm_ops = {
+ .fault = vc4_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vc4_gem_object_funcs = {
+ .free = vc4_free_object,
+ .export = vc4_prime_export,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = vc4_prime_vmap,
+ .vunmap = drm_gem_cma_prime_vunmap,
+ .vm_ops = &vc4_vm_ops,
+};
+
/**
* vc4_gem_create_object - Implementation of driver->gem_create_object.
* @dev: DRM device
@@ -400,6 +417,8 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
vc4->bo_labels[VC4_BO_TYPE_KERNEL].size_allocated += size;
mutex_unlock(&vc4->bo_lock);
+ bo->base.base.funcs = &vc4_gem_object_funcs;
+
return &bo->base.base;
}
@@ -684,7 +703,7 @@ struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)
return dmabuf;
}
-vm_fault_t vc4_fault(struct vm_fault *vmf)
+static vm_fault_t vc4_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 38343d2fb4fb..56c702033d79 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -140,12 +140,6 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
kfree(vc4file);
}
-static const struct vm_operations_struct vc4_vm_ops = {
- .fault = vc4_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations vc4_drm_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -195,16 +189,10 @@ static struct drm_driver vc4_drm_driver = {
#endif
.gem_create_object = vc4_create_object,
- .gem_free_object_unlocked = vc4_free_object,
- .gem_vm_ops = &vc4_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = vc4_prime_export,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_import_sg_table = vc4_prime_import_sg_table,
- .gem_prime_vmap = vc4_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
.gem_prime_mmap = vc4_prime_mmap,
.dumb_create = vc4_dumb_create,
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index fa19160c801f..8eac046f3457 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -778,7 +778,6 @@ int vc4_get_hang_state_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
int vc4_label_bo_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
-vm_fault_t vc4_fault(struct vm_fault *vmf);
int vc4_mmap(struct file *filp, struct vm_area_struct *vma);
int vc4_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
struct drm_gem_object *vc4_prime_import_sg_table(struct drm_device *dev,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 15/20] drm/vc4: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vc4. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ------------
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 74ceebd62fbc..f432278173cd 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -21,6 +21,8 @@
#include "vc4_drv.h"
#include "uapi/drm/vc4_drm.h"
+static vm_fault_t vc4_fault(struct vm_fault *vmf);
+
static const char * const bo_type_names[] = {
"kernel",
"V3D",
@@ -374,6 +376,21 @@ static struct vc4_bo *vc4_bo_get_from_cache(struct drm_device *dev,
return bo;
}
+static const struct vm_operations_struct vc4_vm_ops = {
+ .fault = vc4_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vc4_gem_object_funcs = {
+ .free = vc4_free_object,
+ .export = vc4_prime_export,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = vc4_prime_vmap,
+ .vunmap = drm_gem_cma_prime_vunmap,
+ .vm_ops = &vc4_vm_ops,
+};
+
/**
* vc4_gem_create_object - Implementation of driver->gem_create_object.
* @dev: DRM device
@@ -400,6 +417,8 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
vc4->bo_labels[VC4_BO_TYPE_KERNEL].size_allocated += size;
mutex_unlock(&vc4->bo_lock);
+ bo->base.base.funcs = &vc4_gem_object_funcs;
+
return &bo->base.base;
}
@@ -684,7 +703,7 @@ struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)
return dmabuf;
}
-vm_fault_t vc4_fault(struct vm_fault *vmf)
+static vm_fault_t vc4_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 38343d2fb4fb..56c702033d79 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -140,12 +140,6 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
kfree(vc4file);
}
-static const struct vm_operations_struct vc4_vm_ops = {
- .fault = vc4_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations vc4_drm_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -195,16 +189,10 @@ static struct drm_driver vc4_drm_driver = {
#endif
.gem_create_object = vc4_create_object,
- .gem_free_object_unlocked = vc4_free_object,
- .gem_vm_ops = &vc4_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = vc4_prime_export,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_import_sg_table = vc4_prime_import_sg_table,
- .gem_prime_vmap = vc4_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
.gem_prime_mmap = vc4_prime_mmap,
.dumb_create = vc4_dumb_create,
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index fa19160c801f..8eac046f3457 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -778,7 +778,6 @@ int vc4_get_hang_state_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
int vc4_label_bo_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
-vm_fault_t vc4_fault(struct vm_fault *vmf);
int vc4_mmap(struct file *filp, struct vm_area_struct *vma);
int vc4_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
struct drm_gem_object *vc4_prime_import_sg_table(struct drm_device *dev,
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 15/20] drm/vc4: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vc4. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ------------
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 74ceebd62fbc..f432278173cd 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -21,6 +21,8 @@
#include "vc4_drv.h"
#include "uapi/drm/vc4_drm.h"
+static vm_fault_t vc4_fault(struct vm_fault *vmf);
+
static const char * const bo_type_names[] = {
"kernel",
"V3D",
@@ -374,6 +376,21 @@ static struct vc4_bo *vc4_bo_get_from_cache(struct drm_device *dev,
return bo;
}
+static const struct vm_operations_struct vc4_vm_ops = {
+ .fault = vc4_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vc4_gem_object_funcs = {
+ .free = vc4_free_object,
+ .export = vc4_prime_export,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = vc4_prime_vmap,
+ .vunmap = drm_gem_cma_prime_vunmap,
+ .vm_ops = &vc4_vm_ops,
+};
+
/**
* vc4_gem_create_object - Implementation of driver->gem_create_object.
* @dev: DRM device
@@ -400,6 +417,8 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
vc4->bo_labels[VC4_BO_TYPE_KERNEL].size_allocated += size;
mutex_unlock(&vc4->bo_lock);
+ bo->base.base.funcs = &vc4_gem_object_funcs;
+
return &bo->base.base;
}
@@ -684,7 +703,7 @@ struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)
return dmabuf;
}
-vm_fault_t vc4_fault(struct vm_fault *vmf)
+static vm_fault_t vc4_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 38343d2fb4fb..56c702033d79 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -140,12 +140,6 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
kfree(vc4file);
}
-static const struct vm_operations_struct vc4_vm_ops = {
- .fault = vc4_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations vc4_drm_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -195,16 +189,10 @@ static struct drm_driver vc4_drm_driver = {
#endif
.gem_create_object = vc4_create_object,
- .gem_free_object_unlocked = vc4_free_object,
- .gem_vm_ops = &vc4_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = vc4_prime_export,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_import_sg_table = vc4_prime_import_sg_table,
- .gem_prime_vmap = vc4_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
.gem_prime_mmap = vc4_prime_mmap,
.dumb_create = vc4_dumb_create,
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index fa19160c801f..8eac046f3457 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -778,7 +778,6 @@ int vc4_get_hang_state_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
int vc4_label_bo_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
-vm_fault_t vc4_fault(struct vm_fault *vmf);
int vc4_mmap(struct file *filp, struct vm_area_struct *vma);
int vc4_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
struct drm_gem_object *vc4_prime_import_sg_table(struct drm_device *dev,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 15/20] drm/vc4: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vc4. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ------------
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 74ceebd62fbc..f432278173cd 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -21,6 +21,8 @@
#include "vc4_drv.h"
#include "uapi/drm/vc4_drm.h"
+static vm_fault_t vc4_fault(struct vm_fault *vmf);
+
static const char * const bo_type_names[] = {
"kernel",
"V3D",
@@ -374,6 +376,21 @@ static struct vc4_bo *vc4_bo_get_from_cache(struct drm_device *dev,
return bo;
}
+static const struct vm_operations_struct vc4_vm_ops = {
+ .fault = vc4_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vc4_gem_object_funcs = {
+ .free = vc4_free_object,
+ .export = vc4_prime_export,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = vc4_prime_vmap,
+ .vunmap = drm_gem_cma_prime_vunmap,
+ .vm_ops = &vc4_vm_ops,
+};
+
/**
* vc4_gem_create_object - Implementation of driver->gem_create_object.
* @dev: DRM device
@@ -400,6 +417,8 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
vc4->bo_labels[VC4_BO_TYPE_KERNEL].size_allocated += size;
mutex_unlock(&vc4->bo_lock);
+ bo->base.base.funcs = &vc4_gem_object_funcs;
+
return &bo->base.base;
}
@@ -684,7 +703,7 @@ struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)
return dmabuf;
}
-vm_fault_t vc4_fault(struct vm_fault *vmf)
+static vm_fault_t vc4_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 38343d2fb4fb..56c702033d79 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -140,12 +140,6 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
kfree(vc4file);
}
-static const struct vm_operations_struct vc4_vm_ops = {
- .fault = vc4_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations vc4_drm_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -195,16 +189,10 @@ static struct drm_driver vc4_drm_driver = {
#endif
.gem_create_object = vc4_create_object,
- .gem_free_object_unlocked = vc4_free_object,
- .gem_vm_ops = &vc4_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = vc4_prime_export,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_import_sg_table = vc4_prime_import_sg_table,
- .gem_prime_vmap = vc4_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
.gem_prime_mmap = vc4_prime_mmap,
.dumb_create = vc4_dumb_create,
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index fa19160c801f..8eac046f3457 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -778,7 +778,6 @@ int vc4_get_hang_state_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
int vc4_label_bo_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
-vm_fault_t vc4_fault(struct vm_fault *vmf);
int vc4_mmap(struct file *filp, struct vm_area_struct *vma);
int vc4_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
struct drm_gem_object *vc4_prime_import_sg_table(struct drm_device *dev,
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 15/20] drm/vc4: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vc4. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ------------
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 74ceebd62fbc..f432278173cd 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -21,6 +21,8 @@
#include "vc4_drv.h"
#include "uapi/drm/vc4_drm.h"
+static vm_fault_t vc4_fault(struct vm_fault *vmf);
+
static const char * const bo_type_names[] = {
"kernel",
"V3D",
@@ -374,6 +376,21 @@ static struct vc4_bo *vc4_bo_get_from_cache(struct drm_device *dev,
return bo;
}
+static const struct vm_operations_struct vc4_vm_ops = {
+ .fault = vc4_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vc4_gem_object_funcs = {
+ .free = vc4_free_object,
+ .export = vc4_prime_export,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = vc4_prime_vmap,
+ .vunmap = drm_gem_cma_prime_vunmap,
+ .vm_ops = &vc4_vm_ops,
+};
+
/**
* vc4_gem_create_object - Implementation of driver->gem_create_object.
* @dev: DRM device
@@ -400,6 +417,8 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
vc4->bo_labels[VC4_BO_TYPE_KERNEL].size_allocated += size;
mutex_unlock(&vc4->bo_lock);
+ bo->base.base.funcs = &vc4_gem_object_funcs;
+
return &bo->base.base;
}
@@ -684,7 +703,7 @@ struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)
return dmabuf;
}
-vm_fault_t vc4_fault(struct vm_fault *vmf)
+static vm_fault_t vc4_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 38343d2fb4fb..56c702033d79 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -140,12 +140,6 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
kfree(vc4file);
}
-static const struct vm_operations_struct vc4_vm_ops = {
- .fault = vc4_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations vc4_drm_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -195,16 +189,10 @@ static struct drm_driver vc4_drm_driver = {
#endif
.gem_create_object = vc4_create_object,
- .gem_free_object_unlocked = vc4_free_object,
- .gem_vm_ops = &vc4_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = vc4_prime_export,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_import_sg_table = vc4_prime_import_sg_table,
- .gem_prime_vmap = vc4_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
.gem_prime_mmap = vc4_prime_mmap,
.dumb_create = vc4_dumb_create,
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index fa19160c801f..8eac046f3457 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -778,7 +778,6 @@ int vc4_get_hang_state_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
int vc4_label_bo_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
-vm_fault_t vc4_fault(struct vm_fault *vmf);
int vc4_mmap(struct file *filp, struct vm_area_struct *vma);
int vc4_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
struct drm_gem_object *vc4_prime_import_sg_table(struct drm_device *dev,
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 15/20] drm/vc4: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vc4. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/vc4/vc4_bo.c | 21 ++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_drv.c | 12 ------------
drivers/gpu/drm/vc4/vc4_drv.h | 1 -
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 74ceebd62fbc..f432278173cd 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -21,6 +21,8 @@
#include "vc4_drv.h"
#include "uapi/drm/vc4_drm.h"
+static vm_fault_t vc4_fault(struct vm_fault *vmf);
+
static const char * const bo_type_names[] = {
"kernel",
"V3D",
@@ -374,6 +376,21 @@ static struct vc4_bo *vc4_bo_get_from_cache(struct drm_device *dev,
return bo;
}
+static const struct vm_operations_struct vc4_vm_ops = {
+ .fault = vc4_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vc4_gem_object_funcs = {
+ .free = vc4_free_object,
+ .export = vc4_prime_export,
+ .get_sg_table = drm_gem_cma_prime_get_sg_table,
+ .vmap = vc4_prime_vmap,
+ .vunmap = drm_gem_cma_prime_vunmap,
+ .vm_ops = &vc4_vm_ops,
+};
+
/**
* vc4_gem_create_object - Implementation of driver->gem_create_object.
* @dev: DRM device
@@ -400,6 +417,8 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
vc4->bo_labels[VC4_BO_TYPE_KERNEL].size_allocated += size;
mutex_unlock(&vc4->bo_lock);
+ bo->base.base.funcs = &vc4_gem_object_funcs;
+
return &bo->base.base;
}
@@ -684,7 +703,7 @@ struct dma_buf * vc4_prime_export(struct drm_gem_object *obj, int flags)
return dmabuf;
}
-vm_fault_t vc4_fault(struct vm_fault *vmf)
+static vm_fault_t vc4_fault(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
struct drm_gem_object *obj = vma->vm_private_data;
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 38343d2fb4fb..56c702033d79 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -140,12 +140,6 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
kfree(vc4file);
}
-static const struct vm_operations_struct vc4_vm_ops = {
- .fault = vc4_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static const struct file_operations vc4_drm_fops = {
.owner = THIS_MODULE,
.open = drm_open,
@@ -195,16 +189,10 @@ static struct drm_driver vc4_drm_driver = {
#endif
.gem_create_object = vc4_create_object,
- .gem_free_object_unlocked = vc4_free_object,
- .gem_vm_ops = &vc4_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = vc4_prime_export,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
.gem_prime_import_sg_table = vc4_prime_import_sg_table,
- .gem_prime_vmap = vc4_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
.gem_prime_mmap = vc4_prime_mmap,
.dumb_create = vc4_dumb_create,
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index fa19160c801f..8eac046f3457 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -778,7 +778,6 @@ int vc4_get_hang_state_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
int vc4_label_bo_ioctl(struct drm_device *dev, void *data,
struct drm_file *file_priv);
-vm_fault_t vc4_fault(struct vm_fault *vmf);
int vc4_mmap(struct file *filp, struct vm_area_struct *vma);
int vc4_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
struct drm_gem_object *vc4_prime_import_sg_table(struct drm_device *dev,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 16/20] drm/vgem: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vgem. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vgem/vgem_drv.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 313339bbff90..c49f841dd4cd 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -50,6 +50,8 @@
#define DRIVER_MAJOR 1
#define DRIVER_MINOR 0
+static const struct drm_gem_object_funcs vgem_gem_object_funcs;
+
static struct vgem_device {
struct drm_device drm;
struct platform_device *platform;
@@ -167,6 +169,8 @@ static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->base.funcs = &vgem_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &obj->base, roundup(size, PAGE_SIZE));
if (ret) {
kfree(obj);
@@ -408,13 +412,21 @@ static void vgem_release(struct drm_device *dev)
platform_device_unregister(vgem->platform);
}
+static const struct drm_gem_object_funcs vgem_gem_object_funcs = {
+ .free = vgem_gem_free_object,
+ .pin = vgem_prime_pin,
+ .unpin = vgem_prime_unpin,
+ .get_sg_table = vgem_prime_get_sg_table,
+ .vmap = vgem_prime_vmap,
+ .vunmap = vgem_prime_vunmap,
+ .vm_ops = &vgem_gem_vm_ops,
+};
+
static struct drm_driver vgem_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.release = vgem_release,
.open = vgem_open,
.postclose = vgem_postclose,
- .gem_free_object_unlocked = vgem_gem_free_object,
- .gem_vm_ops = &vgem_gem_vm_ops,
.ioctls = vgem_ioctls,
.num_ioctls = ARRAY_SIZE(vgem_ioctls),
.fops = &vgem_driver_fops,
@@ -423,13 +435,8 @@ static struct drm_driver vgem_driver = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = vgem_prime_pin,
- .gem_prime_unpin = vgem_prime_unpin,
.gem_prime_import = vgem_prime_import,
.gem_prime_import_sg_table = vgem_prime_import_sg_table,
- .gem_prime_get_sg_table = vgem_prime_get_sg_table,
- .gem_prime_vmap = vgem_prime_vmap,
- .gem_prime_vunmap = vgem_prime_vunmap,
.gem_prime_mmap = vgem_prime_mmap,
.name = DRIVER_NAME,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 16/20] drm/vgem: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vgem. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vgem/vgem_drv.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 313339bbff90..c49f841dd4cd 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -50,6 +50,8 @@
#define DRIVER_MAJOR 1
#define DRIVER_MINOR 0
+static const struct drm_gem_object_funcs vgem_gem_object_funcs;
+
static struct vgem_device {
struct drm_device drm;
struct platform_device *platform;
@@ -167,6 +169,8 @@ static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->base.funcs = &vgem_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &obj->base, roundup(size, PAGE_SIZE));
if (ret) {
kfree(obj);
@@ -408,13 +412,21 @@ static void vgem_release(struct drm_device *dev)
platform_device_unregister(vgem->platform);
}
+static const struct drm_gem_object_funcs vgem_gem_object_funcs = {
+ .free = vgem_gem_free_object,
+ .pin = vgem_prime_pin,
+ .unpin = vgem_prime_unpin,
+ .get_sg_table = vgem_prime_get_sg_table,
+ .vmap = vgem_prime_vmap,
+ .vunmap = vgem_prime_vunmap,
+ .vm_ops = &vgem_gem_vm_ops,
+};
+
static struct drm_driver vgem_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.release = vgem_release,
.open = vgem_open,
.postclose = vgem_postclose,
- .gem_free_object_unlocked = vgem_gem_free_object,
- .gem_vm_ops = &vgem_gem_vm_ops,
.ioctls = vgem_ioctls,
.num_ioctls = ARRAY_SIZE(vgem_ioctls),
.fops = &vgem_driver_fops,
@@ -423,13 +435,8 @@ static struct drm_driver vgem_driver = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = vgem_prime_pin,
- .gem_prime_unpin = vgem_prime_unpin,
.gem_prime_import = vgem_prime_import,
.gem_prime_import_sg_table = vgem_prime_import_sg_table,
- .gem_prime_get_sg_table = vgem_prime_get_sg_table,
- .gem_prime_vmap = vgem_prime_vmap,
- .gem_prime_vunmap = vgem_prime_vunmap,
.gem_prime_mmap = vgem_prime_mmap,
.name = DRIVER_NAME,
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 16/20] drm/vgem: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vgem. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vgem/vgem_drv.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 313339bbff90..c49f841dd4cd 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -50,6 +50,8 @@
#define DRIVER_MAJOR 1
#define DRIVER_MINOR 0
+static const struct drm_gem_object_funcs vgem_gem_object_funcs;
+
static struct vgem_device {
struct drm_device drm;
struct platform_device *platform;
@@ -167,6 +169,8 @@ static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->base.funcs = &vgem_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &obj->base, roundup(size, PAGE_SIZE));
if (ret) {
kfree(obj);
@@ -408,13 +412,21 @@ static void vgem_release(struct drm_device *dev)
platform_device_unregister(vgem->platform);
}
+static const struct drm_gem_object_funcs vgem_gem_object_funcs = {
+ .free = vgem_gem_free_object,
+ .pin = vgem_prime_pin,
+ .unpin = vgem_prime_unpin,
+ .get_sg_table = vgem_prime_get_sg_table,
+ .vmap = vgem_prime_vmap,
+ .vunmap = vgem_prime_vunmap,
+ .vm_ops = &vgem_gem_vm_ops,
+};
+
static struct drm_driver vgem_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.release = vgem_release,
.open = vgem_open,
.postclose = vgem_postclose,
- .gem_free_object_unlocked = vgem_gem_free_object,
- .gem_vm_ops = &vgem_gem_vm_ops,
.ioctls = vgem_ioctls,
.num_ioctls = ARRAY_SIZE(vgem_ioctls),
.fops = &vgem_driver_fops,
@@ -423,13 +435,8 @@ static struct drm_driver vgem_driver = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = vgem_prime_pin,
- .gem_prime_unpin = vgem_prime_unpin,
.gem_prime_import = vgem_prime_import,
.gem_prime_import_sg_table = vgem_prime_import_sg_table,
- .gem_prime_get_sg_table = vgem_prime_get_sg_table,
- .gem_prime_vmap = vgem_prime_vmap,
- .gem_prime_vunmap = vgem_prime_vunmap,
.gem_prime_mmap = vgem_prime_mmap,
.name = DRIVER_NAME,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 16/20] drm/vgem: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vgem. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vgem/vgem_drv.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 313339bbff90..c49f841dd4cd 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -50,6 +50,8 @@
#define DRIVER_MAJOR 1
#define DRIVER_MINOR 0
+static const struct drm_gem_object_funcs vgem_gem_object_funcs;
+
static struct vgem_device {
struct drm_device drm;
struct platform_device *platform;
@@ -167,6 +169,8 @@ static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->base.funcs = &vgem_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &obj->base, roundup(size, PAGE_SIZE));
if (ret) {
kfree(obj);
@@ -408,13 +412,21 @@ static void vgem_release(struct drm_device *dev)
platform_device_unregister(vgem->platform);
}
+static const struct drm_gem_object_funcs vgem_gem_object_funcs = {
+ .free = vgem_gem_free_object,
+ .pin = vgem_prime_pin,
+ .unpin = vgem_prime_unpin,
+ .get_sg_table = vgem_prime_get_sg_table,
+ .vmap = vgem_prime_vmap,
+ .vunmap = vgem_prime_vunmap,
+ .vm_ops = &vgem_gem_vm_ops,
+};
+
static struct drm_driver vgem_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.release = vgem_release,
.open = vgem_open,
.postclose = vgem_postclose,
- .gem_free_object_unlocked = vgem_gem_free_object,
- .gem_vm_ops = &vgem_gem_vm_ops,
.ioctls = vgem_ioctls,
.num_ioctls = ARRAY_SIZE(vgem_ioctls),
.fops = &vgem_driver_fops,
@@ -423,13 +435,8 @@ static struct drm_driver vgem_driver = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = vgem_prime_pin,
- .gem_prime_unpin = vgem_prime_unpin,
.gem_prime_import = vgem_prime_import,
.gem_prime_import_sg_table = vgem_prime_import_sg_table,
- .gem_prime_get_sg_table = vgem_prime_get_sg_table,
- .gem_prime_vmap = vgem_prime_vmap,
- .gem_prime_vunmap = vgem_prime_vunmap,
.gem_prime_mmap = vgem_prime_mmap,
.name = DRIVER_NAME,
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 16/20] drm/vgem: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vgem. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vgem/vgem_drv.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 313339bbff90..c49f841dd4cd 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -50,6 +50,8 @@
#define DRIVER_MAJOR 1
#define DRIVER_MINOR 0
+static const struct drm_gem_object_funcs vgem_gem_object_funcs;
+
static struct vgem_device {
struct drm_device drm;
struct platform_device *platform;
@@ -167,6 +169,8 @@ static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->base.funcs = &vgem_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &obj->base, roundup(size, PAGE_SIZE));
if (ret) {
kfree(obj);
@@ -408,13 +412,21 @@ static void vgem_release(struct drm_device *dev)
platform_device_unregister(vgem->platform);
}
+static const struct drm_gem_object_funcs vgem_gem_object_funcs = {
+ .free = vgem_gem_free_object,
+ .pin = vgem_prime_pin,
+ .unpin = vgem_prime_unpin,
+ .get_sg_table = vgem_prime_get_sg_table,
+ .vmap = vgem_prime_vmap,
+ .vunmap = vgem_prime_vunmap,
+ .vm_ops = &vgem_gem_vm_ops,
+};
+
static struct drm_driver vgem_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.release = vgem_release,
.open = vgem_open,
.postclose = vgem_postclose,
- .gem_free_object_unlocked = vgem_gem_free_object,
- .gem_vm_ops = &vgem_gem_vm_ops,
.ioctls = vgem_ioctls,
.num_ioctls = ARRAY_SIZE(vgem_ioctls),
.fops = &vgem_driver_fops,
@@ -423,13 +435,8 @@ static struct drm_driver vgem_driver = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = vgem_prime_pin,
- .gem_prime_unpin = vgem_prime_unpin,
.gem_prime_import = vgem_prime_import,
.gem_prime_import_sg_table = vgem_prime_import_sg_table,
- .gem_prime_get_sg_table = vgem_prime_get_sg_table,
- .gem_prime_vmap = vgem_prime_vmap,
- .gem_prime_vunmap = vgem_prime_vunmap,
.gem_prime_mmap = vgem_prime_mmap,
.name = DRIVER_NAME,
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 16/20] drm/vgem: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vgem. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vgem/vgem_drv.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 313339bbff90..c49f841dd4cd 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -50,6 +50,8 @@
#define DRIVER_MAJOR 1
#define DRIVER_MINOR 0
+static const struct drm_gem_object_funcs vgem_gem_object_funcs;
+
static struct vgem_device {
struct drm_device drm;
struct platform_device *platform;
@@ -167,6 +169,8 @@ static struct drm_vgem_gem_object *__vgem_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->base.funcs = &vgem_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &obj->base, roundup(size, PAGE_SIZE));
if (ret) {
kfree(obj);
@@ -408,13 +412,21 @@ static void vgem_release(struct drm_device *dev)
platform_device_unregister(vgem->platform);
}
+static const struct drm_gem_object_funcs vgem_gem_object_funcs = {
+ .free = vgem_gem_free_object,
+ .pin = vgem_prime_pin,
+ .unpin = vgem_prime_unpin,
+ .get_sg_table = vgem_prime_get_sg_table,
+ .vmap = vgem_prime_vmap,
+ .vunmap = vgem_prime_vunmap,
+ .vm_ops = &vgem_gem_vm_ops,
+};
+
static struct drm_driver vgem_driver = {
.driver_features = DRIVER_GEM | DRIVER_RENDER,
.release = vgem_release,
.open = vgem_open,
.postclose = vgem_postclose,
- .gem_free_object_unlocked = vgem_gem_free_object,
- .gem_vm_ops = &vgem_gem_vm_ops,
.ioctls = vgem_ioctls,
.num_ioctls = ARRAY_SIZE(vgem_ioctls),
.fops = &vgem_driver_fops,
@@ -423,13 +435,8 @@ static struct drm_driver vgem_driver = {
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_pin = vgem_prime_pin,
- .gem_prime_unpin = vgem_prime_unpin,
.gem_prime_import = vgem_prime_import,
.gem_prime_import_sg_table = vgem_prime_import_sg_table,
- .gem_prime_get_sg_table = vgem_prime_get_sg_table,
- .gem_prime_vmap = vgem_prime_vmap,
- .gem_prime_vunmap = vgem_prime_vunmap,
.gem_prime_mmap = vgem_prime_mmap,
.name = DRIVER_NAME,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 17/20] drm/vkms: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vkms.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vkms/vkms_drv.c | 8 --------
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++++++++++++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 83dd5567de8b..a3a1ee1f77fb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -51,12 +51,6 @@ static const struct file_operations vkms_driver_fops = {
.release = drm_release,
};
-static const struct vm_operations_struct vkms_gem_vm_ops = {
- .fault = vkms_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static void vkms_release(struct drm_device *dev)
{
struct vkms_device *vkms = container_of(dev, struct vkms_device, drm);
@@ -101,8 +95,6 @@ static struct drm_driver vkms_driver = {
.release = vkms_release,
.fops = &vkms_driver_fops,
.dumb_create = vkms_dumb_create,
- .gem_vm_ops = &vkms_gem_vm_ops,
- .gem_free_object_unlocked = vkms_gem_free_object,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = vkms_prime_import_sg_table,
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index a017fc59905e..19a0e260a4df 100644
--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -7,6 +7,17 @@
#include "vkms_drv.h"
+static const struct vm_operations_struct vkms_gem_vm_ops = {
+ .fault = vkms_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vkms_gem_object_funcs = {
+ .free = vkms_gem_free_object,
+ .vm_ops = &vkms_gem_vm_ops,
+};
+
static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
u64 size)
{
@@ -17,6 +28,8 @@ static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->gem.funcs = &vkms_gem_object_funcs;
+
size = roundup(size, PAGE_SIZE);
ret = drm_gem_object_init(dev, &obj->gem, size);
if (ret) {
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 17/20] drm/vkms: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vkms.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vkms/vkms_drv.c | 8 --------
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++++++++++++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 83dd5567de8b..a3a1ee1f77fb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -51,12 +51,6 @@ static const struct file_operations vkms_driver_fops = {
.release = drm_release,
};
-static const struct vm_operations_struct vkms_gem_vm_ops = {
- .fault = vkms_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static void vkms_release(struct drm_device *dev)
{
struct vkms_device *vkms = container_of(dev, struct vkms_device, drm);
@@ -101,8 +95,6 @@ static struct drm_driver vkms_driver = {
.release = vkms_release,
.fops = &vkms_driver_fops,
.dumb_create = vkms_dumb_create,
- .gem_vm_ops = &vkms_gem_vm_ops,
- .gem_free_object_unlocked = vkms_gem_free_object,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = vkms_prime_import_sg_table,
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index a017fc59905e..19a0e260a4df 100644
--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -7,6 +7,17 @@
#include "vkms_drv.h"
+static const struct vm_operations_struct vkms_gem_vm_ops = {
+ .fault = vkms_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vkms_gem_object_funcs = {
+ .free = vkms_gem_free_object,
+ .vm_ops = &vkms_gem_vm_ops,
+};
+
static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
u64 size)
{
@@ -17,6 +28,8 @@ static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->gem.funcs = &vkms_gem_object_funcs;
+
size = roundup(size, PAGE_SIZE);
ret = drm_gem_object_init(dev, &obj->gem, size);
if (ret) {
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 17/20] drm/vkms: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vkms.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vkms/vkms_drv.c | 8 --------
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++++++++++++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 83dd5567de8b..a3a1ee1f77fb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -51,12 +51,6 @@ static const struct file_operations vkms_driver_fops = {
.release = drm_release,
};
-static const struct vm_operations_struct vkms_gem_vm_ops = {
- .fault = vkms_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static void vkms_release(struct drm_device *dev)
{
struct vkms_device *vkms = container_of(dev, struct vkms_device, drm);
@@ -101,8 +95,6 @@ static struct drm_driver vkms_driver = {
.release = vkms_release,
.fops = &vkms_driver_fops,
.dumb_create = vkms_dumb_create,
- .gem_vm_ops = &vkms_gem_vm_ops,
- .gem_free_object_unlocked = vkms_gem_free_object,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = vkms_prime_import_sg_table,
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index a017fc59905e..19a0e260a4df 100644
--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -7,6 +7,17 @@
#include "vkms_drv.h"
+static const struct vm_operations_struct vkms_gem_vm_ops = {
+ .fault = vkms_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vkms_gem_object_funcs = {
+ .free = vkms_gem_free_object,
+ .vm_ops = &vkms_gem_vm_ops,
+};
+
static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
u64 size)
{
@@ -17,6 +28,8 @@ static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->gem.funcs = &vkms_gem_object_funcs;
+
size = roundup(size, PAGE_SIZE);
ret = drm_gem_object_init(dev, &obj->gem, size);
if (ret) {
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 17/20] drm/vkms: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vkms.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vkms/vkms_drv.c | 8 --------
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++++++++++++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 83dd5567de8b..a3a1ee1f77fb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -51,12 +51,6 @@ static const struct file_operations vkms_driver_fops = {
.release = drm_release,
};
-static const struct vm_operations_struct vkms_gem_vm_ops = {
- .fault = vkms_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static void vkms_release(struct drm_device *dev)
{
struct vkms_device *vkms = container_of(dev, struct vkms_device, drm);
@@ -101,8 +95,6 @@ static struct drm_driver vkms_driver = {
.release = vkms_release,
.fops = &vkms_driver_fops,
.dumb_create = vkms_dumb_create,
- .gem_vm_ops = &vkms_gem_vm_ops,
- .gem_free_object_unlocked = vkms_gem_free_object,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = vkms_prime_import_sg_table,
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index a017fc59905e..19a0e260a4df 100644
--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -7,6 +7,17 @@
#include "vkms_drv.h"
+static const struct vm_operations_struct vkms_gem_vm_ops = {
+ .fault = vkms_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vkms_gem_object_funcs = {
+ .free = vkms_gem_free_object,
+ .vm_ops = &vkms_gem_vm_ops,
+};
+
static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
u64 size)
{
@@ -17,6 +28,8 @@ static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->gem.funcs = &vkms_gem_object_funcs;
+
size = roundup(size, PAGE_SIZE);
ret = drm_gem_object_init(dev, &obj->gem, size);
if (ret) {
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 17/20] drm/vkms: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vkms.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vkms/vkms_drv.c | 8 --------
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++++++++++++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 83dd5567de8b..a3a1ee1f77fb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -51,12 +51,6 @@ static const struct file_operations vkms_driver_fops = {
.release = drm_release,
};
-static const struct vm_operations_struct vkms_gem_vm_ops = {
- .fault = vkms_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static void vkms_release(struct drm_device *dev)
{
struct vkms_device *vkms = container_of(dev, struct vkms_device, drm);
@@ -101,8 +95,6 @@ static struct drm_driver vkms_driver = {
.release = vkms_release,
.fops = &vkms_driver_fops,
.dumb_create = vkms_dumb_create,
- .gem_vm_ops = &vkms_gem_vm_ops,
- .gem_free_object_unlocked = vkms_gem_free_object,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = vkms_prime_import_sg_table,
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index a017fc59905e..19a0e260a4df 100644
--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -7,6 +7,17 @@
#include "vkms_drv.h"
+static const struct vm_operations_struct vkms_gem_vm_ops = {
+ .fault = vkms_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vkms_gem_object_funcs = {
+ .free = vkms_gem_free_object,
+ .vm_ops = &vkms_gem_vm_ops,
+};
+
static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
u64 size)
{
@@ -17,6 +28,8 @@ static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->gem.funcs = &vkms_gem_object_funcs;
+
size = roundup(size, PAGE_SIZE);
ret = drm_gem_object_init(dev, &obj->gem, size);
if (ret) {
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 17/20] drm/vkms: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in vkms.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vkms/vkms_drv.c | 8 --------
drivers/gpu/drm/vkms/vkms_gem.c | 13 +++++++++++++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 83dd5567de8b..a3a1ee1f77fb 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -51,12 +51,6 @@ static const struct file_operations vkms_driver_fops = {
.release = drm_release,
};
-static const struct vm_operations_struct vkms_gem_vm_ops = {
- .fault = vkms_gem_fault,
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static void vkms_release(struct drm_device *dev)
{
struct vkms_device *vkms = container_of(dev, struct vkms_device, drm);
@@ -101,8 +95,6 @@ static struct drm_driver vkms_driver = {
.release = vkms_release,
.fops = &vkms_driver_fops,
.dumb_create = vkms_dumb_create,
- .gem_vm_ops = &vkms_gem_vm_ops,
- .gem_free_object_unlocked = vkms_gem_free_object,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = vkms_prime_import_sg_table,
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index a017fc59905e..19a0e260a4df 100644
--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -7,6 +7,17 @@
#include "vkms_drv.h"
+static const struct vm_operations_struct vkms_gem_vm_ops = {
+ .fault = vkms_gem_fault,
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs vkms_gem_object_funcs = {
+ .free = vkms_gem_free_object,
+ .vm_ops = &vkms_gem_vm_ops,
+};
+
static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
u64 size)
{
@@ -17,6 +28,8 @@ static struct vkms_gem_object *__vkms_gem_create(struct drm_device *dev,
if (!obj)
return ERR_PTR(-ENOMEM);
+ obj->gem.funcs = &vkms_gem_object_funcs;
+
size = roundup(size, PAGE_SIZE);
ret = drm_gem_object_init(dev, &obj->gem, size);
if (ret) {
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread
* [PATCH 18/20] drm/xen: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (3 preceding siblings ...)
(?)
@ 2020-08-13 8:36 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in xen. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 3e660fb111b3..bd9af1875af1 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
return ret;
}
-static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
{
struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
int idx;
@@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
.mmap = xen_drm_front_gem_mmap,
};
-static const struct vm_operations_struct xen_drm_drv_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static struct drm_driver xen_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
.release = xen_drm_drv_release,
- .gem_vm_ops = &xen_drm_drv_vm_ops,
- .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
- .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
- .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
- .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
.gem_prime_mmap = xen_drm_front_gem_prime_mmap,
.dumb_create = xen_drm_drv_dumb_create,
.fops = &xen_drm_dev_fops,
diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index f92c258350ca..93e60c1db550 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
int conn_idx, u64 fb_cookie);
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
+
#endif /* __XEN_DRM_FRONT_H_ */
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index f0b85e094111..7b315c08bcfc 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
xen_obj->pages = NULL;
}
+static const struct vm_operations_struct xen_drm_drv_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
+ .free = xen_drm_drv_free_object_unlocked,
+ .get_sg_table = xen_drm_front_gem_get_sg_table,
+ .vmap = xen_drm_front_gem_prime_vmap,
+ .vunmap = xen_drm_front_gem_prime_vunmap,
+ .vm_ops = &xen_drm_drv_vm_ops,
+};
+
static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
size_t size)
{
@@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
if (!xen_obj)
return ERR_PTR(-ENOMEM);
+ xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &xen_obj->base, size);
if (ret < 0) {
kfree(xen_obj);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in xen. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 3e660fb111b3..bd9af1875af1 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
return ret;
}
-static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
{
struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
int idx;
@@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
.mmap = xen_drm_front_gem_mmap,
};
-static const struct vm_operations_struct xen_drm_drv_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static struct drm_driver xen_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
.release = xen_drm_drv_release,
- .gem_vm_ops = &xen_drm_drv_vm_ops,
- .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
- .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
- .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
- .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
.gem_prime_mmap = xen_drm_front_gem_prime_mmap,
.dumb_create = xen_drm_drv_dumb_create,
.fops = &xen_drm_dev_fops,
diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index f92c258350ca..93e60c1db550 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
int conn_idx, u64 fb_cookie);
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
+
#endif /* __XEN_DRM_FRONT_H_ */
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index f0b85e094111..7b315c08bcfc 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
xen_obj->pages = NULL;
}
+static const struct vm_operations_struct xen_drm_drv_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
+ .free = xen_drm_drv_free_object_unlocked,
+ .get_sg_table = xen_drm_front_gem_get_sg_table,
+ .vmap = xen_drm_front_gem_prime_vmap,
+ .vunmap = xen_drm_front_gem_prime_vunmap,
+ .vm_ops = &xen_drm_drv_vm_ops,
+};
+
static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
size_t size)
{
@@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
if (!xen_obj)
return ERR_PTR(-ENOMEM);
+ xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &xen_obj->base, size);
if (ret < 0) {
kfree(xen_obj);
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in xen. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 3e660fb111b3..bd9af1875af1 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
return ret;
}
-static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
{
struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
int idx;
@@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
.mmap = xen_drm_front_gem_mmap,
};
-static const struct vm_operations_struct xen_drm_drv_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static struct drm_driver xen_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
.release = xen_drm_drv_release,
- .gem_vm_ops = &xen_drm_drv_vm_ops,
- .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
- .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
- .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
- .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
.gem_prime_mmap = xen_drm_front_gem_prime_mmap,
.dumb_create = xen_drm_drv_dumb_create,
.fops = &xen_drm_dev_fops,
diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index f92c258350ca..93e60c1db550 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
int conn_idx, u64 fb_cookie);
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
+
#endif /* __XEN_DRM_FRONT_H_ */
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index f0b85e094111..7b315c08bcfc 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
xen_obj->pages = NULL;
}
+static const struct vm_operations_struct xen_drm_drv_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
+ .free = xen_drm_drv_free_object_unlocked,
+ .get_sg_table = xen_drm_front_gem_get_sg_table,
+ .vmap = xen_drm_front_gem_prime_vmap,
+ .vunmap = xen_drm_front_gem_prime_vunmap,
+ .vm_ops = &xen_drm_drv_vm_ops,
+};
+
static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
size_t size)
{
@@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
if (!xen_obj)
return ERR_PTR(-ENOMEM);
+ xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &xen_obj->base, size);
if (ret < 0) {
kfree(xen_obj);
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in xen. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 3e660fb111b3..bd9af1875af1 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
return ret;
}
-static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
{
struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
int idx;
@@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
.mmap = xen_drm_front_gem_mmap,
};
-static const struct vm_operations_struct xen_drm_drv_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static struct drm_driver xen_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
.release = xen_drm_drv_release,
- .gem_vm_ops = &xen_drm_drv_vm_ops,
- .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
- .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
- .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
- .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
.gem_prime_mmap = xen_drm_front_gem_prime_mmap,
.dumb_create = xen_drm_drv_dumb_create,
.fops = &xen_drm_dev_fops,
diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index f92c258350ca..93e60c1db550 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
int conn_idx, u64 fb_cookie);
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
+
#endif /* __XEN_DRM_FRONT_H_ */
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index f0b85e094111..7b315c08bcfc 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
xen_obj->pages = NULL;
}
+static const struct vm_operations_struct xen_drm_drv_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
+ .free = xen_drm_drv_free_object_unlocked,
+ .get_sg_table = xen_drm_front_gem_get_sg_table,
+ .vmap = xen_drm_front_gem_prime_vmap,
+ .vunmap = xen_drm_front_gem_prime_vunmap,
+ .vm_ops = &xen_drm_drv_vm_ops,
+};
+
static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
size_t size)
{
@@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
if (!xen_obj)
return ERR_PTR(-ENOMEM);
+ xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &xen_obj->base, size);
if (ret < 0) {
kfree(xen_obj);
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in xen. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 3e660fb111b3..bd9af1875af1 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
return ret;
}
-static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
{
struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
int idx;
@@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
.mmap = xen_drm_front_gem_mmap,
};
-static const struct vm_operations_struct xen_drm_drv_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static struct drm_driver xen_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
.release = xen_drm_drv_release,
- .gem_vm_ops = &xen_drm_drv_vm_ops,
- .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
- .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
- .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
- .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
.gem_prime_mmap = xen_drm_front_gem_prime_mmap,
.dumb_create = xen_drm_drv_dumb_create,
.fops = &xen_drm_dev_fops,
diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index f92c258350ca..93e60c1db550 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
int conn_idx, u64 fb_cookie);
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
+
#endif /* __XEN_DRM_FRONT_H_ */
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index f0b85e094111..7b315c08bcfc 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
xen_obj->pages = NULL;
}
+static const struct vm_operations_struct xen_drm_drv_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
+ .free = xen_drm_drv_free_object_unlocked,
+ .get_sg_table = xen_drm_front_gem_get_sg_table,
+ .vmap = xen_drm_front_gem_prime_vmap,
+ .vunmap = xen_drm_front_gem_prime_vunmap,
+ .vm_ops = &xen_drm_drv_vm_ops,
+};
+
static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
size_t size)
{
@@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
if (!xen_obj)
return ERR_PTR(-ENOMEM);
+ xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &xen_obj->base, size);
if (ret < 0) {
kfree(xen_obj);
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, olek
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in
struct drm_driver. This patch replaces the per-driver callbacks with
per-instance callbacks in xen. The only exception is gem_prime_mmap,
which is non-trivial to convert.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 3e660fb111b3..bd9af1875af1 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
return ret;
}
-static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
{
struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
int idx;
@@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
.mmap = xen_drm_front_gem_mmap,
};
-static const struct vm_operations_struct xen_drm_drv_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static struct drm_driver xen_drm_driver = {
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
.release = xen_drm_drv_release,
- .gem_vm_ops = &xen_drm_drv_vm_ops,
- .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
- .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
- .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
- .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
.gem_prime_mmap = xen_drm_front_gem_prime_mmap,
.dumb_create = xen_drm_drv_dumb_create,
.fops = &xen_drm_dev_fops,
diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
index f92c258350ca..93e60c1db550 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.h
+++ b/drivers/gpu/drm/xen/xen_drm_front.h
@@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
int conn_idx, u64 fb_cookie);
+void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
+
#endif /* __XEN_DRM_FRONT_H_ */
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index f0b85e094111..7b315c08bcfc 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
xen_obj->pages = NULL;
}
+static const struct vm_operations_struct xen_drm_drv_vm_ops = {
+ .open = drm_gem_vm_open,
+ .close = drm_gem_vm_close,
+};
+
+static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
+ .free = xen_drm_drv_free_object_unlocked,
+ .get_sg_table = xen_drm_front_gem_get_sg_table,
+ .vmap = xen_drm_front_gem_prime_vmap,
+ .vunmap = xen_drm_front_gem_prime_vunmap,
+ .vm_ops = &xen_drm_drv_vm_ops,
+};
+
static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
size_t size)
{
@@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
if (!xen_obj)
return ERR_PTR(-ENOMEM);
+ xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
+
ret = drm_gem_object_init(dev, &xen_obj->base, size);
if (ret < 0) {
kfree(xen_obj);
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (4 preceding siblings ...)
(?)
@ 2020-08-13 11:19 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 243+ messages in thread
From: Oleksandr Andrushchenko @ 2020-08-13 11:19 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel@lists.xenproject.org
Hi,
On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in xen. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 3e660fb111b3..bd9af1875af1 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> return ret;
> }
>
> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
Can we please have naming consistent and name it as
xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
but starting with xen_drm_front_ as the rest of exported functions?
With this,
Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> {
> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
> int idx;
> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
> .mmap = xen_drm_front_gem_mmap,
> };
>
> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static struct drm_driver xen_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .release = xen_drm_drv_release,
> - .gem_vm_ops = &xen_drm_drv_vm_ops,
> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
> .dumb_create = xen_drm_drv_dumb_create,
> .fops = &xen_drm_dev_fops,
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
> index f92c258350ca..93e60c1db550 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.h
> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
> int conn_idx, u64 fb_cookie);
>
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
> +
> #endif /* __XEN_DRM_FRONT_H_ */
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index f0b85e094111..7b315c08bcfc 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
> xen_obj->pages = NULL;
> }
>
> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
> + .free = xen_drm_drv_free_object_unlocked,
> + .get_sg_table = xen_drm_front_gem_get_sg_table,
> + .vmap = xen_drm_front_gem_prime_vmap,
> + .vunmap = xen_drm_front_gem_prime_vunmap,
> + .vm_ops = &xen_drm_drv_vm_ops,
> +};
> +
> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> size_t size)
> {
> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> if (!xen_obj)
> return ERR_PTR(-ENOMEM);
>
> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
> +
> ret = drm_gem_object_init(dev, &xen_obj->base, size);
> if (ret < 0) {
> kfree(xen_obj);
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 11:19 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 243+ messages in thread
From: Oleksandr Andrushchenko @ 2020-08-13 11:19 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in xen. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 3e660fb111b3..bd9af1875af1 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> return ret;
> }
>
> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
Can we please have naming consistent and name it as
xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
but starting with xen_drm_front_ as the rest of exported functions?
With this,
Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> {
> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
> int idx;
> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
> .mmap = xen_drm_front_gem_mmap,
> };
>
> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static struct drm_driver xen_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .release = xen_drm_drv_release,
> - .gem_vm_ops = &xen_drm_drv_vm_ops,
> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
> .dumb_create = xen_drm_drv_dumb_create,
> .fops = &xen_drm_dev_fops,
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
> index f92c258350ca..93e60c1db550 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.h
> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
> int conn_idx, u64 fb_cookie);
>
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
> +
> #endif /* __XEN_DRM_FRONT_H_ */
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index f0b85e094111..7b315c08bcfc 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
> xen_obj->pages = NULL;
> }
>
> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
> + .free = xen_drm_drv_free_object_unlocked,
> + .get_sg_table = xen_drm_front_gem_get_sg_table,
> + .vmap = xen_drm_front_gem_prime_vmap,
> + .vunmap = xen_drm_front_gem_prime_vunmap,
> + .vm_ops = &xen_drm_drv_vm_ops,
> +};
> +
> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> size_t size)
> {
> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> if (!xen_obj)
> return ERR_PTR(-ENOMEM);
>
> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
> +
> ret = drm_gem_object_init(dev, &xen_obj->base, size);
> if (ret < 0) {
> kfree(xen_obj);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 11:19 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 243+ messages in thread
From: Oleksandr Andrushchenko @ 2020-08-13 11:19 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
Hi,
On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in xen. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 3e660fb111b3..bd9af1875af1 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> return ret;
> }
>
> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
Can we please have naming consistent and name it as
xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
but starting with xen_drm_front_ as the rest of exported functions?
With this,
Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> {
> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
> int idx;
> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
> .mmap = xen_drm_front_gem_mmap,
> };
>
> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static struct drm_driver xen_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .release = xen_drm_drv_release,
> - .gem_vm_ops = &xen_drm_drv_vm_ops,
> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
> .dumb_create = xen_drm_drv_dumb_create,
> .fops = &xen_drm_dev_fops,
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
> index f92c258350ca..93e60c1db550 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.h
> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
> int conn_idx, u64 fb_cookie);
>
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
> +
> #endif /* __XEN_DRM_FRONT_H_ */
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index f0b85e094111..7b315c08bcfc 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
> xen_obj->pages = NULL;
> }
>
> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
> + .free = xen_drm_drv_free_object_unlocked,
> + .get_sg_table = xen_drm_front_gem_get_sg_table,
> + .vmap = xen_drm_front_gem_prime_vmap,
> + .vunmap = xen_drm_front_gem_prime_vunmap,
> + .vm_ops = &xen_drm_drv_vm_ops,
> +};
> +
> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> size_t size)
> {
> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> if (!xen_obj)
> return ERR_PTR(-ENOMEM);
>
> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
> +
> ret = drm_gem_object_init(dev, &xen_obj->base, size);
> if (ret < 0) {
> kfree(xen_obj);
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 11:19 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 243+ messages in thread
From: Oleksandr Andrushchenko @ 2020-08-13 11:19 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in xen. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 3e660fb111b3..bd9af1875af1 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> return ret;
> }
>
> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
Can we please have naming consistent and name it as
xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
but starting with xen_drm_front_ as the rest of exported functions?
With this,
Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> {
> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
> int idx;
> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
> .mmap = xen_drm_front_gem_mmap,
> };
>
> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static struct drm_driver xen_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .release = xen_drm_drv_release,
> - .gem_vm_ops = &xen_drm_drv_vm_ops,
> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
> .dumb_create = xen_drm_drv_dumb_create,
> .fops = &xen_drm_dev_fops,
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
> index f92c258350ca..93e60c1db550 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.h
> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
> int conn_idx, u64 fb_cookie);
>
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
> +
> #endif /* __XEN_DRM_FRONT_H_ */
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index f0b85e094111..7b315c08bcfc 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
> xen_obj->pages = NULL;
> }
>
> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
> + .free = xen_drm_drv_free_object_unlocked,
> + .get_sg_table = xen_drm_front_gem_get_sg_table,
> + .vmap = xen_drm_front_gem_prime_vmap,
> + .vunmap = xen_drm_front_gem_prime_vunmap,
> + .vm_ops = &xen_drm_drv_vm_ops,
> +};
> +
> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> size_t size)
> {
> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> if (!xen_obj)
> return ERR_PTR(-ENOMEM);
>
> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
> +
> ret = drm_gem_object_init(dev, &xen_obj->base, size);
> if (ret < 0) {
> kfree(xen_obj);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 11:19 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 243+ messages in thread
From: Oleksandr Andrushchenko @ 2020-08-13 11:19 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in xen. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 3e660fb111b3..bd9af1875af1 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> return ret;
> }
>
> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
Can we please have naming consistent and name it as
xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
but starting with xen_drm_front_ as the rest of exported functions?
With this,
Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> {
> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
> int idx;
> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
> .mmap = xen_drm_front_gem_mmap,
> };
>
> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static struct drm_driver xen_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .release = xen_drm_drv_release,
> - .gem_vm_ops = &xen_drm_drv_vm_ops,
> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
> .dumb_create = xen_drm_drv_dumb_create,
> .fops = &xen_drm_dev_fops,
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
> index f92c258350ca..93e60c1db550 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.h
> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
> int conn_idx, u64 fb_cookie);
>
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
> +
> #endif /* __XEN_DRM_FRONT_H_ */
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index f0b85e094111..7b315c08bcfc 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
> xen_obj->pages = NULL;
> }
>
> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
> + .free = xen_drm_drv_free_object_unlocked,
> + .get_sg_table = xen_drm_front_gem_get_sg_table,
> + .vmap = xen_drm_front_gem_prime_vmap,
> + .vunmap = xen_drm_front_gem_prime_vunmap,
> + .vm_ops = &xen_drm_drv_vm_ops,
> +};
> +
> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> size_t size)
> {
> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> if (!xen_obj)
> return ERR_PTR(-ENOMEM);
>
> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
> +
> ret = drm_gem_object_init(dev, &xen_obj->base, size);
> if (ret < 0) {
> kfree(xen_obj);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 11:19 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 243+ messages in thread
From: Oleksandr Andrushchenko @ 2020-08-13 11:19 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in xen. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 3e660fb111b3..bd9af1875af1 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> return ret;
> }
>
> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
Can we please have naming consistent and name it as
xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
but starting with xen_drm_front_ as the rest of exported functions?
With this,
Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> {
> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
> int idx;
> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
> .mmap = xen_drm_front_gem_mmap,
> };
>
> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static struct drm_driver xen_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .release = xen_drm_drv_release,
> - .gem_vm_ops = &xen_drm_drv_vm_ops,
> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
> .dumb_create = xen_drm_drv_dumb_create,
> .fops = &xen_drm_dev_fops,
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
> index f92c258350ca..93e60c1db550 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.h
> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
> int conn_idx, u64 fb_cookie);
>
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
> +
> #endif /* __XEN_DRM_FRONT_H_ */
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index f0b85e094111..7b315c08bcfc 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
> xen_obj->pages = NULL;
> }
>
> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
> + .free = xen_drm_drv_free_object_unlocked,
> + .get_sg_table = xen_drm_front_gem_get_sg_table,
> + .vmap = xen_drm_front_gem_prime_vmap,
> + .vunmap = xen_drm_front_gem_prime_vunmap,
> + .vm_ops = &xen_drm_drv_vm_ops,
> +};
> +
> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> size_t size)
> {
> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> if (!xen_obj)
> return ERR_PTR(-ENOMEM);
>
> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
> +
> ret = drm_gem_object_init(dev, &xen_obj->base, size);
> if (ret < 0) {
> kfree(xen_obj);
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-08-13 11:19 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 243+ messages in thread
From: Oleksandr Andrushchenko @ 2020-08-13 11:19 UTC (permalink / raw)
To: Thomas Zimmermann, alexander.deucher, christian.koenig, airlied,
daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
Hi,
On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
> GEM object functions deprecate several similar callback interfaces in
> struct drm_driver. This patch replaces the per-driver callbacks with
> per-instance callbacks in xen. The only exception is gem_prime_mmap,
> which is non-trivial to convert.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 3e660fb111b3..bd9af1875af1 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> return ret;
> }
>
> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
Can we please have naming consistent and name it as
xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
but starting with xen_drm_front_ as the rest of exported functions?
With this,
Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thank you,
Oleksandr
> {
> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
> int idx;
> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
> .mmap = xen_drm_front_gem_mmap,
> };
>
> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> - .open = drm_gem_vm_open,
> - .close = drm_gem_vm_close,
> -};
> -
> static struct drm_driver xen_drm_driver = {
> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
> .release = xen_drm_drv_release,
> - .gem_vm_ops = &xen_drm_drv_vm_ops,
> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
> .dumb_create = xen_drm_drv_dumb_create,
> .fops = &xen_drm_dev_fops,
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
> index f92c258350ca..93e60c1db550 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.h
> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
> int conn_idx, u64 fb_cookie);
>
> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
> +
> #endif /* __XEN_DRM_FRONT_H_ */
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index f0b85e094111..7b315c08bcfc 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
> xen_obj->pages = NULL;
> }
>
> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
> + .open = drm_gem_vm_open,
> + .close = drm_gem_vm_close,
> +};
> +
> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
> + .free = xen_drm_drv_free_object_unlocked,
> + .get_sg_table = xen_drm_front_gem_get_sg_table,
> + .vmap = xen_drm_front_gem_prime_vmap,
> + .vunmap = xen_drm_front_gem_prime_vunmap,
> + .vm_ops = &xen_drm_drv_vm_ops,
> +};
> +
> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> size_t size)
> {
> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
> if (!xen_obj)
> return ERR_PTR(-ENOMEM);
>
> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
> +
> ret = drm_gem_object_init(dev, &xen_obj->base, size);
> if (ret < 0) {
> kfree(xen_obj);
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher, christian.koenig,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 5109 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher, christian.koenig,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 5109 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher, christian.koenig,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 5109 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher, christian.koenig,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 5109 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher, christian.koenig,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 5109 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher, christian.koenig,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 5109 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher, christian.koenig,
airlied, daniel, linux, maarten.lankhorst, mripard, l.stach,
christian.gmeiner, inki.dae, jy0922.shim, sw0312.kim,
kyungmin.park, kgene, krzk, patrik.r.jakobsson, jani.nikula,
joonas.lahtinen, rodrigo.vivi, chunkuang.hu, p.zabel,
matthias.bgg, robdclark, sean, bskeggs, tomi.valkeinen, eric,
hjc, heiko, thierry.reding, jonathanh, rodrigosiqueiramelo,
hamohammed.sa, hyun.kwon, laurent.pinchart, michal.simek,
sumit.semwal, evan.quan, Hawking.Zhang, tianci.yin, marek.olsak,
hdegoede, andrey.grodzovsky, Felix.Kuehling, xinhui.pan,
aaron.liu, nirmoy.das, chris, matthew.auld, abdiel.janulgue,
tvrtko.ursulin, andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, nouveau, linux-tegra,
xen-devel, freedreno, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 5109 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 18/20] drm/xen: Introduce GEM object functions
@ 2020-09-15 8:56 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-09-15 8:56 UTC (permalink / raw)
To: Oleksandr Andrushchenko, alexander.deucher-5C7GfCeVMHo,
christian.koenig-5C7GfCeVMHo, airlied-cv59FeDIM0c,
daniel-/w4YWyX8dFk, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1.1: Type: text/plain, Size: 5150 bytes --]
Hi
Am 13.08.20 um 13:19 schrieb Oleksandr Andrushchenko:
> Hi,
>
> On 8/13/20 11:36 AM, Thomas Zimmermann wrote:
>> GEM object functions deprecate several similar callback interfaces in
>> struct drm_driver. This patch replaces the per-driver callbacks with
>> per-instance callbacks in xen. The only exception is gem_prime_mmap,
>> which is non-trivial to convert.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
>> ---
>> drivers/gpu/drm/xen/xen_drm_front.c | 12 +-----------
>> drivers/gpu/drm/xen/xen_drm_front.h | 2 ++
>> drivers/gpu/drm/xen/xen_drm_front_gem.c | 15 +++++++++++++++
>> 3 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 3e660fb111b3..bd9af1875af1 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -433,7 +433,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>> return ret;
>> }
>>
>> -static void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj)
>
> Can we please have naming consistent and name it as
>
> xen_drm_front_drv_free_object_unlocked or any other name if this seems to be too long,
>
> but starting with xen_drm_front_ as the rest of exported functions?
There already is a function with that name in drm_xen_front_gem.c. I'll
move the callback function next to the object-function structure and
rename it slightly.
Best regards
Thomas
>
> With this,
>
> Acked-by: Oleksandr Andrushchenko <oleksandr_andrushchenko-uRwfk40T5oI@public.gmane.org>
>
> Thank you,
>
> Oleksandr
>
>> {
>> struct xen_drm_front_drm_info *drm_info = obj->dev->dev_private;
>> int idx;
>> @@ -481,22 +481,12 @@ static const struct file_operations xen_drm_dev_fops = {
>> .mmap = xen_drm_front_gem_mmap,
>> };
>>
>> -static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> - .open = drm_gem_vm_open,
>> - .close = drm_gem_vm_close,
>> -};
>> -
>> static struct drm_driver xen_drm_driver = {
>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> .release = xen_drm_drv_release,
>> - .gem_vm_ops = &xen_drm_drv_vm_ops,
>> - .gem_free_object_unlocked = xen_drm_drv_free_object_unlocked,
>> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> .gem_prime_import_sg_table = xen_drm_front_gem_import_sg_table,
>> - .gem_prime_get_sg_table = xen_drm_front_gem_get_sg_table,
>> - .gem_prime_vmap = xen_drm_front_gem_prime_vmap,
>> - .gem_prime_vunmap = xen_drm_front_gem_prime_vunmap,
>> .gem_prime_mmap = xen_drm_front_gem_prime_mmap,
>> .dumb_create = xen_drm_drv_dumb_create,
>> .fops = &xen_drm_dev_fops,
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.h b/drivers/gpu/drm/xen/xen_drm_front.h
>> index f92c258350ca..93e60c1db550 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.h
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.h
>> @@ -160,4 +160,6 @@ int xen_drm_front_page_flip(struct xen_drm_front_info *front_info,
>> void xen_drm_front_on_frame_done(struct xen_drm_front_info *front_info,
>> int conn_idx, u64 fb_cookie);
>>
>> +void xen_drm_drv_free_object_unlocked(struct drm_gem_object *obj);
>> +
>> #endif /* __XEN_DRM_FRONT_H_ */
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> index f0b85e094111..7b315c08bcfc 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
>> @@ -56,6 +56,19 @@ static void gem_free_pages_array(struct xen_gem_object *xen_obj)
>> xen_obj->pages = NULL;
>> }
>>
>> +static const struct vm_operations_struct xen_drm_drv_vm_ops = {
>> + .open = drm_gem_vm_open,
>> + .close = drm_gem_vm_close,
>> +};
>> +
>> +static const struct drm_gem_object_funcs xen_drm_front_gem_object_funcs = {
>> + .free = xen_drm_drv_free_object_unlocked,
>> + .get_sg_table = xen_drm_front_gem_get_sg_table,
>> + .vmap = xen_drm_front_gem_prime_vmap,
>> + .vunmap = xen_drm_front_gem_prime_vunmap,
>> + .vm_ops = &xen_drm_drv_vm_ops,
>> +};
>> +
>> static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> size_t size)
>> {
>> @@ -66,6 +79,8 @@ static struct xen_gem_object *gem_create_obj(struct drm_device *dev,
>> if (!xen_obj)
>> return ERR_PTR(-ENOMEM);
>>
>> + xen_obj->base.funcs = &xen_drm_front_gem_object_funcs;
>> +
>> ret = drm_gem_object_init(dev, &xen_obj->base, size);
>> if (ret < 0) {
>> kfree(xen_obj);
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
The xlnx driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
to their default implementations, so they are just kept empty now.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 26328c76305b..058044dcc062 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM |
DRIVER_ATOMIC,
- .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
- .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = drm_gem_prime_export,
- .gem_prime_import = drm_gem_prime_import,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .dumb_create = zynqmp_dpsub_dumb_create,
- .dumb_destroy = drm_gem_dumb_destroy,
+ DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
.fops = &zynqmp_dpsub_drm_fops,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The xlnx driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
to their default implementations, so they are just kept empty now.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 26328c76305b..058044dcc062 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM |
DRIVER_ATOMIC,
- .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
- .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = drm_gem_prime_export,
- .gem_prime_import = drm_gem_prime_import,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .dumb_create = zynqmp_dpsub_dumb_create,
- .dumb_destroy = drm_gem_dumb_destroy,
+ DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
.fops = &zynqmp_dpsub_drm_fops,
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The xlnx driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
to their default implementations, so they are just kept empty now.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 26328c76305b..058044dcc062 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM |
DRIVER_ATOMIC,
- .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
- .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = drm_gem_prime_export,
- .gem_prime_import = drm_gem_prime_import,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .dumb_create = zynqmp_dpsub_dumb_create,
- .dumb_destroy = drm_gem_dumb_destroy,
+ DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
.fops = &zynqmp_dpsub_drm_fops,
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The xlnx driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
to their default implementations, so they are just kept empty now.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 26328c76305b..058044dcc062 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM |
DRIVER_ATOMIC,
- .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
- .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = drm_gem_prime_export,
- .gem_prime_import = drm_gem_prime_import,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .dumb_create = zynqmp_dpsub_dumb_create,
- .dumb_destroy = drm_gem_dumb_destroy,
+ DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
.fops = &zynqmp_dpsub_drm_fops,
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
The xlnx driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
to their default implementations, so they are just kept empty now.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 26328c76305b..058044dcc062 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM |
DRIVER_ATOMIC,
- .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
- .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = drm_gem_prime_export,
- .gem_prime_import = drm_gem_prime_import,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .dumb_create = zynqmp_dpsub_dumb_create,
- .dumb_destroy = drm_gem_dumb_destroy,
+ DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
.fops = &zynqmp_dpsub_drm_fops,
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
The xlnx driver uses CMA helpers with default callback functions.
Initialize the driver structure with the rsp CMA helper macro. The
driver is being converted to use GEM object functions as part of
this change.
Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
to their default implementations, so they are just kept empty now.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
index 26328c76305b..058044dcc062 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
@@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM |
DRIVER_ATOMIC,
- .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
- .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_prime_export = drm_gem_prime_export,
- .gem_prime_import = drm_gem_prime_import,
- .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_vmap = drm_gem_cma_prime_vmap,
- .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
- .gem_free_object_unlocked = drm_gem_cma_free_object,
- .gem_vm_ops = &drm_gem_cma_vm_ops,
- .dumb_create = zynqmp_dpsub_dumb_create,
- .dumb_destroy = drm_gem_dumb_destroy,
+ DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
.fops = &zynqmp_dpsub_drm_fops,
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:36 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, michal.simek, sumit.semwal, evan.quan, Hawking.Zhang,
tianci.yin, marek.olsak, hdegoede, andrey.grodzovsky,
Felix.Kuehling, xinhui.pan, aaron.liu, nirmoy.das, chris,
matthew.auld, abdiel.janulgue, tvrtko.ursulin, andi.shyti, sam,
miaoqinglang, emil.velikov, amd-gfx, dri-devel, etnaviv,
linux-arm-kernel, linux-samsung-soc, intel-gfx, linux-mediatek,
linux-arm-msm, freedreno, nouveau, linux-rockchip, linux-tegra,
xen-devel
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
>
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 26328c76305b..058044dcc062 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_ATOMIC,
>
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = drm_gem_prime_export,
> - .gem_prime_import = drm_gem_prime_import,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = zynqmp_dpsub_dumb_create,
> - .dumb_destroy = drm_gem_dumb_destroy,
> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
The only effective change here is
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
+ .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
+ .gem_prime_mmap = drm_gem_prime_mmap,
The change is significant, and I have a hard time following the code to
verify that it's correct, or if it's an undesired side effect. If it's
correct, could the change be mentioned in the commit message, with at
least a brief explanation of why this is correct, and what the
consequences here ?
>
> .fops = &zynqmp_dpsub_drm_fops,
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:36 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sam, sumit.semwal, emil.velikov,
abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
patrik.r.jakobsson, jonathanh, linux-rockchip, kgene, bskeggs,
xen-devel, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, miaoqinglang,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
>
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 26328c76305b..058044dcc062 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_ATOMIC,
>
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = drm_gem_prime_export,
> - .gem_prime_import = drm_gem_prime_import,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = zynqmp_dpsub_dumb_create,
> - .dumb_destroy = drm_gem_dumb_destroy,
> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
The only effective change here is
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
+ .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
+ .gem_prime_mmap = drm_gem_prime_mmap,
The change is significant, and I have a hard time following the code to
verify that it's correct, or if it's an undesired side effect. If it's
correct, could the change be mentioned in the commit message, with at
least a brief explanation of why this is correct, and what the
consequences here ?
>
> .fops = &zynqmp_dpsub_drm_fops,
>
--
Regards,
Laurent Pinchart
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:36 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
dri-devel, michal.simek, eric, krzk, sam, sumit.semwal,
emil.velikov, abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
jonathanh, linux-rockchip, kgene, bskeggs, xen-devel, intel-gfx,
matthew.auld, chunkuang.hu, linux-arm-msm, marek.olsak,
tianci.yin, etnaviv, inki.dae, christian.gmeiner, linux-mediatek,
mripard, matthias.bgg, evan.quan, linux-arm-kernel, amd-gfx,
chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, miaoqinglang, kyungmin.park,
nirmoy.das, p.zabel, alexander.deucher, Hawking.Zhang, freedreno,
christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
>
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 26328c76305b..058044dcc062 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_ATOMIC,
>
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = drm_gem_prime_export,
> - .gem_prime_import = drm_gem_prime_import,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = zynqmp_dpsub_dumb_create,
> - .dumb_destroy = drm_gem_dumb_destroy,
> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
The only effective change here is
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
+ .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
+ .gem_prime_mmap = drm_gem_prime_mmap,
The change is significant, and I have a hard time following the code to
verify that it's correct, or if it's an undesired side effect. If it's
correct, could the change be mentioned in the commit message, with at
least a brief explanation of why this is correct, and what the
consequences here ?
>
> .fops = &zynqmp_dpsub_drm_fops,
>
--
Regards,
Laurent Pinchart
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:36 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, airlied, nouveau, dri-devel, michal.simek,
thierry.reding, krzk, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, jonathanh, linux-rockchip,
kgene, bskeggs, xen-devel, intel-gfx, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, marek.olsak, tianci.yin, etnaviv,
hdegoede, linux-mediatek, rodrigo.vivi, matthias.bgg, evan.quan,
sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx, chris,
hyun.kwon, rodrigosiqueiramelo, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, miaoqinglang, kyungmin.park,
nirmoy.das, alexander.deucher, Hawking.Zhang, freedreno,
christian.koenig
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
>
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 26328c76305b..058044dcc062 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_ATOMIC,
>
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = drm_gem_prime_export,
> - .gem_prime_import = drm_gem_prime_import,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = zynqmp_dpsub_dumb_create,
> - .dumb_destroy = drm_gem_dumb_destroy,
> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
The only effective change here is
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
+ .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
+ .gem_prime_mmap = drm_gem_prime_mmap,
The change is significant, and I have a hard time following the code to
verify that it's correct, or if it's an undesired side effect. If it's
correct, could the change be mentioned in the commit message, with at
least a brief explanation of why this is correct, and what the
consequences here ?
>
> .fops = &zynqmp_dpsub_drm_fops,
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:36 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sam, sumit.semwal, emil.velikov,
abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
patrik.r.jakobsson, jonathanh, linux-rockchip, kgene, bskeggs,
xen-devel, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, miaoqinglang,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
>
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 26328c76305b..058044dcc062 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_ATOMIC,
>
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = drm_gem_prime_export,
> - .gem_prime_import = drm_gem_prime_import,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = zynqmp_dpsub_dumb_create,
> - .dumb_destroy = drm_gem_dumb_destroy,
> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
The only effective change here is
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
+ .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
+ .gem_prime_mmap = drm_gem_prime_mmap,
The change is significant, and I have a hard time following the code to
verify that it's correct, or if it's an undesired side effect. If it's
correct, could the change be mentioned in the commit message, with at
least a brief explanation of why this is correct, and what the
consequences here ?
>
> .fops = &zynqmp_dpsub_drm_fops,
>
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:36 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sam, sumit.semwal, emil.velikov,
abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
patrik.r.jakobsson, jonathanh, linux-rockchip, kgene, bskeggs,
xen-devel, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, chris, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, miaoqinglang,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
>
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 26328c76305b..058044dcc062 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_ATOMIC,
>
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = drm_gem_prime_export,
> - .gem_prime_import = drm_gem_prime_import,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = zynqmp_dpsub_dumb_create,
> - .dumb_destroy = drm_gem_dumb_destroy,
> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
The only effective change here is
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
+ .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
+ .gem_prime_mmap = drm_gem_prime_mmap,
The change is significant, and I have a hard time following the code to
verify that it's correct, or if it's an undesired side effect. If it's
correct, could the change be mentioned in the commit message, with at
least a brief explanation of why this is correct, and what the
consequences here ?
>
> .fops = &zynqmp_dpsub_drm_fops,
>
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:36 ` Laurent Pinchart
0 siblings, 0 replies; 243+ messages in thread
From: Laurent Pinchart @ 2020-08-13 13:36 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Hi Thomas,
Thank you for the patch.
On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
>
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
> ---
> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 26328c76305b..058044dcc062 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
> .driver_features = DRIVER_MODESET | DRIVER_GEM |
> DRIVER_ATOMIC,
>
> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> - .gem_prime_export = drm_gem_prime_export,
> - .gem_prime_import = drm_gem_prime_import,
> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> - .gem_free_object_unlocked = drm_gem_cma_free_object,
> - .gem_vm_ops = &drm_gem_cma_vm_ops,
> - .dumb_create = zynqmp_dpsub_dumb_create,
> - .dumb_destroy = drm_gem_dumb_destroy,
> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
The only effective change here is
- .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
- .gem_prime_mmap = drm_gem_cma_prime_mmap,
+ .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
+ .gem_prime_mmap = drm_gem_prime_mmap,
The change is significant, and I have a hard time following the code to
verify that it's correct, or if it's an undesired side effect. If it's
correct, could the change be mentioned in the commit message, with at
least a brief explanation of why this is correct, and what the
consequences here ?
>
> .fops = &zynqmp_dpsub_drm_fops,
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa, airlied, nouveau, dri-devel, michal.simek,
thierry.reding, krzk, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, jonathanh, linux-rockchip,
kgene, bskeggs, xen-devel, intel-gfx, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, marek.olsak, tianci.yin, etnaviv,
hdegoede, linux-mediatek, rodrigo.vivi, matthias.bgg, evan.quan,
sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx, chris,
hyun.kwon, rodrigosiqueiramelo, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, miaoqinglang, kyungmin.park,
nirmoy.das, alexander.deucher, Hawking.Zhang, freedreno,
christian.koenig
[-- Attachment #1.1: Type: text/plain, Size: 3004 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, amd-gfx, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, krzk, jonathanh, linux-rockchip, tomi.valkeinen,
bskeggs, xen-devel, marek.olsak, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, intel-gfx, tianci.yin, nirmoy.das,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, chris,
rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, miaoqinglang, kgene,
alexander.deucher, freedreno, christian.koenig, Hawking.Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 3004 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa, airlied, nouveau, dri-devel, michal.simek,
thierry.reding, krzk, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, jonathanh, linux-rockchip,
kgene, bskeggs, xen-devel, intel-gfx, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, marek.olsak, tianci.yin, etnaviv,
hdegoede, linux-mediatek, rodrigo.vivi, matthias.bgg, evan.quan,
sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx, chris,
hyun.kwon, rodrigosiqueiramelo, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, miaoqinglang, kyungmin.park,
nirmoy.das, alexander.deucher, Hawking.Zhang, freedreno,
christian.koenig
[-- Attachment #1.1: Type: text/plain, Size: 3004 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
amd-gfx, sam, emil.velikov, abdiel.janulgue, linux-samsung-soc,
jy0922.shim, oleksandr_andrushchenko, michal.simek, krzk,
jonathanh, linux-rockchip, tomi.valkeinen, bskeggs, xen-devel,
marek.olsak, matthew.auld, chunkuang.hu, linux-arm-msm,
intel-gfx, tianci.yin, nirmoy.das, etnaviv, linux-mediatek,
linux-tegra, evan.quan, linux-arm-kernel, chris,
rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, miaoqinglang, kgene,
alexander.deucher, freedreno, christian.koenig, Hawking.Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 3004 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, amd-gfx, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, krzk, jonathanh, linux-rockchip, tomi.valkeinen,
bskeggs, xen-devel, marek.olsak, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, intel-gfx, tianci.yin, nirmoy.das,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, chris,
rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, miaoqinglang, kgene,
alexander.deucher, freedreno, christian.koenig, Hawking.Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 3004 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, amd-gfx, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, krzk, jonathanh, linux-rockchip, tomi.valkeinen,
bskeggs, xen-devel, marek.olsak, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, intel-gfx, tianci.yin, nirmoy.das,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, chris,
rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, miaoqinglang, kgene,
alexander.deucher, freedreno, christian.koenig, Hawking.Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 3004 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, amd-gfx, sam, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, krzk, jonathanh, linux-rockchip, tomi.valkeinen,
bskeggs, xen-devel, marek.olsak, matthew.auld, chunkuang.hu,
andi.shyti, linux-arm-msm, intel-gfx, tianci.yin, nirmoy.das,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, chris,
rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, miaoqinglang, kgene,
alexander.deucher, freedreno, christian.koenig, Hawking.Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 3004 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro
@ 2020-08-13 13:57 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 13:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, airlied-cv59FeDIM0c,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
krzk-DgEjT+Ai2ygdnm+yROfE0A, sam-uyr5N9Q2VtJg9hUCZPvPmw,
emil.velikov-ZGY8ohtN/8qB+jHODAdFcQ,
abdiel.janulgue-VuQAYsv1563Yd54FQh9/CA,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
oleksandr_andrushchenko-uRwfk40T5oI, tomi.valkeinen-l0cyMroinI0,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
kgene-DgEjT+Ai2ygdnm+yROfE0A, bskeggs-H+wXaHxf7aLQT0dZR+AlfA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
matthew.auld-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
andi.shyti-ral2JQCrhuEAvxtiuMwx3w,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, marek.olsak-5C7GfCeVMHo,
tianci.yin-5C7GfCeVMHo, etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
hdegoede-H+wXaHxf7aLQT0dZR+AlfA
[-- Attachment #1.1: Type: text/plain, Size: 3025 bytes --]
Hi
Am 13.08.20 um 15:36 schrieb Laurent Pinchart:
> Hi Thomas,
>
> Thank you for the patch.
>
> On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote:
>> The xlnx driver uses CMA helpers with default callback functions.
>> Initialize the driver structure with the rsp CMA helper macro. The
>> driver is being converted to use GEM object functions as part of
>> this change.
>>
>> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
>> to their default implementations, so they are just kept empty now.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
>> ---
>> drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> index 26328c76305b..058044dcc062 100644
>> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
>> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>> .driver_features = DRIVER_MODESET | DRIVER_GEM |
>> DRIVER_ATOMIC,
>>
>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>> - .gem_prime_export = drm_gem_prime_export,
>> - .gem_prime_import = drm_gem_prime_import,
>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
>> - .gem_prime_vmap = drm_gem_cma_prime_vmap,
>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap,
>> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
>> - .gem_free_object_unlocked = drm_gem_cma_free_object,
>> - .gem_vm_ops = &drm_gem_cma_vm_ops,
>> - .dumb_create = zynqmp_dpsub_dumb_create,
>> - .dumb_destroy = drm_gem_dumb_destroy,
>> + DRM_GEM_CMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>
> The only effective change here is
>
> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> - .gem_prime_mmap = drm_gem_cma_prime_mmap,
> + .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap,
> + .gem_prime_mmap = drm_gem_prime_mmap,
>
> The change is significant, and I have a hard time following the code to
> verify that it's correct, or if it's an undesired side effect. If it's
> correct, could the change be mentioned in the commit message, with at
> least a brief explanation of why this is correct, and what the
> consequences here ?
I think this is a mistake that I didn't notice. Thanks for spotting it.
Initializing the driver structure
DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE should fix it. I'll change this
for the patch's next revision.
Best regards
Thomas
>
>>
>> .fops = &zynqmp_dpsub_drm_fops,
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread
* [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: amd-gfx, dri-devel, etnaviv, linux-arm-kernel, linux-samsung-soc,
intel-gfx, linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel, Thomas Zimmermann
Several GEM and PRIME callbacks have been deprecated in favor of
per-instance GEM object functions. Remove the callbacks as they are
now unused. The only exception is .gem_prime_mmap, which is still
in use by several drivers.
What is also gone is gem_vm_ops in struct drm_driver. All drivers now
use struct drm_gem_object_funcs.vm_ops instead.
While at it, the patch also improves error handling around calls
to .free and .get_sg_table callbacks.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gem.c | 35 +++---------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 +++---
include/drm/drm_drv.h | 85 ++--------------------------
4 files changed, 23 insertions(+), 120 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 19d73868490e..96945bed8291 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
{
struct drm_file *file_priv = data;
struct drm_gem_object *obj = ptr;
- struct drm_device *dev = obj->dev;
if (obj->funcs && obj->funcs->close)
obj->funcs->close(obj, file_priv);
- else if (dev->driver->gem_close_object)
- dev->driver->gem_close_object(obj, file_priv);
drm_gem_remove_prime_handles(obj, file_priv);
drm_vma_node_revoke(&obj->vma_node, file_priv);
@@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
ret = obj->funcs->open(obj, file_priv);
if (ret)
goto err_revoke;
- } else if (dev->driver->gem_open_object) {
- ret = dev->driver->gem_open_object(obj, file_priv);
- if (ret)
- goto err_revoke;
}
*handlep = handle;
@@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
{
struct drm_gem_object *obj =
container_of(kref, struct drm_gem_object, refcount);
- struct drm_device *dev = obj->dev;
- if (obj->funcs)
- obj->funcs->free(obj);
- else if (dev->driver->gem_free_object_unlocked)
- dev->driver->gem_free_object_unlocked(obj);
+ if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
+ return;
+
+ obj->funcs->free(obj);
}
EXPORT_SYMBOL(drm_gem_object_free);
@@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* @obj_size: the object size to be mapped, in bytes
* @vma: VMA for the area to be mapped
*
- * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
- * provided by the driver. Depending on their requirements, drivers can either
- * provide a fault handler in their gem_vm_ops (in which case any accesses to
+ * Set up the VMA to prepare mapping of the GEM object using the GEM object's
+ * vm_ops. Depending on their requirements, GEM objects can either
+ * provide a fault handler in their vm_ops (in which case any accesses to
* the object will be trapped, to perform migration, GTT binding, surface
* register allocation, or performance monitoring), or mmap the buffer memory
* synchronously after calling drm_gem_mmap_obj.
@@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* callers must verify access restrictions before calling this helper.
*
* Return 0 or success or -EINVAL if the object size is smaller than the VMA
- * size, or if no gem_vm_ops are provided.
+ * size, or if no vm_ops are provided.
*/
int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
struct vm_area_struct *vma)
{
- struct drm_device *dev = obj->dev;
int ret;
/* Check for valid size. */
@@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
} else {
if (obj->funcs && obj->funcs->vm_ops)
vma->vm_ops = obj->funcs->vm_ops;
- else if (dev->driver->gem_vm_ops)
- vma->vm_ops = dev->driver->gem_vm_ops;
else {
drm_gem_object_put(obj);
return -EINVAL;
@@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->pin)
return obj->funcs->pin(obj);
- else if (obj->dev->driver->gem_prime_pin)
- return obj->dev->driver->gem_prime_pin(obj);
else
return 0;
}
@@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->unpin)
obj->funcs->unpin(obj);
- else if (obj->dev->driver->gem_prime_unpin)
- obj->dev->driver->gem_prime_unpin(obj);
}
void *drm_gem_vmap(struct drm_gem_object *obj)
@@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
if (obj->funcs && obj->funcs->vmap)
vaddr = obj->funcs->vmap(obj);
- else if (obj->dev->driver->gem_prime_vmap)
- vaddr = obj->dev->driver->gem_prime_vmap(obj);
else
vaddr = ERR_PTR(-EOPNOTSUPP);
@@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
if (obj->funcs && obj->funcs->vunmap)
obj->funcs->vunmap(obj, vaddr);
- else if (obj->dev->driver->gem_prime_vunmap)
- obj->dev->driver->gem_prime_vunmap(obj, vaddr);
}
/**
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 822edeadbab3..209202257cc2 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
*
* This function exports a scatter/gather table suitable for PRIME usage by
* calling the standard DMA mapping API. Drivers using the CMA helpers should
- * set this as their &drm_driver.gem_prime_get_sg_table callback.
+ * set this as their &drm_gem_object_funcs.get_sg_table callback.
*
* Returns:
* A pointer to the scatter/gather table of pinned pages or NULL on failure.
@@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
* virtual address space. Since the CMA buffers are already mapped into the
* kernel virtual address space this simply returns the cached virtual
* address. Drivers using the CMA helpers should set this as their DRM
- * driver's &drm_driver.gem_prime_vmap callback.
+ * driver's &drm_gem_object_funcs.vmap callback.
*
* Returns:
* The kernel virtual address of the CMA GEM object's backing store.
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
* This function removes a buffer exported via DRM PRIME from the kernel's
* virtual address space. This is a no-op because CMA buffers cannot be
* unmapped from kernel space. Drivers using the CMA helpers should set this
- * as their &drm_driver.gem_prime_vunmap callback.
+ * as their &drm_gem_object_funcs.vunmap callback.
*/
void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
{
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 1693aa7c14b5..9a87639e7008 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
if (obj->funcs && obj->funcs->export)
dmabuf = obj->funcs->export(obj, flags);
- else if (dev->driver->gem_prime_export)
- dmabuf = dev->driver->gem_prime_export(obj, flags);
- else
- dmabuf = drm_gem_prime_export(obj, flags);
if (IS_ERR(dmabuf)) {
/* normally the created dma-buf takes ownership of the ref,
* but if that fails then drop the ref
@@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
* This is the PRIME export function which must be used mandatorily by GEM
* drivers to ensure correct lifetime management of the underlying GEM object.
* The actual exporting from GEM object to a dma-buf is done through the
- * &drm_driver.gem_prime_export driver callback.
+ * &drm_gem_object_funcs.export callback.
*/
int drm_gem_prime_handle_to_fd(struct drm_device *dev,
struct drm_file *file_priv, uint32_t handle,
@@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
enum dma_data_direction dir)
{
struct drm_gem_object *obj = attach->dmabuf->priv;
- struct sg_table *sgt;
+ struct sg_table *sgt = NULL;
if (WARN_ON(dir == DMA_NONE))
return ERR_PTR(-EINVAL);
- if (obj->funcs)
+ if (obj->funcs && obj->funcs->get_sg_table)
sgt = obj->funcs->get_sg_table(obj);
- else
- sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
+
+ if (!sgt)
+ return ERR_PTR(-EINVAL);
+ else if (IS_ERR(sgt))
+ return sgt;
if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
DMA_ATTR_SKIP_CPU_SYNC)) {
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 7116abc1a04e..8b325bf6cef4 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -36,10 +36,12 @@ struct drm_file;
struct drm_gem_object;
struct drm_master;
struct drm_minor;
+struct dma_buf;
struct dma_buf_attachment;
struct drm_display_mode;
struct drm_mode_create_dumb;
struct drm_printer;
+struct sg_table;
/**
* enum drm_driver_feature - feature flags
@@ -327,32 +329,6 @@ struct drm_driver {
*/
void (*debugfs_init)(struct drm_minor *minor);
- /**
- * @gem_free_object_unlocked: deconstructor for drm_gem_objects
- *
- * This is deprecated and should not be used by new drivers. Use
- * &drm_gem_object_funcs.free instead.
- */
- void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
-
- /**
- * @gem_open_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.open.
- *
- * Driver hook called upon gem handle creation
- */
- int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
-
- /**
- * @gem_close_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.close.
- *
- * Driver hook called upon gem handle release
- */
- void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
-
/**
* @gem_create_object: constructor for gem objects
*
@@ -361,6 +337,7 @@ struct drm_driver {
*/
struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
size_t size);
+
/**
* @prime_handle_to_fd:
*
@@ -383,14 +360,7 @@ struct drm_driver {
*/
int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
int prime_fd, uint32_t *handle);
- /**
- * @gem_prime_export:
- *
- * Export hook for GEM drivers. Deprecated in favour of
- * &drm_gem_object_funcs.export.
- */
- struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
- int flags);
+
/**
* @gem_prime_import:
*
@@ -400,29 +370,6 @@ struct drm_driver {
*/
struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
struct dma_buf *dma_buf);
-
- /**
- * @gem_prime_pin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.pin.
- */
- int (*gem_prime_pin)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_unpin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
- */
- void (*gem_prime_unpin)(struct drm_gem_object *obj);
-
-
- /**
- * @gem_prime_get_sg_table:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
- */
- struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
-
/**
* @gem_prime_import_sg_table:
*
@@ -433,22 +380,6 @@ struct drm_driver {
struct drm_device *dev,
struct dma_buf_attachment *attach,
struct sg_table *sgt);
- /**
- * @gem_prime_vmap:
- *
- * Deprecated vmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vmap instead.
- */
- void *(*gem_prime_vmap)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_vunmap:
- *
- * Deprecated vunmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vunmap instead.
- */
- void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
-
/**
* @gem_prime_mmap:
*
@@ -523,14 +454,6 @@ struct drm_driver {
struct drm_device *dev,
uint32_t handle);
- /**
- * @gem_vm_ops: Driver private ops for this object
- *
- * For GEM drivers this is deprecated in favour of
- * &drm_gem_object_funcs.vm_ops.
- */
- const struct vm_operations_struct *gem_vm_ops;
-
/** @major: driver major number */
int major;
/** @minor: driver minor number */
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
Several GEM and PRIME callbacks have been deprecated in favor of
per-instance GEM object functions. Remove the callbacks as they are
now unused. The only exception is .gem_prime_mmap, which is still
in use by several drivers.
What is also gone is gem_vm_ops in struct drm_driver. All drivers now
use struct drm_gem_object_funcs.vm_ops instead.
While at it, the patch also improves error handling around calls
to .free and .get_sg_table callbacks.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gem.c | 35 +++---------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 +++---
include/drm/drm_drv.h | 85 ++--------------------------
4 files changed, 23 insertions(+), 120 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 19d73868490e..96945bed8291 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
{
struct drm_file *file_priv = data;
struct drm_gem_object *obj = ptr;
- struct drm_device *dev = obj->dev;
if (obj->funcs && obj->funcs->close)
obj->funcs->close(obj, file_priv);
- else if (dev->driver->gem_close_object)
- dev->driver->gem_close_object(obj, file_priv);
drm_gem_remove_prime_handles(obj, file_priv);
drm_vma_node_revoke(&obj->vma_node, file_priv);
@@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
ret = obj->funcs->open(obj, file_priv);
if (ret)
goto err_revoke;
- } else if (dev->driver->gem_open_object) {
- ret = dev->driver->gem_open_object(obj, file_priv);
- if (ret)
- goto err_revoke;
}
*handlep = handle;
@@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
{
struct drm_gem_object *obj =
container_of(kref, struct drm_gem_object, refcount);
- struct drm_device *dev = obj->dev;
- if (obj->funcs)
- obj->funcs->free(obj);
- else if (dev->driver->gem_free_object_unlocked)
- dev->driver->gem_free_object_unlocked(obj);
+ if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
+ return;
+
+ obj->funcs->free(obj);
}
EXPORT_SYMBOL(drm_gem_object_free);
@@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* @obj_size: the object size to be mapped, in bytes
* @vma: VMA for the area to be mapped
*
- * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
- * provided by the driver. Depending on their requirements, drivers can either
- * provide a fault handler in their gem_vm_ops (in which case any accesses to
+ * Set up the VMA to prepare mapping of the GEM object using the GEM object's
+ * vm_ops. Depending on their requirements, GEM objects can either
+ * provide a fault handler in their vm_ops (in which case any accesses to
* the object will be trapped, to perform migration, GTT binding, surface
* register allocation, or performance monitoring), or mmap the buffer memory
* synchronously after calling drm_gem_mmap_obj.
@@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* callers must verify access restrictions before calling this helper.
*
* Return 0 or success or -EINVAL if the object size is smaller than the VMA
- * size, or if no gem_vm_ops are provided.
+ * size, or if no vm_ops are provided.
*/
int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
struct vm_area_struct *vma)
{
- struct drm_device *dev = obj->dev;
int ret;
/* Check for valid size. */
@@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
} else {
if (obj->funcs && obj->funcs->vm_ops)
vma->vm_ops = obj->funcs->vm_ops;
- else if (dev->driver->gem_vm_ops)
- vma->vm_ops = dev->driver->gem_vm_ops;
else {
drm_gem_object_put(obj);
return -EINVAL;
@@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->pin)
return obj->funcs->pin(obj);
- else if (obj->dev->driver->gem_prime_pin)
- return obj->dev->driver->gem_prime_pin(obj);
else
return 0;
}
@@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->unpin)
obj->funcs->unpin(obj);
- else if (obj->dev->driver->gem_prime_unpin)
- obj->dev->driver->gem_prime_unpin(obj);
}
void *drm_gem_vmap(struct drm_gem_object *obj)
@@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
if (obj->funcs && obj->funcs->vmap)
vaddr = obj->funcs->vmap(obj);
- else if (obj->dev->driver->gem_prime_vmap)
- vaddr = obj->dev->driver->gem_prime_vmap(obj);
else
vaddr = ERR_PTR(-EOPNOTSUPP);
@@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
if (obj->funcs && obj->funcs->vunmap)
obj->funcs->vunmap(obj, vaddr);
- else if (obj->dev->driver->gem_prime_vunmap)
- obj->dev->driver->gem_prime_vunmap(obj, vaddr);
}
/**
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 822edeadbab3..209202257cc2 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
*
* This function exports a scatter/gather table suitable for PRIME usage by
* calling the standard DMA mapping API. Drivers using the CMA helpers should
- * set this as their &drm_driver.gem_prime_get_sg_table callback.
+ * set this as their &drm_gem_object_funcs.get_sg_table callback.
*
* Returns:
* A pointer to the scatter/gather table of pinned pages or NULL on failure.
@@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
* virtual address space. Since the CMA buffers are already mapped into the
* kernel virtual address space this simply returns the cached virtual
* address. Drivers using the CMA helpers should set this as their DRM
- * driver's &drm_driver.gem_prime_vmap callback.
+ * driver's &drm_gem_object_funcs.vmap callback.
*
* Returns:
* The kernel virtual address of the CMA GEM object's backing store.
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
* This function removes a buffer exported via DRM PRIME from the kernel's
* virtual address space. This is a no-op because CMA buffers cannot be
* unmapped from kernel space. Drivers using the CMA helpers should set this
- * as their &drm_driver.gem_prime_vunmap callback.
+ * as their &drm_gem_object_funcs.vunmap callback.
*/
void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
{
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 1693aa7c14b5..9a87639e7008 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
if (obj->funcs && obj->funcs->export)
dmabuf = obj->funcs->export(obj, flags);
- else if (dev->driver->gem_prime_export)
- dmabuf = dev->driver->gem_prime_export(obj, flags);
- else
- dmabuf = drm_gem_prime_export(obj, flags);
if (IS_ERR(dmabuf)) {
/* normally the created dma-buf takes ownership of the ref,
* but if that fails then drop the ref
@@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
* This is the PRIME export function which must be used mandatorily by GEM
* drivers to ensure correct lifetime management of the underlying GEM object.
* The actual exporting from GEM object to a dma-buf is done through the
- * &drm_driver.gem_prime_export driver callback.
+ * &drm_gem_object_funcs.export callback.
*/
int drm_gem_prime_handle_to_fd(struct drm_device *dev,
struct drm_file *file_priv, uint32_t handle,
@@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
enum dma_data_direction dir)
{
struct drm_gem_object *obj = attach->dmabuf->priv;
- struct sg_table *sgt;
+ struct sg_table *sgt = NULL;
if (WARN_ON(dir == DMA_NONE))
return ERR_PTR(-EINVAL);
- if (obj->funcs)
+ if (obj->funcs && obj->funcs->get_sg_table)
sgt = obj->funcs->get_sg_table(obj);
- else
- sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
+
+ if (!sgt)
+ return ERR_PTR(-EINVAL);
+ else if (IS_ERR(sgt))
+ return sgt;
if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
DMA_ATTR_SKIP_CPU_SYNC)) {
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 7116abc1a04e..8b325bf6cef4 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -36,10 +36,12 @@ struct drm_file;
struct drm_gem_object;
struct drm_master;
struct drm_minor;
+struct dma_buf;
struct dma_buf_attachment;
struct drm_display_mode;
struct drm_mode_create_dumb;
struct drm_printer;
+struct sg_table;
/**
* enum drm_driver_feature - feature flags
@@ -327,32 +329,6 @@ struct drm_driver {
*/
void (*debugfs_init)(struct drm_minor *minor);
- /**
- * @gem_free_object_unlocked: deconstructor for drm_gem_objects
- *
- * This is deprecated and should not be used by new drivers. Use
- * &drm_gem_object_funcs.free instead.
- */
- void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
-
- /**
- * @gem_open_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.open.
- *
- * Driver hook called upon gem handle creation
- */
- int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
-
- /**
- * @gem_close_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.close.
- *
- * Driver hook called upon gem handle release
- */
- void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
-
/**
* @gem_create_object: constructor for gem objects
*
@@ -361,6 +337,7 @@ struct drm_driver {
*/
struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
size_t size);
+
/**
* @prime_handle_to_fd:
*
@@ -383,14 +360,7 @@ struct drm_driver {
*/
int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
int prime_fd, uint32_t *handle);
- /**
- * @gem_prime_export:
- *
- * Export hook for GEM drivers. Deprecated in favour of
- * &drm_gem_object_funcs.export.
- */
- struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
- int flags);
+
/**
* @gem_prime_import:
*
@@ -400,29 +370,6 @@ struct drm_driver {
*/
struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
struct dma_buf *dma_buf);
-
- /**
- * @gem_prime_pin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.pin.
- */
- int (*gem_prime_pin)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_unpin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
- */
- void (*gem_prime_unpin)(struct drm_gem_object *obj);
-
-
- /**
- * @gem_prime_get_sg_table:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
- */
- struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
-
/**
* @gem_prime_import_sg_table:
*
@@ -433,22 +380,6 @@ struct drm_driver {
struct drm_device *dev,
struct dma_buf_attachment *attach,
struct sg_table *sgt);
- /**
- * @gem_prime_vmap:
- *
- * Deprecated vmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vmap instead.
- */
- void *(*gem_prime_vmap)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_vunmap:
- *
- * Deprecated vunmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vunmap instead.
- */
- void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
-
/**
* @gem_prime_mmap:
*
@@ -523,14 +454,6 @@ struct drm_driver {
struct drm_device *dev,
uint32_t handle);
- /**
- * @gem_vm_ops: Driver private ops for this object
- *
- * For GEM drivers this is deprecated in favour of
- * &drm_gem_object_funcs.vm_ops.
- */
- const struct vm_operations_struct *gem_vm_ops;
-
/** @major: driver major number */
int major;
/** @minor: driver minor number */
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [Intel-gfx] [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
Several GEM and PRIME callbacks have been deprecated in favor of
per-instance GEM object functions. Remove the callbacks as they are
now unused. The only exception is .gem_prime_mmap, which is still
in use by several drivers.
What is also gone is gem_vm_ops in struct drm_driver. All drivers now
use struct drm_gem_object_funcs.vm_ops instead.
While at it, the patch also improves error handling around calls
to .free and .get_sg_table callbacks.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gem.c | 35 +++---------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 +++---
include/drm/drm_drv.h | 85 ++--------------------------
4 files changed, 23 insertions(+), 120 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 19d73868490e..96945bed8291 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
{
struct drm_file *file_priv = data;
struct drm_gem_object *obj = ptr;
- struct drm_device *dev = obj->dev;
if (obj->funcs && obj->funcs->close)
obj->funcs->close(obj, file_priv);
- else if (dev->driver->gem_close_object)
- dev->driver->gem_close_object(obj, file_priv);
drm_gem_remove_prime_handles(obj, file_priv);
drm_vma_node_revoke(&obj->vma_node, file_priv);
@@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
ret = obj->funcs->open(obj, file_priv);
if (ret)
goto err_revoke;
- } else if (dev->driver->gem_open_object) {
- ret = dev->driver->gem_open_object(obj, file_priv);
- if (ret)
- goto err_revoke;
}
*handlep = handle;
@@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
{
struct drm_gem_object *obj =
container_of(kref, struct drm_gem_object, refcount);
- struct drm_device *dev = obj->dev;
- if (obj->funcs)
- obj->funcs->free(obj);
- else if (dev->driver->gem_free_object_unlocked)
- dev->driver->gem_free_object_unlocked(obj);
+ if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
+ return;
+
+ obj->funcs->free(obj);
}
EXPORT_SYMBOL(drm_gem_object_free);
@@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* @obj_size: the object size to be mapped, in bytes
* @vma: VMA for the area to be mapped
*
- * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
- * provided by the driver. Depending on their requirements, drivers can either
- * provide a fault handler in their gem_vm_ops (in which case any accesses to
+ * Set up the VMA to prepare mapping of the GEM object using the GEM object's
+ * vm_ops. Depending on their requirements, GEM objects can either
+ * provide a fault handler in their vm_ops (in which case any accesses to
* the object will be trapped, to perform migration, GTT binding, surface
* register allocation, or performance monitoring), or mmap the buffer memory
* synchronously after calling drm_gem_mmap_obj.
@@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* callers must verify access restrictions before calling this helper.
*
* Return 0 or success or -EINVAL if the object size is smaller than the VMA
- * size, or if no gem_vm_ops are provided.
+ * size, or if no vm_ops are provided.
*/
int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
struct vm_area_struct *vma)
{
- struct drm_device *dev = obj->dev;
int ret;
/* Check for valid size. */
@@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
} else {
if (obj->funcs && obj->funcs->vm_ops)
vma->vm_ops = obj->funcs->vm_ops;
- else if (dev->driver->gem_vm_ops)
- vma->vm_ops = dev->driver->gem_vm_ops;
else {
drm_gem_object_put(obj);
return -EINVAL;
@@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->pin)
return obj->funcs->pin(obj);
- else if (obj->dev->driver->gem_prime_pin)
- return obj->dev->driver->gem_prime_pin(obj);
else
return 0;
}
@@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->unpin)
obj->funcs->unpin(obj);
- else if (obj->dev->driver->gem_prime_unpin)
- obj->dev->driver->gem_prime_unpin(obj);
}
void *drm_gem_vmap(struct drm_gem_object *obj)
@@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
if (obj->funcs && obj->funcs->vmap)
vaddr = obj->funcs->vmap(obj);
- else if (obj->dev->driver->gem_prime_vmap)
- vaddr = obj->dev->driver->gem_prime_vmap(obj);
else
vaddr = ERR_PTR(-EOPNOTSUPP);
@@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
if (obj->funcs && obj->funcs->vunmap)
obj->funcs->vunmap(obj, vaddr);
- else if (obj->dev->driver->gem_prime_vunmap)
- obj->dev->driver->gem_prime_vunmap(obj, vaddr);
}
/**
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 822edeadbab3..209202257cc2 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
*
* This function exports a scatter/gather table suitable for PRIME usage by
* calling the standard DMA mapping API. Drivers using the CMA helpers should
- * set this as their &drm_driver.gem_prime_get_sg_table callback.
+ * set this as their &drm_gem_object_funcs.get_sg_table callback.
*
* Returns:
* A pointer to the scatter/gather table of pinned pages or NULL on failure.
@@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
* virtual address space. Since the CMA buffers are already mapped into the
* kernel virtual address space this simply returns the cached virtual
* address. Drivers using the CMA helpers should set this as their DRM
- * driver's &drm_driver.gem_prime_vmap callback.
+ * driver's &drm_gem_object_funcs.vmap callback.
*
* Returns:
* The kernel virtual address of the CMA GEM object's backing store.
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
* This function removes a buffer exported via DRM PRIME from the kernel's
* virtual address space. This is a no-op because CMA buffers cannot be
* unmapped from kernel space. Drivers using the CMA helpers should set this
- * as their &drm_driver.gem_prime_vunmap callback.
+ * as their &drm_gem_object_funcs.vunmap callback.
*/
void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
{
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 1693aa7c14b5..9a87639e7008 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
if (obj->funcs && obj->funcs->export)
dmabuf = obj->funcs->export(obj, flags);
- else if (dev->driver->gem_prime_export)
- dmabuf = dev->driver->gem_prime_export(obj, flags);
- else
- dmabuf = drm_gem_prime_export(obj, flags);
if (IS_ERR(dmabuf)) {
/* normally the created dma-buf takes ownership of the ref,
* but if that fails then drop the ref
@@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
* This is the PRIME export function which must be used mandatorily by GEM
* drivers to ensure correct lifetime management of the underlying GEM object.
* The actual exporting from GEM object to a dma-buf is done through the
- * &drm_driver.gem_prime_export driver callback.
+ * &drm_gem_object_funcs.export callback.
*/
int drm_gem_prime_handle_to_fd(struct drm_device *dev,
struct drm_file *file_priv, uint32_t handle,
@@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
enum dma_data_direction dir)
{
struct drm_gem_object *obj = attach->dmabuf->priv;
- struct sg_table *sgt;
+ struct sg_table *sgt = NULL;
if (WARN_ON(dir == DMA_NONE))
return ERR_PTR(-EINVAL);
- if (obj->funcs)
+ if (obj->funcs && obj->funcs->get_sg_table)
sgt = obj->funcs->get_sg_table(obj);
- else
- sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
+
+ if (!sgt)
+ return ERR_PTR(-EINVAL);
+ else if (IS_ERR(sgt))
+ return sgt;
if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
DMA_ATTR_SKIP_CPU_SYNC)) {
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 7116abc1a04e..8b325bf6cef4 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -36,10 +36,12 @@ struct drm_file;
struct drm_gem_object;
struct drm_master;
struct drm_minor;
+struct dma_buf;
struct dma_buf_attachment;
struct drm_display_mode;
struct drm_mode_create_dumb;
struct drm_printer;
+struct sg_table;
/**
* enum drm_driver_feature - feature flags
@@ -327,32 +329,6 @@ struct drm_driver {
*/
void (*debugfs_init)(struct drm_minor *minor);
- /**
- * @gem_free_object_unlocked: deconstructor for drm_gem_objects
- *
- * This is deprecated and should not be used by new drivers. Use
- * &drm_gem_object_funcs.free instead.
- */
- void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
-
- /**
- * @gem_open_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.open.
- *
- * Driver hook called upon gem handle creation
- */
- int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
-
- /**
- * @gem_close_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.close.
- *
- * Driver hook called upon gem handle release
- */
- void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
-
/**
* @gem_create_object: constructor for gem objects
*
@@ -361,6 +337,7 @@ struct drm_driver {
*/
struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
size_t size);
+
/**
* @prime_handle_to_fd:
*
@@ -383,14 +360,7 @@ struct drm_driver {
*/
int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
int prime_fd, uint32_t *handle);
- /**
- * @gem_prime_export:
- *
- * Export hook for GEM drivers. Deprecated in favour of
- * &drm_gem_object_funcs.export.
- */
- struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
- int flags);
+
/**
* @gem_prime_import:
*
@@ -400,29 +370,6 @@ struct drm_driver {
*/
struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
struct dma_buf *dma_buf);
-
- /**
- * @gem_prime_pin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.pin.
- */
- int (*gem_prime_pin)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_unpin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
- */
- void (*gem_prime_unpin)(struct drm_gem_object *obj);
-
-
- /**
- * @gem_prime_get_sg_table:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
- */
- struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
-
/**
* @gem_prime_import_sg_table:
*
@@ -433,22 +380,6 @@ struct drm_driver {
struct drm_device *dev,
struct dma_buf_attachment *attach,
struct sg_table *sgt);
- /**
- * @gem_prime_vmap:
- *
- * Deprecated vmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vmap instead.
- */
- void *(*gem_prime_vmap)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_vunmap:
- *
- * Deprecated vunmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vunmap instead.
- */
- void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
-
/**
* @gem_prime_mmap:
*
@@ -523,14 +454,6 @@ struct drm_driver {
struct drm_device *dev,
uint32_t handle);
- /**
- * @gem_vm_ops: Driver private ops for this object
- *
- * For GEM drivers this is deprecated in favour of
- * &drm_gem_object_funcs.vm_ops.
- */
- const struct vm_operations_struct *gem_vm_ops;
-
/** @major: driver major number */
int major;
/** @minor: driver minor number */
--
2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
Several GEM and PRIME callbacks have been deprecated in favor of
per-instance GEM object functions. Remove the callbacks as they are
now unused. The only exception is .gem_prime_mmap, which is still
in use by several drivers.
What is also gone is gem_vm_ops in struct drm_driver. All drivers now
use struct drm_gem_object_funcs.vm_ops instead.
While at it, the patch also improves error handling around calls
to .free and .get_sg_table callbacks.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gem.c | 35 +++---------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 +++---
include/drm/drm_drv.h | 85 ++--------------------------
4 files changed, 23 insertions(+), 120 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 19d73868490e..96945bed8291 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
{
struct drm_file *file_priv = data;
struct drm_gem_object *obj = ptr;
- struct drm_device *dev = obj->dev;
if (obj->funcs && obj->funcs->close)
obj->funcs->close(obj, file_priv);
- else if (dev->driver->gem_close_object)
- dev->driver->gem_close_object(obj, file_priv);
drm_gem_remove_prime_handles(obj, file_priv);
drm_vma_node_revoke(&obj->vma_node, file_priv);
@@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
ret = obj->funcs->open(obj, file_priv);
if (ret)
goto err_revoke;
- } else if (dev->driver->gem_open_object) {
- ret = dev->driver->gem_open_object(obj, file_priv);
- if (ret)
- goto err_revoke;
}
*handlep = handle;
@@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
{
struct drm_gem_object *obj =
container_of(kref, struct drm_gem_object, refcount);
- struct drm_device *dev = obj->dev;
- if (obj->funcs)
- obj->funcs->free(obj);
- else if (dev->driver->gem_free_object_unlocked)
- dev->driver->gem_free_object_unlocked(obj);
+ if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
+ return;
+
+ obj->funcs->free(obj);
}
EXPORT_SYMBOL(drm_gem_object_free);
@@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* @obj_size: the object size to be mapped, in bytes
* @vma: VMA for the area to be mapped
*
- * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
- * provided by the driver. Depending on their requirements, drivers can either
- * provide a fault handler in their gem_vm_ops (in which case any accesses to
+ * Set up the VMA to prepare mapping of the GEM object using the GEM object's
+ * vm_ops. Depending on their requirements, GEM objects can either
+ * provide a fault handler in their vm_ops (in which case any accesses to
* the object will be trapped, to perform migration, GTT binding, surface
* register allocation, or performance monitoring), or mmap the buffer memory
* synchronously after calling drm_gem_mmap_obj.
@@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* callers must verify access restrictions before calling this helper.
*
* Return 0 or success or -EINVAL if the object size is smaller than the VMA
- * size, or if no gem_vm_ops are provided.
+ * size, or if no vm_ops are provided.
*/
int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
struct vm_area_struct *vma)
{
- struct drm_device *dev = obj->dev;
int ret;
/* Check for valid size. */
@@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
} else {
if (obj->funcs && obj->funcs->vm_ops)
vma->vm_ops = obj->funcs->vm_ops;
- else if (dev->driver->gem_vm_ops)
- vma->vm_ops = dev->driver->gem_vm_ops;
else {
drm_gem_object_put(obj);
return -EINVAL;
@@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->pin)
return obj->funcs->pin(obj);
- else if (obj->dev->driver->gem_prime_pin)
- return obj->dev->driver->gem_prime_pin(obj);
else
return 0;
}
@@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->unpin)
obj->funcs->unpin(obj);
- else if (obj->dev->driver->gem_prime_unpin)
- obj->dev->driver->gem_prime_unpin(obj);
}
void *drm_gem_vmap(struct drm_gem_object *obj)
@@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
if (obj->funcs && obj->funcs->vmap)
vaddr = obj->funcs->vmap(obj);
- else if (obj->dev->driver->gem_prime_vmap)
- vaddr = obj->dev->driver->gem_prime_vmap(obj);
else
vaddr = ERR_PTR(-EOPNOTSUPP);
@@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
if (obj->funcs && obj->funcs->vunmap)
obj->funcs->vunmap(obj, vaddr);
- else if (obj->dev->driver->gem_prime_vunmap)
- obj->dev->driver->gem_prime_vunmap(obj, vaddr);
}
/**
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 822edeadbab3..209202257cc2 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
*
* This function exports a scatter/gather table suitable for PRIME usage by
* calling the standard DMA mapping API. Drivers using the CMA helpers should
- * set this as their &drm_driver.gem_prime_get_sg_table callback.
+ * set this as their &drm_gem_object_funcs.get_sg_table callback.
*
* Returns:
* A pointer to the scatter/gather table of pinned pages or NULL on failure.
@@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
* virtual address space. Since the CMA buffers are already mapped into the
* kernel virtual address space this simply returns the cached virtual
* address. Drivers using the CMA helpers should set this as their DRM
- * driver's &drm_driver.gem_prime_vmap callback.
+ * driver's &drm_gem_object_funcs.vmap callback.
*
* Returns:
* The kernel virtual address of the CMA GEM object's backing store.
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
* This function removes a buffer exported via DRM PRIME from the kernel's
* virtual address space. This is a no-op because CMA buffers cannot be
* unmapped from kernel space. Drivers using the CMA helpers should set this
- * as their &drm_driver.gem_prime_vunmap callback.
+ * as their &drm_gem_object_funcs.vunmap callback.
*/
void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
{
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 1693aa7c14b5..9a87639e7008 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
if (obj->funcs && obj->funcs->export)
dmabuf = obj->funcs->export(obj, flags);
- else if (dev->driver->gem_prime_export)
- dmabuf = dev->driver->gem_prime_export(obj, flags);
- else
- dmabuf = drm_gem_prime_export(obj, flags);
if (IS_ERR(dmabuf)) {
/* normally the created dma-buf takes ownership of the ref,
* but if that fails then drop the ref
@@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
* This is the PRIME export function which must be used mandatorily by GEM
* drivers to ensure correct lifetime management of the underlying GEM object.
* The actual exporting from GEM object to a dma-buf is done through the
- * &drm_driver.gem_prime_export driver callback.
+ * &drm_gem_object_funcs.export callback.
*/
int drm_gem_prime_handle_to_fd(struct drm_device *dev,
struct drm_file *file_priv, uint32_t handle,
@@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
enum dma_data_direction dir)
{
struct drm_gem_object *obj = attach->dmabuf->priv;
- struct sg_table *sgt;
+ struct sg_table *sgt = NULL;
if (WARN_ON(dir == DMA_NONE))
return ERR_PTR(-EINVAL);
- if (obj->funcs)
+ if (obj->funcs && obj->funcs->get_sg_table)
sgt = obj->funcs->get_sg_table(obj);
- else
- sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
+
+ if (!sgt)
+ return ERR_PTR(-EINVAL);
+ else if (IS_ERR(sgt))
+ return sgt;
if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
DMA_ATTR_SKIP_CPU_SYNC)) {
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 7116abc1a04e..8b325bf6cef4 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -36,10 +36,12 @@ struct drm_file;
struct drm_gem_object;
struct drm_master;
struct drm_minor;
+struct dma_buf;
struct dma_buf_attachment;
struct drm_display_mode;
struct drm_mode_create_dumb;
struct drm_printer;
+struct sg_table;
/**
* enum drm_driver_feature - feature flags
@@ -327,32 +329,6 @@ struct drm_driver {
*/
void (*debugfs_init)(struct drm_minor *minor);
- /**
- * @gem_free_object_unlocked: deconstructor for drm_gem_objects
- *
- * This is deprecated and should not be used by new drivers. Use
- * &drm_gem_object_funcs.free instead.
- */
- void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
-
- /**
- * @gem_open_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.open.
- *
- * Driver hook called upon gem handle creation
- */
- int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
-
- /**
- * @gem_close_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.close.
- *
- * Driver hook called upon gem handle release
- */
- void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
-
/**
* @gem_create_object: constructor for gem objects
*
@@ -361,6 +337,7 @@ struct drm_driver {
*/
struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
size_t size);
+
/**
* @prime_handle_to_fd:
*
@@ -383,14 +360,7 @@ struct drm_driver {
*/
int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
int prime_fd, uint32_t *handle);
- /**
- * @gem_prime_export:
- *
- * Export hook for GEM drivers. Deprecated in favour of
- * &drm_gem_object_funcs.export.
- */
- struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
- int flags);
+
/**
* @gem_prime_import:
*
@@ -400,29 +370,6 @@ struct drm_driver {
*/
struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
struct dma_buf *dma_buf);
-
- /**
- * @gem_prime_pin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.pin.
- */
- int (*gem_prime_pin)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_unpin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
- */
- void (*gem_prime_unpin)(struct drm_gem_object *obj);
-
-
- /**
- * @gem_prime_get_sg_table:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
- */
- struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
-
/**
* @gem_prime_import_sg_table:
*
@@ -433,22 +380,6 @@ struct drm_driver {
struct drm_device *dev,
struct dma_buf_attachment *attach,
struct sg_table *sgt);
- /**
- * @gem_prime_vmap:
- *
- * Deprecated vmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vmap instead.
- */
- void *(*gem_prime_vmap)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_vunmap:
- *
- * Deprecated vunmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vunmap instead.
- */
- void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
-
/**
* @gem_prime_mmap:
*
@@ -523,14 +454,6 @@ struct drm_driver {
struct drm_device *dev,
uint32_t handle);
- /**
- * @gem_vm_ops: Driver private ops for this object
- *
- * For GEM drivers this is deprecated in favour of
- * &drm_gem_object_funcs.vm_ops.
- */
- const struct vm_operations_struct *gem_vm_ops;
-
/** @major: driver major number */
int major;
/** @minor: driver minor number */
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, sam, miaoqinglang, emil.velikov
Cc: linux-samsung-soc, linux-arm-msm, intel-gfx, etnaviv, dri-devel,
linux-rockchip, linux-mediatek, amd-gfx, Thomas Zimmermann,
nouveau, linux-tegra, xen-devel, freedreno, linux-arm-kernel
Several GEM and PRIME callbacks have been deprecated in favor of
per-instance GEM object functions. Remove the callbacks as they are
now unused. The only exception is .gem_prime_mmap, which is still
in use by several drivers.
What is also gone is gem_vm_ops in struct drm_driver. All drivers now
use struct drm_gem_object_funcs.vm_ops instead.
While at it, the patch also improves error handling around calls
to .free and .get_sg_table callbacks.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gem.c | 35 +++---------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 +++---
include/drm/drm_drv.h | 85 ++--------------------------
4 files changed, 23 insertions(+), 120 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 19d73868490e..96945bed8291 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
{
struct drm_file *file_priv = data;
struct drm_gem_object *obj = ptr;
- struct drm_device *dev = obj->dev;
if (obj->funcs && obj->funcs->close)
obj->funcs->close(obj, file_priv);
- else if (dev->driver->gem_close_object)
- dev->driver->gem_close_object(obj, file_priv);
drm_gem_remove_prime_handles(obj, file_priv);
drm_vma_node_revoke(&obj->vma_node, file_priv);
@@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
ret = obj->funcs->open(obj, file_priv);
if (ret)
goto err_revoke;
- } else if (dev->driver->gem_open_object) {
- ret = dev->driver->gem_open_object(obj, file_priv);
- if (ret)
- goto err_revoke;
}
*handlep = handle;
@@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
{
struct drm_gem_object *obj =
container_of(kref, struct drm_gem_object, refcount);
- struct drm_device *dev = obj->dev;
- if (obj->funcs)
- obj->funcs->free(obj);
- else if (dev->driver->gem_free_object_unlocked)
- dev->driver->gem_free_object_unlocked(obj);
+ if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
+ return;
+
+ obj->funcs->free(obj);
}
EXPORT_SYMBOL(drm_gem_object_free);
@@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* @obj_size: the object size to be mapped, in bytes
* @vma: VMA for the area to be mapped
*
- * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
- * provided by the driver. Depending on their requirements, drivers can either
- * provide a fault handler in their gem_vm_ops (in which case any accesses to
+ * Set up the VMA to prepare mapping of the GEM object using the GEM object's
+ * vm_ops. Depending on their requirements, GEM objects can either
+ * provide a fault handler in their vm_ops (in which case any accesses to
* the object will be trapped, to perform migration, GTT binding, surface
* register allocation, or performance monitoring), or mmap the buffer memory
* synchronously after calling drm_gem_mmap_obj.
@@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* callers must verify access restrictions before calling this helper.
*
* Return 0 or success or -EINVAL if the object size is smaller than the VMA
- * size, or if no gem_vm_ops are provided.
+ * size, or if no vm_ops are provided.
*/
int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
struct vm_area_struct *vma)
{
- struct drm_device *dev = obj->dev;
int ret;
/* Check for valid size. */
@@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
} else {
if (obj->funcs && obj->funcs->vm_ops)
vma->vm_ops = obj->funcs->vm_ops;
- else if (dev->driver->gem_vm_ops)
- vma->vm_ops = dev->driver->gem_vm_ops;
else {
drm_gem_object_put(obj);
return -EINVAL;
@@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->pin)
return obj->funcs->pin(obj);
- else if (obj->dev->driver->gem_prime_pin)
- return obj->dev->driver->gem_prime_pin(obj);
else
return 0;
}
@@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->unpin)
obj->funcs->unpin(obj);
- else if (obj->dev->driver->gem_prime_unpin)
- obj->dev->driver->gem_prime_unpin(obj);
}
void *drm_gem_vmap(struct drm_gem_object *obj)
@@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
if (obj->funcs && obj->funcs->vmap)
vaddr = obj->funcs->vmap(obj);
- else if (obj->dev->driver->gem_prime_vmap)
- vaddr = obj->dev->driver->gem_prime_vmap(obj);
else
vaddr = ERR_PTR(-EOPNOTSUPP);
@@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
if (obj->funcs && obj->funcs->vunmap)
obj->funcs->vunmap(obj, vaddr);
- else if (obj->dev->driver->gem_prime_vunmap)
- obj->dev->driver->gem_prime_vunmap(obj, vaddr);
}
/**
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 822edeadbab3..209202257cc2 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
*
* This function exports a scatter/gather table suitable for PRIME usage by
* calling the standard DMA mapping API. Drivers using the CMA helpers should
- * set this as their &drm_driver.gem_prime_get_sg_table callback.
+ * set this as their &drm_gem_object_funcs.get_sg_table callback.
*
* Returns:
* A pointer to the scatter/gather table of pinned pages or NULL on failure.
@@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
* virtual address space. Since the CMA buffers are already mapped into the
* kernel virtual address space this simply returns the cached virtual
* address. Drivers using the CMA helpers should set this as their DRM
- * driver's &drm_driver.gem_prime_vmap callback.
+ * driver's &drm_gem_object_funcs.vmap callback.
*
* Returns:
* The kernel virtual address of the CMA GEM object's backing store.
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
* This function removes a buffer exported via DRM PRIME from the kernel's
* virtual address space. This is a no-op because CMA buffers cannot be
* unmapped from kernel space. Drivers using the CMA helpers should set this
- * as their &drm_driver.gem_prime_vunmap callback.
+ * as their &drm_gem_object_funcs.vunmap callback.
*/
void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
{
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 1693aa7c14b5..9a87639e7008 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
if (obj->funcs && obj->funcs->export)
dmabuf = obj->funcs->export(obj, flags);
- else if (dev->driver->gem_prime_export)
- dmabuf = dev->driver->gem_prime_export(obj, flags);
- else
- dmabuf = drm_gem_prime_export(obj, flags);
if (IS_ERR(dmabuf)) {
/* normally the created dma-buf takes ownership of the ref,
* but if that fails then drop the ref
@@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
* This is the PRIME export function which must be used mandatorily by GEM
* drivers to ensure correct lifetime management of the underlying GEM object.
* The actual exporting from GEM object to a dma-buf is done through the
- * &drm_driver.gem_prime_export driver callback.
+ * &drm_gem_object_funcs.export callback.
*/
int drm_gem_prime_handle_to_fd(struct drm_device *dev,
struct drm_file *file_priv, uint32_t handle,
@@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
enum dma_data_direction dir)
{
struct drm_gem_object *obj = attach->dmabuf->priv;
- struct sg_table *sgt;
+ struct sg_table *sgt = NULL;
if (WARN_ON(dir == DMA_NONE))
return ERR_PTR(-EINVAL);
- if (obj->funcs)
+ if (obj->funcs && obj->funcs->get_sg_table)
sgt = obj->funcs->get_sg_table(obj);
- else
- sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
+
+ if (!sgt)
+ return ERR_PTR(-EINVAL);
+ else if (IS_ERR(sgt))
+ return sgt;
if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
DMA_ATTR_SKIP_CPU_SYNC)) {
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 7116abc1a04e..8b325bf6cef4 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -36,10 +36,12 @@ struct drm_file;
struct drm_gem_object;
struct drm_master;
struct drm_minor;
+struct dma_buf;
struct dma_buf_attachment;
struct drm_display_mode;
struct drm_mode_create_dumb;
struct drm_printer;
+struct sg_table;
/**
* enum drm_driver_feature - feature flags
@@ -327,32 +329,6 @@ struct drm_driver {
*/
void (*debugfs_init)(struct drm_minor *minor);
- /**
- * @gem_free_object_unlocked: deconstructor for drm_gem_objects
- *
- * This is deprecated and should not be used by new drivers. Use
- * &drm_gem_object_funcs.free instead.
- */
- void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
-
- /**
- * @gem_open_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.open.
- *
- * Driver hook called upon gem handle creation
- */
- int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
-
- /**
- * @gem_close_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.close.
- *
- * Driver hook called upon gem handle release
- */
- void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
-
/**
* @gem_create_object: constructor for gem objects
*
@@ -361,6 +337,7 @@ struct drm_driver {
*/
struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
size_t size);
+
/**
* @prime_handle_to_fd:
*
@@ -383,14 +360,7 @@ struct drm_driver {
*/
int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
int prime_fd, uint32_t *handle);
- /**
- * @gem_prime_export:
- *
- * Export hook for GEM drivers. Deprecated in favour of
- * &drm_gem_object_funcs.export.
- */
- struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
- int flags);
+
/**
* @gem_prime_import:
*
@@ -400,29 +370,6 @@ struct drm_driver {
*/
struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
struct dma_buf *dma_buf);
-
- /**
- * @gem_prime_pin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.pin.
- */
- int (*gem_prime_pin)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_unpin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
- */
- void (*gem_prime_unpin)(struct drm_gem_object *obj);
-
-
- /**
- * @gem_prime_get_sg_table:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
- */
- struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
-
/**
* @gem_prime_import_sg_table:
*
@@ -433,22 +380,6 @@ struct drm_driver {
struct drm_device *dev,
struct dma_buf_attachment *attach,
struct sg_table *sgt);
- /**
- * @gem_prime_vmap:
- *
- * Deprecated vmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vmap instead.
- */
- void *(*gem_prime_vmap)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_vunmap:
- *
- * Deprecated vunmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vunmap instead.
- */
- void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
-
/**
* @gem_prime_mmap:
*
@@ -523,14 +454,6 @@ struct drm_driver {
struct drm_device *dev,
uint32_t handle);
- /**
- * @gem_vm_ops: Driver private ops for this object
- *
- * For GEM drivers this is deprecated in favour of
- * &drm_gem_object_funcs.vm_ops.
- */
- const struct vm_operations_struct *gem_vm_ops;
-
/** @major: driver major number */
int major;
/** @minor: driver minor number */
--
2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 243+ messages in thread* [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 8:36 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 8:36 UTC (permalink / raw)
To: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b, Thomas Zimmermann
Several GEM and PRIME callbacks have been deprecated in favor of
per-instance GEM object functions. Remove the callbacks as they are
now unused. The only exception is .gem_prime_mmap, which is still
in use by several drivers.
What is also gone is gem_vm_ops in struct drm_driver. All drivers now
use struct drm_gem_object_funcs.vm_ops instead.
While at it, the patch also improves error handling around calls
to .free and .get_sg_table callbacks.
Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
---
drivers/gpu/drm/drm_gem.c | 35 +++---------
drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
drivers/gpu/drm/drm_prime.c | 17 +++---
include/drm/drm_drv.h | 85 ++--------------------------
4 files changed, 23 insertions(+), 120 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 19d73868490e..96945bed8291 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
{
struct drm_file *file_priv = data;
struct drm_gem_object *obj = ptr;
- struct drm_device *dev = obj->dev;
if (obj->funcs && obj->funcs->close)
obj->funcs->close(obj, file_priv);
- else if (dev->driver->gem_close_object)
- dev->driver->gem_close_object(obj, file_priv);
drm_gem_remove_prime_handles(obj, file_priv);
drm_vma_node_revoke(&obj->vma_node, file_priv);
@@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
ret = obj->funcs->open(obj, file_priv);
if (ret)
goto err_revoke;
- } else if (dev->driver->gem_open_object) {
- ret = dev->driver->gem_open_object(obj, file_priv);
- if (ret)
- goto err_revoke;
}
*handlep = handle;
@@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
{
struct drm_gem_object *obj =
container_of(kref, struct drm_gem_object, refcount);
- struct drm_device *dev = obj->dev;
- if (obj->funcs)
- obj->funcs->free(obj);
- else if (dev->driver->gem_free_object_unlocked)
- dev->driver->gem_free_object_unlocked(obj);
+ if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
+ return;
+
+ obj->funcs->free(obj);
}
EXPORT_SYMBOL(drm_gem_object_free);
@@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* @obj_size: the object size to be mapped, in bytes
* @vma: VMA for the area to be mapped
*
- * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
- * provided by the driver. Depending on their requirements, drivers can either
- * provide a fault handler in their gem_vm_ops (in which case any accesses to
+ * Set up the VMA to prepare mapping of the GEM object using the GEM object's
+ * vm_ops. Depending on their requirements, GEM objects can either
+ * provide a fault handler in their vm_ops (in which case any accesses to
* the object will be trapped, to perform migration, GTT binding, surface
* register allocation, or performance monitoring), or mmap the buffer memory
* synchronously after calling drm_gem_mmap_obj.
@@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
* callers must verify access restrictions before calling this helper.
*
* Return 0 or success or -EINVAL if the object size is smaller than the VMA
- * size, or if no gem_vm_ops are provided.
+ * size, or if no vm_ops are provided.
*/
int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
struct vm_area_struct *vma)
{
- struct drm_device *dev = obj->dev;
int ret;
/* Check for valid size. */
@@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
} else {
if (obj->funcs && obj->funcs->vm_ops)
vma->vm_ops = obj->funcs->vm_ops;
- else if (dev->driver->gem_vm_ops)
- vma->vm_ops = dev->driver->gem_vm_ops;
else {
drm_gem_object_put(obj);
return -EINVAL;
@@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->pin)
return obj->funcs->pin(obj);
- else if (obj->dev->driver->gem_prime_pin)
- return obj->dev->driver->gem_prime_pin(obj);
else
return 0;
}
@@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
{
if (obj->funcs && obj->funcs->unpin)
obj->funcs->unpin(obj);
- else if (obj->dev->driver->gem_prime_unpin)
- obj->dev->driver->gem_prime_unpin(obj);
}
void *drm_gem_vmap(struct drm_gem_object *obj)
@@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
if (obj->funcs && obj->funcs->vmap)
vaddr = obj->funcs->vmap(obj);
- else if (obj->dev->driver->gem_prime_vmap)
- vaddr = obj->dev->driver->gem_prime_vmap(obj);
else
vaddr = ERR_PTR(-EOPNOTSUPP);
@@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
if (obj->funcs && obj->funcs->vunmap)
obj->funcs->vunmap(obj, vaddr);
- else if (obj->dev->driver->gem_prime_vunmap)
- obj->dev->driver->gem_prime_vunmap(obj, vaddr);
}
/**
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 822edeadbab3..209202257cc2 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
*
* This function exports a scatter/gather table suitable for PRIME usage by
* calling the standard DMA mapping API. Drivers using the CMA helpers should
- * set this as their &drm_driver.gem_prime_get_sg_table callback.
+ * set this as their &drm_gem_object_funcs.get_sg_table callback.
*
* Returns:
* A pointer to the scatter/gather table of pinned pages or NULL on failure.
@@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
* virtual address space. Since the CMA buffers are already mapped into the
* kernel virtual address space this simply returns the cached virtual
* address. Drivers using the CMA helpers should set this as their DRM
- * driver's &drm_driver.gem_prime_vmap callback.
+ * driver's &drm_gem_object_funcs.vmap callback.
*
* Returns:
* The kernel virtual address of the CMA GEM object's backing store.
@@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
* This function removes a buffer exported via DRM PRIME from the kernel's
* virtual address space. This is a no-op because CMA buffers cannot be
* unmapped from kernel space. Drivers using the CMA helpers should set this
- * as their &drm_driver.gem_prime_vunmap callback.
+ * as their &drm_gem_object_funcs.vunmap callback.
*/
void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
{
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 1693aa7c14b5..9a87639e7008 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
if (obj->funcs && obj->funcs->export)
dmabuf = obj->funcs->export(obj, flags);
- else if (dev->driver->gem_prime_export)
- dmabuf = dev->driver->gem_prime_export(obj, flags);
- else
- dmabuf = drm_gem_prime_export(obj, flags);
if (IS_ERR(dmabuf)) {
/* normally the created dma-buf takes ownership of the ref,
* but if that fails then drop the ref
@@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
* This is the PRIME export function which must be used mandatorily by GEM
* drivers to ensure correct lifetime management of the underlying GEM object.
* The actual exporting from GEM object to a dma-buf is done through the
- * &drm_driver.gem_prime_export driver callback.
+ * &drm_gem_object_funcs.export callback.
*/
int drm_gem_prime_handle_to_fd(struct drm_device *dev,
struct drm_file *file_priv, uint32_t handle,
@@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
enum dma_data_direction dir)
{
struct drm_gem_object *obj = attach->dmabuf->priv;
- struct sg_table *sgt;
+ struct sg_table *sgt = NULL;
if (WARN_ON(dir == DMA_NONE))
return ERR_PTR(-EINVAL);
- if (obj->funcs)
+ if (obj->funcs && obj->funcs->get_sg_table)
sgt = obj->funcs->get_sg_table(obj);
- else
- sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
+
+ if (!sgt)
+ return ERR_PTR(-EINVAL);
+ else if (IS_ERR(sgt))
+ return sgt;
if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
DMA_ATTR_SKIP_CPU_SYNC)) {
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 7116abc1a04e..8b325bf6cef4 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -36,10 +36,12 @@ struct drm_file;
struct drm_gem_object;
struct drm_master;
struct drm_minor;
+struct dma_buf;
struct dma_buf_attachment;
struct drm_display_mode;
struct drm_mode_create_dumb;
struct drm_printer;
+struct sg_table;
/**
* enum drm_driver_feature - feature flags
@@ -327,32 +329,6 @@ struct drm_driver {
*/
void (*debugfs_init)(struct drm_minor *minor);
- /**
- * @gem_free_object_unlocked: deconstructor for drm_gem_objects
- *
- * This is deprecated and should not be used by new drivers. Use
- * &drm_gem_object_funcs.free instead.
- */
- void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
-
- /**
- * @gem_open_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.open.
- *
- * Driver hook called upon gem handle creation
- */
- int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
-
- /**
- * @gem_close_object:
- *
- * This callback is deprecated in favour of &drm_gem_object_funcs.close.
- *
- * Driver hook called upon gem handle release
- */
- void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
-
/**
* @gem_create_object: constructor for gem objects
*
@@ -361,6 +337,7 @@ struct drm_driver {
*/
struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
size_t size);
+
/**
* @prime_handle_to_fd:
*
@@ -383,14 +360,7 @@ struct drm_driver {
*/
int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
int prime_fd, uint32_t *handle);
- /**
- * @gem_prime_export:
- *
- * Export hook for GEM drivers. Deprecated in favour of
- * &drm_gem_object_funcs.export.
- */
- struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
- int flags);
+
/**
* @gem_prime_import:
*
@@ -400,29 +370,6 @@ struct drm_driver {
*/
struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
struct dma_buf *dma_buf);
-
- /**
- * @gem_prime_pin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.pin.
- */
- int (*gem_prime_pin)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_unpin:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
- */
- void (*gem_prime_unpin)(struct drm_gem_object *obj);
-
-
- /**
- * @gem_prime_get_sg_table:
- *
- * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
- */
- struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
-
/**
* @gem_prime_import_sg_table:
*
@@ -433,22 +380,6 @@ struct drm_driver {
struct drm_device *dev,
struct dma_buf_attachment *attach,
struct sg_table *sgt);
- /**
- * @gem_prime_vmap:
- *
- * Deprecated vmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vmap instead.
- */
- void *(*gem_prime_vmap)(struct drm_gem_object *obj);
-
- /**
- * @gem_prime_vunmap:
- *
- * Deprecated vunmap hook for GEM drivers. Please use
- * &drm_gem_object_funcs.vunmap instead.
- */
- void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
-
/**
* @gem_prime_mmap:
*
@@ -523,14 +454,6 @@ struct drm_driver {
struct drm_device *dev,
uint32_t handle);
- /**
- * @gem_vm_ops: Driver private ops for this object
- *
- * For GEM drivers this is deprecated in favour of
- * &drm_gem_object_funcs.vm_ops.
- */
- const struct vm_operations_struct *gem_vm_ops;
-
/** @major: driver major number */
int major;
/** @minor: driver minor number */
--
2.28.0
^ permalink raw reply related [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:16 ` Sam Ravnborg
0 siblings, 0 replies; 243+ messages in thread
From: Sam Ravnborg @ 2020-08-13 10:16 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexander.deucher, christian.koenig, airlied, daniel, linux,
maarten.lankhorst, mripard, l.stach, christian.gmeiner, inki.dae,
jy0922.shim, sw0312.kim, kyungmin.park, kgene, krzk,
patrik.r.jakobsson, jani.nikula, joonas.lahtinen, rodrigo.vivi,
chunkuang.hu, p.zabel, matthias.bgg, robdclark, sean, bskeggs,
tomi.valkeinen, eric, hjc, heiko, thierry.reding, jonathanh,
rodrigosiqueiramelo, hamohammed.sa, oleksandr_andrushchenko,
hyun.kwon, laurent.pinchart, michal.simek, sumit.semwal,
evan.quan, Hawking.Zhang, tianci.yin, marek.olsak, hdegoede,
andrey.grodzovsky, Felix.Kuehling, xinhui.pan, aaron.liu,
nirmoy.das, chris, matthew.auld, abdiel.janulgue, tvrtko.ursulin,
andi.shyti, miaoqinglang, emil.velikov, amd-gfx, dri-devel,
etnaviv, linux-arm-kernel, linux-samsung-soc, intel-gfx,
linux-mediatek, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-tegra, xen-devel
Hi Thomas.
On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
> Several GEM and PRIME callbacks have been deprecated in favor of
> per-instance GEM object functions. Remove the callbacks as they are
> now unused. The only exception is .gem_prime_mmap, which is still
> in use by several drivers.
>
> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
> use struct drm_gem_object_funcs.vm_ops instead.
>
> While at it, the patch also improves error handling around calls
> to .free and .get_sg_table callbacks.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
After this following entry in todo.rst is done?
"
struct drm_gem_object_funcs
---------------------------
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
We also need a 2nd version of the CMA define that doesn't require the
vmapping to be present (different hook for prime importing). Plus this needs to
be rolled out to all drivers using their own implementations, too.
"
If yes, then delete it too.
Sam
> ---
> drivers/gpu/drm/drm_gem.c | 35 +++---------
> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
> drivers/gpu/drm/drm_prime.c | 17 +++---
> include/drm/drm_drv.h | 85 ++--------------------------
> 4 files changed, 23 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 19d73868490e..96945bed8291 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
> {
> struct drm_file *file_priv = data;
> struct drm_gem_object *obj = ptr;
> - struct drm_device *dev = obj->dev;
>
> if (obj->funcs && obj->funcs->close)
> obj->funcs->close(obj, file_priv);
> - else if (dev->driver->gem_close_object)
> - dev->driver->gem_close_object(obj, file_priv);
>
> drm_gem_remove_prime_handles(obj, file_priv);
> drm_vma_node_revoke(&obj->vma_node, file_priv);
> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
> ret = obj->funcs->open(obj, file_priv);
> if (ret)
> goto err_revoke;
> - } else if (dev->driver->gem_open_object) {
> - ret = dev->driver->gem_open_object(obj, file_priv);
> - if (ret)
> - goto err_revoke;
> }
>
> *handlep = handle;
> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
> {
> struct drm_gem_object *obj =
> container_of(kref, struct drm_gem_object, refcount);
> - struct drm_device *dev = obj->dev;
>
> - if (obj->funcs)
> - obj->funcs->free(obj);
> - else if (dev->driver->gem_free_object_unlocked)
> - dev->driver->gem_free_object_unlocked(obj);
> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
> + return;
> +
> + obj->funcs->free(obj);
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * @obj_size: the object size to be mapped, in bytes
> * @vma: VMA for the area to be mapped
> *
> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
> - * provided by the driver. Depending on their requirements, drivers can either
> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
> + * vm_ops. Depending on their requirements, GEM objects can either
> + * provide a fault handler in their vm_ops (in which case any accesses to
> * the object will be trapped, to perform migration, GTT binding, surface
> * register allocation, or performance monitoring), or mmap the buffer memory
> * synchronously after calling drm_gem_mmap_obj.
> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * callers must verify access restrictions before calling this helper.
> *
> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
> - * size, or if no gem_vm_ops are provided.
> + * size, or if no vm_ops are provided.
> */
> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> struct vm_area_struct *vma)
> {
> - struct drm_device *dev = obj->dev;
> int ret;
>
> /* Check for valid size. */
> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> } else {
> if (obj->funcs && obj->funcs->vm_ops)
> vma->vm_ops = obj->funcs->vm_ops;
> - else if (dev->driver->gem_vm_ops)
> - vma->vm_ops = dev->driver->gem_vm_ops;
> else {
> drm_gem_object_put(obj);
> return -EINVAL;
> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else if (obj->dev->driver->gem_prime_pin)
> - return obj->dev->driver->gem_prime_pin(obj);
> else
> return 0;
> }
> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->unpin)
> obj->funcs->unpin(obj);
> - else if (obj->dev->driver->gem_prime_unpin)
> - obj->dev->driver->gem_prime_unpin(obj);
> }
>
> void *drm_gem_vmap(struct drm_gem_object *obj)
> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>
> if (obj->funcs && obj->funcs->vmap)
> vaddr = obj->funcs->vmap(obj);
> - else if (obj->dev->driver->gem_prime_vmap)
> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
> else
> vaddr = ERR_PTR(-EOPNOTSUPP);
>
> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> if (obj->funcs && obj->funcs->vunmap)
> obj->funcs->vunmap(obj, vaddr);
> - else if (obj->dev->driver->gem_prime_vunmap)
> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
> }
>
> /**
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 822edeadbab3..209202257cc2 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
> *
> * This function exports a scatter/gather table suitable for PRIME usage by
> * calling the standard DMA mapping API. Drivers using the CMA helpers should
> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
> *
> * Returns:
> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
> * virtual address space. Since the CMA buffers are already mapped into the
> * kernel virtual address space this simply returns the cached virtual
> * address. Drivers using the CMA helpers should set this as their DRM
> - * driver's &drm_driver.gem_prime_vmap callback.
> + * driver's &drm_gem_object_funcs.vmap callback.
> *
> * Returns:
> * The kernel virtual address of the CMA GEM object's backing store.
> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
> * This function removes a buffer exported via DRM PRIME from the kernel's
> * virtual address space. This is a no-op because CMA buffers cannot be
> * unmapped from kernel space. Drivers using the CMA helpers should set this
> - * as their &drm_driver.gem_prime_vunmap callback.
> + * as their &drm_gem_object_funcs.vunmap callback.
> */
> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> {
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 1693aa7c14b5..9a87639e7008 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>
> if (obj->funcs && obj->funcs->export)
> dmabuf = obj->funcs->export(obj, flags);
> - else if (dev->driver->gem_prime_export)
> - dmabuf = dev->driver->gem_prime_export(obj, flags);
> - else
> - dmabuf = drm_gem_prime_export(obj, flags);
> if (IS_ERR(dmabuf)) {
> /* normally the created dma-buf takes ownership of the ref,
> * but if that fails then drop the ref
> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
> * This is the PRIME export function which must be used mandatorily by GEM
> * drivers to ensure correct lifetime management of the underlying GEM object.
> * The actual exporting from GEM object to a dma-buf is done through the
> - * &drm_driver.gem_prime_export driver callback.
> + * &drm_gem_object_funcs.export callback.
> */
> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
> struct drm_file *file_priv, uint32_t handle,
> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
> enum dma_data_direction dir)
> {
> struct drm_gem_object *obj = attach->dmabuf->priv;
> - struct sg_table *sgt;
> + struct sg_table *sgt = NULL;
>
> if (WARN_ON(dir == DMA_NONE))
> return ERR_PTR(-EINVAL);
>
> - if (obj->funcs)
> + if (obj->funcs && obj->funcs->get_sg_table)
> sgt = obj->funcs->get_sg_table(obj);
> - else
> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +
> + if (!sgt)
> + return ERR_PTR(-EINVAL);
> + else if (IS_ERR(sgt))
> + return sgt;
>
> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
> DMA_ATTR_SKIP_CPU_SYNC)) {
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 7116abc1a04e..8b325bf6cef4 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -36,10 +36,12 @@ struct drm_file;
> struct drm_gem_object;
> struct drm_master;
> struct drm_minor;
> +struct dma_buf;
> struct dma_buf_attachment;
> struct drm_display_mode;
> struct drm_mode_create_dumb;
> struct drm_printer;
> +struct sg_table;
>
> /**
> * enum drm_driver_feature - feature flags
> @@ -327,32 +329,6 @@ struct drm_driver {
> */
> void (*debugfs_init)(struct drm_minor *minor);
>
> - /**
> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
> - *
> - * This is deprecated and should not be used by new drivers. Use
> - * &drm_gem_object_funcs.free instead.
> - */
> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
> -
> - /**
> - * @gem_open_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
> - *
> - * Driver hook called upon gem handle creation
> - */
> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
> -
> - /**
> - * @gem_close_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
> - *
> - * Driver hook called upon gem handle release
> - */
> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
> -
> /**
> * @gem_create_object: constructor for gem objects
> *
> @@ -361,6 +337,7 @@ struct drm_driver {
> */
> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
> size_t size);
> +
> /**
> * @prime_handle_to_fd:
> *
> @@ -383,14 +360,7 @@ struct drm_driver {
> */
> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
> int prime_fd, uint32_t *handle);
> - /**
> - * @gem_prime_export:
> - *
> - * Export hook for GEM drivers. Deprecated in favour of
> - * &drm_gem_object_funcs.export.
> - */
> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
> - int flags);
> +
> /**
> * @gem_prime_import:
> *
> @@ -400,29 +370,6 @@ struct drm_driver {
> */
> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
> struct dma_buf *dma_buf);
> -
> - /**
> - * @gem_prime_pin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
> - */
> - int (*gem_prime_pin)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_unpin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
> - */
> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
> -
> -
> - /**
> - * @gem_prime_get_sg_table:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
> - */
> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
> -
> /**
> * @gem_prime_import_sg_table:
> *
> @@ -433,22 +380,6 @@ struct drm_driver {
> struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt);
> - /**
> - * @gem_prime_vmap:
> - *
> - * Deprecated vmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vmap instead.
> - */
> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_vunmap:
> - *
> - * Deprecated vunmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vunmap instead.
> - */
> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
> -
> /**
> * @gem_prime_mmap:
> *
> @@ -523,14 +454,6 @@ struct drm_driver {
> struct drm_device *dev,
> uint32_t handle);
>
> - /**
> - * @gem_vm_ops: Driver private ops for this object
> - *
> - * For GEM drivers this is deprecated in favour of
> - * &drm_gem_object_funcs.vm_ops.
> - */
> - const struct vm_operations_struct *gem_vm_ops;
> -
> /** @major: driver major number */
> int major;
> /** @minor: driver minor number */
> --
> 2.28.0
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:16 ` Sam Ravnborg
0 siblings, 0 replies; 243+ messages in thread
From: Sam Ravnborg @ 2020-08-13 10:16 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sumit.semwal, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, patrik.r.jakobsson,
jonathanh, linux-rockchip, kgene, bskeggs, xen-devel,
miaoqinglang, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, laurent.pinchart, hyun.kwon, rodrigosiqueiramelo,
aaron.liu, Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, chris,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas.
On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
> Several GEM and PRIME callbacks have been deprecated in favor of
> per-instance GEM object functions. Remove the callbacks as they are
> now unused. The only exception is .gem_prime_mmap, which is still
> in use by several drivers.
>
> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
> use struct drm_gem_object_funcs.vm_ops instead.
>
> While at it, the patch also improves error handling around calls
> to .free and .get_sg_table callbacks.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
After this following entry in todo.rst is done?
"
struct drm_gem_object_funcs
---------------------------
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
We also need a 2nd version of the CMA define that doesn't require the
vmapping to be present (different hook for prime importing). Plus this needs to
be rolled out to all drivers using their own implementations, too.
"
If yes, then delete it too.
Sam
> ---
> drivers/gpu/drm/drm_gem.c | 35 +++---------
> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
> drivers/gpu/drm/drm_prime.c | 17 +++---
> include/drm/drm_drv.h | 85 ++--------------------------
> 4 files changed, 23 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 19d73868490e..96945bed8291 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
> {
> struct drm_file *file_priv = data;
> struct drm_gem_object *obj = ptr;
> - struct drm_device *dev = obj->dev;
>
> if (obj->funcs && obj->funcs->close)
> obj->funcs->close(obj, file_priv);
> - else if (dev->driver->gem_close_object)
> - dev->driver->gem_close_object(obj, file_priv);
>
> drm_gem_remove_prime_handles(obj, file_priv);
> drm_vma_node_revoke(&obj->vma_node, file_priv);
> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
> ret = obj->funcs->open(obj, file_priv);
> if (ret)
> goto err_revoke;
> - } else if (dev->driver->gem_open_object) {
> - ret = dev->driver->gem_open_object(obj, file_priv);
> - if (ret)
> - goto err_revoke;
> }
>
> *handlep = handle;
> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
> {
> struct drm_gem_object *obj =
> container_of(kref, struct drm_gem_object, refcount);
> - struct drm_device *dev = obj->dev;
>
> - if (obj->funcs)
> - obj->funcs->free(obj);
> - else if (dev->driver->gem_free_object_unlocked)
> - dev->driver->gem_free_object_unlocked(obj);
> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
> + return;
> +
> + obj->funcs->free(obj);
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * @obj_size: the object size to be mapped, in bytes
> * @vma: VMA for the area to be mapped
> *
> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
> - * provided by the driver. Depending on their requirements, drivers can either
> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
> + * vm_ops. Depending on their requirements, GEM objects can either
> + * provide a fault handler in their vm_ops (in which case any accesses to
> * the object will be trapped, to perform migration, GTT binding, surface
> * register allocation, or performance monitoring), or mmap the buffer memory
> * synchronously after calling drm_gem_mmap_obj.
> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * callers must verify access restrictions before calling this helper.
> *
> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
> - * size, or if no gem_vm_ops are provided.
> + * size, or if no vm_ops are provided.
> */
> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> struct vm_area_struct *vma)
> {
> - struct drm_device *dev = obj->dev;
> int ret;
>
> /* Check for valid size. */
> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> } else {
> if (obj->funcs && obj->funcs->vm_ops)
> vma->vm_ops = obj->funcs->vm_ops;
> - else if (dev->driver->gem_vm_ops)
> - vma->vm_ops = dev->driver->gem_vm_ops;
> else {
> drm_gem_object_put(obj);
> return -EINVAL;
> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else if (obj->dev->driver->gem_prime_pin)
> - return obj->dev->driver->gem_prime_pin(obj);
> else
> return 0;
> }
> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->unpin)
> obj->funcs->unpin(obj);
> - else if (obj->dev->driver->gem_prime_unpin)
> - obj->dev->driver->gem_prime_unpin(obj);
> }
>
> void *drm_gem_vmap(struct drm_gem_object *obj)
> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>
> if (obj->funcs && obj->funcs->vmap)
> vaddr = obj->funcs->vmap(obj);
> - else if (obj->dev->driver->gem_prime_vmap)
> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
> else
> vaddr = ERR_PTR(-EOPNOTSUPP);
>
> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> if (obj->funcs && obj->funcs->vunmap)
> obj->funcs->vunmap(obj, vaddr);
> - else if (obj->dev->driver->gem_prime_vunmap)
> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
> }
>
> /**
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 822edeadbab3..209202257cc2 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
> *
> * This function exports a scatter/gather table suitable for PRIME usage by
> * calling the standard DMA mapping API. Drivers using the CMA helpers should
> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
> *
> * Returns:
> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
> * virtual address space. Since the CMA buffers are already mapped into the
> * kernel virtual address space this simply returns the cached virtual
> * address. Drivers using the CMA helpers should set this as their DRM
> - * driver's &drm_driver.gem_prime_vmap callback.
> + * driver's &drm_gem_object_funcs.vmap callback.
> *
> * Returns:
> * The kernel virtual address of the CMA GEM object's backing store.
> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
> * This function removes a buffer exported via DRM PRIME from the kernel's
> * virtual address space. This is a no-op because CMA buffers cannot be
> * unmapped from kernel space. Drivers using the CMA helpers should set this
> - * as their &drm_driver.gem_prime_vunmap callback.
> + * as their &drm_gem_object_funcs.vunmap callback.
> */
> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> {
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 1693aa7c14b5..9a87639e7008 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>
> if (obj->funcs && obj->funcs->export)
> dmabuf = obj->funcs->export(obj, flags);
> - else if (dev->driver->gem_prime_export)
> - dmabuf = dev->driver->gem_prime_export(obj, flags);
> - else
> - dmabuf = drm_gem_prime_export(obj, flags);
> if (IS_ERR(dmabuf)) {
> /* normally the created dma-buf takes ownership of the ref,
> * but if that fails then drop the ref
> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
> * This is the PRIME export function which must be used mandatorily by GEM
> * drivers to ensure correct lifetime management of the underlying GEM object.
> * The actual exporting from GEM object to a dma-buf is done through the
> - * &drm_driver.gem_prime_export driver callback.
> + * &drm_gem_object_funcs.export callback.
> */
> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
> struct drm_file *file_priv, uint32_t handle,
> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
> enum dma_data_direction dir)
> {
> struct drm_gem_object *obj = attach->dmabuf->priv;
> - struct sg_table *sgt;
> + struct sg_table *sgt = NULL;
>
> if (WARN_ON(dir == DMA_NONE))
> return ERR_PTR(-EINVAL);
>
> - if (obj->funcs)
> + if (obj->funcs && obj->funcs->get_sg_table)
> sgt = obj->funcs->get_sg_table(obj);
> - else
> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +
> + if (!sgt)
> + return ERR_PTR(-EINVAL);
> + else if (IS_ERR(sgt))
> + return sgt;
>
> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
> DMA_ATTR_SKIP_CPU_SYNC)) {
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 7116abc1a04e..8b325bf6cef4 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -36,10 +36,12 @@ struct drm_file;
> struct drm_gem_object;
> struct drm_master;
> struct drm_minor;
> +struct dma_buf;
> struct dma_buf_attachment;
> struct drm_display_mode;
> struct drm_mode_create_dumb;
> struct drm_printer;
> +struct sg_table;
>
> /**
> * enum drm_driver_feature - feature flags
> @@ -327,32 +329,6 @@ struct drm_driver {
> */
> void (*debugfs_init)(struct drm_minor *minor);
>
> - /**
> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
> - *
> - * This is deprecated and should not be used by new drivers. Use
> - * &drm_gem_object_funcs.free instead.
> - */
> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
> -
> - /**
> - * @gem_open_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
> - *
> - * Driver hook called upon gem handle creation
> - */
> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
> -
> - /**
> - * @gem_close_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
> - *
> - * Driver hook called upon gem handle release
> - */
> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
> -
> /**
> * @gem_create_object: constructor for gem objects
> *
> @@ -361,6 +337,7 @@ struct drm_driver {
> */
> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
> size_t size);
> +
> /**
> * @prime_handle_to_fd:
> *
> @@ -383,14 +360,7 @@ struct drm_driver {
> */
> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
> int prime_fd, uint32_t *handle);
> - /**
> - * @gem_prime_export:
> - *
> - * Export hook for GEM drivers. Deprecated in favour of
> - * &drm_gem_object_funcs.export.
> - */
> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
> - int flags);
> +
> /**
> * @gem_prime_import:
> *
> @@ -400,29 +370,6 @@ struct drm_driver {
> */
> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
> struct dma_buf *dma_buf);
> -
> - /**
> - * @gem_prime_pin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
> - */
> - int (*gem_prime_pin)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_unpin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
> - */
> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
> -
> -
> - /**
> - * @gem_prime_get_sg_table:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
> - */
> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
> -
> /**
> * @gem_prime_import_sg_table:
> *
> @@ -433,22 +380,6 @@ struct drm_driver {
> struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt);
> - /**
> - * @gem_prime_vmap:
> - *
> - * Deprecated vmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vmap instead.
> - */
> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_vunmap:
> - *
> - * Deprecated vunmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vunmap instead.
> - */
> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
> -
> /**
> * @gem_prime_mmap:
> *
> @@ -523,14 +454,6 @@ struct drm_driver {
> struct drm_device *dev,
> uint32_t handle);
>
> - /**
> - * @gem_vm_ops: Driver private ops for this object
> - *
> - * For GEM drivers this is deprecated in favour of
> - * &drm_gem_object_funcs.vm_ops.
> - */
> - const struct vm_operations_struct *gem_vm_ops;
> -
> /** @major: driver major number */
> int major;
> /** @minor: driver minor number */
> --
> 2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:16 ` Sam Ravnborg
0 siblings, 0 replies; 243+ messages in thread
From: Sam Ravnborg @ 2020-08-13 10:16 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
dri-devel, michal.simek, eric, krzk, sumit.semwal, emil.velikov,
abdiel.janulgue, linux-samsung-soc, jy0922.shim,
oleksandr_andrushchenko, tomi.valkeinen, linux-tegra, linux,
jonathanh, linux-rockchip, kgene, bskeggs, xen-devel,
miaoqinglang, intel-gfx, matthew.auld, chunkuang.hu,
linux-arm-msm, marek.olsak, tianci.yin, etnaviv, inki.dae,
christian.gmeiner, linux-mediatek, mripard, matthias.bgg,
evan.quan, linux-arm-kernel, amd-gfx, laurent.pinchart,
hyun.kwon, rodrigosiqueiramelo, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, chris, kyungmin.park, nirmoy.das,
p.zabel, alexander.deucher, Hawking.Zhang, freedreno,
christian.koenig, l.stach
Hi Thomas.
On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
> Several GEM and PRIME callbacks have been deprecated in favor of
> per-instance GEM object functions. Remove the callbacks as they are
> now unused. The only exception is .gem_prime_mmap, which is still
> in use by several drivers.
>
> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
> use struct drm_gem_object_funcs.vm_ops instead.
>
> While at it, the patch also improves error handling around calls
> to .free and .get_sg_table callbacks.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
After this following entry in todo.rst is done?
"
struct drm_gem_object_funcs
---------------------------
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
We also need a 2nd version of the CMA define that doesn't require the
vmapping to be present (different hook for prime importing). Plus this needs to
be rolled out to all drivers using their own implementations, too.
"
If yes, then delete it too.
Sam
> ---
> drivers/gpu/drm/drm_gem.c | 35 +++---------
> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
> drivers/gpu/drm/drm_prime.c | 17 +++---
> include/drm/drm_drv.h | 85 ++--------------------------
> 4 files changed, 23 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 19d73868490e..96945bed8291 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
> {
> struct drm_file *file_priv = data;
> struct drm_gem_object *obj = ptr;
> - struct drm_device *dev = obj->dev;
>
> if (obj->funcs && obj->funcs->close)
> obj->funcs->close(obj, file_priv);
> - else if (dev->driver->gem_close_object)
> - dev->driver->gem_close_object(obj, file_priv);
>
> drm_gem_remove_prime_handles(obj, file_priv);
> drm_vma_node_revoke(&obj->vma_node, file_priv);
> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
> ret = obj->funcs->open(obj, file_priv);
> if (ret)
> goto err_revoke;
> - } else if (dev->driver->gem_open_object) {
> - ret = dev->driver->gem_open_object(obj, file_priv);
> - if (ret)
> - goto err_revoke;
> }
>
> *handlep = handle;
> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
> {
> struct drm_gem_object *obj =
> container_of(kref, struct drm_gem_object, refcount);
> - struct drm_device *dev = obj->dev;
>
> - if (obj->funcs)
> - obj->funcs->free(obj);
> - else if (dev->driver->gem_free_object_unlocked)
> - dev->driver->gem_free_object_unlocked(obj);
> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
> + return;
> +
> + obj->funcs->free(obj);
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * @obj_size: the object size to be mapped, in bytes
> * @vma: VMA for the area to be mapped
> *
> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
> - * provided by the driver. Depending on their requirements, drivers can either
> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
> + * vm_ops. Depending on their requirements, GEM objects can either
> + * provide a fault handler in their vm_ops (in which case any accesses to
> * the object will be trapped, to perform migration, GTT binding, surface
> * register allocation, or performance monitoring), or mmap the buffer memory
> * synchronously after calling drm_gem_mmap_obj.
> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * callers must verify access restrictions before calling this helper.
> *
> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
> - * size, or if no gem_vm_ops are provided.
> + * size, or if no vm_ops are provided.
> */
> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> struct vm_area_struct *vma)
> {
> - struct drm_device *dev = obj->dev;
> int ret;
>
> /* Check for valid size. */
> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> } else {
> if (obj->funcs && obj->funcs->vm_ops)
> vma->vm_ops = obj->funcs->vm_ops;
> - else if (dev->driver->gem_vm_ops)
> - vma->vm_ops = dev->driver->gem_vm_ops;
> else {
> drm_gem_object_put(obj);
> return -EINVAL;
> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else if (obj->dev->driver->gem_prime_pin)
> - return obj->dev->driver->gem_prime_pin(obj);
> else
> return 0;
> }
> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->unpin)
> obj->funcs->unpin(obj);
> - else if (obj->dev->driver->gem_prime_unpin)
> - obj->dev->driver->gem_prime_unpin(obj);
> }
>
> void *drm_gem_vmap(struct drm_gem_object *obj)
> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>
> if (obj->funcs && obj->funcs->vmap)
> vaddr = obj->funcs->vmap(obj);
> - else if (obj->dev->driver->gem_prime_vmap)
> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
> else
> vaddr = ERR_PTR(-EOPNOTSUPP);
>
> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> if (obj->funcs && obj->funcs->vunmap)
> obj->funcs->vunmap(obj, vaddr);
> - else if (obj->dev->driver->gem_prime_vunmap)
> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
> }
>
> /**
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 822edeadbab3..209202257cc2 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
> *
> * This function exports a scatter/gather table suitable for PRIME usage by
> * calling the standard DMA mapping API. Drivers using the CMA helpers should
> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
> *
> * Returns:
> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
> * virtual address space. Since the CMA buffers are already mapped into the
> * kernel virtual address space this simply returns the cached virtual
> * address. Drivers using the CMA helpers should set this as their DRM
> - * driver's &drm_driver.gem_prime_vmap callback.
> + * driver's &drm_gem_object_funcs.vmap callback.
> *
> * Returns:
> * The kernel virtual address of the CMA GEM object's backing store.
> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
> * This function removes a buffer exported via DRM PRIME from the kernel's
> * virtual address space. This is a no-op because CMA buffers cannot be
> * unmapped from kernel space. Drivers using the CMA helpers should set this
> - * as their &drm_driver.gem_prime_vunmap callback.
> + * as their &drm_gem_object_funcs.vunmap callback.
> */
> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> {
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 1693aa7c14b5..9a87639e7008 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>
> if (obj->funcs && obj->funcs->export)
> dmabuf = obj->funcs->export(obj, flags);
> - else if (dev->driver->gem_prime_export)
> - dmabuf = dev->driver->gem_prime_export(obj, flags);
> - else
> - dmabuf = drm_gem_prime_export(obj, flags);
> if (IS_ERR(dmabuf)) {
> /* normally the created dma-buf takes ownership of the ref,
> * but if that fails then drop the ref
> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
> * This is the PRIME export function which must be used mandatorily by GEM
> * drivers to ensure correct lifetime management of the underlying GEM object.
> * The actual exporting from GEM object to a dma-buf is done through the
> - * &drm_driver.gem_prime_export driver callback.
> + * &drm_gem_object_funcs.export callback.
> */
> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
> struct drm_file *file_priv, uint32_t handle,
> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
> enum dma_data_direction dir)
> {
> struct drm_gem_object *obj = attach->dmabuf->priv;
> - struct sg_table *sgt;
> + struct sg_table *sgt = NULL;
>
> if (WARN_ON(dir == DMA_NONE))
> return ERR_PTR(-EINVAL);
>
> - if (obj->funcs)
> + if (obj->funcs && obj->funcs->get_sg_table)
> sgt = obj->funcs->get_sg_table(obj);
> - else
> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +
> + if (!sgt)
> + return ERR_PTR(-EINVAL);
> + else if (IS_ERR(sgt))
> + return sgt;
>
> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
> DMA_ATTR_SKIP_CPU_SYNC)) {
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 7116abc1a04e..8b325bf6cef4 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -36,10 +36,12 @@ struct drm_file;
> struct drm_gem_object;
> struct drm_master;
> struct drm_minor;
> +struct dma_buf;
> struct dma_buf_attachment;
> struct drm_display_mode;
> struct drm_mode_create_dumb;
> struct drm_printer;
> +struct sg_table;
>
> /**
> * enum drm_driver_feature - feature flags
> @@ -327,32 +329,6 @@ struct drm_driver {
> */
> void (*debugfs_init)(struct drm_minor *minor);
>
> - /**
> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
> - *
> - * This is deprecated and should not be used by new drivers. Use
> - * &drm_gem_object_funcs.free instead.
> - */
> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
> -
> - /**
> - * @gem_open_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
> - *
> - * Driver hook called upon gem handle creation
> - */
> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
> -
> - /**
> - * @gem_close_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
> - *
> - * Driver hook called upon gem handle release
> - */
> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
> -
> /**
> * @gem_create_object: constructor for gem objects
> *
> @@ -361,6 +337,7 @@ struct drm_driver {
> */
> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
> size_t size);
> +
> /**
> * @prime_handle_to_fd:
> *
> @@ -383,14 +360,7 @@ struct drm_driver {
> */
> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
> int prime_fd, uint32_t *handle);
> - /**
> - * @gem_prime_export:
> - *
> - * Export hook for GEM drivers. Deprecated in favour of
> - * &drm_gem_object_funcs.export.
> - */
> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
> - int flags);
> +
> /**
> * @gem_prime_import:
> *
> @@ -400,29 +370,6 @@ struct drm_driver {
> */
> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
> struct dma_buf *dma_buf);
> -
> - /**
> - * @gem_prime_pin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
> - */
> - int (*gem_prime_pin)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_unpin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
> - */
> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
> -
> -
> - /**
> - * @gem_prime_get_sg_table:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
> - */
> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
> -
> /**
> * @gem_prime_import_sg_table:
> *
> @@ -433,22 +380,6 @@ struct drm_driver {
> struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt);
> - /**
> - * @gem_prime_vmap:
> - *
> - * Deprecated vmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vmap instead.
> - */
> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_vunmap:
> - *
> - * Deprecated vunmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vunmap instead.
> - */
> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
> -
> /**
> * @gem_prime_mmap:
> *
> @@ -523,14 +454,6 @@ struct drm_driver {
> struct drm_device *dev,
> uint32_t handle);
>
> - /**
> - * @gem_vm_ops: Driver private ops for this object
> - *
> - * For GEM drivers this is deprecated in favour of
> - * &drm_gem_object_funcs.vm_ops.
> - */
> - const struct vm_operations_struct *gem_vm_ops;
> -
> /** @major: driver major number */
> int major;
> /** @minor: driver minor number */
> --
> 2.28.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:16 ` Sam Ravnborg
0 siblings, 0 replies; 243+ messages in thread
From: Sam Ravnborg @ 2020-08-13 10:16 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, airlied, nouveau, dri-devel, michal.simek,
thierry.reding, krzk, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, jonathanh, linux-rockchip,
kgene, bskeggs, xen-devel, miaoqinglang, intel-gfx, matthew.auld,
chunkuang.hu, andi.shyti, linux-arm-msm, marek.olsak, tianci.yin,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, matthias.bgg,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx,
laurent.pinchart, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, chris,
kyungmin.park, nirmoy.das, alexander.deucher, Hawking.Zhang,
freedreno, christian.koenig
Hi Thomas.
On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
> Several GEM and PRIME callbacks have been deprecated in favor of
> per-instance GEM object functions. Remove the callbacks as they are
> now unused. The only exception is .gem_prime_mmap, which is still
> in use by several drivers.
>
> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
> use struct drm_gem_object_funcs.vm_ops instead.
>
> While at it, the patch also improves error handling around calls
> to .free and .get_sg_table callbacks.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
After this following entry in todo.rst is done?
"
struct drm_gem_object_funcs
---------------------------
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
We also need a 2nd version of the CMA define that doesn't require the
vmapping to be present (different hook for prime importing). Plus this needs to
be rolled out to all drivers using their own implementations, too.
"
If yes, then delete it too.
Sam
> ---
> drivers/gpu/drm/drm_gem.c | 35 +++---------
> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
> drivers/gpu/drm/drm_prime.c | 17 +++---
> include/drm/drm_drv.h | 85 ++--------------------------
> 4 files changed, 23 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 19d73868490e..96945bed8291 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
> {
> struct drm_file *file_priv = data;
> struct drm_gem_object *obj = ptr;
> - struct drm_device *dev = obj->dev;
>
> if (obj->funcs && obj->funcs->close)
> obj->funcs->close(obj, file_priv);
> - else if (dev->driver->gem_close_object)
> - dev->driver->gem_close_object(obj, file_priv);
>
> drm_gem_remove_prime_handles(obj, file_priv);
> drm_vma_node_revoke(&obj->vma_node, file_priv);
> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
> ret = obj->funcs->open(obj, file_priv);
> if (ret)
> goto err_revoke;
> - } else if (dev->driver->gem_open_object) {
> - ret = dev->driver->gem_open_object(obj, file_priv);
> - if (ret)
> - goto err_revoke;
> }
>
> *handlep = handle;
> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
> {
> struct drm_gem_object *obj =
> container_of(kref, struct drm_gem_object, refcount);
> - struct drm_device *dev = obj->dev;
>
> - if (obj->funcs)
> - obj->funcs->free(obj);
> - else if (dev->driver->gem_free_object_unlocked)
> - dev->driver->gem_free_object_unlocked(obj);
> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
> + return;
> +
> + obj->funcs->free(obj);
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * @obj_size: the object size to be mapped, in bytes
> * @vma: VMA for the area to be mapped
> *
> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
> - * provided by the driver. Depending on their requirements, drivers can either
> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
> + * vm_ops. Depending on their requirements, GEM objects can either
> + * provide a fault handler in their vm_ops (in which case any accesses to
> * the object will be trapped, to perform migration, GTT binding, surface
> * register allocation, or performance monitoring), or mmap the buffer memory
> * synchronously after calling drm_gem_mmap_obj.
> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * callers must verify access restrictions before calling this helper.
> *
> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
> - * size, or if no gem_vm_ops are provided.
> + * size, or if no vm_ops are provided.
> */
> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> struct vm_area_struct *vma)
> {
> - struct drm_device *dev = obj->dev;
> int ret;
>
> /* Check for valid size. */
> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> } else {
> if (obj->funcs && obj->funcs->vm_ops)
> vma->vm_ops = obj->funcs->vm_ops;
> - else if (dev->driver->gem_vm_ops)
> - vma->vm_ops = dev->driver->gem_vm_ops;
> else {
> drm_gem_object_put(obj);
> return -EINVAL;
> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else if (obj->dev->driver->gem_prime_pin)
> - return obj->dev->driver->gem_prime_pin(obj);
> else
> return 0;
> }
> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->unpin)
> obj->funcs->unpin(obj);
> - else if (obj->dev->driver->gem_prime_unpin)
> - obj->dev->driver->gem_prime_unpin(obj);
> }
>
> void *drm_gem_vmap(struct drm_gem_object *obj)
> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>
> if (obj->funcs && obj->funcs->vmap)
> vaddr = obj->funcs->vmap(obj);
> - else if (obj->dev->driver->gem_prime_vmap)
> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
> else
> vaddr = ERR_PTR(-EOPNOTSUPP);
>
> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> if (obj->funcs && obj->funcs->vunmap)
> obj->funcs->vunmap(obj, vaddr);
> - else if (obj->dev->driver->gem_prime_vunmap)
> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
> }
>
> /**
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 822edeadbab3..209202257cc2 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
> *
> * This function exports a scatter/gather table suitable for PRIME usage by
> * calling the standard DMA mapping API. Drivers using the CMA helpers should
> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
> *
> * Returns:
> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
> * virtual address space. Since the CMA buffers are already mapped into the
> * kernel virtual address space this simply returns the cached virtual
> * address. Drivers using the CMA helpers should set this as their DRM
> - * driver's &drm_driver.gem_prime_vmap callback.
> + * driver's &drm_gem_object_funcs.vmap callback.
> *
> * Returns:
> * The kernel virtual address of the CMA GEM object's backing store.
> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
> * This function removes a buffer exported via DRM PRIME from the kernel's
> * virtual address space. This is a no-op because CMA buffers cannot be
> * unmapped from kernel space. Drivers using the CMA helpers should set this
> - * as their &drm_driver.gem_prime_vunmap callback.
> + * as their &drm_gem_object_funcs.vunmap callback.
> */
> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> {
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 1693aa7c14b5..9a87639e7008 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>
> if (obj->funcs && obj->funcs->export)
> dmabuf = obj->funcs->export(obj, flags);
> - else if (dev->driver->gem_prime_export)
> - dmabuf = dev->driver->gem_prime_export(obj, flags);
> - else
> - dmabuf = drm_gem_prime_export(obj, flags);
> if (IS_ERR(dmabuf)) {
> /* normally the created dma-buf takes ownership of the ref,
> * but if that fails then drop the ref
> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
> * This is the PRIME export function which must be used mandatorily by GEM
> * drivers to ensure correct lifetime management of the underlying GEM object.
> * The actual exporting from GEM object to a dma-buf is done through the
> - * &drm_driver.gem_prime_export driver callback.
> + * &drm_gem_object_funcs.export callback.
> */
> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
> struct drm_file *file_priv, uint32_t handle,
> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
> enum dma_data_direction dir)
> {
> struct drm_gem_object *obj = attach->dmabuf->priv;
> - struct sg_table *sgt;
> + struct sg_table *sgt = NULL;
>
> if (WARN_ON(dir == DMA_NONE))
> return ERR_PTR(-EINVAL);
>
> - if (obj->funcs)
> + if (obj->funcs && obj->funcs->get_sg_table)
> sgt = obj->funcs->get_sg_table(obj);
> - else
> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +
> + if (!sgt)
> + return ERR_PTR(-EINVAL);
> + else if (IS_ERR(sgt))
> + return sgt;
>
> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
> DMA_ATTR_SKIP_CPU_SYNC)) {
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 7116abc1a04e..8b325bf6cef4 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -36,10 +36,12 @@ struct drm_file;
> struct drm_gem_object;
> struct drm_master;
> struct drm_minor;
> +struct dma_buf;
> struct dma_buf_attachment;
> struct drm_display_mode;
> struct drm_mode_create_dumb;
> struct drm_printer;
> +struct sg_table;
>
> /**
> * enum drm_driver_feature - feature flags
> @@ -327,32 +329,6 @@ struct drm_driver {
> */
> void (*debugfs_init)(struct drm_minor *minor);
>
> - /**
> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
> - *
> - * This is deprecated and should not be used by new drivers. Use
> - * &drm_gem_object_funcs.free instead.
> - */
> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
> -
> - /**
> - * @gem_open_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
> - *
> - * Driver hook called upon gem handle creation
> - */
> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
> -
> - /**
> - * @gem_close_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
> - *
> - * Driver hook called upon gem handle release
> - */
> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
> -
> /**
> * @gem_create_object: constructor for gem objects
> *
> @@ -361,6 +337,7 @@ struct drm_driver {
> */
> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
> size_t size);
> +
> /**
> * @prime_handle_to_fd:
> *
> @@ -383,14 +360,7 @@ struct drm_driver {
> */
> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
> int prime_fd, uint32_t *handle);
> - /**
> - * @gem_prime_export:
> - *
> - * Export hook for GEM drivers. Deprecated in favour of
> - * &drm_gem_object_funcs.export.
> - */
> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
> - int flags);
> +
> /**
> * @gem_prime_import:
> *
> @@ -400,29 +370,6 @@ struct drm_driver {
> */
> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
> struct dma_buf *dma_buf);
> -
> - /**
> - * @gem_prime_pin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
> - */
> - int (*gem_prime_pin)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_unpin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
> - */
> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
> -
> -
> - /**
> - * @gem_prime_get_sg_table:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
> - */
> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
> -
> /**
> * @gem_prime_import_sg_table:
> *
> @@ -433,22 +380,6 @@ struct drm_driver {
> struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt);
> - /**
> - * @gem_prime_vmap:
> - *
> - * Deprecated vmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vmap instead.
> - */
> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_vunmap:
> - *
> - * Deprecated vunmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vunmap instead.
> - */
> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
> -
> /**
> * @gem_prime_mmap:
> *
> @@ -523,14 +454,6 @@ struct drm_driver {
> struct drm_device *dev,
> uint32_t handle);
>
> - /**
> - * @gem_vm_ops: Driver private ops for this object
> - *
> - * For GEM drivers this is deprecated in favour of
> - * &drm_gem_object_funcs.vm_ops.
> - */
> - const struct vm_operations_struct *gem_vm_ops;
> -
> /** @major: driver major number */
> int major;
> /** @minor: driver minor number */
> --
> 2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:16 ` Sam Ravnborg
0 siblings, 0 replies; 243+ messages in thread
From: Sam Ravnborg @ 2020-08-13 10:16 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sumit.semwal, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, patrik.r.jakobsson,
jonathanh, linux-rockchip, kgene, bskeggs, xen-devel,
miaoqinglang, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, laurent.pinchart, hyun.kwon, rodrigosiqueiramelo,
aaron.liu, Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, chris,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas.
On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
> Several GEM and PRIME callbacks have been deprecated in favor of
> per-instance GEM object functions. Remove the callbacks as they are
> now unused. The only exception is .gem_prime_mmap, which is still
> in use by several drivers.
>
> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
> use struct drm_gem_object_funcs.vm_ops instead.
>
> While at it, the patch also improves error handling around calls
> to .free and .get_sg_table callbacks.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
After this following entry in todo.rst is done?
"
struct drm_gem_object_funcs
---------------------------
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
We also need a 2nd version of the CMA define that doesn't require the
vmapping to be present (different hook for prime importing). Plus this needs to
be rolled out to all drivers using their own implementations, too.
"
If yes, then delete it too.
Sam
> ---
> drivers/gpu/drm/drm_gem.c | 35 +++---------
> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
> drivers/gpu/drm/drm_prime.c | 17 +++---
> include/drm/drm_drv.h | 85 ++--------------------------
> 4 files changed, 23 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 19d73868490e..96945bed8291 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
> {
> struct drm_file *file_priv = data;
> struct drm_gem_object *obj = ptr;
> - struct drm_device *dev = obj->dev;
>
> if (obj->funcs && obj->funcs->close)
> obj->funcs->close(obj, file_priv);
> - else if (dev->driver->gem_close_object)
> - dev->driver->gem_close_object(obj, file_priv);
>
> drm_gem_remove_prime_handles(obj, file_priv);
> drm_vma_node_revoke(&obj->vma_node, file_priv);
> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
> ret = obj->funcs->open(obj, file_priv);
> if (ret)
> goto err_revoke;
> - } else if (dev->driver->gem_open_object) {
> - ret = dev->driver->gem_open_object(obj, file_priv);
> - if (ret)
> - goto err_revoke;
> }
>
> *handlep = handle;
> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
> {
> struct drm_gem_object *obj =
> container_of(kref, struct drm_gem_object, refcount);
> - struct drm_device *dev = obj->dev;
>
> - if (obj->funcs)
> - obj->funcs->free(obj);
> - else if (dev->driver->gem_free_object_unlocked)
> - dev->driver->gem_free_object_unlocked(obj);
> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
> + return;
> +
> + obj->funcs->free(obj);
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * @obj_size: the object size to be mapped, in bytes
> * @vma: VMA for the area to be mapped
> *
> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
> - * provided by the driver. Depending on their requirements, drivers can either
> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
> + * vm_ops. Depending on their requirements, GEM objects can either
> + * provide a fault handler in their vm_ops (in which case any accesses to
> * the object will be trapped, to perform migration, GTT binding, surface
> * register allocation, or performance monitoring), or mmap the buffer memory
> * synchronously after calling drm_gem_mmap_obj.
> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * callers must verify access restrictions before calling this helper.
> *
> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
> - * size, or if no gem_vm_ops are provided.
> + * size, or if no vm_ops are provided.
> */
> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> struct vm_area_struct *vma)
> {
> - struct drm_device *dev = obj->dev;
> int ret;
>
> /* Check for valid size. */
> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> } else {
> if (obj->funcs && obj->funcs->vm_ops)
> vma->vm_ops = obj->funcs->vm_ops;
> - else if (dev->driver->gem_vm_ops)
> - vma->vm_ops = dev->driver->gem_vm_ops;
> else {
> drm_gem_object_put(obj);
> return -EINVAL;
> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else if (obj->dev->driver->gem_prime_pin)
> - return obj->dev->driver->gem_prime_pin(obj);
> else
> return 0;
> }
> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->unpin)
> obj->funcs->unpin(obj);
> - else if (obj->dev->driver->gem_prime_unpin)
> - obj->dev->driver->gem_prime_unpin(obj);
> }
>
> void *drm_gem_vmap(struct drm_gem_object *obj)
> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>
> if (obj->funcs && obj->funcs->vmap)
> vaddr = obj->funcs->vmap(obj);
> - else if (obj->dev->driver->gem_prime_vmap)
> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
> else
> vaddr = ERR_PTR(-EOPNOTSUPP);
>
> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> if (obj->funcs && obj->funcs->vunmap)
> obj->funcs->vunmap(obj, vaddr);
> - else if (obj->dev->driver->gem_prime_vunmap)
> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
> }
>
> /**
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 822edeadbab3..209202257cc2 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
> *
> * This function exports a scatter/gather table suitable for PRIME usage by
> * calling the standard DMA mapping API. Drivers using the CMA helpers should
> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
> *
> * Returns:
> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
> * virtual address space. Since the CMA buffers are already mapped into the
> * kernel virtual address space this simply returns the cached virtual
> * address. Drivers using the CMA helpers should set this as their DRM
> - * driver's &drm_driver.gem_prime_vmap callback.
> + * driver's &drm_gem_object_funcs.vmap callback.
> *
> * Returns:
> * The kernel virtual address of the CMA GEM object's backing store.
> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
> * This function removes a buffer exported via DRM PRIME from the kernel's
> * virtual address space. This is a no-op because CMA buffers cannot be
> * unmapped from kernel space. Drivers using the CMA helpers should set this
> - * as their &drm_driver.gem_prime_vunmap callback.
> + * as their &drm_gem_object_funcs.vunmap callback.
> */
> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> {
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 1693aa7c14b5..9a87639e7008 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>
> if (obj->funcs && obj->funcs->export)
> dmabuf = obj->funcs->export(obj, flags);
> - else if (dev->driver->gem_prime_export)
> - dmabuf = dev->driver->gem_prime_export(obj, flags);
> - else
> - dmabuf = drm_gem_prime_export(obj, flags);
> if (IS_ERR(dmabuf)) {
> /* normally the created dma-buf takes ownership of the ref,
> * but if that fails then drop the ref
> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
> * This is the PRIME export function which must be used mandatorily by GEM
> * drivers to ensure correct lifetime management of the underlying GEM object.
> * The actual exporting from GEM object to a dma-buf is done through the
> - * &drm_driver.gem_prime_export driver callback.
> + * &drm_gem_object_funcs.export callback.
> */
> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
> struct drm_file *file_priv, uint32_t handle,
> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
> enum dma_data_direction dir)
> {
> struct drm_gem_object *obj = attach->dmabuf->priv;
> - struct sg_table *sgt;
> + struct sg_table *sgt = NULL;
>
> if (WARN_ON(dir == DMA_NONE))
> return ERR_PTR(-EINVAL);
>
> - if (obj->funcs)
> + if (obj->funcs && obj->funcs->get_sg_table)
> sgt = obj->funcs->get_sg_table(obj);
> - else
> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +
> + if (!sgt)
> + return ERR_PTR(-EINVAL);
> + else if (IS_ERR(sgt))
> + return sgt;
>
> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
> DMA_ATTR_SKIP_CPU_SYNC)) {
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 7116abc1a04e..8b325bf6cef4 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -36,10 +36,12 @@ struct drm_file;
> struct drm_gem_object;
> struct drm_master;
> struct drm_minor;
> +struct dma_buf;
> struct dma_buf_attachment;
> struct drm_display_mode;
> struct drm_mode_create_dumb;
> struct drm_printer;
> +struct sg_table;
>
> /**
> * enum drm_driver_feature - feature flags
> @@ -327,32 +329,6 @@ struct drm_driver {
> */
> void (*debugfs_init)(struct drm_minor *minor);
>
> - /**
> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
> - *
> - * This is deprecated and should not be used by new drivers. Use
> - * &drm_gem_object_funcs.free instead.
> - */
> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
> -
> - /**
> - * @gem_open_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
> - *
> - * Driver hook called upon gem handle creation
> - */
> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
> -
> - /**
> - * @gem_close_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
> - *
> - * Driver hook called upon gem handle release
> - */
> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
> -
> /**
> * @gem_create_object: constructor for gem objects
> *
> @@ -361,6 +337,7 @@ struct drm_driver {
> */
> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
> size_t size);
> +
> /**
> * @prime_handle_to_fd:
> *
> @@ -383,14 +360,7 @@ struct drm_driver {
> */
> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
> int prime_fd, uint32_t *handle);
> - /**
> - * @gem_prime_export:
> - *
> - * Export hook for GEM drivers. Deprecated in favour of
> - * &drm_gem_object_funcs.export.
> - */
> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
> - int flags);
> +
> /**
> * @gem_prime_import:
> *
> @@ -400,29 +370,6 @@ struct drm_driver {
> */
> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
> struct dma_buf *dma_buf);
> -
> - /**
> - * @gem_prime_pin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
> - */
> - int (*gem_prime_pin)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_unpin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
> - */
> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
> -
> -
> - /**
> - * @gem_prime_get_sg_table:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
> - */
> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
> -
> /**
> * @gem_prime_import_sg_table:
> *
> @@ -433,22 +380,6 @@ struct drm_driver {
> struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt);
> - /**
> - * @gem_prime_vmap:
> - *
> - * Deprecated vmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vmap instead.
> - */
> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_vunmap:
> - *
> - * Deprecated vunmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vunmap instead.
> - */
> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
> -
> /**
> * @gem_prime_mmap:
> *
> @@ -523,14 +454,6 @@ struct drm_driver {
> struct drm_device *dev,
> uint32_t handle);
>
> - /**
> - * @gem_vm_ops: Driver private ops for this object
> - *
> - * For GEM drivers this is deprecated in favour of
> - * &drm_gem_object_funcs.vm_ops.
> - */
> - const struct vm_operations_struct *gem_vm_ops;
> -
> /** @major: driver major number */
> int major;
> /** @minor: driver minor number */
> --
> 2.28.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:16 ` Sam Ravnborg
0 siblings, 0 replies; 243+ messages in thread
From: Sam Ravnborg @ 2020-08-13 10:16 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: hamohammed.sa, heiko, andrey.grodzovsky, airlied, nouveau,
joonas.lahtinen, dri-devel, michal.simek, eric, thierry.reding,
robdclark, krzk, sumit.semwal, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, patrik.r.jakobsson,
jonathanh, linux-rockchip, kgene, bskeggs, xen-devel,
miaoqinglang, intel-gfx, matthew.auld, chunkuang.hu, andi.shyti,
daniel, linux-arm-msm, marek.olsak, tianci.yin,
maarten.lankhorst, etnaviv, jani.nikula, inki.dae, hdegoede,
christian.gmeiner, linux-mediatek, mripard, rodrigo.vivi,
matthias.bgg, evan.quan, sean, linux-arm-kernel, tvrtko.ursulin,
amd-gfx, laurent.pinchart, hyun.kwon, rodrigosiqueiramelo,
aaron.liu, Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, chris,
kyungmin.park, nirmoy.das, p.zabel, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, l.stach
Hi Thomas.
On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
> Several GEM and PRIME callbacks have been deprecated in favor of
> per-instance GEM object functions. Remove the callbacks as they are
> now unused. The only exception is .gem_prime_mmap, which is still
> in use by several drivers.
>
> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
> use struct drm_gem_object_funcs.vm_ops instead.
>
> While at it, the patch also improves error handling around calls
> to .free and .get_sg_table callbacks.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
After this following entry in todo.rst is done?
"
struct drm_gem_object_funcs
---------------------------
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
We also need a 2nd version of the CMA define that doesn't require the
vmapping to be present (different hook for prime importing). Plus this needs to
be rolled out to all drivers using their own implementations, too.
"
If yes, then delete it too.
Sam
> ---
> drivers/gpu/drm/drm_gem.c | 35 +++---------
> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
> drivers/gpu/drm/drm_prime.c | 17 +++---
> include/drm/drm_drv.h | 85 ++--------------------------
> 4 files changed, 23 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 19d73868490e..96945bed8291 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
> {
> struct drm_file *file_priv = data;
> struct drm_gem_object *obj = ptr;
> - struct drm_device *dev = obj->dev;
>
> if (obj->funcs && obj->funcs->close)
> obj->funcs->close(obj, file_priv);
> - else if (dev->driver->gem_close_object)
> - dev->driver->gem_close_object(obj, file_priv);
>
> drm_gem_remove_prime_handles(obj, file_priv);
> drm_vma_node_revoke(&obj->vma_node, file_priv);
> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
> ret = obj->funcs->open(obj, file_priv);
> if (ret)
> goto err_revoke;
> - } else if (dev->driver->gem_open_object) {
> - ret = dev->driver->gem_open_object(obj, file_priv);
> - if (ret)
> - goto err_revoke;
> }
>
> *handlep = handle;
> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
> {
> struct drm_gem_object *obj =
> container_of(kref, struct drm_gem_object, refcount);
> - struct drm_device *dev = obj->dev;
>
> - if (obj->funcs)
> - obj->funcs->free(obj);
> - else if (dev->driver->gem_free_object_unlocked)
> - dev->driver->gem_free_object_unlocked(obj);
> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
> + return;
> +
> + obj->funcs->free(obj);
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * @obj_size: the object size to be mapped, in bytes
> * @vma: VMA for the area to be mapped
> *
> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
> - * provided by the driver. Depending on their requirements, drivers can either
> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
> + * vm_ops. Depending on their requirements, GEM objects can either
> + * provide a fault handler in their vm_ops (in which case any accesses to
> * the object will be trapped, to perform migration, GTT binding, surface
> * register allocation, or performance monitoring), or mmap the buffer memory
> * synchronously after calling drm_gem_mmap_obj.
> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * callers must verify access restrictions before calling this helper.
> *
> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
> - * size, or if no gem_vm_ops are provided.
> + * size, or if no vm_ops are provided.
> */
> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> struct vm_area_struct *vma)
> {
> - struct drm_device *dev = obj->dev;
> int ret;
>
> /* Check for valid size. */
> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> } else {
> if (obj->funcs && obj->funcs->vm_ops)
> vma->vm_ops = obj->funcs->vm_ops;
> - else if (dev->driver->gem_vm_ops)
> - vma->vm_ops = dev->driver->gem_vm_ops;
> else {
> drm_gem_object_put(obj);
> return -EINVAL;
> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else if (obj->dev->driver->gem_prime_pin)
> - return obj->dev->driver->gem_prime_pin(obj);
> else
> return 0;
> }
> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->unpin)
> obj->funcs->unpin(obj);
> - else if (obj->dev->driver->gem_prime_unpin)
> - obj->dev->driver->gem_prime_unpin(obj);
> }
>
> void *drm_gem_vmap(struct drm_gem_object *obj)
> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>
> if (obj->funcs && obj->funcs->vmap)
> vaddr = obj->funcs->vmap(obj);
> - else if (obj->dev->driver->gem_prime_vmap)
> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
> else
> vaddr = ERR_PTR(-EOPNOTSUPP);
>
> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> if (obj->funcs && obj->funcs->vunmap)
> obj->funcs->vunmap(obj, vaddr);
> - else if (obj->dev->driver->gem_prime_vunmap)
> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
> }
>
> /**
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 822edeadbab3..209202257cc2 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
> *
> * This function exports a scatter/gather table suitable for PRIME usage by
> * calling the standard DMA mapping API. Drivers using the CMA helpers should
> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
> *
> * Returns:
> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
> * virtual address space. Since the CMA buffers are already mapped into the
> * kernel virtual address space this simply returns the cached virtual
> * address. Drivers using the CMA helpers should set this as their DRM
> - * driver's &drm_driver.gem_prime_vmap callback.
> + * driver's &drm_gem_object_funcs.vmap callback.
> *
> * Returns:
> * The kernel virtual address of the CMA GEM object's backing store.
> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
> * This function removes a buffer exported via DRM PRIME from the kernel's
> * virtual address space. This is a no-op because CMA buffers cannot be
> * unmapped from kernel space. Drivers using the CMA helpers should set this
> - * as their &drm_driver.gem_prime_vunmap callback.
> + * as their &drm_gem_object_funcs.vunmap callback.
> */
> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> {
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 1693aa7c14b5..9a87639e7008 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>
> if (obj->funcs && obj->funcs->export)
> dmabuf = obj->funcs->export(obj, flags);
> - else if (dev->driver->gem_prime_export)
> - dmabuf = dev->driver->gem_prime_export(obj, flags);
> - else
> - dmabuf = drm_gem_prime_export(obj, flags);
> if (IS_ERR(dmabuf)) {
> /* normally the created dma-buf takes ownership of the ref,
> * but if that fails then drop the ref
> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
> * This is the PRIME export function which must be used mandatorily by GEM
> * drivers to ensure correct lifetime management of the underlying GEM object.
> * The actual exporting from GEM object to a dma-buf is done through the
> - * &drm_driver.gem_prime_export driver callback.
> + * &drm_gem_object_funcs.export callback.
> */
> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
> struct drm_file *file_priv, uint32_t handle,
> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
> enum dma_data_direction dir)
> {
> struct drm_gem_object *obj = attach->dmabuf->priv;
> - struct sg_table *sgt;
> + struct sg_table *sgt = NULL;
>
> if (WARN_ON(dir == DMA_NONE))
> return ERR_PTR(-EINVAL);
>
> - if (obj->funcs)
> + if (obj->funcs && obj->funcs->get_sg_table)
> sgt = obj->funcs->get_sg_table(obj);
> - else
> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +
> + if (!sgt)
> + return ERR_PTR(-EINVAL);
> + else if (IS_ERR(sgt))
> + return sgt;
>
> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
> DMA_ATTR_SKIP_CPU_SYNC)) {
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 7116abc1a04e..8b325bf6cef4 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -36,10 +36,12 @@ struct drm_file;
> struct drm_gem_object;
> struct drm_master;
> struct drm_minor;
> +struct dma_buf;
> struct dma_buf_attachment;
> struct drm_display_mode;
> struct drm_mode_create_dumb;
> struct drm_printer;
> +struct sg_table;
>
> /**
> * enum drm_driver_feature - feature flags
> @@ -327,32 +329,6 @@ struct drm_driver {
> */
> void (*debugfs_init)(struct drm_minor *minor);
>
> - /**
> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
> - *
> - * This is deprecated and should not be used by new drivers. Use
> - * &drm_gem_object_funcs.free instead.
> - */
> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
> -
> - /**
> - * @gem_open_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
> - *
> - * Driver hook called upon gem handle creation
> - */
> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
> -
> - /**
> - * @gem_close_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
> - *
> - * Driver hook called upon gem handle release
> - */
> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
> -
> /**
> * @gem_create_object: constructor for gem objects
> *
> @@ -361,6 +337,7 @@ struct drm_driver {
> */
> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
> size_t size);
> +
> /**
> * @prime_handle_to_fd:
> *
> @@ -383,14 +360,7 @@ struct drm_driver {
> */
> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
> int prime_fd, uint32_t *handle);
> - /**
> - * @gem_prime_export:
> - *
> - * Export hook for GEM drivers. Deprecated in favour of
> - * &drm_gem_object_funcs.export.
> - */
> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
> - int flags);
> +
> /**
> * @gem_prime_import:
> *
> @@ -400,29 +370,6 @@ struct drm_driver {
> */
> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
> struct dma_buf *dma_buf);
> -
> - /**
> - * @gem_prime_pin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
> - */
> - int (*gem_prime_pin)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_unpin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
> - */
> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
> -
> -
> - /**
> - * @gem_prime_get_sg_table:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
> - */
> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
> -
> /**
> * @gem_prime_import_sg_table:
> *
> @@ -433,22 +380,6 @@ struct drm_driver {
> struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt);
> - /**
> - * @gem_prime_vmap:
> - *
> - * Deprecated vmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vmap instead.
> - */
> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_vunmap:
> - *
> - * Deprecated vunmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vunmap instead.
> - */
> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
> -
> /**
> * @gem_prime_mmap:
> *
> @@ -523,14 +454,6 @@ struct drm_driver {
> struct drm_device *dev,
> uint32_t handle);
>
> - /**
> - * @gem_vm_ops: Driver private ops for this object
> - *
> - * For GEM drivers this is deprecated in favour of
> - * &drm_gem_object_funcs.vm_ops.
> - */
> - const struct vm_operations_struct *gem_vm_ops;
> -
> /** @major: driver major number */
> int major;
> /** @minor: driver minor number */
> --
> 2.28.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:16 ` Sam Ravnborg
0 siblings, 0 replies; 243+ messages in thread
From: Sam Ravnborg @ 2020-08-13 10:16 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: alexander.deucher-5C7GfCeVMHo, christian.koenig-5C7GfCeVMHo,
airlied-cv59FeDIM0c, daniel-/w4YWyX8dFk,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA,
mripard-DgEjT+Ai2ygdnm+yROfE0A, l.stach-bIcnvbaLZ9MEGnE8C9+IrQ,
christian.gmeiner-Re5JQEeQqe8AvxtiuMwx3w,
inki.dae-Sze3O3UU22JBDgjK7y7TUQ,
jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ,
kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w,
jani.nikula-VuQAYsv1563Yd54FQh9/CA,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w,
chunkuang.hu-DgEjT+Ai2ygdnm+yROfE0A,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
robdclark-Re5JQEeQqe8AvxtiuMwx3w, sean-p7yTbzM4H96eqtR555YLDQ,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA, tomi.valkeinen-l0cyMroinI0,
eric-WhKQ6XTQaPysTnJN9+BGXg, hjc-TNX95d0MmH7DzftRWevZcw,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
jonathanh-DDmLM1+adcrQT0dZR+AlfA,
rodrigosiqueiramelo-Re5JQEeQqe8AvxtiuMwx3w,
hamohammed.sa-Re5JQEeQqe8AvxtiuMwx3w, olek
Hi Thomas.
On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
> Several GEM and PRIME callbacks have been deprecated in favor of
> per-instance GEM object functions. Remove the callbacks as they are
> now unused. The only exception is .gem_prime_mmap, which is still
> in use by several drivers.
>
> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
> use struct drm_gem_object_funcs.vm_ops instead.
>
> While at it, the patch also improves error handling around calls
> to .free and .get_sg_table callbacks.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
After this following entry in todo.rst is done?
"
struct drm_gem_object_funcs
---------------------------
GEM objects can now have a function table instead of having the callbacks on the
DRM driver struct. This is now the preferred way and drivers can be moved over.
We also need a 2nd version of the CMA define that doesn't require the
vmapping to be present (different hook for prime importing). Plus this needs to
be rolled out to all drivers using their own implementations, too.
"
If yes, then delete it too.
Sam
> ---
> drivers/gpu/drm/drm_gem.c | 35 +++---------
> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
> drivers/gpu/drm/drm_prime.c | 17 +++---
> include/drm/drm_drv.h | 85 ++--------------------------
> 4 files changed, 23 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 19d73868490e..96945bed8291 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
> {
> struct drm_file *file_priv = data;
> struct drm_gem_object *obj = ptr;
> - struct drm_device *dev = obj->dev;
>
> if (obj->funcs && obj->funcs->close)
> obj->funcs->close(obj, file_priv);
> - else if (dev->driver->gem_close_object)
> - dev->driver->gem_close_object(obj, file_priv);
>
> drm_gem_remove_prime_handles(obj, file_priv);
> drm_vma_node_revoke(&obj->vma_node, file_priv);
> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
> ret = obj->funcs->open(obj, file_priv);
> if (ret)
> goto err_revoke;
> - } else if (dev->driver->gem_open_object) {
> - ret = dev->driver->gem_open_object(obj, file_priv);
> - if (ret)
> - goto err_revoke;
> }
>
> *handlep = handle;
> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
> {
> struct drm_gem_object *obj =
> container_of(kref, struct drm_gem_object, refcount);
> - struct drm_device *dev = obj->dev;
>
> - if (obj->funcs)
> - obj->funcs->free(obj);
> - else if (dev->driver->gem_free_object_unlocked)
> - dev->driver->gem_free_object_unlocked(obj);
> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
> + return;
> +
> + obj->funcs->free(obj);
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * @obj_size: the object size to be mapped, in bytes
> * @vma: VMA for the area to be mapped
> *
> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
> - * provided by the driver. Depending on their requirements, drivers can either
> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
> + * vm_ops. Depending on their requirements, GEM objects can either
> + * provide a fault handler in their vm_ops (in which case any accesses to
> * the object will be trapped, to perform migration, GTT binding, surface
> * register allocation, or performance monitoring), or mmap the buffer memory
> * synchronously after calling drm_gem_mmap_obj.
> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
> * callers must verify access restrictions before calling this helper.
> *
> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
> - * size, or if no gem_vm_ops are provided.
> + * size, or if no vm_ops are provided.
> */
> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> struct vm_area_struct *vma)
> {
> - struct drm_device *dev = obj->dev;
> int ret;
>
> /* Check for valid size. */
> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
> } else {
> if (obj->funcs && obj->funcs->vm_ops)
> vma->vm_ops = obj->funcs->vm_ops;
> - else if (dev->driver->gem_vm_ops)
> - vma->vm_ops = dev->driver->gem_vm_ops;
> else {
> drm_gem_object_put(obj);
> return -EINVAL;
> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->pin)
> return obj->funcs->pin(obj);
> - else if (obj->dev->driver->gem_prime_pin)
> - return obj->dev->driver->gem_prime_pin(obj);
> else
> return 0;
> }
> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
> {
> if (obj->funcs && obj->funcs->unpin)
> obj->funcs->unpin(obj);
> - else if (obj->dev->driver->gem_prime_unpin)
> - obj->dev->driver->gem_prime_unpin(obj);
> }
>
> void *drm_gem_vmap(struct drm_gem_object *obj)
> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>
> if (obj->funcs && obj->funcs->vmap)
> vaddr = obj->funcs->vmap(obj);
> - else if (obj->dev->driver->gem_prime_vmap)
> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
> else
> vaddr = ERR_PTR(-EOPNOTSUPP);
>
> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>
> if (obj->funcs && obj->funcs->vunmap)
> obj->funcs->vunmap(obj, vaddr);
> - else if (obj->dev->driver->gem_prime_vunmap)
> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
> }
>
> /**
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 822edeadbab3..209202257cc2 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
> *
> * This function exports a scatter/gather table suitable for PRIME usage by
> * calling the standard DMA mapping API. Drivers using the CMA helpers should
> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
> *
> * Returns:
> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
> * virtual address space. Since the CMA buffers are already mapped into the
> * kernel virtual address space this simply returns the cached virtual
> * address. Drivers using the CMA helpers should set this as their DRM
> - * driver's &drm_driver.gem_prime_vmap callback.
> + * driver's &drm_gem_object_funcs.vmap callback.
> *
> * Returns:
> * The kernel virtual address of the CMA GEM object's backing store.
> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
> * This function removes a buffer exported via DRM PRIME from the kernel's
> * virtual address space. This is a no-op because CMA buffers cannot be
> * unmapped from kernel space. Drivers using the CMA helpers should set this
> - * as their &drm_driver.gem_prime_vunmap callback.
> + * as their &drm_gem_object_funcs.vunmap callback.
> */
> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> {
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 1693aa7c14b5..9a87639e7008 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>
> if (obj->funcs && obj->funcs->export)
> dmabuf = obj->funcs->export(obj, flags);
> - else if (dev->driver->gem_prime_export)
> - dmabuf = dev->driver->gem_prime_export(obj, flags);
> - else
> - dmabuf = drm_gem_prime_export(obj, flags);
> if (IS_ERR(dmabuf)) {
> /* normally the created dma-buf takes ownership of the ref,
> * but if that fails then drop the ref
> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
> * This is the PRIME export function which must be used mandatorily by GEM
> * drivers to ensure correct lifetime management of the underlying GEM object.
> * The actual exporting from GEM object to a dma-buf is done through the
> - * &drm_driver.gem_prime_export driver callback.
> + * &drm_gem_object_funcs.export callback.
> */
> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
> struct drm_file *file_priv, uint32_t handle,
> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
> enum dma_data_direction dir)
> {
> struct drm_gem_object *obj = attach->dmabuf->priv;
> - struct sg_table *sgt;
> + struct sg_table *sgt = NULL;
>
> if (WARN_ON(dir == DMA_NONE))
> return ERR_PTR(-EINVAL);
>
> - if (obj->funcs)
> + if (obj->funcs && obj->funcs->get_sg_table)
> sgt = obj->funcs->get_sg_table(obj);
> - else
> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
> +
> + if (!sgt)
> + return ERR_PTR(-EINVAL);
> + else if (IS_ERR(sgt))
> + return sgt;
>
> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
> DMA_ATTR_SKIP_CPU_SYNC)) {
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 7116abc1a04e..8b325bf6cef4 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -36,10 +36,12 @@ struct drm_file;
> struct drm_gem_object;
> struct drm_master;
> struct drm_minor;
> +struct dma_buf;
> struct dma_buf_attachment;
> struct drm_display_mode;
> struct drm_mode_create_dumb;
> struct drm_printer;
> +struct sg_table;
>
> /**
> * enum drm_driver_feature - feature flags
> @@ -327,32 +329,6 @@ struct drm_driver {
> */
> void (*debugfs_init)(struct drm_minor *minor);
>
> - /**
> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
> - *
> - * This is deprecated and should not be used by new drivers. Use
> - * &drm_gem_object_funcs.free instead.
> - */
> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
> -
> - /**
> - * @gem_open_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
> - *
> - * Driver hook called upon gem handle creation
> - */
> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
> -
> - /**
> - * @gem_close_object:
> - *
> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
> - *
> - * Driver hook called upon gem handle release
> - */
> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
> -
> /**
> * @gem_create_object: constructor for gem objects
> *
> @@ -361,6 +337,7 @@ struct drm_driver {
> */
> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
> size_t size);
> +
> /**
> * @prime_handle_to_fd:
> *
> @@ -383,14 +360,7 @@ struct drm_driver {
> */
> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
> int prime_fd, uint32_t *handle);
> - /**
> - * @gem_prime_export:
> - *
> - * Export hook for GEM drivers. Deprecated in favour of
> - * &drm_gem_object_funcs.export.
> - */
> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
> - int flags);
> +
> /**
> * @gem_prime_import:
> *
> @@ -400,29 +370,6 @@ struct drm_driver {
> */
> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
> struct dma_buf *dma_buf);
> -
> - /**
> - * @gem_prime_pin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
> - */
> - int (*gem_prime_pin)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_unpin:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
> - */
> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
> -
> -
> - /**
> - * @gem_prime_get_sg_table:
> - *
> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
> - */
> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
> -
> /**
> * @gem_prime_import_sg_table:
> *
> @@ -433,22 +380,6 @@ struct drm_driver {
> struct drm_device *dev,
> struct dma_buf_attachment *attach,
> struct sg_table *sgt);
> - /**
> - * @gem_prime_vmap:
> - *
> - * Deprecated vmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vmap instead.
> - */
> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
> -
> - /**
> - * @gem_prime_vunmap:
> - *
> - * Deprecated vunmap hook for GEM drivers. Please use
> - * &drm_gem_object_funcs.vunmap instead.
> - */
> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
> -
> /**
> * @gem_prime_mmap:
> *
> @@ -523,14 +454,6 @@ struct drm_driver {
> struct drm_device *dev,
> uint32_t handle);
>
> - /**
> - * @gem_vm_ops: Driver private ops for this object
> - *
> - * For GEM drivers this is deprecated in favour of
> - * &drm_gem_object_funcs.vm_ops.
> - */
> - const struct vm_operations_struct *gem_vm_ops;
> -
> /** @major: driver major number */
> int major;
> /** @minor: driver minor number */
> --
> 2.28.0
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
2020-08-13 10:16 ` Sam Ravnborg
` (5 preceding siblings ...)
(?)
@ 2020-08-13 10:33 ` Thomas Zimmermann
-1 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, michal.simek,
thierry.reding, krzk, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, jonathanh, linux-rockchip,
kgene, bskeggs, xen-devel, miaoqinglang, intel-gfx, matthew.auld,
chunkuang.hu, andi.shyti, linux-arm-msm, marek.olsak, tianci.yin,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, matthias.bgg,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx,
laurent.pinchart, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, chris,
kyungmin.park, nirmoy.das, alexander.deucher, Hawking.Zhang,
freedreno, christian.koenig
[-- Attachment #1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:33 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, krzk, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, miaoqinglang, jonathanh, linux-rockchip,
tomi.valkeinen, bskeggs, xen-devel, marek.olsak, matthew.auld,
chunkuang.hu, andi.shyti, linux-arm-msm, intel-gfx, tianci.yin,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx,
chris, rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, nirmoy.das, kgene,
alexander.deucher, Hawking.Zhang, freedreno, christian.koenig,
laurent.pinchart
[-- Attachment #1.1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:33 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, michal.simek,
thierry.reding, krzk, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
tomi.valkeinen, linux-tegra, linux, jonathanh, linux-rockchip,
kgene, bskeggs, xen-devel, miaoqinglang, intel-gfx, matthew.auld,
chunkuang.hu, andi.shyti, linux-arm-msm, marek.olsak, tianci.yin,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, matthias.bgg,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx,
laurent.pinchart, hyun.kwon, rodrigosiqueiramelo, aaron.liu,
Felix.Kuehling, xinhui.pan, sw0312.kim, hjc, chris,
kyungmin.park, nirmoy.das, alexander.deucher, Hawking.Zhang,
freedreno, christian.koenig
[-- Attachment #1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:33 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
krzk, emil.velikov, abdiel.janulgue, linux-samsung-soc,
jy0922.shim, oleksandr_andrushchenko, michal.simek, miaoqinglang,
jonathanh, linux-rockchip, tomi.valkeinen, bskeggs, xen-devel,
marek.olsak, matthew.auld, chunkuang.hu, linux-arm-msm,
intel-gfx, tianci.yin, etnaviv, linux-mediatek, linux-tegra,
evan.quan, linux-arm-kernel, amd-gfx, chris, rodrigosiqueiramelo,
hyun.kwon, aaron.liu, Felix.Kuehling, xinhui.pan, sw0312.kim,
hjc, kyungmin.park, nirmoy.das, kgene, alexander.deucher,
Hawking.Zhang, freedreno, christian.koenig, laurent.pinchart
[-- Attachment #1.1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:33 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, krzk, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, miaoqinglang, jonathanh, linux-rockchip,
tomi.valkeinen, bskeggs, xen-devel, marek.olsak, matthew.auld,
chunkuang.hu, andi.shyti, linux-arm-msm, intel-gfx, tianci.yin,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx,
chris, rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, nirmoy.das, kgene,
alexander.deucher, Hawking.Zhang, freedreno, christian.koenig,
laurent.pinchart
[-- Attachment #1.1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:33 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, krzk, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, miaoqinglang, jonathanh, linux-rockchip,
tomi.valkeinen, bskeggs, xen-devel, marek.olsak, matthew.auld,
chunkuang.hu, andi.shyti, linux-arm-msm, intel-gfx, tianci.yin,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx,
chris, rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, nirmoy.das, kgene,
alexander.deucher, Hawking.Zhang, freedreno, christian.koenig,
laurent.pinchart
[-- Attachment #1.1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:33 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
thierry.reding, krzk, emil.velikov, abdiel.janulgue,
linux-samsung-soc, jy0922.shim, oleksandr_andrushchenko,
michal.simek, miaoqinglang, jonathanh, linux-rockchip,
tomi.valkeinen, bskeggs, xen-devel, marek.olsak, matthew.auld,
chunkuang.hu, andi.shyti, linux-arm-msm, intel-gfx, tianci.yin,
etnaviv, hdegoede, linux-mediatek, rodrigo.vivi, linux-tegra,
evan.quan, sean, linux-arm-kernel, tvrtko.ursulin, amd-gfx,
chris, rodrigosiqueiramelo, hyun.kwon, aaron.liu, Felix.Kuehling,
xinhui.pan, sw0312.kim, hjc, kyungmin.park, nirmoy.das, kgene,
alexander.deucher, Hawking.Zhang, freedreno, christian.koenig,
laurent.pinchart
[-- Attachment #1.1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
@ 2020-08-13 10:33 ` Thomas Zimmermann
0 siblings, 0 replies; 243+ messages in thread
From: Thomas Zimmermann @ 2020-08-13 10:33 UTC (permalink / raw)
To: Sam Ravnborg
Cc: hamohammed.sa, airlied, nouveau, dri-devel, linux, matthias.bgg,
krzk, emil.velikov, abdiel.janulgue, linux-samsung-soc,
jy0922.shim, oleksandr_andrushchenko, michal.simek, miaoqinglang,
jonathanh, linux-rockchip, tomi.valkeinen, bskeggs, xen-devel,
marek.olsak, matthew.auld, chunkuang.hu, linux-arm-msm,
intel-gfx, tianci.yin, etnaviv, linux-mediatek, linux-tegra,
evan.quan, linux-arm-kernel, amd-gfx, chris, rodrigosiq
[-- Attachment #1.1.1: Type: text/plain, Size: 14886 bytes --]
Hi
Am 13.08.20 um 12:16 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Aug 13, 2020 at 10:36:44AM +0200, Thomas Zimmermann wrote:
>> Several GEM and PRIME callbacks have been deprecated in favor of
>> per-instance GEM object functions. Remove the callbacks as they are
>> now unused. The only exception is .gem_prime_mmap, which is still
>> in use by several drivers.
>>
>> What is also gone is gem_vm_ops in struct drm_driver. All drivers now
>> use struct drm_gem_object_funcs.vm_ops instead.
>>
>> While at it, the patch also improves error handling around calls
>> to .free and .get_sg_table callbacks.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> After this following entry in todo.rst is done?
>
> "
> struct drm_gem_object_funcs
> ---------------------------
>
> GEM objects can now have a function table instead of having the callbacks on the
> DRM driver struct. This is now the preferred way and drivers can be moved over.
This should only say that .gem_prime_mmap() is left in struct
drm_drivers for conversion.
>
> We also need a 2nd version of the CMA define that doesn't require the
> vmapping to be present (different hook for prime importing). Plus this needs to
> be rolled out to all drivers using their own implementations, too.
> "
This sounds like it got fixed in the recent CMA clean-up series. There
are CMA initializer macros for drivers with and without vmap. I have to
take a closer look, but I think it can be removed.
Thanks for bringing this up.
Best regards
Thomas
>
> If yes, then delete it too.
>
> Sam
>
>> ---
>> drivers/gpu/drm/drm_gem.c | 35 +++---------
>> drivers/gpu/drm/drm_gem_cma_helper.c | 6 +-
>> drivers/gpu/drm/drm_prime.c | 17 +++---
>> include/drm/drm_drv.h | 85 ++--------------------------
>> 4 files changed, 23 insertions(+), 120 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
>> index 19d73868490e..96945bed8291 100644
>> --- a/drivers/gpu/drm/drm_gem.c
>> +++ b/drivers/gpu/drm/drm_gem.c
>> @@ -247,12 +247,9 @@ drm_gem_object_release_handle(int id, void *ptr, void *data)
>> {
>> struct drm_file *file_priv = data;
>> struct drm_gem_object *obj = ptr;
>> - struct drm_device *dev = obj->dev;
>>
>> if (obj->funcs && obj->funcs->close)
>> obj->funcs->close(obj, file_priv);
>> - else if (dev->driver->gem_close_object)
>> - dev->driver->gem_close_object(obj, file_priv);
>>
>> drm_gem_remove_prime_handles(obj, file_priv);
>> drm_vma_node_revoke(&obj->vma_node, file_priv);
>> @@ -407,10 +404,6 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
>> ret = obj->funcs->open(obj, file_priv);
>> if (ret)
>> goto err_revoke;
>> - } else if (dev->driver->gem_open_object) {
>> - ret = dev->driver->gem_open_object(obj, file_priv);
>> - if (ret)
>> - goto err_revoke;
>> }
>>
>> *handlep = handle;
>> @@ -982,12 +975,11 @@ drm_gem_object_free(struct kref *kref)
>> {
>> struct drm_gem_object *obj =
>> container_of(kref, struct drm_gem_object, refcount);
>> - struct drm_device *dev = obj->dev;
>>
>> - if (obj->funcs)
>> - obj->funcs->free(obj);
>> - else if (dev->driver->gem_free_object_unlocked)
>> - dev->driver->gem_free_object_unlocked(obj);
>> + if (drm_WARN_ON_ONCE(obj->dev, !obj->funcs || !obj->funcs->free))
>> + return;
>> +
>> + obj->funcs->free(obj);
>> }
>> EXPORT_SYMBOL(drm_gem_object_free);
>>
>> @@ -1049,9 +1041,9 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * @obj_size: the object size to be mapped, in bytes
>> * @vma: VMA for the area to be mapped
>> *
>> - * Set up the VMA to prepare mapping of the GEM object using the gem_vm_ops
>> - * provided by the driver. Depending on their requirements, drivers can either
>> - * provide a fault handler in their gem_vm_ops (in which case any accesses to
>> + * Set up the VMA to prepare mapping of the GEM object using the GEM object's
>> + * vm_ops. Depending on their requirements, GEM objects can either
>> + * provide a fault handler in their vm_ops (in which case any accesses to
>> * the object will be trapped, to perform migration, GTT binding, surface
>> * register allocation, or performance monitoring), or mmap the buffer memory
>> * synchronously after calling drm_gem_mmap_obj.
>> @@ -1065,12 +1057,11 @@ EXPORT_SYMBOL(drm_gem_vm_close);
>> * callers must verify access restrictions before calling this helper.
>> *
>> * Return 0 or success or -EINVAL if the object size is smaller than the VMA
>> - * size, or if no gem_vm_ops are provided.
>> + * size, or if no vm_ops are provided.
>> */
>> int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> struct vm_area_struct *vma)
>> {
>> - struct drm_device *dev = obj->dev;
>> int ret;
>>
>> /* Check for valid size. */
>> @@ -1095,8 +1086,6 @@ int drm_gem_mmap_obj(struct drm_gem_object *obj, unsigned long obj_size,
>> } else {
>> if (obj->funcs && obj->funcs->vm_ops)
>> vma->vm_ops = obj->funcs->vm_ops;
>> - else if (dev->driver->gem_vm_ops)
>> - vma->vm_ops = dev->driver->gem_vm_ops;
>> else {
>> drm_gem_object_put(obj);
>> return -EINVAL;
>> @@ -1206,8 +1195,6 @@ int drm_gem_pin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->pin)
>> return obj->funcs->pin(obj);
>> - else if (obj->dev->driver->gem_prime_pin)
>> - return obj->dev->driver->gem_prime_pin(obj);
>> else
>> return 0;
>> }
>> @@ -1216,8 +1203,6 @@ void drm_gem_unpin(struct drm_gem_object *obj)
>> {
>> if (obj->funcs && obj->funcs->unpin)
>> obj->funcs->unpin(obj);
>> - else if (obj->dev->driver->gem_prime_unpin)
>> - obj->dev->driver->gem_prime_unpin(obj);
>> }
>>
>> void *drm_gem_vmap(struct drm_gem_object *obj)
>> @@ -1226,8 +1211,6 @@ void *drm_gem_vmap(struct drm_gem_object *obj)
>>
>> if (obj->funcs && obj->funcs->vmap)
>> vaddr = obj->funcs->vmap(obj);
>> - else if (obj->dev->driver->gem_prime_vmap)
>> - vaddr = obj->dev->driver->gem_prime_vmap(obj);
>> else
>> vaddr = ERR_PTR(-EOPNOTSUPP);
>>
>> @@ -1244,8 +1227,6 @@ void drm_gem_vunmap(struct drm_gem_object *obj, void *vaddr)
>>
>> if (obj->funcs && obj->funcs->vunmap)
>> obj->funcs->vunmap(obj, vaddr);
>> - else if (obj->dev->driver->gem_prime_vunmap)
>> - obj->dev->driver->gem_prime_vunmap(obj, vaddr);
>> }
>>
>> /**
>> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
>> index 822edeadbab3..209202257cc2 100644
>> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
>> @@ -419,7 +419,7 @@ EXPORT_SYMBOL(drm_gem_cma_print_info);
>> *
>> * This function exports a scatter/gather table suitable for PRIME usage by
>> * calling the standard DMA mapping API. Drivers using the CMA helpers should
>> - * set this as their &drm_driver.gem_prime_get_sg_table callback.
>> + * set this as their &drm_gem_object_funcs.get_sg_table callback.
>> *
>> * Returns:
>> * A pointer to the scatter/gather table of pinned pages or NULL on failure.
>> @@ -542,7 +542,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_mmap);
>> * virtual address space. Since the CMA buffers are already mapped into the
>> * kernel virtual address space this simply returns the cached virtual
>> * address. Drivers using the CMA helpers should set this as their DRM
>> - * driver's &drm_driver.gem_prime_vmap callback.
>> + * driver's &drm_gem_object_funcs.vmap callback.
>> *
>> * Returns:
>> * The kernel virtual address of the CMA GEM object's backing store.
>> @@ -564,7 +564,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_prime_vmap);
>> * This function removes a buffer exported via DRM PRIME from the kernel's
>> * virtual address space. This is a no-op because CMA buffers cannot be
>> * unmapped from kernel space. Drivers using the CMA helpers should set this
>> - * as their &drm_driver.gem_prime_vunmap callback.
>> + * as their &drm_gem_object_funcs.vunmap callback.
>> */
>> void drm_gem_cma_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
>> {
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 1693aa7c14b5..9a87639e7008 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -386,10 +386,6 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>>
>> if (obj->funcs && obj->funcs->export)
>> dmabuf = obj->funcs->export(obj, flags);
>> - else if (dev->driver->gem_prime_export)
>> - dmabuf = dev->driver->gem_prime_export(obj, flags);
>> - else
>> - dmabuf = drm_gem_prime_export(obj, flags);
>> if (IS_ERR(dmabuf)) {
>> /* normally the created dma-buf takes ownership of the ref,
>> * but if that fails then drop the ref
>> @@ -419,7 +415,7 @@ static struct dma_buf *export_and_register_object(struct drm_device *dev,
>> * This is the PRIME export function which must be used mandatorily by GEM
>> * drivers to ensure correct lifetime management of the underlying GEM object.
>> * The actual exporting from GEM object to a dma-buf is done through the
>> - * &drm_driver.gem_prime_export driver callback.
>> + * &drm_gem_object_funcs.export callback.
>> */
>> int drm_gem_prime_handle_to_fd(struct drm_device *dev,
>> struct drm_file *file_priv, uint32_t handle,
>> @@ -616,15 +612,18 @@ struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach,
>> enum dma_data_direction dir)
>> {
>> struct drm_gem_object *obj = attach->dmabuf->priv;
>> - struct sg_table *sgt;
>> + struct sg_table *sgt = NULL;
>>
>> if (WARN_ON(dir == DMA_NONE))
>> return ERR_PTR(-EINVAL);
>>
>> - if (obj->funcs)
>> + if (obj->funcs && obj->funcs->get_sg_table)
>> sgt = obj->funcs->get_sg_table(obj);
>> - else
>> - sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
>> +
>> + if (!sgt)
>> + return ERR_PTR(-EINVAL);
>> + else if (IS_ERR(sgt))
>> + return sgt;
>>
>> if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,
>> DMA_ATTR_SKIP_CPU_SYNC)) {
>> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
>> index 7116abc1a04e..8b325bf6cef4 100644
>> --- a/include/drm/drm_drv.h
>> +++ b/include/drm/drm_drv.h
>> @@ -36,10 +36,12 @@ struct drm_file;
>> struct drm_gem_object;
>> struct drm_master;
>> struct drm_minor;
>> +struct dma_buf;
>> struct dma_buf_attachment;
>> struct drm_display_mode;
>> struct drm_mode_create_dumb;
>> struct drm_printer;
>> +struct sg_table;
>>
>> /**
>> * enum drm_driver_feature - feature flags
>> @@ -327,32 +329,6 @@ struct drm_driver {
>> */
>> void (*debugfs_init)(struct drm_minor *minor);
>>
>> - /**
>> - * @gem_free_object_unlocked: deconstructor for drm_gem_objects
>> - *
>> - * This is deprecated and should not be used by new drivers. Use
>> - * &drm_gem_object_funcs.free instead.
>> - */
>> - void (*gem_free_object_unlocked) (struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_open_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.open.
>> - *
>> - * Driver hook called upon gem handle creation
>> - */
>> - int (*gem_open_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> - /**
>> - * @gem_close_object:
>> - *
>> - * This callback is deprecated in favour of &drm_gem_object_funcs.close.
>> - *
>> - * Driver hook called upon gem handle release
>> - */
>> - void (*gem_close_object) (struct drm_gem_object *, struct drm_file *);
>> -
>> /**
>> * @gem_create_object: constructor for gem objects
>> *
>> @@ -361,6 +337,7 @@ struct drm_driver {
>> */
>> struct drm_gem_object *(*gem_create_object)(struct drm_device *dev,
>> size_t size);
>> +
>> /**
>> * @prime_handle_to_fd:
>> *
>> @@ -383,14 +360,7 @@ struct drm_driver {
>> */
>> int (*prime_fd_to_handle)(struct drm_device *dev, struct drm_file *file_priv,
>> int prime_fd, uint32_t *handle);
>> - /**
>> - * @gem_prime_export:
>> - *
>> - * Export hook for GEM drivers. Deprecated in favour of
>> - * &drm_gem_object_funcs.export.
>> - */
>> - struct dma_buf * (*gem_prime_export)(struct drm_gem_object *obj,
>> - int flags);
>> +
>> /**
>> * @gem_prime_import:
>> *
>> @@ -400,29 +370,6 @@ struct drm_driver {
>> */
>> struct drm_gem_object * (*gem_prime_import)(struct drm_device *dev,
>> struct dma_buf *dma_buf);
>> -
>> - /**
>> - * @gem_prime_pin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.pin.
>> - */
>> - int (*gem_prime_pin)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_unpin:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.unpin.
>> - */
>> - void (*gem_prime_unpin)(struct drm_gem_object *obj);
>> -
>> -
>> - /**
>> - * @gem_prime_get_sg_table:
>> - *
>> - * Deprecated hook in favour of &drm_gem_object_funcs.get_sg_table.
>> - */
>> - struct sg_table *(*gem_prime_get_sg_table)(struct drm_gem_object *obj);
>> -
>> /**
>> * @gem_prime_import_sg_table:
>> *
>> @@ -433,22 +380,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> struct dma_buf_attachment *attach,
>> struct sg_table *sgt);
>> - /**
>> - * @gem_prime_vmap:
>> - *
>> - * Deprecated vmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vmap instead.
>> - */
>> - void *(*gem_prime_vmap)(struct drm_gem_object *obj);
>> -
>> - /**
>> - * @gem_prime_vunmap:
>> - *
>> - * Deprecated vunmap hook for GEM drivers. Please use
>> - * &drm_gem_object_funcs.vunmap instead.
>> - */
>> - void (*gem_prime_vunmap)(struct drm_gem_object *obj, void *vaddr);
>> -
>> /**
>> * @gem_prime_mmap:
>> *
>> @@ -523,14 +454,6 @@ struct drm_driver {
>> struct drm_device *dev,
>> uint32_t handle);
>>
>> - /**
>> - * @gem_vm_ops: Driver private ops for this object
>> - *
>> - * For GEM drivers this is deprecated in favour of
>> - * &drm_gem_object_funcs.vm_ops.
>> - */
>> - const struct vm_operations_struct *gem_vm_ops;
>> -
>> /** @major: driver major number */
>> int major;
>> /** @minor: driver minor number */
>> --
>> 2.28.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread
* Re: [Intel-gfx] [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
2020-08-13 8:36 ` Thomas Zimmermann
` (5 preceding siblings ...)
(?)
@ 2020-08-13 12:45 ` kernel test robot
-1 siblings, 0 replies; 243+ messages in thread
From: kernel test robot @ 2020-08-13 12:45 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4850 bytes --]
Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on next-20200813]
[cannot apply to drm-intel/for-linux-next linux-arm/drm-armada-devel linux-arm/drm-armada-fixes v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Convert-all-remaining-drivers-to-GEM-object-functions/20200813-163944
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dc06fe51d26efc100ac74121607c01a454867c91
config: arc-allmodconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/arm/malidp_planes.c: In function 'malidp_check_pages_threshold':
>> drivers/gpu/drm/arm/malidp_planes.c:349:28: error: 'struct drm_driver' has no member named 'gem_prime_get_sg_table'; did you mean 'gem_prime_import_sg_table'?
349 | sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
| ^~~~~~~~~~~~~~~~~~~~~~
| gem_prime_import_sg_table
vim +349 drivers/gpu/drm/arm/malidp_planes.c
1f23a56a46b81d Jamie Fox 2018-10-01 325
1f23a56a46b81d Jamie Fox 2018-10-01 326 /*
1f23a56a46b81d Jamie Fox 2018-10-01 327 * Check if the framebuffer is entirely made up of pages at least pgsize in
1f23a56a46b81d Jamie Fox 2018-10-01 328 * size. Only a heuristic: assumes that each scatterlist entry has been aligned
1f23a56a46b81d Jamie Fox 2018-10-01 329 * to the largest page size smaller than its length and that the MMU maps to
1f23a56a46b81d Jamie Fox 2018-10-01 330 * the largest page size possible.
1f23a56a46b81d Jamie Fox 2018-10-01 331 */
1f23a56a46b81d Jamie Fox 2018-10-01 332 static bool malidp_check_pages_threshold(struct malidp_plane_state *ms,
1f23a56a46b81d Jamie Fox 2018-10-01 333 u32 pgsize)
1f23a56a46b81d Jamie Fox 2018-10-01 334 {
1f23a56a46b81d Jamie Fox 2018-10-01 335 int i;
1f23a56a46b81d Jamie Fox 2018-10-01 336
1f23a56a46b81d Jamie Fox 2018-10-01 337 for (i = 0; i < ms->n_planes; i++) {
1f23a56a46b81d Jamie Fox 2018-10-01 338 struct drm_gem_object *obj;
1f23a56a46b81d Jamie Fox 2018-10-01 339 struct drm_gem_cma_object *cma_obj;
1f23a56a46b81d Jamie Fox 2018-10-01 340 struct sg_table *sgt;
1f23a56a46b81d Jamie Fox 2018-10-01 341 struct scatterlist *sgl;
1f23a56a46b81d Jamie Fox 2018-10-01 342
1f23a56a46b81d Jamie Fox 2018-10-01 343 obj = drm_gem_fb_get_obj(ms->base.fb, i);
1f23a56a46b81d Jamie Fox 2018-10-01 344 cma_obj = to_drm_gem_cma_obj(obj);
1f23a56a46b81d Jamie Fox 2018-10-01 345
1f23a56a46b81d Jamie Fox 2018-10-01 346 if (cma_obj->sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 347 sgt = cma_obj->sgt;
1f23a56a46b81d Jamie Fox 2018-10-01 348 else
1f23a56a46b81d Jamie Fox 2018-10-01 @349 sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
1f23a56a46b81d Jamie Fox 2018-10-01 350
1f23a56a46b81d Jamie Fox 2018-10-01 351 if (!sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 352 return false;
1f23a56a46b81d Jamie Fox 2018-10-01 353
1f23a56a46b81d Jamie Fox 2018-10-01 354 sgl = sgt->sgl;
1f23a56a46b81d Jamie Fox 2018-10-01 355
1f23a56a46b81d Jamie Fox 2018-10-01 356 while (sgl) {
1f23a56a46b81d Jamie Fox 2018-10-01 357 if (sgl->length < pgsize) {
1f23a56a46b81d Jamie Fox 2018-10-01 358 if (!cma_obj->sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 359 kfree(sgt);
1f23a56a46b81d Jamie Fox 2018-10-01 360 return false;
1f23a56a46b81d Jamie Fox 2018-10-01 361 }
1f23a56a46b81d Jamie Fox 2018-10-01 362
1f23a56a46b81d Jamie Fox 2018-10-01 363 sgl = sg_next(sgl);
1f23a56a46b81d Jamie Fox 2018-10-01 364 }
1f23a56a46b81d Jamie Fox 2018-10-01 365 if (!cma_obj->sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 366 kfree(sgt);
1f23a56a46b81d Jamie Fox 2018-10-01 367 }
1f23a56a46b81d Jamie Fox 2018-10-01 368
1f23a56a46b81d Jamie Fox 2018-10-01 369 return true;
1f23a56a46b81d Jamie Fox 2018-10-01 370 }
1f23a56a46b81d Jamie Fox 2018-10-01 371
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65058 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread* Re: [Intel-gfx] [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
2020-08-13 8:36 ` Thomas Zimmermann
` (6 preceding siblings ...)
(?)
@ 2020-08-13 15:41 ` kernel test robot
-1 siblings, 0 replies; 243+ messages in thread
From: kernel test robot @ 2020-08-13 15:41 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3744 bytes --]
Hi Thomas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on next-20200813]
[cannot apply to drm-intel/for-linux-next linux-arm/drm-armada-devel linux-arm/drm-armada-fixes anholt/for-next v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Convert-all-remaining-drivers-to-GEM-object-functions/20200813-163944
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dc06fe51d26efc100ac74121607c01a454867c91
config: i386-randconfig-m021-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/gpu/drm/drm_prime.c:389 export_and_register_object() error: uninitialized symbol 'dmabuf'.
Old smatch warnings:
drivers/gpu/drm/drm_prime.c:359 drm_gem_prime_fd_to_handle() warn: inconsistent returns 'dev->object_name_lock'.
vim +/dmabuf +389 drivers/gpu/drm/drm_prime.c
89177644a7b6306 Aaron Plattner 2013-01-15 374
319c933c71f3dbd Daniel Vetter 2013-08-15 375 static struct dma_buf *export_and_register_object(struct drm_device *dev,
319c933c71f3dbd Daniel Vetter 2013-08-15 376 struct drm_gem_object *obj,
319c933c71f3dbd Daniel Vetter 2013-08-15 377 uint32_t flags)
319c933c71f3dbd Daniel Vetter 2013-08-15 378 {
319c933c71f3dbd Daniel Vetter 2013-08-15 379 struct dma_buf *dmabuf;
319c933c71f3dbd Daniel Vetter 2013-08-15 380
319c933c71f3dbd Daniel Vetter 2013-08-15 381 /* prevent races with concurrent gem_close. */
319c933c71f3dbd Daniel Vetter 2013-08-15 382 if (obj->handle_count == 0) {
319c933c71f3dbd Daniel Vetter 2013-08-15 383 dmabuf = ERR_PTR(-ENOENT);
319c933c71f3dbd Daniel Vetter 2013-08-15 384 return dmabuf;
319c933c71f3dbd Daniel Vetter 2013-08-15 385 }
319c933c71f3dbd Daniel Vetter 2013-08-15 386
b39b5394fabc79a Noralf Trønnes 2018-11-10 387 if (obj->funcs && obj->funcs->export)
b39b5394fabc79a Noralf Trønnes 2018-11-10 388 dmabuf = obj->funcs->export(obj, flags);
319c933c71f3dbd Daniel Vetter 2013-08-15 @389 if (IS_ERR(dmabuf)) {
319c933c71f3dbd Daniel Vetter 2013-08-15 390 /* normally the created dma-buf takes ownership of the ref,
319c933c71f3dbd Daniel Vetter 2013-08-15 391 * but if that fails then drop the ref
319c933c71f3dbd Daniel Vetter 2013-08-15 392 */
319c933c71f3dbd Daniel Vetter 2013-08-15 393 return dmabuf;
319c933c71f3dbd Daniel Vetter 2013-08-15 394 }
319c933c71f3dbd Daniel Vetter 2013-08-15 395
319c933c71f3dbd Daniel Vetter 2013-08-15 396 /*
319c933c71f3dbd Daniel Vetter 2013-08-15 397 * Note that callers do not need to clean up the export cache
319c933c71f3dbd Daniel Vetter 2013-08-15 398 * since the check for obj->handle_count guarantees that someone
319c933c71f3dbd Daniel Vetter 2013-08-15 399 * will clean it up.
319c933c71f3dbd Daniel Vetter 2013-08-15 400 */
319c933c71f3dbd Daniel Vetter 2013-08-15 401 obj->dma_buf = dmabuf;
319c933c71f3dbd Daniel Vetter 2013-08-15 402 get_dma_buf(obj->dma_buf);
319c933c71f3dbd Daniel Vetter 2013-08-15 403
319c933c71f3dbd Daniel Vetter 2013-08-15 404 return dmabuf;
319c933c71f3dbd Daniel Vetter 2013-08-15 405 }
319c933c71f3dbd Daniel Vetter 2013-08-15 406
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30687 bytes --]
^ permalink raw reply [flat|nested] 243+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Convert all remaining drivers to GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (24 preceding siblings ...)
(?)
@ 2020-08-13 9:30 ` Patchwork
-1 siblings, 0 replies; 243+ messages in thread
From: Patchwork @ 2020-08-13 9:30 UTC (permalink / raw)
To: Thomas Zimmermann; +Cc: intel-gfx
== Series Details ==
Series: Convert all remaining drivers to GEM object functions
URL : https://patchwork.freedesktop.org/series/80593/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3432354b0aba drm/amdgpu: Introduce GEM object functions
a6636204e871 drm/armada: Introduce GEM object functions
419237bb45ec drm/etnaviv: Introduce GEM object functions
5ac6227c35a6 drm/exynos: Introduce GEM object functions
bece754b7d5e drm/gma500: Introduce GEM object functions
975a7cc97edf drm/i915: Introduce GEM object functions
8f9c261ff43a drm/mediatek: Introduce GEM object functions
8901932a7d0b drm/msm: Introduce GEM object funcs
8e0a96b9b934 drm/nouveau: Introduce GEM object functions
6db00555b27f drm/omapdrm: Introduce GEM object functions
9f951cff95de drm/pl111: Introduce GEM object functions
d35bbda1b7a0 drm/radeon: Introduce GEM object functions
-:85: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#85: FILE: drivers/gpu/drm/radeon/radeon_object.c:48:
+void radeon_gem_object_free(struct drm_gem_object *obj);
-:86: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#86: FILE: drivers/gpu/drm/radeon/radeon_object.c:49:
+int radeon_gem_object_open(struct drm_gem_object *obj,
-:87: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#87: FILE: drivers/gpu/drm/radeon/radeon_object.c:50:
+int radeon_gem_object_open(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
-:88: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#88: FILE: drivers/gpu/drm/radeon/radeon_object.c:51:
+void radeon_gem_object_close(struct drm_gem_object *obj,
-:89: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#89: FILE: drivers/gpu/drm/radeon/radeon_object.c:52:
+void radeon_gem_object_close(struct drm_gem_object *obj,
+ struct drm_file *file_priv);
-:93: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#93: FILE: drivers/gpu/drm/radeon/radeon_object.c:56:
+int radeon_gem_prime_pin(struct drm_gem_object *obj);
-:94: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#94: FILE: drivers/gpu/drm/radeon/radeon_object.c:57:
+void radeon_gem_prime_unpin(struct drm_gem_object *obj);
-:96: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#96: FILE: drivers/gpu/drm/radeon/radeon_object.c:59:
+void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
total: 0 errors, 6 warnings, 2 checks, 101 lines checked
67f82bee99a9 drm/rockchip: Convert to drm_gem_object_funcs
dabc081c2725 drm/tegra: Introduce GEM object functions
082439f00666 drm/vc4: Introduce GEM object functions
fff50ea99db8 drm/vgem: Introduce GEM object functions
700a27560ff8 drm/vkms: Introduce GEM object functions
e7063ad8ca7d drm/xen: Introduce GEM object functions
57a3d52d4eaf drm/xlnx: Initialize DRM driver instance with CMA helper macro
f887ba13ff85 drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for Convert all remaining drivers to GEM object functions
2020-08-13 8:36 ` Thomas Zimmermann
` (25 preceding siblings ...)
(?)
@ 2020-08-13 9:47 ` Patchwork
-1 siblings, 0 replies; 243+ messages in thread
From: Patchwork @ 2020-08-13 9:47 UTC (permalink / raw)
To: Thomas Zimmermann; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18684 bytes --]
== Series Details ==
Series: Convert all remaining drivers to GEM object functions
URL : https://patchwork.freedesktop.org/series/80593/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8880 -> Patchwork_18353
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18353 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18353, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18353:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_fence@basic-busy@rcs0:
- fi-blb-e6850: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-blb-e6850/igt@gem_exec_fence@basic-busy@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-blb-e6850/igt@gem_exec_fence@basic-busy@rcs0.html
- fi-pnv-d510: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-pnv-d510/igt@gem_exec_fence@basic-busy@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-pnv-d510/igt@gem_exec_fence@basic-busy@rcs0.html
* igt@gem_exec_fence@basic-busy@vcs0:
- fi-ivb-3770: [PASS][5] -> [DMESG-WARN][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-ivb-3770/igt@gem_exec_fence@basic-busy@vcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-ivb-3770/igt@gem_exec_fence@basic-busy@vcs0.html
- fi-elk-e7500: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-elk-e7500/igt@gem_exec_fence@basic-busy@vcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-elk-e7500/igt@gem_exec_fence@basic-busy@vcs0.html
- fi-ilk-650: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-ilk-650/igt@gem_exec_fence@basic-busy@vcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-ilk-650/igt@gem_exec_fence@basic-busy@vcs0.html
- fi-byt-j1900: [PASS][11] -> [DMESG-WARN][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-byt-j1900/igt@gem_exec_fence@basic-busy@vcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-byt-j1900/igt@gem_exec_fence@basic-busy@vcs0.html
* igt@gem_exec_fence@basic-busy@vecs0:
- fi-hsw-4770: [PASS][13] -> [DMESG-WARN][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-hsw-4770/igt@gem_exec_fence@basic-busy@vecs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-hsw-4770/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-cml-u2: [PASS][15] -> [DMESG-WARN][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-cml-u2/igt@gem_exec_fence@basic-busy@vecs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cml-u2/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-skl-6700k2: [PASS][17] -> [DMESG-WARN][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-skl-6700k2/igt@gem_exec_fence@basic-busy@vecs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-6700k2/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-cfl-8700k: [PASS][19] -> [DMESG-WARN][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-cfl-8700k/igt@gem_exec_fence@basic-busy@vecs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cfl-8700k/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-tgl-u2: [PASS][21] -> [DMESG-WARN][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-tgl-u2/igt@gem_exec_fence@basic-busy@vecs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-tgl-u2/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bsw-n3050: [PASS][23] -> [DMESG-WARN][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-bsw-n3050/igt@gem_exec_fence@basic-busy@vecs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bsw-n3050/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-skl-lmem: [PASS][25] -> [DMESG-WARN][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-skl-lmem/igt@gem_exec_fence@basic-busy@vecs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-lmem/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-soraka: [PASS][27] -> [DMESG-WARN][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@vecs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-cml-s: [PASS][29] -> [DMESG-WARN][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-cml-s/igt@gem_exec_fence@basic-busy@vecs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cml-s/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-x1275: [PASS][31] -> [DMESG-WARN][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-kbl-x1275/igt@gem_exec_fence@basic-busy@vecs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-x1275/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bsw-kefka: [PASS][33] -> [DMESG-WARN][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-bsw-kefka/igt@gem_exec_fence@basic-busy@vecs0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bsw-kefka/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-r: [PASS][35] -> [DMESG-WARN][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-kbl-r/igt@gem_exec_fence@basic-busy@vecs0.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-r/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-cfl-8109u: [PASS][37] -> [DMESG-WARN][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-cfl-8109u/igt@gem_exec_fence@basic-busy@vecs0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cfl-8109u/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-icl-y: [PASS][39] -> [DMESG-WARN][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-icl-y/igt@gem_exec_fence@basic-busy@vecs0.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-icl-y/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-guc: [PASS][41] -> [DMESG-WARN][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-kbl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bsw-nick: [PASS][43] -> [DMESG-WARN][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-bsw-nick/igt@gem_exec_fence@basic-busy@vecs0.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bsw-nick/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bdw-gvtdvm: [PASS][45] -> [DMESG-WARN][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-bdw-gvtdvm/igt@gem_exec_fence@basic-busy@vecs0.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bdw-gvtdvm/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bdw-5557u: [PASS][47] -> [DMESG-WARN][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-bdw-5557u/igt@gem_exec_fence@basic-busy@vecs0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bdw-5557u/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-7500u: [PASS][49] -> [DMESG-WARN][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-kbl-7500u/igt@gem_exec_fence@basic-busy@vecs0.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-7500u/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-skl-6600u: [PASS][51] -> [DMESG-WARN][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-skl-6600u/igt@gem_exec_fence@basic-busy@vecs0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-6600u/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-skl-guc: [PASS][53] -> [DMESG-WARN][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-skl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
* igt@runner@aborted:
- fi-ilk-650: NOTRUN -> [FAIL][55]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-ilk-650/igt@runner@aborted.html
- fi-pnv-d510: NOTRUN -> [FAIL][56]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-pnv-d510/igt@runner@aborted.html
- fi-kbl-x1275: NOTRUN -> [FAIL][57]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-x1275/igt@runner@aborted.html
- fi-bsw-kefka: NOTRUN -> [FAIL][58]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bsw-kefka/igt@runner@aborted.html
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][59]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bdw-gvtdvm/igt@runner@aborted.html
- fi-cfl-8700k: NOTRUN -> [FAIL][60]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cfl-8700k/igt@runner@aborted.html
- fi-skl-6600u: NOTRUN -> [FAIL][61]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-6600u/igt@runner@aborted.html
- fi-cfl-8109u: NOTRUN -> [FAIL][62]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cfl-8109u/igt@runner@aborted.html
- fi-bsw-nick: NOTRUN -> [FAIL][63]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bsw-nick/igt@runner@aborted.html
- fi-snb-2520m: NOTRUN -> [FAIL][64]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-snb-2520m/igt@runner@aborted.html
- fi-skl-lmem: NOTRUN -> [FAIL][65]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-lmem/igt@runner@aborted.html
- fi-kbl-r: NOTRUN -> [FAIL][66]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-r/igt@runner@aborted.html
- fi-bdw-5557u: NOTRUN -> [FAIL][67]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bdw-5557u/igt@runner@aborted.html
- fi-bwr-2160: NOTRUN -> [FAIL][68]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bwr-2160/igt@runner@aborted.html
- fi-kbl-soraka: NOTRUN -> [FAIL][69]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-soraka/igt@runner@aborted.html
- fi-hsw-4770: NOTRUN -> [FAIL][70]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-hsw-4770/igt@runner@aborted.html
- fi-kbl-7500u: NOTRUN -> [FAIL][71]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-7500u/igt@runner@aborted.html
- fi-kbl-guc: NOTRUN -> [FAIL][72]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-guc/igt@runner@aborted.html
- fi-snb-2600: NOTRUN -> [FAIL][73]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-snb-2600/igt@runner@aborted.html
- fi-cml-u2: NOTRUN -> [FAIL][74]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cml-u2/igt@runner@aborted.html
- fi-ivb-3770: NOTRUN -> [FAIL][75]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-ivb-3770/igt@runner@aborted.html
- fi-byt-j1900: NOTRUN -> [FAIL][76]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-byt-j1900/igt@runner@aborted.html
- fi-elk-e7500: NOTRUN -> [FAIL][77]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-elk-e7500/igt@runner@aborted.html
- fi-cml-s: NOTRUN -> [FAIL][78]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-cml-s/igt@runner@aborted.html
- fi-icl-y: NOTRUN -> [FAIL][79]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-icl-y/igt@runner@aborted.html
- fi-skl-guc: NOTRUN -> [FAIL][80]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-guc/igt@runner@aborted.html
- fi-skl-6700k2: NOTRUN -> [FAIL][81]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-skl-6700k2/igt@runner@aborted.html
- fi-bsw-n3050: NOTRUN -> [FAIL][82]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bsw-n3050/igt@runner@aborted.html
- fi-blb-e6850: NOTRUN -> [FAIL][83]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-blb-e6850/igt@runner@aborted.html
#### Warnings ####
* igt@runner@aborted:
- fi-tgl-u2: [FAIL][84] ([i915#1233] / [i915#2110]) -> [FAIL][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-tgl-u2/igt@runner@aborted.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-tgl-u2/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_fence@basic-busy@vecs0:
- {fi-ehl-1}: [PASS][86] -> [DMESG-WARN][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-ehl-1/igt@gem_exec_fence@basic-busy@vecs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-ehl-1/igt@gem_exec_fence@basic-busy@vecs0.html
- {fi-tgl-dsi}: [PASS][88] -> [DMESG-WARN][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-tgl-dsi/igt@gem_exec_fence@basic-busy@vecs0.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-tgl-dsi/igt@gem_exec_fence@basic-busy@vecs0.html
- {fi-kbl-7560u}: [PASS][90] -> [DMESG-WARN][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-kbl-7560u/igt@gem_exec_fence@basic-busy@vecs0.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-7560u/igt@gem_exec_fence@basic-busy@vecs0.html
* igt@runner@aborted:
- {fi-tgl-dsi}: NOTRUN -> [FAIL][92]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-tgl-dsi/igt@runner@aborted.html
- {fi-ehl-1}: NOTRUN -> [FAIL][93]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-ehl-1/igt@runner@aborted.html
- {fi-kbl-7560u}: NOTRUN -> [FAIL][94]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-7560u/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_18353 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@vecs0:
- fi-apl-guc: [PASS][95] -> [DMESG-WARN][96] ([i915#1635])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-apl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-apl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bxt-dsi: [PASS][97] -> [DMESG-WARN][98] ([i915#1635])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-bxt-dsi/igt@gem_exec_fence@basic-busy@vecs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-bxt-dsi/igt@gem_exec_fence@basic-busy@vecs0.html
#### Warnings ####
* igt@debugfs_test@read_all_entries:
- fi-kbl-x1275: [DMESG-WARN][99] ([i915#62] / [i915#92]) -> [DMESG-WARN][100] ([i915#62] / [i915#92] / [i915#95])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8880/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1233]: https://gitlab.freedesktop.org/drm/intel/issues/1233
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (44 -> 37)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8880 -> Patchwork_18353
CI-20190529: 20190529
CI_DRM_8880: 105bb2602f98f6acb503ad62a5b6a86e1f454ca5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18353: f887ba13ff85dd6c3bfa8fff2b06fb5562bdcbe7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f887ba13ff85 drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
57a3d52d4eaf drm/xlnx: Initialize DRM driver instance with CMA helper macro
e7063ad8ca7d drm/xen: Introduce GEM object functions
700a27560ff8 drm/vkms: Introduce GEM object functions
fff50ea99db8 drm/vgem: Introduce GEM object functions
082439f00666 drm/vc4: Introduce GEM object functions
dabc081c2725 drm/tegra: Introduce GEM object functions
67f82bee99a9 drm/rockchip: Convert to drm_gem_object_funcs
d35bbda1b7a0 drm/radeon: Introduce GEM object functions
9f951cff95de drm/pl111: Introduce GEM object functions
6db00555b27f drm/omapdrm: Introduce GEM object functions
8e0a96b9b934 drm/nouveau: Introduce GEM object functions
8901932a7d0b drm/msm: Introduce GEM object funcs
8f9c261ff43a drm/mediatek: Introduce GEM object functions
975a7cc97edf drm/i915: Introduce GEM object functions
bece754b7d5e drm/gma500: Introduce GEM object functions
5ac6227c35a6 drm/exynos: Introduce GEM object functions
419237bb45ec drm/etnaviv: Introduce GEM object functions
a6636204e871 drm/armada: Introduce GEM object functions
3432354b0aba drm/amdgpu: Introduce GEM object functions
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18353/index.html
[-- Attachment #1.2: Type: text/html, Size: 20691 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 243+ messages in thread