From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 2/3] syscalls/msgrcv07: Add different msgtyp test
Date: Thu, 13 Aug 2020 16:11:04 +0200 [thread overview]
Message-ID: <20200813141104.GE13292@yuki.lan> (raw)
In-Reply-To: <1595230227-21468-3-git-send-email-xuyang2018.jy@cn.fujitsu.com>
Hi!
> diff --git a/testcases/kernel/syscalls/ipc/msgrcv/msgrcv07.c b/testcases/kernel/syscalls/ipc/msgrcv/msgrcv07.c
> index 39fbdb67a..9b04fd2ac 100644
> --- a/testcases/kernel/syscalls/ipc/msgrcv/msgrcv07.c
> +++ b/testcases/kernel/syscalls/ipc/msgrcv/msgrcv07.c
> @@ -3,7 +3,8 @@
> * Copyright (c) 2014-2020 Fujitsu Ltd.
> * Author: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
> *
> - * Basic test for msgrcv(2) using MSG_EXCEPT, MSG_NOERROR
> + * Basic test for msgrcv(2) using MSG_EXCEPT, MSG_NOERROR and different
> + * msg_typ(zero,positive,negative).
> */
>
> #define _GNU_SOURCE
> @@ -22,15 +23,20 @@ static int queue_id = -1;
> static struct buf {
> long type;
> char mtext[MSGSIZE];
> -} rcv_buf, snd_buf[2] = {
> +} rcv_buf, snd_buf[3] = {
> {MSGTYPE1, MSG1},
> - {MSGTYPE2, MSG2}
> + {MSGTYPE2, MSG2},
> };
This is a bit useless change.
> static void test_msg_except(void);
> static void test_msg_noerror(void);
> +static void test_zero_msgtyp(void);
> +static void test_positive_msgtyp(void);
> +static void test_negative_msgtyp(void);
> static void cleanup(void);
> -static void (*testfunc[])(void) = {test_msg_except, test_msg_noerror};
> +static void (*testfunc[])(void) = {test_msg_except, test_msg_noerror,
> + test_zero_msgtyp, test_positive_msgtyp,
> + test_negative_msgtyp};
>
> static void verify_msgcrv(unsigned int n)
> {
> @@ -81,6 +87,73 @@ static void test_msg_noerror(void)
> SAFE_MSGCTL(queue_id, IPC_RMID, NULL);
> }
>
> +static void test_zero_msgtyp(void)
> +{
> + queue_id = SAFE_MSGGET(msgkey, IPC_CREAT | IPC_EXCL | MSG_RW);
> + SAFE_MSGSND(queue_id, &snd_buf[0], MSGSIZE, 0);
> + SAFE_MSGSND(queue_id, &snd_buf[1], MSGSIZE, 0);
> + memset(&rcv_buf, 0, sizeof(rcv_buf));
This init is common for all of these tests, I guess that it would be
easier to put this piece of code into a function called prepare_queue()
so that we do not have to repeat it all over.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-08-13 14:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 7:30 [LTP] [PATCH v1 0/3] increase msgrcv coverage Yang Xu
2020-07-20 7:30 ` [LTP] [PATCH v1 1/3] syscalls/msgrcv: Add check for msg_lrpid and msg_rtime Yang Xu
2020-08-13 12:53 ` Cyril Hrubis
2020-07-20 7:30 ` [LTP] [PATCH v1 2/3] syscalls/msgrcv07: Add different msgtyp test Yang Xu
2020-08-13 14:11 ` Cyril Hrubis [this message]
2020-08-13 15:21 ` [LTP] [PATCH v2] " Yang Xu
2020-08-14 12:27 ` Cyril Hrubis
2020-07-20 7:30 ` [LTP] [PATCH v1 3/3] syscalls/msgrcv09: Add error test for MSG_COPY flag Yang Xu
2020-08-13 14:19 ` Cyril Hrubis
2020-08-13 14:43 ` Yang Xu
2020-08-13 15:25 ` Cyril Hrubis
2020-08-14 5:37 ` Yang Xu
2020-08-18 3:43 ` [LTP] [PATCH v2] syscalls/msgrcv03: " Yang Xu
2020-08-24 6:40 ` Yang Xu
2020-09-04 3:47 ` Yang Xu
2020-09-08 13:03 ` Cyril Hrubis
2020-07-20 7:38 ` [LTP] [PATCH v1 0/3] increase msgrcv coverage Yang Xu
2020-08-13 14:16 ` Cyril Hrubis
2020-08-13 15:22 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813141104.GE13292@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.