From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 3/3] syscalls/msgrcv09: Add error test for MSG_COPY flag
Date: Thu, 13 Aug 2020 17:25:36 +0200 [thread overview]
Message-ID: <20200813152536.GH13292@yuki.lan> (raw)
In-Reply-To: <e304a375-2d99-a083-bd7c-2cb6fe2ed314@cn.fujitsu.com>
Hi!
> >> +static struct tst_test test = {
> >> + .needs_tmpdir = 1,
> >> + .needs_root = 1,
> >> + .needs_kconfigs = (const char *[]) {
> >> + "CONFIG_CHECKPOINT_RESTORE",
> >> + NULL
> >> + },
> >> + .min_kver = "3.8.0",
> >> + .tcnt = ARRAY_SIZE(tcases),
> >> + .test = verify_msgrcv,
> >> + .setup = setup,
> >> + .cleanup = cleanup,
> >> +};
> >
> > Do we need both min_kver and CONFIG_CHECKPOINT_RESTORE? Wouldn't be
> > CONFIG_CHECKPOINT_RESTORE enough?
> I think we need both because the CONFIG_CHECKPOINT_RESTORE macro was not
> introduced since 3.8. Before 3.8, we can enable this config but the
> kernel does not support this MSG_COPY FLAG.
> also using "CONFIG_CHECKPOINT_RESTORE=y" is better.
Ah, makes sense. I wonder if this worth a comment in the top level
test description.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-08-13 15:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 7:30 [LTP] [PATCH v1 0/3] increase msgrcv coverage Yang Xu
2020-07-20 7:30 ` [LTP] [PATCH v1 1/3] syscalls/msgrcv: Add check for msg_lrpid and msg_rtime Yang Xu
2020-08-13 12:53 ` Cyril Hrubis
2020-07-20 7:30 ` [LTP] [PATCH v1 2/3] syscalls/msgrcv07: Add different msgtyp test Yang Xu
2020-08-13 14:11 ` Cyril Hrubis
2020-08-13 15:21 ` [LTP] [PATCH v2] " Yang Xu
2020-08-14 12:27 ` Cyril Hrubis
2020-07-20 7:30 ` [LTP] [PATCH v1 3/3] syscalls/msgrcv09: Add error test for MSG_COPY flag Yang Xu
2020-08-13 14:19 ` Cyril Hrubis
2020-08-13 14:43 ` Yang Xu
2020-08-13 15:25 ` Cyril Hrubis [this message]
2020-08-14 5:37 ` Yang Xu
2020-08-18 3:43 ` [LTP] [PATCH v2] syscalls/msgrcv03: " Yang Xu
2020-08-24 6:40 ` Yang Xu
2020-09-04 3:47 ` Yang Xu
2020-09-08 13:03 ` Cyril Hrubis
2020-07-20 7:38 ` [LTP] [PATCH v1 0/3] increase msgrcv coverage Yang Xu
2020-08-13 14:16 ` Cyril Hrubis
2020-08-13 15:22 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813152536.GH13292@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.