[PATCH] ASoC: codecs: wm0010: use DECLARE_COMPLETION_ONSTACK() macro

[PATCH] ASoC: codecs: wm0010: use DECLARE_COMPLETION_ONSTACK() macro

[Pierre-Louis Bossart]

Follow recommendation in Documentation/scheduler/completion.rst and
use macro to declare local 'struct completion'

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/wm0010.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 2f2b2f5d55e4..28b4656c4e14 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -346,7 +346,7 @@ static int wm0010_firmware_load(const char *name, struct snd_soc_component *comp
 	struct list_head xfer_list;
 	struct wm0010_boot_xfer *xfer;
 	int ret;
-	struct completion done;
+	DECLARE_COMPLETION_ONSTACK(done);
 	const struct firmware *fw;
 	const struct dfw_binrec *rec;
 	const struct dfw_inforec *inforec;
@@ -370,7 +370,6 @@ static int wm0010_firmware_load(const char *name, struct snd_soc_component *comp
 	wm0010->boot_failed = false;
 	if (WARN_ON(!list_empty(&xfer_list)))
 		return -EINVAL;
-	init_completion(&done);
 
 	/* First record should be INFO */
 	if (rec->command != DFW_CMD_INFO) {
-- 
2.25.1

Re: [PATCH] ASoC: codecs: wm0010: use DECLARE_COMPLETION_ONSTACK() macro

[Charles Keepax]

On Thu, Aug 13, 2020 at 12:54:42PM -0500, Pierre-Louis Bossart wrote:
> Follow recommendation in Documentation/scheduler/completion.rst and
> use macro to declare local 'struct completion'
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: [PATCH] ASoC: codecs: wm0010: use DECLARE_COMPLETION_ONSTACK() macro

[Mark Brown]

On Thu, 13 Aug 2020 12:54:42 -0500, Pierre-Louis Bossart wrote:
> Follow recommendation in Documentation/scheduler/completion.rst and
> use macro to declare local 'struct completion'

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: wm0010: use DECLARE_COMPLETION_ONSTACK() macro
      commit: 093513b8ed12d3f074c846cfae5ca4e34f3b37f4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark