All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 5/5] ASoC: Intel: sof_sdw: clarify operator precedence
Date: Thu, 13 Aug 2020 12:58:39 -0500	[thread overview]
Message-ID: <20200813175839.59422-6-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200813175839.59422-1-pierre-louis.bossart@linux.intel.com>

Fix cppcheck warning:

sound/soc/intel/boards/sof_sdw.c:739:46: style: Clarify calculation
precedence for '&' and '?'. [clarifyCalculation]
 hdmi_num = sof_sdw_quirk & SOF_SDW_TGL_HDMI ?
                                             ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/sof_sdw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index 2463d432bf4d..baff9e99f626 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -728,7 +728,7 @@ static int sof_card_dai_links_create(struct device *dev,
 	for (i = 0; i < ARRAY_SIZE(codec_info_list); i++)
 		codec_info_list[i].amp_num = 0;
 
-	hdmi_num = sof_sdw_quirk & SOF_SDW_TGL_HDMI ?
+	hdmi_num = (sof_sdw_quirk & SOF_SDW_TGL_HDMI) ?
 				SOF_TGL_HDMI_COUNT : SOF_PRE_TGL_HDMI_COUNT;
 
 	ssp_mask = SOF_SSP_GET_PORT(sof_sdw_quirk);
-- 
2.25.1


  parent reply	other threads:[~2020-08-13 18:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 17:58 [PATCH 0/5] ASoC: SOF/Intel: fix cppcheck warnings Pierre-Louis Bossart
2020-08-13 17:58 ` [PATCH 1/5] ASOC: SOF: Intel: hda-codec: move unused label to correct position Pierre-Louis Bossart
2020-08-23  3:48   ` Nathan Chancellor
2020-08-24 14:17     ` Pierre-Louis Bossart
2020-08-13 17:58 ` [PATCH 2/5] ASoC: SOF: Intel: hda-codec: move variable used conditionally Pierre-Louis Bossart
2020-08-13 17:58 ` [PATCH 3/5] ASoC: Intel: rename shadowed variable for all broadwell boards Pierre-Louis Bossart
2020-08-13 17:58 ` [PATCH 4/5] ASoC: Intel: bytcht_cx2072x: simplify return handling Pierre-Louis Bossart
2020-08-13 17:58 ` Pierre-Louis Bossart [this message]
2020-08-13 18:45   ` [PATCH 5/5] ASoC: Intel: sof_sdw: clarify operator precedence Mark Brown
2020-08-13 19:43     ` Pierre-Louis Bossart
2020-08-13 19:49       ` Mark Brown
2020-08-13 19:57         ` Pierre-Louis Bossart
2020-08-18 16:54 ` [PATCH 0/5] ASoC: SOF/Intel: fix cppcheck warnings Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813175839.59422-6-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.