* [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set
@ 2020-08-11 14:40 Biju Das
2020-08-12 19:24 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Biju Das @ 2020-08-11 14:40 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
commit 528d06d41b80a4acb2a9efd33bfc87495147f75e upstream.
The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
the stub is declared in drm_of.h without a static inline. This causes
multiple definitions of the function to be linked when the CONFIG_OF
option isn't set. Fix it by making the stub static inline.
Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191219103703.8547-1-laurent.pinchart+renesas@ideasonboard.com
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reported-by: kernel test robot <lkp@intel.com>
---
include/drm/drm_of.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h
index 8ec7ca6d2369..b9b093add92e 100644
--- a/include/drm/drm_of.h
+++ b/include/drm/drm_of.h
@@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const struct device_node *np,
return -EINVAL;
}
-int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1,
- const struct device_node *port2)
+static inline int
+drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1,
+ const struct device_node *port2)
{
return -EINVAL;
}
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5109): https://lists.cip-project.org/g/cip-dev/message/5109
Mute This Topic: https://lists.cip-project.org/mt/76127518/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set
2020-08-11 14:40 [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set Biju Das
@ 2020-08-12 19:24 ` Pavel Machek
2020-08-13 6:39 ` Biju Das
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2020-08-12 19:24 UTC (permalink / raw)
To: Biju Das
Cc: cip-dev, Nobuhiro Iwamatsu, Pavel Machek, Chris Paterson,
Prabhakar Mahadev Lad
[-- Attachment #1.1: Type: text/plain, Size: 1306 bytes --]
Hi!
I assume this patch is for 4.19-cip?
> commit 528d06d41b80a4acb2a9efd33bfc87495147f75e upstream.
>
> The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
> commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
> the stub is declared in drm_of.h without a static inline. This causes
> multiple definitions of the function to be linked when the CONFIG_OF
> option isn't set. Fix it by making the stub static inline.
So this is pretty obvious, and I'll likely apply it.
Best regards,
Pavel
> diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h
> index 8ec7ca6d2369..b9b093add92e 100644
> --- a/include/drm/drm_of.h
> +++ b/include/drm/drm_of.h
> @@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const struct device_node *np,
> return -EINVAL;
> }
>
> -int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1,
> - const struct device_node *port2)
> +static inline int
> +drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1,
> + const struct device_node *port2)
> {
> return -EINVAL;
> }
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5110): https://lists.cip-project.org/g/cip-dev/message/5110
Mute This Topic: https://lists.cip-project.org/mt/76127518/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set
2020-08-12 19:24 ` Pavel Machek
@ 2020-08-13 6:39 ` Biju Das
2020-08-13 20:48 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Biju Das @ 2020-08-13 6:39 UTC (permalink / raw)
To: Pavel Machek
Cc: cip-dev, Nobuhiro Iwamatsu, Chris Paterson, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]
Hi Pavel,
Thanks for the feedback.
> Subject: Re: [PATCH] drm: of: Fix linking when CONFIG_OF is not set
>
> Hi!
>
> I assume this patch is for 4.19-cip?
Yes, it is for 4.19-cip.
> > commit 528d06d41b80a4acb2a9efd33bfc87495147f75e upstream.
> >
> > The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
> > commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
> > the stub is declared in drm_of.h without a static inline. This causes
> > multiple definitions of the function to be linked when the CONFIG_OF
> > option isn't set. Fix it by making the stub static inline.
>
> So this is pretty obvious, and I'll likely apply it.
Thanks for applying it.
Regards,
Biju
>
> Best regards,
> Pavel
>
>
> > diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index
> > 8ec7ca6d2369..b9b093add92e 100644
> > --- a/include/drm/drm_of.h
> > +++ b/include/drm/drm_of.h
> > @@ -92,8 +92,9 @@ static inline int drm_of_find_panel_or_bridge(const
> struct device_node *np,
> > return -EINVAL;
> > }
> >
> > -int drm_of_lvds_get_dual_link_pixel_order(const struct device_node
> *port1,
> > - const struct device_node *port2)
> > +static inline int
> > +drm_of_lvds_get_dual_link_pixel_order(const struct device_node
> *port1,
> > + const struct device_node *port2)
> > {
> > return -EINVAL;
> > }
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5115): https://lists.cip-project.org/g/cip-dev/message/5115
Mute This Topic: https://lists.cip-project.org/mt/76127518/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set
2020-08-13 6:39 ` Biju Das
@ 2020-08-13 20:48 ` Pavel Machek
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2020-08-13 20:48 UTC (permalink / raw)
To: Biju Das
Cc: Pavel Machek, cip-dev, Nobuhiro Iwamatsu, Chris Paterson,
Prabhakar Mahadev Lad
[-- Attachment #1.1: Type: text/plain, Size: 979 bytes --]
On Thu 2020-08-13 06:39:55, Biju Das wrote:
> Hi Pavel,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH] drm: of: Fix linking when CONFIG_OF is not set
> >
> > Hi!
> >
> > I assume this patch is for 4.19-cip?
>
> Yes, it is for 4.19-cip.
>
> > > commit 528d06d41b80a4acb2a9efd33bfc87495147f75e upstream.
> > >
> > > The new helper drm_of_lvds_get_dual_link_pixel_order() introduced in
> > > commit 6529007522de has a fallback stub when CONFIG_OF is not set, but
> > > the stub is declared in drm_of.h without a static inline. This causes
> > > multiple definitions of the function to be linked when the CONFIG_OF
> > > option isn't set. Fix it by making the stub static inline.
> >
> > So this is pretty obvious, and I'll likely apply it.
>
> Thanks for applying it.
Applied.
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5121): https://lists.cip-project.org/g/cip-dev/message/5121
Mute This Topic: https://lists.cip-project.org/mt/76127518/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-13 20:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-11 14:40 [cip-dev] [PATCH] drm: of: Fix linking when CONFIG_OF is not set Biju Das
2020-08-12 19:24 ` Pavel Machek
2020-08-13 6:39 ` Biju Das
2020-08-13 20:48 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.