* [PATCH] drm/amd/powerplay: suppress the kernel test robot warning
@ 2020-08-14 4:21 Evan Quan
2020-08-14 4:53 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Evan Quan @ 2020-08-14 4:21 UTC (permalink / raw)
To: amd-gfx; +Cc: alexander.deucher, Evan Quan, kernel test robot
Suppress the warning below:
In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/smu_cmn.c:
>> drivers/gpu/drm/amd/powerplay/smu_cmn.c:485:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_cmn.c:477:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/smu_cmn.c:485:9: note: second condition
return ret;
^
Change-Id: I4b512008b8fe410fc7974e0483c39206ebec08ca
Signed-off-by: Evan Quan <evan.quan@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/gpu/drm/amd/powerplay/smu_cmn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smu_cmn.c b/drivers/gpu/drm/amd/powerplay/smu_cmn.c
index 968b734baac0..a58ea08cd115 100644
--- a/drivers/gpu/drm/amd/powerplay/smu_cmn.c
+++ b/drivers/gpu/drm/amd/powerplay/smu_cmn.c
@@ -604,7 +604,7 @@ int smu_cmn_update_table(struct smu_context *smu,
memcpy(table_data, table->cpu_addr, table_size);
}
- return ret;
+ return 0;
}
int smu_cmn_write_watermarks_table(struct smu_context *smu)
--
2.28.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/powerplay: suppress the kernel test robot warning
2020-08-14 4:21 [PATCH] drm/amd/powerplay: suppress the kernel test robot warning Evan Quan
@ 2020-08-14 4:53 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-08-14 4:53 UTC (permalink / raw)
To: Evan Quan; +Cc: Deucher, Alexander, kernel test robot, amd-gfx list
On Fri, Aug 14, 2020 at 12:22 AM Evan Quan <evan.quan@amd.com> wrote:
>
> Suppress the warning below:
> In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/smu_cmn.c:
> >> drivers/gpu/drm/amd/powerplay/smu_cmn.c:485:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
> return ret;
> ^
> drivers/gpu/drm/amd/powerplay/smu_cmn.c:477:6: note: first condition
> if (ret)
> ^
> drivers/gpu/drm/amd/powerplay/smu_cmn.c:485:9: note: second condition
> return ret;
> ^
>
> Change-Id: I4b512008b8fe410fc7974e0483c39206ebec08ca
> Signed-off-by: Evan Quan <evan.quan@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/smu_cmn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_cmn.c b/drivers/gpu/drm/amd/powerplay/smu_cmn.c
> index 968b734baac0..a58ea08cd115 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_cmn.c
> @@ -604,7 +604,7 @@ int smu_cmn_update_table(struct smu_context *smu,
> memcpy(table_data, table->cpu_addr, table_size);
> }
>
> - return ret;
> + return 0;
> }
>
> int smu_cmn_write_watermarks_table(struct smu_context *smu)
> --
> 2.28.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-14 4:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 4:21 [PATCH] drm/amd/powerplay: suppress the kernel test robot warning Evan Quan
2020-08-14 4:53 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.