From: Stephan Gerhold <stephan@gerhold.net>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
tiwai@suse.com, john.stultz@linaro.org
Subject: Re: [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
Date: Fri, 14 Aug 2020 19:43:32 +0200 [thread overview]
Message-ID: <20200814174332.GA314820@gerhold.net> (raw)
In-Reply-To: <20200811103452.20448-1-srinivas.kandagatla@linaro.org>
On Tue, Aug 11, 2020 at 11:34:52AM +0100, Srinivas Kandagatla wrote:
> For some reason interrupt set and clear register offsets are
> not set correctly.
> This patch corrects them!
>
> Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 4428c62e25cf..3ddd822240e3 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -19,8 +19,8 @@
>
> #define CDC_D_REVISION1 (0xf000)
> #define CDC_D_PERPH_SUBTYPE (0xf005)
> -#define CDC_D_INT_EN_SET (0x015)
> -#define CDC_D_INT_EN_CLR (0x016)
> +#define CDC_D_INT_EN_SET (0xf015)
> +#define CDC_D_INT_EN_CLR (0xf016)
> #define MBHC_SWITCH_INT BIT(7)
> #define MBHC_MIC_ELECTRICAL_INS_REM_DET BIT(6)
> #define MBHC_BUTTON_PRESS_DET BIT(5)
> --
> 2.21.0
>
It's surprising that we didn't notice this before. Seems like the HW
has exactly the IRQs we want enabled by default. Everything seems to be
still working fine after this patch, so FWIW:
Tested-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Thanks!
Stephan
WARNING: multiple messages have this Message-ID (diff)
From: Stephan Gerhold <stephan@gerhold.net>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, broonie@kernel.org,
john.stultz@linaro.org
Subject: Re: [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset
Date: Fri, 14 Aug 2020 19:43:32 +0200 [thread overview]
Message-ID: <20200814174332.GA314820@gerhold.net> (raw)
In-Reply-To: <20200811103452.20448-1-srinivas.kandagatla@linaro.org>
On Tue, Aug 11, 2020 at 11:34:52AM +0100, Srinivas Kandagatla wrote:
> For some reason interrupt set and clear register offsets are
> not set correctly.
> This patch corrects them!
>
> Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index 4428c62e25cf..3ddd822240e3 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -19,8 +19,8 @@
>
> #define CDC_D_REVISION1 (0xf000)
> #define CDC_D_PERPH_SUBTYPE (0xf005)
> -#define CDC_D_INT_EN_SET (0x015)
> -#define CDC_D_INT_EN_CLR (0x016)
> +#define CDC_D_INT_EN_SET (0xf015)
> +#define CDC_D_INT_EN_CLR (0xf016)
> #define MBHC_SWITCH_INT BIT(7)
> #define MBHC_MIC_ELECTRICAL_INS_REM_DET BIT(6)
> #define MBHC_BUTTON_PRESS_DET BIT(5)
> --
> 2.21.0
>
It's surprising that we didn't notice this before. Seems like the HW
has exactly the IRQs we want enabled by default. Everything seems to be
still working fine after this patch, so FWIW:
Tested-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Thanks!
Stephan
next prev parent reply other threads:[~2020-08-14 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 10:34 [PATCH] ASoC: msm8916-wcd-analog: fix register Interrupt offset Srinivas Kandagatla
2020-08-11 10:34 ` Srinivas Kandagatla
2020-08-14 17:43 ` Stephan Gerhold [this message]
2020-08-14 17:43 ` Stephan Gerhold
2020-08-18 16:54 ` Mark Brown
2020-08-18 16:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814174332.GA314820@gerhold.net \
--to=stephan@gerhold.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=john.stultz@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.