Re: [PATCH 7/8] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock

From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, "Marek Vasut" <marex@denx.de>,
	devicetree@vger.kernel.org, "Guido Günther" <agx@sigxcpu.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/8] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock
Date: Sun, 16 Aug 2020 09:28:58 +0200	[thread overview]
Message-ID: <20200816072858.GH1201814@ravnborg.org> (raw)
In-Reply-To: <20200813012910.13576-8-laurent.pinchart@ideasonboard.com>

On Thu, Aug 13, 2020 at 04:29:09AM +0300, Laurent Pinchart wrote:
> The LCDIF disp_axi clock is not mandatory in the DT binding and not
> required by the driver. Remove it when it points to a dummy clock.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  arch/arm/boot/dts/imx6sl.dtsi  | 5 ++---
>  arch/arm/boot/dts/imx6sll.dtsi | 5 ++---
>  arch/arm/boot/dts/imx6ul.dtsi  | 5 ++---
>  3 files changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index deeb647ffc3f..a4d74216c9f4 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -773,9 +773,8 @@ lcdif: lcdif@20f8000 {
>  				reg = <0x020f8000 0x4000>;
>  				interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
> -					 <&clks IMX6SL_CLK_LCDIF_AXI>,
> -					 <&clks IMX6SL_CLK_DUMMY>;
> -				clock-names = "pix", "axi", "disp_axi";
> +					 <&clks IMX6SL_CLK_LCDIF_AXI>;
> +				clock-names = "pix", "axi";
>  				status = "disabled";
>  				power-domains = <&pd_disp>;
>  			};
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index c51072bb43ba..55775318559b 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -648,9 +648,8 @@ lcdif: lcd-controller@20f8000 {
>  				reg = <0x020f8000 0x4000>;
>  				interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>,
> -					 <&clks IMX6SLL_CLK_LCDIF_APB>,
> -					 <&clks IMX6SLL_CLK_DUMMY>;
> -				clock-names = "pix", "axi", "disp_axi";
> +					 <&clks IMX6SLL_CLK_LCDIF_APB>;
> +				clock-names = "pix", "axi";
>  				status = "disabled";
>  			};
>  
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index b16cce1680a9..35df39cc85a4 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -982,9 +982,8 @@ lcdif: lcdif@21c8000 {
>  				reg = <0x021c8000 0x4000>;
>  				interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6UL_CLK_LCDIF_PIX>,
> -					 <&clks IMX6UL_CLK_LCDIF_APB>,
> -					 <&clks IMX6UL_CLK_DUMMY>;
> -				clock-names = "pix", "axi", "disp_axi";
> +					 <&clks IMX6UL_CLK_LCDIF_APB>;
> +				clock-names = "pix", "axi";
>  				status = "disabled";
>  			};
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel