* [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed
@ 2020-08-15 21:57 Fabrice Fontaine
2020-08-15 22:11 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2020-08-15 21:57 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692c
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/mpv/mpv.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/mpv/mpv.mk b/package/mpv/mpv.mk
index 8619de5a8e..6801a0468f 100644
--- a/package/mpv/mpv.mk
+++ b/package/mpv/mpv.mk
@@ -235,4 +235,8 @@ else
MPV_CONF_OPTS += --disable-x11
endif
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+MPV_CONF_ENV += LDFLAGS="$(TARGET_LDFLAGS) -latomic"
+endif
+
$(eval $(waf-package))
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed
2020-08-15 21:57 [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed Fabrice Fontaine
@ 2020-08-15 22:11 ` Thomas Petazzoni
2020-08-16 8:05 ` Fabrice Fontaine
2020-08-16 9:28 ` Thomas Petazzoni
2020-08-28 16:43 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-08-15 22:11 UTC (permalink / raw)
To: buildroot
On Sat, 15 Aug 2020 23:57:30 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Thanks! I was also looking (briefly) at this build issue. I see that mpv has:
depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8
Does RISC-V implements the sync 8-byte built-in ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed
2020-08-15 22:11 ` Thomas Petazzoni
@ 2020-08-16 8:05 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2020-08-16 8:05 UTC (permalink / raw)
To: buildroot
Le dim. 16 ao?t 2020 ? 00:11, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Sat, 15 Aug 2020 23:57:30 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Fixes:
> > - http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692c
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Thanks! I was also looking (briefly) at this build issue. I see that mpv has:
>
> depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8
>
> Does RISC-V implements the sync 8-byte built-in ?
It seems that __sync builtins have been dropped since version 0.24.0 and
https://github.com/mpv-player/mpv/commit/c3205d294e519f994829d9355eb133670729aab4
so this dependency should also be updated to reflect that atomic is mandatory.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed
2020-08-15 21:57 [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed Fabrice Fontaine
2020-08-15 22:11 ` Thomas Petazzoni
@ 2020-08-16 9:28 ` Thomas Petazzoni
2020-08-28 16:43 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-08-16 9:28 UTC (permalink / raw)
To: buildroot
On Sat, 15 Aug 2020 23:57:30 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/mpv/mpv.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed
2020-08-15 21:57 [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed Fabrice Fontaine
2020-08-15 22:11 ` Thomas Petazzoni
2020-08-16 9:28 ` Thomas Petazzoni
@ 2020-08-28 16:43 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2020-08-28 16:43 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fixes:
> - http://autobuild.buildroot.org/results/12f4580429427b6b546184366f74da16f83d692c
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.02.x and 2020.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-28 16:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-15 21:57 [Buildroot] [PATCH 1/1] package/mpv: link with libatomic if needed Fabrice Fontaine
2020-08-15 22:11 ` Thomas Petazzoni
2020-08-16 8:05 ` Fabrice Fontaine
2020-08-16 9:28 ` Thomas Petazzoni
2020-08-28 16:43 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.