* [PATCH v2 1/4] Documentation: bindings: usb: add rk3328 dwc3 docs
@ 2020-08-17 3:11 ` travelvia
0 siblings, 0 replies; 7+ messages in thread
From: travelvia @ 2020-08-17 3:11 UTC (permalink / raw)
To: robh+dt, heiko, balbi, gregkh, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-usb
Cc: Cameron Nemo
From: Cameron Nemo <cnemo@tutanota.com>
Document compatible for dwc3 on the Rockchip rk3328 platform.
Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
---
Documentation/devicetree/bindings/usb/dwc3.txt | 1 +
Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index d03edf9d3935..d625cd5966e9 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -25,6 +25,7 @@ Exception for clocks:
"ti,am437x-dwc3"
"ti,dwc3"
"ti,keystone-dwc3"
+ "rockchip,rk3328-dwc3"
"rockchip,rk3399-dwc3"
"xlnx,zynqmp-dwc3"
diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
index 94520493233b..b41f30a61be6 100644
--- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
@@ -1,7 +1,8 @@
Rockchip SuperSpeed DWC3 USB SoC controller
Required properties:
-- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC
+- compatible: should contain "rockchip,rk3328-dwc3" for rk3328 SoC
+ or "rockchip,rk3399-dwc3" for rk3399 SoC
- clocks: A list of phandle + clock-specifier pairs for the
clocks listed in clock-names
- clock-names: Should contain the following:
--
2.28.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 1/4] Documentation: bindings: usb: add rk3328 dwc3 docs
@ 2020-08-17 3:11 ` travelvia
0 siblings, 0 replies; 7+ messages in thread
From: travelvia @ 2020-08-17 3:11 UTC (permalink / raw)
To: robh+dt, heiko, balbi, gregkh, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-usb
Cc: Cameron Nemo
From: Cameron Nemo <cnemo@tutanota.com>
Document compatible for dwc3 on the Rockchip rk3328 platform.
Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
---
Documentation/devicetree/bindings/usb/dwc3.txt | 1 +
Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index d03edf9d3935..d625cd5966e9 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -25,6 +25,7 @@ Exception for clocks:
"ti,am437x-dwc3"
"ti,dwc3"
"ti,keystone-dwc3"
+ "rockchip,rk3328-dwc3"
"rockchip,rk3399-dwc3"
"xlnx,zynqmp-dwc3"
diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
index 94520493233b..b41f30a61be6 100644
--- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt
@@ -1,7 +1,8 @@
Rockchip SuperSpeed DWC3 USB SoC controller
Required properties:
-- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC
+- compatible: should contain "rockchip,rk3328-dwc3" for rk3328 SoC
+ or "rockchip,rk3399-dwc3" for rk3399 SoC
- clocks: A list of phandle + clock-specifier pairs for the
clocks listed in clock-names
- clock-names: Should contain the following:
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/4] usb: dwc3: of-simple: Add compatible for rk3328
2020-08-17 3:11 ` travelvia
@ 2020-08-17 3:11 ` travelvia
-1 siblings, 0 replies; 7+ messages in thread
From: travelvia @ 2020-08-17 3:11 UTC (permalink / raw)
To: robh+dt, heiko, balbi, gregkh, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-usb
Cc: Cameron Nemo
From: Cameron Nemo <cnemo@tutanota.com>
Add a compatible to be hooked into by the Rockchip rk3328 device tree.
The rk3399 compatible cannot be reused because the rk3328 SoCs may
require a specialized driver in the future, and old device trees must
remain compatible with newer kernels.
Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
---
drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index 7df115012935..68d6e4fa0c6a 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
* Some controllers need to toggle the usb3-otg reset before trying to
* initialize the PHY, otherwise the PHY times out.
*/
- if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
+ if (of_device_is_compatible(np, "rockchip,rk3328-dwc3") ||
+ of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
simple->need_reset = true;
simple->resets = of_reset_control_array_get(np, false, true,
@@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
};
static const struct of_device_id of_dwc3_simple_match[] = {
+ { .compatible = "rockchip,rk3328-dwc3" },
{ .compatible = "rockchip,rk3399-dwc3" },
{ .compatible = "xlnx,zynqmp-dwc3" },
{ .compatible = "cavium,octeon-7130-usb-uctl" },
--
2.28.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/4] usb: dwc3: of-simple: Add compatible for rk3328
@ 2020-08-17 3:11 ` travelvia
0 siblings, 0 replies; 7+ messages in thread
From: travelvia @ 2020-08-17 3:11 UTC (permalink / raw)
To: robh+dt, heiko, balbi, gregkh, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel, linux-usb
Cc: Cameron Nemo
From: Cameron Nemo <cnemo@tutanota.com>
Add a compatible to be hooked into by the Rockchip rk3328 device tree.
The rk3399 compatible cannot be reused because the rk3328 SoCs may
require a specialized driver in the future, and old device trees must
remain compatible with newer kernels.
Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
---
drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index 7df115012935..68d6e4fa0c6a 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
* Some controllers need to toggle the usb3-otg reset before trying to
* initialize the PHY, otherwise the PHY times out.
*/
- if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
+ if (of_device_is_compatible(np, "rockchip,rk3328-dwc3") ||
+ of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
simple->need_reset = true;
simple->resets = of_reset_control_array_get(np, false, true,
@@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
};
static const struct of_device_id of_dwc3_simple_match[] = {
+ { .compatible = "rockchip,rk3328-dwc3" },
{ .compatible = "rockchip,rk3399-dwc3" },
{ .compatible = "xlnx,zynqmp-dwc3" },
{ .compatible = "cavium,octeon-7130-usb-uctl" },
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/4] usb: dwc3: of-simple: Add compatible for rk3328
2020-08-17 3:11 ` travelvia
(?)
@ 2020-08-18 14:53 ` Robin Murphy
-1 siblings, 0 replies; 7+ messages in thread
From: Robin Murphy @ 2020-08-18 14:53 UTC (permalink / raw)
To: travelvia, robh+dt, heiko, balbi, gregkh, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-usb
Cc: Cameron Nemo
On 2020-08-17 04:11, travelvia@airmail.cc wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
>
> Add a compatible to be hooked into by the Rockchip rk3328 device tree.
>
> The rk3399 compatible cannot be reused because the rk3328 SoCs may
> require a specialized driver in the future, and old device trees must
> remain compatible with newer kernels.
>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 7df115012935..68d6e4fa0c6a 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> * Some controllers need to toggle the usb3-otg reset before trying to
> * initialize the PHY, otherwise the PHY times out.
> */
> - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> + if (of_device_is_compatible(np, "rockchip,rk3328-dwc3") ||
Is this necessary? Even downstream there's no reset control in the DT,
so I can't see that it achieves anything.
Robin.
> + of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> simple->need_reset = true;
>
> simple->resets = of_reset_control_array_get(np, false, true,
> @@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
> };
>
> static const struct of_device_id of_dwc3_simple_match[] = {
> + { .compatible = "rockchip,rk3328-dwc3" },
> { .compatible = "rockchip,rk3399-dwc3" },
> { .compatible = "xlnx,zynqmp-dwc3" },
> { .compatible = "cavium,octeon-7130-usb-uctl" },
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/4] usb: dwc3: of-simple: Add compatible for rk3328
@ 2020-08-18 14:53 ` Robin Murphy
0 siblings, 0 replies; 7+ messages in thread
From: Robin Murphy @ 2020-08-18 14:53 UTC (permalink / raw)
To: travelvia, robh+dt, heiko, balbi, gregkh, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-usb
Cc: Cameron Nemo
On 2020-08-17 04:11, travelvia@airmail.cc wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
>
> Add a compatible to be hooked into by the Rockchip rk3328 device tree.
>
> The rk3399 compatible cannot be reused because the rk3328 SoCs may
> require a specialized driver in the future, and old device trees must
> remain compatible with newer kernels.
>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 7df115012935..68d6e4fa0c6a 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> * Some controllers need to toggle the usb3-otg reset before trying to
> * initialize the PHY, otherwise the PHY times out.
> */
> - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> + if (of_device_is_compatible(np, "rockchip,rk3328-dwc3") ||
Is this necessary? Even downstream there's no reset control in the DT,
so I can't see that it achieves anything.
Robin.
> + of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> simple->need_reset = true;
>
> simple->resets = of_reset_control_array_get(np, false, true,
> @@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
> };
>
> static const struct of_device_id of_dwc3_simple_match[] = {
> + { .compatible = "rockchip,rk3328-dwc3" },
> { .compatible = "rockchip,rk3399-dwc3" },
> { .compatible = "xlnx,zynqmp-dwc3" },
> { .compatible = "cavium,octeon-7130-usb-uctl" },
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/4] usb: dwc3: of-simple: Add compatible for rk3328
@ 2020-08-18 14:53 ` Robin Murphy
0 siblings, 0 replies; 7+ messages in thread
From: Robin Murphy @ 2020-08-18 14:53 UTC (permalink / raw)
To: travelvia, robh+dt, heiko, balbi, gregkh, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, linux-usb
Cc: Cameron Nemo
On 2020-08-17 04:11, travelvia@airmail.cc wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
>
> Add a compatible to be hooked into by the Rockchip rk3328 device tree.
>
> The rk3399 compatible cannot be reused because the rk3328 SoCs may
> require a specialized driver in the future, and old device trees must
> remain compatible with newer kernels.
>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 7df115012935..68d6e4fa0c6a 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> * Some controllers need to toggle the usb3-otg reset before trying to
> * initialize the PHY, otherwise the PHY times out.
> */
> - if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> + if (of_device_is_compatible(np, "rockchip,rk3328-dwc3") ||
Is this necessary? Even downstream there's no reset control in the DT,
so I can't see that it achieves anything.
Robin.
> + of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> simple->need_reset = true;
>
> simple->resets = of_reset_control_array_get(np, false, true,
> @@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
> };
>
> static const struct of_device_id of_dwc3_simple_match[] = {
> + { .compatible = "rockchip,rk3328-dwc3" },
> { .compatible = "rockchip,rk3399-dwc3" },
> { .compatible = "xlnx,zynqmp-dwc3" },
> { .compatible = "cavium,octeon-7130-usb-uctl" },
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-18 14:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 3:11 [PATCH v2 1/4] Documentation: bindings: usb: add rk3328 dwc3 docs travelvia
2020-08-17 3:11 ` travelvia
2020-08-17 3:11 ` [PATCH v2 2/4] usb: dwc3: of-simple: Add compatible for rk3328 travelvia
2020-08-17 3:11 ` travelvia
2020-08-18 14:53 ` Robin Murphy
2020-08-18 14:53 ` Robin Murphy
2020-08-18 14:53 ` Robin Murphy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.