* [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel
@ 2020-07-14 5:11 Steffen Trumtrar
2020-07-14 5:11 ` [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device Steffen Trumtrar
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Steffen Trumtrar @ 2020-07-14 5:11 UTC (permalink / raw)
To: Shawn Guo, Rob Herring
Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team
Add clock source init for the second ethernet port.
This changes the clock direction and clock selection in a way that the
ethernet phy reference clock is routed as an output.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
arch/arm/mach-imx/mach-imx7d.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-imx/mach-imx7d.c b/arch/arm/mach-imx/mach-imx7d.c
index 879c35929a13..7a203f660721 100644
--- a/arch/arm/mach-imx/mach-imx7d.c
+++ b/arch/arm/mach-imx/mach-imx7d.c
@@ -65,6 +65,9 @@ static void __init imx7d_enet_clk_sel(void)
if (!IS_ERR(gpr)) {
regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_TX_CLK_SEL_MASK, 0);
regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_CLK_DIR_MASK, 0);
+ regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_TX_CLK_SEL_MASK, 0);
+ regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_CLK_DIR_MASK,
+ IMX7D_GPR1_ENET2_CLK_DIR_MASK);
} else {
pr_err("failed to find fsl,imx7d-iomux-gpr regmap\n");
}
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device 2020-07-14 5:11 [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Steffen Trumtrar @ 2020-07-14 5:11 ` Steffen Trumtrar 2020-10-26 1:58 ` Shawn Guo 2020-07-14 5:11 ` [PATCH v2 3/4] dt-bindings: Add vendor prefix for IoTmaxx GmbH Steffen Trumtrar ` (3 subsequent siblings) 4 siblings, 1 reply; 13+ messages in thread From: Steffen Trumtrar @ 2020-07-14 5:11 UTC (permalink / raw) To: Shawn Guo, Rob Herring Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team The Maxim DS2482 is an I2C to 1-wire bridge. Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 4165352a590a..7d1dc3d96257 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -107,6 +107,8 @@ properties: # 5 Bit Programmable, Pulse-Width Modulator - maxim,ds1050 # 10-bit 8 channels 300ks/s SPI ADC with temperature sensor + - maxim,ds2482 + # I2C to 1-wire bridge - maxim,max1027 # 10-bit 12 channels 300ks/s SPI ADC with temperature sensor - maxim,max1029 -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device 2020-07-14 5:11 ` [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device Steffen Trumtrar @ 2020-10-26 1:58 ` Shawn Guo 0 siblings, 0 replies; 13+ messages in thread From: Shawn Guo @ 2020-10-26 1:58 UTC (permalink / raw) To: Steffen Trumtrar, Rob Herring Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team On Tue, Jul 14, 2020 at 07:11:38AM +0200, Steffen Trumtrar wrote: > The Maxim DS2482 is an I2C to 1-wire bridge. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Hi Rob, Are you okay with this one? Shawn > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 4165352a590a..7d1dc3d96257 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -107,6 +107,8 @@ properties: > # 5 Bit Programmable, Pulse-Width Modulator > - maxim,ds1050 > # 10-bit 8 channels 300ks/s SPI ADC with temperature sensor > + - maxim,ds2482 > + # I2C to 1-wire bridge > - maxim,max1027 > # 10-bit 12 channels 300ks/s SPI ADC with temperature sensor > - maxim,max1029 > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 3/4] dt-bindings: Add vendor prefix for IoTmaxx GmbH 2020-07-14 5:11 [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Steffen Trumtrar 2020-07-14 5:11 ` [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device Steffen Trumtrar @ 2020-07-14 5:11 ` Steffen Trumtrar 2020-10-26 1:59 ` Shawn Guo 2020-07-14 5:11 ` [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway Steffen Trumtrar ` (2 subsequent siblings) 4 siblings, 1 reply; 13+ messages in thread From: Steffen Trumtrar @ 2020-07-14 5:11 UTC (permalink / raw) To: Shawn Guo, Rob Herring Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team IoTmaxx GmbH is a developer of IoT solutions. The website is https://www.iotmaxx.com/ Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 9aeab66be85f..26bffde7fe0a 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -497,6 +497,8 @@ patternProperties: description: Inverse Path "^iom,.*": description: Iomega Corporation + "^iotmaxx,.*": + description: IoTmaxx GmbH "^isee,.*": description: ISEE 2007 S.L. "^isil,.*": -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings: Add vendor prefix for IoTmaxx GmbH 2020-07-14 5:11 ` [PATCH v2 3/4] dt-bindings: Add vendor prefix for IoTmaxx GmbH Steffen Trumtrar @ 2020-10-26 1:59 ` Shawn Guo 0 siblings, 0 replies; 13+ messages in thread From: Shawn Guo @ 2020-10-26 1:59 UTC (permalink / raw) To: Steffen Trumtrar, Rob Herring Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team On Tue, Jul 14, 2020 at 07:11:39AM +0200, Steffen Trumtrar wrote: > IoTmaxx GmbH is a developer of IoT solutions. The website is > https://www.iotmaxx.com/ > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Hi Rob, Are okay with this vendor prefix addition? Shawn > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 9aeab66be85f..26bffde7fe0a 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -497,6 +497,8 @@ patternProperties: > description: Inverse Path > "^iom,.*": > description: Iomega Corporation > + "^iotmaxx,.*": > + description: IoTmaxx GmbH > "^isee,.*": > description: ISEE 2007 S.L. > "^isil,.*": > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway 2020-07-14 5:11 [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Steffen Trumtrar 2020-07-14 5:11 ` [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device Steffen Trumtrar 2020-07-14 5:11 ` [PATCH v2 3/4] dt-bindings: Add vendor prefix for IoTmaxx GmbH Steffen Trumtrar @ 2020-07-14 5:11 ` Steffen Trumtrar 2020-10-13 9:45 ` Steffen Trumtrar 2021-01-12 13:29 ` Fabio Estevam 2020-08-17 7:24 ` [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Shawn Guo 2020-10-26 1:57 ` Shawn Guo 4 siblings, 2 replies; 13+ messages in thread From: Steffen Trumtrar @ 2020-07-14 5:11 UTC (permalink / raw) To: Shawn Guo, Rob Herring Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team The GW4100 will be an i.MX7D based board from IoTMaxx. The support is almost complete apart from the pmic setup which currently can not be used because of a hardware bug. This can and will be changed once it is fixed in hardware. Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx7d-iotmaxx-gw4100.dts | 611 +++++++++++++++++++++ 2 files changed, 612 insertions(+) create mode 100644 arch/arm/boot/dts/imx7d-iotmaxx-gw4100.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index e6a1cac0bfc7..819c3811e35b 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -628,6 +628,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \ imx7d-colibri-emmc-aster.dtb \ imx7d-colibri-emmc-eval-v3.dtb \ imx7d-colibri-eval-v3.dtb \ + imx7d-iotmaxx-gw4100.dtb \ imx7d-mba7.dtb \ imx7d-meerkat96.dtb \ imx7d-nitrogen7.dtb \ diff --git a/arch/arm/boot/dts/imx7d-iotmaxx-gw4100.dts b/arch/arm/boot/dts/imx7d-iotmaxx-gw4100.dts new file mode 100644 index 000000000000..b751172d80b1 --- /dev/null +++ b/arch/arm/boot/dts/imx7d-iotmaxx-gw4100.dts @@ -0,0 +1,611 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (C) 2020 Steffen Trumtrar <s.trumtrar@pengutronix.de> +*/ + +/dts-v1/; +#include "imx7d.dtsi" + +/ { + model = "IoTMAXX i.MX7D GW4100 Gateway"; + compatible = "iotmaxx,imx7d-gw4100", "fsl,imx7d"; + + chosen { + stdout-path = &uart3; + }; + + memory { + device_type = "memory"; + reg = <0x80000000 0x40000000>; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>, + <&adc2 0>, <&adc2 1>, <&adc2 2>; + }; + + gpio-leds { + compatible = "gpio-leds"; + pinctrl-0 = <&pinctrl_leds_usr>; + pinctrl-names = "default"; + + usr1 { + label = "iotmaxx:green:usr1"; + gpios = <&gpio4 15 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "heartbeat"; + }; + + usr2 { + label = "iotmaxx:green:usr2"; + gpios = <&gpio4 14 GPIO_ACTIVE_HIGH>; + }; + }; + + reg_ldo_emmc_3v3: regulator-ldo-emmc-3v3 { + compatible = "regulator-fixed"; + regulator-name = "ldo_emmc_v3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + + reg_ldo_misc_3v3: regulator-ldo-misc-3v3 { + compatible = "regulator-fixed"; + regulator-name = "ldo_misc_v3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + + reg_dcdc_1v8: regulator-ldo-dcdc-1v8 { + compatible = "regulator-fixed"; + regulator-name = "ldo_dcdc_1v8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + reg_vadc_1v8: regulator-vadc-1v8 { + compatible = "regulator-fixed"; + regulator-name = "vadc_1v8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + /* Power for the serial converter. Needs to be enabled on boot */ + reg_5v_periph: regulator-5v-periph { + compatible = "regulator-fixed"; + regulator-name = "5v_periph"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio2 2 GPIO_ACTIVE_HIGH>; + enable-active-high; + regulator-boot-on; + }; + + /* + * There is no consumer for the GSM modem yet. Power needs to be + * enabled before &usb_hub is probed. Otherwise the Modem is never + * enumerated. + */ + reg_gsm_pwr_en_3v3: regulator-gsm-pwr-en-3v3 { + compatible = "regulator-fixed"; + regulator-name = "gsm_pwr_en_3v3"; + pinctrl-names = "default"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio2 15 GPIO_ACTIVE_HIGH>; + enable-active-high; + regulator-always-on; + }; + + reg_usb_otg1_vbus: regulator-usb-otg1-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb_otg1_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; + + reg_usb_otg2_vbus: regulator-usb-otg2-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb_otg2_vbus"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb_otg2_vbus_reg>; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; +}; + +&adc1 { + vref-supply = <®_vadc_1v8>; + status = "okay"; +}; + +&adc2 { + vref-supply = <®_vadc_1v8>; + status = "okay"; +}; + +&ecspi2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi2>; + num-chipselects = <1>; + status = "okay"; + + flash: m25p80@0 { + compatible = "sst,sst25vf512", "m25p80"; + spi-max-frequency = <20000000>; + reg = <1>; + #address-cells = <1>; + #size-cells = <1>; + + partition@1 { + reg = <0x0 0x10000>; + }; + }; +}; + +/* Expansion slot */ +&ecspi3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi3>; + num-chipselects = <1>; + status = "okay"; +}; + +&fec2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_enet2>, + <&pinctrl_mdio>, + <&pinctrl_rmii_phy>; + /* set the enet_ref_clk and enet_out with a 50MHz clock */ + assigned-clocks = <&clks IMX7D_ENET_PHY_REF_ROOT_DIV>; + assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; + assigned-clock-rates = <50000000>; + clocks = <&clks IMX7D_ENET2_IPG_ROOT_CLK>, + <&clks IMX7D_ENET_AXI_ROOT_CLK>, + <&clks IMX7D_ENET2_TIME_ROOT_CLK>, + <&clks IMX7D_PLL_ENET_MAIN_50M_CLK>, + <&clks IMX7D_ENET2_REF_ROOT_DIV>; + clock-names = "ipg", "ahb", "ptp", + "enet_clk_ref", "enet_out"; + phy-handle = <ðphy1>; + phy-mode = "rmii"; + phy-reset-gpios = <&gpio2 27 GPIO_ACTIVE_LOW>; + fsl,magic-packet; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy1: ethernet-phy@1 { + interrupt-parent = <&gpio2>; + interrupts = <25 IRQ_TYPE_LEVEL_LOW>; + clocks = <&clks IMX7D_ENET2_REF_ROOT_DIV>; + clock-names = "rmii-ref"; + reg = <1>; + }; + }; +}; + +&flexcan1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flexcan1>; + xceiver-supply = <®_5v_periph>; + status = "okay"; +}; + +&gpio1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio1>; + + gpio-line-names = "gpio1_highside", + "gpio1_lowside", "gpio1_pullup", "n_gpio1_in", "gpio2_highside", "gpio2_lowside", + "n_usb_ext_oc", "usb_ext_pwr", "", "", "", + "", "", "", "", "", + "", "", "", "", "", + "", "", "", "", "", + "", "", "", "", "", + ""; +}; + +&gpio2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio2>; + status = "okay"; + + gpio-line-names = "", + "", "5v_periph_en", "", "sim_cd1", "sim_cd2", + "", "", "", "", "", + "", "", "", "", "gsm_pwr_en_3v3", + "", "", "n_usbhub_int", "usbhub_connect", "", + "", "", "", "", "", + "", "", "", "", "n_usbhub_rst", + ""; +}; + +&gpio3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio3>; + status = "okay"; + + gpio-line-names = "", + "", "", "", "vusb_gsm_en", "", + "", "", "", "", "", + "", "", "", "", "", + "", "", "", "", "", + "", "", "", "", "sim_enable", + "", "", "", "", "", + ""; +}; + +&gpio4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio4>, + <&pinctrl_gpio4_hog>; + status = "okay"; + + gpio-line-names = "", + "", "", "", "", "", + "", "", "", "", "", + "", "n_can_term_en", "", "led_usr2", "led_usr1", + "sim_sel", "gsm_reset", "", "n_gsm_pwr_ind", "", + "", "", "", "", "", + "", "", "", "", "", + ""; + + gsm-pwr-on-off { + gpio-hog; + gpios = <18 GPIO_ACTIVE_HIGH>; + output-high; + line-name = "gsm_power_on_off"; + }; +}; + +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1>; + status = "okay"; + + 1wiremaster@18 { + compatible = "maxim,ds2482"; + reg = <0x18>; + }; +}; + +/* CTRL_I2C */ +&i2c3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3>; + status = "okay"; + + usb_hub: usb-hub@8 { + compatible = "smsc,usb3503"; + reg = <0x8>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbhub>; + initial-mode = <1>; /* HUB mode */ + reset-gpios = <&gpio2 30 GPIO_ACTIVE_LOW>; + intn-gpios = <&gpio2 18 GPIO_ACTIVE_LOW>; + connect-gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>; + clocks = <&clks IMX7D_OSC_24M_CLK>; + clock-names = "refclk"; + }; + + tpm: tpm@20 { + compatible = "infineon,slb9645tt"; + reg = <0x20>; + }; + + eeprom: eeprom@50 { + compatible = "atmel,24c01"; + vcc-supply = <®_ldo_misc_3v3>; + pagesize = <8>; + reg = <0x50>; + }; + + pcf85363: pcf85363@51 { + compatible = "nxp,pcf85363"; + reg = <0x51>; + }; +}; + +/* EXP_I2C */ +&i2c4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c4>; + status = "okay"; +}; + +&iomuxc { + pinctrl_ecspi2: ecspi2grp { + fsl,pins = < + MX7D_PAD_ECSPI2_MISO__ECSPI2_MISO 0x7c + MX7D_PAD_ECSPI2_MOSI__ECSPI2_MOSI 0x74 + MX7D_PAD_ECSPI2_SCLK__ECSPI2_SCLK 0x74 + MX7D_PAD_ECSPI2_SS0__ECSPI2_SS0 0x74 + >; + }; + + pinctrl_ecspi3: ecspi3grp { + fsl,pins = < + MX7D_PAD_SAI2_TX_SYNC__ECSPI3_MISO 0x7c /* EXP_SPI_MISO */ + MX7D_PAD_SAI2_TX_BCLK__ECSPI3_MOSI 0x74 /* EXP_SPI_MOSI */ + MX7D_PAD_SAI2_RX_DATA__ECSPI3_SCLK 0x74 /* EXP_SPI_CLK */ + MX7D_PAD_SAI2_TX_DATA__ECSPI3_SS0 0x74 /* EXP_SPI_CS */ + >; + }; + + pinctrl_enet2: enet2grp { + fsl,pins = < + MX7D_PAD_EPDC_SDCE0__ENET2_RGMII_RX_CTL 0x5 /* ENET2_CRS_DV */ + MX7D_PAD_EPDC_SDCE1__ENET2_RX_ER 0x5 /* ENET2_RXER */ + MX7D_PAD_EPDC_SDCE2__ENET2_RGMII_TD0 0x5 /* ENET2_TXD0 */ + MX7D_PAD_EPDC_SDCE3__ENET2_RGMII_TD1 0x5 /* ENET2_TXD1 */ + MX7D_PAD_EPDC_SDCLK__ENET2_RGMII_RD0 0x5 /* ENET2_RXD0 */ + MX7D_PAD_EPDC_SDLE__ENET2_RGMII_RD1 0x5 /* ENET2_RXD1 */ + MX7D_PAD_EPDC_GDCLK__GPIO2_IO24 0x5 /* ENET2_B-CAST_OFF */ + MX7D_PAD_EPDC_GDRL__ENET2_RGMII_TX_CTL 0x5 /* ENET2_TXEN */ + MX7D_PAD_EPDC_BDR0__CCM_ENET_REF_CLK2 0x40000001 /* ENET2_TX_CLK */ + >; + }; + + pinctrl_flexcan1: flexcan1grp { + fsl,pins = < + MX7D_PAD_GPIO1_IO12__FLEXCAN1_RX 0x5a + MX7D_PAD_GPIO1_IO13__FLEXCAN1_TX 0x52 + >; + }; + + pinctrl_gpio2: gpio2grp { + fsl,pins = < + MX7D_PAD_EPDC_DATA02__GPIO2_IO2 0x14 /* 5V_PERIPH_EN */ + MX7D_PAD_EPDC_DATA15__GPIO2_IO15 0x14 /* GSM_PWR_EN_3V3 */ + MX7D_PAD_EPDC_DATA04__GPIO2_IO4 0x14 /* SIM_CD1 */ + MX7D_PAD_EPDC_DATA05__GPIO2_IO5 0x14 /* SIM_CD2 */ + >; + }; + + pinctrl_gpio3: gpio3grp { + fsl,pins = < + MX7D_PAD_LCD_RESET__GPIO3_IO4 0x79 /* VUSB_GSM_EN */ + MX7D_PAD_LCD_DATA20__GPIO3_IO25 0x14 /* SIM_ENABLE */ + >; + }; + + pinctrl_gpio4: gpio4grp { + fsl,pins = < + MX7D_PAD_ECSPI1_SS0__GPIO4_IO19 0x59 /* !GSM_PWR_IND */ + MX7D_PAD_ECSPI1_SCLK__GPIO4_IO16 0x59 /* SIM_SEL */ + MX7D_PAD_I2C3_SCL__GPIO4_IO12 0x59 /* !CAN_TERM_EN */ + MX7D_PAD_ECSPI1_MOSI__GPIO4_IO17 0x03 /* GSM_RST */ + >; + }; + + pinctrl_gpio4_hog: gpio4hoggrp { + fsl,pins = < + MX7D_PAD_ECSPI1_MISO__GPIO4_IO18 0x73 /* GSM_POWER_ON_OFF */ + >; + }; + + pinctrl_i2c1: i2c1grp { + fsl,pins = < + MX7D_PAD_UART1_RX_DATA__I2C1_SCL 0x40000078 + MX7D_PAD_UART1_TX_DATA__I2C1_SDA 0x40000078 + >; + }; + + pinctrl_i2c3: i2c3grp { + fsl,pins = < + MX7D_PAD_ENET1_RGMII_RD1__I2C3_SDA 0x40000078 + MX7D_PAD_ENET1_RGMII_RD0__I2C3_SCL 0x40000078 + >; + }; + + pinctrl_i2c4: i2c4grp { + fsl,pins = < + MX7D_PAD_ENET1_RGMII_TD3__I2C4_SDA 0x40000078 + MX7D_PAD_ENET1_RGMII_TD2__I2C4_SCL 0x40000078 + >; + }; + + pinctrl_leds_usr: ledsusrgrp { + fsl,pins = < + MX7D_PAD_I2C4_SDA__GPIO4_IO15 0x51 /* LED USR1 */ + MX7D_PAD_I2C4_SCL__GPIO4_IO14 0x51 /* LED USR2 */ + >; + }; + + pinctrl_mdio: mdiogrp { + fsl,pins = < + MX7D_PAD_UART2_RX_DATA__ENET2_MDIO 0x3 /* ENET_MDIO */ + MX7D_PAD_UART2_TX_DATA__ENET2_MDC 0x3 /* ENET_MDC */ + >; + }; + + pinctrl_rmii_phy: phygrp { + fsl,pins = < + MX7D_PAD_EPDC_GDSP__GPIO2_IO27 0x59 /* !ENET2_RST */ + MX7D_PAD_EPDC_GDOE__GPIO2_IO25 0x59 /* !ENET2_INT */ + >; + }; + + pinctrl_uart3: uart3grp { + fsl,pins = < + MX7D_PAD_UART3_RX_DATA__UART3_DCE_RX 0x79 + MX7D_PAD_UART3_TX_DATA__UART3_DCE_TX 0x79 + MX7D_PAD_UART3_RTS_B__UART3_DCE_RTS 0x79 + MX7D_PAD_UART3_CTS_B__UART3_DCE_CTS 0x79 + >; + }; + + pinctrl_uart4: uart4grp { + fsl,pins = < + MX7D_PAD_I2C1_SCL__GPIO4_IO8 0x79 /* RS485_DE */ + MX7D_PAD_I2C2_SCL__UART4_DCE_RX 0x79 /* RS485_R */ + MX7D_PAD_I2C2_SDA__UART4_DCE_TX 0x79 /* RS458_D */ + >; + }; + + pinctrl_usbhub: usbhubgrp { + fsl,pins = < + MX7D_PAD_EPDC_PWR_COM__GPIO2_IO30 0x59 /* !USBHUB_RST */ + MX7D_PAD_EPDC_SDOE__GPIO2_IO18 0x59 /* !USBHUB_INT */ + MX7D_PAD_EPDC_SDSHR__GPIO2_IO19 0x59 /* USBHUB_CONNECT */ + >; + }; + + pinctrl_usdhc2: usdhc2grp { + fsl,pins = < + MX7D_PAD_SD2_CMD__SD2_CMD 0x59 + MX7D_PAD_SD2_CLK__SD2_CLK 0x19 + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59 + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59 + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59 + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x59 + MX7D_PAD_SD2_CD_B__SD2_CD_B 0x59 + >; + }; + + pinctrl_usdhc3: usdhc3grp { + fsl,pins = < + MX7D_PAD_SD3_CMD__SD3_CMD 0x59 + MX7D_PAD_SD3_CLK__SD3_CLK 0x19 + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x59 + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x59 + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x59 + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x59 + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x59 + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x59 + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x59 + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x59 + MX7D_PAD_SD3_STROBE__SD3_STROBE 0x19 + >; + }; + + pinctrl_usdhc3_100mhz: usdhc3grp_100mhz { + fsl,pins = < + MX7D_PAD_SD3_CMD__SD3_CMD 0x5a + MX7D_PAD_SD3_CLK__SD3_CLK 0x1a + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x5a + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x5a + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x5a + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x5a + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x5a + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x5a + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x5a + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x5a + MX7D_PAD_SD3_STROBE__SD3_STROBE 0x1a + >; + }; + + pinctrl_usdhc3_200mhz: usdhc3grp_200mhz { + fsl,pins = < + MX7D_PAD_SD3_CMD__SD3_CMD 0x5b + MX7D_PAD_SD3_CLK__SD3_CLK 0x1b + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x5b + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x5b + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x5b + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x5b + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x5b + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x5b + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x5b + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x5b + MX7D_PAD_SD3_STROBE__SD3_STROBE 0x1b + >; + }; +}; + +&iomuxc_lpsr { + pinctrl_gpio1: gpio1grp { + fsl,pins = < + MX7D_PAD_LPSR_GPIO1_IO00__GPIO1_IO0 0x00 /* GPIO1_HIGHSIDE */ + MX7D_PAD_LPSR_GPIO1_IO01__GPIO1_IO1 0x00 /* GPIO1_LOWSIDE */ + MX7D_PAD_LPSR_GPIO1_IO02__GPIO1_IO2 0x00 /* GPIO1_PULLUP */ + MX7D_PAD_LPSR_GPIO1_IO03__GPIO1_IO3 0x00 /* GPIO1_IN */ + MX7D_PAD_LPSR_GPIO1_IO04__GPIO1_IO4 0x00 /* GPIO2_HIGHSIDE */ + MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x00 /* GPIO2_LOWSIDE */ + MX7D_PAD_LPSR_GPIO1_IO06__GPIO1_IO6 0x00 /* !USB_EXT_OC */ + >; + }; + + pinctrl_usb_otg2_vbus_reg: usbotg2vbusreggrp { + fsl,pins = < + MX7D_PAD_LPSR_GPIO1_IO07__GPIO1_IO7 0x14 /* USB_EXT_PWR */ + >; + }; +}; + +&uart3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart3>; + assigned-clocks = <&clks IMX7D_UART3_ROOT_SRC>; + assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>; + uart-has-rtscts; + status = "okay"; +}; + +/* Maxlinear SP483 RS-485 transceiver */ +&uart4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart4>; + rts-gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>; + linux,rs485-enabled-at-boot-time; + status = "okay"; +}; + +&usbphynop3 { + vcc-supply = <®_ldo_misc_3v3>; +}; + +&usbh { + disable-over-current; + status = "okay"; +}; + +&usbphynop1 { + vcc-supply = <®_usb_otg1_vbus>; +}; + +&usbotg1 { + vbus-supply = <®_ldo_misc_3v3>; + dr_mode = "otg"; + disable-over-current; + status = "okay"; +}; + +&usbphynop2 { + vcc-supply = <®_usb_otg2_vbus>; +}; + +&usbotg2 { + vbus-supply = <®_usb_otg2_vbus>; + dr_mode = "host"; + disable-over-current; + status = "okay"; +}; + +&usdhc2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc2>; + status = "okay"; +}; + +&usdhc3 { + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc3>; + pinctrl-1 = <&pinctrl_usdhc3_100mhz>; + pinctrl-2 = <&pinctrl_usdhc3_200mhz>; + assigned-clocks = <&clks IMX7D_USDHC3_ROOT_CLK>; + assigned-clock-rates = <400000000>; + bus-width = <8>; + no-sd; + no-sdio; + disable-wp; + fsl,tuning-step = <2>; + non-removable; + vmmc-supply = <®_ldo_emmc_3v3>; + vqmmc-supply = <®_dcdc_1v8>; + status = "okay"; +}; -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway 2020-07-14 5:11 ` [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway Steffen Trumtrar @ 2020-10-13 9:45 ` Steffen Trumtrar 2021-01-12 12:59 ` Steffen Trumtrar 2021-01-12 13:29 ` Fabio Estevam 1 sibling, 1 reply; 13+ messages in thread From: Steffen Trumtrar @ 2020-10-13 9:45 UTC (permalink / raw) To: Steffen Trumtrar Cc: Shawn Guo, Rob Herring, NXP Linux Team, kernel, Fabio Estevam, linux-arm-kernel Hi! Steffen Trumtrar <s.trumtrar@pengutronix.de> writes: > The GW4100 will be an i.MX7D based board from IoTMaxx. > The support is almost complete apart from the pmic setup which currently > can not be used because of a hardware bug. This can and will be changed > once it is fixed in hardware. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Is there anything I missed to have at least an initial version of the devicetree applied? Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway 2020-10-13 9:45 ` Steffen Trumtrar @ 2021-01-12 12:59 ` Steffen Trumtrar 0 siblings, 0 replies; 13+ messages in thread From: Steffen Trumtrar @ 2021-01-12 12:59 UTC (permalink / raw) To: Steffen Trumtrar Cc: Shawn Guo, Rob Herring, NXP Linux Team, kernel, Fabio Estevam, linux-arm-kernel Steffen Trumtrar <s.trumtrar@pengutronix.de> writes: > Hi! > > Steffen Trumtrar <s.trumtrar@pengutronix.de> writes: > >> The GW4100 will be an i.MX7D based board from IoTMaxx. >> The support is almost complete apart from the pmic setup which currently >> can not be used because of a hardware bug. This can and will be changed >> once it is fixed in hardware. >> >> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > Is there anything I missed to have at least an initial version of the > devicetree applied? > Gentle ping! Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway 2020-07-14 5:11 ` [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway Steffen Trumtrar 2020-10-13 9:45 ` Steffen Trumtrar @ 2021-01-12 13:29 ` Fabio Estevam 2021-01-12 15:30 ` Ahmad Fatoum 1 sibling, 1 reply; 13+ messages in thread From: Fabio Estevam @ 2021-01-12 13:29 UTC (permalink / raw) To: Steffen Trumtrar Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, Rob Herring, Shawn Guo, NXP Linux Team, Pengutronix Kernel Team Hi Steffen, On Tue, Jul 14, 2020 at 2:12 AM Steffen Trumtrar <s.trumtrar@pengutronix.de> wrote: > + memory { memory@80000000 to avoid dtc W=1 warning. > +&ecspi2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ecspi2>; > + num-chipselects = <1>; This property is not used for spi-imx. > + status = "okay"; > + > + flash: m25p80@0 { Node names should be generic: spi-flash@0 > +/* Expansion slot */ > +&ecspi3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ecspi3>; > + num-chipselects = <1>; > + status = "okay"; > +}; > + > +&fec2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet2>, > + <&pinctrl_mdio>, > + <&pinctrl_rmii_phy>; > + /* set the enet_ref_clk and enet_out with a 50MHz clock */ > + assigned-clocks = <&clks IMX7D_ENET_PHY_REF_ROOT_DIV>; > + assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; > + assigned-clock-rates = <50000000>; > + clocks = <&clks IMX7D_ENET2_IPG_ROOT_CLK>, > + <&clks IMX7D_ENET_AXI_ROOT_CLK>, > + <&clks IMX7D_ENET2_TIME_ROOT_CLK>, > + <&clks IMX7D_PLL_ENET_MAIN_50M_CLK>, > + <&clks IMX7D_ENET2_REF_ROOT_DIV>; > + clock-names = "ipg", "ahb", "ptp", > + "enet_clk_ref", "enet_out"; > + phy-handle = <ðphy1>; > + phy-mode = "rmii"; > + phy-reset-gpios = <&gpio2 27 GPIO_ACTIVE_LOW>; This property is considered obsolete. Please describe the Ethernet PHY reset inside the ethernet-phy nodes as per: Documentation/devicetree/bindings/net/ethernet-phy.yaml > + pcf85363: pcf85363@51 { rtc@51 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway 2021-01-12 13:29 ` Fabio Estevam @ 2021-01-12 15:30 ` Ahmad Fatoum 0 siblings, 0 replies; 13+ messages in thread From: Ahmad Fatoum @ 2021-01-12 15:30 UTC (permalink / raw) To: Fabio Estevam, Steffen Trumtrar Cc: Pengutronix Kernel Team, Rob Herring, Shawn Guo, NXP Linux Team, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE On 12.01.21 14:29, Fabio Estevam wrote: > Hi Steffen, > > On Tue, Jul 14, 2020 at 2:12 AM Steffen Trumtrar > <s.trumtrar@pengutronix.de> wrote: > >> + memory { > > memory@80000000 to avoid dtc W=1 warning. Or just drop it as the bootloader likely fixed it up anyway? -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel 2020-07-14 5:11 [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Steffen Trumtrar ` (2 preceding siblings ...) 2020-07-14 5:11 ` [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway Steffen Trumtrar @ 2020-08-17 7:24 ` Shawn Guo 2020-08-24 9:46 ` Steffen Trumtrar 2020-10-26 1:57 ` Shawn Guo 4 siblings, 1 reply; 13+ messages in thread From: Shawn Guo @ 2020-08-17 7:24 UTC (permalink / raw) To: Steffen Trumtrar, Fugang Duan Cc: linux-arm-kernel, Rob Herring, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team On Tue, Jul 14, 2020 at 07:11:37AM +0200, Steffen Trumtrar wrote: > Add clock source init for the second ethernet port. > This changes the clock direction and clock selection in a way that the > ethernet phy reference clock is routed as an output. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > arch/arm/mach-imx/mach-imx7d.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-imx/mach-imx7d.c b/arch/arm/mach-imx/mach-imx7d.c > index 879c35929a13..7a203f660721 100644 > --- a/arch/arm/mach-imx/mach-imx7d.c > +++ b/arch/arm/mach-imx/mach-imx7d.c > @@ -65,6 +65,9 @@ static void __init imx7d_enet_clk_sel(void) > if (!IS_ERR(gpr)) { > regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_TX_CLK_SEL_MASK, 0); > regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_CLK_DIR_MASK, 0); > + regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_TX_CLK_SEL_MASK, 0); > + regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_CLK_DIR_MASK, > + IMX7D_GPR1_ENET2_CLK_DIR_MASK); I would like to see such code get removed from machine code rather than added. Can we deal with these IOMUXC_GPR bits in some driver code? Shawn > } else { > pr_err("failed to find fsl,imx7d-iomux-gpr regmap\n"); > } > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel 2020-08-17 7:24 ` [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Shawn Guo @ 2020-08-24 9:46 ` Steffen Trumtrar 0 siblings, 0 replies; 13+ messages in thread From: Steffen Trumtrar @ 2020-08-24 9:46 UTC (permalink / raw) To: Shawn Guo Cc: Fugang Duan, Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel Hi! Shawn Guo <shawnguo@kernel.org> writes: > On Tue, Jul 14, 2020 at 07:11:37AM +0200, Steffen Trumtrar > wrote: >> Add clock source init for the second ethernet port. >> This changes the clock direction and clock selection in a way >> that the >> ethernet phy reference clock is routed as an output. >> >> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >> --- >> arch/arm/mach-imx/mach-imx7d.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm/mach-imx/mach-imx7d.c >> b/arch/arm/mach-imx/mach-imx7d.c >> index 879c35929a13..7a203f660721 100644 >> --- a/arch/arm/mach-imx/mach-imx7d.c >> +++ b/arch/arm/mach-imx/mach-imx7d.c >> @@ -65,6 +65,9 @@ static void __init imx7d_enet_clk_sel(void) >> if (!IS_ERR(gpr)) { >> regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET_TX_CLK_SEL_MASK, 0); >> regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET_CLK_DIR_MASK, 0); >> + regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET2_TX_CLK_SEL_MASK, 0); >> + regmap_update_bits(gpr, IOMUXC_GPR1, >> IMX7D_GPR1_ENET2_CLK_DIR_MASK, >> + IMX7D_GPR1_ENET2_CLK_DIR_MASK); > > I would like to see such code get removed from machine code > rather than > added. Can we deal with these IOMUXC_GPR bits in some driver > code? > My comment got lost in the v2: I know, that this is not a "good solution", but I don't know how we can handle this in a better way. Open for suggestions. Of course, putting it in the machine code is suboptimal. If anyone has a good idea where the 4 gpr1 calls should go without producing a massive complexity overhead, please share. Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel 2020-07-14 5:11 [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Steffen Trumtrar ` (3 preceding siblings ...) 2020-08-17 7:24 ` [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Shawn Guo @ 2020-10-26 1:57 ` Shawn Guo 4 siblings, 0 replies; 13+ messages in thread From: Shawn Guo @ 2020-10-26 1:57 UTC (permalink / raw) To: Steffen Trumtrar Cc: linux-arm-kernel, Rob Herring, Fabio Estevam, NXP Linux Team, Pengutronix Kernel Team On Tue, Jul 14, 2020 at 07:11:37AM +0200, Steffen Trumtrar wrote: > Add clock source init for the second ethernet port. > This changes the clock direction and clock selection in a way that the > ethernet phy reference clock is routed as an output. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > arch/arm/mach-imx/mach-imx7d.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/mach-imx/mach-imx7d.c b/arch/arm/mach-imx/mach-imx7d.c > index 879c35929a13..7a203f660721 100644 > --- a/arch/arm/mach-imx/mach-imx7d.c > +++ b/arch/arm/mach-imx/mach-imx7d.c > @@ -65,6 +65,9 @@ static void __init imx7d_enet_clk_sel(void) > if (!IS_ERR(gpr)) { > regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_TX_CLK_SEL_MASK, 0); > regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET_CLK_DIR_MASK, 0); > + regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_TX_CLK_SEL_MASK, 0); > + regmap_update_bits(gpr, IOMUXC_GPR1, IMX7D_GPR1_ENET2_CLK_DIR_MASK, > + IMX7D_GPR1_ENET2_CLK_DIR_MASK); Can this be pushed down to bootloader or moved into network driver? Shawn > } else { > pr_err("failed to find fsl,imx7d-iomux-gpr regmap\n"); > } > -- > 2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-01-12 15:32 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-14 5:11 [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Steffen Trumtrar 2020-07-14 5:11 ` [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device Steffen Trumtrar 2020-10-26 1:58 ` Shawn Guo 2020-07-14 5:11 ` [PATCH v2 3/4] dt-bindings: Add vendor prefix for IoTmaxx GmbH Steffen Trumtrar 2020-10-26 1:59 ` Shawn Guo 2020-07-14 5:11 ` [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway Steffen Trumtrar 2020-10-13 9:45 ` Steffen Trumtrar 2021-01-12 12:59 ` Steffen Trumtrar 2021-01-12 13:29 ` Fabio Estevam 2021-01-12 15:30 ` Ahmad Fatoum 2020-08-17 7:24 ` [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Shawn Guo 2020-08-24 9:46 ` Steffen Trumtrar 2020-10-26 1:57 ` Shawn Guo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.