* [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
@ 2020-08-02 12:22 ` Christophe JAILLET
0 siblings, 0 replies; 9+ messages in thread
From: Christophe JAILLET @ 2020-08-02 12:22 UTC (permalink / raw)
To: kvalo, davem, kuba, pillair
Cc: ath10k, linux-wireless, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()'.
Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch looks obvious to me, but commit 1863008369ae looks also simple.
So it is surprising that such a "typo" slipped in.
---
drivers/net/wireless/ath/ath10k/ce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c
index 294fbc1e89ab..e6e0284e4783 100644
--- a/drivers/net/wireless/ath/ath10k/ce.c
+++ b/drivers/net/wireless/ath/ath10k/ce.c
@@ -1555,7 +1555,7 @@ ath10k_ce_alloc_src_ring(struct ath10k *ar, unsigned int ce_id,
ret = ath10k_ce_alloc_shadow_base(ar, src_ring, nentries);
if (ret) {
dma_free_coherent(ar->dev,
- (nentries * sizeof(struct ce_desc_64) +
+ (nentries * sizeof(struct ce_desc) +
CE_DESC_RING_ALIGN),
src_ring->base_addr_owner_space_unaligned,
base_addr);
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
@ 2020-08-02 12:22 ` Christophe JAILLET
0 siblings, 0 replies; 9+ messages in thread
From: Christophe JAILLET @ 2020-08-02 12:22 UTC (permalink / raw)
To: kvalo, davem, kuba, pillair
Cc: linux-wireless, netdev, kernel-janitors, linux-kernel, ath10k,
Christophe JAILLET
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()'.
Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch looks obvious to me, but commit 1863008369ae looks also simple.
So it is surprising that such a "typo" slipped in.
---
drivers/net/wireless/ath/ath10k/ce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c
index 294fbc1e89ab..e6e0284e4783 100644
--- a/drivers/net/wireless/ath/ath10k/ce.c
+++ b/drivers/net/wireless/ath/ath10k/ce.c
@@ -1555,7 +1555,7 @@ ath10k_ce_alloc_src_ring(struct ath10k *ar, unsigned int ce_id,
ret = ath10k_ce_alloc_shadow_base(ar, src_ring, nentries);
if (ret) {
dma_free_coherent(ar->dev,
- (nentries * sizeof(struct ce_desc_64) +
+ (nentries * sizeof(struct ce_desc) +
CE_DESC_RING_ALIGN),
src_ring->base_addr_owner_space_unaligned,
base_addr);
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
@ 2020-08-02 12:22 ` Christophe JAILLET
0 siblings, 0 replies; 9+ messages in thread
From: Christophe JAILLET @ 2020-08-02 12:22 UTC (permalink / raw)
To: kvalo, davem, kuba, pillair
Cc: linux-wireless, netdev, kernel-janitors, linux-kernel, ath10k,
Christophe JAILLET
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()'.
Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch looks obvious to me, but commit 1863008369ae looks also simple.
So it is surprising that such a "typo" slipped in.
---
drivers/net/wireless/ath/ath10k/ce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c
index 294fbc1e89ab..e6e0284e4783 100644
--- a/drivers/net/wireless/ath/ath10k/ce.c
+++ b/drivers/net/wireless/ath/ath10k/ce.c
@@ -1555,7 +1555,7 @@ ath10k_ce_alloc_src_ring(struct ath10k *ar, unsigned int ce_id,
ret = ath10k_ce_alloc_shadow_base(ar, src_ring, nentries);
if (ret) {
dma_free_coherent(ar->dev,
- (nentries * sizeof(struct ce_desc_64) +
+ (nentries * sizeof(struct ce_desc) +
CE_DESC_RING_ALIGN),
src_ring->base_addr_owner_space_unaligned,
base_addr);
--
2.25.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
2020-08-02 12:22 ` Christophe JAILLET
(?)
@ 2020-08-06 2:57 ` Rakesh Pillai
-1 siblings, 0 replies; 9+ messages in thread
From: Rakesh Pillai @ 2020-08-06 2:57 UTC (permalink / raw)
To: 'Christophe JAILLET', kvalo, davem, kuba
Cc: ath10k, linux-wireless, netdev, linux-kernel, kernel-janitors
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, August 2, 2020 5:52 PM
> To: kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org;
> pillair@codeaurora.org
> Cc: ath10k@lists.infradead.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org; Christophe JAILLET
> <christophe.jaillet@wanadoo.fr>
> Subject: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call
in
> an error handling path
>
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()'.
>
> Fixes: 1863008369ae ("ath10k: fix shadow register implementation for
> WCN3990")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch looks obvious to me, but commit 1863008369ae looks also simple.
> So it is surprising that such a "typo" slipped in.
Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath10k/ce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/ce.c
> b/drivers/net/wireless/ath/ath10k/ce.c
> index 294fbc1e89ab..e6e0284e4783 100644
> --- a/drivers/net/wireless/ath/ath10k/ce.c
> +++ b/drivers/net/wireless/ath/ath10k/ce.c
> @@ -1555,7 +1555,7 @@ ath10k_ce_alloc_src_ring(struct ath10k *ar,
> unsigned int ce_id,
> ret = ath10k_ce_alloc_shadow_base(ar, src_ring, nentries);
> if (ret) {
> dma_free_coherent(ar->dev,
> - (nentries * sizeof(struct
> ce_desc_64) +
> + (nentries * sizeof(struct ce_desc)
+
> CE_DESC_RING_ALIGN),
> src_ring-
> >base_addr_owner_space_unaligned,
> base_addr);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
@ 2020-08-06 2:57 ` Rakesh Pillai
0 siblings, 0 replies; 9+ messages in thread
From: Rakesh Pillai @ 2020-08-06 2:57 UTC (permalink / raw)
To: 'Christophe JAILLET', kvalo, davem, kuba
Cc: netdev, kernel-janitors, linux-wireless, linux-kernel, ath10k
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, August 2, 2020 5:52 PM
> To: kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org;
> pillair@codeaurora.org
> Cc: ath10k@lists.infradead.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org; Christophe JAILLET
> <christophe.jaillet@wanadoo.fr>
> Subject: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call
in
> an error handling path
>
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()'.
>
> Fixes: 1863008369ae ("ath10k: fix shadow register implementation for
> WCN3990")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch looks obvious to me, but commit 1863008369ae looks also simple.
> So it is surprising that such a "typo" slipped in.
Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath10k/ce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/ce.c
> b/drivers/net/wireless/ath/ath10k/ce.c
> index 294fbc1e89ab..e6e0284e4783 100644
> --- a/drivers/net/wireless/ath/ath10k/ce.c
> +++ b/drivers/net/wireless/ath/ath10k/ce.c
> @@ -1555,7 +1555,7 @@ ath10k_ce_alloc_src_ring(struct ath10k *ar,
> unsigned int ce_id,
> ret = ath10k_ce_alloc_shadow_base(ar, src_ring, nentries);
> if (ret) {
> dma_free_coherent(ar->dev,
> - (nentries * sizeof(struct
> ce_desc_64) +
> + (nentries * sizeof(struct ce_desc)
+
> CE_DESC_RING_ALIGN),
> src_ring-
> >base_addr_owner_space_unaligned,
> base_addr);
> --
> 2.25.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
@ 2020-08-06 2:57 ` Rakesh Pillai
0 siblings, 0 replies; 9+ messages in thread
From: Rakesh Pillai @ 2020-08-06 2:57 UTC (permalink / raw)
To: 'Christophe JAILLET', kvalo, davem, kuba
Cc: netdev, kernel-janitors, linux-wireless, linux-kernel, ath10k
> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Sent: Sunday, August 2, 2020 5:52 PM
> To: kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org;
> pillair@codeaurora.org
> Cc: ath10k@lists.infradead.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-
> janitors@vger.kernel.org; Christophe JAILLET
> <christophe.jaillet@wanadoo.fr>
> Subject: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call
in
> an error handling path
>
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()'.
>
> Fixes: 1863008369ae ("ath10k: fix shadow register implementation for
> WCN3990")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch looks obvious to me, but commit 1863008369ae looks also simple.
> So it is surprising that such a "typo" slipped in.
Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath10k/ce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/ce.c
> b/drivers/net/wireless/ath/ath10k/ce.c
> index 294fbc1e89ab..e6e0284e4783 100644
> --- a/drivers/net/wireless/ath/ath10k/ce.c
> +++ b/drivers/net/wireless/ath/ath10k/ce.c
> @@ -1555,7 +1555,7 @@ ath10k_ce_alloc_src_ring(struct ath10k *ar,
> unsigned int ce_id,
> ret = ath10k_ce_alloc_shadow_base(ar, src_ring, nentries);
> if (ret) {
> dma_free_coherent(ar->dev,
> - (nentries * sizeof(struct
> ce_desc_64) +
> + (nentries * sizeof(struct ce_desc)
+
> CE_DESC_RING_ALIGN),
> src_ring-
> >base_addr_owner_space_unaligned,
> base_addr);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
2020-08-02 12:22 ` Christophe JAILLET
@ 2020-08-17 10:25 ` Kalle Valo
-1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2020-08-17 10:25 UTC (permalink / raw)
To: Christophe JAILLET
Cc: davem, kuba, pillair, ath10k, linux-wireless, netdev,
linux-kernel, kernel-janitors, Christophe JAILLET
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()'.
>
> Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
454530a9950b ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
--
https://patchwork.kernel.org/patch/11696383/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in
@ 2020-08-17 10:25 ` Kalle Valo
0 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2020-08-17 10:25 UTC (permalink / raw)
To: Christophe JAILLET
Cc: davem, kuba, pillair, ath10k, linux-wireless, netdev,
linux-kernel, kernel-janitors
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()'.
>
> Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
454530a9950b ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
--
https://patchwork.kernel.org/patch/11696383/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
2020-08-02 12:22 ` Christophe JAILLET
` (2 preceding siblings ...)
(?)
@ 2020-08-17 10:25 ` Kalle Valo
-1 siblings, 0 replies; 9+ messages in thread
From: Kalle Valo @ 2020-08-17 10:25 UTC (permalink / raw)
To: Christophe JAILLET
Cc: kernel-janitors, netdev, linux-wireless, linux-kernel, ath10k,
pillair, kuba, davem
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()'.
>
> Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
454530a9950b ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path
--
https://patchwork.kernel.org/patch/11696383/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-08-17 10:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 12:22 [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path Christophe JAILLET
2020-08-02 12:22 ` Christophe JAILLET
2020-08-02 12:22 ` Christophe JAILLET
2020-08-06 2:57 ` Rakesh Pillai
2020-08-06 2:57 ` Rakesh Pillai
2020-08-06 2:57 ` Rakesh Pillai
2020-08-17 10:25 ` Kalle Valo
2020-08-17 10:25 ` Kalle Valo
2020-08-17 10:25 ` [PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.