* [PATCH v2] perf sched timehist: Fix use of CPU list with summary option
@ 2020-08-17 17:09 David Ahern
2020-08-18 1:29 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2020-08-17 17:09 UTC (permalink / raw)
To: acme; +Cc: namhyung, linux-kernel, jolsa, David Ahern
Do not update thread stats or show idle summary unless CPU is in
the list of interest.
Fixes: c30d630d1bcf ("perf sched timehist: Add support for filtering on CPU")
Signed-off-by: David Ahern <dsahern@kernel.org>
---
v2
- check that cpu_list is set before checking cpu_bitmap in timehist_print_summary
tools/perf/builtin-sched.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 0c7d599fa555..e6fc297cee91 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -2584,7 +2584,8 @@ static int timehist_sched_change_event(struct perf_tool *tool,
}
if (!sched->idle_hist || thread->tid == 0) {
- timehist_update_runtime_stats(tr, t, tprev);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap))
+ timehist_update_runtime_stats(tr, t, tprev);
if (sched->idle_hist) {
struct idle_thread_runtime *itr = (void *)tr;
@@ -2857,6 +2858,9 @@ static void timehist_print_summary(struct perf_sched *sched,
printf("\nIdle stats:\n");
for (i = 0; i < idle_max_cpu; ++i) {
+ if (cpu_list && !test_bit(i, cpu_bitmap))
+ continue;
+
t = idle_threads[i];
if (!t)
continue;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] perf sched timehist: Fix use of CPU list with summary option
2020-08-17 17:09 [PATCH v2] perf sched timehist: Fix use of CPU list with summary option David Ahern
@ 2020-08-18 1:29 ` Namhyung Kim
2020-08-18 11:51 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2020-08-18 1:29 UTC (permalink / raw)
To: David Ahern; +Cc: Arnaldo Carvalho de Melo, linux-kernel, Jiri Olsa
Hi David,
On Tue, Aug 18, 2020 at 2:09 AM David Ahern <dsahern@kernel.org> wrote:
>
> Do not update thread stats or show idle summary unless CPU is in
> the list of interest.
>
> Fixes: c30d630d1bcf ("perf sched timehist: Add support for filtering on CPU")
> Signed-off-by: David Ahern <dsahern@kernel.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks
Namhyung
> ---
> v2
> - check that cpu_list is set before checking cpu_bitmap in timehist_print_summary
>
> tools/perf/builtin-sched.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 0c7d599fa555..e6fc297cee91 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -2584,7 +2584,8 @@ static int timehist_sched_change_event(struct perf_tool *tool,
> }
>
> if (!sched->idle_hist || thread->tid == 0) {
> - timehist_update_runtime_stats(tr, t, tprev);
> + if (!cpu_list || test_bit(sample->cpu, cpu_bitmap))
> + timehist_update_runtime_stats(tr, t, tprev);
>
> if (sched->idle_hist) {
> struct idle_thread_runtime *itr = (void *)tr;
> @@ -2857,6 +2858,9 @@ static void timehist_print_summary(struct perf_sched *sched,
>
> printf("\nIdle stats:\n");
> for (i = 0; i < idle_max_cpu; ++i) {
> + if (cpu_list && !test_bit(i, cpu_bitmap))
> + continue;
> +
> t = idle_threads[i];
> if (!t)
> continue;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] perf sched timehist: Fix use of CPU list with summary option
2020-08-18 1:29 ` Namhyung Kim
@ 2020-08-18 11:51 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2020-08-18 11:51 UTC (permalink / raw)
To: Namhyung Kim; +Cc: David Ahern, linux-kernel, Jiri Olsa
Em Tue, Aug 18, 2020 at 10:29:29AM +0900, Namhyung Kim escreveu:
> Hi David,
>
> On Tue, Aug 18, 2020 at 2:09 AM David Ahern <dsahern@kernel.org> wrote:
> >
> > Do not update thread stats or show idle summary unless CPU is in
> > the list of interest.
> >
> > Fixes: c30d630d1bcf ("perf sched timehist: Add support for filtering on CPU")
> > Signed-off-by: David Ahern <dsahern@kernel.org>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied.
- Arnaldo
> Thanks
> Namhyung
>
> > ---
> > v2
> > - check that cpu_list is set before checking cpu_bitmap in timehist_print_summary
> >
> > tools/perf/builtin-sched.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index 0c7d599fa555..e6fc297cee91 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -2584,7 +2584,8 @@ static int timehist_sched_change_event(struct perf_tool *tool,
> > }
> >
> > if (!sched->idle_hist || thread->tid == 0) {
> > - timehist_update_runtime_stats(tr, t, tprev);
> > + if (!cpu_list || test_bit(sample->cpu, cpu_bitmap))
> > + timehist_update_runtime_stats(tr, t, tprev);
> >
> > if (sched->idle_hist) {
> > struct idle_thread_runtime *itr = (void *)tr;
> > @@ -2857,6 +2858,9 @@ static void timehist_print_summary(struct perf_sched *sched,
> >
> > printf("\nIdle stats:\n");
> > for (i = 0; i < idle_max_cpu; ++i) {
> > + if (cpu_list && !test_bit(i, cpu_bitmap))
> > + continue;
> > +
> > t = idle_threads[i];
> > if (!t)
> > continue;
> > --
> > 2.17.1
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-18 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 17:09 [PATCH v2] perf sched timehist: Fix use of CPU list with summary option David Ahern
2020-08-18 1:29 ` Namhyung Kim
2020-08-18 11:51 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.