From: Andrew Lunn <andrew@lunn.ch> To: Landen Chao <landen.chao@mediatek.com> Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, davem@davemloft.net, sean.wang@mediatek.com, opensource@vdorst.com, frank-w@public-files.de, dqfext@gmail.com Subject: Re: [PATCH net-next v2 3/7] net: dsa: mt7530: Extend device data ready for adding a new hardware Date: Tue, 18 Aug 2020 17:56:21 +0200 [thread overview] Message-ID: <20200818155621.GE2330298@lunn.ch> (raw) In-Reply-To: <a56f3029b913d31fbd27562b98d485e981815165.1597729692.git.landen.chao@mediatek.com> On Tue, Aug 18, 2020 at 03:14:08PM +0800, Landen Chao wrote: > Add a structure holding required operations for each device such as device > initialization, PHY port read or write, a checker whether PHY interface is > supported on a certain port, MAC port setup for either bus pad or a > specific PHY interface. > > The patch is done for ready adding a new hardware MT7531. > > Signed-off-by: Landen Chao <landen.chao@mediatek.com> > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > drivers/net/dsa/mt7530.c | 272 +++++++++++++++++++++++++++++---------- > drivers/net/dsa/mt7530.h | 37 +++++- > 2 files changed, 240 insertions(+), 69 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 0fd50798aa42..d30b41725b4d 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -372,8 +372,9 @@ mt7530_fdb_write(struct mt7530_priv *priv, u16 vid, > mt7530_write(priv, MT7530_ATA1 + (i * 4), reg[i]); > } > > +/* Setup TX circuit incluing relevant PAD and driving */ > static int > -mt7530_pad_clk_setup(struct dsa_switch *ds, int mode) > +mt7530_pad_clk_setup(struct dsa_switch *ds, phy_interface_t interface) > { > struct mt7530_priv *priv = ds->priv; > u32 ncpo1, ssc_delta, trgint, i, xtal; > @@ -387,7 +388,7 @@ mt7530_pad_clk_setup(struct dsa_switch *ds, int mode) > return -EINVAL; > } > > - switch (mode) { > + switch (interface) { > case PHY_INTERFACE_MODE_RGMII: > trgint = 0; > /* PLL frequency: 125MHz */ Do you actually need to support all 4 RGMII modes? ... + goto unsupported; > + break; > + case 6: /* 1st cpu port */ > + if (state->interface != PHY_INTERFACE_MODE_RGMII && > + state->interface != PHY_INTERFACE_MODE_TRGMII) phy_interface_mode_is_rgmii()? Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: Landen Chao <landen.chao@mediatek.com> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, frank-w@public-files.de, f.fainelli@gmail.com, dqfext@gmail.com, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, opensource@vdorst.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, davem@davemloft.net Subject: Re: [PATCH net-next v2 3/7] net: dsa: mt7530: Extend device data ready for adding a new hardware Date: Tue, 18 Aug 2020 17:56:21 +0200 [thread overview] Message-ID: <20200818155621.GE2330298@lunn.ch> (raw) In-Reply-To: <a56f3029b913d31fbd27562b98d485e981815165.1597729692.git.landen.chao@mediatek.com> On Tue, Aug 18, 2020 at 03:14:08PM +0800, Landen Chao wrote: > Add a structure holding required operations for each device such as device > initialization, PHY port read or write, a checker whether PHY interface is > supported on a certain port, MAC port setup for either bus pad or a > specific PHY interface. > > The patch is done for ready adding a new hardware MT7531. > > Signed-off-by: Landen Chao <landen.chao@mediatek.com> > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > --- > drivers/net/dsa/mt7530.c | 272 +++++++++++++++++++++++++++++---------- > drivers/net/dsa/mt7530.h | 37 +++++- > 2 files changed, 240 insertions(+), 69 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 0fd50798aa42..d30b41725b4d 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -372,8 +372,9 @@ mt7530_fdb_write(struct mt7530_priv *priv, u16 vid, > mt7530_write(priv, MT7530_ATA1 + (i * 4), reg[i]); > } > > +/* Setup TX circuit incluing relevant PAD and driving */ > static int > -mt7530_pad_clk_setup(struct dsa_switch *ds, int mode) > +mt7530_pad_clk_setup(struct dsa_switch *ds, phy_interface_t interface) > { > struct mt7530_priv *priv = ds->priv; > u32 ncpo1, ssc_delta, trgint, i, xtal; > @@ -387,7 +388,7 @@ mt7530_pad_clk_setup(struct dsa_switch *ds, int mode) > return -EINVAL; > } > > - switch (mode) { > + switch (interface) { > case PHY_INTERFACE_MODE_RGMII: > trgint = 0; > /* PLL frequency: 125MHz */ Do you actually need to support all 4 RGMII modes? ... + goto unsupported; > + break; > + case 6: /* 1st cpu port */ > + if (state->interface != PHY_INTERFACE_MODE_RGMII && > + state->interface != PHY_INTERFACE_MODE_TRGMII) phy_interface_mode_is_rgmii()? Andrew _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-08-18 15:56 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-18 7:14 [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 7:14 ` [PATCH net-next v2 1/7] net: dsa: mt7530: Refine message in Kconfig Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 7:14 ` [PATCH net-next v2 2/7] net: dsa: mt7530: support full-duplex gigabit only Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 15:49 ` Andrew Lunn 2020-08-18 15:49 ` Andrew Lunn 2020-08-18 7:14 ` [PATCH net-next v2 3/7] net: dsa: mt7530: Extend device data ready for adding a new hardware Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 15:56 ` Andrew Lunn [this message] 2020-08-18 15:56 ` Andrew Lunn 2020-08-18 17:31 ` Frank Wunderlich 2020-08-18 17:31 ` Frank Wunderlich 2020-08-18 7:14 ` [PATCH net-next v2 4/7] dt-bindings: net: dsa: add new MT7531 binding to support MT7531 Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-25 19:43 ` Rob Herring 2020-08-25 19:43 ` Rob Herring 2020-08-18 7:14 ` [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 15:23 ` Jakub Kicinski 2020-08-18 15:23 ` Jakub Kicinski 2020-08-19 9:50 ` Landen Chao 2020-08-19 9:50 ` Landen Chao 2020-08-18 16:09 ` Andrew Lunn 2020-08-18 16:09 ` Andrew Lunn 2020-08-19 9:44 ` Landen Chao 2020-08-19 9:44 ` Landen Chao 2020-08-19 13:12 ` Andrew Lunn 2020-08-19 13:12 ` Andrew Lunn 2020-08-19 23:46 ` René van Dorst 2020-08-19 23:46 ` René van Dorst 2020-08-20 15:29 ` Chuanhong Guo 2020-08-20 15:29 ` Chuanhong Guo 2020-08-18 7:14 ` [PATCH net-next v2 6/7] arm64: dts: mt7622: add mt7531 dsa to mt7622-rfb1 board Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 16:10 ` Andrew Lunn 2020-08-18 16:10 ` Andrew Lunn 2020-08-18 7:14 ` [PATCH net-next v2 7/7] arm64: dts: mt7622: add mt7531 dsa to bananapi-bpi-r64 board Landen Chao 2020-08-18 7:14 ` Landen Chao 2020-08-18 16:24 ` Vladimir Oltean 2020-08-18 16:24 ` Vladimir Oltean 2020-08-19 8:15 ` Landen Chao 2020-08-19 8:15 ` Landen Chao 2020-08-19 8:51 ` Vladimir Oltean 2020-08-19 8:51 ` Vladimir Oltean 2020-08-18 17:54 ` Aw: [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531 Frank Wunderlich 2020-08-18 17:54 ` Frank Wunderlich 2020-08-19 3:49 ` DENG Qingfang 2020-08-19 3:49 ` DENG Qingfang 2020-08-19 6:57 ` Frank Wunderlich 2020-08-19 7:38 ` Landen Chao 2020-08-19 7:38 ` Landen Chao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200818155621.GE2330298@lunn.ch \ --to=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dqfext@gmail.com \ --cc=f.fainelli@gmail.com \ --cc=frank-w@public-files.de \ --cc=landen.chao@mediatek.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=opensource@vdorst.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=vivien.didelot@savoirfairelinux.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.