* [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
@ 2020-08-19 4:34 Nischal Varide
2020-08-19 4:34 ` [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref Nischal Varide
` (8 more replies)
0 siblings, 9 replies; 23+ messages in thread
From: Nischal Varide @ 2020-08-19 4:34 UTC (permalink / raw)
To: intel-gfx, nischal.varide
This Patch fixes the Klocwork errors and the Current fix is avoiding
Possible Null Pointer Dereference
Signed-off-by: Nischal Varide <nischal.varide@intel.com>
---
drivers/gpu/drm/i915/display/intel_atomic.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
index 630f49b7aa01..cf51f1005ec1 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic.c
@@ -132,6 +132,9 @@ int intel_digital_connector_atomic_check(struct drm_connector *conn,
to_intel_digital_connector_state(old_state);
struct drm_crtc_state *crtc_state;
+ if (!(new_state && new_conn_state && old_state && old_conn_state))
+ return 0;
+
intel_hdcp_atomic_check(conn, old_state, new_state);
intel_psr_atomic_check(conn, old_state, new_state);
@@ -192,6 +195,8 @@ intel_connector_needs_modeset(struct intel_atomic_state *state,
old_conn_state = drm_atomic_get_old_connector_state(&state->base, connector);
new_conn_state = drm_atomic_get_new_connector_state(&state->base, connector);
+ if (!(old_conn_state && new_conn_state))
+ return 0;
return old_conn_state->crtc != new_conn_state->crtc ||
(new_conn_state->crtc &&
@@ -418,7 +423,7 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,
*/
/* fail if required scalers > available scalers */
- if (num_scalers_need > intel_crtc->num_scalers){
+ if (num_scalers_need > intel_crtc->num_scalers) {
drm_dbg_kms(&dev_priv->drm,
"Too many scaling requests %d > %d\n",
num_scalers_need, intel_crtc->num_scalers);
--
2.26.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
@ 2020-08-19 4:34 ` Nischal Varide
2020-08-20 3:24 ` kernel test robot
2020-08-25 9:25 ` Dan Carpenter
2020-08-19 4:34 ` [Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null Nischal Varide
` (7 subsequent siblings)
8 siblings, 2 replies; 23+ messages in thread
From: Nischal Varide @ 2020-08-19 4:34 UTC (permalink / raw)
To: intel-gfx, nischal.varide
This Patch fixes the Critical KlockWork Error and here a possible NuLL
Pointer dereferencing is addressed. A check has been added before
dereferencing.
Signed-off-by: Nischal Varide <nischal.varide@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 22 +++++++++++---------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 2ddabf92adde..cc59c5e94698 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -2265,9 +2265,9 @@ intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
pinctl = 0;
if (HAS_GMCH(dev_priv))
pinctl |= PIN_MAPPABLE;
-
- vma = i915_gem_object_pin_to_display_plane(obj,
- alignment, view, pinctl);
+ if (obj)
+ vma = i915_gem_object_pin_to_display_plane(obj,
+ alignment, view, pinctl);
if (IS_ERR(vma))
goto err;
@@ -11269,10 +11269,13 @@ static u32 intel_cursor_base(const struct intel_plane_state *plane_state)
const struct drm_i915_gem_object *obj = intel_fb_obj(fb);
u32 base;
- if (INTEL_INFO(dev_priv)->display.cursor_needs_physical)
- base = sg_dma_address(obj->mm.pages->sgl);
- else
- base = intel_plane_ggtt_offset(plane_state);
+ if (obj) {
+
+ if (INTEL_INFO(dev_priv)->display.cursor_needs_physical)
+ base = sg_dma_address(obj->mm.pages->sgl);
+ else
+ base = intel_plane_ggtt_offset(plane_state);
+ }
return base + plane_state->color_plane[0].offset;
}
@@ -17126,10 +17129,9 @@ static int intel_user_framebuffer_dirty(struct drm_framebuffer *fb,
unsigned num_clips)
{
struct drm_i915_gem_object *obj = intel_fb_obj(fb);
-
- i915_gem_object_flush_if_display(obj);
+ if (obj)
+ i915_gem_object_flush_if_display(obj);
intel_frontbuffer_flush(to_intel_frontbuffer(fb), ORIGIN_DIRTYFB);
-
return 0;
}
--
2.26.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
2020-08-19 4:34 ` [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref Nischal Varide
@ 2020-08-20 3:24 ` kernel test robot
2020-08-25 9:25 ` Dan Carpenter
1 sibling, 0 replies; 23+ messages in thread
From: kernel test robot @ 2020-08-20 3:24 UTC (permalink / raw)
To: Nischal Varide, intel-gfx; +Cc: kbuild-all
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
^
drivers/gpu/drm/i915/display/intel_display.c:4308:7: warning: Local variable src_w shadows outer variable [shadowVar]
int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
^
drivers/gpu/drm/i915/display/intel_display.c:4271:20: note: Shadowed declaration
int src_x, src_y, src_w;
^
drivers/gpu/drm/i915/display/intel_display.c:4308:7: note: Shadow variable
int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
^
drivers/gpu/drm/i915/display/intel_display.c:11169:7: warning: Local variable tmp shadows outer variable [shadowVar]
u32 tmp = intel_de_read(dev_priv,
^
drivers/gpu/drm/i915/display/intel_display.c:11133:6: note: Shadowed declaration
u32 tmp;
^
drivers/gpu/drm/i915/display/intel_display.c:11169:7: note: Shadow variable
u32 tmp = intel_de_read(dev_priv,
^
drivers/gpu/drm/i915/display/intel_display.c:14246:4: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(active,
^
drivers/gpu/drm/i915/display/intel_display.c:14237:3: note: Shadowed declaration
I915_STATE_WARN(!!encoder->base.crtc != enabled,
^
drivers/gpu/drm/i915/display/intel_display.c:14246:4: note: Shadow variable
I915_STATE_WARN(active,
^
drivers/gpu/drm/i915/display/intel_display.c:14293:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(active != new_crtc_state->hw.active,
^
drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
I915_STATE_WARN(new_crtc_state->hw.active != active,
^
drivers/gpu/drm/i915/display/intel_display.c:14293:3: note: Shadow variable
I915_STATE_WARN(active != new_crtc_state->hw.active,
^
drivers/gpu/drm/i915/display/intel_display.c:14298:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(active && crtc->pipe != pipe,
^
drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
I915_STATE_WARN(new_crtc_state->hw.active != active,
^
drivers/gpu/drm/i915/display/intel_display.c:14298:3: note: Shadow variable
I915_STATE_WARN(active && crtc->pipe != pipe,
^
drivers/gpu/drm/i915/display/intel_display.c:14315:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(1, "pipe state doesn't match!n");
^
drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
I915_STATE_WARN(new_crtc_state->hw.active != active,
^
drivers/gpu/drm/i915/display/intel_display.c:14315:3: note: Shadow variable
I915_STATE_WARN(1, "pipe state doesn't match!n");
^
drivers/gpu/drm/i915/display/intel_display.c:18447:23: warning: Local variable crtc shadows outer variable [shadowVar]
struct intel_crtc *crtc;
^
drivers/gpu/drm/i915/display/intel_display.c:18385:21: note: Shadowed declaration
struct intel_crtc *crtc;
^
drivers/gpu/drm/i915/display/intel_display.c:18447:23: note: Shadow variable
struct intel_crtc *crtc;
^
drivers/gpu/drm/i915/display/intel_display.c:6103:35: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
scaler_state->scaler_users |= (1 << scaler_user);
^
drivers/gpu/drm/i915/display/intel_display.c:6127:6: note: Calling function 'skl_update_scaler', 3rd argument '31' value is 31
SKL_CRTC_INDEX,
^
drivers/gpu/drm/i915/display/intel_display.c:6103:35: note: Shift
scaler_state->scaler_users |= (1 << scaler_user);
^
drivers/gpu/drm/i915/display/intel_display.c:10477:36: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
scaler_state->scaler_users |= (1 << SKL_CRTC_INDEX);
^
drivers/gpu/drm/i915/display/intel_display.c:10479:37: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
scaler_state->scaler_users &= ~(1 << SKL_CRTC_INDEX);
^
>> drivers/gpu/drm/i915/display/intel_display.c:11280:9: warning: Uninitialized variable: base [uninitvar]
return base + plane_state->color_plane[0].offset;
^
# https://github.com/0day-ci/linux/commit/5d862961b8571914f726e947570316016ec67c5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 5d862961b8571914f726e947570316016ec67c5d
vim +11280 drivers/gpu/drm/i915/display/intel_display.c
0e8ffe1bf81b07 drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2013-03-28 11263
cd5dcbf1b26c60 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11264 static u32 intel_cursor_base(const struct intel_plane_state *plane_state)
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11265 {
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11266 struct drm_i915_private *dev_priv =
f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_display.c Maarten Lankhorst 2019-10-31 11267 to_i915(plane_state->uapi.plane->dev);
7b3cb17a48dc1b drivers/gpu/drm/i915/display/intel_display.c Maarten Lankhorst 2019-10-31 11268 const struct drm_framebuffer *fb = plane_state->hw.fb;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11269 const struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11270 u32 base;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11271
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 11272 if (obj) {
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 11273
d53db442db36fd drivers/gpu/drm/i915/intel_display.c José Roberto de Souza 2018-11-30 11274 if (INTEL_INFO(dev_priv)->display.cursor_needs_physical)
c6790dc22312f5 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2020-02-02 11275 base = sg_dma_address(obj->mm.pages->sgl);
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11276 else
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11277 base = intel_plane_ggtt_offset(plane_state);
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 11278 }
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11279
30a027dcccc270 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-10-15 @11280 return base + plane_state->color_plane[0].offset;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11281 }
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11282
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
@ 2020-08-20 3:24 ` kernel test robot
0 siblings, 0 replies; 23+ messages in thread
From: kernel test robot @ 2020-08-20 3:24 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8414 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
^
drivers/gpu/drm/i915/display/intel_display.c:4308:7: warning: Local variable src_w shadows outer variable [shadowVar]
int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
^
drivers/gpu/drm/i915/display/intel_display.c:4271:20: note: Shadowed declaration
int src_x, src_y, src_w;
^
drivers/gpu/drm/i915/display/intel_display.c:4308:7: note: Shadow variable
int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
^
drivers/gpu/drm/i915/display/intel_display.c:11169:7: warning: Local variable tmp shadows outer variable [shadowVar]
u32 tmp = intel_de_read(dev_priv,
^
drivers/gpu/drm/i915/display/intel_display.c:11133:6: note: Shadowed declaration
u32 tmp;
^
drivers/gpu/drm/i915/display/intel_display.c:11169:7: note: Shadow variable
u32 tmp = intel_de_read(dev_priv,
^
drivers/gpu/drm/i915/display/intel_display.c:14246:4: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(active,
^
drivers/gpu/drm/i915/display/intel_display.c:14237:3: note: Shadowed declaration
I915_STATE_WARN(!!encoder->base.crtc != enabled,
^
drivers/gpu/drm/i915/display/intel_display.c:14246:4: note: Shadow variable
I915_STATE_WARN(active,
^
drivers/gpu/drm/i915/display/intel_display.c:14293:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(active != new_crtc_state->hw.active,
^
drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
I915_STATE_WARN(new_crtc_state->hw.active != active,
^
drivers/gpu/drm/i915/display/intel_display.c:14293:3: note: Shadow variable
I915_STATE_WARN(active != new_crtc_state->hw.active,
^
drivers/gpu/drm/i915/display/intel_display.c:14298:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(active && crtc->pipe != pipe,
^
drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
I915_STATE_WARN(new_crtc_state->hw.active != active,
^
drivers/gpu/drm/i915/display/intel_display.c:14298:3: note: Shadow variable
I915_STATE_WARN(active && crtc->pipe != pipe,
^
drivers/gpu/drm/i915/display/intel_display.c:14315:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
I915_STATE_WARN(1, "pipe state doesn't match!n");
^
drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
I915_STATE_WARN(new_crtc_state->hw.active != active,
^
drivers/gpu/drm/i915/display/intel_display.c:14315:3: note: Shadow variable
I915_STATE_WARN(1, "pipe state doesn't match!n");
^
drivers/gpu/drm/i915/display/intel_display.c:18447:23: warning: Local variable crtc shadows outer variable [shadowVar]
struct intel_crtc *crtc;
^
drivers/gpu/drm/i915/display/intel_display.c:18385:21: note: Shadowed declaration
struct intel_crtc *crtc;
^
drivers/gpu/drm/i915/display/intel_display.c:18447:23: note: Shadow variable
struct intel_crtc *crtc;
^
drivers/gpu/drm/i915/display/intel_display.c:6103:35: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
scaler_state->scaler_users |= (1 << scaler_user);
^
drivers/gpu/drm/i915/display/intel_display.c:6127:6: note: Calling function 'skl_update_scaler', 3rd argument '31' value is 31
SKL_CRTC_INDEX,
^
drivers/gpu/drm/i915/display/intel_display.c:6103:35: note: Shift
scaler_state->scaler_users |= (1 << scaler_user);
^
drivers/gpu/drm/i915/display/intel_display.c:10477:36: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
scaler_state->scaler_users |= (1 << SKL_CRTC_INDEX);
^
drivers/gpu/drm/i915/display/intel_display.c:10479:37: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
scaler_state->scaler_users &= ~(1 << SKL_CRTC_INDEX);
^
>> drivers/gpu/drm/i915/display/intel_display.c:11280:9: warning: Uninitialized variable: base [uninitvar]
return base + plane_state->color_plane[0].offset;
^
# https://github.com/0day-ci/linux/commit/5d862961b8571914f726e947570316016ec67c5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 5d862961b8571914f726e947570316016ec67c5d
vim +11280 drivers/gpu/drm/i915/display/intel_display.c
0e8ffe1bf81b07 drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2013-03-28 11263
cd5dcbf1b26c60 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11264 static u32 intel_cursor_base(const struct intel_plane_state *plane_state)
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11265 {
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11266 struct drm_i915_private *dev_priv =
f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_display.c Maarten Lankhorst 2019-10-31 11267 to_i915(plane_state->uapi.plane->dev);
7b3cb17a48dc1b drivers/gpu/drm/i915/display/intel_display.c Maarten Lankhorst 2019-10-31 11268 const struct drm_framebuffer *fb = plane_state->hw.fb;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11269 const struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11270 u32 base;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11271
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 11272 if (obj) {
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 11273
d53db442db36fd drivers/gpu/drm/i915/intel_display.c José Roberto de Souza 2018-11-30 11274 if (INTEL_INFO(dev_priv)->display.cursor_needs_physical)
c6790dc22312f5 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2020-02-02 11275 base = sg_dma_address(obj->mm.pages->sgl);
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11276 else
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11277 base = intel_plane_ggtt_offset(plane_state);
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 11278 }
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11279
30a027dcccc270 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-10-15 @11280 return base + plane_state->color_plane[0].offset;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11281 }
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-27 11282
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
2020-08-19 4:34 ` [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref Nischal Varide
2020-08-20 3:24 ` kernel test robot
@ 2020-08-25 9:25 ` Dan Carpenter
1 sibling, 0 replies; 23+ messages in thread
From: Dan Carpenter @ 2020-08-25 9:25 UTC (permalink / raw)
To: kbuild, Nischal Varide, intel-gfx; +Cc: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 14340 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-m021-20200824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:2271 intel_pin_and_fence_fb_obj() error: uninitialized symbol 'vma'.
drivers/gpu/drm/i915/display/intel_display.c:11280 intel_cursor_base() error: uninitialized symbol 'base'.
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:6183 skl_update_scaler_plane() error: we previously assumed 'fb' could be null (see line 6167)
# https://github.com/0day-ci/linux/commit/5d862961b8571914f726e947570316016ec67c5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 5d862961b8571914f726e947570316016ec67c5d
vim +/vma +2271 drivers/gpu/drm/i915/display/intel_display.c
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2217 struct i915_vma *
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2218 intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2219 const struct i915_ggtt_view *view,
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2220 bool uses_fence,
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2221 unsigned long *out_flags)
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2222 {
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2223 struct drm_device *dev = fb->dev;
fac5e23e3c385f drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-07-04 2224 struct drm_i915_private *dev_priv = to_i915(dev);
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2225 struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1d264d91befc31 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2019-01-14 2226 intel_wakeref_t wakeref;
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2227 struct i915_vma *vma;
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2228 unsigned int pinctl;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2229 u32 alignment;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2230
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2231 if (drm_WARN_ON(dev, !i915_gem_object_is_framebuffer(obj)))
5a90606df7cb73 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-09-02 2232 return ERR_PTR(-EINVAL);
ebcdd39eafb1d8 drivers/gpu/drm/i915/intel_display.c Matt Roper 2014-07-09 2233
d88c4afddc5519 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-07 2234 alignment = intel_surf_alignment(fb, 0);
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2235 if (drm_WARN_ON(dev, alignment && !is_power_of_2(alignment)))
7361bdb26c2ca6 drivers/gpu/drm/i915/display/intel_display.c Imre Deak 2019-12-25 2236 return ERR_PTR(-EINVAL);
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2237
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2238 /* Note that the w/a also requires 64 PTE of padding following the
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2239 * bo. We currently fill all unused PTE with the shadow page and so
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2240 * we should always have valid PTE following the scanout preventing
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2241 * the VT-d warning.
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2242 */
48f112fed3b078 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-06-24 2243 if (intel_scanout_needs_vtd_wa(dev_priv) && alignment < 256 * 1024)
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2244 alignment = 256 * 1024;
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2245
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2246 /*
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2247 * Global gtt pte registers are special registers which actually forward
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2248 * writes to a chunk of system memory. Which means that there is no risk
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2249 * that the register values disappear as soon as we call
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2250 * intel_runtime_pm_put(), so it is correct to wrap only the
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2251 * pin/unpin/fence and not more.
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2252 */
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2253 wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2254
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2255 atomic_inc(&dev_priv->gpu_error.pending_fb_pin);
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2256
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2257 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2258 * Valleyview is definitely limited to scanning out the first
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2259 * 512MiB. Lets presume this behaviour was inherited from the
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2260 * g4x display engine and that all earlier gen are similarly
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2261 * limited. Testing suggests that it is a little more
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2262 * complicated than this. For example, Cherryview appears quite
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2263 * happy to scanout from anywhere within its global aperture.
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2264 */
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2265 pinctl = 0;
b2ae318acdcaf1 drivers/gpu/drm/i915/intel_display.c Rodrigo Vivi 2019-02-04 2266 if (HAS_GMCH(dev_priv))
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2267 pinctl |= PIN_MAPPABLE;
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 2268 if (obj)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2269 vma = i915_gem_object_pin_to_display_plane(obj,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2270 alignment, view, pinctl);
"vma" not initialized on else path.
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 @2271 if (IS_ERR(vma))
^^^
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2272 goto err;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2273
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2274 if (uses_fence && i915_vma_is_map_and_fenceable(vma)) {
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2275 int ret;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2276
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2277 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2278 * Install a fence for tiled scan-out. Pre-i965 always needs a
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2279 * fence, whereas 965+ only requires a fence if using
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2280 * framebuffer compression. For simplicity, we always, when
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2281 * possible, install a fence as the cost is not that onerous.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2282 *
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2283 * If we fail to fence the tiled scanout, then either the
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2284 * modeset will reject the change (which is highly unlikely as
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2285 * the affected systems, all but one, do not have unmappable
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2286 * space) or we will not be able to enable full powersaving
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2287 * techniques (also likely not to apply due to various limits
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2288 * FBC and the like impose on the size of the buffer, which
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2289 * presumably we violated anyway with this unmappable buffer).
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2290 * Anyway, it is presumably better to stumble onwards with
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2291 * something and try to run the system in a "less than optimal"
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2292 * mode that matches the user configuration.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2293 */
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2294 ret = i915_vma_pin_fence(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2295 if (ret != 0 && INTEL_GEN(dev_priv) < 4) {
7509702bd8bd09 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-03-05 2296 i915_gem_object_unpin_from_display_plane(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2297 vma = ERR_PTR(ret);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2298 goto err;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2299 }
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2300
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2301 if (ret == 0 && vma->fence)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2302 *out_flags |= PLANE_HAS_FENCE;
9807216f585fc6 drivers/gpu/drm/i915/intel_display.c Vivek Kasireddy 2015-10-29 2303 }
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2304
be1e341513ca23 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2017-01-16 2305 i915_vma_get(vma);
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2306 err:
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2307 atomic_dec(&dev_priv->gpu_error.pending_fb_pin);
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2308 intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2309 return vma;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2310 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40662 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
@ 2020-08-25 9:25 ` Dan Carpenter
0 siblings, 0 replies; 23+ messages in thread
From: Dan Carpenter @ 2020-08-25 9:25 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 14507 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-m021-20200824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:2271 intel_pin_and_fence_fb_obj() error: uninitialized symbol 'vma'.
drivers/gpu/drm/i915/display/intel_display.c:11280 intel_cursor_base() error: uninitialized symbol 'base'.
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:6183 skl_update_scaler_plane() error: we previously assumed 'fb' could be null (see line 6167)
# https://github.com/0day-ci/linux/commit/5d862961b8571914f726e947570316016ec67c5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 5d862961b8571914f726e947570316016ec67c5d
vim +/vma +2271 drivers/gpu/drm/i915/display/intel_display.c
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2217 struct i915_vma *
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2218 intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2219 const struct i915_ggtt_view *view,
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2220 bool uses_fence,
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2221 unsigned long *out_flags)
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2222 {
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2223 struct drm_device *dev = fb->dev;
fac5e23e3c385f drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-07-04 2224 struct drm_i915_private *dev_priv = to_i915(dev);
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2225 struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1d264d91befc31 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2019-01-14 2226 intel_wakeref_t wakeref;
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2227 struct i915_vma *vma;
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2228 unsigned int pinctl;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2229 u32 alignment;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2230
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2231 if (drm_WARN_ON(dev, !i915_gem_object_is_framebuffer(obj)))
5a90606df7cb73 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-09-02 2232 return ERR_PTR(-EINVAL);
ebcdd39eafb1d8 drivers/gpu/drm/i915/intel_display.c Matt Roper 2014-07-09 2233
d88c4afddc5519 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-07 2234 alignment = intel_surf_alignment(fb, 0);
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2235 if (drm_WARN_ON(dev, alignment && !is_power_of_2(alignment)))
7361bdb26c2ca6 drivers/gpu/drm/i915/display/intel_display.c Imre Deak 2019-12-25 2236 return ERR_PTR(-EINVAL);
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2237
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2238 /* Note that the w/a also requires 64 PTE of padding following the
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2239 * bo. We currently fill all unused PTE with the shadow page and so
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2240 * we should always have valid PTE following the scanout preventing
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2241 * the VT-d warning.
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2242 */
48f112fed3b078 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-06-24 2243 if (intel_scanout_needs_vtd_wa(dev_priv) && alignment < 256 * 1024)
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2244 alignment = 256 * 1024;
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2245
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2246 /*
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2247 * Global gtt pte registers are special registers which actually forward
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2248 * writes to a chunk of system memory. Which means that there is no risk
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2249 * that the register values disappear as soon as we call
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2250 * intel_runtime_pm_put(), so it is correct to wrap only the
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2251 * pin/unpin/fence and not more.
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2252 */
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2253 wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2254
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2255 atomic_inc(&dev_priv->gpu_error.pending_fb_pin);
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2256
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2257 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2258 * Valleyview is definitely limited to scanning out the first
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2259 * 512MiB. Lets presume this behaviour was inherited from the
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2260 * g4x display engine and that all earlier gen are similarly
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2261 * limited. Testing suggests that it is a little more
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2262 * complicated than this. For example, Cherryview appears quite
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2263 * happy to scanout from anywhere within its global aperture.
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2264 */
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2265 pinctl = 0;
b2ae318acdcaf1 drivers/gpu/drm/i915/intel_display.c Rodrigo Vivi 2019-02-04 2266 if (HAS_GMCH(dev_priv))
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2267 pinctl |= PIN_MAPPABLE;
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 2268 if (obj)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2269 vma = i915_gem_object_pin_to_display_plane(obj,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2270 alignment, view, pinctl);
"vma" not initialized on else path.
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 @2271 if (IS_ERR(vma))
^^^
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2272 goto err;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2273
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2274 if (uses_fence && i915_vma_is_map_and_fenceable(vma)) {
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2275 int ret;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2276
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2277 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2278 * Install a fence for tiled scan-out. Pre-i965 always needs a
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2279 * fence, whereas 965+ only requires a fence if using
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2280 * framebuffer compression. For simplicity, we always, when
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2281 * possible, install a fence as the cost is not that onerous.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2282 *
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2283 * If we fail to fence the tiled scanout, then either the
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2284 * modeset will reject the change (which is highly unlikely as
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2285 * the affected systems, all but one, do not have unmappable
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2286 * space) or we will not be able to enable full powersaving
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2287 * techniques (also likely not to apply due to various limits
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2288 * FBC and the like impose on the size of the buffer, which
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2289 * presumably we violated anyway with this unmappable buffer).
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2290 * Anyway, it is presumably better to stumble onwards with
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2291 * something and try to run the system in a "less than optimal"
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2292 * mode that matches the user configuration.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2293 */
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2294 ret = i915_vma_pin_fence(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2295 if (ret != 0 && INTEL_GEN(dev_priv) < 4) {
7509702bd8bd09 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-03-05 2296 i915_gem_object_unpin_from_display_plane(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2297 vma = ERR_PTR(ret);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2298 goto err;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2299 }
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2300
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2301 if (ret == 0 && vma->fence)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2302 *out_flags |= PLANE_HAS_FENCE;
9807216f585fc6 drivers/gpu/drm/i915/intel_display.c Vivek Kasireddy 2015-10-29 2303 }
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2304
be1e341513ca23 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2017-01-16 2305 i915_vma_get(vma);
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2306 err:
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2307 atomic_dec(&dev_priv->gpu_error.pending_fb_pin);
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2308 intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2309 return vma;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2310 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40662 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
@ 2020-08-25 9:25 ` Dan Carpenter
0 siblings, 0 replies; 23+ messages in thread
From: Dan Carpenter @ 2020-08-25 9:25 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 14507 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-m021-20200824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:2271 intel_pin_and_fence_fb_obj() error: uninitialized symbol 'vma'.
drivers/gpu/drm/i915/display/intel_display.c:11280 intel_cursor_base() error: uninitialized symbol 'base'.
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:6183 skl_update_scaler_plane() error: we previously assumed 'fb' could be null (see line 6167)
# https://github.com/0day-ci/linux/commit/5d862961b8571914f726e947570316016ec67c5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 5d862961b8571914f726e947570316016ec67c5d
vim +/vma +2271 drivers/gpu/drm/i915/display/intel_display.c
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2217 struct i915_vma *
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2218 intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2219 const struct i915_ggtt_view *view,
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2220 bool uses_fence,
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2221 unsigned long *out_flags)
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2222 {
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2223 struct drm_device *dev = fb->dev;
fac5e23e3c385f drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-07-04 2224 struct drm_i915_private *dev_priv = to_i915(dev);
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2225 struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1d264d91befc31 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2019-01-14 2226 intel_wakeref_t wakeref;
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2227 struct i915_vma *vma;
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2228 unsigned int pinctl;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2229 u32 alignment;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2230
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2231 if (drm_WARN_ON(dev, !i915_gem_object_is_framebuffer(obj)))
5a90606df7cb73 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-09-02 2232 return ERR_PTR(-EINVAL);
ebcdd39eafb1d8 drivers/gpu/drm/i915/intel_display.c Matt Roper 2014-07-09 2233
d88c4afddc5519 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-07 2234 alignment = intel_surf_alignment(fb, 0);
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2235 if (drm_WARN_ON(dev, alignment && !is_power_of_2(alignment)))
7361bdb26c2ca6 drivers/gpu/drm/i915/display/intel_display.c Imre Deak 2019-12-25 2236 return ERR_PTR(-EINVAL);
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2237
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2238 /* Note that the w/a also requires 64 PTE of padding following the
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2239 * bo. We currently fill all unused PTE with the shadow page and so
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2240 * we should always have valid PTE following the scanout preventing
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2241 * the VT-d warning.
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2242 */
48f112fed3b078 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-06-24 2243 if (intel_scanout_needs_vtd_wa(dev_priv) && alignment < 256 * 1024)
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2244 alignment = 256 * 1024;
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2245
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2246 /*
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2247 * Global gtt pte registers are special registers which actually forward
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2248 * writes to a chunk of system memory. Which means that there is no risk
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2249 * that the register values disappear as soon as we call
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2250 * intel_runtime_pm_put(), so it is correct to wrap only the
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2251 * pin/unpin/fence and not more.
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2252 */
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2253 wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2254
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2255 atomic_inc(&dev_priv->gpu_error.pending_fb_pin);
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2256
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2257 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2258 * Valleyview is definitely limited to scanning out the first
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2259 * 512MiB. Lets presume this behaviour was inherited from the
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2260 * g4x display engine and that all earlier gen are similarly
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2261 * limited. Testing suggests that it is a little more
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2262 * complicated than this. For example, Cherryview appears quite
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2263 * happy to scanout from anywhere within its global aperture.
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2264 */
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2265 pinctl = 0;
b2ae318acdcaf1 drivers/gpu/drm/i915/intel_display.c Rodrigo Vivi 2019-02-04 2266 if (HAS_GMCH(dev_priv))
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2267 pinctl |= PIN_MAPPABLE;
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 2268 if (obj)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2269 vma = i915_gem_object_pin_to_display_plane(obj,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2270 alignment, view, pinctl);
"vma" not initialized on else path.
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 @2271 if (IS_ERR(vma))
^^^
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2272 goto err;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2273
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2274 if (uses_fence && i915_vma_is_map_and_fenceable(vma)) {
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2275 int ret;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2276
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2277 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2278 * Install a fence for tiled scan-out. Pre-i965 always needs a
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2279 * fence, whereas 965+ only requires a fence if using
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2280 * framebuffer compression. For simplicity, we always, when
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2281 * possible, install a fence as the cost is not that onerous.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2282 *
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2283 * If we fail to fence the tiled scanout, then either the
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2284 * modeset will reject the change (which is highly unlikely as
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2285 * the affected systems, all but one, do not have unmappable
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2286 * space) or we will not be able to enable full powersaving
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2287 * techniques (also likely not to apply due to various limits
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2288 * FBC and the like impose on the size of the buffer, which
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2289 * presumably we violated anyway with this unmappable buffer).
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2290 * Anyway, it is presumably better to stumble onwards with
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2291 * something and try to run the system in a "less than optimal"
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2292 * mode that matches the user configuration.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2293 */
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2294 ret = i915_vma_pin_fence(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2295 if (ret != 0 && INTEL_GEN(dev_priv) < 4) {
7509702bd8bd09 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-03-05 2296 i915_gem_object_unpin_from_display_plane(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2297 vma = ERR_PTR(ret);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2298 goto err;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2299 }
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2300
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2301 if (ret == 0 && vma->fence)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2302 *out_flags |= PLANE_HAS_FENCE;
9807216f585fc6 drivers/gpu/drm/i915/intel_display.c Vivek Kasireddy 2015-10-29 2303 }
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2304
be1e341513ca23 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2017-01-16 2305 i915_vma_get(vma);
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2306 err:
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2307 atomic_dec(&dev_priv->gpu_error.pending_fb_pin);
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2308 intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2309 return vma;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2310 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40662 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
2020-08-19 4:34 ` [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref Nischal Varide
@ 2020-08-19 4:34 ` Nischal Varide
2020-08-19 4:34 ` [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null Nischal Varide
` (6 subsequent siblings)
8 siblings, 0 replies; 23+ messages in thread
From: Nischal Varide @ 2020-08-19 4:34 UTC (permalink / raw)
To: intel-gfx, nischal.varide
This patch fixes Critical Klockwork errors and in this case a Possible
Null Pointer Dereferencing is addressed with a Check before
Dereferencing
Signed-off-by: Nischal Varide <nischal.varide@intel.com>
---
drivers/gpu/drm/i915/display/intel_sdvo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
index 2da4388e1540..186a2d695bb6 100644
--- a/drivers/gpu/drm/i915/display/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
@@ -2505,6 +2505,9 @@ static int intel_sdvo_atomic_check(struct drm_connector *conn,
struct intel_sdvo_connector_state *new_state =
to_intel_sdvo_connector_state(new_conn_state);
+ if (!(new_conn_state && old_conn_state && old_state && new_state))
+ return 0;
+
if (new_conn_state->crtc &&
(memcmp(&old_state->tv, &new_state->tv, sizeof(old_state->tv)) ||
memcmp(&old_conn_state->tv, &new_conn_state->tv, sizeof(old_conn_state->tv)))) {
--
2.26.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
2020-08-19 4:34 ` [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref Nischal Varide
2020-08-19 4:34 ` [Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null Nischal Varide
@ 2020-08-19 4:34 ` Nischal Varide
2020-08-24 6:32 ` Anshuman Gupta
2020-08-25 9:31 ` Dan Carpenter
2020-08-19 4:34 ` [Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null Nischal Varide
` (5 subsequent siblings)
8 siblings, 2 replies; 23+ messages in thread
From: Nischal Varide @ 2020-08-19 4:34 UTC (permalink / raw)
To: intel-gfx, nischal.varide
This patch fixes the Critical Klock work Error and in this case a
Possible Null Pointer Dereference has been addressed with a Null check
before dereferencing
Signed-off-by: Nischal Varide <nischal.varide@intel.com>
---
drivers/gpu/drm/i915/display/intel_tv.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
index 777032d9697b..5600d146ae81 100644
--- a/drivers/gpu/drm/i915/display/intel_tv.c
+++ b/drivers/gpu/drm/i915/display/intel_tv.c
@@ -1836,17 +1836,20 @@ static int intel_tv_atomic_check(struct drm_connector *connector,
struct drm_connector_state *old_state;
new_state = drm_atomic_get_new_connector_state(state, connector);
- if (!new_state->crtc)
- return 0;
-
old_state = drm_atomic_get_old_connector_state(state, connector);
new_crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
+ if (!(old_state && new_state && new_crtc_state))
+ return 0;
+
+ if (!new_state->crtc)
+ return 0;
+
if (old_state->tv.mode != new_state->tv.mode ||
- old_state->tv.margins.left != new_state->tv.margins.left ||
- old_state->tv.margins.right != new_state->tv.margins.right ||
- old_state->tv.margins.top != new_state->tv.margins.top ||
- old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
+ old_state->tv.margins.left != new_state->tv.margins.left ||
+ old_state->tv.margins.right != new_state->tv.margins.right ||
+ old_state->tv.margins.top != new_state->tv.margins.top ||
+ old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
/* Force a modeset. */
new_crtc_state->connectors_changed = true;
--
2.26.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null
2020-08-19 4:34 ` [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null Nischal Varide
@ 2020-08-24 6:32 ` Anshuman Gupta
2020-08-25 9:31 ` Dan Carpenter
1 sibling, 0 replies; 23+ messages in thread
From: Anshuman Gupta @ 2020-08-24 6:32 UTC (permalink / raw)
To: Nischal Varide; +Cc: intel-gfx
On 2020-08-19 at 10:04:08 +0530, Nischal Varide wrote:
> This patch fixes the Critical Klock work Error and in this case a
> Possible Null Pointer Dereference has been addressed with a Null check
> before dereferencing
>
> Signed-off-by: Nischal Varide <nischal.varide@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_tv.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_tv.c b/drivers/gpu/drm/i915/display/intel_tv.c
> index 777032d9697b..5600d146ae81 100644
> --- a/drivers/gpu/drm/i915/display/intel_tv.c
> +++ b/drivers/gpu/drm/i915/display/intel_tv.c
> @@ -1836,17 +1836,20 @@ static int intel_tv_atomic_check(struct drm_connector *connector,
> struct drm_connector_state *old_state;
>
> new_state = drm_atomic_get_new_connector_state(state, connector);
> - if (!new_state->crtc)
> - return 0;
> -
> old_state = drm_atomic_get_old_connector_state(state, connector);
> new_crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
>
> + if (!(old_state && new_state && new_crtc_state))
> + return 0;
> +
> + if (!new_state->crtc)
> + return 0;
> +
> if (old_state->tv.mode != new_state->tv.mode ||
> - old_state->tv.margins.left != new_state->tv.margins.left ||
> - old_state->tv.margins.right != new_state->tv.margins.right ||
> - old_state->tv.margins.top != new_state->tv.margins.top ||
> - old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
> + old_state->tv.margins.left != new_state->tv.margins.left ||
> + old_state->tv.margins.right != new_state->tv.margins.right ||
> + old_state->tv.margins.top != new_state->tv.margins.top ||
> + old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
This seems unwanted changes.
Thanks,
Anshuman.
> /* Force a modeset. */
>
> new_crtc_state->connectors_changed = true;
> --
> 2.26.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null
2020-08-19 4:34 ` [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null Nischal Varide
2020-08-24 6:32 ` Anshuman Gupta
@ 2020-08-25 9:31 ` Dan Carpenter
1 sibling, 0 replies; 23+ messages in thread
From: Dan Carpenter @ 2020-08-25 9:31 UTC (permalink / raw)
To: kbuild, Nischal Varide, intel-gfx; +Cc: kbuild-all, Dan Carpenter
[-- Attachment #1: Type: text/plain, Size: 5061 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-m021-20200824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_tv.c:1842 intel_tv_atomic_check() warn: variable dereferenced before check 'new_state' (see line 1840)
# https://github.com/0day-ci/linux/commit/6fb528c1b424d3c8095085afa7e777ac5502450b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 6fb528c1b424d3c8095085afa7e777ac5502450b
vim +/new_state +1842 drivers/gpu/drm/i915/display/intel_tv.c
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1831 static int intel_tv_atomic_check(struct drm_connector *connector,
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1832 struct drm_atomic_state *state)
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1833 {
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1834 struct drm_connector_state *new_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1835 struct drm_crtc_state *new_crtc_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1836 struct drm_connector_state *old_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1837
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1838 new_state = drm_atomic_get_new_connector_state(state, connector);
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1839 old_state = drm_atomic_get_old_connector_state(state, connector);
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 @1840 new_crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
^^^^^^^^^^^^^^^
Dereference
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1841
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 @1842 if (!(old_state && new_state && new_crtc_state))
^^^^^^^^^
Checked too late
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1843 return 0;
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1844
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1845 if (!new_state->crtc)
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1846 return 0;
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1847
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1848 if (old_state->tv.mode != new_state->tv.mode ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1849 old_state->tv.margins.left != new_state->tv.margins.left ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1850 old_state->tv.margins.right != new_state->tv.margins.right ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1851 old_state->tv.margins.top != new_state->tv.margins.top ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1852 old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1853 /* Force a modeset. */
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1854
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1855 new_crtc_state->connectors_changed = true;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1856 }
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1857
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1858 return 0;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1859 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40662 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null
@ 2020-08-25 9:31 ` Dan Carpenter
0 siblings, 0 replies; 23+ messages in thread
From: Dan Carpenter @ 2020-08-25 9:31 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5124 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-m021-20200824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_tv.c:1842 intel_tv_atomic_check() warn: variable dereferenced before check 'new_state' (see line 1840)
# https://github.com/0day-ci/linux/commit/6fb528c1b424d3c8095085afa7e777ac5502450b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 6fb528c1b424d3c8095085afa7e777ac5502450b
vim +/new_state +1842 drivers/gpu/drm/i915/display/intel_tv.c
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1831 static int intel_tv_atomic_check(struct drm_connector *connector,
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1832 struct drm_atomic_state *state)
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1833 {
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1834 struct drm_connector_state *new_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1835 struct drm_crtc_state *new_crtc_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1836 struct drm_connector_state *old_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1837
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1838 new_state = drm_atomic_get_new_connector_state(state, connector);
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1839 old_state = drm_atomic_get_old_connector_state(state, connector);
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 @1840 new_crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
^^^^^^^^^^^^^^^
Dereference
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1841
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 @1842 if (!(old_state && new_state && new_crtc_state))
^^^^^^^^^
Checked too late
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1843 return 0;
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1844
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1845 if (!new_state->crtc)
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1846 return 0;
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1847
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1848 if (old_state->tv.mode != new_state->tv.mode ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1849 old_state->tv.margins.left != new_state->tv.margins.left ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1850 old_state->tv.margins.right != new_state->tv.margins.right ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1851 old_state->tv.margins.top != new_state->tv.margins.top ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1852 old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1853 /* Force a modeset. */
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1854
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1855 new_crtc_state->connectors_changed = true;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1856 }
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1857
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1858 return 0;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1859 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40662 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null
@ 2020-08-25 9:31 ` Dan Carpenter
0 siblings, 0 replies; 23+ messages in thread
From: Dan Carpenter @ 2020-08-25 9:31 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5124 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-m021-20200824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_tv.c:1842 intel_tv_atomic_check() warn: variable dereferenced before check 'new_state' (see line 1840)
# https://github.com/0day-ci/linux/commit/6fb528c1b424d3c8095085afa7e777ac5502450b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 6fb528c1b424d3c8095085afa7e777ac5502450b
vim +/new_state +1842 drivers/gpu/drm/i915/display/intel_tv.c
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1831 static int intel_tv_atomic_check(struct drm_connector *connector,
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1832 struct drm_atomic_state *state)
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1833 {
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1834 struct drm_connector_state *new_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1835 struct drm_crtc_state *new_crtc_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1836 struct drm_connector_state *old_state;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1837
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1838 new_state = drm_atomic_get_new_connector_state(state, connector);
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 1839 old_state = drm_atomic_get_old_connector_state(state, connector);
6f3b62781bbd26 drivers/gpu/drm/i915/intel_tv.c Sean Paul 2019-06-11 @1840 new_crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
^^^^^^^^^^^^^^^
Dereference
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1841
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 @1842 if (!(old_state && new_state && new_crtc_state))
^^^^^^^^^
Checked too late
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1843 return 0;
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1844
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1845 if (!new_state->crtc)
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1846 return 0;
6fb528c1b424d3 drivers/gpu/drm/i915/display/intel_tv.c Nischal Varide 2020-08-19 1847
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1848 if (old_state->tv.mode != new_state->tv.mode ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1849 old_state->tv.margins.left != new_state->tv.margins.left ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1850 old_state->tv.margins.right != new_state->tv.margins.right ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1851 old_state->tv.margins.top != new_state->tv.margins.top ||
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1852 old_state->tv.margins.bottom != new_state->tv.margins.bottom) {
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1853 /* Force a modeset. */
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1854
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1855 new_crtc_state->connectors_changed = true;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1856 }
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1857
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1858 return 0;
0e891b3f447f4d drivers/gpu/drm/i915/intel_tv.c Maarten Lankhorst 2017-04-10 1859 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40662 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
` (2 preceding siblings ...)
2020-08-19 4:34 ` [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null Nischal Varide
@ 2020-08-19 4:34 ` Nischal Varide
2020-08-24 6:27 ` Anshuman Gupta
2020-08-19 11:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Patchwork
` (4 subsequent siblings)
8 siblings, 1 reply; 23+ messages in thread
From: Nischal Varide @ 2020-08-19 4:34 UTC (permalink / raw)
To: intel-gfx, nischal.varide
This Patch fixes the Critical KlockWork Errors and here a Possible Null
Pointer Dereferencing is addressed with a Null Pointer check before
Dereferencing
Signed-off-by: Nischal Varide <nischal.varide@intel.com>
---
drivers/gpu/drm/i915/display/intel_crt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
index 5b4510ce5693..b5777fdc8cac 100644
--- a/drivers/gpu/drm/i915/display/intel_crt.c
+++ b/drivers/gpu/drm/i915/display/intel_crt.c
@@ -504,6 +504,9 @@ static bool valleyview_crt_detect_hotplug(struct drm_connector *connector)
bool ret;
u32 save_adpa;
+ if (!(dev_priv))
+ return false;
+
/*
* Doing a force trigger causes a hpd interrupt to get sent, which can
* get us stuck in a loop if we're polling:
--
2.26.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null
2020-08-19 4:34 ` [Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null Nischal Varide
@ 2020-08-24 6:27 ` Anshuman Gupta
0 siblings, 0 replies; 23+ messages in thread
From: Anshuman Gupta @ 2020-08-24 6:27 UTC (permalink / raw)
To: Nischal Varide; +Cc: intel-gfx
On 2020-08-19 at 10:04:09 +0530, Nischal Varide wrote:
> This Patch fixes the Critical KlockWork Errors and here a Possible Null
> Pointer Dereferencing is addressed with a Null Pointer check before
> Dereferencing
>
> Signed-off-by: Nischal Varide <nischal.varide@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_crt.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
> index 5b4510ce5693..b5777fdc8cac 100644
> --- a/drivers/gpu/drm/i915/display/intel_crt.c
> +++ b/drivers/gpu/drm/i915/display/intel_crt.c
> @@ -504,6 +504,9 @@ static bool valleyview_crt_detect_hotplug(struct drm_connector *connector)
> bool ret;
> u32 save_adpa;
>
> + if (!(dev_priv))
> + return false;
> +
IMHO this should be treated as false alarm, since i915_driver_probe()
has allocated a drm_i915_private i915 priv structure and initilizes drm_dev
at early phase, if any erros over there it will be bailed out at early
stages. IOW to_i915(drm_dev) will never return null.
Thanks,
Anshuman Gupta.
> /*
> * Doing a force trigger causes a hpd interrupt to get sent, which can
> * get us stuck in a loop if we're polling:
> --
> 2.26.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
` (3 preceding siblings ...)
2020-08-19 4:34 ` [Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null Nischal Varide
@ 2020-08-19 11:52 ` Patchwork
2020-08-19 12:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
8 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2020-08-19 11:52 UTC (permalink / raw)
To: Nischal Varide; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
URL : https://patchwork.freedesktop.org/series/80798/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3848eb8cc6ce Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
eb9bd41069a2 Critical-KlockWork-Fixes-intel_display.c-NullDeref
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/i915/display/intel_display.c:2270:
+ vma = i915_gem_object_pin_to_display_plane(obj,
+ alignment, view, pinctl);
-:38: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#38: FILE: drivers/gpu/drm/i915/display/intel_display.c:11273:
+ if (obj) {
+
total: 0 errors, 0 warnings, 2 checks, 41 lines checked
f99675438805 Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null
66e2f48dd7a0 Critical-KlockWork-Fix-intel_tv.c-Possible-Null
75fa8cc3edb3 Critical-KlockWorks-Fix-intel_crt.c-Possible-Null
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
` (4 preceding siblings ...)
2020-08-19 11:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Patchwork
@ 2020-08-19 12:09 ` Patchwork
2020-08-19 18:47 ` kernel test robot
` (2 subsequent siblings)
8 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2020-08-19 12:09 UTC (permalink / raw)
To: Nischal Varide; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4631 bytes --]
== Series Details ==
Series: series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
URL : https://patchwork.freedesktop.org/series/80798/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8907 -> Patchwork_18371
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/index.html
Known issues
------------
Here are the changes found in Patchwork_18371 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html
- fi-bsw-kefka: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][9] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][10] ([i915#62] / [i915#92] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@kms_flip@basic-flip-vs-dpms@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#62] / [i915#92]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][13] ([i915#62] / [i915#92]) -> [DMESG-WARN][14] ([i915#62] / [i915#92] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/fi-kbl-x1275/igt@kms_force_connector_basic@prune-stale-modes.html
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (39 -> 34)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_8907 -> Patchwork_18371
CI-20190529: 20190529
CI_DRM_8907: f9f7b73d0f125316a33e35f3315f3a5955079e33 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18371: 75fa8cc3edb3b94544251d89ce0e8a9899547e3d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
75fa8cc3edb3 Critical-KlockWorks-Fix-intel_crt.c-Possible-Null
66e2f48dd7a0 Critical-KlockWork-Fix-intel_tv.c-Possible-Null
f99675438805 Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null
eb9bd41069a2 Critical-KlockWork-Fixes-intel_display.c-NullDeref
3848eb8cc6ce Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/index.html
[-- Attachment #1.2: Type: text/html, Size: 6443 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
@ 2020-08-19 18:47 ` kernel test robot
2020-08-19 4:34 ` [Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null Nischal Varide
` (7 subsequent siblings)
8 siblings, 0 replies; 23+ messages in thread
From: kernel test robot @ 2020-08-19 18:47 UTC (permalink / raw)
To: Nischal Varide, intel-gfx; +Cc: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-c001-20200818 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/display/intel_atomic.c:199:9-10: WARNING: return of 0/1 in function 'intel_connector_needs_modeset' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34221 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* [Intel-gfx] [PATCH] fix boolreturn.cocci warnings
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
@ 2020-08-19 18:47 ` kernel test robot
2020-08-19 4:34 ` [Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null Nischal Varide
` (7 subsequent siblings)
8 siblings, 0 replies; 23+ messages in thread
From: kernel test robot @ 2020-08-19 18:47 UTC (permalink / raw)
To: Nischal Varide, intel-gfx; +Cc: kbuild-all
From: kernel test robot <lkp@intel.com>
drivers/gpu/drm/i915/display/intel_atomic.c:199:9-10: WARNING: return of 0/1 in function 'intel_connector_needs_modeset' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Nischal Varide <nischal.varide@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
intel_atomic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic.c
@@ -196,7 +196,7 @@ intel_connector_needs_modeset(struct int
old_conn_state = drm_atomic_get_old_connector_state(&state->base, connector);
new_conn_state = drm_atomic_get_new_connector_state(&state->base, connector);
if (!(old_conn_state && new_conn_state))
- return 0;
+ return false;
return old_conn_state->crtc != new_conn_state->crtc ||
(new_conn_state->crtc &&
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
` (7 preceding siblings ...)
2020-08-19 18:47 ` kernel test robot
@ 2020-08-19 22:37 ` Patchwork
8 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2020-08-19 22:37 UTC (permalink / raw)
To: Nischal Varide; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 14757 bytes --]
== Series Details ==
Series: series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull
URL : https://patchwork.freedesktop.org/series/80798/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8907_full -> Patchwork_18371_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18371_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap_gtt@fault-concurrent:
- shard-iclb: [PASS][1] -> [DMESG-WARN][2] ([i915#2165])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-iclb6/igt@gem_mmap_gtt@fault-concurrent.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-iclb6/igt@gem_mmap_gtt@fault-concurrent.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#1436] / [i915#1635] / [i915#716])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-apl6/igt@gen9_exec_parse@allowed-all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-apl7/igt@gen9_exec_parse@allowed-all.html
* igt@i915_module_load@reload:
- shard-iclb: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-iclb6/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-iclb6/igt@i915_module_load@reload.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-glk3/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-glk4/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-hsw4/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible@ab-vga1-hdmi-a1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-hsw1/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible@ab-vga1-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-fences@a-edp1:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +9 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl9/igt@kms_flip@flip-vs-fences@a-edp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl9/igt@kms_flip@flip-vs-fences@a-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl2/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl1/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
* igt@kms_flip_tiling@flip-to-y-tiled:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#167])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl9/igt@kms_flip_tiling@flip-to-y-tiled.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl9/igt@kms_flip_tiling@flip-to-y-tiled.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1188])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][29] -> [FAIL][30] ([i915#1635] / [i915#31])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-apl8/igt@kms_setmode@basic.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-apl1/igt@kms_setmode@basic.html
* igt@prime_mmap_coherency@write:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([i915#1635] / [i915#1982])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-apl8/igt@prime_mmap_coherency@write.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-apl2/igt@prime_mmap_coherency@write.html
#### Possible fixes ####
* {igt@feature_discovery@psr2}:
- shard-iclb: [SKIP][33] ([i915#658]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-iclb4/igt@feature_discovery@psr2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_gttfill@all:
- shard-glk: [DMESG-WARN][35] ([i915#118] / [i915#95]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-glk8/igt@gem_exec_gttfill@all.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-glk8/igt@gem_exec_gttfill@all.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][37] ([i915#1436] / [i915#716]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl7/igt@gen9_exec_parse@allowed-single.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl2/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- shard-skl: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +9 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl2/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl1/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
- shard-tglb: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-tglb5/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-tglb8/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank@bc-vga1-hdmi-a1:
- shard-hsw: [INCOMPLETE][43] ([CI#80]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-hsw4/igt@kms_flip@2x-flip-vs-absolute-wf_vblank@bc-vga1-hdmi-a1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-hsw8/igt@kms_flip@2x-flip-vs-absolute-wf_vblank@bc-vga1-hdmi-a1.html
* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [FAIL][45] ([i915#2122]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-kbl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [INCOMPLETE][49] ([i915#155]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
- shard-skl: [FAIL][51] ([i915#49]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][53] ([fdo#108145] / [i915#265]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf@blocking-parameterized:
- shard-iclb: [FAIL][59] ([i915#1542]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-iclb4/igt@perf@blocking-parameterized.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-iclb2/igt@perf@blocking-parameterized.html
* igt@prime_busy@after@vecs0:
- shard-hsw: [FAIL][61] ([i915#2258]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-hsw1/igt@prime_busy@after@vecs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-hsw4/igt@prime_busy@after@vecs0.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][63] ([i915#658]) -> [SKIP][64] ([i915#588])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8907/shard-iclb4/igt@i915_pm_dc@dc3co-vpb-simulation.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#167]: https://gitlab.freedesktop.org/drm/intel/issues/167
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2165]: https://gitlab.freedesktop.org/drm/intel/issues/2165
[i915#2258]: https://gitlab.freedesktop.org/drm/intel/issues/2258
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8907 -> Patchwork_18371
CI-20190529: 20190529
CI_DRM_8907: f9f7b73d0f125316a33e35f3315f3a5955079e33 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5769: 4e5f76be680b65780204668e302026cf638decc9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18371: 75fa8cc3edb3b94544251d89ce0e8a9899547e3d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18371/index.html
[-- Attachment #1.2: Type: text/html, Size: 17350 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
@ 2020-08-24 21:51 kernel test robot
0 siblings, 0 replies; 23+ messages in thread
From: kernel test robot @ 2020-08-24 21:51 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 15307 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200819043409.26010-2-nischal.varide@intel.com>
References: <20200819043409.26010-2-nischal.varide@intel.com>
TO: Nischal Varide <nischal.varide@intel.com>
TO: intel-gfx(a)lists.freedesktop.org
TO: nischal.varide(a)intel.com
Hi Nischal,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.9-rc2 next-20200824]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base: git://anongit.freedesktop.org/drm-intel for-linux-next
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: i386-randconfig-m021-20200824 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:2271 intel_pin_and_fence_fb_obj() error: uninitialized symbol 'vma'.
drivers/gpu/drm/i915/display/intel_display.c:11280 intel_cursor_base() error: uninitialized symbol 'base'.
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:6183 skl_update_scaler_plane() error: we previously assumed 'fb' could be null (see line 6167)
drivers/gpu/drm/i915/display/intel_display.c:16655 intel_crtc_init() warn: passing a valid pointer to 'PTR_ERR'
# https://github.com/0day-ci/linux/commit/5d862961b8571914f726e947570316016ec67c5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 5d862961b8571914f726e947570316016ec67c5d
vim +/vma +2271 drivers/gpu/drm/i915/display/intel_display.c
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2216
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2217 struct i915_vma *
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2218 intel_pin_and_fence_fb_obj(struct drm_framebuffer *fb,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2219 const struct i915_ggtt_view *view,
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2220 bool uses_fence,
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2221 unsigned long *out_flags)
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2222 {
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2223 struct drm_device *dev = fb->dev;
fac5e23e3c385f drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-07-04 2224 struct drm_i915_private *dev_priv = to_i915(dev);
850c4cdc6c223d drivers/gpu/drm/i915/intel_display.c Tvrtko Ursulin 2014-10-30 2225 struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1d264d91befc31 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2019-01-14 2226 intel_wakeref_t wakeref;
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2227 struct i915_vma *vma;
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2228 unsigned int pinctl;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2229 u32 alignment;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2230
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2231 if (drm_WARN_ON(dev, !i915_gem_object_is_framebuffer(obj)))
5a90606df7cb73 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-09-02 2232 return ERR_PTR(-EINVAL);
ebcdd39eafb1d8 drivers/gpu/drm/i915/intel_display.c Matt Roper 2014-07-09 2233
d88c4afddc5519 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2017-03-07 2234 alignment = intel_surf_alignment(fb, 0);
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 2235 if (drm_WARN_ON(dev, alignment && !is_power_of_2(alignment)))
7361bdb26c2ca6 drivers/gpu/drm/i915/display/intel_display.c Imre Deak 2019-12-25 2236 return ERR_PTR(-EINVAL);
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2237
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2238 /* Note that the w/a also requires 64 PTE of padding following the
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2239 * bo. We currently fill all unused PTE with the shadow page and so
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2240 * we should always have valid PTE following the scanout preventing
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2241 * the VT-d warning.
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2242 */
48f112fed3b078 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-06-24 2243 if (intel_scanout_needs_vtd_wa(dev_priv) && alignment < 256 * 1024)
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2244 alignment = 256 * 1024;
693db1842d864c drivers/gpu/drm/i915/intel_display.c Chris Wilson 2013-03-05 2245
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2246 /*
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2247 * Global gtt pte registers are special registers which actually forward
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2248 * writes to a chunk of system memory. Which means that there is no risk
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2249 * that the register values disappear as soon as we call
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2250 * intel_runtime_pm_put(), so it is correct to wrap only the
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2251 * pin/unpin/fence and not more.
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2252 */
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2253 wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
d6dd6843ff4a57 drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2014-08-15 2254
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2255 atomic_inc(&dev_priv->gpu_error.pending_fb_pin);
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2256
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2257 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2258 * Valleyview is definitely limited to scanning out the first
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2259 * 512MiB. Lets presume this behaviour was inherited from the
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2260 * g4x display engine and that all earlier gen are similarly
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2261 * limited. Testing suggests that it is a little more
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2262 * complicated than this. For example, Cherryview appears quite
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2263 * happy to scanout from anywhere within its global aperture.
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2264 */
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2265 pinctl = 0;
b2ae318acdcaf1 drivers/gpu/drm/i915/intel_display.c Rodrigo Vivi 2019-02-04 2266 if (HAS_GMCH(dev_priv))
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2267 pinctl |= PIN_MAPPABLE;
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide 2020-08-19 2268 if (obj)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2269 vma = i915_gem_object_pin_to_display_plane(obj,
f5929c5309a6a4 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-09-07 2270 alignment, view, pinctl);
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 @2271 if (IS_ERR(vma))
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2272 goto err;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2273
f7a02ad7d16b24 drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2274 if (uses_fence && i915_vma_is_map_and_fenceable(vma)) {
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2275 int ret;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2276
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2277 /*
8b1c78e06e6167 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson 2019-12-06 2278 * Install a fence for tiled scan-out. Pre-i965 always needs a
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2279 * fence, whereas 965+ only requires a fence if using
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2280 * framebuffer compression. For simplicity, we always, when
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2281 * possible, install a fence as the cost is not that onerous.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2282 *
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2283 * If we fail to fence the tiled scanout, then either the
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2284 * modeset will reject the change (which is highly unlikely as
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2285 * the affected systems, all but one, do not have unmappable
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2286 * space) or we will not be able to enable full powersaving
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2287 * techniques (also likely not to apply due to various limits
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2288 * FBC and the like impose on the size of the buffer, which
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2289 * presumably we violated anyway with this unmappable buffer).
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2290 * Anyway, it is presumably better to stumble onwards with
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2291 * something and try to run the system in a "less than optimal"
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2292 * mode that matches the user configuration.
842315ee7e416f drivers/gpu/drm/i915/intel_display.c Maarten Lankhorst 2015-08-05 2293 */
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2294 ret = i915_vma_pin_fence(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2295 if (ret != 0 && INTEL_GEN(dev_priv) < 4) {
7509702bd8bd09 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-03-05 2296 i915_gem_object_unpin_from_display_plane(vma);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2297 vma = ERR_PTR(ret);
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2298 goto err;
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2299 }
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2300
85798ac9b35f8c drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2018-02-21 2301 if (ret == 0 && vma->fence)
5935485f8eee35 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2018-02-20 2302 *out_flags |= PLANE_HAS_FENCE;
9807216f585fc6 drivers/gpu/drm/i915/intel_display.c Vivek Kasireddy 2015-10-29 2303 }
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2304
be1e341513ca23 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2017-01-16 2305 i915_vma_get(vma);
49ef5294cda256 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-18 2306 err:
9db529aac9381e drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2017-08-08 2307 atomic_dec(&dev_priv->gpu_error.pending_fb_pin);
d858d5695f3897 drivers/gpu/drm/i915/intel_display.c Daniele Ceraolo Spurio 2019-06-13 2308 intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
058d88c4330f96 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2016-08-15 2309 return vma;
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2310 }
6b95a207c1fd55 drivers/gpu/drm/i915/intel_display.c Kristian Høgsberg 2009-11-18 2311
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40662 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2020-08-25 9:34 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
2020-08-19 4:34 ` [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref Nischal Varide
2020-08-20 3:24 ` kernel test robot
2020-08-20 3:24 ` kernel test robot
2020-08-25 9:25 ` Dan Carpenter
2020-08-25 9:25 ` Dan Carpenter
2020-08-25 9:25 ` Dan Carpenter
2020-08-19 4:34 ` [Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null Nischal Varide
2020-08-19 4:34 ` [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null Nischal Varide
2020-08-24 6:32 ` Anshuman Gupta
2020-08-25 9:31 ` Dan Carpenter
2020-08-25 9:31 ` Dan Carpenter
2020-08-25 9:31 ` Dan Carpenter
2020-08-19 4:34 ` [Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null Nischal Varide
2020-08-24 6:27 ` Anshuman Gupta
2020-08-19 11:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Patchwork
2020-08-19 12:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-19 18:47 ` [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull kernel test robot
2020-08-19 18:47 ` kernel test robot
2020-08-19 18:47 ` [Intel-gfx] [PATCH] fix boolreturn.cocci warnings kernel test robot
2020-08-19 18:47 ` kernel test robot
2020-08-19 22:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Patchwork
2020-08-24 21:51 [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.