Re: [PATCH] mmc: sdhci-acpi: Fix HS400 tuning for AMDI0040

From: kernel test robot <lkp@intel.com>
To: Raul E Rangel <rrangel@chromium.org>, adrian.hunter@intel.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	Nehal-bakulchandra.Shah@amd.com, chris.wang@amd.com,
	Akshu.Agrawal@amd.com, Raul E Rangel <rrangel@chromium.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-acpi: Fix HS400 tuning for AMDI0040
Date: Wed, 19 Aug 2020 14:01:41 +0800	[thread overview]
Message-ID: <202008191332.Grwknflp%lkp@intel.com> (raw)
In-Reply-To: <20200818162900.1.Ie8f0689ec9f449203328b37409d1cf06b565f331@changeid>

[-- Attachment #1: Type: text/plain, Size: 2797 bytes --]

Hi Raul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc1 next-20200818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Raul-E-Rangel/mmc-sdhci-acpi-Fix-HS400-tuning-for-AMDI0040/20200819-063255
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 18445bf405cb331117bc98427b1ba6f12418ad17
config: x86_64-randconfig-a003-20200818 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b34b1e38381fa4d1b1d9751a6b5233b68e734cfe)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/mmc/host/sdhci-acpi.c:607:5: warning: no previous prototype for function 'amd_sdhci_execute_tuning' [-Wmissing-prototypes]
   int amd_sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
       ^
   drivers/mmc/host/sdhci-acpi.c:607:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int amd_sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
   ^
   static 
   1 warning generated.

# https://github.com/0day-ci/linux/commit/dcfd321141ed51cca9f8a3262895bd8df1739f41
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Raul-E-Rangel/mmc-sdhci-acpi-Fix-HS400-tuning-for-AMDI0040/20200819-063255
git checkout dcfd321141ed51cca9f8a3262895bd8df1739f41
vim +/amd_sdhci_execute_tuning +607 drivers/mmc/host/sdhci-acpi.c

   606	
 > 607	int amd_sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
   608	{
   609		int err;
   610		struct sdhci_host *host = mmc_priv(mmc);
   611		struct sdhci_acpi_host *acpi_host = sdhci_priv(host);
   612		struct amd_sdhci_host *amd_host = sdhci_acpi_priv(acpi_host);
   613	
   614		amd_host->tuned_clock = false;
   615	
   616		err = sdhci_execute_tuning(mmc, opcode);
   617	
   618		if (!err && !host->tuning_err)
   619			amd_host->tuned_clock = true;
   620	
   621		return err;
   622	}
   623	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 46904 bytes --]