* [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS
@ 2020-08-19 10:23 Veronika Kabatova
2020-08-19 11:49 ` Jesper Dangaard Brouer
2020-08-19 15:36 ` Yonghong Song
0 siblings, 2 replies; 4+ messages in thread
From: Veronika Kabatova @ 2020-08-19 10:23 UTC (permalink / raw)
To: bpf; +Cc: sdf, andriin, skozina, brouer, Veronika Kabatova
Calling generic selftests "make install" fails as rsync expects all
files from TEST_GEN_PROGS to be present. The binary is not generated
anymore (commit 3b09d27cc93d) so we can safely remove it from there.
Fixes: 3b09d27cc93d ("selftests/bpf: Move test_align under test_progs")
Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
---
tools/testing/selftests/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index a83b5827532f..fc946b7ac288 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -32,7 +32,7 @@ LDLIBS += -lcap -lelf -lz -lrt -lpthread
# Order correspond to 'make run_tests' order
TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test_progs \
- test_align test_verifier_log test_dev_cgroup test_tcpbpf_user \
+ test_verifier_log test_dev_cgroup test_tcpbpf_user \
test_sock test_btf test_sockmap get_cgroup_id_user test_socket_cookie \
test_cgroup_storage \
test_netcnt test_tcpnotify_user test_sock_fields test_sysctl \
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS
2020-08-19 10:23 [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS Veronika Kabatova
@ 2020-08-19 11:49 ` Jesper Dangaard Brouer
2020-08-19 15:36 ` Yonghong Song
1 sibling, 0 replies; 4+ messages in thread
From: Jesper Dangaard Brouer @ 2020-08-19 11:49 UTC (permalink / raw)
To: Veronika Kabatova; +Cc: bpf, sdf, andriin, skozina, brouer
On Wed, 19 Aug 2020 12:23:54 +0200
Veronika Kabatova <vkabatov@redhat.com> wrote:
> Calling generic selftests "make install" fails as rsync expects all
> files from TEST_GEN_PROGS to be present. The binary is not generated
> anymore (commit 3b09d27cc93d) so we can safely remove it from there.
>
> Fixes: 3b09d27cc93d ("selftests/bpf: Move test_align under test_progs")
> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> ---
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS
2020-08-19 10:23 [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS Veronika Kabatova
2020-08-19 11:49 ` Jesper Dangaard Brouer
@ 2020-08-19 15:36 ` Yonghong Song
2020-08-19 15:57 ` Veronika Kabatova
1 sibling, 1 reply; 4+ messages in thread
From: Yonghong Song @ 2020-08-19 15:36 UTC (permalink / raw)
To: Veronika Kabatova, bpf; +Cc: sdf, andriin, skozina, brouer
On 8/19/20 3:23 AM, Veronika Kabatova wrote:
> Calling generic selftests "make install" fails as rsync expects all
> files from TEST_GEN_PROGS to be present. The binary is not generated
> anymore (commit 3b09d27cc93d) so we can safely remove it from there.
>
> Fixes: 3b09d27cc93d ("selftests/bpf: Move test_align under test_progs")
> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
Could you remove 'test_align' for .gitignore as well? With this,
Acked-by: Yonghong Song <yhs@fb.com>
> ---
> tools/testing/selftests/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index a83b5827532f..fc946b7ac288 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -32,7 +32,7 @@ LDLIBS += -lcap -lelf -lz -lrt -lpthread
>
> # Order correspond to 'make run_tests' order
> TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test_progs \
> - test_align test_verifier_log test_dev_cgroup test_tcpbpf_user \
> + test_verifier_log test_dev_cgroup test_tcpbpf_user \
> test_sock test_btf test_sockmap get_cgroup_id_user test_socket_cookie \
> test_cgroup_storage \
> test_netcnt test_tcpnotify_user test_sock_fields test_sysctl \
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS
2020-08-19 15:36 ` Yonghong Song
@ 2020-08-19 15:57 ` Veronika Kabatova
0 siblings, 0 replies; 4+ messages in thread
From: Veronika Kabatova @ 2020-08-19 15:57 UTC (permalink / raw)
To: Yonghong Song; +Cc: bpf, sdf, andriin, skozina, brouer
----- Original Message -----
> From: "Yonghong Song" <yhs@fb.com>
> To: "Veronika Kabatova" <vkabatov@redhat.com>, bpf@vger.kernel.org
> Cc: sdf@google.com, andriin@fb.com, skozina@redhat.com, brouer@redhat.com
> Sent: Wednesday, August 19, 2020 5:36:01 PM
> Subject: Re: [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS
>
>
>
> On 8/19/20 3:23 AM, Veronika Kabatova wrote:
> > Calling generic selftests "make install" fails as rsync expects all
> > files from TEST_GEN_PROGS to be present. The binary is not generated
> > anymore (commit 3b09d27cc93d) so we can safely remove it from there.
> >
> > Fixes: 3b09d27cc93d ("selftests/bpf: Move test_align under test_progs")
> > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
>
> Could you remove 'test_align' for .gitignore as well? With this,
> Acked-by: Yonghong Song <yhs@fb.com>
>
Good idea. Will send a v2 soon.
Veronika
> > ---
> > tools/testing/selftests/bpf/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/Makefile
> > b/tools/testing/selftests/bpf/Makefile
> > index a83b5827532f..fc946b7ac288 100644
> > --- a/tools/testing/selftests/bpf/Makefile
> > +++ b/tools/testing/selftests/bpf/Makefile
> > @@ -32,7 +32,7 @@ LDLIBS += -lcap -lelf -lz -lrt -lpthread
> >
> > # Order correspond to 'make run_tests' order
> > TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map
> > test_lpm_map test_progs \
> > - test_align test_verifier_log test_dev_cgroup test_tcpbpf_user \
> > + test_verifier_log test_dev_cgroup test_tcpbpf_user \
> > test_sock test_btf test_sockmap get_cgroup_id_user test_socket_cookie \
> > test_cgroup_storage \
> > test_netcnt test_tcpnotify_user test_sock_fields test_sysctl \
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-19 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 10:23 [PATCH] selftests/bpf: Remove test_align from TEST_GEN_PROGS Veronika Kabatova
2020-08-19 11:49 ` Jesper Dangaard Brouer
2020-08-19 15:36 ` Yonghong Song
2020-08-19 15:57 ` Veronika Kabatova
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.