All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly
@ 2020-08-19 14:37 ` Nadezda Lutovinova
  0 siblings, 0 replies; 4+ messages in thread
From: Nadezda Lutovinova @ 2020-08-19 14:37 UTC (permalink / raw)
  To: Peter Senna Tschudin
  Cc: Nadezda Lutovinova, Martin Donnelly, Martyn Welch, Andrzej Hajda,
	Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
	David Airlie, Daniel Vetter, dri-devel, linux-kernel,
	ldv-project

If ge_b850v3_lvds_init() does not allocate memory for ge_b850v3_lvds_ptr,
then a null pointer dereference is accessed.

The patch adds checking of the return value of ge_b850v3_lvds_init().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
---
 drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
index 6200f12..ab81748 100644
--- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
+++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
@@ -302,8 +302,12 @@ static int stdp4028_ge_b850v3_fw_probe(struct i2c_client *stdp4028_i2c,
 				       const struct i2c_device_id *id)
 {
 	struct device *dev = &stdp4028_i2c->dev;
+	int ret;
+
+	ret = ge_b850v3_lvds_init(dev);
 
-	ge_b850v3_lvds_init(dev);
+	if (ret)
+		return ret;
 
 	ge_b850v3_lvds_ptr->stdp4028_i2c = stdp4028_i2c;
 	i2c_set_clientdata(stdp4028_i2c, ge_b850v3_lvds_ptr);
@@ -361,8 +365,12 @@ static int stdp2690_ge_b850v3_fw_probe(struct i2c_client *stdp2690_i2c,
 				       const struct i2c_device_id *id)
 {
 	struct device *dev = &stdp2690_i2c->dev;
+	int ret;
+
+	ret = ge_b850v3_lvds_init(dev);
 
-	ge_b850v3_lvds_init(dev);
+	if (ret)
+		return ret;
 
 	ge_b850v3_lvds_ptr->stdp2690_i2c = stdp2690_i2c;
 	i2c_set_clientdata(stdp2690_i2c, ge_b850v3_lvds_ptr);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly
@ 2020-08-19 14:37 ` Nadezda Lutovinova
  0 siblings, 0 replies; 4+ messages in thread
From: Nadezda Lutovinova @ 2020-08-19 14:37 UTC (permalink / raw)
  To: Peter Senna Tschudin
  Cc: Nadezda Lutovinova, ldv-project, Jernej Skrabec, Martyn Welch,
	Neil Armstrong, David Airlie, Jonas Karlman, linux-kernel,
	dri-devel, Andrzej Hajda, Laurent Pinchart, Martin Donnelly

If ge_b850v3_lvds_init() does not allocate memory for ge_b850v3_lvds_ptr,
then a null pointer dereference is accessed.

The patch adds checking of the return value of ge_b850v3_lvds_init().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
---
 drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
index 6200f12..ab81748 100644
--- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
+++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
@@ -302,8 +302,12 @@ static int stdp4028_ge_b850v3_fw_probe(struct i2c_client *stdp4028_i2c,
 				       const struct i2c_device_id *id)
 {
 	struct device *dev = &stdp4028_i2c->dev;
+	int ret;
+
+	ret = ge_b850v3_lvds_init(dev);
 
-	ge_b850v3_lvds_init(dev);
+	if (ret)
+		return ret;
 
 	ge_b850v3_lvds_ptr->stdp4028_i2c = stdp4028_i2c;
 	i2c_set_clientdata(stdp4028_i2c, ge_b850v3_lvds_ptr);
@@ -361,8 +365,12 @@ static int stdp2690_ge_b850v3_fw_probe(struct i2c_client *stdp2690_i2c,
 				       const struct i2c_device_id *id)
 {
 	struct device *dev = &stdp2690_i2c->dev;
+	int ret;
+
+	ret = ge_b850v3_lvds_init(dev);
 
-	ge_b850v3_lvds_init(dev);
+	if (ret)
+		return ret;
 
 	ge_b850v3_lvds_ptr->stdp2690_i2c = stdp2690_i2c;
 	i2c_set_clientdata(stdp2690_i2c, ge_b850v3_lvds_ptr);
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly
  2020-08-19 14:37 ` Nadezda Lutovinova
@ 2020-08-23 15:10   ` Sam Ravnborg
  -1 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2020-08-23 15:10 UTC (permalink / raw)
  To: Nadezda Lutovinova
  Cc: Peter Senna Tschudin, ldv-project, Jernej Skrabec, Martyn Welch,
	Neil Armstrong, David Airlie, Jonas Karlman, linux-kernel,
	dri-devel, Andrzej Hajda, Laurent Pinchart, Martin Donnelly

Hi Nadezda

On Wed, Aug 19, 2020 at 05:37:56PM +0300, Nadezda Lutovinova wrote:
> If ge_b850v3_lvds_init() does not allocate memory for ge_b850v3_lvds_ptr,
> then a null pointer dereference is accessed.
> 
> The patch adds checking of the return value of ge_b850v3_lvds_init().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>

Thanks, applied to drm-misc-next, so it will hit upstream during the
next merge window.

	Sam

> ---
>  drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
> index 6200f12..ab81748 100644
> --- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
> +++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
> @@ -302,8 +302,12 @@ static int stdp4028_ge_b850v3_fw_probe(struct i2c_client *stdp4028_i2c,
>  				       const struct i2c_device_id *id)
>  {
>  	struct device *dev = &stdp4028_i2c->dev;
> +	int ret;
> +
> +	ret = ge_b850v3_lvds_init(dev);
>  
> -	ge_b850v3_lvds_init(dev);
> +	if (ret)
> +		return ret;
>  
>  	ge_b850v3_lvds_ptr->stdp4028_i2c = stdp4028_i2c;
>  	i2c_set_clientdata(stdp4028_i2c, ge_b850v3_lvds_ptr);
> @@ -361,8 +365,12 @@ static int stdp2690_ge_b850v3_fw_probe(struct i2c_client *stdp2690_i2c,
>  				       const struct i2c_device_id *id)
>  {
>  	struct device *dev = &stdp2690_i2c->dev;
> +	int ret;
> +
> +	ret = ge_b850v3_lvds_init(dev);
>  
> -	ge_b850v3_lvds_init(dev);
> +	if (ret)
> +		return ret;
>  
>  	ge_b850v3_lvds_ptr->stdp2690_i2c = stdp2690_i2c;
>  	i2c_set_clientdata(stdp2690_i2c, ge_b850v3_lvds_ptr);
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly
@ 2020-08-23 15:10   ` Sam Ravnborg
  0 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2020-08-23 15:10 UTC (permalink / raw)
  To: Nadezda Lutovinova
  Cc: ldv-project, Jernej Skrabec, Martyn Welch, Neil Armstrong,
	David Airlie, Peter Senna Tschudin, linux-kernel, dri-devel,
	Andrzej Hajda, Jonas Karlman, Laurent Pinchart, Martin Donnelly

Hi Nadezda

On Wed, Aug 19, 2020 at 05:37:56PM +0300, Nadezda Lutovinova wrote:
> If ge_b850v3_lvds_init() does not allocate memory for ge_b850v3_lvds_ptr,
> then a null pointer dereference is accessed.
> 
> The patch adds checking of the return value of ge_b850v3_lvds_init().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>

Thanks, applied to drm-misc-next, so it will hit upstream during the
next merge window.

	Sam

> ---
>  drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
> index 6200f12..ab81748 100644
> --- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
> +++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c
> @@ -302,8 +302,12 @@ static int stdp4028_ge_b850v3_fw_probe(struct i2c_client *stdp4028_i2c,
>  				       const struct i2c_device_id *id)
>  {
>  	struct device *dev = &stdp4028_i2c->dev;
> +	int ret;
> +
> +	ret = ge_b850v3_lvds_init(dev);
>  
> -	ge_b850v3_lvds_init(dev);
> +	if (ret)
> +		return ret;
>  
>  	ge_b850v3_lvds_ptr->stdp4028_i2c = stdp4028_i2c;
>  	i2c_set_clientdata(stdp4028_i2c, ge_b850v3_lvds_ptr);
> @@ -361,8 +365,12 @@ static int stdp2690_ge_b850v3_fw_probe(struct i2c_client *stdp2690_i2c,
>  				       const struct i2c_device_id *id)
>  {
>  	struct device *dev = &stdp2690_i2c->dev;
> +	int ret;
> +
> +	ret = ge_b850v3_lvds_init(dev);
>  
> -	ge_b850v3_lvds_init(dev);
> +	if (ret)
> +		return ret;
>  
>  	ge_b850v3_lvds_ptr->stdp2690_i2c = stdp2690_i2c;
>  	i2c_set_clientdata(stdp2690_i2c, ge_b850v3_lvds_ptr);
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-23 15:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 14:37 [PATCH] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly Nadezda Lutovinova
2020-08-19 14:37 ` Nadezda Lutovinova
2020-08-23 15:10 ` Sam Ravnborg
2020-08-23 15:10   ` Sam Ravnborg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.